Drew Jaynes
9351a7c9ff
Docs: Add a missing DocBlock for the private `_add_themes_utility_last()` function.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36471
git-svn-id: http://core.svn.wordpress.org/trunk@36438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-03 20:07:27 +00:00
Dominik Schilling
72c6f7f86f
Suppress possible warnings in PHP < 5.3.3 by `parse_url()` in `wp_validate_redirect()`.
...
PHP 5.3.3 removed the E_WARNING that was emitted when URL parsing failed.
Built from https://develop.svn.wordpress.org/trunk@36446
git-svn-id: http://core.svn.wordpress.org/trunk@36413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 16:34:27 +00:00
Aaron Jorbin
5c4031dd84
Revert [35792]
...
This causes a regression and causes redirects to potentially fail.
See #5114 #34028
props ocean90
Built from https://develop.svn.wordpress.org/trunk@36445
git-svn-id: http://core.svn.wordpress.org/trunk@36412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 16:24:26 +00:00
Dominik Schilling
361ed7a3d6
Better validation of the URL used in HTTP redirects.
...
Built from https://develop.svn.wordpress.org/trunk@36444
git-svn-id: http://core.svn.wordpress.org/trunk@36411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 15:11:28 +00:00
Dominik Schilling
f65de8ec9f
HTTP: `0.1.2.3` is not a valid IP.
...
Built from https://develop.svn.wordpress.org/trunk@36435
git-svn-id: http://core.svn.wordpress.org/trunk@36402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 12:55:29 +00:00
Gary Pendergast
e19a8796fd
Database: Allow loading when only the `mysqlnd` extension is loaded.
...
We do an early check for a mysql extension being loaded, but it fails if the `mysqlnd` extension is the only one present.
Props nexurium.
Fixes #33261 .
Built from https://develop.svn.wordpress.org/trunk@36434
git-svn-id: http://core.svn.wordpress.org/trunk@36401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 00:59:25 +00:00
Gary Pendergast
5779ed9d8a
WPDB: Add a `close()` method to `wpdb`, for when the connection needs to be manually closed.
...
In the event that it was closed prematurely, `wpdb::query()` will re-open the connection automatically.
Fixes #34903 .
Built from https://develop.svn.wordpress.org/trunk@36433
git-svn-id: http://core.svn.wordpress.org/trunk@36400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 00:13:26 +00:00
Weston Ruter
9f7d608a6a
Customizer: Fix searching for available nav menu items by updating reference to nonce.
...
Fixes regression introduced in [36414] where the nonce for listing available nav menu items was updated to use the new centralized location at `wp.customize.settings.nonce`, but the nonce for search did not get updated.
See #35617 .
Built from https://develop.svn.wordpress.org/trunk@36432
git-svn-id: http://core.svn.wordpress.org/trunk@36399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-01 21:36:28 +00:00
Dominik Schilling
cd892b86b4
Media: In `wp_read_image_metadata()` make sure that IPTC keywords are UTF8 encoded.
...
Prevents missing `_wp_attachment_metadata` when an image contains keywords with latin extended characters.
Fixes #35316 .
Built from https://develop.svn.wordpress.org/trunk@36429
git-svn-id: http://core.svn.wordpress.org/trunk@36396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-01 14:53:27 +00:00
Andrea Fercia
c9e5edd637
Menus: Avoid displaying two spinners when adding selected menu items.
...
Fixes #35682 .
Built from https://develop.svn.wordpress.org/trunk@36427
git-svn-id: http://core.svn.wordpress.org/trunk@36394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-31 18:06:27 +00:00
Andrea Fercia
82f59fc6ef
Menus: after [36379] prevent "Quick Search" form submission when pressing Enter.
...
Fixes #35374 .
Built from https://develop.svn.wordpress.org/trunk@36426
git-svn-id: http://core.svn.wordpress.org/trunk@36393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-31 14:03:27 +00:00
Rachel Baker
2573fa7ab8
Comments: Add back `$req` variable in `comments_template()`.
...
The variables in `comments_template()` should never be assumed to be unused. This function includes the `comments.php` template file from the active theme or falls back to `theme-compat/comments.php`. This is why including a file within a function only brings pain and sorrow.
Reverts r36322.
See #35473 .
Built from https://develop.svn.wordpress.org/trunk@36425
git-svn-id: http://core.svn.wordpress.org/trunk@36392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-30 22:13:26 +00:00
Rachel Baker
099b35933d
Comments: Add a back link to `wp_die()` comment form submission error display.
...
Fixes #4332 .
Props wonderboymusic, westonruter, shamess, rachelbaker.
Built from https://develop.svn.wordpress.org/trunk@36424
git-svn-id: http://core.svn.wordpress.org/trunk@36391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-30 21:56:27 +00:00
Andrea Fercia
98518bdd4d
Install: Improve the install page language chooser button style.
...
Fixes #34547 .
Built from https://develop.svn.wordpress.org/trunk@36423
git-svn-id: http://core.svn.wordpress.org/trunk@36390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-30 14:53:26 +00:00
Andrea Fercia
62d8fda8dd
After [36171] remove all the occurrences of the old CSS clearfix.
...
The old clearfix was applied to very specific items and defined multiple times
across CSS files. Uses the new generic `.wp-clearfix` utility class instead.
See #26396 .
Built from https://develop.svn.wordpress.org/trunk@36422
git-svn-id: http://core.svn.wordpress.org/trunk@36389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-30 13:46:27 +00:00
Dion Hulse
1abb98520b
Update Random_Compat to the latest version (1.1.6).
...
See #35665
Built from https://develop.svn.wordpress.org/trunk@36421
git-svn-id: http://core.svn.wordpress.org/trunk@36388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-30 00:57:28 +00:00
Boone Gorges
bb6a068e29
Simplify action placement in `update_metadata()`.
...
By combining a number of `foreach` loops, we make the code more readable and
potentially faster in the case where many metadata rows are being updated.
Props Shelob9.
Fixes #35652 .
Built from https://develop.svn.wordpress.org/trunk@36420
git-svn-id: http://core.svn.wordpress.org/trunk@36387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-29 04:52:28 +00:00
Dion Hulse
34b9af6efd
Menus: Remove a redundant and unused `0` parameter from the `Delete Menu` link on the nav menus admin screen.
...
Fixes #35641 .
Built from https://develop.svn.wordpress.org/trunk@36419
git-svn-id: http://core.svn.wordpress.org/trunk@36386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-28 06:14:25 +00:00
Boone Gorges
4b4978ecbd
Pass additional params to 'get_archive_links' filter.
...
Props sebastian.pisula.
Fixes #35573 .
Built from https://develop.svn.wordpress.org/trunk@36418
git-svn-id: http://core.svn.wordpress.org/trunk@36385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-28 04:46:26 +00:00
Eric Lewis
24adb71a56
Networks and sites: Replace "blog" usage with "site" in docs.
...
Multisite functions use the term "blog" to refer to what we now call a "site," e.g. `get_current_blog_id()`. These functions are here to stay because of our commitment to backwards compatibility. What we can do is set the documentation straight.
See #35417 .
Built from https://develop.svn.wordpress.org/trunk@36417
git-svn-id: http://core.svn.wordpress.org/trunk@36384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-28 03:51:26 +00:00
Eric Lewis
22467e840f
Networks and sites: Replace "blog" usage with "site" in docs.
...
Multisite functions use the term "blog" to refer to what we now call a "site," e.g. `get_current_blog_id()`. These functions are here to stay because of our commitment to backwards compatibility. What we can do is set the documentation straight.
See #35417 .
Built from https://develop.svn.wordpress.org/trunk@36416
git-svn-id: http://core.svn.wordpress.org/trunk@36383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-28 03:35:27 +00:00
Boone Gorges
af34d4f296
Fix set up/tear down of post types in comment query test.
...
Introduced in [31015].
Props kouratoras.
Fixes #35633 .
Built from https://develop.svn.wordpress.org/trunk@36415
git-svn-id: http://core.svn.wordpress.org/trunk@36382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-27 23:13:27 +00:00
Weston Ruter
c376477265
Customizer: Export `nonce`, `theme`, and `url` app settings in preview as exported in pane.
...
* Introduce `WP_Customize_Manager::get_nonces()` to consolidate logic for retrieving nonces.
* Export nonces centrally in `wp.customize.settings.nonce` with each request and update nav menus preview to utilize.
* Send updated nonces to preview upon `nonce-refresh`.
* Request full preview refresh if Nav Menu selective refresh request fails (e.g. due to bad nonce).
* Update nav menus and widgets in Customizer to utilize `customize_refresh_nonces` for exporting nonces and keeping them up to date.
See #27355 .
Fixes #35617 .
Built from https://develop.svn.wordpress.org/trunk@36414
git-svn-id: http://core.svn.wordpress.org/trunk@36381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-27 17:55:26 +00:00
Dominik Schilling
e8cc1b5a32
Multisite: Add the global cache group `sites` to `restore_current_blog()` and `wp_start_object_cache()`.
...
See #32450 .
Built from https://develop.svn.wordpress.org/trunk@36413
git-svn-id: http://core.svn.wordpress.org/trunk@36380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-27 13:51:26 +00:00
Dominik Schilling
87b5e06838
Multisite: Add the global cache group `networks` to `restore_current_blog()`.
...
Missed in [36258].
See #35251 .
Built from https://develop.svn.wordpress.org/trunk@36411
git-svn-id: http://core.svn.wordpress.org/trunk@36378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-27 13:43:28 +00:00
Eric Lewis
c48e9eea46
Build/Test Tools: Move class `WP_UnitTest_Factory` into its own file.
...
In [36347] we moved all PHP factory classes into their own files except the main class. The main class is now in its own file, and `factory.php` is solely an include manifest for all factory classes.
Built from https://develop.svn.wordpress.org/trunk@36409
git-svn-id: http://core.svn.wordpress.org/trunk@36376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-27 03:27:26 +00:00
Eric Lewis
2d2353cbde
General: Document the difference between site_url() and home_url().
...
`site_url()` returns a url where WordPress application files are accessible (e.g. where the `wp-admin/` folder resides). `home_url()` returns a url where the front-end of the WordPress site can be visited.
See #35238 .
Built from https://develop.svn.wordpress.org/trunk@36408
git-svn-id: http://core.svn.wordpress.org/trunk@36375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-27 02:55:27 +00:00
Weston Ruter
c7923b2c9d
Customizer: Improve parity between JS Setting models in preview with JS Setting models in pane.
...
* Ensure that Setting `Value` objects in preview get initial `_dirty` flag set if values among POST data.
* Upon `saved` event, send `saved` message to preview with the `response` to trigger `saved` event there.
* Reset `_dirty` flag for all setting `Value` objects in preview upon `saved`.
* Continue to create settings synced from pane even after initial bootstrap, and create them as dirty.
* Ensure that `id` property is set for setting `Value` objects in preview.
See #27355 .
Fixes #35616 .
Built from https://develop.svn.wordpress.org/trunk@36407
git-svn-id: http://core.svn.wordpress.org/trunk@36374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-26 23:52:25 +00:00
Andrea Fercia
972215f9f9
Accessibility: Improve the focus style on the Credits screen.
...
Leads and contributing developers will now look nicer when focused.
Also, combines adjacent image and text links for the same resource thus
simplifying markup and reducing noise for screen reader users.
Props walbo, afercia.
Fixes #34953 .
Built from https://develop.svn.wordpress.org/trunk@36406
git-svn-id: http://core.svn.wordpress.org/trunk@36373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-26 22:38:28 +00:00
Eric Lewis
0efd5b3d00
Comments: Fire an action after a comment is removed from object cache.
...
When a comment is removed from the object cache, the `clean_comment_cache` action is now fired. This provides plugin and theme developers a chance to perform secondary cache invalidation as needed.
Props spacedmonkey.
Fixes #35610 .
Built from https://develop.svn.wordpress.org/trunk@36405
git-svn-id: http://core.svn.wordpress.org/trunk@36372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-26 03:47:25 +00:00
Boone Gorges
e6d2b6cab0
Query: Respect 'suppress_filters' when filtering search-related SQL.
...
Props 5um17.
Fixes #35594 .
Built from https://develop.svn.wordpress.org/trunk@36404
git-svn-id: http://core.svn.wordpress.org/trunk@36371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-26 03:12:25 +00:00
Boone Gorges
de89efc4dc
Introduce `$comment_status` and `$ping_status` params for `WP_Query`.
...
Props birgire.
Fixes #35601 .
Built from https://develop.svn.wordpress.org/trunk@36403
git-svn-id: http://core.svn.wordpress.org/trunk@36370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-26 02:56:26 +00:00
Boone Gorges
de9d742b9a
Allow `is_post_type_viewable()` to accept a post type name.
...
Previously, it accepted only a post type object.
Props spacedmonkey.
Fixes #35609 .
Built from https://develop.svn.wordpress.org/trunk@36402
git-svn-id: http://core.svn.wordpress.org/trunk@36369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-26 02:37:26 +00:00
Boone Gorges
0d33e0904e
Add tests for `is_post_type_viewable()`.
...
See #35609 .
Built from https://develop.svn.wordpress.org/trunk@36401
git-svn-id: http://core.svn.wordpress.org/trunk@36368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-26 02:27:26 +00:00
Boone Gorges
ced24390f9
Normalize 'clean_term_cache' docs formatting after [36399].
...
Built from https://develop.svn.wordpress.org/trunk@36400
git-svn-id: http://core.svn.wordpress.org/trunk@36367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-26 02:19:26 +00:00
Boone Gorges
32e5795042
Pass `$clean_taxonomy` param to 'clean_term_cache' action.
...
Props spacedmonkey.
Fixes #35611 .
Built from https://develop.svn.wordpress.org/trunk@36399
git-svn-id: http://core.svn.wordpress.org/trunk@36366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-26 02:18:26 +00:00
Sergey Biryukov
f6cde8e3c5
Docs: Correct return value for `is_allowed_http_origin()`.
...
Props kraftbj.
Fixes #35607 .
Built from https://develop.svn.wordpress.org/trunk@36398
git-svn-id: http://core.svn.wordpress.org/trunk@36365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-26 00:39:26 +00:00
Eric Lewis
d01e8db4ad
Plugins: Clarify that mu-plugins can't be "active" in docs.
...
Plugins installed in the plugins/ folder can be activated by users. This puts the plugin in an "active" state. Plugins in the mu-folder/ are "must-use" plugins that are always loaded. They can't be activated, and thereby can't be "active." Because of this, using the `is_plugin_active()` or `is_plugin_active_for_network()` returns false when checking for these plugins. This clarifies that behavior in the functions' docs.
Built from https://develop.svn.wordpress.org/trunk@36397
git-svn-id: http://core.svn.wordpress.org/trunk@36364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-26 00:32:27 +00:00
Andrea Fercia
af25083b6f
Accessibility: Improve the color contrast ratio replacing the residual occurrences of the `#777` gray.
...
Uses the existing `#72777c` on white backgrounds and the new `#555d66` "dark medium gray" on darker backgrounds.
Fixes #35605 .
Built from https://develop.svn.wordpress.org/trunk@36396
git-svn-id: http://core.svn.wordpress.org/trunk@36363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-26 00:04:26 +00:00
Andrea Fercia
eba8321e21
Accessibility: Fix the color contrast ratio in the login screen.
...
Props scarinessreported for the initial patch.
Fixes #31548 .
Built from https://develop.svn.wordpress.org/trunk@36395
git-svn-id: http://core.svn.wordpress.org/trunk@36362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-25 23:52:25 +00:00
Konstantin Obenland
d28ce2a1e4
Pass data consistently on plugin, network plugin, and network theme screens.
...
List tables on these three screens look similar but come with unexpected caveats.
The network themes screen in particular has been neglected, using a `.plugin`
class to inherit its sibling's styles and not providing classes and data
attributes that the other two offer. This will provide some more consistency.
Fixes #35335 .
Built from https://develop.svn.wordpress.org/trunk@36394
git-svn-id: http://core.svn.wordpress.org/trunk@36361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-25 22:55:25 +00:00
Jeremy Felt
0b69f2cd63
Multisite: Introduce the WP_Site class.
...
* A `WP_Site` object initially matches a row from `wp_blogs`.
* A site can be retrieved by its ID through `WP_Site::get_instance()`.
* Adds `sites` to the global cache group and captures instance lookups.
* The multisite bootstrap now ensures `$current_blog` is an instance of `WP_Site`.
Props johnjamesjacoby, jeremyfelt.
See #32450 .
Built from https://develop.svn.wordpress.org/trunk@36393
git-svn-id: http://core.svn.wordpress.org/trunk@36360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-25 21:51:26 +00:00
Dominik Schilling
f3c20d5011
Docs: Fix indentation in `add_filter()` example.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36392
git-svn-id: http://core.svn.wordpress.org/trunk@36359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-25 18:58:27 +00:00
Drew Jaynes
3fc149d9ee
Docs: Fix parameter documentation ordering in the hook docs for the `register_taxonomy_args` filter.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36391
git-svn-id: http://core.svn.wordpress.org/trunk@36358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-25 17:11:27 +00:00
Peter Westwood
90b80fce4e
i18n tools: Add the text domain to translate_nooped_plural() calls as well.
...
Fixes #34126 props jrf.
Built from https://develop.svn.wordpress.org/trunk@36390
git-svn-id: http://core.svn.wordpress.org/trunk@36357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-24 15:29:26 +00:00
Peter Westwood
bc56bc2d5f
i18n tools: Add a test for the add-textdomain.php script.
...
Built from https://develop.svn.wordpress.org/trunk@36389
git-svn-id: http://core.svn.wordpress.org/trunk@36356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-24 15:26:28 +00:00
Weston Ruter
57c2b5d192
Customizer: Use "(Untitled)" as site title if `blogname` is empty.
...
Fixes a layout issue in the Customizer UI. Also de-duplicate title display logic, outputting "Loading..." as site title in PHP with actual title being set upon Customizer `ready`. Also update the site title in response to a `blogname` setting change as opposed to `input` DOM events on the control.
Fixes #35579 .
Built from https://develop.svn.wordpress.org/trunk@36388
git-svn-id: http://core.svn.wordpress.org/trunk@36355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-23 23:15:27 +00:00
Boone Gorges
00cf77999d
In comments list table, `$post_id` should default to `false` rather than 0.
...
After [36381], the default value of `0` was causing the list table at
edit-comments.php to be empty. `false` prevents this.
This fix is likely temporary, while more research is done into the backward
compatibility concerns tied to [36381].
See #35090 .
Built from https://develop.svn.wordpress.org/trunk@36387
git-svn-id: http://core.svn.wordpress.org/trunk@36354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-23 22:16:26 +00:00
Eric Lewis
51ae114302
Networks and sites: Replace "blog" usage with "site" in docs.
...
This effort focuses on `src/wp-includes/link-template.php`.
Multisite functions use the term "blog" to refer to what we now call a "site," e.g. `get_current_blog_id()`. These functions are here to stay because of our commitment to backwards compatibility. What we can do is set the documentation straight.
Props mrahmadawais.
Fixes #35589 .
Built from https://develop.svn.wordpress.org/trunk@36386
git-svn-id: http://core.svn.wordpress.org/trunk@36353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-23 16:47:29 +00:00
Sergey Biryukov
b0b311053e
Docs: Correct `wpdb::db_version()` description.
...
Props luciole135.
Fixes #35588 .
Built from https://develop.svn.wordpress.org/trunk@36385
git-svn-id: http://core.svn.wordpress.org/trunk@36352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-23 11:22:26 +00:00
Ella Iseulde Van Dorpe
3663a5bca5
TinyMCE: add inline link dialog
...
First run.
Links the advanced button to the "old" dialog for now.
See #33301 .
Built from https://develop.svn.wordpress.org/trunk@36384
git-svn-id: http://core.svn.wordpress.org/trunk@36351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-23 00:08:26 +00:00
Weston Ruter
fb8544a0ac
Customizer: Add shift-click on nav menu items in preview to focus on corresponding nav menu item controls in pane.
...
Add missing `params.completeCallback` to `MenuItemControl.focus()` for parity with `Control.focus()`. Also adds `params` to `MenuItemControl.expandForm`, `MenuItemControl.collapseForm()`, and `MenuItemControl.toggleForm()`.
Props MattGeri, westonruter.
Fixes #32681 .
Built from https://develop.svn.wordpress.org/trunk@36383
git-svn-id: http://core.svn.wordpress.org/trunk@36350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-22 21:21:26 +00:00
Drew Jaynes
196271e5b4
Docs: List out possible values for the `$show` parameter in the description for `get_bloginfo()`.
...
Fixes #35581 .
Built from https://develop.svn.wordpress.org/trunk@36382
git-svn-id: http://core.svn.wordpress.org/trunk@36349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-22 20:22:25 +00:00
Boone Gorges
c5ab953773
Allow comment query results to be limited to comments with comment_post_ID = 0.
...
Previously, this was not possible due to an overly broad `empty()` check.
Passing `null`, `false`, or `''` to 'post_id', or omitting 'post_id'
altogether, will continue to return comments regardless of `comment_post_ID`,
as before. Passing `0` or `'0'` will limit results to comments with no
associated post.
Props danielbachhuber.
Fixes #35090 .
Built from https://develop.svn.wordpress.org/trunk@36381
git-svn-id: http://core.svn.wordpress.org/trunk@36348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-22 20:20:25 +00:00
Drew Jaynes
90b4ee93b3
Docs: Improve documentation for `bloginfo()` including cross-reference info for the `$show` parameter passed through to `get_bloginfo()`.
...
See #35581 .
Built from https://develop.svn.wordpress.org/trunk@36380
git-svn-id: http://core.svn.wordpress.org/trunk@36347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-22 20:17:28 +00:00
Andrea Fercia
450cbb3e81
Accessibility: Remove title attributes from the Menus screen.
...
Also, adds missing labels and improves the existing ones.
Updates the "custom links" labels and inputs in the Customizer too.
Introduces a generic, reusable, `.wp-initial-focus` CSS class to be used for
the sole purpose of setting the initial focus.
"Quick Search": uniform the attached events and avoids new AJAX requests to
be triggered when the pressed key doesn't change the searched term.
Fixes #35374 .
Built from https://develop.svn.wordpress.org/trunk@36379
git-svn-id: http://core.svn.wordpress.org/trunk@36346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-22 14:26:27 +00:00
Sergey Biryukov
6699b761e1
Docs: Remove redundant PHP tags from `get_object_taxonomies()` description.
...
Props dotancohen.
Fixes #35553 .
Built from https://develop.svn.wordpress.org/trunk@36377
git-svn-id: http://core.svn.wordpress.org/trunk@36344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-22 02:41:26 +00:00
Andrew Ozz
ca1906b159
TinyMCE: remove the `srcset` and `sizes` attributes (if any) after replacing or editing an image.
...
See #35434 .
Built from https://develop.svn.wordpress.org/trunk@36376
git-svn-id: http://core.svn.wordpress.org/trunk@36343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-22 01:19:25 +00:00
Andrea Fercia
496bde4e77
Quick/Bulk Edit: Remove a no more used jQuery loop for unsupported post formats.
...
See #23426 .
See #24096 .
Fixes #35564 .
Built from https://develop.svn.wordpress.org/trunk@36375
git-svn-id: http://core.svn.wordpress.org/trunk@36342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-21 22:50:25 +00:00
Weston Ruter
dc343e41fa
Customizer: Hide help toggle button in panel when no description is supplied.
...
This aligns with the `.customize-panel-description` element which is also excluded if there is no description.
Props drebbits.web.
Fixes #35540 .
Built from https://develop.svn.wordpress.org/trunk@36374
git-svn-id: http://core.svn.wordpress.org/trunk@36341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-21 22:01:26 +00:00
Sergey Biryukov
7afa923067
Media: In `_wp_handle_upload()`, move ending brace to a new line.
...
Props georgestephanis.
Fixes #35565 .
Built from https://develop.svn.wordpress.org/trunk@36373
git-svn-id: http://core.svn.wordpress.org/trunk@36340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-21 20:27:26 +00:00
Sergey Biryukov
aeefc9af75
Unit Tests: Correct comment in `wp-tests-config-sample.php`.
...
Props tahteche.
Fixes #35563 .
Built from https://develop.svn.wordpress.org/trunk@36372
git-svn-id: http://core.svn.wordpress.org/trunk@36339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-21 20:25:27 +00:00
Weston Ruter
c055021d1e
Customizer: Fix `click.preview` event handler for jump links and shift+clicks in preview.
...
* Prevent following jump links (starting with `#`), but instead scroll that element into view.
* Prevent following links clicked in the Customizer if shift key is pressed when clicking; this fixes an issue when trying to shift-click on a widget or nav menu item (#32681 ) to just focus on the control in the Customizer.
Fixes #26005 .
Built from https://develop.svn.wordpress.org/trunk@36371
git-svn-id: http://core.svn.wordpress.org/trunk@36338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-21 06:08:27 +00:00
Dion Hulse
65182e4dc8
Upgrade: Switch the locking mechanism to using static methods so that it can be accessed from other upgrade-classes.
...
Fixes #34878
Built from https://develop.svn.wordpress.org/trunk@36370
git-svn-id: http://core.svn.wordpress.org/trunk@36337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-21 01:22:25 +00:00
Dominik Schilling
23133b0b06
Widgets: Show the "Clear Inactive Widgets" button only after the sidebar with inactive widgets.
...
Fixes #35447 .
Built from https://develop.svn.wordpress.org/trunk@36368
git-svn-id: http://core.svn.wordpress.org/trunk@36335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-20 21:54:26 +00:00
Drew Jaynes
42caba7134
Docs: Update the `@access` tag value for `WP_Http::_get_first_available_transport()` from `private` to `public`.
...
When the method was introduced in [17914], the name was underscore-prefixed as is core style for private-use, though it was also introduced with a `public` access modifier for the declaration. Due to core's committment to backward-compatibility, the access modifier overrules in this case, meaning that while the method is underscore-prefixed and was originally-intentioned to be private, it is and always will be a public method, and the documentation should reflect that.
Props Frozzare.
Fixes #35289 .
Built from https://develop.svn.wordpress.org/trunk@36367
git-svn-id: http://core.svn.wordpress.org/trunk@36334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-20 18:46:26 +00:00
Jeremy Felt
3018d9827c
Themes: Enhance filtering options for allowed themes on a network.
...
* Move the legacy `allowed_themes` filter to `WP_Theme::get_allowed_on_network()`, where it will continue to filter themes allowed on the network.
* Add `network_allowed_themes` filter to `WP_Theme::get_allowed()` and pass `$blog_id` to provide context.
* Add `site_allowed_themes` filter to `WP_Theme::get_allowed_on_site()` and pass `$blog_id` to provide context.
Props pauldewouters, lamosty, michalzuber, dmsnell, johnnypea, rob.
Fixes #28436 .
Built from https://develop.svn.wordpress.org/trunk@36366
git-svn-id: http://core.svn.wordpress.org/trunk@36333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-20 18:29:27 +00:00
Drew Jaynes
1e1d1375b0
Docs: Add missing `@access` tags to DocBlocks for `WP` class methods and properties.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36365
git-svn-id: http://core.svn.wordpress.org/trunk@36332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-20 18:19:27 +00:00
Scott Taylor
cee318ed81
Media: When reusing the initial values from the global MediaElement config object, the config object should first be cloned. Objects in JS are references that will retain any changes. This fixes an issue where player controls could get mixed up between instances when multiple players (namely, single audio and audio playlists, in a certain order) are on the same page.
...
Props Fab1en.
Fixes #34152 .
Built from https://develop.svn.wordpress.org/trunk@36364
git-svn-id: http://core.svn.wordpress.org/trunk@36331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-20 15:47:28 +00:00
Dion Hulse
dddfbfa1d3
Emoji: Work around a `mod_security` rule which prevents pages with 4 or more instances of `String.fromCharCode(` from being served.
...
Fixes #35412 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36359
git-svn-id: http://core.svn.wordpress.org/trunk@36326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-20 07:40:28 +00:00
Andrew Ozz
6c3261d3da
TinyMCE: update to 4.3.3. Update the QUnit tests and revert back to testing the non-minified files in /src.
...
Fixes #35539 .
Built from https://develop.svn.wordpress.org/trunk@36352
git-svn-id: http://core.svn.wordpress.org/trunk@36319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-20 04:18:33 +00:00
Dion Hulse
78b24ed790
Build Tools: Revert to using a human readable timestamp rather than the unix timestamp in [36315].
...
Fixes #28722
Built from https://develop.svn.wordpress.org/trunk@36351
git-svn-id: http://core.svn.wordpress.org/trunk@36318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-20 02:02:27 +00:00
Jeremy Felt
1def66a1c9
Themes: Add initial tests for the `allowed_themes` filter.
...
We'll be adjusting the placement of this filter and adding two other related filters, so we should make sure it continues to work as expected after the change.
See #28436 .
Built from https://develop.svn.wordpress.org/trunk@36350
git-svn-id: http://core.svn.wordpress.org/trunk@36317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-19 23:58:27 +00:00
Dion Hulse
006ae74d4c
Core Upgrader: Add a locking mechanism to avoid two concurrent updates of WordPress occuring.
...
Fixes #34878
Built from https://develop.svn.wordpress.org/trunk@36349
git-svn-id: http://core.svn.wordpress.org/trunk@36316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-19 05:07:26 +00:00
Boone Gorges
60a9f41315
Don't double-escape the 'name' param in `get_terms()`.
...
[32353] changed the way the 'name' param in `get_terms()` is sanitized, by
running it through `sanitize_term_field( 'name' )` before performing the SQL
query. An unintentional side effect of this change was that the string is
double-escaped: once by `wp_filter_kses()`, and once by `esc_sql()`. The
double-escaping was causing 'name' queries to fail when the param contained
apostrophes or other escaped characters.
Fixes #35493 .
Built from https://develop.svn.wordpress.org/trunk@36348
git-svn-id: http://core.svn.wordpress.org/trunk@36315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-19 04:10:25 +00:00
Eric Lewis
96f0c643e3
Build/Test Tools: Move PHP factory classes into their own files.
...
This makes the code easier to browse.
`factory.php` loads the new files, so this is backwards compatible in case `factory.php` is loaded directly for access to one of the classes.
See #35492 .
Built from https://develop.svn.wordpress.org/trunk@36347
git-svn-id: http://core.svn.wordpress.org/trunk@36314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-19 03:56:27 +00:00
Boone Gorges
f1e6cde0a2
Share post fixture in `WP_Comment_Query` tests.
...
See #30017 .
Built from https://develop.svn.wordpress.org/trunk@36346
git-svn-id: http://core.svn.wordpress.org/trunk@36313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-19 03:03:26 +00:00
Boone Gorges
a2c17d92d2
Ignore false values of 'search' in `WP_Comment_Query`.
...
Props danielbachhuber.
Fixes #35513 .
Built from https://develop.svn.wordpress.org/trunk@36345
git-svn-id: http://core.svn.wordpress.org/trunk@36312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-19 02:55:27 +00:00
Eric Lewis
3f643ba9af
Themes: Show template loading error to users with `switch_themes` cap.
...
In [36338], a template loading error was shown only to users with the `install_themes` capability. This is now displayed users with the `switch_themes` capability, as users with this cap can at least switch to a different theme. Also, this will now show for site administrators in multisite, whereas `install_themes` is limited to superadmins.
Props dd32.
See #21931 .
Built from https://develop.svn.wordpress.org/trunk@36344
git-svn-id: http://core.svn.wordpress.org/trunk@36311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-18 19:57:26 +00:00
Rachel Baker
f956379447
Comments: Remove unused `$default_comments_page` variable in `get_comment_link()`.
...
Left in r34735, fetches the `default_comments_page` option twice since this variable is unused.
See #34073 and #35511 .
Props Latz.
Built from https://develop.svn.wordpress.org/trunk@36343
git-svn-id: http://core.svn.wordpress.org/trunk@36310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-18 16:35:28 +00:00
Dion Hulse
61951f5aff
CSS: Reference the original location of the CSS rule being overridden.
...
See #35229
Built from https://develop.svn.wordpress.org/trunk@36342
git-svn-id: http://core.svn.wordpress.org/trunk@36309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-18 09:59:26 +00:00
Dion Hulse
987ce83cfc
CSS: Stop using `wp-admin.min.css` and instead queue the individual stylesheets up through `load-styles.php`.
...
We still generate the `wp-admin.*` files for compabitility purposes, however they only include the `@import()` lines.
Fixes #35229
Built from https://develop.svn.wordpress.org/trunk@36341
git-svn-id: http://core.svn.wordpress.org/trunk@36308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-18 09:57:29 +00:00
Jeremy Felt
fcd674ca6c
Docs: Fix type documentation for `WP_Network` properties.
...
* `$cookie_domain` was incorrectly documented as an `int`.
* `$id` and `$blog_id`, though numeric, are provided as strings and should be documented as such.
Fixes #35404 .
Built from https://develop.svn.wordpress.org/trunk@36340
git-svn-id: http://core.svn.wordpress.org/trunk@36307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-18 02:59:27 +00:00
Rachel Baker
9065794462
List Tables: Use the $GLOBALS array when unsetting the global post and comment in `WP_Comments_List_Table::single_row()`.
...
In r35674 only the local variables were unset, when using `unset()` with a global variable the `$GLOBALS` array must be used.
Fixes #35506 .
Built from https://develop.svn.wordpress.org/trunk@36339
git-svn-id: http://core.svn.wordpress.org/trunk@36306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-18 02:50:27 +00:00
Eric Lewis
e62c559da3
Themes: Only users with proper capability should see theme errors.
...
After [36335], if a template file is not loaded, an error is displayed
to logged-in users. As logged-in users may have no capabilities,
this check is insubstantial. Limit the display of this error to users
with the `install_themes` capability, i.e. someone who has the capacity
to deal with the error.
See #21931 .
Built from https://develop.svn.wordpress.org/trunk@36338
git-svn-id: http://core.svn.wordpress.org/trunk@36305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-17 23:59:26 +00:00
Ella Iseulde Van Dorpe
d17af5ff4b
Fix unit tests after [36336]
...
Built from https://develop.svn.wordpress.org/trunk@36337
git-svn-id: http://core.svn.wordpress.org/trunk@36304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-17 23:38:25 +00:00
Ella Iseulde Van Dorpe
dea6197932
Emoji: adjust $wpsmiliestrans
...
Swap simple-smile.png with SLIGHTLY SMILING FACE
and frownie.png with SLIGHTLY FROWNING FACE
Fixes #31710 .
Built from https://develop.svn.wordpress.org/trunk@36336
git-svn-id: http://core.svn.wordpress.org/trunk@36303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-17 22:28:29 +00:00
Eric Lewis
435196fc40
Themes: Show an error message to logged-in users if a template file isn't loaded.
...
On the off-chance the active theme folder is renamed or deleted, a "white screen
of death" was displayed to the user. Instead, the user is shown a useful error
screen displaying any errors the theme has (e.g. if the theme can't be found).
Props MikeHansenMe, SergeyBiryukov.
See #21931 .
Built from https://develop.svn.wordpress.org/trunk@36335
git-svn-id: http://core.svn.wordpress.org/trunk@36302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-17 17:29:27 +00:00
Andrea Fercia
82c596594b
After [36333] correctly use `esc_attr()` instead of `esc_attr__()`.
...
See #35313 .
Built from https://develop.svn.wordpress.org/trunk@36334
git-svn-id: http://core.svn.wordpress.org/trunk@36301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-17 16:03:25 +00:00
Andrea Fercia
497de1d658
Accessibility: Remove title attributes from the Posts list table.
...
Fixes #35313 .
Built from https://develop.svn.wordpress.org/trunk@36333
git-svn-id: http://core.svn.wordpress.org/trunk@36300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-17 15:47:26 +00:00
Rachel Baker
97e367483a
Comments: Correct description of `comment_author` property in WP_Comment class.
...
The `comment_author` property is the comment author’s name, not an ID.
Props meitar.
Fixes #35464 .
Built from https://develop.svn.wordpress.org/trunk@36332
git-svn-id: http://core.svn.wordpress.org/trunk@36299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-17 15:00:27 +00:00
Andrea Fercia
1183b06bc5
Accessibility: Remove title attributes from the Media Library list table.
...
Fixes #35136 .
Built from https://develop.svn.wordpress.org/trunk@36331
git-svn-id: http://core.svn.wordpress.org/trunk@36298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-17 14:46:29 +00:00
Eric Lewis
fd99c1705e
Docs: Nav menu location functions relate to nav menu locations, not nav menus.
...
Fixes #35471 .
Built from https://develop.svn.wordpress.org/trunk@36330
git-svn-id: http://core.svn.wordpress.org/trunk@36297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-17 01:43:26 +00:00
Pascal Birchler
4e978a1ce6
Posts: Correctly pass `$post` to `post_password_required()` in `get_the_excerpt()`.
...
Corrects the relevant test.
Props sebastian.pisula for initial patch.
Fixes #35486 .
Built from https://develop.svn.wordpress.org/trunk@36329
git-svn-id: http://core.svn.wordpress.org/trunk@36296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-16 10:14:28 +00:00
Dominik Schilling
3b3ded01a0
Media: Update some attach/detach strings in the columns view.
...
* Show a "Media attachment reattached."/"Media attachment detached." message when only one attachment was attached/detached.
* Use the string placeholder as `number_format_i18n()` returns a string.
* Add translator comments.
* Update help text to refer to the new dropdown menus.
* Add a more generic title to the attach modal.
Fixes #33237 .
Built from https://develop.svn.wordpress.org/trunk@36328
git-svn-id: http://core.svn.wordpress.org/trunk@36295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 22:29:25 +00:00
Boone Gorges
b750ee042b
Correct documentation for `post_author` param of `WP_Comment_Query`.
...
Props chriscct7.
Fixes #35481 .
Built from https://develop.svn.wordpress.org/trunk@36327
git-svn-id: http://core.svn.wordpress.org/trunk@36294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 20:14:26 +00:00
Boone Gorges
4c91776f3b
Respect all post-related filters in `WP_Comment_Query`.
...
The refactor of `WP_Comment_Query`'s SQL generation in [34542] introduced a bug
that caused only the last post-related filter to be respected in comment
queries. In other words, if querying for comments using params
`post_status=draft&post_author=3`, only the last-processed of these params
would be respected. The current changeset fixes the logic so that these clauses
don't overwrite each other.
Props chriscct7.
Fixes #35478 .
Built from https://develop.svn.wordpress.org/trunk@36326
git-svn-id: http://core.svn.wordpress.org/trunk@36293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 20:10:51 +00:00
Rachel Baker
f407e3a473
Comments: Use TEXT column type in fallback for `wp_get_comment_column_max_length()`.
...
Fixes #10377 .
Built from https://develop.svn.wordpress.org/trunk@36325
git-svn-id: http://core.svn.wordpress.org/trunk@36292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 20:10:27 +00:00
Boone Gorges
d2dabdecf6
Respect custom pagination params when using `wp_list_comments()` in a query loop.
...
[36157] fixed a problem, introduced in 4.4, that caused custom pagination
parameters passed to `wp_list_comments()`. However, the fix introduced in that
changeset was limited to the `is_singular()` context, so that the bug remained
when `wp_list_comments()` is used within a non-singular `WP_Query` loop. We
fix this by removing the `is_singular()` check and using the more general
`get_the_ID()` to identify the correct post_id to use for the secondary
comment query.
Fixes #35402 .
Built from https://develop.svn.wordpress.org/trunk@36324
git-svn-id: http://core.svn.wordpress.org/trunk@36291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 19:48:25 +00:00
Boone Gorges
d5bc0fe493
Populate term cache with proper clone of term objects.
...
[34999] modified the cache strategy for terms in the context of
`wp_get_object_terms()`. As part of these changes, the `object_id` property of
term objects had to be unset before being cached. To avoid modifying passed-by-
reference terms, `update_term_cache()` attempted to make a copy of the terms
passed to the function; however, it failed to use the `clone` keyword, and thus
only created a reference instead of a copy.
Props berengerzyla.
Fixes #35462 .
Built from https://develop.svn.wordpress.org/trunk@36323
git-svn-id: http://core.svn.wordpress.org/trunk@36290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 19:35:26 +00:00
Pascal Birchler
e85f75f23f
Comments: Remove unneeded `$req` variable in `comments_template()`.
...
Props Latz.
Fixes #35473 .
Built from https://develop.svn.wordpress.org/trunk@36322
git-svn-id: http://core.svn.wordpress.org/trunk@36289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 19:33:27 +00:00
Pascal Birchler
552ed65d3b
Post: After [36319], add `$post` parameter to the `get_the_excerpt` filter.
...
Props sebastian.pisula.
Fixes #35474 .
Built from https://develop.svn.wordpress.org/trunk@36321
git-svn-id: http://core.svn.wordpress.org/trunk@36288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 19:28:26 +00:00
Pascal Birchler
1bad16273e
Add tests missed and announced in [36319].
...
See #27246 .
Built from https://develop.svn.wordpress.org/trunk@36320
git-svn-id: http://core.svn.wordpress.org/trunk@36287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 14:50:30 +00:00
Pascal Birchler
10be93190e
Posts: Add a `$post` parameter to `get_the_excerpt()`.
...
This allows getting the excerpt for a specific post, similar to how most other template tags work.
A deprecation notice is thrown if a boolean value is passed, which is deprecated since 2.3 and has not been used for a long time.
Adds unit tests.
Fixes #27246 .
Built from https://develop.svn.wordpress.org/trunk@36319
git-svn-id: http://core.svn.wordpress.org/trunk@36286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 14:47:26 +00:00
Pascal Birchler
19d4304565
Comments: Add a new `pre_wp_update_comment_count_now` filter.
...
This allows filtering a post's comment count before it is queried and updated in the database.
Props peterwilsoncc for initial patch.
Fixes #35060 .
Built from https://develop.svn.wordpress.org/trunk@36318
git-svn-id: http://core.svn.wordpress.org/trunk@36285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 13:42:26 +00:00
Eric Lewis
ededb78efc
Docs: Use "site" rather than "blog" in `get_current_blog_id()` docs.
...
Fixes #35415 .
Built from https://develop.svn.wordpress.org/trunk@36317
git-svn-id: http://core.svn.wordpress.org/trunk@36284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 13:18:27 +00:00
Pascal Birchler
68f12521c8
Post Types: Introduce `unregister_post_type()`.
...
This new function can be used to completely unregister non built-in post types.
Fixes #14761 .
Built from https://develop.svn.wordpress.org/trunk@36316
git-svn-id: http://core.svn.wordpress.org/trunk@36283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 12:20:27 +00:00
Pascal Birchler
a6aa15a445
Build Tools: Append the timestamp to `$wp_version` instead of only the current date.
...
This ensures the `Etag` header added in [36312] changes for every build.
Fixes #28722 .
Built from https://develop.svn.wordpress.org/trunk@36315
git-svn-id: http://core.svn.wordpress.org/trunk@36282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 11:54:26 +00:00
Dominik Schilling
c5e3716c11
Docs: Fix `@return` type for `wp_get_current_user()` after [36313].
...
See #19615 .
Built from https://develop.svn.wordpress.org/trunk@36314
git-svn-id: http://core.svn.wordpress.org/trunk@36281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 11:16:26 +00:00
Pascal Birchler
9cd880d356
Users: Always return `$current_user` in `wp_get_current_user()`, never a boolean.
...
Fixes unit tests affected by [36311].
See #19615 .
Built from https://develop.svn.wordpress.org/trunk@36313
git-svn-id: http://core.svn.wordpress.org/trunk@36280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 10:47:25 +00:00
Pascal Birchler
9ea68bc533
Script Loader: Add `Etag: $wp_version` header in `load-scripts.php` and `load-styles.php`.
...
This improves performance since browsers won't re-download the scripts and styles when there was no change in `$wp_version`.
Props sergej.mueller, dd32, swissspidy.
Fixes #28722 .
Built from https://develop.svn.wordpress.org/trunk@36312
git-svn-id: http://core.svn.wordpress.org/trunk@36279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 10:23:25 +00:00
Pascal Birchler
283684b616
Users: Deprecate the `get_currentuserinfo()` pluggable function.
...
It encourages an ugly pattern like `global $userdata; get_currentuserinfo();` in plugins/themes. `wp_get_current_user()` should be used instead, e.g. `$current_user = wp_get_current_user();`.
Props scribu for initial patch.
Fixes #19615 .
Built from https://develop.svn.wordpress.org/trunk@36311
git-svn-id: http://core.svn.wordpress.org/trunk@36278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 10:16:27 +00:00
Pascal Birchler
16142a461e
Filesystem API: Add a filter to `wp_unique_filename()`.
...
Props SergeyBiryukov, MikeHansenMe, johnbillion, swissspidy.
Fixes #19121 .
Built from https://develop.svn.wordpress.org/trunk@36310
git-svn-id: http://core.svn.wordpress.org/trunk@36277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 09:39:26 +00:00
Pascal Birchler
6951e8d045
Taxonomy: Fix unit tests after [36308].
...
See #34988 .
Built from https://develop.svn.wordpress.org/trunk@36309
git-svn-id: http://core.svn.wordpress.org/trunk@36276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 09:13:26 +00:00
Pascal Birchler
27fa2f65eb
Taxonomy: Introduce `wp-admin/term.php` for editing single terms.
...
This is similar to `edit.php` -> `post.php` and `users.php` -> `user-edit.php` and fixes a bug where screen options for the list table were shown while editing a term.
Fixes #34988 .
Built from https://develop.svn.wordpress.org/trunk@36308
git-svn-id: http://core.svn.wordpress.org/trunk@36275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 08:27:27 +00:00
Pascal Birchler
b0b13aff2f
Embeds: Allow embedding static front pages and pages having a child page with an `embed` slug.
...
This makes `embed` a special slug that can't be used for new pages/posts. When `https://example.com/foo/embed/ ` is an existing page, embeds fall back to `https://example.com/foo/?embed=true `.
Adds unit tests.
Fixes #34971 .
Built from https://develop.svn.wordpress.org/trunk@36307
git-svn-id: http://core.svn.wordpress.org/trunk@36274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 07:56:26 +00:00
Pascal Birchler
b9fd40a8cb
Users: Decode special characters in password and email change notification emails.
...
Fixes #35283 .
Built from https://develop.svn.wordpress.org/trunk@36306
git-svn-id: http://core.svn.wordpress.org/trunk@36273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 07:29:27 +00:00
Eric Lewis
207ba54fed
In wp.Backbone.Subviews, extract subviews with proper Underscore.js functions.
...
Subviews are stored internally on the Subview manager as an object. The object
is composed of key-value pairs where the key is a jQuery selector for a view,
and the value is an array of views that matching the selector.
To extract subviews, `_.flatten()` was used to collate the nested arrays of
views into a single view. However, `_.flatten()` is not intended to be used
for objects, and this unintended functionality breaks in newer versions of
Underscore.js.
Instead, we'll use `_.values()` to extract the arrays of views first,
and then flatten the array of arrays.
Props adamsilverstein.
See #34350 .
Built from https://develop.svn.wordpress.org/trunk@36305
git-svn-id: http://core.svn.wordpress.org/trunk@36272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 04:02:28 +00:00
Andrea Fercia
e41649c325
Accessibility: Improve focus handling on the Taxonomies Quick Edit.
...
Moves focus back to a proper place when saving or closing the form.
Fixes #35460 .
Built from https://develop.svn.wordpress.org/trunk@36304
git-svn-id: http://core.svn.wordpress.org/trunk@36271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 23:03:26 +00:00
Andrea Fercia
c6ec579751
Accessibility: Improve focus handling and audible feedback on the Posts Quick-Bulk Edit.
...
Avoids a focus loss when saving or closing the form moving focus back to a proper place.
Uses `wp.a11y.speak()` to dispatch successful edits and error messages to screen readers.
Fixes #34756 .
Built from https://develop.svn.wordpress.org/trunk@36303
git-svn-id: http://core.svn.wordpress.org/trunk@36270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 22:58:27 +00:00
Pascal Birchler
aaa11d6207
Allow searching for `0` throughout the admin.
...
Fixes #31025 .
Built from https://develop.svn.wordpress.org/trunk@36302
git-svn-id: http://core.svn.wordpress.org/trunk@36269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 20:06:25 +00:00
Pascal Birchler
d4b30f47bf
Plugins: Prevent a warning when searching in the plugins list table.
...
After [36182], plugin data contains compatibility info from the API, which is an array and cannot be searched.
Fixes #35461 .
Built from https://develop.svn.wordpress.org/trunk@36301
git-svn-id: http://core.svn.wordpress.org/trunk@36268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 20:00:29 +00:00
Drew Jaynes
ca94aafb50
Docs: Add a changelog entry to the DocBlock for `get_post_type_archive_link()` denoting that posts support was added in 4.5.
...
See [36225]. See #19902 .
Built from https://develop.svn.wordpress.org/trunk@36300
git-svn-id: http://core.svn.wordpress.org/trunk@36267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 17:56:27 +00:00
Drew Jaynes
383b9a44de
Docs: Adjust formatting for an added-parameter changelog entry in the hook doc for the `cron_request` filter.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36299
git-svn-id: http://core.svn.wordpress.org/trunk@36266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 17:30:28 +00:00
Andrea Fercia
2d76f3cb83
Accessibility: Remove title attributes from the Comments screen.
...
Fixes #35304 .
Built from https://develop.svn.wordpress.org/trunk@36298
git-svn-id: http://core.svn.wordpress.org/trunk@36265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 16:04:27 +00:00
Pascal Birchler
ded3a1d72f
Plugins: Make sure the 'Beta testing' tab is first in the plugin installer.
...
This makes feature plugins more discoverable for people running development builds.
Fixes #29631 .
Built from https://develop.svn.wordpress.org/trunk@36297
git-svn-id: http://core.svn.wordpress.org/trunk@36264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 09:07:26 +00:00
Pascal Birchler
08693cd206
Administration: After [36295], mark `postBoxL10n` as a global to please JSHint.
...
See #26399 .
Built from https://develop.svn.wordpress.org/trunk@36296
git-svn-id: http://core.svn.wordpress.org/trunk@36263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 08:40:26 +00:00
John Blackbourn
9ae1736d01
Administration: Add a "Drag boxes here" message to empty dashboard meta boxes so it's clear to users that it's possible to drag meta boxes into empty spaces.
...
Props xavortm
Fixes #26399
Built from https://develop.svn.wordpress.org/trunk@36295
git-svn-id: http://core.svn.wordpress.org/trunk@36262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 04:13:26 +00:00
Joe Hoyle
0f9b770b6c
Add response status code aliases on WP_Http for convenience.
...
These provide a more descriptive way to set response codes elsewhere,
so it's readable and less chance for the wrong response code to be
used such as 401 vs 403.
Props rmccue for the idea.
Fixes #35426 .
Built from https://develop.svn.wordpress.org/trunk@36294
git-svn-id: http://core.svn.wordpress.org/trunk@36261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 03:16:27 +00:00
John Blackbourn
55bbcf0391
Networks and Sites: Clarify the docblock for `get_current_site()` so it's clear that it returns the current network object, not anything to do with the current site. As a further exercise, the reader is invited to fix the nomenclature surrounding blogs, sites, and networks in WordPress.
...
Props ericlewis
Fixes #35414
Built from https://develop.svn.wordpress.org/trunk@36293
git-svn-id: http://core.svn.wordpress.org/trunk@36260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 00:02:25 +00:00
John Blackbourn
d6228b95b0
I18N: Introduce tests for `WP_Locale`.
...
Props realloc, swissspidy
Fixes #34688
Built from https://develop.svn.wordpress.org/trunk@36292
git-svn-id: http://core.svn.wordpress.org/trunk@36259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 23:50:26 +00:00
Andrea Fercia
7ab88221fa
Customizer: Aggregate similar CSS rules.
...
Fixes #34333 .
Built from https://develop.svn.wordpress.org/trunk@36291
git-svn-id: http://core.svn.wordpress.org/trunk@36258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 22:36:26 +00:00
John Blackbourn
045d7d3a18
I18N: Correct an argument description and return value for `wp_dropdown_languages()`.
...
Props realloc
See #35294
Built from https://develop.svn.wordpress.org/trunk@36290
git-svn-id: http://core.svn.wordpress.org/trunk@36257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 20:33:25 +00:00
John Blackbourn
e56457f7fe
Taxonomy: Correct the accetped types for the `taxonomy` element in the arguments passed to `wp_dropdown_categories()`.
...
Props grapplerulrich
Fixes #35446
Built from https://develop.svn.wordpress.org/trunk@36289
git-svn-id: http://core.svn.wordpress.org/trunk@36256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 20:16:29 +00:00
Dominik Schilling
9cd5b76fbd
jQuery: Replace `$( document ).on( 'ready', fn )` with `$( fn )`.
...
The 'ready' event is deprecated since jQuery 1.8.
See https://github.com/jquery/jquery-migrate/blob/1.3.0/warnings.md#jqmigrate-ready-event-is-deprecated .
See #35380 .
Built from https://develop.svn.wordpress.org/trunk@36288
git-svn-id: http://core.svn.wordpress.org/trunk@36255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 17:39:25 +00:00
Dominik Schilling
b7df807589
jQuery: Replace use of the `.load()` method for the "load" event with `.on( 'load', handler )`.
...
The shortcut is deprecated since jQuery 1.8.
See http://api.jquery.com/load-event/ .
See #35380 .
Built from https://develop.svn.wordpress.org/trunk@36287
git-svn-id: http://core.svn.wordpress.org/trunk@36254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 17:22:27 +00:00
Dominik Schilling
b3d8732c17
jQuery: Replace the use of the `.size()` method with the `.length` property.
...
The `.size()` method is deprecated since jQuery 1.8. The `.length` property is preferred because it doesn't have the overhead of a function call.
See https://api.jquery.com/size/ .
See #35380 .
Built from https://develop.svn.wordpress.org/trunk@36286
git-svn-id: http://core.svn.wordpress.org/trunk@36253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 16:17:27 +00:00
Dominik Schilling
b1a9983584
External Libraries: Update jQuery to 1.12.0 and jQuery Migrate to 1.3.0.
...
jQuery:
* Release post: http://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/
* Changes: https://github.com/jquery/jquery/compare/1.11.3...1.12.0
jQuery Migrate:
* Release post: http://blog.jquery.com/2016/01/13/jquery-migrate-1-3-0-released/
* Changes: https://github.com/jquery/jquery-migrate/compare/1.2.1...1.3.0
See #35380 .
Built from https://develop.svn.wordpress.org/trunk@36285
git-svn-id: http://core.svn.wordpress.org/trunk@36252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 15:52:26 +00:00
Dominik Schilling
b8f2a138e7
Set `svn:eol-style` to native on "jquery-migrate.js" and "jquery-migrate.min.js".
...
Built from https://develop.svn.wordpress.org/trunk@36284
git-svn-id: http://core.svn.wordpress.org/trunk@36251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 15:45:28 +00:00
Dominik Schilling
0a6f311922
Plugins: In `_get_plugin_data_markup_translate()` remove the fallback to the "default" textdomain for Akismet.
...
Akismet has its own language files since WordPress 3.9.
Props jrf.
Fixes #35436 .
Built from https://develop.svn.wordpress.org/trunk@36283
git-svn-id: http://core.svn.wordpress.org/trunk@36250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 13:56:26 +00:00
Dominik Schilling
a51129c2a6
Plugins: In `_get_plugin_data_markup_translate()` don't reload translations if they're already loaded.
...
Props jrf.
Fixes #35439 .
Built from https://develop.svn.wordpress.org/trunk@36282
git-svn-id: http://core.svn.wordpress.org/trunk@36249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 13:04:27 +00:00
Boone Gorges
2d136ce421
Use `assertEqualSets()` in `comment_author` test.
...
The previous assertion was too specific, resulting in race conditions.
See #35377 .
Built from https://develop.svn.wordpress.org/trunk@36279
git-svn-id: http://core.svn.wordpress.org/trunk@36246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 04:43:26 +00:00
Boone Gorges
2d74b18bea
Support searching for `'0'` in `WP_Query`.
...
Props swissspidy.
See #31025 .
Built from https://develop.svn.wordpress.org/trunk@36278
git-svn-id: http://core.svn.wordpress.org/trunk@36245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 04:37:25 +00:00
Boone Gorges
98fb5f0bdb
Use the post-filter WHERE clause when querying for comment descendants.
...
The descendant query in `WP_Comment_Query::fill_descendants()` uses the clauses
of the main `get_comment_ids()` query as a basis, discarding the `parent`,
`parent__in`, and `parent__not_in` clauses. As implemented in WP 4.4 [34546],
the WHERE clause was assembled in such a way that any modifications applied
using the `comments_clauses` filter were not inherited by `fill_descendants()`.
This resulted in descendant queries that did not always properly filter
results, and sometimes contained syntax errors.
The current changeset fixes the problem by using the post-filter WHERE clause
as the basis for the `fill_descendants()` query. This change requires a new
approach for eliminating the unneeded parent-related clauses: instead of
eliminating values in an associative array, we must use regular expressions.
Props boonebgorges, firebird75.
Fixes #35192 .
Built from https://develop.svn.wordpress.org/trunk@36277
git-svn-id: http://core.svn.wordpress.org/trunk@36244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 04:01:26 +00:00
Boone Gorges
4ac35f5713
Always respect `$comments` array passed to `wp_list_comments()`.
...
[36157] fixed a bug whereby `wp_list_comments()` would not properly recognize
custom pagination arguments. See #35175 . However, it inadvertently introduced
a bug that caused any `$comments` array explicitly passed to the function to be
ignored, when that array was accompanied by pagination arguments that differ
from those in `$wp_query`. We address this bug by moving the logic introduced
in [36157] inside a block that only fires when no `$comments` array has been
provided to the function.
Props ivankristianto.
Fixes #35356 .
Built from https://develop.svn.wordpress.org/trunk@36276
git-svn-id: http://core.svn.wordpress.org/trunk@36243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 03:27:27 +00:00
Boone Gorges
294a164b15
Ignore hierarchy in pagination calculation when comment threading is disabled.
...
In order to calculate comment pagination when newest comments are displayed
first, `comments_template()` must perform a separate query to determine the
total number of paginating comments available on a post. See [34729], #8071 ,
pagination calculation - can be defined as a top-level comment, or a comment
with `parent=0`. However, when comment threading is disabled, yet comments
exist in the database that have parents, all comments - even those with a
parent - are "paginating". (This typically happens when comments threading was
once enabled, but has since been turned off.) As such, the total-paginating-
comments query should only be limited to top-level comments when
'thread_comments' is disabled.
Props jmdodd.
Fixes #35419 .
Built from https://develop.svn.wordpress.org/trunk@36275
git-svn-id: http://core.svn.wordpress.org/trunk@36242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 03:13:25 +00:00
Joe Hoyle
5036a79e73
Add missing HTTP status code descriptions (specifically 308 and 421.)
...
Props kraftbj.
Fixes 35336.
Built from https://develop.svn.wordpress.org/trunk@36274
git-svn-id: http://core.svn.wordpress.org/trunk@36241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 02:55:26 +00:00
Joe Hoyle
dea447f04c
Add support for 451 http status code (Unavailable For Legal Reasons.)
...
Though this is technically still in the proposal stage, there is support from the core team and precedent in #16914
Props andizer.
Fixes #35333 .
Built from https://develop.svn.wordpress.org/trunk@36273
git-svn-id: http://core.svn.wordpress.org/trunk@36240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 02:49:25 +00:00
Rachel Baker
87e7b4455d
Comments: Restrict the maximum characters for input fields within the comments template.
...
Added hardcoded maxlength attributes on the author, author_email, author_url, and comment_field input markup. These can be modified via the comment_form_defaults filter. Added logic in wp_handle_comment_submission() to return a WP_Error when the comment_author, comment_author_url, or comment_content values exceed the max length of their columns. Introduces wp_get_comment_column_max_length() which returns the max column length for a given column name, and is filterable. Unit tests included for the error conditions in wp_handle_comment_submission()
Fixes #10377 .
Props westonruter rachelbaker.
Built from https://develop.svn.wordpress.org/trunk@36272
git-svn-id: http://core.svn.wordpress.org/trunk@36239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 01:25:26 +00:00
Eric Lewis
6bd2399382
Docs: Fix typo in wp-admin/admin.php.
...
Props sebastian.pisula
Fixes #35423 .
Built from https://develop.svn.wordpress.org/trunk@36271
git-svn-id: http://core.svn.wordpress.org/trunk@36238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-12 20:43:28 +00:00
Konstantin Obenland
c0e903a040
Themes: Clear floated theme cards on Themes page.
...
Also maintains visual separation for Broken Themes table on searches that
return no results.
See [36171] for `.wp-clearfix`.
Props 5um17, obenland, valendesigns, afercia.
Fixes #26646 .
Built from https://develop.svn.wordpress.org/trunk@36270
git-svn-id: http://core.svn.wordpress.org/trunk@36237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-12 17:13:29 +00:00
Pascal Birchler
d0c1f44d21
Docs: Revert [36268] as the global is indeed used, just via the superglobal.
...
Fixes #35413 .
Built from https://develop.svn.wordpress.org/trunk@36269
git-svn-id: http://core.svn.wordpress.org/trunk@36236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-12 12:26:27 +00:00
Pascal Birchler
14f073a154
Docs: Fix incorrect DocBlock for `wp_get_attachment_url()`.
...
The documented `$pagenow` global isn't used in the function.
Props sebastian.pisula.
Fixes #35413 .
Built from https://develop.svn.wordpress.org/trunk@36268
git-svn-id: http://core.svn.wordpress.org/trunk@36235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-12 12:08:26 +00:00
Andrea Fercia
44ad0964b0
After [36263] escape filterable HTML output.
...
Props adamsilverstein.
Fixes #35064 .
Built from https://develop.svn.wordpress.org/trunk@36267
git-svn-id: http://core.svn.wordpress.org/trunk@36234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-12 08:58:26 +00:00
Pascal Birchler
e7660a104d
Introduce `wp_get_raw_referer()` to retrieve unvalidated referer.
...
For things like redirects `wp_get_referer()` should be used instead.
Props voldemortensen for initial patch.
Fixes #27152 .
Built from https://develop.svn.wordpress.org/trunk@36266
git-svn-id: http://core.svn.wordpress.org/trunk@36233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-12 08:32:28 +00:00
Andrea Fercia
5bd888497d
Accessibility: Remove title attributes from the Terms list table.
...
Fixes #35187 .
Built from https://develop.svn.wordpress.org/trunk@36265
git-svn-id: http://core.svn.wordpress.org/trunk@36232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 23:30:26 +00:00
Andrea Fercia
876ab5c293
Menus screen: improve responsiveness of select elements.
...
Props Luan-Ramos, sagarjadhav.
Fixes #31826 .
Built from https://develop.svn.wordpress.org/trunk@36264
git-svn-id: http://core.svn.wordpress.org/trunk@36231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 23:05:26 +00:00
Andrea Fercia
057ec3cec0
Accessibility: Remove title attributes from the General Settings screen.
...
Date and time formats are now displayed in plain text and available for all
users. Also, lines up them with the "custom" date and time format fields to
help reinforce what these fields do.
Props afercia, perezlabs.
Fixes #35064 .
Built from https://develop.svn.wordpress.org/trunk@36263
git-svn-id: http://core.svn.wordpress.org/trunk@36230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 22:54:28 +00:00
Weston Ruter
dd123ab2c0
Customizer: Re-use list of components to eliminate code duplication.
...
Introduces protected `WP_Customize_Manager::$components` to store list of loaded core components filtered by `customize_loaded_components`.
Props DrewAPicture.
See #35242
See #33552 .
Fixes #35354 .
Built from https://develop.svn.wordpress.org/trunk@36262
git-svn-id: http://core.svn.wordpress.org/trunk@36229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 20:28:28 +00:00
Weston Ruter
3e35a7157f
Customizer: Prevent erroneously directing user to login screen when closing.
...
Fixes issue where user gets stuck at login screen after trying to close the app if previously they had to first login to access the Customizer. Prevents `WP_Customize_Manager::get_return_url()` from using `wp-login.php` as a referer.
Props chandrapatel.
See #32637 .
Fixes #35355 .
Built from https://develop.svn.wordpress.org/trunk@36261
git-svn-id: http://core.svn.wordpress.org/trunk@36228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 18:51:28 +00:00
Andrea Fercia
9b486acb9b
Quick Edit: on the Taxonomies screens, prevent a page reload when pressing Enter on a focused field.
...
Fixes #35401 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36260
git-svn-id: http://core.svn.wordpress.org/trunk@36227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 13:15:29 +00:00
Dion Hulse
abbcc01542
Multisite: The `networks` group should be global.
...
Fixes #35251 .
Built from https://develop.svn.wordpress.org/trunk@36258
git-svn-id: http://core.svn.wordpress.org/trunk@36225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 05:04:26 +00:00
Boone Gorges
2c96c289cf
Add missing param to 'comments_template_query_args'.
...
As introduced in [36235].
Props birgire.
See #34442 .
Built from https://develop.svn.wordpress.org/trunk@36256
git-svn-id: http://core.svn.wordpress.org/trunk@36223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 02:28:27 +00:00
Pascal Birchler
d63ae29fac
After [36254], commit all the necessary files and not just the unit test.
...
Built from https://develop.svn.wordpress.org/trunk@36255
git-svn-id: http://core.svn.wordpress.org/trunk@36222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 19:07:26 +00:00
Pascal Birchler
34dfb47c4b
Rewrite: Ensure `WP_Rewrite::flush_rules()` does not delete the 'rewrite_rules' option.
...
Instead, the option gets updated to an empty string.
Adds unit tests.
Props SergeyBiryukov, jesin, voldemortensen.
Fixes #29107 .
Built from https://develop.svn.wordpress.org/trunk@36254
git-svn-id: http://core.svn.wordpress.org/trunk@36221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 19:02:26 +00:00
Pascal Birchler
73317a33b6
Permalinks: Ensure the page hierarchy is correct for sample permalinks.
...
Fixes #35368 .
Built from https://develop.svn.wordpress.org/trunk@36253
git-svn-id: http://core.svn.wordpress.org/trunk@36220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 18:28:28 +00:00
Boone Gorges
909470db67
Don't reset index keys when trimming results of term queries.
...
`array_slice()` must be told to preserve keys when the query results exceed the
limit specified the 'number' parameter, so that `id=>parent` and other
id-indexed return value formats don't get mangled.
Props fantasyworld, wpdelighter.
Fixes #35382 .
Built from https://develop.svn.wordpress.org/trunk@36252
git-svn-id: http://core.svn.wordpress.org/trunk@36219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 04:06:25 +00:00
Boone Gorges
cfae56d2c2
Avoid invalid SQL when building ORDER BY clause using long search strings.
...
The introduction of negative search terms in 4.4 [34934] introduced the
possibility that the ORDER BY clause of a search query could be assembled in
such a way as to create invalid syntax. The current changeset fixes this by
ensuring that the ORDER BY clause corresponding to the search terms is
excluded when it would otherwise be empty.
Props salvoaranzulla.
Fixes #35361 .
Built from https://develop.svn.wordpress.org/trunk@36251
git-svn-id: http://core.svn.wordpress.org/trunk@36218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 03:26:26 +00:00
John Blackbourn
a4facedfee
Docs: Various docblock corrections.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@36250
git-svn-id: http://core.svn.wordpress.org/trunk@36217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 01:26:25 +00:00
John Blackbourn
877d14883e
Emoji: Explictly use `https` as the scheme for emoji fallback images, as they're only served over HTTPS by the CDN anyway.
...
Fixes #35376
Props ocean90
Built from https://develop.svn.wordpress.org/trunk@36249
git-svn-id: http://core.svn.wordpress.org/trunk@36216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 01:24:26 +00:00
John Blackbourn
f63dc802cb
Comments: Correct the docblocks for various methods in the comment list table class.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@36248
git-svn-id: http://core.svn.wordpress.org/trunk@36215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 00:52:25 +00:00
John Blackbourn
16fe7012dd
Taxonomy: More tests for `unregister_taxonomy()`.
...
See #35227
Built from https://develop.svn.wordpress.org/trunk@36247
git-svn-id: http://core.svn.wordpress.org/trunk@36214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 23:35:26 +00:00
Eric Lewis
c52af7470b
Login is not a verb, change "login" to "log in".
...
See #35387
Built from https://develop.svn.wordpress.org/trunk@36246
git-svn-id: http://core.svn.wordpress.org/trunk@36213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 21:08:26 +00:00
Eric Lewis
2f41867519
Users: Fix incorrect docs for user authentication and login functions.
...
Fixes #35387
Built from https://develop.svn.wordpress.org/trunk@36245
git-svn-id: http://core.svn.wordpress.org/trunk@36212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 20:52:27 +00:00
Pascal Birchler
2e4210e209
Taxonomy: Use `Invalid taxonomy` instead of `Invalid Taxonomy` for error strings.
...
Built from https://develop.svn.wordpress.org/trunk@36244
git-svn-id: http://core.svn.wordpress.org/trunk@36211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 15:16:25 +00:00
Pascal Birchler
710501dc53
Taxonomy: Introduce `unregister_taxonomy()`.
...
This new function can be used to completely unregister non built-in taxonomies.
Fixes #35227 .
Built from https://develop.svn.wordpress.org/trunk@36243
git-svn-id: http://core.svn.wordpress.org/trunk@36210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 14:58:26 +00:00
Pascal Birchler
d591f26ce7
Ensure `wp_get_referer()` returns `false` when the referrer URL is the current URL.
...
Adds unit tests.
Fixes #19856 .
Built from https://develop.svn.wordpress.org/trunk@36242
git-svn-id: http://core.svn.wordpress.org/trunk@36209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 14:36:26 +00:00
Pascal Birchler
fdb6bbfa10
Media: After [36240], remove some unneeded whitespace.
...
Props ocean90.
See #35367 .
Built from https://develop.svn.wordpress.org/trunk@36241
git-svn-id: http://core.svn.wordpress.org/trunk@36208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 14:29:26 +00:00
Pascal Birchler
8ee945d82f
Media: Fix `wp_audio_shortcode` and `wp_video_shortcode` attributes handling.
...
Although documented, the `class` and `style` attributes were simply ignored.
Adds unit tests.
Fixes #35367 .
Built from https://develop.svn.wordpress.org/trunk@36240
git-svn-id: http://core.svn.wordpress.org/trunk@36207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 14:18:27 +00:00
Dion Hulse
43d8a30d0c
Tests: Add more paged canonical tests for page_on_front.
...
See #35344 .
Built from https://develop.svn.wordpress.org/trunk@36238
git-svn-id: http://core.svn.wordpress.org/trunk@36205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 08:09:26 +00:00
Dion Hulse
84a3b4407f
Canonical: Generate the correct canonical url for paged posts/pages when they're used as the page_on_front.
...
This fixes an issue where pages become inacessible on a front page post.
Fixes #35344 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36237
git-svn-id: http://core.svn.wordpress.org/trunk@36204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 07:33:27 +00:00
Dion Hulse
d57776b108
Tests: Remove some debug that's slipped in at some point.
...
Built from https://develop.svn.wordpress.org/trunk@36236
git-svn-id: http://core.svn.wordpress.org/trunk@36203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 06:12:27 +00:00
Boone Gorges
72265e4a98
Introduce `comments_template_query_args` filter.
...
This new filter gives developers a way to target the arguments used for comment
queries specifically when populating the main comment template.
Props birgire.
Fixes #34442 .
Built from https://develop.svn.wordpress.org/trunk@36235
git-svn-id: http://core.svn.wordpress.org/trunk@36202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 04:44:26 +00:00
Boone Gorges
4ce9b93af9
Clarify return types in `get_option()` documentation.
...
The new note specifies that scalar values will always be returned as strings.
Fixes #31820 .
Built from https://develop.svn.wordpress.org/trunk@36234
git-svn-id: http://core.svn.wordpress.org/trunk@36201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 03:12:26 +00:00
Andrew Ozz
5a6be6d431
Media: fix undefined error that prevents showing a preview in the media modal when replacing video or audio.
...
Fixes #35363 .
Built from https://develop.svn.wordpress.org/trunk@36233
git-svn-id: http://core.svn.wordpress.org/trunk@36200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 02:22:26 +00:00
John Blackbourn
a5d44337b2
Docs: `@param` fixes for a variety of docblocks.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@36232
git-svn-id: http://core.svn.wordpress.org/trunk@36199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 01:45:26 +00:00
John Blackbourn
7718e07129
Docs: Correct the parameter docs for various Heartbeat filters and functions.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@36231
git-svn-id: http://core.svn.wordpress.org/trunk@36198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 01:37:26 +00:00
John Blackbourn
7931478595
Feeds: Remove the `rss-http` feed type, unused since r32468.
...
See #15110
Built from https://develop.svn.wordpress.org/trunk@36230
git-svn-id: http://core.svn.wordpress.org/trunk@36197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 01:20:26 +00:00
Eric Lewis
b464b01c7e
Add documentation for parseData() and ajaxDel() in wp-lists.js.
...
Fixes #35360 .
Built from https://develop.svn.wordpress.org/trunk@36229
git-svn-id: http://core.svn.wordpress.org/trunk@36196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 00:05:26 +00:00
Eric Lewis
7733ed2ddc
Cron: Add the cron lock timestamp to the 'cron_request' filter arguments.
...
Fixes #31307
Built from https://develop.svn.wordpress.org/trunk@36228
git-svn-id: http://core.svn.wordpress.org/trunk@36195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 23:54:26 +00:00
Boone Gorges
cbb245196c
Use a more generous selector when setting up tag suggestion.
...
This allows taxonomy metaboxes to be registered in a greater variety of
locations on the Dashboard.
Props johnjamesjacoby..
Fixes #35349 .
Built from https://develop.svn.wordpress.org/trunk@36227
git-svn-id: http://core.svn.wordpress.org/trunk@36194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 23:18:25 +00:00
Boone Gorges
13629bf5d0
In `comments_template()`, don't run hierarchical queries if comment threading is disabled.
...
When hierarchical=true, `WP_Comment_Query` will always fetch comments according
to the comment hierarchy, even if 'thread_comments' is disabled for the site.
This can cause problems when comment threading is disabled after threaded
comments have been recorded on the site; comments will no longer be returned in
a strictly chronological order.
We address the issue by refraining from querying hierarchically when comment
threading is disabled.
Props jmdodd.
Fixes #35378 .
Built from https://develop.svn.wordpress.org/trunk@36226
git-svn-id: http://core.svn.wordpress.org/trunk@36193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 22:17:26 +00:00
Eric Lewis
d8e6199126
Permalinks: Make `get_post_type_archive_link()` work for the 'post' post type.
...
Props jjj.
See #19902 .
Built from https://develop.svn.wordpress.org/trunk@36225
git-svn-id: http://core.svn.wordpress.org/trunk@36192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 22:01:26 +00:00
Boone Gorges
5b4b4fc479
Introduce 'author_url' param to `WP_Comment_Query`.
...
Props swissspidy.
Fixes #35377 .
Built from https://develop.svn.wordpress.org/trunk@36224
git-svn-id: http://core.svn.wordpress.org/trunk@36191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 21:52:27 +00:00
Andrea Fercia
ae1575bd80
Media: make the Image Editor usable with a keyboard.
...
For accessibility, all interactive controls must be operable from the keyboard.
Replaces `<div>`s used as UI controls with buttons. Groups some logically-related
form elements.
Fixes #28864 .
Built from https://develop.svn.wordpress.org/trunk@36223
git-svn-id: http://core.svn.wordpress.org/trunk@36190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 19:13:26 +00:00
Andrea Fercia
1f9c29d98f
Accessibility: remove the title attribute from the `get_search_form()` HTML5 search field.
...
It was added in [23801] as a workaround for issues with very old browser/screen reader combos (Jaws7/IE6).
No more necessary today. Reduces redundancy and noise for screen reader users.
See #16539 .
Fixes #33952 .
Built from https://develop.svn.wordpress.org/trunk@36222
git-svn-id: http://core.svn.wordpress.org/trunk@36189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 19:01:26 +00:00
Konstantin Obenland
c252e77ce3
Plugins: Use plugin file rather than slug as identifier
...
The plugin file is unique while there can be more than one plugin with the
same slug. This also allows us to simplify the way updates from the plugin
detail iframe are executed.
See [36205].
Fixes #35350 .
Built from https://develop.svn.wordpress.org/trunk@36221
git-svn-id: http://core.svn.wordpress.org/trunk@36188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 17:48:28 +00:00
Dion Hulse
07e9d22968
Update to Random_Compat 1.1.5 to fix an issue with older libSodium modules.
...
Props sarciszewski.
Fixes #35327 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36220
git-svn-id: http://core.svn.wordpress.org/trunk@36187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 03:28:28 +00:00
Weston Ruter
0b8c6eed83
Customizer: Improve `_doing_it_wrong()` message when `widgets` or `nav_menus` are manually removed via `WP_Customize_Manager::remove_panel()`.
...
* Link to code reference page for `customize_loaded_components` instead of linking to a Trac comment.
* Remove HTML code from being included in translated string.
* Add missing translator comment for the specifiers in the translated string.
Amends [36216].
Props DrewAPicture.
Fixes #35242 .
Built from https://develop.svn.wordpress.org/trunk@36219
git-svn-id: http://core.svn.wordpress.org/trunk@36186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-07 18:44:28 +00:00
Pascal Birchler
0075480202
Tests: Fix unit tests after [36217].
...
See #35236 .
Built from https://develop.svn.wordpress.org/trunk@36218
git-svn-id: http://core.svn.wordpress.org/trunk@36185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-07 10:17:27 +00:00
Pascal Birchler
f079f57357
Rewrite: Add a `remove_rewrite_tag()` helper function.
...
It can be used to properly remove registered rewrite tags. Adds unit tests.
Fixes #35236 .
Built from https://develop.svn.wordpress.org/trunk@36217
git-svn-id: http://core.svn.wordpress.org/trunk@36184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-07 09:39:27 +00:00
Weston Ruter
668818e93d
Customizer: Call `_doing_it_wrong()` if `widgets` or `nav_menus` are manually removed via `WP_Customize_Manager::remove_panel()`.
...
Advise that the `customize_loaded_components` filter should be used instead.
Props voldemortensen.
See #33552 .
Fixes #35242 .
Built from https://develop.svn.wordpress.org/trunk@36216
git-svn-id: http://core.svn.wordpress.org/trunk@36183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-07 06:06:28 +00:00
Boone Gorges
74f83e1016
Allow comment agent and author IP to be set via `wp_update_comment()`.
...
Props adamsilverstein, welcher.
Fixes #35276 .
Built from https://develop.svn.wordpress.org/trunk@36215
git-svn-id: http://core.svn.wordpress.org/trunk@36182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-07 03:55:28 +00:00
Boone Gorges
0e0c6a7ee7
Ensure 'description' is a string in `wp_insert_term()`.
...
Passing `'description' => null` when creating a term can cause MySQL notices,
as the description column in the terms table does not allow for null values.
We correct this by intepreting a `null` description as an empty string.
Props TimothyBlynJacobs.
Fixes #35321 .
Built from https://develop.svn.wordpress.org/trunk@36214
git-svn-id: http://core.svn.wordpress.org/trunk@36181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-07 03:32:28 +00:00
Konstantin Obenland
0b9f825e29
Plugins: Avoid ID attribute collisions in plugins list table.
...
Removes id attributes with non-unique plugin slug and adds a data attribute
with the unique plugin file.
Props khag7.
Fixes #18974 .
Built from https://develop.svn.wordpress.org/trunk@36205
git-svn-id: http://core.svn.wordpress.org/trunk@36172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 22:40:26 +00:00
Konstantin Obenland
d5fd177b96
Themes: Avoid changing the count of themes with updates in network admin.
...
Makes the count bubble selector a little more specific to avoid interfering
with the admin menu, but not too specific for installed theme searches not to
update the bubble.
See [29786], [31495].
Fixes #35332 .
Built from https://develop.svn.wordpress.org/trunk@36204
git-svn-id: http://core.svn.wordpress.org/trunk@36171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 22:32:28 +00:00
Aaron Jorbin
7ab65139c6
Theme: Escape error messages
...
Built from https://develop.svn.wordpress.org/trunk@36185
git-svn-id: http://core.svn.wordpress.org/trunk@36152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 17:23:28 +00:00
Dion Hulse
83059c3553
Unit Tests: Fix the unit test added in [36181] to include the index in the comparison.
...
See #35235
Built from https://develop.svn.wordpress.org/trunk@36183
git-svn-id: http://core.svn.wordpress.org/trunk@36150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 08:10:26 +00:00
Dion Hulse
4a0e40a814
Updates: Don't perform an API call to WordPress.org for every plugin update displayed. The API has been updated to return this information with the update response.
...
See #35301
Built from https://develop.svn.wordpress.org/trunk@36182
git-svn-id: http://core.svn.wordpress.org/trunk@36149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 07:53:26 +00:00
Pascal Birchler
dbe28bf8e3
Rewrite: Add a `remove_permastruct()` helper function.
...
It can be used to remove permastructs that were added using `add_permastruct()`.
Fixes #35235 .
Built from https://develop.svn.wordpress.org/trunk@36181
git-svn-id: http://core.svn.wordpress.org/trunk@36148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 07:40:26 +00:00
Dion Hulse
06a3f799e7
Background Updates: Remove the 7am/7pm background update check. This check was made redundant by [28129] as background updates are now run after a version check takes place.
...
See #27772 , #35323 .
Built from https://develop.svn.wordpress.org/trunk@36180
git-svn-id: http://core.svn.wordpress.org/trunk@36147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 06:12:26 +00:00
Dominik Schilling
7d378fce01
Bundled Themes: Bump version number of Twenty Thirteen.
...
Props davidakennedy.
Fixes #35319 .
Built from https://develop.svn.wordpress.org/trunk@36179
git-svn-id: http://core.svn.wordpress.org/trunk@36146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-05 22:20:26 +00:00
Dominik Schilling
4cb341e82c
Install: Use new colors for error notices.
...
Props duaneblake, DBrumbaugh10Up.
Fixes #34704 .
Built from https://develop.svn.wordpress.org/trunk@36178
git-svn-id: http://core.svn.wordpress.org/trunk@36145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-05 21:47:25 +00:00
Pascal Birchler
85bb9aa5fb
Query: Add a `WP::remove_query_var()` helper function.
...
This makes cleaning up public query vars easier.
Fixes #35234 .
Built from https://develop.svn.wordpress.org/trunk@36177
git-svn-id: http://core.svn.wordpress.org/trunk@36144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-05 20:57:28 +00:00
Dominik Schilling
c9d7fb9b28
Install: Only enqueue scripts when necessary.
...
Props flixos90 for initial patch.
Fixes #34700 .
Built from https://develop.svn.wordpress.org/trunk@36176
git-svn-id: http://core.svn.wordpress.org/trunk@36143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-05 16:42:29 +00:00
Dominik Schilling
0929025aea
Docs: Move the hook doc for the `the_title` filter in `Walker_Page::start_el()` to directly precede the `apply_filters()` line.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36175
git-svn-id: http://core.svn.wordpress.org/trunk@36142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-05 16:35:26 +00:00
Dominik Schilling
0b6c5744dc
Nav Menus: Apply the `the_title` filter on original post titles in `wp_setup_nav_menu_item()`.
...
The filter is already used in `Walker_Nav_Menu_Checklist` and `Walker_Nav_Menu_Edit`. This ensures that titles are consistent across the admin and front end.
Fixes #35317 .
Built from https://develop.svn.wordpress.org/trunk@36174
git-svn-id: http://core.svn.wordpress.org/trunk@36141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-05 16:27:26 +00:00
Rachel Baker
e51c790844
Comments: Remove orphaned closing `td` tag within cancel button of Moderate Comment screen.
...
Left behind in r31641. See #23988 .
Props ash.matadeen.
Built from https://develop.svn.wordpress.org/trunk@36173
git-svn-id: http://core.svn.wordpress.org/trunk@36140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-05 16:07:27 +00:00
Andrea Fercia
b4cc1cfc48
Accessibility: Remove title attributes from the Admin Dashboard.
...
Uses `aria-label` and `screen-reader-text` where appropriate. Also removes
the default title attribute output by `privacy_on_link_title`, preserving
the ability to use the filter.
Fixes #35049 .
Built from https://develop.svn.wordpress.org/trunk@36172
git-svn-id: http://core.svn.wordpress.org/trunk@36139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-05 14:19:28 +00:00
Andrea Fercia
52920b8511
Introduce a new generic CSS clearfix utility class.
...
`.wp-clearfix` is now the recommended way to clear and contain floated elements.
Adds back compatibility for the `.nav-tab-wrapper` navigation tabs.
See #26396 .
Built from https://develop.svn.wordpress.org/trunk@36171
git-svn-id: http://core.svn.wordpress.org/trunk@36138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-05 13:38:30 +00:00
Konstantin Obenland
a9dab28f63
Template: Always display the site title on the front page.
...
Limits using the page title to the blog page when the site has a static front page,
bringing it N’Sync with `wp_title()`.
Props peterwilsoncc.
Fixes #34962 .
Built from https://develop.svn.wordpress.org/trunk@36168
git-svn-id: http://core.svn.wordpress.org/trunk@36134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-04 17:16:27 +00:00
Andrew Ozz
6abb7e6284
Media: when inserting an attachment in the editor and it is not an image, ensure the link is set to something else than `none`.
...
Props eherman24, azaozz.
Fizes #35153 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36166
git-svn-id: http://core.svn.wordpress.org/trunk@36132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-04 00:33:28 +00:00
Andrew Nacin
8090ae273d
XML-RPC: Revert [34681] as it broke date handling.
...
props dossy, hnle, redsweater.
see #35053 , #30429 (original ticket).
Built from https://develop.svn.wordpress.org/trunk@36163
git-svn-id: http://core.svn.wordpress.org/trunk@36129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-03 19:49:32 +00:00
Andrea Fercia
1b3ee7098a
Media: set the image editor spinner on the smallest possible area.
...
When using spinners as background images, the re-painted area should be the smallest
possible one. See similar performance issue in #31196 , #33311 , #33322 , and #34951 .
Fixes #35296 .
Built from https://develop.svn.wordpress.org/trunk@36162
git-svn-id: http://core.svn.wordpress.org/trunk@36128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-03 16:49:28 +00:00
Gary Pendergast
5a0f8ca847
Emoji: Add a test to the emoji loader, to see if the browser supports emoji diversity. If it doesn't, fall back to twemoji.
...
See #33592 .
Built from https://develop.svn.wordpress.org/trunk@36160
git-svn-id: http://core.svn.wordpress.org/trunk@36126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-03 04:26:27 +00:00
Boone Gorges
6b31ff88d8
Fix incorrect `@covers` annotation in `get_adjacent_post()` tests.
...
Introduced in [36077].
Props netweb.
Fixes #35211 .
Built from https://develop.svn.wordpress.org/trunk@36159
git-svn-id: http://core.svn.wordpress.org/trunk@36125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-03 02:44:27 +00:00
Boone Gorges
31ef230595
Ensure that non-default pagination values work in `wp_list_comments()`.
...
Prior to 4.4, it was possible to pass 'page' and 'per_page' values to
`wp_list_comments()` that do not match the corresponding global query vars.
This ability was lost in 4.4 with the refactor of how `comments_template()`
queries for comments; when the main comment query started fetching only the
comments that ought to appear on a page, instead of all of a post's comments,
it became impossible for the comment walker to select comments corresponding to
custom pagination parameters. See #8071 .
We restore the previous behavior by (a) detecting when a 'page' or 'per_page'
parameter has been passed to `wp_list_comments()` that does not match the
corresponding query vars (so that the desired comments will not be found in
`$wp_query`), and if so, then (b) querying for all of the post's comments and
passing them to the comment walker for pagination, as was the case before 4.4.
Props boonebgorges, smerriman.
Fixes #35175 .
Built from https://develop.svn.wordpress.org/trunk@36157
git-svn-id: http://core.svn.wordpress.org/trunk@36123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-03 02:03:28 +00:00
Dominik Schilling
ef3442a2fe
Docs: Remove indentation from the `hidden_columns` changelog entry.
...
Added in [36154].
See #35057 .
Built from https://develop.svn.wordpress.org/trunk@36156
git-svn-id: http://core.svn.wordpress.org/trunk@36122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-02 15:16:28 +00:00
Dion Hulse
f802d26f10
List Tables: When a user has hidden all columns, do not override that with the `default_hidden_columns` filter.
...
Props Compute, jorbin, voldemortensen.
Fixes #35057
Built from https://develop.svn.wordpress.org/trunk@36154
git-svn-id: http://core.svn.wordpress.org/trunk@36120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-02 04:44:27 +00:00
Sergey Biryukov
267c524a07
Docs: Correct `get_page_uri()` description.
...
Props ericlewis.
Fixes #35165 .
Built from https://develop.svn.wordpress.org/trunk@36143
git-svn-id: http://core.svn.wordpress.org/trunk@36109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-01 18:29:27 +00:00
Andrea Fercia
78e6aa46c1
Accessibility: Don't mark up "URL" as an abbreviation.
...
"URL" has essentially entered language as a self-contained concept, there's
no more need to expand it with an `<abbr>` element and a title attribute.
Fixes #35174 .
Built from https://develop.svn.wordpress.org/trunk@36142
git-svn-id: http://core.svn.wordpress.org/trunk@36108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-01 12:10:26 +00:00
Gary Pendergast
5d943e3be3
Bump the `license.txt` year to 2016.
...
Happy New Year, all y'all!
Built from https://develop.svn.wordpress.org/trunk@36141
git-svn-id: http://core.svn.wordpress.org/trunk@36107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-01 10:00:27 +00:00
Sergey Biryukov
7950c2de31
Export: Add a missing Oxford comma.
...
Props juhise.
Fixes #35275 .
Built from https://develop.svn.wordpress.org/trunk@36140
git-svn-id: http://core.svn.wordpress.org/trunk@36106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 19:33:25 +00:00
Rachel Baker
2bdc6a5fd0
Docs: Add null to `post_id` param type, fix syntax, and descriptions in the DocBlock for `wp_update_comment_count()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36139
git-svn-id: http://core.svn.wordpress.org/trunk@36105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 19:21:28 +00:00
Rachel Baker
4aa970e0e8
Feeds: Comments on attachments display in the site-wide comments RSS feed.
...
Individual attachment pages already have their own RSS comment feed, and would be expected to be included in the site-wide comments RSS feed.
Props jbrinley.
Fixes #15610
Built from https://develop.svn.wordpress.org/trunk@36138
git-svn-id: http://core.svn.wordpress.org/trunk@36104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 17:16:27 +00:00
Andrea Fercia
f13881d4e3
Admin: Restore the "Show advanced menu properties" checkboxes IDs.
...
These checkboxes are used on the Menus screen options and the Customizer Menus options.
Their IDs were removed in [34991] but they're needed to get the checkboxes to be saved
via AJAX. Also, avoids a useless AJAX call.
Fixes #35112 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36137
git-svn-id: http://core.svn.wordpress.org/trunk@36103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 11:52:26 +00:00
Pascal Birchler
d15b5318b5
Twenty Thirteen: Add missing loop in the image attachment template.
...
Props vtieu.
Fixes #35110 .
Built from https://develop.svn.wordpress.org/trunk@36136
git-svn-id: http://core.svn.wordpress.org/trunk@36102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 11:39:26 +00:00
Pascal Birchler
25ca04b95f
Docs: Improve readability of the default arguments of `wp_list_categories()`.
...
Adds missing documentation for the `separator` argument introduced in [35140].
Props birgire for initial patch.
Fixes #34751 .
Built from https://develop.svn.wordpress.org/trunk@36135
git-svn-id: http://core.svn.wordpress.org/trunk@36101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 11:30:27 +00:00
Andrea Fercia
27e5599bf7
Admin: fix repositioning of notices when the first header is not an immediate children of `.wrap`.
...
Props DvanKooten for the initial patch.
Fixes #35047 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36134
git-svn-id: http://core.svn.wordpress.org/trunk@36100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 11:05:31 +00:00
Dion Hulse
7bc4b19203
XMLRPC: Revert [35509] which caused a change of behviour in at least one XMLRPC client.
...
XMLRPC has many quirks in it's operation, #16980 being just one of the many, #35185 just became yet another quirk.
See #16980 .
Fixes #35185 .
Built from https://develop.svn.wordpress.org/trunk@36132
git-svn-id: http://core.svn.wordpress.org/trunk@36098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 04:06:26 +00:00
Sergey Biryukov
7b3b8f6fd4
Widgets: Revert [34465], as it introduced a regression, making the `$index` argument of `dynamic_sidebar()` case-sensitive.
...
Fixes #34995 for trunk. See #23423 .
Built from https://develop.svn.wordpress.org/trunk@36130
git-svn-id: http://core.svn.wordpress.org/trunk@36096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 03:13:26 +00:00
Gary Pendergast
b23280fe49
Redirects: Prevent redirects if a queried object exists.
...
After [34659], it became possible to cause an incorrect redirect, by changing the slug of a post, then creating a new post with the old slug. The correct behaviour is to prevent redirecting to the old post.
Props dd32, pento.
Fixes #35031 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36128
git-svn-id: http://core.svn.wordpress.org/trunk@36094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 03:01:29 +00:00
Sergey Biryukov
d160543282
Query: Remove a stray debug line from `WP_Query::get_posts()`.
...
Props dlh.
Fixes #35271 .
Built from https://develop.svn.wordpress.org/trunk@36127
git-svn-id: http://core.svn.wordpress.org/trunk@36093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 02:23:30 +00:00
Gary Pendergast
3057c03474
Emoji: Update emoji support to Unicode 8.0, including the Diversity set.
...
Fixes #33592 .
Built from https://develop.svn.wordpress.org/trunk@36126
git-svn-id: http://core.svn.wordpress.org/trunk@36092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 01:30:27 +00:00
Pascal Birchler
2c9896e8d1
Comments: Don't nofollow links within the site.
...
Fixes #11360 .
Built from https://develop.svn.wordpress.org/trunk@36125
git-svn-id: http://core.svn.wordpress.org/trunk@36091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-30 23:20:25 +00:00
Pascal Birchler
7e516f5cf8
Plugins: Add a new `pre_uninstall_plugin` action that runs right before uninstalling a plugin.
...
Fixes #34569 .
Built from https://develop.svn.wordpress.org/trunk@36124
git-svn-id: http://core.svn.wordpress.org/trunk@36090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-30 22:38:26 +00:00
Pascal Birchler
66d239c034
Embeds: Change attachment metadata condition to prevent a warning in the embeds template.
...
Fixes #35237 .
Built from https://develop.svn.wordpress.org/trunk@36123
git-svn-id: http://core.svn.wordpress.org/trunk@36089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-30 22:25:28 +00:00
Andrea Fercia
d3eea5477c
Media: Fix icons for HiDPI displays on the media modal after [32952].
...
Props vtieu.
Fixes #35200 .
Built from https://develop.svn.wordpress.org/trunk@36122
git-svn-id: http://core.svn.wordpress.org/trunk@36088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-30 18:32:29 +00:00
Andrew Ozz
d03333735f
Responsive images: fix the check whether the attachment meta matches the image src to work with http/https and CDNs.
...
Props webaware, joemcgill, azaozz.
Fixes #35045 and #35102 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36121
git-svn-id: http://core.svn.wordpress.org/trunk@36087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-30 01:04:27 +00:00
Andrew Ozz
597bbf0318
Responsive images: add compatibility for versions < 2.7 when the full image path was stored in the metadata. Introduces `_wp_get_attachment_relative_path()` and uses it in `wp_get_attachment_url()`.
...
Props dd32, SergeyBiryukov.
Fixes #35106 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36120
git-svn-id: http://core.svn.wordpress.org/trunk@36086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-30 00:06:28 +00:00