Sergey Biryukov
75857aa857
Users: Use `wp_update_user()` in `get_password_reset_key()`.
...
Props jayswadas, spacedmonkey, donmhico, SergeyBiryukov.
Fixes #45746 .
Built from https://develop.svn.wordpress.org/trunk@45714
git-svn-id: http://core.svn.wordpress.org/trunk@45525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 17:25:55 +00:00
Sergey Biryukov
f6189321e1
Users: Reorganize `user_nicename`, `user_url`, `user_registered` setting in `wp_insert_user()` for consistency with the order or fields in the database.
...
See #45746 .
Built from https://develop.svn.wordpress.org/trunk@45713
git-svn-id: http://core.svn.wordpress.org/trunk@45524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 17:13:57 +00:00
Sergey Biryukov
4a6461dcc2
Users: Use `get_password_reset_key()` in `wp_new_user_notification()`.
...
Props mrasharirfan, spacedmonkey.
Fixes #45745 .
Built from https://develop.svn.wordpress.org/trunk@45712
git-svn-id: http://core.svn.wordpress.org/trunk@45523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 15:30:58 +00:00
Sergey Biryukov
6623a824d0
Taxonomy: Correct some strict comparisons after [45710].
...
See #47573 .
Built from https://develop.svn.wordpress.org/trunk@45711
git-svn-id: http://core.svn.wordpress.org/trunk@45522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 15:04:56 +00:00
Sergey Biryukov
3e1126d940
Coding Standards: Use strict comparison in `wp-includes/taxonomy.php`.
...
Props andizer, SergeyBiryukov.
Fixes #47573 .
Built from https://develop.svn.wordpress.org/trunk@45710
git-svn-id: http://core.svn.wordpress.org/trunk@45521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 13:45:56 +00:00
Sergey Biryukov
fd03949143
Coding Standards: Fix WPCS violations after [45708].
...
See #45747 .
Built from https://develop.svn.wordpress.org/trunk@45709
git-svn-id: http://core.svn.wordpress.org/trunk@45520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 12:03:56 +00:00
Sergey Biryukov
b32cff72c2
Users: Deprecate `update_user_status()` in favor of `wp_update_user()`.
...
Props spacedmonkey, SergeyBiryukov.
Fixes #45747 .
Built from https://develop.svn.wordpress.org/trunk@45708
git-svn-id: http://core.svn.wordpress.org/trunk@45519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 11:28:54 +00:00
Sergey Biryukov
2d574d673f
Database: Use a strict comparison for `has_filter()` check in `wpdb::placeholder_escape()`.
...
The filter is added with a priority of `0`, so a loose comparison had an unintended effect of adding the filter on every call.
Props withinboredom.
Fixes #47430 .
Built from https://develop.svn.wordpress.org/trunk@45707
git-svn-id: http://core.svn.wordpress.org/trunk@45518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 02:25:56 +00:00
K. Adam White
5f9ba92af4
REST API: Skip processing fields which are not present in the selected context.
...
In `WP_REST_Controller::get_fields_for_response()`, exclude fields which are not registered to appear in the request's context.
In conjunction with r45705 this prevents the unnecessary computation of the sample permalink when making a request that is not context=edit.
Props dlh.
Fixes #45605 .
Built from https://develop.svn.wordpress.org/trunk@45706
git-svn-id: http://core.svn.wordpress.org/trunk@45517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-31 20:21:56 +00:00
K. Adam White
d296736b75
REST API: Generate sample permalink only when a dependent field is requested.
...
The sample permalink will now only be generated if the derivative `permalink_template` or `generated_slug` fields are to be included in the response, preventing an unnecessary database request for each post (via `wp_unique_post_slug()`) when those fields are not requested.
Props dlh.
See #45605 .
Built from https://develop.svn.wordpress.org/trunk@45705
git-svn-id: http://core.svn.wordpress.org/trunk@45516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-31 20:00:57 +00:00
Sergey Biryukov
ee23869c68
Docs: Correct parameter documentation for `bulk_edit_custom_box` and `quick_edit_custom_box` actions.
...
Props abrain.
Fixes #47810 .
Built from https://develop.svn.wordpress.org/trunk@45704
git-svn-id: http://core.svn.wordpress.org/trunk@45515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-31 15:10:58 +00:00
Sergey Biryukov
fec01b0685
Docs: Correct parameter type and description for `is_email` filter.
...
Props jenkoian.
Fixes #47793 .
Built from https://develop.svn.wordpress.org/trunk@45703
git-svn-id: http://core.svn.wordpress.org/trunk@45514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-31 01:26:54 +00:00
Sergey Biryukov
383c1df66b
Docs: Correct `@return` value description for `get_term_link()`.
...
Props garrett-eclipse.
Fixes #47806 .
Built from https://develop.svn.wordpress.org/trunk@45702
git-svn-id: http://core.svn.wordpress.org/trunk@45513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-31 01:19:56 +00:00
Tammie Lister
d5c7657189
Media: Reduces the bulk media options to have one primary button
...
This fixes where 2 primary buttons were showing for bulk actions within media trash.
Props garrett-eclipse, afercia, ianbelanger, SergeyBiryukov
Fixes #46757 , #46758
Built from https://develop.svn.wordpress.org/trunk@45701
git-svn-id: http://core.svn.wordpress.org/trunk@45512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-30 23:20:57 +00:00
Tammie Lister
fa9980049e
Admin: Improve Dashboard icon contrast.
...
The icons used across the dashboard had too low contrast to pass AA WCAG guidelines. They’re now slightly darker for better contrast.
Props @melchoyce, @SergeyBiryukov, @chetan200891 , @kjellr
Fixes #46935
Built from https://develop.svn.wordpress.org/trunk@45700
git-svn-id: http://core.svn.wordpress.org/trunk@45511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-30 22:54:57 +00:00
Sergey Biryukov
c7493264a4
Rewrite Rules: Check if `$wp_rewrite->flush_rules()` is callable before calling it in `flush_rewrite_rules()`.
...
Props bsetiawan88, markjaquith.
Fixes #47087 .
Built from https://develop.svn.wordpress.org/trunk@45699
git-svn-id: http://core.svn.wordpress.org/trunk@45510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 17:52:56 +00:00
Sergey Biryukov
98642b4821
Users: Use case-insensitive email address comparison when checking whether "Grant this user super admin privileges" checkbox should be displayed on Edit User screen.
...
Props trepmal.
Fixes #47119 .
Built from https://develop.svn.wordpress.org/trunk@45698
git-svn-id: http://core.svn.wordpress.org/trunk@45509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 17:42:55 +00:00
Sergey Biryukov
ec8940edeb
Coding Standards: Fix WPCS violations in `wp-admin/includes/class-walker-nav-menu-edit.php`.
...
Props sudhiryadav, audrasjb.
Fixes #46902 .
Built from https://develop.svn.wordpress.org/trunk@45697
git-svn-id: http://core.svn.wordpress.org/trunk@45508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:53:52 +00:00
Sergey Biryukov
c9942bb3d8
Coding Standards: Fix WPCS violations in [45694].
...
See #47466 .
Built from https://develop.svn.wordpress.org/trunk@45696
git-svn-id: http://core.svn.wordpress.org/trunk@45507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:52:56 +00:00
Sergey Biryukov
e7abdc7040
Docs: Improve the DocBlocks for `got_mod_rewrite()`, `extract_from_markers()`, `insert_with_markers()`.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@45695
git-svn-id: http://core.svn.wordpress.org/trunk@45506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:35:56 +00:00
Sergey Biryukov
67e5038470
Rewrite Rules: Add a comment to `# BEGIN/END` `.htaccess` markers to clarify that the directives are dynamically generated, and should only be modified via WordPress filters.
...
Introduce `insert_with_markers_inline_instructions` filter to modify the default instructions text.
Props bradleyt, SergeyBiryukov.
Fixes #47466 .
Built from https://develop.svn.wordpress.org/trunk@45694
git-svn-id: http://core.svn.wordpress.org/trunk@45505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:31:57 +00:00
Sergey Biryukov
7a4d1b5dbd
Permalinks: Improve appearance of URL examples on Permalink Settings screen.
...
Props luan-ramos, sarath.ar.
Fixes #41559 .
Built from https://develop.svn.wordpress.org/trunk@45693
git-svn-id: http://core.svn.wordpress.org/trunk@45504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:11:56 +00:00
Sergey Biryukov
b95b055225
Administration: Allow breaking long strings in `<code>` tags at any point, to avoid overflowing on mobile.
...
Props david.binda, mukesh27.
Fixes #47329 .
Built from https://develop.svn.wordpress.org/trunk@45692
git-svn-id: http://core.svn.wordpress.org/trunk@45503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:09:55 +00:00
Sergey Biryukov
a59301c2ba
Site Health: Consistently use `wpdb::db_version()` for checking the database server version, instead of partically replicating its functionality.
...
Props Clorith, wpfed.
Fixes #47738 .
Built from https://develop.svn.wordpress.org/trunk@45691
git-svn-id: http://core.svn.wordpress.org/trunk@45502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 14:55:57 +00:00
Dominik Schilling
182f813e24
I18N: Display the logged out message in the user's locale
...
Built from https://develop.svn.wordpress.org/trunk@45690
git-svn-id: http://core.svn.wordpress.org/trunk@45501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-27 14:31:55 +00:00
Dominik Schilling
391d6a3f2b
I18N: Following [45688], remove test for removed method.
...
See #44865 .
Built from https://develop.svn.wordpress.org/trunk@45689
git-svn-id: http://core.svn.wordpress.org/trunk@45500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-27 14:30:57 +00:00
Dominik Schilling
892a80d974
I18N: Use RTL stylesheets when running from /src.
...
To run WordPress from /src you have to use the `--dev` flag which also builds the RTL stylesheets thus the admin notice and force to LTR is no longer required.
See #44492 .
Fixes #44865 .
Built from https://develop.svn.wordpress.org/trunk@45688
git-svn-id: http://core.svn.wordpress.org/trunk@45499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-27 14:17:57 +00:00
Dominik Schilling
4d3ca52c45
REST API: Pass current request object to `rest_authentication_errors` filter in `WP_REST_Server::check_authentication()`.
...
Fixes #46907 .
Built from https://develop.svn.wordpress.org/trunk@45687
git-svn-id: http://core.svn.wordpress.org/trunk@45498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-27 13:44:57 +00:00
Dominik Schilling
81bfb111d1
Tools: Remove internationalization tools (also known as `makepot.php`).
...
It has been a great pleasure to work with `makepot.php` over the past [https://i18n.trac.wordpress.org/changeset/4169/ 11 years] but now it's time to say goodbye.
The tools have been integrated into WP-CLI as [https://developer.wordpress.org/cli/commands/i18n/make-pot/ wp i18n make-pot] and [https://developer.wordpress.org/cli/commands/i18n/make-json/ wp i18n make-json]. The new commands were optimized to support current PHP versions and are more flexible and reliable when extracting strings for PHP, and JavaScript.
Access to the old tools continue to exist in previous branches or at https://i18n.svn.wordpress.org/tools/ .
Fixes #45287 .
Built from https://develop.svn.wordpress.org/trunk@45686
git-svn-id: http://core.svn.wordpress.org/trunk@45497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-27 13:10:56 +00:00
Dominik Schilling
8059b362e8
I18N: Add support for custom `WP_PLUGIN_URL` in `load_script_textdomain()`.
...
Plugins may not be on the same host/path as the rest of the content. To support loading translations for this setup check if the script source matches `plugins_url()`.
Also fixes an undefined index notice when a custom content URL has no path.
Props odminstudios, ocean90.
Fixes #46336 , #46387 .
Built from https://develop.svn.wordpress.org/trunk@45685
git-svn-id: http://core.svn.wordpress.org/trunk@45496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-27 12:44:56 +00:00
Sergey Biryukov
0af752e360
Accessibility: Toolbar: Make the `min-width` value for `#wpadminbar` at `782px` breakpoint consistent with that of `<body>`.
...
This ensures that the "My Account" toolbar item stays visible at high zoom levels.
Props isabel_brison, chetan200891.
Fixes #47603 .
Built from https://develop.svn.wordpress.org/trunk@45684
git-svn-id: http://core.svn.wordpress.org/trunk@45495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-26 22:04:55 +00:00
Sergey Biryukov
f933abef11
Accessibility: Taxonomy: When a new category or tag is being added, show a spinner and noop the button to avoid multiple requests.
...
Props andg, afercia, guddu1315, SergeyBiryukov.
Fixes #47607 .
Built from https://develop.svn.wordpress.org/trunk@45683
git-svn-id: http://core.svn.wordpress.org/trunk@45494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-26 17:46:56 +00:00
Sergey Biryukov
5cdbe22b16
Administration: Merge CSS rules for `#adminmenu .wp-submenu a` in one place.
...
Props ozmatflc, AkSDvP.
Fixes #47780 .
Built from https://develop.svn.wordpress.org/trunk@45682
git-svn-id: http://core.svn.wordpress.org/trunk@45493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-26 13:49:57 +00:00
Sergey Biryukov
33b2fbc7e7
REST API: Make "Could not update meta value in database" error messages more helpful.
...
Props apermo, AkSDvP.
Fixes #46252 .
Built from https://develop.svn.wordpress.org/trunk@45681
git-svn-id: http://core.svn.wordpress.org/trunk@45492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-26 13:20:56 +00:00
Sergey Biryukov
e925997562
Site Health: Show parent theme in its own accordion on Site Health Info screen; rename "Other Themes" to "Inactive Themes".
...
Props garrett-eclipse, mukesh27, Clorith, xkon, msaggiorato.
Fixes #46925 .
Built from https://develop.svn.wordpress.org/trunk@45680
git-svn-id: http://core.svn.wordpress.org/trunk@45491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-26 03:49:55 +00:00
Sergey Biryukov
dae07c8216
Coding Standards: Fix newlines in `wp-includes/date.php`.
...
See #47775 .
Built from https://develop.svn.wordpress.org/trunk@45679
git-svn-id: http://core.svn.wordpress.org/trunk@45490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-26 00:12:55 +00:00
Sergey Biryukov
cff445d55f
Coding Standards: Move `wp-includes/date.php` to `wp-includes/class-wp-date-query.php`.
...
This renames the file containing the `WP_Date_Query` class to conform to the coding standards.
This commit also includes:
- A new `date.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.
Fixes #47775 . See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45678
git-svn-id: http://core.svn.wordpress.org/trunk@45489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 23:31:56 +00:00
Sergey Biryukov
ace077085d
I18N: Update translator comment missed in [45676].
...
See #47771 .
Built from https://develop.svn.wordpress.org/trunk@45677
git-svn-id: http://core.svn.wordpress.org/trunk@45488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 22:56:55 +00:00
Sergey Biryukov
a186dbcb65
I18N: Update translator comments after [45674].
...
See #47771 .
Built from https://develop.svn.wordpress.org/trunk@45676
git-svn-id: http://core.svn.wordpress.org/trunk@45487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 22:52:56 +00:00
Sergey Biryukov
ac10f9b9e4
Bundled Themes: Replace Codex URLs with a corresponding HelpHub or DevHub article.
...
Props ianbelanger, tobifjellner, SergeyBiryukov.
See #47771 .
Built from https://develop.svn.wordpress.org/trunk@45675
git-svn-id: http://core.svn.wordpress.org/trunk@45486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 22:46:55 +00:00
Sergey Biryukov
8e85299a00
General: First pass at replacing Codex URLs with a corresponding HelpHub or DevHub article.
...
Props ianbelanger, tobifjellner, SergeyBiryukov.
See #47771 .
Built from https://develop.svn.wordpress.org/trunk@45674
git-svn-id: http://core.svn.wordpress.org/trunk@45485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 22:45:57 +00:00
Sergey Biryukov
ccba6c4aec
Upgrade/Install: Bring some consistency to installation screen styles.
...
* Include `forms.css` and `l10n.css`, for consistency with login screen and other admin screens.
* Remove redundant `@import` directives from `login.css` for files already declared as dependencies.
* Adjust margin on password strength meter for consistency with other fields.
* Increase font size for "You will need this password to log in" notice.
* Fix misaligned icon on "Hide" button for the password.
Props iseulde, dan@micamedia.com , bassgang, cdog, johnbillion, nmenescardi, mukesh27, SergeyBiryukov.
Fixes #35776 , #47757 , #47758 .
Built from https://develop.svn.wordpress.org/trunk@45673
git-svn-id: http://core.svn.wordpress.org/trunk@45484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 19:11:55 +00:00
Sergey Biryukov
1d283ef54f
Docs: Clarify that `is_network_admin()` does not check if the site is a Multisite network; `is_multisite()` should be used for that.
...
Props svovaf, dilipbheda, tazotodua.
Fixes #47415 .
Built from https://develop.svn.wordpress.org/trunk@45672
git-svn-id: http://core.svn.wordpress.org/trunk@45483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 15:19:58 +00:00
Sergey Biryukov
8ab7bbe385
Posts, Post Types: Introduce `is_sticky` filter in `is_sticky()` to provide more flexibility for custom sticky post implementations.
...
Props dehisok, greenshady.
Fixes #37629 .
Built from https://develop.svn.wordpress.org/trunk@45671
git-svn-id: http://core.svn.wordpress.org/trunk@45482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 01:36:54 +00:00
Sergey Biryukov
316fa4aecb
Code Editor: Check for correct `mode` value in `wp.codeEditor.initialize` to enable autocomplete support for PHP.
...
Props ediamin.
Fixes #47769 .
Built from https://develop.svn.wordpress.org/trunk@45670
git-svn-id: http://core.svn.wordpress.org/trunk@45481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 01:27:57 +00:00
Sergey Biryukov
aee690fd84
Permalinks: Update URLs for "Changing File Permissions" documentation article.
...
Props patilswapnilv, ianbelanger, SergeyBiryukov.
Fixes #47768 .
Built from https://develop.svn.wordpress.org/trunk@45669
git-svn-id: http://core.svn.wordpress.org/trunk@45480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 01:18:55 +00:00
Sergey Biryukov
5522be31e7
Coding Standards: Use correct variable in `wp_dropdown_categories()` after [45667].
...
See #45059 .
Built from https://develop.svn.wordpress.org/trunk@45668
git-svn-id: http://core.svn.wordpress.org/trunk@45479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 01:07:54 +00:00
Sergey Biryukov
18bd01985b
Coding Standards: Rename `$r` variable used with `wp_parse_args()` to `$parsed_args` for clarity.
...
Props freewebmentor.
Fixes #45059 .
Built from https://develop.svn.wordpress.org/trunk@45667
git-svn-id: http://core.svn.wordpress.org/trunk@45478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 00:48:58 +00:00
Gary Pendergast
7112ee7132
Coding Standards: Move the remaining PHPCS errors to report as warnings, and add Travis tests.
...
The remaining error-level coding standards issues (specifically, associated with the sniffs `WordPress.PHP.YodaConditions.NotYoda`, `WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase`, `WordPress.DB.PreparedSQL.InterpolatedNotPrepared`, `WordPress.DB.PreparedSQL.NotPrepared`, and `WordPress.Files.FileName.InvalidClassFileName`) are marked as warnings, until they're all addressed.
This change allows us to run linting on Travis across the entire codebase, ensuring no other error-level violations can be introduced.
Additionally, PHPCS will now cache results locally, drastically improving performance for subsequent checks: scanning the entire codebase takes 1-2 minutes the first time, and less than one second for subsequent checks.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45665
git-svn-id: http://core.svn.wordpress.org/trunk@45476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-19 07:48:56 +00:00
Gary Pendergast
172117d35f
Coding Standards: Fix a filename replacement missed in [45663].
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45664
git-svn-id: http://core.svn.wordpress.org/trunk@45475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-19 04:42:57 +00:00
Gary Pendergast
af0a914d14
Coding Standards: Move `wp-includes/class-oembed.php` to `wp-includes/class-wp-oembed.php`.
...
This renames the file containing the `WP_oEmbed` class to conform to the coding standards.
This commit also includes:
- A new `class-oembed.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45663
git-svn-id: http://core.svn.wordpress.org/trunk@45474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-19 04:32:57 +00:00
Gary Pendergast
971814047f
Coding Standards: Move wp-admin/custom-background.php to wp-admin/includes/class-custom-background.php
...
This renames the file containing the Custom_Background class to conform to the coding standards.
This commit also includes:
- A new custom-background.php that includes the new file, for anyone that may've been including the file directly.
- Replaces a reference to the old filename with the new filename.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45662
git-svn-id: http://core.svn.wordpress.org/trunk@45473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-19 04:02:55 +00:00
Gary Pendergast
744ffe8e00
Coding Standards: Exclude a handful of incorrectly named files that won't be renamed.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45661
git-svn-id: http://core.svn.wordpress.org/trunk@45472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-19 03:50:59 +00:00
Gary Pendergast
1f5fcff132
Coding Standards: Improve spacing of `printf()` calls in the admin About pages.
...
Props garrett-eclipse.
Fixes #47734 .
Built from https://develop.svn.wordpress.org/trunk@45660
git-svn-id: http://core.svn.wordpress.org/trunk@45471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-19 00:09:58 +00:00
Sergey Biryukov
1c331e8931
I18N: Make URLs to ` https://wordpress.org/about/ ` and related pages translatable, as they can now be localized on Rosetta sites.
...
Props mukesh27.
Fixes #46386 .
Built from https://develop.svn.wordpress.org/trunk@45659
git-svn-id: http://core.svn.wordpress.org/trunk@45470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-18 12:41:57 +00:00
Gary Pendergast
22412b1d97
Customizer: Show all widgets when the search field is cleared.
...
When clicking the clear button on the widget search field, the search results should refresh to show all widgets.
Props Mahesh901122.
Fixes #47534 .
Built from https://develop.svn.wordpress.org/trunk@45658
git-svn-id: http://core.svn.wordpress.org/trunk@45469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-18 05:55:59 +00:00
Sergey Biryukov
7149d65934
Editor: Replace external Classic Editor plugin URL with a link to Add Plugins screen with Classic Editor pre-selected.
...
This applies to messages displayed when JavaScript is disabled in Block Editor, or an incompatible meta box is used.
Props garrett-eclipse, derweili, afercia.
Fixes #47487 .
Built from https://develop.svn.wordpress.org/trunk@45657
git-svn-id: http://core.svn.wordpress.org/trunk@45468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-18 01:33:57 +00:00
Sergey Biryukov
4b460d0f80
Coding Standards: Fix WPCS issues in [45655].
...
See #47723 .
Built from https://develop.svn.wordpress.org/trunk@45656
git-svn-id: http://core.svn.wordpress.org/trunk@45467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-17 19:22:56 +00:00
Sergey Biryukov
f7c4398ea9
Menus: Trim whitespace from custom link URLs.
...
Props majemedia, SergeyBiryukov.
Fixes #47723 .
Built from https://develop.svn.wordpress.org/trunk@45655
git-svn-id: http://core.svn.wordpress.org/trunk@45466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-17 18:45:58 +00:00
Gary Pendergast
24d08a9463
Coding Standards: Move `wp-admin/custom-header.php` to `wp-admin/includes/class-custom-image-header.php`
...
This renames the file containing the `Custom_Image_Header` class to conform to the coding standards.
This commit also includes:
- A new `custom-header.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45654
git-svn-id: http://core.svn.wordpress.org/trunk@45465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-17 06:17:56 +00:00
Gary Pendergast
83427a87a9
Coding Standards: Exclude some class names from checks when they can't be renamed.
...
Renaming the classes would likely cause back compat issues, so the safest option is to allow this handful to continue unchanged.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45653
git-svn-id: http://core.svn.wordpress.org/trunk@45464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-17 04:34:55 +00:00
Sergey Biryukov
970fe7d85c
Coding Standards: Fix WPCS issues in [45651].
...
See #38195 .
Built from https://develop.svn.wordpress.org/trunk@45652
git-svn-id: http://core.svn.wordpress.org/trunk@45463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-17 01:50:58 +00:00
Sergey Biryukov
6cb424b978
Media: Add "Documents", "Spreadsheets", and "Archives" groups to file type filter in Media Library.
...
Props zodiac1978, swissspidy, karmatosed, SergeyBiryukov.
Fixes #38195 .
Built from https://develop.svn.wordpress.org/trunk@45651
git-svn-id: http://core.svn.wordpress.org/trunk@45462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-17 01:22:55 +00:00
Sergey Biryukov
1f256f3fdc
Administration: In `admin-ajax.php`, send `X-Robots-Tag` header earlier, so that it applies before `wp_die()` when no action parameter was provided.
...
Props robi-bobi, harryfear, garrett-eclipse.
Fixes #47711 .
Built from https://develop.svn.wordpress.org/trunk@45650
git-svn-id: http://core.svn.wordpress.org/trunk@45461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-17 01:11:56 +00:00
Sergey Biryukov
66afb60397
Site Health: Use consistent verbiage for "Learn more" links.
...
Props ronakganatra, garrett-eclipse.
Fixes #47302 .
Built from https://develop.svn.wordpress.org/trunk@45649
git-svn-id: http://core.svn.wordpress.org/trunk@45460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 22:28:57 +00:00
Sergey Biryukov
f600647e22
Site Health: Replace "harddrive" with "device" on Site Health Info screen.
...
Props chetan200891, timhavinga, Cybr, Clorith.
Fixes #46965 .
Built from https://develop.svn.wordpress.org/trunk@45648
git-svn-id: http://core.svn.wordpress.org/trunk@45459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 22:19:55 +00:00
Sergey Biryukov
e5ad773194
I18N: Merge duplicate "Your plugins/themes/translations are all up to date" strings.
...
Props ramiy.
Fixes #47252 .
Built from https://develop.svn.wordpress.org/trunk@45647
git-svn-id: http://core.svn.wordpress.org/trunk@45458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 22:13:58 +00:00
Sergey Biryukov
2ac05ca7d5
Media: Add a unit test for `wp_get_mime_types()`.
...
Props pbearne.
Fixes #47701 .
Built from https://develop.svn.wordpress.org/trunk@45646
git-svn-id: http://core.svn.wordpress.org/trunk@45457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 21:52:57 +00:00
Andrew Ozz
5eba5381e6
Media: Sort the new sizes array by priority when creating image sub-sizes.
...
See #40439 .
Built from https://develop.svn.wordpress.org/trunk@45645
git-svn-id: http://core.svn.wordpress.org/trunk@45456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 21:48:56 +00:00
Sergey Biryukov
6f2fe4da8f
Customize: In `WP_Customize_Widgets::capture_filter_pre_update_option()`, return the filtered value instead of `null` when bailing early for ignored options.
...
Props dlh.
Fixes #47715 .
Built from https://develop.svn.wordpress.org/trunk@45644
git-svn-id: http://core.svn.wordpress.org/trunk@45455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 21:33:57 +00:00
Sergey Biryukov
62216de5d4
Docs: Move the `do_mu_upgrade` DocBlock out of the preceding `if` statement.
...
Props ChriCo, dkarfa.
Fixes #47710 .
Built from https://develop.svn.wordpress.org/trunk@45643
git-svn-id: http://core.svn.wordpress.org/trunk@45454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 13:15:58 +00:00
Sergey Biryukov
62dc808103
Docs: Correct `@since` tag for `do_mu_upgrade` hook, for consistency with `after_mu_upgrade` and `wpmu_upgrade_site`.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@45642
git-svn-id: http://core.svn.wordpress.org/trunk@45453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 12:42:59 +00:00
Sergey Biryukov
c0e53279b3
Comments: Fix typo in comment reply observer options.
...
Props maguiar.
Fixes #47706 . See #46260 .
Built from https://develop.svn.wordpress.org/trunk@45641
git-svn-id: http://core.svn.wordpress.org/trunk@45452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-15 16:46:55 +00:00
Gary Pendergast
820ce9c438
Code Modernisation: Revert [45624].
...
Changing the method signatures on `Walker` causes back compat issues.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45640
git-svn-id: http://core.svn.wordpress.org/trunk@45451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-15 07:04:59 +00:00
Gary Pendergast
a571a7d621
Code Modernisation: Fix known instances of array access on data types that can't be accessed as arrays.
...
PHP 7.4 addes a warning when trying access a null/bool/int/float/resource (everything but array, string and object) as if it were an array.
This change fixes all of these warnings visible in unit tests.
Props jrf.
See #47704 .
Built from https://develop.svn.wordpress.org/trunk@45639
git-svn-id: http://core.svn.wordpress.org/trunk@45450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-15 06:25:57 +00:00
Gary Pendergast
bd45c7d3b9
Code Modernisation: Document when the Hash polyfills can be removed.
...
The Hash extension cannot be disabled as of PHP 7.4. So, while we can't remove these polyfills yet, we can document when we'll be able to.
Props jrf.
Fixes #47698 .
Built from https://develop.svn.wordpress.org/trunk@45638
git-svn-id: http://core.svn.wordpress.org/trunk@45449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-15 05:14:55 +00:00
Gary Pendergast
21df1bda5b
Code Modernisation: Remove the SPL autoloader polyfill.
...
As of PHP 5.3, the SPL extension cannot be disabled, so we no longer need this polyfill.
The file is kept with a `_deprecated_file()` call, to alert any plugins or themes that may be loading it directly.
Props jrf, ayeshrajans.
See #47698 , #46630 .
Built from https://develop.svn.wordpress.org/trunk@45637
git-svn-id: http://core.svn.wordpress.org/trunk@45448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-15 05:11:56 +00:00
Gary Pendergast
501b5f545b
Code Modernisation: Remove the `array_replace_recursive()` polyfill.
...
This function was added in PHP 5.3.0, so we no longer need the polyfill.
Props jrf.
See #47698 .
Built from https://develop.svn.wordpress.org/trunk@45636
git-svn-id: http://core.svn.wordpress.org/trunk@45447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-15 05:08:56 +00:00
Gary Pendergast
fbdb267634
WPDB: Allow custom data to be added to logged queries.
...
This adds a new method, `wpdb::log_query()`, and a new filter, `log_query_custom_data`. The custom data is stored as a new element in each entry of the `wpdb::$queries` array.
Props CrazyJaco, johnbillion, pento.
Fixes 42151.
Built from https://develop.svn.wordpress.org/trunk@45635
git-svn-id: http://core.svn.wordpress.org/trunk@45446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-15 04:07:57 +00:00
Sergey Biryukov
83d175cdd0
I18N: Add context for theme filter strings in `WP_MS_Themes_List_Table::get_views()`.
...
Props audrasjb.
Fixes #47695 .
Built from https://develop.svn.wordpress.org/trunk@45634
git-svn-id: http://core.svn.wordpress.org/trunk@45445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-14 14:47:56 +00:00
Sergey Biryukov
436a9512e2
Upgrade/Install: Remove debugging artifacts from `wp-admin/upgrade.php` added in [1229].
...
Props rahulvaza.
Fixes #47074 .
Built from https://develop.svn.wordpress.org/trunk@45633
git-svn-id: http://core.svn.wordpress.org/trunk@45444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-14 14:39:57 +00:00
Sergey Biryukov
e85a5c64a3
REST API: Allow `rest_get_avatar_urls()` to accept full user, post, or comment objects, rather than just an email address, to provide better flexibility for alternative avatar data.
...
Since the function uses `get_avatar_url()` internally, which already supports it, this should not have any backward compatibility concerns.
Props donmhico, dshanske, pputzer, joehoyle, TimothyBlynJacobs.
Fixes #40030 .
Built from https://develop.svn.wordpress.org/trunk@45632
git-svn-id: http://core.svn.wordpress.org/trunk@45443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-14 14:35:56 +00:00
Andrew Ozz
ee8813606d
TinyMCE: fix adding of too many undo levels for wpviews. The HTML changes several times when a wpview is added. We only want one undo level. Also fixes cases when the cursor is next to an embeddable URL in the Text tab and the user switches to the Visual tab.
...
See #45307 .
Built from https://develop.svn.wordpress.org/trunk@45631
git-svn-id: http://core.svn.wordpress.org/trunk@45442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 03:25:55 +00:00
Gary Pendergast
4d3a84aa9f
Code Modernisation: Introduce the spread operator in `wpdb::prepare()`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45630
git-svn-id: http://core.svn.wordpress.org/trunk@45441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:17:57 +00:00
Gary Pendergast
2fe355cdd0
Code Modernisation: Introduce the spread operator in `widgets.php`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45629
git-svn-id: http://core.svn.wordpress.org/trunk@45440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:14:58 +00:00
Gary Pendergast
afdbf749d7
Code Modernisation: Introduce the spread operator in `theme.php`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf, pento.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45628
git-svn-id: http://core.svn.wordpress.org/trunk@45439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:10:56 +00:00
Gary Pendergast
1af80c2106
Code Modernisation: Introduce the spread operator in `walk_page_dropdown_tree()`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45627
git-svn-id: http://core.svn.wordpress.org/trunk@45438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:06:55 +00:00
Sergey Biryukov
02c07f23d5
Customize: Fix text direction for color picker in RTL.
...
Props vjik for the report.
Fixes #47688 . See #23740 .
Built from https://develop.svn.wordpress.org/trunk@45626
git-svn-id: http://core.svn.wordpress.org/trunk@45437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:05:57 +00:00
Gary Pendergast
5fb46ff14b
Code Modernisation: Introduce the spread operator in `add_post_type_support()`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf, pento.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45625
git-svn-id: http://core.svn.wordpress.org/trunk@45436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:02:56 +00:00
Gary Pendergast
41ea1f106d
Code Modernisation: Introduce the spread operator in `Walker`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45624
git-svn-id: http://core.svn.wordpress.org/trunk@45435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 23:51:56 +00:00
Gary Pendergast
4de2f2f49b
Code Modernisation: Introduce the spread operator in `WP_User`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45623
git-svn-id: http://core.svn.wordpress.org/trunk@45434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 23:48:56 +00:00
Gary Pendergast
5d658427a8
Code Modernisation: Introduce the spread operator in `capabilities.php`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45622
git-svn-id: http://core.svn.wordpress.org/trunk@45433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 23:46:56 +00:00
Andrew Ozz
ff723a2fba
Editor: Make registered editor stylesheets (editor-style.css) available to the front-end.
...
Props webmandesign, azaozz.
Fixes #34882 .
Built from https://develop.svn.wordpress.org/trunk@45621
git-svn-id: http://core.svn.wordpress.org/trunk@45432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 18:30:57 +00:00
Andrew Ozz
969699260d
TinyMCE: fix flickering inline toolbar when showing a tooltip. Take two.
...
Fixes #44911 .
Built from https://develop.svn.wordpress.org/trunk@45620
git-svn-id: http://core.svn.wordpress.org/trunk@45431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 18:18:58 +00:00
Gary Pendergast
bb8afb46b9
Block Editor: Avoid a PHP warning when a theme adds an editor style with an empty filename.
...
Fixes #45739 .
Built from https://develop.svn.wordpress.org/trunk@45619
git-svn-id: http://core.svn.wordpress.org/trunk@45430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 07:21:55 +00:00
Gary Pendergast
4c3d541e23
Block Editor: Fix the link to the classic editor when incompatible meta boxen are detected.
...
Props tmatsuur, mukesh27.
Fixes #45935 .
Built from https://develop.svn.wordpress.org/trunk@45618
git-svn-id: http://core.svn.wordpress.org/trunk@45429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 06:01:58 +00:00
Sergey Biryukov
7369ff02f5
Coding Standards: Remove extra whitespace in list tables' `column_cb()` methods.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45617
git-svn-id: http://core.svn.wordpress.org/trunk@45428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 21:11:58 +00:00
Sergey Biryukov
9a5f538153
Coding Standards: Remove extra whitespace in `wp-admin/includes/image-edit.php`.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45616
git-svn-id: http://core.svn.wordpress.org/trunk@45427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 21:05:57 +00:00
Sergey Biryukov
6a696f6051
I18N: Move code out of translatable string in a `_deprecated_argument()` message in `wp_stream_image()`, `wp_save_image_file()`, and `image_edit_apply_changes()`.
...
Props ramiy.
Fixes #47406 .
Built from https://develop.svn.wordpress.org/trunk@45615
git-svn-id: http://core.svn.wordpress.org/trunk@45426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 20:57:56 +00:00
Sergey Biryukov
bb365054b8
Menus: Remove extra whitespace from URLs in `Walker_Nav_Menu_Edit::start_el()`.
...
Props alexeyskr, SergeyBiryukov.
Fixes #47666 .
Built from https://develop.svn.wordpress.org/trunk@45614
git-svn-id: http://core.svn.wordpress.org/trunk@45425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 20:45:56 +00:00
Sergey Biryukov
29e5155969
Filesystem API: Check correct variable in `WP_Filesystem_Direct::dirlist()` after [45611].
...
Props zinigor.
Fixes #47668 . See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45613
git-svn-id: http://core.svn.wordpress.org/trunk@45424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 15:58:57 +00:00
Gary Pendergast
4be25f3d06
Coding Standards: Fix instances of `WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase`.
...
See #46732 .
Built from https://develop.svn.wordpress.org/trunk@45612
git-svn-id: http://core.svn.wordpress.org/trunk@45423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 06:29:57 +00:00
Gary Pendergast
abcbee954f
Coding Standards: Fix instances of `WordPress.PHP.NoSilencedErrors.Discouraged`.
...
Noteable changes:
- The `magic_quotes_runtime` and `magic_quotes_sybase` settings were removed in PHP 5.4, so no longer need to be set.
- Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
- Quite a few functions would cause errors if `safe_mode` was set. This setting was removed in PHP 5.4.
- Only a handful of `header()` calls needed corresponding `headers_sent()` checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.
See #46732 .
Built from https://develop.svn.wordpress.org/trunk@45611
git-svn-id: http://core.svn.wordpress.org/trunk@45422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 05:45:58 +00:00
Andrew Ozz
4a273484f3
TinyMCE: fix flickering inline toolbar when hovering over the buttons there and the vertical scrollbar is not shown (the page height is less than the window height). Improves/removes the previous fix for similar flickering but only in RTL, see #42018 .
...
Props joakimsilfverberg, mukesh27, kokers, Howdy_McGee, noisysocks, azaozz.
Fixes #44911 .
Built from https://develop.svn.wordpress.org/trunk@45610
git-svn-id: http://core.svn.wordpress.org/trunk@45421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 01:11:55 +00:00
Gary Pendergast
c71bc1513e
Coding Standards: Add missing translator comments to the default themes.
...
All default themes now have translator comments for all strings with placeholders!
See #46732 .
Built from https://develop.svn.wordpress.org/trunk@45609
git-svn-id: http://core.svn.wordpress.org/trunk@45420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 01:10:00 +00:00
Gary Pendergast
82935b0343
Theme Editor: Hide the recommendation to create a child theme when editing a child theme.
...
Props mukesh27, davidbaumwald.
Fixes #44889 .
Built from https://develop.svn.wordpress.org/trunk@45608
git-svn-id: http://core.svn.wordpress.org/trunk@45419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-08 03:15:56 +00:00
Gary Pendergast
ec07a7e565
Coding Standards: Fix the remaining issues in `/tests`.
...
All PHP files in `/tests` now conform to the PHP coding standards, or have exceptions appropriately marked.
Travis now also runs `phpcs` on the `/tests` directory, any future changes to these files must conform entirely to the WordPress PHP coding standards. 🎉
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45607
git-svn-id: http://core.svn.wordpress.org/trunk@45418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-08 00:56:56 +00:00
laurelfulford
83e19085a3
Twenty Thirteen: Add styles for the new Group block.
...
Add styles for the new Group block to the theme, to make sure nested blocks display correctly when using the wide and full alignments.
Props @kjellr.
Fixes #46778 .
Built from https://develop.svn.wordpress.org/trunk@45606
git-svn-id: http://core.svn.wordpress.org/trunk@45417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-07 20:49:55 +00:00
laurelfulford
5b4b6d98ce
Twenty Nineteen: Add styles for the new Group block.
...
Add styles for the new Group block to the theme, to make sure nested blocks display correctly when using the wide and full alignments.
Props @kjellr, @dianeco.
Fixes #46750 .
Built from https://develop.svn.wordpress.org/trunk@45605
git-svn-id: http://core.svn.wordpress.org/trunk@45416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-07 20:11:57 +00:00
Gary Pendergast
28a8f31ffa
Coding Standards: Add missing translator comments.
...
Twentys Eleven, Sixteen, and Seventeen now have translator comments for all their strings.
Also, WPCS now doesn't show missing translator comment warnings for test files.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45604
git-svn-id: http://core.svn.wordpress.org/trunk@45415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 08:04:57 +00:00
Gary Pendergast
14c7533162
Coding Standards: Fix all `WordPress.DB.PreparedSQLPlaceholders` issues.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45603
git-svn-id: http://core.svn.wordpress.org/trunk@45414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 05:43:55 +00:00
Gary Pendergast
87675d288b
Coding Standards: Fix all `WordPress.WhiteSpace.PrecisionAlignment` issues.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45602
git-svn-id: http://core.svn.wordpress.org/trunk@45413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 05:21:56 +00:00
Gary Pendergast
f69c20859e
Coding Standards: Fix all `WordPress.CodeAnalysis.AssignmentInCondition` issues.
...
`WordPress.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition` can be ignored, as this is allowed in Core.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45601
git-svn-id: http://core.svn.wordpress.org/trunk@45412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 03:14:56 +00:00
Gary Pendergast
d378f0a8f4
Coding Standards: Upgrade WPCS to 2.1.1.
...
Noteable changes:
- WPCS now throws warnings when non-strict comparisons are used. There are quite a few of them in Core. 🙃
- WPCS now detects and warns for assignments in loop conditions.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45600
git-svn-id: http://core.svn.wordpress.org/trunk@45411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 02:50:56 +00:00
Gary Pendergast
a02b5cc2a8
Coding Standards: Mark the handful of hook names with uppercase characters or hyphens as ignored.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45599
git-svn-id: http://core.svn.wordpress.org/trunk@45410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 01:45:56 +00:00
Sergey Biryukov
b8be081e7e
Text Changes: Use consistent question wording in database connection error messages.
...
Props Presskopp.
See #44878 .
Built from https://develop.svn.wordpress.org/trunk@45598
git-svn-id: http://core.svn.wordpress.org/trunk@45409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 10:58:56 +00:00
Sergey Biryukov
4af4c78a27
Text Changes: Use consistent question wording for plugin and theme deletion confirmations.
...
Props johnjamesjacoby, Presskopp.
Fixes #44878 .
Built from https://develop.svn.wordpress.org/trunk@45597
git-svn-id: http://core.svn.wordpress.org/trunk@45408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 09:56:57 +00:00
Sergey Biryukov
abe3ec288b
Twenty Nineteen: Fix markup errors in `twentynineteen_add_ellipses_to_nav()`:
...
* Add missing i18n for `aria-label` attribute.
* Remove redundant screen reader text superseded by `aria-label`.
* Remove unnecessary `id` and `class` attributes.
Props afercia, chetan200891, ianbelanger.
Fixes #47067 .
Built from https://develop.svn.wordpress.org/trunk@45596
git-svn-id: http://core.svn.wordpress.org/trunk@45407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 09:23:55 +00:00
Sergey Biryukov
d1815a5c91
Twenty Nineteen: Adjust markup in `twentynineteen_add_ellipses_to_nav()` for better readability.
...
See #47067 .
Built from https://develop.svn.wordpress.org/trunk@45595
git-svn-id: http://core.svn.wordpress.org/trunk@45406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 09:15:58 +00:00
Sergey Biryukov
f84ab5e19f
Twenty Nineteen: Update `package.json` with the latest package versions to pass `npm audit`.
...
Props netweb.
Fixes #47631 .
Built from https://develop.svn.wordpress.org/trunk@45594
git-svn-id: http://core.svn.wordpress.org/trunk@45405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 00:38:58 +00:00
Sergey Biryukov
3a57fee891
Script Loader: Remove unnecessary `jquery` dependency for `wp-sanitize.js`.
...
The file is written in plain JavaScript.
Props sstoqnov.
Fixes #47324 .
Built from https://develop.svn.wordpress.org/trunk@45593
git-svn-id: http://core.svn.wordpress.org/trunk@45404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 00:33:57 +00:00
Sergey Biryukov
f154cd0780
Bundled Themes: Remove extra semicolons from CSS files.
...
Props shashank3105, ianbelanger.
Fixes #47178 .
Built from https://develop.svn.wordpress.org/trunk@45592
git-svn-id: http://core.svn.wordpress.org/trunk@45403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 00:27:58 +00:00
Sergey Biryukov
268c64913e
Query: Make sure `$climits` variable in `WP_Query::get_posts()` is always defined to avoid a PHP notice.
...
Props juiiee8487, agengineering.
Fixes #47638 .
Built from https://develop.svn.wordpress.org/trunk@45591
git-svn-id: http://core.svn.wordpress.org/trunk@45402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-03 01:14:57 +00:00
Gary Pendergast
4803fc405e
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in `wp-includes`.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45590
git-svn-id: http://core.svn.wordpress.org/trunk@45401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 23:42:58 +00:00
Gary Pendergast
55b2d94cca
Formatting: Revert the changes to `wpautop()` in [45585,45587].
...
See #27350 .
Built from https://develop.svn.wordpress.org/trunk@45589
git-svn-id: http://core.svn.wordpress.org/trunk@45400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 11:22:56 +00:00
Gary Pendergast
073f379fd3
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in `tests`.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45588
git-svn-id: http://core.svn.wordpress.org/trunk@45399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 04:43:57 +00:00
Gary Pendergast
b57d185bb1
Formatting: Improve performance of `wpautop()` on large paragraphs.
...
Following [45585], older versions of PHP could segfault when attempting to autop paragraphs with 10,000+ characters.
Rather than having to negative lookahead for every character in the paragraph (which could run into recursion limits), we can quickly jump ahead to the next tag and start checking from there.
See #27350 .
Built from https://develop.svn.wordpress.org/trunk@45587
git-svn-id: http://core.svn.wordpress.org/trunk@45398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 03:29:55 +00:00
Gary Pendergast
d7b95b1a86
Docs: Update some function docs and signatures.
...
- Update the `_wp_specialchars()` docs to match the function signature.
- Update the `human_time_diff()` function signature to match the docs.
Props subrataemfluence.
Fixes #46845 .
Built from https://develop.svn.wordpress.org/trunk@45586
git-svn-id: http://core.svn.wordpress.org/trunk@45397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 01:45:58 +00:00
Gary Pendergast
23de362563
Clean up stray `<p>` tags added by `wpautop()` inside block level tags.
...
`autop()` can sometimes get confused and not clean up stray `<p>` or `</p>` tags inside block level elements, which produces sub-optimal HTML. While browsers can generally handle it, there's no need to make things harder for them if we don't have to.
Props pento, ayubi, pbearne, jond, azaozz, 1994rstefan, dionysous, MikeHansenMe, jorbin, miqrogroove, niallkennedy.
Fixes #27350 .
Built from https://develop.svn.wordpress.org/trunk@45585
git-svn-id: http://core.svn.wordpress.org/trunk@45396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 01:31:56 +00:00
Adam Silverstein
4568c13df8
Taxonomy: add a new 'terms_pre_query' filter to short circuit WP_Term_Query 'get_terms' queries.
...
Add a new `terms_pre_query` filter which returns null by default. Return a non-null value to bypass WordPress's default `get_terms` queries.
Props jarocks, boonebgorges, spacedmonkey.
Fixes #41246 .
Built from https://develop.svn.wordpress.org/trunk@45584
git-svn-id: http://core.svn.wordpress.org/trunk@45395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 20:48:58 +00:00
Gary Pendergast
cf3fa9f7c8
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in `wp-admin`.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45583
git-svn-id: http://core.svn.wordpress.org/trunk@45394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 12:52:01 +00:00
Gary Pendergast
b2d5a4216c
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in the base directory.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45582
git-svn-id: http://core.svn.wordpress.org/trunk@45393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 08:27:58 +00:00
Gary Pendergast
0d23be600e
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in the default themes.
...
See #47632
Built from https://develop.svn.wordpress.org/trunk@45581
git-svn-id: http://core.svn.wordpress.org/trunk@45392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 08:23:57 +00:00
Gary Pendergast
55af0f0d0a
Coding Standards: Fix/ignore the `WordPress.NamingConventions.ValidFunctionName` violations.
...
See #47632
Built from https://develop.svn.wordpress.org/trunk@45580
git-svn-id: http://core.svn.wordpress.org/trunk@45391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 08:01:57 +00:00
Gary Pendergast
072682b1ed
Multisite: Use `size_format()` in `display_space_usage()`.
...
Deleted code is the best code.
Fixes #28239 .
Built from https://develop.svn.wordpress.org/trunk@45579
git-svn-id: http://core.svn.wordpress.org/trunk@45390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 03:47:56 +00:00
Gary Pendergast
abc0f7dd32
Formatting: Trim leading whitespace in `esc_url()`.
...
Props toszcze.
Fixes #36369 .
Built from https://develop.svn.wordpress.org/trunk@45578
git-svn-id: http://core.svn.wordpress.org/trunk@45389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 03:29:57 +00:00
Gary Pendergast
f3ece5149f
Formatting: Don't add `<p>` tags inside `<svg>` tags.
...
Inline `<svg>`s should generally work, as browsers should just ignore `<p>` or `<br/>` tags that shouldn't be inside the `<svg>`. To keep things neat, however, it's better not add them in the first place.
Props jared_smith, nacin, pento.
Fixes #9437 .
Built from https://develop.svn.wordpress.org/trunk@45577
git-svn-id: http://core.svn.wordpress.org/trunk@45388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 03:19:58 +00:00
Sergey Biryukov
93f3335f13
Twenty Seventeen: Correct the CSS selectors intended to fix hover colors for MediaElement controls.
...
This is a follow-up to the previous fix in [45146], which didn't work as expected.
Props ryokuhi.
Fixes #47543 . See #40843 .
Built from https://develop.svn.wordpress.org/trunk@45576
git-svn-id: http://core.svn.wordpress.org/trunk@45387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-29 00:51:58 +00:00
youknowriad
405efef86c
Build/Test Tools: Fix the hello e2e test assertion.
...
The previous assertion was always valid because we assumed it returned a single object,
while in reality it was returning an array.
Props hideokamoto.
Fixes #47622 .
Built from https://develop.svn.wordpress.org/trunk@45575
git-svn-id: http://core.svn.wordpress.org/trunk@45386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-28 11:34:58 +00:00
Gary Pendergast
691ffce019
Formatting: Add correct `<p>` tags near `<hr>` tags.
...
It can be tricky to know when `wpautop()` should add `<p>` tags, but one thing we can be certain about is that they really shouldn't be anywhere near `<hr>` tags.
Now they aren't.
Props solarissmoke, MattyRob, pento.
Fixes #14674 .
Built from https://develop.svn.wordpress.org/trunk@45574
git-svn-id: http://core.svn.wordpress.org/trunk@45385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-28 07:16:56 +00:00
Gary Pendergast
dd38e9cc0b
Formatting: Add support for seconds to `human_time_diff()`.
...
The web has gotten so much faster since `human_time_diff()` was created, we need to be able to measure time differences with much finer granularity. Now, we can.
Props johnjamesjacoby, pento.
Fixes #35655 .
Built from https://develop.svn.wordpress.org/trunk@45573
git-svn-id: http://core.svn.wordpress.org/trunk@45384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-28 06:44:57 +00:00
Andrea Fercia
00704114e0
Accessibility: Make the Media modal an ARIA modal dialog.
...
For a number of years, the Media modal missed an explicit ARIA role and the required attributes for modal dialogs.
This was confusing for assistive technology users, since they may not realize they're inside a dialog, and that consequently the keyboard interactions may be different from the rest of the page. Lack of an explicit label for the dialog was confusing as well, since assistive technology users didn't have an immediate sense of what the dialog is for.
This change makes the Media modal meet the ARIA Authoring Practices recommendations, helping users better understand the purpose and interactions with the modal. Also, it makes sure to hide the rest of the page content from assistive technologies, until support for `aria-modal="true"` improves.
Additionally:
- moves the modal H1 heading to the beginning of the modal content
- changes the modal left menu position to make visual and DOM order match
- improves the `wp.media.view.FocusManager` documentation
Fixes #47145 .
Built from https://develop.svn.wordpress.org/trunk@45572
git-svn-id: http://core.svn.wordpress.org/trunk@45383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-27 12:33:56 +00:00
youknowriad
1714484132
Build/Test Tools: Make the local env scripts executable.
...
See #45165 .
Built from https://develop.svn.wordpress.org/trunk@45571
git-svn-id: http://core.svn.wordpress.org/trunk@45382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-27 12:06:55 +00:00
youknowriad
5cf8452ae9
Build/Test Tools: Add the e2e tests setup.
...
- Adds a local environment based on docker
- Adds the e2e tests setup
- Adds a "Hello World" e2e test to serve as a template
Props gziolo, herregroen, mcsf.
Fixes #45165 .
Built from https://develop.svn.wordpress.org/trunk@45570
git-svn-id: http://core.svn.wordpress.org/trunk@45381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-27 11:28:19 +00:00
Gary Pendergast
d2a64fdabd
Formatting: Don't convert smilies in ignored tags that have attributes.
...
Smilies in ignored tags are not supposed to be converted to emoji, but this can malfunction if the tag has attributes. For example, the Preformatted block with add a `class` to the `<pre>` tag.
Props pento, jikamens.
Fixes #47489 .
Built from https://develop.svn.wordpress.org/trunk@45569
git-svn-id: http://core.svn.wordpress.org/trunk@45380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-27 02:05:52 +00:00
Sergey Biryukov
573daa129c
Users: Pass `$length`, `$special_chars`, and `$extra_special_chars` parameters to the `random_password` filter in `wp_generate_password()`.
...
Props roytanck.
Fixes #47092 .
Built from https://develop.svn.wordpress.org/trunk@45568
git-svn-id: http://core.svn.wordpress.org/trunk@45379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-27 00:48:53 +00:00
Sergey Biryukov
9d7bd11631
Docs: Correct `@since` for `admin/edit-comments.js`, introduced in [3736].
...
See #47581 .
Built from https://develop.svn.wordpress.org/trunk@45567
git-svn-id: http://core.svn.wordpress.org/trunk@45378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-26 18:19:52 +00:00
Sergey Biryukov
e23ce44744
REST API: Call `WP_REST_Server::get_compact_response_links()` and `::get_raw_data()` static methods the right way.
...
Props andizer, TimothyBlynJacobs.
Fixes #47578 .
Built from https://develop.svn.wordpress.org/trunk@45566
git-svn-id: http://core.svn.wordpress.org/trunk@45377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-26 18:07:54 +00:00
John Blackbourn
bab5ed2df5
Docs: Correct and improve the docs for a few nonce-related functions.
...
See #47110
Built from https://develop.svn.wordpress.org/trunk@45565
git-svn-id: http://core.svn.wordpress.org/trunk@45376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-25 17:07:52 +00:00
Andrew Ozz
05c9032a0b
Editor: Fix undefined `$locked` var in edit-form-blocks.php when the `show_post_locked_dialog` filter is used to disable displaying of the dialog.
...
Props aprea.
Fixes #47604 .
Built from https://develop.svn.wordpress.org/trunk@45564
git-svn-id: http://core.svn.wordpress.org/trunk@45375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-25 15:03:52 +00:00