00cb4c7dbd
REST API: Prevent deletion of post revisions.
...
Allowing the client to delete revisions breaks the "audit trail" functionality. This is not allowed in WordPress and shouldn't be allowed through the API.
While not recommended, a plugin may opt-in to the previous behavior by setting a custom 'delete_post' capability for the revisions post type.
Props dlh, danielbachhuber, TimothyBlynJacobs, azaozz, kadamwhite.
Fixes #43709 .
Built from https://develop.svn.wordpress.org/trunk@45812
git-svn-id: http://core.svn.wordpress.org/trunk@45623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 22:01:55 +00:00
5dbb64d0dd
REST API: Cache results of get_item_schema on controller instances for performance.
...
Caches the output of get_item_schema() to avoid redundant recomputation of translatable strings and other computed values. This method is called many times per item in each REST request, and the results of the method should not vary between calls.
Additional schema fields are not cached.
Props kadamwhite, joehoyle, TimothyBlynJacobs.
Fixes #47871 .
Built from https://develop.svn.wordpress.org/trunk@45811
git-svn-id: http://core.svn.wordpress.org/trunk@45622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 21:09:55 +00:00
dbfa0c7ed4
REST API: Clarify arguments passed to rest route get & update callbacks.
...
Update doc block argument definitions to clarify that the REST API always passes an array to the `get_callback` and always passes an entity object to the `update_callback`.
Props TimothyBlynJacobs, salzano.
Fixes #44432 .
Built from https://develop.svn.wordpress.org/trunk@45810
git-svn-id: http://core.svn.wordpress.org/trunk@45621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 20:04:55 +00:00
8dcc10693f
REST API: Do not send response body if status is 204 or body is null.
...
Status code 204 should indicate no response body is sent. Previously, a "null" string was sent, which MacOS Safari would try to parse as JSON and thereby fail to complete the request.
Props TimothyBlynJacobs, andizer, matthias.thiel.
Fixes #43691 .
Built from https://develop.svn.wordpress.org/trunk@45809
git-svn-id: http://core.svn.wordpress.org/trunk@45620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 19:56:55 +00:00
b75420443c
REST API: Add test class file incorrectly omitted from [45807].
...
Props @TimothyBlynJacobs.
See #43392 .
Built from https://develop.svn.wordpress.org/trunk@45808
git-svn-id: http://core.svn.wordpress.org/trunk@45619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 17:21:55 +00:00
5b318f1dda
REST API: Support 'object' and 'array' types in register_meta() schemas.
...
Extends meta registration to support complex schema values, mirroring the functionality in the settings controller.
Error when trying to modify a meta key containing schema-nonconformant data.
Props @TimothyBlynJacobs, @birgire, @mnelson4, @flixos90.
Fixes #43392 .
Built from https://develop.svn.wordpress.org/trunk@45807
git-svn-id: http://core.svn.wordpress.org/trunk@45618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 17:17:55 +00:00
ab0b860db9
Users: When deleting users, exclude the current user from the content existence check.
...
The current user cannot be deleted, so the check is redundant in that context and should only be done for other users.
Props mt8.biz, SergeyBiryukov.
Fixes #47851 .
Built from https://develop.svn.wordpress.org/trunk@45806
git-svn-id: http://core.svn.wordpress.org/trunk@45617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 13:06:55 +00:00
7169586254
Schema: Add an index to `wp_options.autoload`.
...
Most sites will be unaffected by this change, but those with a large number of rows in `wp_options`, only a small number of which have `autoload` set, will see a significant performance improvement.
Sites with a large number of rows in `wp_options`, with many of them having `autoload` set will unfortunately see a performance penalty on top of the already very slow queries they're running, but this should be the minority of cases.
Props DanBUK.
Fixes #24044 .
Built from https://develop.svn.wordpress.org/trunk@45805
git-svn-id: http://core.svn.wordpress.org/trunk@45616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 07:13:55 +00:00
98ffc642a9
Networks and Sites: Trim site domain when creating a new site on Add New Site screen before further validation.
...
Props dharmin16, jeremyfelt, aubreypwd.
Fixes #44808 .
Built from https://develop.svn.wordpress.org/trunk@45804
git-svn-id: http://core.svn.wordpress.org/trunk@45615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 01:21:55 +00:00
d85ba82d8e
Docs: Add missing `@since` tag for `WP_Site_Health::has_late_cron()`.
...
See #47223 .
Built from https://develop.svn.wordpress.org/trunk@45803
git-svn-id: http://core.svn.wordpress.org/trunk@45614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 00:42:55 +00:00
1d7ae02376
Site Health Check: New tests file missed in [45801].
...
Built from https://develop.svn.wordpress.org/trunk@45802
git-svn-id: http://core.svn.wordpress.org/trunk@45613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 00:37:56 +00:00
a56256d158
Site Health Check: Increase time allowance for cron checks.
...
Introduces `WP_Site_Health::has_late_cron()` for late wp-cron jobs and extends the time allowance before a job is considered missed.
In a standard configuration using loopback requests, a job is considered late once past due and missed over five minutes past due.
Late and missed time frames are extended if `DISABLE_WP_CRON` is defined as `true` to allow for crontab tasks running less frequently. A job is considered late once it's 15 minutes past due and missed over one hour past due.
A file for site health unit tests has been introduced with tests for cron in critical, late and missed states.
Props rockfire, afragen, peterwilsoncc.
Fixes #47223 .
Built from https://develop.svn.wordpress.org/trunk@45801
git-svn-id: http://core.svn.wordpress.org/trunk@45612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 00:35:55 +00:00
b8c5530131
Build Tools: Change the PHPUnit Docker image's working directory to match the other images.
...
Also, pass the `WP_MULTISITE` environment variable along to the container.
See #47767 .
Built from https://develop.svn.wordpress.org/trunk@45800
git-svn-id: http://core.svn.wordpress.org/trunk@45611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 00:34:57 +00:00
b473b2241e
Build Tools: Run `composer` commands in a Docker container on Travis.
...
This tidies up the `.travis.yml` file a little more.
See #47767 .
Built from https://develop.svn.wordpress.org/trunk@45799
git-svn-id: http://core.svn.wordpress.org/trunk@45610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 23:12:55 +00:00
cc8e05df39
Widgets: Allow for short-circuiting widget output in `the_widget()` using the `widget_display_callback` filter, for consistency with output via a registered sidebar.
...
Props MarcGuay, donmhico.
Fixes #34226 .
Built from https://develop.svn.wordpress.org/trunk@45798
git-svn-id: http://core.svn.wordpress.org/trunk@45609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 23:03:55 +00:00
0e1343ee2b
Docs: Correct type for `query_var` argument of `register_taxonomy()`.
...
Props juiiee8487, audrasjb.
Fixes #47877 .
Built from https://develop.svn.wordpress.org/trunk@45797
git-svn-id: http://core.svn.wordpress.org/trunk@45608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 17:47:55 +00:00
c03a0bea8d
Posts, Post Types: In `wp_trim_words()` make sure the `$num_words` parameter is always an integer, as documented, to avoid a PHP warning.
...
Props donmhico, pikamander2.
Fixes #47867 .
Built from https://develop.svn.wordpress.org/trunk@45796
git-svn-id: http://core.svn.wordpress.org/trunk@45607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 17:18:55 +00:00
ae4087bca6
Users: Make `wp_list_authors()` unit tests more readable.
...
See #23498 .
Built from https://develop.svn.wordpress.org/trunk@45795
git-svn-id: http://core.svn.wordpress.org/trunk@45606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 15:36:57 +00:00
d6faa62338
Networks and Sites: Improve documentation and variable naming in `switch_to_blog()` and `restore_current_blog()`.
...
In `switch_to_blog()`:
* Rename `$blog_id` to `$prev_blog_id` for clarity.
* Rename `$new_blog` to `$new_blog_id` for consistency.
* Pass `$prev_blog_id` as a second parameter to `switch_blog` action, instead of the duplicated `$new_blog_id`. This only clarifies documentation and does not affect functionality, since the values are equal in the context where the DocBlock is located.
In `restore_current_blog()`:
* Rename `$blog` to `$new_blog_id` for clarity.
* Rename `$blog_id` to `$prev_blog_id` for clarity.
Props ChriCo, jeremyfelt, SergeyBiryukov.
Fixes #45594 .
Built from https://develop.svn.wordpress.org/trunk@45794
git-svn-id: http://core.svn.wordpress.org/trunk@45605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 14:29:56 +00:00
428a738f1d
Plugins: Adjust the pause before running plugin search AJAX request on "Add Plugins" screen to allow more time for using browser's autocomplete.
...
Props donmhico, apermo.
Fixes #46021 .
Built from https://develop.svn.wordpress.org/trunk@45793
git-svn-id: http://core.svn.wordpress.org/trunk@45604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 02:02:56 +00:00
3ce3927dc1
Coding Standards: Fix JSHint error in [45790].
...
See #41545 .
Built from https://develop.svn.wordpress.org/trunk@45792
git-svn-id: http://core.svn.wordpress.org/trunk@45603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 00:02:55 +00:00
4cf729f5a9
Site Health: Simplify the language in Status Health Info page introduction, add a link to Status page.
...
Props birgire, mukesh27, subrataemfluence, leogermani.
Fixes #46946 .
Built from https://develop.svn.wordpress.org/trunk@45791
git-svn-id: http://core.svn.wordpress.org/trunk@45602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-13 23:35:56 +00:00
3e605d3852
Comments: enable typing cmd/ctrl-enter to submit comment forms.
...
Add a key handler on the comment form that detects the cmd/ctrl-enter key press and submits the comment form.
Props xyfi, Lindstromer, helen, splitti.
Fixes #41545 .
Built from https://develop.svn.wordpress.org/trunk@45790
git-svn-id: http://core.svn.wordpress.org/trunk@45601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-13 21:26:56 +00:00
400ed5add0
Remove trailing white space in upgrade.php.
...
See #46349 .
Built from https://develop.svn.wordpress.org/trunk@45789
git-svn-id: http://core.svn.wordpress.org/trunk@45600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-13 19:53:55 +00:00
197b4a829b
Admin email verification:
...
- Add the `admin_email_lifespan` option when installing. Fixes a bug where the verification screen is shown right after installation.
- Reset the same option when upgrading and the user doing the DB upgrade is not an admin. This will ensure the email verification is shown next time an admin logs in.
- Use `site_url()` instead of `network_site_url()` for the form action. The latter seems needed only for password reset.
See #46349 .
Built from https://develop.svn.wordpress.org/trunk@45788
git-svn-id: http://core.svn.wordpress.org/trunk@45599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-13 17:40:55 +00:00
dc2e7e716f
Comments: Include post permalink in comment reply link.
...
Include the post's permalink when generating reply links in `get_comment_reply_link()` to account for comments displayed on index and archive pages.
This reapplies [32786] which was inadvertently reverted in [42360].
Props justinahinon, donmhico.
See #33383 .
Fixes #47174 .
Built from https://develop.svn.wordpress.org/trunk@45787
git-svn-id: http://core.svn.wordpress.org/trunk@45598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-13 05:09:56 +00:00
aa90dc4e8c
Docs: Clarify custom-fields support requirement for viewing custom post meta in REST API.
...
Fixes #47866 .
Built from https://develop.svn.wordpress.org/trunk@45786
git-svn-id: http://core.svn.wordpress.org/trunk@45597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-13 01:51:56 +00:00
28ad3662fc
Build Tools: Remove the old `docker-compose.yml` file, now no longer used.
...
See #47767 .
Built from https://develop.svn.wordpress.org/trunk@45785
git-svn-id: http://core.svn.wordpress.org/trunk@45596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-12 09:22:55 +00:00
20f833426a
Build Tools: Add the `docker-compose.yml` file, missed in [45783].
...
See #47767 .
Built from https://develop.svn.wordpress.org/trunk@45784
git-svn-id: http://core.svn.wordpress.org/trunk@45595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-12 09:21:56 +00:00
74d03c4692
Build Tools: Miscellaneous `local-env` improvements.
...
- Move the functionality for controlling `local-env` out of `package.json`, into JS scripts.
- Merge the `docker-compose` config files, and move it to the root directory. This allows `docker-compose.override.yml` to work for local overrides.
- Fix nginx redirecting to port 80 under some circumstances.
- `npm run env:install` now creates `wp-tests.config.php` for you.
- Cleaned up a bunch of cruft in `.travis.yml`.
See #47767 .
Built from https://develop.svn.wordpress.org/trunk@45783
git-svn-id: http://core.svn.wordpress.org/trunk@45594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-12 08:29:55 +00:00
99f4ff2578
Site Health: Add database charset and collation information to debug info.
...
Props sharaz, Clorith, SergeyBiryukov.
Fixes #47828 .
Built from https://develop.svn.wordpress.org/trunk@45782
git-svn-id: http://core.svn.wordpress.org/trunk@45593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-12 01:54:57 +00:00
e6a4b884f5
Docs: Improve documentation for various feed link functions and filters.
...
Props atachibana, SergeyBiryukov.
Fixes #47862 .
Built from https://develop.svn.wordpress.org/trunk@45781
git-svn-id: http://core.svn.wordpress.org/trunk@45592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-11 17:21:57 +00:00
b7e7a5321b
Docs: Improve documentation for `get_last_updated()`.
...
Props atachibana.
Fixes #47861 .
Built from https://develop.svn.wordpress.org/trunk@45780
git-svn-id: http://core.svn.wordpress.org/trunk@45591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-11 16:18:57 +00:00
80d153fb70
Docs: Improve documentation for `get_page_by_title()`.
...
Props atachibana.
Fixes #47860 .
Built from https://develop.svn.wordpress.org/trunk@45779
git-svn-id: http://core.svn.wordpress.org/trunk@45590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-11 12:42:56 +00:00
64290005f5
Docs: Document the `show_split_view` argument for `wp_text_diff()`.
...
Convert `$args` array documentation to hash notation.
Props riddhiehta02, jeremyfelt, SergeyBiryukov.
Fixes #47224 .
Built from https://develop.svn.wordpress.org/trunk@45778
git-svn-id: http://core.svn.wordpress.org/trunk@45589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-10 22:28:54 +00:00
1a9812d9b4
Widgets: Replace http with https in the link placeholder widget image
...
The existing placeholder can make the user think that they must use http. We should encourage the use of https.
Also, the block editor uses https for its placeholders. Let's add some consistency.
Props Chaton666, audrasjb, mukesh27.
Fixes #46320 .
Built from https://develop.svn.wordpress.org/trunk@45777
git-svn-id: http://core.svn.wordpress.org/trunk@45588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-09 17:06:55 +00:00
6e060079ae
Twenty Sixteen: Correct HelpHub URL in `readme.txt`.
...
See #47771 .
Built from https://develop.svn.wordpress.org/trunk@45776
git-svn-id: http://core.svn.wordpress.org/trunk@45587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-09 13:53:56 +00:00
092872c3fc
Twenty Nineteen: Add missing `Installation` section to `readme.txt`, for consistency with other themes.
...
See #47857 .
Built from https://develop.svn.wordpress.org/trunk@45775
git-svn-id: http://core.svn.wordpress.org/trunk@45586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-09 13:42:57 +00:00
aaea839402
Twenty Nineteen: Add missing copyright information.
...
Props poena, kjellr.
Fixes #47857 .
Built from https://develop.svn.wordpress.org/trunk@45774
git-svn-id: http://core.svn.wordpress.org/trunk@45585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-09 13:36:58 +00:00
441a3c97e0
Twenty Nineteen: Correct license URI.
...
Props munyagu, shital-patel.
Fixes #47850 .
Built from https://develop.svn.wordpress.org/trunk@45773
git-svn-id: http://core.svn.wordpress.org/trunk@45584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-09 02:57:59 +00:00
12aa773802
Feeds: Introduce the `get_self_link()` function.
...
Corresponds to the `self_link()` template function.
This matches other feed template functions, using one function to get the value, and a different function to echo it.
Props jojotjebaby, mobeen-abdullah, donmhico, audrasjb, dshanske.
Fixes #44838 .
Built from https://develop.svn.wordpress.org/trunk@45772
git-svn-id: http://core.svn.wordpress.org/trunk@45583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-09 01:31:56 +00:00
2aa8ce5bc5
REST API: In `get_rest_url()`, check if `$_SERVER['SERVER_NAME']` is set to avoid a PHP warning in CLI context.
...
Props paulschreiber.
Fixes #47854 .
Built from https://develop.svn.wordpress.org/trunk@45771
git-svn-id: http://core.svn.wordpress.org/trunk@45582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 20:20:55 +00:00
6041a08347
Bootstrap/Load: Change "Insufficient Requirements" `wp_die()` heading to "Requirements Not Met", which is more appropriate for the context it's used in.
...
Props yoavf.
Fixes #47575 .
Built from https://develop.svn.wordpress.org/trunk@45770
git-svn-id: http://core.svn.wordpress.org/trunk@45581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 12:54:56 +00:00
638bae9392
Emoji: Upgrade Twemoji to 12.1.2.
...
This upgrade adds support for the transgender flag: 🏳️⚧️
There's some additional housekeeping in this commit:
- Twemoji recently rearranged their repository and package, so `Gruntfile.js` needed tweaking to allow for that.
- As only new files were added in this Twemoji release, the CDN version didn't need updating.
Fixes #47852 .
Built from https://develop.svn.wordpress.org/trunk@45769
git-svn-id: http://core.svn.wordpress.org/trunk@45580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 04:05:55 +00:00
83187125e4
Bundled Themes: Audit and update version numbers passed to `wp_enqueue_script()` to ensure proper cache busting.
...
Props dswebsme, ianbelanger, justinahinon.
Fixes #46981 .
Built from https://develop.svn.wordpress.org/trunk@45768
git-svn-id: http://core.svn.wordpress.org/trunk@45579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 01:29:58 +00:00
e0563013ed
Bundled Themes: Audit and update version numbers passed to `wp_enqueue_style()` to ensure proper cache busting.
...
Props dswebsme, ianbelanger, desrosj.
Fixes #46979 .
Built from https://develop.svn.wordpress.org/trunk@45767
git-svn-id: http://core.svn.wordpress.org/trunk@45578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 01:25:58 +00:00
c965d2e097
Administration: Show a warning in Reading Settings when a Privacy Policy page is accidentally set as a Homepage or Posts page.
...
Props garrett-eclipse, subrataemfluence.
Fixes #46831 .
Built from https://develop.svn.wordpress.org/trunk@45766
git-svn-id: http://core.svn.wordpress.org/trunk@45577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 23:03:54 +00:00
b8fd2b631b
Bump grunt-patch-wordpress to 2.0.0
...
Fixes #47845
Props pento, kadamwhite, netweb, jorbin
Built from https://develop.svn.wordpress.org/trunk@45765
git-svn-id: http://core.svn.wordpress.org/trunk@45576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 15:09:57 +00:00
aa4ab3acdc
Twenty Seventeen: Correct height for a Button block without text.
...
Props ianbelanger, laurelfulford, nayana123.
Fixes #47414 .
Built from https://develop.svn.wordpress.org/trunk@45764
git-svn-id: http://core.svn.wordpress.org/trunk@45575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 11:57:54 +00:00
64202a7ca3
Twenty Eleven: Correct height for a Button block without text.
...
Props ianbelanger, laurelfulford, nayana123.
See #47414 .
Built from https://develop.svn.wordpress.org/trunk@45763
git-svn-id: http://core.svn.wordpress.org/trunk@45574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 11:56:57 +00:00
d5d58a90f9
Build Tools: Switch all Travis PHPUnit jobs over to Docker-based PHP.
...
Additionally, there are a handful of related minor changes in this commit:
- `.travis.yml` has been tidied up a little.
- [45745] was incorrectly marking Travis jobs as passed when some PHPUnit runs failed.
- Add the `LOCAL_PHP_MEMCACHED` environment variable, for enabling Memcached.
- Add the `env:pull` NPM script, for refreshing Docker images.
See #47767 .
Built from https://develop.svn.wordpress.org/trunk@45762
git-svn-id: http://core.svn.wordpress.org/trunk@45573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 11:55:57 +00:00
de099aec14
Twenty Nineteen: Revise Latest Posts block styles to support post content options.
...
Props kjellr, ianbelanger.
Fixes #47340 .
Built from https://develop.svn.wordpress.org/trunk@45761
git-svn-id: http://core.svn.wordpress.org/trunk@45572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 11:48:57 +00:00
72b11e3322
Twenty Nineteen: Remove duplicate `height` and `width` attributes from SVG icons.
...
The attributes are added via `TwentyNineteen_SVG_Icons::get_svg()`, there's no need to have them separately in SVG sources.
Props mukesh27, albertomake.
Fixes #47128 .
Built from https://develop.svn.wordpress.org/trunk@45760
git-svn-id: http://core.svn.wordpress.org/trunk@45571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 11:41:54 +00:00
32afb6f7c7
Coding Standards: Use strict comparison in `wp-admin/edit.php`.
...
Props davidbaumwald.
Fixes #47201 .
Built from https://develop.svn.wordpress.org/trunk@45759
git-svn-id: http://core.svn.wordpress.org/trunk@45570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 11:40:55 +00:00
52c53ae6f8
Remove trailing white space in upgrade.php after [45757].
...
See #46349 .
Built from https://develop.svn.wordpress.org/trunk@45758
git-svn-id: http://core.svn.wordpress.org/trunk@45569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 01:01:57 +00:00
fff56d219f
Add admin email verification screen. Shown every six months after an admin has logged in.
...
Also includes WPCS fixes for wp-login.php.
Props andraganescu, boemedia, lessbloat, azaozz.
See #46349 .
Built from https://develop.svn.wordpress.org/trunk@45757
git-svn-id: http://core.svn.wordpress.org/trunk@45568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 00:04:56 +00:00
e081194455
Administration: Correct "Quick Edit" link height in list tables for consistency with other action links.
...
Props jobthomas, burhandodhy.
Fixes #47815 .
Built from https://develop.svn.wordpress.org/trunk@45756
git-svn-id: http://core.svn.wordpress.org/trunk@45567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 22:20:58 +00:00
e4f1204e04
Coding Standards: Fix WPCS violation in [45754].
...
See #46570 .
Built from https://develop.svn.wordpress.org/trunk@45755
git-svn-id: http://core.svn.wordpress.org/trunk@45566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 18:10:59 +00:00
282dfee8e0
General: Correctly detect large floats in `is_serialized()`.
...
Props killerbishop, donmhico, hoythan.
Fixes #46570 .
Built from https://develop.svn.wordpress.org/trunk@45754
git-svn-id: http://core.svn.wordpress.org/trunk@45565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 13:55:57 +00:00
d5fc1647c0
Feeds: Escape `&` characters in `atom_site_icon()` for XML, for consistency with `rss2_site_icon()`.
...
Props abhijitrakas, shawfactor.
Fixes #47482 .
Built from https://develop.svn.wordpress.org/trunk@45753
git-svn-id: http://core.svn.wordpress.org/trunk@45564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 13:15:56 +00:00
2ac34c799b
Coding Standards: Use strict comparison in `wp-admin/options-reading.php`.
...
Props subrataemfluence.
Fixes #46834 .
Built from https://develop.svn.wordpress.org/trunk@45752
git-svn-id: http://core.svn.wordpress.org/trunk@45563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 12:52:56 +00:00
ad9d8c7d58
Plugins: Use `include_once` for `wp-admin/includes/plugin-install.php` in `WP_Plugin_Install_List_Table::prepare_items()`.
...
This brings consistency with the other instances where the file is included, and allows for reusing its functions in custom code.
Props engelen, desrosj.
Fixes #38874 .
Built from https://develop.svn.wordpress.org/trunk@45751
git-svn-id: http://core.svn.wordpress.org/trunk@45562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 11:07:55 +00:00
c1a252da8e
Site Health: Use correct variable when checking PHP requirements for a plugin update in `WP_Plugins_List_Table::single_row()`.
...
Props diddledan, sharaz, vaishalipanchal.
Fixes #47835 .
Built from https://develop.svn.wordpress.org/trunk@45750
git-svn-id: http://core.svn.wordpress.org/trunk@45561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 10:58:56 +00:00
bec2aa0ef7
Docs: Correct `@type` annotation for `WP_Http_Curl` properties.
...
Props diddledan.
Fixes #46860 .
Built from https://develop.svn.wordpress.org/trunk@45749
git-svn-id: http://core.svn.wordpress.org/trunk@45560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 08:12:56 +00:00
bbf84bccf7
Docs: Correct `@type` annotation for `WP_HTTP_Cookie::$expires`.
...
Props diddledan.
Fixes #46859 .
Built from https://develop.svn.wordpress.org/trunk@45748
git-svn-id: http://core.svn.wordpress.org/trunk@45559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 07:56:56 +00:00
f7b8423b12
Upgrade/Install: Make sure `translate_level_to_role()` always returns a value.
...
Props diddledan.
Fixes #46848 .
Built from https://develop.svn.wordpress.org/trunk@45747
git-svn-id: http://core.svn.wordpress.org/trunk@45558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 07:48:58 +00:00
69bbdc4022
Posts, Post Types: Update, not delete the `page_for_posts` option in `_reset_front_page_settings_for_post()` when a linked page is deleted or trashed.
...
Props diddledan.
Fixes #46850 .
Built from https://develop.svn.wordpress.org/trunk@45746
git-svn-id: http://core.svn.wordpress.org/trunk@45557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 07:44:55 +00:00
41dc3e8d39
Build Tools: Add a WordPress Development Environment.
...
This commit adds the first iteration of a Docker-based config for setting up a local WordPress development environment.
Props pento, noisysocks, mcsf, pbearne, isabel_brison.
See #47767 .
Built from https://develop.svn.wordpress.org/trunk@45745
git-svn-id: http://core.svn.wordpress.org/trunk@45556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 07:10:56 +00:00
545157d30d
Posts, Post Types: Revert unintended change from [45742].
...
See #46503 .
Built from https://develop.svn.wordpress.org/trunk@45744
git-svn-id: http://core.svn.wordpress.org/trunk@45555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 14:44:55 +00:00
e8cd892ba4
Administration: Display a warning at the top of "All Settings" screen.
...
Props zodiac1978, donmhico, pixolin.
Fixes #47718 .
Built from https://develop.svn.wordpress.org/trunk@45743
git-svn-id: http://core.svn.wordpress.org/trunk@45554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 13:03:55 +00:00
9967a3e030
Docs: Add missing description for `$post` global.
...
Props immeet94.
Fixes #46503 . See #47110 .
Built from https://develop.svn.wordpress.org/trunk@45742
git-svn-id: http://core.svn.wordpress.org/trunk@45553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 12:28:56 +00:00
0cf1235477
Docs: Remove incorrect `@return` tags in `comment_reply_link()` and `post_reply_link()` DocBlocks.
...
Props atachibana.
Fixes #47826 .
Built from https://develop.svn.wordpress.org/trunk@45741
git-svn-id: http://core.svn.wordpress.org/trunk@45552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 02:20:55 +00:00
6da93732e7
Docs: Add missing description for `$current_screen` global.
...
Props mukesh27.
Fixes #45604 . See #47110 .
Built from https://develop.svn.wordpress.org/trunk@45740
git-svn-id: http://core.svn.wordpress.org/trunk@45551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 02:03:55 +00:00
7f7480cb2a
Docs: Add missing description for `$wp_query` and `$wp_the_query` globals.
...
Props mukesh27.
See #45604 , #47110 .
Built from https://develop.svn.wordpress.org/trunk@45739
git-svn-id: http://core.svn.wordpress.org/trunk@45550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 01:59:56 +00:00
77a31e6875
Docs: Add missing description for `$wp_locale_switcher` global.
...
See #45604 , #47110 .
Built from https://develop.svn.wordpress.org/trunk@45738
git-svn-id: http://core.svn.wordpress.org/trunk@45549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 01:47:55 +00:00
e0311b76c7
Docs: Add missing description for `$wp_locale` global.
...
Props mukesh27.
See #45604 , #47110 .
Built from https://develop.svn.wordpress.org/trunk@45737
git-svn-id: http://core.svn.wordpress.org/trunk@45548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 01:46:55 +00:00
ea606165a5
Docs: Add missing description for `$wp` global.
...
See #45604 , #47110 .
Built from https://develop.svn.wordpress.org/trunk@45736
git-svn-id: http://core.svn.wordpress.org/trunk@45547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 01:28:55 +00:00
b1e34ccc1f
Docs: Add missing description for `$wp_rewrite` global.
...
See #45604 , #47110 .
Built from https://develop.svn.wordpress.org/trunk@45735
git-svn-id: http://core.svn.wordpress.org/trunk@45546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 01:19:56 +00:00
29b072e706
Docs: Add missing description for `$wpdb`, `$wp_db_version`, and `$wp_current_db_version` globals.
...
Props mukesh27, utsav72640, immeet94, SergeyBiryukov.
See #45604 .
Built from https://develop.svn.wordpress.org/trunk@45734
git-svn-id: http://core.svn.wordpress.org/trunk@45545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 01:12:56 +00:00
702ee129ad
Docs: Fix typo in a comment in `WP_Site_Health::get_test_theme_version()`.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@45733
git-svn-id: http://core.svn.wordpress.org/trunk@45544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 00:48:56 +00:00
fd83290995
Site Health: If `WP_DEFAULT_THEME` doesn't exist, use `WP_Theme::get_core_default_theme()` as a fallback.
...
Props ajayghaghretiya1, juliobox, SergeyBiryukov.
Fixes #47299 .
Built from https://develop.svn.wordpress.org/trunk@45732
git-svn-id: http://core.svn.wordpress.org/trunk@45543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 00:02:55 +00:00
7dbc4d28e5
Script Loader: Send a 400 Bad Request status code in `load-scripts.php` and `load-styles.php` if the required `load[]` parameter is not set.
...
Props compilenix.
Fixes #44108 .
Built from https://develop.svn.wordpress.org/trunk@45731
git-svn-id: http://core.svn.wordpress.org/trunk@45542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-03 22:17:57 +00:00
c377191858
PHP 7.4 compatibility fix / accessing arrays/string using curly brace syntax
...
PHP used to allow both square brackets and curly braces to be used interchangeably for accessing array elements and string offsets. The curly bracket syntax is only allowed in a limited set of cases and can be confusing for people not used to it.
PHP 7.4 will deprecate the curly brace syntax for accessing array elements and string offsets and it is expected that support will be completely removed in PHP 8.0.
Ref: https://wiki.php.net/rfc/deprecate_curly_braces_array_access
See #47751 .
Props jrf.
Built from https://develop.svn.wordpress.org/trunk@45730
git-svn-id: http://core.svn.wordpress.org/trunk@45541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-03 20:21:55 +00:00
b853e21bf9
Accessibility: Improve the differences between revisions.
...
Color alone is not sufficient to visually communicate differences.
- adds `plus` and `minus` icons to the changed lines
- adds visually hidden text: `Added`, `Deleted`, and `Unchanged` to clarify the differences to assistive technologies users
Props birgire, audrasjb, kjellr, adamsilverstein.
Fixes #43532 .
Built from https://develop.svn.wordpress.org/trunk@45729
git-svn-id: http://core.svn.wordpress.org/trunk@45540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-03 15:46:54 +00:00
cbd6b7b5bc
Accessibility: Remove title attributes from the Meta widget.
...
- removes the `Powered by WordPress, state-of-the-art semantic personal publishing platform.` title attribute
- removes the title attribute from the abbreviations: contrary to a common belief, title attributes on abbreviations are only available to a minority of users, see https://developer.paciellogroup.com/blog/2019/03/short-note-the-abbreviation-appreciation-society/
- changes the term `RSS` to `feed`, as `RSS` is a technical term not all users are supposed to be familiar with
- improves the `widget_meta_poweredby` filter documentation
Props nishitlangaliya, chetan200891, audrasjb.
See #46980 , #24766 .
Fixes #46978 .
Built from https://develop.svn.wordpress.org/trunk@45728
git-svn-id: http://core.svn.wordpress.org/trunk@45539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-03 13:28:57 +00:00
7b45746001
Menus: Fix the Custom Links text fallback.
...
When adding a Custom Link and leaving the "Link Text" field empty, WordPress used to set a default fallback text: "Menu Item".
The changes in [36379] broke this behavior making the fallback text: ` (Pending)`, with a leading space.
Pending major refactoring of the Menus page (which is going to use a block-based user interface) this change just restores the original behavior by adding the fallback text to the related AJAX response.
Props christophherr, Fencer04, thakkarhardik, backermann1978, audrasjb.
Fixes #38415 .
Built from https://develop.svn.wordpress.org/trunk@45727
git-svn-id: http://core.svn.wordpress.org/trunk@45538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-03 12:19:56 +00:00
2d60076e77
Accessibility: Improve the way emojis are announced by screen readers.
...
Adds an ARIA `role="img"` to the emojis markup in the front end. While the ARIA role is technically redundant, it helps Safari and VoiceOver to properly announce the emojis as "image". Without the role, they announce a generic "group" role.
Tested with Safari 12.1.1 / VoiceOver 9.
Props pento.
See #37486 .
Built from https://develop.svn.wordpress.org/trunk@45726
git-svn-id: http://core.svn.wordpress.org/trunk@45537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-03 11:53:56 +00:00
9228eeb47b
Accessibility: Fix the `alt` attribute of the Gallery images within the Classic Editor.
...
Passes the images `alt` attribute value to the Gallery template used within the Classic Editor.
Props yarnboy, wpboss.
Fixes #47687 .
Built from https://develop.svn.wordpress.org/trunk@45725
git-svn-id: http://core.svn.wordpress.org/trunk@45536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-03 11:36:53 +00:00
76f482de43
Posts, Post Types: Check the result of `wp_update_post()` in `wp_trash_post()` and `wp_untrash_post()`.
...
Props abhijitrakas, manzoorwani.jk, siliconforks.
Fixes #47773 .
Built from https://develop.svn.wordpress.org/trunk@45724
git-svn-id: http://core.svn.wordpress.org/trunk@45535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-03 03:47:54 +00:00
c26f1c5d90
Taxonomy: Fix deprecated calls to `get_terms()`.
...
The taxonomy should be passed as part of `$args`, rather than as its own argument.
Props sgastard, mukesh27, SergeyBiryukov.
Fixes #47819 .
Built from https://develop.svn.wordpress.org/trunk@45723
git-svn-id: http://core.svn.wordpress.org/trunk@45534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-03 03:35:56 +00:00
60431f3c53
Customize: Make the color picker close when clicking on the empty area on the right.
...
Props monikarao.
Fixes #47693 .
Built from https://develop.svn.wordpress.org/trunk@45722
git-svn-id: http://core.svn.wordpress.org/trunk@45533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-02 17:09:57 +00:00
ad46ef7c06
Twenty Thirteen: Make `twentythirteen_author_bio_template()` use author templates if exist, fall back to regular template hierarchy otherwise.
...
See #32096 .
Built from https://develop.svn.wordpress.org/trunk@45721
git-svn-id: http://core.svn.wordpress.org/trunk@45532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-02 03:09:55 +00:00
b900e22629
Twenty Fifteen: Make `twentyfifteen_author_bio_template()` use author templates if exist, fall back to regular template hierarchy otherwise.
...
See #32096 .
Built from https://develop.svn.wordpress.org/trunk@45720
git-svn-id: http://core.svn.wordpress.org/trunk@45531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-02 03:08:55 +00:00
e2ea3f7f30
Twenty Thirteen: Prevent `author-bio.php` partial template from interfering with rendering an author archive of a user with the `bio` username.
...
Props rclations, ianbelanger, lordlod, SergeyBiryukov.
Fixes #32096 .
Built from https://develop.svn.wordpress.org/trunk@45719
git-svn-id: http://core.svn.wordpress.org/trunk@45530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-02 02:34:52 +00:00
97f28973da
Twenty Fifteen: Prevent `author-bio.php` partial template from interfering with rendering an author archive of a user with the `bio` username.
...
Props rclations, ianbelanger, lordlod, SergeyBiryukov.
See #32096 .
Built from https://develop.svn.wordpress.org/trunk@45718
git-svn-id: http://core.svn.wordpress.org/trunk@45529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-02 02:33:57 +00:00
f6770efd94
Users: Clean user cache in `check_password_reset_key()` tests.
...
Props davidbaumwald, spacedmonkey.
See #45845 .
Built from https://develop.svn.wordpress.org/trunk@45717
git-svn-id: http://core.svn.wordpress.org/trunk@45528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 19:54:55 +00:00
65420d3c7a
Users: Replace raw SQL query in `check_password_reset_key()` with `get_user_by()`.
...
Props davidbaumwald, iworks, spacedmonkey.
Fixes #45845 .
Built from https://develop.svn.wordpress.org/trunk@45716
git-svn-id: http://core.svn.wordpress.org/trunk@45527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 19:19:55 +00:00
ee5e044a2a
Users: Use `clean_user_cache()` in `wp_insert_user()`, `wp_update_user()`, `wp_set_password()`, `add_user_to_blog()`.
...
Props spacedmonkey.
Fixes #47021 .
Built from https://develop.svn.wordpress.org/trunk@45715
git-svn-id: http://core.svn.wordpress.org/trunk@45526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 17:49:57 +00:00
75857aa857
Users: Use `wp_update_user()` in `get_password_reset_key()`.
...
Props jayswadas, spacedmonkey, donmhico, SergeyBiryukov.
Fixes #45746 .
Built from https://develop.svn.wordpress.org/trunk@45714
git-svn-id: http://core.svn.wordpress.org/trunk@45525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 17:25:55 +00:00
f6189321e1
Users: Reorganize `user_nicename`, `user_url`, `user_registered` setting in `wp_insert_user()` for consistency with the order or fields in the database.
...
See #45746 .
Built from https://develop.svn.wordpress.org/trunk@45713
git-svn-id: http://core.svn.wordpress.org/trunk@45524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 17:13:57 +00:00
4a6461dcc2
Users: Use `get_password_reset_key()` in `wp_new_user_notification()`.
...
Props mrasharirfan, spacedmonkey.
Fixes #45745 .
Built from https://develop.svn.wordpress.org/trunk@45712
git-svn-id: http://core.svn.wordpress.org/trunk@45523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 15:30:58 +00:00
6623a824d0
Taxonomy: Correct some strict comparisons after [45710].
...
See #47573 .
Built from https://develop.svn.wordpress.org/trunk@45711
git-svn-id: http://core.svn.wordpress.org/trunk@45522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 15:04:56 +00:00
3e1126d940
Coding Standards: Use strict comparison in `wp-includes/taxonomy.php`.
...
Props andizer, SergeyBiryukov.
Fixes #47573 .
Built from https://develop.svn.wordpress.org/trunk@45710
git-svn-id: http://core.svn.wordpress.org/trunk@45521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 13:45:56 +00:00
fd03949143
Coding Standards: Fix WPCS violations after [45708].
...
See #45747 .
Built from https://develop.svn.wordpress.org/trunk@45709
git-svn-id: http://core.svn.wordpress.org/trunk@45520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 12:03:56 +00:00
b32cff72c2
Users: Deprecate `update_user_status()` in favor of `wp_update_user()`.
...
Props spacedmonkey, SergeyBiryukov.
Fixes #45747 .
Built from https://develop.svn.wordpress.org/trunk@45708
git-svn-id: http://core.svn.wordpress.org/trunk@45519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 11:28:54 +00:00
2d574d673f
Database: Use a strict comparison for `has_filter()` check in `wpdb::placeholder_escape()`.
...
The filter is added with a priority of `0`, so a loose comparison had an unintended effect of adding the filter on every call.
Props withinboredom.
Fixes #47430 .
Built from https://develop.svn.wordpress.org/trunk@45707
git-svn-id: http://core.svn.wordpress.org/trunk@45518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 02:25:56 +00:00
5f9ba92af4
REST API: Skip processing fields which are not present in the selected context.
...
In `WP_REST_Controller::get_fields_for_response()`, exclude fields which are not registered to appear in the request's context.
In conjunction with r45705 this prevents the unnecessary computation of the sample permalink when making a request that is not context=edit.
Props dlh.
Fixes #45605 .
Built from https://develop.svn.wordpress.org/trunk@45706
git-svn-id: http://core.svn.wordpress.org/trunk@45517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-31 20:21:56 +00:00
d296736b75
REST API: Generate sample permalink only when a dependent field is requested.
...
The sample permalink will now only be generated if the derivative `permalink_template` or `generated_slug` fields are to be included in the response, preventing an unnecessary database request for each post (via `wp_unique_post_slug()`) when those fields are not requested.
Props dlh.
See #45605 .
Built from https://develop.svn.wordpress.org/trunk@45705
git-svn-id: http://core.svn.wordpress.org/trunk@45516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-31 20:00:57 +00:00
ee23869c68
Docs: Correct parameter documentation for `bulk_edit_custom_box` and `quick_edit_custom_box` actions.
...
Props abrain.
Fixes #47810 .
Built from https://develop.svn.wordpress.org/trunk@45704
git-svn-id: http://core.svn.wordpress.org/trunk@45515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-31 15:10:58 +00:00
fec01b0685
Docs: Correct parameter type and description for `is_email` filter.
...
Props jenkoian.
Fixes #47793 .
Built from https://develop.svn.wordpress.org/trunk@45703
git-svn-id: http://core.svn.wordpress.org/trunk@45514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-31 01:26:54 +00:00
383c1df66b
Docs: Correct `@return` value description for `get_term_link()`.
...
Props garrett-eclipse.
Fixes #47806 .
Built from https://develop.svn.wordpress.org/trunk@45702
git-svn-id: http://core.svn.wordpress.org/trunk@45513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-31 01:19:56 +00:00
d5c7657189
Media: Reduces the bulk media options to have one primary button
...
This fixes where 2 primary buttons were showing for bulk actions within media trash.
Props garrett-eclipse, afercia, ianbelanger, SergeyBiryukov
Fixes #46757 , #46758
Built from https://develop.svn.wordpress.org/trunk@45701
git-svn-id: http://core.svn.wordpress.org/trunk@45512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-30 23:20:57 +00:00
fa9980049e
Admin: Improve Dashboard icon contrast.
...
The icons used across the dashboard had too low contrast to pass AA WCAG guidelines. They’re now slightly darker for better contrast.
Props @melchoyce, @SergeyBiryukov, @chetan200891 , @kjellr
Fixes #46935
Built from https://develop.svn.wordpress.org/trunk@45700
git-svn-id: http://core.svn.wordpress.org/trunk@45511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-30 22:54:57 +00:00
c7493264a4
Rewrite Rules: Check if `$wp_rewrite->flush_rules()` is callable before calling it in `flush_rewrite_rules()`.
...
Props bsetiawan88, markjaquith.
Fixes #47087 .
Built from https://develop.svn.wordpress.org/trunk@45699
git-svn-id: http://core.svn.wordpress.org/trunk@45510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 17:52:56 +00:00
98642b4821
Users: Use case-insensitive email address comparison when checking whether "Grant this user super admin privileges" checkbox should be displayed on Edit User screen.
...
Props trepmal.
Fixes #47119 .
Built from https://develop.svn.wordpress.org/trunk@45698
git-svn-id: http://core.svn.wordpress.org/trunk@45509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 17:42:55 +00:00
ec8940edeb
Coding Standards: Fix WPCS violations in `wp-admin/includes/class-walker-nav-menu-edit.php`.
...
Props sudhiryadav, audrasjb.
Fixes #46902 .
Built from https://develop.svn.wordpress.org/trunk@45697
git-svn-id: http://core.svn.wordpress.org/trunk@45508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:53:52 +00:00
c9942bb3d8
Coding Standards: Fix WPCS violations in [45694].
...
See #47466 .
Built from https://develop.svn.wordpress.org/trunk@45696
git-svn-id: http://core.svn.wordpress.org/trunk@45507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:52:56 +00:00
e7abdc7040
Docs: Improve the DocBlocks for `got_mod_rewrite()`, `extract_from_markers()`, `insert_with_markers()`.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@45695
git-svn-id: http://core.svn.wordpress.org/trunk@45506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:35:56 +00:00
67e5038470
Rewrite Rules: Add a comment to `# BEGIN/END` `.htaccess` markers to clarify that the directives are dynamically generated, and should only be modified via WordPress filters.
...
Introduce `insert_with_markers_inline_instructions` filter to modify the default instructions text.
Props bradleyt, SergeyBiryukov.
Fixes #47466 .
Built from https://develop.svn.wordpress.org/trunk@45694
git-svn-id: http://core.svn.wordpress.org/trunk@45505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:31:57 +00:00
7a4d1b5dbd
Permalinks: Improve appearance of URL examples on Permalink Settings screen.
...
Props luan-ramos, sarath.ar.
Fixes #41559 .
Built from https://develop.svn.wordpress.org/trunk@45693
git-svn-id: http://core.svn.wordpress.org/trunk@45504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:11:56 +00:00
b95b055225
Administration: Allow breaking long strings in `<code>` tags at any point, to avoid overflowing on mobile.
...
Props david.binda, mukesh27.
Fixes #47329 .
Built from https://develop.svn.wordpress.org/trunk@45692
git-svn-id: http://core.svn.wordpress.org/trunk@45503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:09:55 +00:00
a59301c2ba
Site Health: Consistently use `wpdb::db_version()` for checking the database server version, instead of partically replicating its functionality.
...
Props Clorith, wpfed.
Fixes #47738 .
Built from https://develop.svn.wordpress.org/trunk@45691
git-svn-id: http://core.svn.wordpress.org/trunk@45502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 14:55:57 +00:00
182f813e24
I18N: Display the logged out message in the user's locale
...
Built from https://develop.svn.wordpress.org/trunk@45690
git-svn-id: http://core.svn.wordpress.org/trunk@45501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-27 14:31:55 +00:00
391d6a3f2b
I18N: Following [45688], remove test for removed method.
...
See #44865 .
Built from https://develop.svn.wordpress.org/trunk@45689
git-svn-id: http://core.svn.wordpress.org/trunk@45500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-27 14:30:57 +00:00
892a80d974
I18N: Use RTL stylesheets when running from /src.
...
To run WordPress from /src you have to use the `--dev` flag which also builds the RTL stylesheets thus the admin notice and force to LTR is no longer required.
See #44492 .
Fixes #44865 .
Built from https://develop.svn.wordpress.org/trunk@45688
git-svn-id: http://core.svn.wordpress.org/trunk@45499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-27 14:17:57 +00:00
4d3ca52c45
REST API: Pass current request object to `rest_authentication_errors` filter in `WP_REST_Server::check_authentication()`.
...
Fixes #46907 .
Built from https://develop.svn.wordpress.org/trunk@45687
git-svn-id: http://core.svn.wordpress.org/trunk@45498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-27 13:44:57 +00:00
81bfb111d1
Tools: Remove internationalization tools (also known as `makepot.php`).
...
It has been a great pleasure to work with `makepot.php` over the past [https://i18n.trac.wordpress.org/changeset/4169/ 11 years] but now it's time to say goodbye.
The tools have been integrated into WP-CLI as [https://developer.wordpress.org/cli/commands/i18n/make-pot/ wp i18n make-pot] and [https://developer.wordpress.org/cli/commands/i18n/make-json/ wp i18n make-json]. The new commands were optimized to support current PHP versions and are more flexible and reliable when extracting strings for PHP, and JavaScript.
Access to the old tools continue to exist in previous branches or at https://i18n.svn.wordpress.org/tools/ .
Fixes #45287 .
Built from https://develop.svn.wordpress.org/trunk@45686
git-svn-id: http://core.svn.wordpress.org/trunk@45497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-27 13:10:56 +00:00
8059b362e8
I18N: Add support for custom `WP_PLUGIN_URL` in `load_script_textdomain()`.
...
Plugins may not be on the same host/path as the rest of the content. To support loading translations for this setup check if the script source matches `plugins_url()`.
Also fixes an undefined index notice when a custom content URL has no path.
Props odminstudios, ocean90.
Fixes #46336 , #46387 .
Built from https://develop.svn.wordpress.org/trunk@45685
git-svn-id: http://core.svn.wordpress.org/trunk@45496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-27 12:44:56 +00:00
0af752e360
Accessibility: Toolbar: Make the `min-width` value for `#wpadminbar` at `782px` breakpoint consistent with that of `<body>`.
...
This ensures that the "My Account" toolbar item stays visible at high zoom levels.
Props isabel_brison, chetan200891.
Fixes #47603 .
Built from https://develop.svn.wordpress.org/trunk@45684
git-svn-id: http://core.svn.wordpress.org/trunk@45495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-26 22:04:55 +00:00
f933abef11
Accessibility: Taxonomy: When a new category or tag is being added, show a spinner and noop the button to avoid multiple requests.
...
Props andg, afercia, guddu1315, SergeyBiryukov.
Fixes #47607 .
Built from https://develop.svn.wordpress.org/trunk@45683
git-svn-id: http://core.svn.wordpress.org/trunk@45494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-26 17:46:56 +00:00
5cdbe22b16
Administration: Merge CSS rules for `#adminmenu .wp-submenu a` in one place.
...
Props ozmatflc, AkSDvP.
Fixes #47780 .
Built from https://develop.svn.wordpress.org/trunk@45682
git-svn-id: http://core.svn.wordpress.org/trunk@45493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-26 13:49:57 +00:00
33b2fbc7e7
REST API: Make "Could not update meta value in database" error messages more helpful.
...
Props apermo, AkSDvP.
Fixes #46252 .
Built from https://develop.svn.wordpress.org/trunk@45681
git-svn-id: http://core.svn.wordpress.org/trunk@45492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-26 13:20:56 +00:00
e925997562
Site Health: Show parent theme in its own accordion on Site Health Info screen; rename "Other Themes" to "Inactive Themes".
...
Props garrett-eclipse, mukesh27, Clorith, xkon, msaggiorato.
Fixes #46925 .
Built from https://develop.svn.wordpress.org/trunk@45680
git-svn-id: http://core.svn.wordpress.org/trunk@45491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-26 03:49:55 +00:00
dae07c8216
Coding Standards: Fix newlines in `wp-includes/date.php`.
...
See #47775 .
Built from https://develop.svn.wordpress.org/trunk@45679
git-svn-id: http://core.svn.wordpress.org/trunk@45490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-26 00:12:55 +00:00
cff445d55f
Coding Standards: Move `wp-includes/date.php` to `wp-includes/class-wp-date-query.php`.
...
This renames the file containing the `WP_Date_Query` class to conform to the coding standards.
This commit also includes:
- A new `date.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.
Fixes #47775 . See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45678
git-svn-id: http://core.svn.wordpress.org/trunk@45489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 23:31:56 +00:00
ace077085d
I18N: Update translator comment missed in [45676].
...
See #47771 .
Built from https://develop.svn.wordpress.org/trunk@45677
git-svn-id: http://core.svn.wordpress.org/trunk@45488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 22:56:55 +00:00
a186dbcb65
I18N: Update translator comments after [45674].
...
See #47771 .
Built from https://develop.svn.wordpress.org/trunk@45676
git-svn-id: http://core.svn.wordpress.org/trunk@45487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 22:52:56 +00:00
ac10f9b9e4
Bundled Themes: Replace Codex URLs with a corresponding HelpHub or DevHub article.
...
Props ianbelanger, tobifjellner, SergeyBiryukov.
See #47771 .
Built from https://develop.svn.wordpress.org/trunk@45675
git-svn-id: http://core.svn.wordpress.org/trunk@45486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 22:46:55 +00:00
8e85299a00
General: First pass at replacing Codex URLs with a corresponding HelpHub or DevHub article.
...
Props ianbelanger, tobifjellner, SergeyBiryukov.
See #47771 .
Built from https://develop.svn.wordpress.org/trunk@45674
git-svn-id: http://core.svn.wordpress.org/trunk@45485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 22:45:57 +00:00
ccba6c4aec
Upgrade/Install: Bring some consistency to installation screen styles.
...
* Include `forms.css` and `l10n.css`, for consistency with login screen and other admin screens.
* Remove redundant `@import` directives from `login.css` for files already declared as dependencies.
* Adjust margin on password strength meter for consistency with other fields.
* Increase font size for "You will need this password to log in" notice.
* Fix misaligned icon on "Hide" button for the password.
Props iseulde, dan@micamedia.com , bassgang, cdog, johnbillion, nmenescardi, mukesh27, SergeyBiryukov.
Fixes #35776 , #47757 , #47758 .
Built from https://develop.svn.wordpress.org/trunk@45673
git-svn-id: http://core.svn.wordpress.org/trunk@45484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 19:11:55 +00:00
1d283ef54f
Docs: Clarify that `is_network_admin()` does not check if the site is a Multisite network; `is_multisite()` should be used for that.
...
Props svovaf, dilipbheda, tazotodua.
Fixes #47415 .
Built from https://develop.svn.wordpress.org/trunk@45672
git-svn-id: http://core.svn.wordpress.org/trunk@45483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 15:19:58 +00:00
8ab7bbe385
Posts, Post Types: Introduce `is_sticky` filter in `is_sticky()` to provide more flexibility for custom sticky post implementations.
...
Props dehisok, greenshady.
Fixes #37629 .
Built from https://develop.svn.wordpress.org/trunk@45671
git-svn-id: http://core.svn.wordpress.org/trunk@45482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 01:36:54 +00:00
316fa4aecb
Code Editor: Check for correct `mode` value in `wp.codeEditor.initialize` to enable autocomplete support for PHP.
...
Props ediamin.
Fixes #47769 .
Built from https://develop.svn.wordpress.org/trunk@45670
git-svn-id: http://core.svn.wordpress.org/trunk@45481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 01:27:57 +00:00
aee690fd84
Permalinks: Update URLs for "Changing File Permissions" documentation article.
...
Props patilswapnilv, ianbelanger, SergeyBiryukov.
Fixes #47768 .
Built from https://develop.svn.wordpress.org/trunk@45669
git-svn-id: http://core.svn.wordpress.org/trunk@45480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 01:18:55 +00:00
5522be31e7
Coding Standards: Use correct variable in `wp_dropdown_categories()` after [45667].
...
See #45059 .
Built from https://develop.svn.wordpress.org/trunk@45668
git-svn-id: http://core.svn.wordpress.org/trunk@45479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 01:07:54 +00:00
18bd01985b
Coding Standards: Rename `$r` variable used with `wp_parse_args()` to `$parsed_args` for clarity.
...
Props freewebmentor.
Fixes #45059 .
Built from https://develop.svn.wordpress.org/trunk@45667
git-svn-id: http://core.svn.wordpress.org/trunk@45478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 00:48:58 +00:00
7112ee7132
Coding Standards: Move the remaining PHPCS errors to report as warnings, and add Travis tests.
...
The remaining error-level coding standards issues (specifically, associated with the sniffs `WordPress.PHP.YodaConditions.NotYoda`, `WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase`, `WordPress.DB.PreparedSQL.InterpolatedNotPrepared`, `WordPress.DB.PreparedSQL.NotPrepared`, and `WordPress.Files.FileName.InvalidClassFileName`) are marked as warnings, until they're all addressed.
This change allows us to run linting on Travis across the entire codebase, ensuring no other error-level violations can be introduced.
Additionally, PHPCS will now cache results locally, drastically improving performance for subsequent checks: scanning the entire codebase takes 1-2 minutes the first time, and less than one second for subsequent checks.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45665
git-svn-id: http://core.svn.wordpress.org/trunk@45476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-19 07:48:56 +00:00
172117d35f
Coding Standards: Fix a filename replacement missed in [45663].
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45664
git-svn-id: http://core.svn.wordpress.org/trunk@45475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-19 04:42:57 +00:00
af0a914d14
Coding Standards: Move `wp-includes/class-oembed.php` to `wp-includes/class-wp-oembed.php`.
...
This renames the file containing the `WP_oEmbed` class to conform to the coding standards.
This commit also includes:
- A new `class-oembed.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45663
git-svn-id: http://core.svn.wordpress.org/trunk@45474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-19 04:32:57 +00:00
971814047f
Coding Standards: Move wp-admin/custom-background.php to wp-admin/includes/class-custom-background.php
...
This renames the file containing the Custom_Background class to conform to the coding standards.
This commit also includes:
- A new custom-background.php that includes the new file, for anyone that may've been including the file directly.
- Replaces a reference to the old filename with the new filename.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45662
git-svn-id: http://core.svn.wordpress.org/trunk@45473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-19 04:02:55 +00:00
744ffe8e00
Coding Standards: Exclude a handful of incorrectly named files that won't be renamed.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45661
git-svn-id: http://core.svn.wordpress.org/trunk@45472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-19 03:50:59 +00:00
1f5fcff132
Coding Standards: Improve spacing of `printf()` calls in the admin About pages.
...
Props garrett-eclipse.
Fixes #47734 .
Built from https://develop.svn.wordpress.org/trunk@45660
git-svn-id: http://core.svn.wordpress.org/trunk@45471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-19 00:09:58 +00:00
1c331e8931
I18N: Make URLs to ` https://wordpress.org/about/ ` and related pages translatable, as they can now be localized on Rosetta sites.
...
Props mukesh27.
Fixes #46386 .
Built from https://develop.svn.wordpress.org/trunk@45659
git-svn-id: http://core.svn.wordpress.org/trunk@45470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-18 12:41:57 +00:00
22412b1d97
Customizer: Show all widgets when the search field is cleared.
...
When clicking the clear button on the widget search field, the search results should refresh to show all widgets.
Props Mahesh901122.
Fixes #47534 .
Built from https://develop.svn.wordpress.org/trunk@45658
git-svn-id: http://core.svn.wordpress.org/trunk@45469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-18 05:55:59 +00:00
7149d65934
Editor: Replace external Classic Editor plugin URL with a link to Add Plugins screen with Classic Editor pre-selected.
...
This applies to messages displayed when JavaScript is disabled in Block Editor, or an incompatible meta box is used.
Props garrett-eclipse, derweili, afercia.
Fixes #47487 .
Built from https://develop.svn.wordpress.org/trunk@45657
git-svn-id: http://core.svn.wordpress.org/trunk@45468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-18 01:33:57 +00:00
4b460d0f80
Coding Standards: Fix WPCS issues in [45655].
...
See #47723 .
Built from https://develop.svn.wordpress.org/trunk@45656
git-svn-id: http://core.svn.wordpress.org/trunk@45467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-17 19:22:56 +00:00
f7c4398ea9
Menus: Trim whitespace from custom link URLs.
...
Props majemedia, SergeyBiryukov.
Fixes #47723 .
Built from https://develop.svn.wordpress.org/trunk@45655
git-svn-id: http://core.svn.wordpress.org/trunk@45466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-17 18:45:58 +00:00
24d08a9463
Coding Standards: Move `wp-admin/custom-header.php` to `wp-admin/includes/class-custom-image-header.php`
...
This renames the file containing the `Custom_Image_Header` class to conform to the coding standards.
This commit also includes:
- A new `custom-header.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45654
git-svn-id: http://core.svn.wordpress.org/trunk@45465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-17 06:17:56 +00:00
83427a87a9
Coding Standards: Exclude some class names from checks when they can't be renamed.
...
Renaming the classes would likely cause back compat issues, so the safest option is to allow this handful to continue unchanged.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45653
git-svn-id: http://core.svn.wordpress.org/trunk@45464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-17 04:34:55 +00:00
970fe7d85c
Coding Standards: Fix WPCS issues in [45651].
...
See #38195 .
Built from https://develop.svn.wordpress.org/trunk@45652
git-svn-id: http://core.svn.wordpress.org/trunk@45463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-17 01:50:58 +00:00
6cb424b978
Media: Add "Documents", "Spreadsheets", and "Archives" groups to file type filter in Media Library.
...
Props zodiac1978, swissspidy, karmatosed, SergeyBiryukov.
Fixes #38195 .
Built from https://develop.svn.wordpress.org/trunk@45651
git-svn-id: http://core.svn.wordpress.org/trunk@45462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-17 01:22:55 +00:00
1f256f3fdc
Administration: In `admin-ajax.php`, send `X-Robots-Tag` header earlier, so that it applies before `wp_die()` when no action parameter was provided.
...
Props robi-bobi, harryfear, garrett-eclipse.
Fixes #47711 .
Built from https://develop.svn.wordpress.org/trunk@45650
git-svn-id: http://core.svn.wordpress.org/trunk@45461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-17 01:11:56 +00:00
66afb60397
Site Health: Use consistent verbiage for "Learn more" links.
...
Props ronakganatra, garrett-eclipse.
Fixes #47302 .
Built from https://develop.svn.wordpress.org/trunk@45649
git-svn-id: http://core.svn.wordpress.org/trunk@45460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 22:28:57 +00:00
f600647e22
Site Health: Replace "harddrive" with "device" on Site Health Info screen.
...
Props chetan200891, timhavinga, Cybr, Clorith.
Fixes #46965 .
Built from https://develop.svn.wordpress.org/trunk@45648
git-svn-id: http://core.svn.wordpress.org/trunk@45459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 22:19:55 +00:00
e5ad773194
I18N: Merge duplicate "Your plugins/themes/translations are all up to date" strings.
...
Props ramiy.
Fixes #47252 .
Built from https://develop.svn.wordpress.org/trunk@45647
git-svn-id: http://core.svn.wordpress.org/trunk@45458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 22:13:58 +00:00
2ac05ca7d5
Media: Add a unit test for `wp_get_mime_types()`.
...
Props pbearne.
Fixes #47701 .
Built from https://develop.svn.wordpress.org/trunk@45646
git-svn-id: http://core.svn.wordpress.org/trunk@45457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 21:52:57 +00:00
5eba5381e6
Media: Sort the new sizes array by priority when creating image sub-sizes.
...
See #40439 .
Built from https://develop.svn.wordpress.org/trunk@45645
git-svn-id: http://core.svn.wordpress.org/trunk@45456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 21:48:56 +00:00
6f2fe4da8f
Customize: In `WP_Customize_Widgets::capture_filter_pre_update_option()`, return the filtered value instead of `null` when bailing early for ignored options.
...
Props dlh.
Fixes #47715 .
Built from https://develop.svn.wordpress.org/trunk@45644
git-svn-id: http://core.svn.wordpress.org/trunk@45455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 21:33:57 +00:00
62216de5d4
Docs: Move the `do_mu_upgrade` DocBlock out of the preceding `if` statement.
...
Props ChriCo, dkarfa.
Fixes #47710 .
Built from https://develop.svn.wordpress.org/trunk@45643
git-svn-id: http://core.svn.wordpress.org/trunk@45454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 13:15:58 +00:00
62dc808103
Docs: Correct `@since` tag for `do_mu_upgrade` hook, for consistency with `after_mu_upgrade` and `wpmu_upgrade_site`.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@45642
git-svn-id: http://core.svn.wordpress.org/trunk@45453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 12:42:59 +00:00
c0e53279b3
Comments: Fix typo in comment reply observer options.
...
Props maguiar.
Fixes #47706 . See #46260 .
Built from https://develop.svn.wordpress.org/trunk@45641
git-svn-id: http://core.svn.wordpress.org/trunk@45452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-15 16:46:55 +00:00
820ce9c438
Code Modernisation: Revert [45624].
...
Changing the method signatures on `Walker` causes back compat issues.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45640
git-svn-id: http://core.svn.wordpress.org/trunk@45451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-15 07:04:59 +00:00
a571a7d621
Code Modernisation: Fix known instances of array access on data types that can't be accessed as arrays.
...
PHP 7.4 addes a warning when trying access a null/bool/int/float/resource (everything but array, string and object) as if it were an array.
This change fixes all of these warnings visible in unit tests.
Props jrf.
See #47704 .
Built from https://develop.svn.wordpress.org/trunk@45639
git-svn-id: http://core.svn.wordpress.org/trunk@45450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-15 06:25:57 +00:00
bd45c7d3b9
Code Modernisation: Document when the Hash polyfills can be removed.
...
The Hash extension cannot be disabled as of PHP 7.4. So, while we can't remove these polyfills yet, we can document when we'll be able to.
Props jrf.
Fixes #47698 .
Built from https://develop.svn.wordpress.org/trunk@45638
git-svn-id: http://core.svn.wordpress.org/trunk@45449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-15 05:14:55 +00:00
21df1bda5b
Code Modernisation: Remove the SPL autoloader polyfill.
...
As of PHP 5.3, the SPL extension cannot be disabled, so we no longer need this polyfill.
The file is kept with a `_deprecated_file()` call, to alert any plugins or themes that may be loading it directly.
Props jrf, ayeshrajans.
See #47698 , #46630 .
Built from https://develop.svn.wordpress.org/trunk@45637
git-svn-id: http://core.svn.wordpress.org/trunk@45448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-15 05:11:56 +00:00
501b5f545b
Code Modernisation: Remove the `array_replace_recursive()` polyfill.
...
This function was added in PHP 5.3.0, so we no longer need the polyfill.
Props jrf.
See #47698 .
Built from https://develop.svn.wordpress.org/trunk@45636
git-svn-id: http://core.svn.wordpress.org/trunk@45447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-15 05:08:56 +00:00
fbdb267634
WPDB: Allow custom data to be added to logged queries.
...
This adds a new method, `wpdb::log_query()`, and a new filter, `log_query_custom_data`. The custom data is stored as a new element in each entry of the `wpdb::$queries` array.
Props CrazyJaco, johnbillion, pento.
Fixes 42151.
Built from https://develop.svn.wordpress.org/trunk@45635
git-svn-id: http://core.svn.wordpress.org/trunk@45446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-15 04:07:57 +00:00
83d175cdd0
I18N: Add context for theme filter strings in `WP_MS_Themes_List_Table::get_views()`.
...
Props audrasjb.
Fixes #47695 .
Built from https://develop.svn.wordpress.org/trunk@45634
git-svn-id: http://core.svn.wordpress.org/trunk@45445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-14 14:47:56 +00:00
436a9512e2
Upgrade/Install: Remove debugging artifacts from `wp-admin/upgrade.php` added in [1229].
...
Props rahulvaza.
Fixes #47074 .
Built from https://develop.svn.wordpress.org/trunk@45633
git-svn-id: http://core.svn.wordpress.org/trunk@45444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-14 14:39:57 +00:00
e85a5c64a3
REST API: Allow `rest_get_avatar_urls()` to accept full user, post, or comment objects, rather than just an email address, to provide better flexibility for alternative avatar data.
...
Since the function uses `get_avatar_url()` internally, which already supports it, this should not have any backward compatibility concerns.
Props donmhico, dshanske, pputzer, joehoyle, TimothyBlynJacobs.
Fixes #40030 .
Built from https://develop.svn.wordpress.org/trunk@45632
git-svn-id: http://core.svn.wordpress.org/trunk@45443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-14 14:35:56 +00:00
ee8813606d
TinyMCE: fix adding of too many undo levels for wpviews. The HTML changes several times when a wpview is added. We only want one undo level. Also fixes cases when the cursor is next to an embeddable URL in the Text tab and the user switches to the Visual tab.
...
See #45307 .
Built from https://develop.svn.wordpress.org/trunk@45631
git-svn-id: http://core.svn.wordpress.org/trunk@45442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 03:25:55 +00:00
4d3a84aa9f
Code Modernisation: Introduce the spread operator in `wpdb::prepare()`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45630
git-svn-id: http://core.svn.wordpress.org/trunk@45441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:17:57 +00:00
2fe355cdd0
Code Modernisation: Introduce the spread operator in `widgets.php`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45629
git-svn-id: http://core.svn.wordpress.org/trunk@45440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:14:58 +00:00
afdbf749d7
Code Modernisation: Introduce the spread operator in `theme.php`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf, pento.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45628
git-svn-id: http://core.svn.wordpress.org/trunk@45439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:10:56 +00:00
1af80c2106
Code Modernisation: Introduce the spread operator in `walk_page_dropdown_tree()`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45627
git-svn-id: http://core.svn.wordpress.org/trunk@45438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:06:55 +00:00
02c07f23d5
Customize: Fix text direction for color picker in RTL.
...
Props vjik for the report.
Fixes #47688 . See #23740 .
Built from https://develop.svn.wordpress.org/trunk@45626
git-svn-id: http://core.svn.wordpress.org/trunk@45437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:05:57 +00:00
5fb46ff14b
Code Modernisation: Introduce the spread operator in `add_post_type_support()`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf, pento.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45625
git-svn-id: http://core.svn.wordpress.org/trunk@45436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:02:56 +00:00
41ea1f106d
Code Modernisation: Introduce the spread operator in `Walker`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45624
git-svn-id: http://core.svn.wordpress.org/trunk@45435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 23:51:56 +00:00
4de2f2f49b
Code Modernisation: Introduce the spread operator in `WP_User`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45623
git-svn-id: http://core.svn.wordpress.org/trunk@45434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 23:48:56 +00:00
5d658427a8
Code Modernisation: Introduce the spread operator in `capabilities.php`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45622
git-svn-id: http://core.svn.wordpress.org/trunk@45433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 23:46:56 +00:00
ff723a2fba
Editor: Make registered editor stylesheets (editor-style.css) available to the front-end.
...
Props webmandesign, azaozz.
Fixes #34882 .
Built from https://develop.svn.wordpress.org/trunk@45621
git-svn-id: http://core.svn.wordpress.org/trunk@45432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 18:30:57 +00:00
969699260d
TinyMCE: fix flickering inline toolbar when showing a tooltip. Take two.
...
Fixes #44911 .
Built from https://develop.svn.wordpress.org/trunk@45620
git-svn-id: http://core.svn.wordpress.org/trunk@45431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 18:18:58 +00:00
bb8afb46b9
Block Editor: Avoid a PHP warning when a theme adds an editor style with an empty filename.
...
Fixes #45739 .
Built from https://develop.svn.wordpress.org/trunk@45619
git-svn-id: http://core.svn.wordpress.org/trunk@45430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 07:21:55 +00:00
4c3d541e23
Block Editor: Fix the link to the classic editor when incompatible meta boxen are detected.
...
Props tmatsuur, mukesh27.
Fixes #45935 .
Built from https://develop.svn.wordpress.org/trunk@45618
git-svn-id: http://core.svn.wordpress.org/trunk@45429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 06:01:58 +00:00
7369ff02f5
Coding Standards: Remove extra whitespace in list tables' `column_cb()` methods.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45617
git-svn-id: http://core.svn.wordpress.org/trunk@45428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 21:11:58 +00:00
9a5f538153
Coding Standards: Remove extra whitespace in `wp-admin/includes/image-edit.php`.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45616
git-svn-id: http://core.svn.wordpress.org/trunk@45427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 21:05:57 +00:00
6a696f6051
I18N: Move code out of translatable string in a `_deprecated_argument()` message in `wp_stream_image()`, `wp_save_image_file()`, and `image_edit_apply_changes()`.
...
Props ramiy.
Fixes #47406 .
Built from https://develop.svn.wordpress.org/trunk@45615
git-svn-id: http://core.svn.wordpress.org/trunk@45426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 20:57:56 +00:00
bb365054b8
Menus: Remove extra whitespace from URLs in `Walker_Nav_Menu_Edit::start_el()`.
...
Props alexeyskr, SergeyBiryukov.
Fixes #47666 .
Built from https://develop.svn.wordpress.org/trunk@45614
git-svn-id: http://core.svn.wordpress.org/trunk@45425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 20:45:56 +00:00
29e5155969
Filesystem API: Check correct variable in `WP_Filesystem_Direct::dirlist()` after [45611].
...
Props zinigor.
Fixes #47668 . See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45613
git-svn-id: http://core.svn.wordpress.org/trunk@45424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 15:58:57 +00:00
4be25f3d06
Coding Standards: Fix instances of `WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase`.
...
See #46732 .
Built from https://develop.svn.wordpress.org/trunk@45612
git-svn-id: http://core.svn.wordpress.org/trunk@45423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 06:29:57 +00:00
abcbee954f
Coding Standards: Fix instances of `WordPress.PHP.NoSilencedErrors.Discouraged`.
...
Noteable changes:
- The `magic_quotes_runtime` and `magic_quotes_sybase` settings were removed in PHP 5.4, so no longer need to be set.
- Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
- Quite a few functions would cause errors if `safe_mode` was set. This setting was removed in PHP 5.4.
- Only a handful of `header()` calls needed corresponding `headers_sent()` checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.
See #46732 .
Built from https://develop.svn.wordpress.org/trunk@45611
git-svn-id: http://core.svn.wordpress.org/trunk@45422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 05:45:58 +00:00
4a273484f3
TinyMCE: fix flickering inline toolbar when hovering over the buttons there and the vertical scrollbar is not shown (the page height is less than the window height). Improves/removes the previous fix for similar flickering but only in RTL, see #42018 .
...
Props joakimsilfverberg, mukesh27, kokers, Howdy_McGee, noisysocks, azaozz.
Fixes #44911 .
Built from https://develop.svn.wordpress.org/trunk@45610
git-svn-id: http://core.svn.wordpress.org/trunk@45421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 01:11:55 +00:00
c71bc1513e
Coding Standards: Add missing translator comments to the default themes.
...
All default themes now have translator comments for all strings with placeholders!
See #46732 .
Built from https://develop.svn.wordpress.org/trunk@45609
git-svn-id: http://core.svn.wordpress.org/trunk@45420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 01:10:00 +00:00
82935b0343
Theme Editor: Hide the recommendation to create a child theme when editing a child theme.
...
Props mukesh27, davidbaumwald.
Fixes #44889 .
Built from https://develop.svn.wordpress.org/trunk@45608
git-svn-id: http://core.svn.wordpress.org/trunk@45419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-08 03:15:56 +00:00
ec07a7e565
Coding Standards: Fix the remaining issues in `/tests`.
...
All PHP files in `/tests` now conform to the PHP coding standards, or have exceptions appropriately marked.
Travis now also runs `phpcs` on the `/tests` directory, any future changes to these files must conform entirely to the WordPress PHP coding standards. 🎉
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45607
git-svn-id: http://core.svn.wordpress.org/trunk@45418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-08 00:56:56 +00:00
83e19085a3
Twenty Thirteen: Add styles for the new Group block.
...
Add styles for the new Group block to the theme, to make sure nested blocks display correctly when using the wide and full alignments.
Props @kjellr.
Fixes #46778 .
Built from https://develop.svn.wordpress.org/trunk@45606
git-svn-id: http://core.svn.wordpress.org/trunk@45417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-07 20:49:55 +00:00
5b4b6d98ce
Twenty Nineteen: Add styles for the new Group block.
...
Add styles for the new Group block to the theme, to make sure nested blocks display correctly when using the wide and full alignments.
Props @kjellr, @dianeco.
Fixes #46750 .
Built from https://develop.svn.wordpress.org/trunk@45605
git-svn-id: http://core.svn.wordpress.org/trunk@45416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-07 20:11:57 +00:00
28a8f31ffa
Coding Standards: Add missing translator comments.
...
Twentys Eleven, Sixteen, and Seventeen now have translator comments for all their strings.
Also, WPCS now doesn't show missing translator comment warnings for test files.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45604
git-svn-id: http://core.svn.wordpress.org/trunk@45415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 08:04:57 +00:00
14c7533162
Coding Standards: Fix all `WordPress.DB.PreparedSQLPlaceholders` issues.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45603
git-svn-id: http://core.svn.wordpress.org/trunk@45414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 05:43:55 +00:00
87675d288b
Coding Standards: Fix all `WordPress.WhiteSpace.PrecisionAlignment` issues.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45602
git-svn-id: http://core.svn.wordpress.org/trunk@45413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 05:21:56 +00:00
f69c20859e
Coding Standards: Fix all `WordPress.CodeAnalysis.AssignmentInCondition` issues.
...
`WordPress.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition` can be ignored, as this is allowed in Core.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45601
git-svn-id: http://core.svn.wordpress.org/trunk@45412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 03:14:56 +00:00
d378f0a8f4
Coding Standards: Upgrade WPCS to 2.1.1.
...
Noteable changes:
- WPCS now throws warnings when non-strict comparisons are used. There are quite a few of them in Core. 🙃
- WPCS now detects and warns for assignments in loop conditions.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45600
git-svn-id: http://core.svn.wordpress.org/trunk@45411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 02:50:56 +00:00
a02b5cc2a8
Coding Standards: Mark the handful of hook names with uppercase characters or hyphens as ignored.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45599
git-svn-id: http://core.svn.wordpress.org/trunk@45410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 01:45:56 +00:00
b8be081e7e
Text Changes: Use consistent question wording in database connection error messages.
...
Props Presskopp.
See #44878 .
Built from https://develop.svn.wordpress.org/trunk@45598
git-svn-id: http://core.svn.wordpress.org/trunk@45409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 10:58:56 +00:00
4af4c78a27
Text Changes: Use consistent question wording for plugin and theme deletion confirmations.
...
Props johnjamesjacoby, Presskopp.
Fixes #44878 .
Built from https://develop.svn.wordpress.org/trunk@45597
git-svn-id: http://core.svn.wordpress.org/trunk@45408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 09:56:57 +00:00
abe3ec288b
Twenty Nineteen: Fix markup errors in `twentynineteen_add_ellipses_to_nav()`:
...
* Add missing i18n for `aria-label` attribute.
* Remove redundant screen reader text superseded by `aria-label`.
* Remove unnecessary `id` and `class` attributes.
Props afercia, chetan200891, ianbelanger.
Fixes #47067 .
Built from https://develop.svn.wordpress.org/trunk@45596
git-svn-id: http://core.svn.wordpress.org/trunk@45407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 09:23:55 +00:00
d1815a5c91
Twenty Nineteen: Adjust markup in `twentynineteen_add_ellipses_to_nav()` for better readability.
...
See #47067 .
Built from https://develop.svn.wordpress.org/trunk@45595
git-svn-id: http://core.svn.wordpress.org/trunk@45406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 09:15:58 +00:00
f84ab5e19f
Twenty Nineteen: Update `package.json` with the latest package versions to pass `npm audit`.
...
Props netweb.
Fixes #47631 .
Built from https://develop.svn.wordpress.org/trunk@45594
git-svn-id: http://core.svn.wordpress.org/trunk@45405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 00:38:58 +00:00
3a57fee891
Script Loader: Remove unnecessary `jquery` dependency for `wp-sanitize.js`.
...
The file is written in plain JavaScript.
Props sstoqnov.
Fixes #47324 .
Built from https://develop.svn.wordpress.org/trunk@45593
git-svn-id: http://core.svn.wordpress.org/trunk@45404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 00:33:57 +00:00
f154cd0780
Bundled Themes: Remove extra semicolons from CSS files.
...
Props shashank3105, ianbelanger.
Fixes #47178 .
Built from https://develop.svn.wordpress.org/trunk@45592
git-svn-id: http://core.svn.wordpress.org/trunk@45403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 00:27:58 +00:00
268c64913e
Query: Make sure `$climits` variable in `WP_Query::get_posts()` is always defined to avoid a PHP notice.
...
Props juiiee8487, agengineering.
Fixes #47638 .
Built from https://develop.svn.wordpress.org/trunk@45591
git-svn-id: http://core.svn.wordpress.org/trunk@45402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-03 01:14:57 +00:00
4803fc405e
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in `wp-includes`.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45590
git-svn-id: http://core.svn.wordpress.org/trunk@45401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 23:42:58 +00:00
55b2d94cca
Formatting: Revert the changes to `wpautop()` in [45585,45587].
...
See #27350 .
Built from https://develop.svn.wordpress.org/trunk@45589
git-svn-id: http://core.svn.wordpress.org/trunk@45400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 11:22:56 +00:00
073f379fd3
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in `tests`.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45588
git-svn-id: http://core.svn.wordpress.org/trunk@45399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 04:43:57 +00:00
b57d185bb1
Formatting: Improve performance of `wpautop()` on large paragraphs.
...
Following [45585], older versions of PHP could segfault when attempting to autop paragraphs with 10,000+ characters.
Rather than having to negative lookahead for every character in the paragraph (which could run into recursion limits), we can quickly jump ahead to the next tag and start checking from there.
See #27350 .
Built from https://develop.svn.wordpress.org/trunk@45587
git-svn-id: http://core.svn.wordpress.org/trunk@45398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 03:29:55 +00:00
d7b95b1a86
Docs: Update some function docs and signatures.
...
- Update the `_wp_specialchars()` docs to match the function signature.
- Update the `human_time_diff()` function signature to match the docs.
Props subrataemfluence.
Fixes #46845 .
Built from https://develop.svn.wordpress.org/trunk@45586
git-svn-id: http://core.svn.wordpress.org/trunk@45397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 01:45:58 +00:00
23de362563
Clean up stray `<p>` tags added by `wpautop()` inside block level tags.
...
`autop()` can sometimes get confused and not clean up stray `<p>` or `</p>` tags inside block level elements, which produces sub-optimal HTML. While browsers can generally handle it, there's no need to make things harder for them if we don't have to.
Props pento, ayubi, pbearne, jond, azaozz, 1994rstefan, dionysous, MikeHansenMe, jorbin, miqrogroove, niallkennedy.
Fixes #27350 .
Built from https://develop.svn.wordpress.org/trunk@45585
git-svn-id: http://core.svn.wordpress.org/trunk@45396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 01:31:56 +00:00
4568c13df8
Taxonomy: add a new 'terms_pre_query' filter to short circuit WP_Term_Query 'get_terms' queries.
...
Add a new `terms_pre_query` filter which returns null by default. Return a non-null value to bypass WordPress's default `get_terms` queries.
Props jarocks, boonebgorges, spacedmonkey.
Fixes #41246 .
Built from https://develop.svn.wordpress.org/trunk@45584
git-svn-id: http://core.svn.wordpress.org/trunk@45395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 20:48:58 +00:00
cf3fa9f7c8
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in `wp-admin`.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45583
git-svn-id: http://core.svn.wordpress.org/trunk@45394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 12:52:01 +00:00
b2d5a4216c
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in the base directory.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45582
git-svn-id: http://core.svn.wordpress.org/trunk@45393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 08:27:58 +00:00
0d23be600e
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in the default themes.
...
See #47632
Built from https://develop.svn.wordpress.org/trunk@45581
git-svn-id: http://core.svn.wordpress.org/trunk@45392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 08:23:57 +00:00
55af0f0d0a
Coding Standards: Fix/ignore the `WordPress.NamingConventions.ValidFunctionName` violations.
...
See #47632
Built from https://develop.svn.wordpress.org/trunk@45580
git-svn-id: http://core.svn.wordpress.org/trunk@45391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 08:01:57 +00:00
072682b1ed
Multisite: Use `size_format()` in `display_space_usage()`.
...
Deleted code is the best code.
Fixes #28239 .
Built from https://develop.svn.wordpress.org/trunk@45579
git-svn-id: http://core.svn.wordpress.org/trunk@45390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 03:47:56 +00:00
abc0f7dd32
Formatting: Trim leading whitespace in `esc_url()`.
...
Props toszcze.
Fixes #36369 .
Built from https://develop.svn.wordpress.org/trunk@45578
git-svn-id: http://core.svn.wordpress.org/trunk@45389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 03:29:57 +00:00
f3ece5149f
Formatting: Don't add `<p>` tags inside `<svg>` tags.
...
Inline `<svg>`s should generally work, as browsers should just ignore `<p>` or `<br/>` tags that shouldn't be inside the `<svg>`. To keep things neat, however, it's better not add them in the first place.
Props jared_smith, nacin, pento.
Fixes #9437 .
Built from https://develop.svn.wordpress.org/trunk@45577
git-svn-id: http://core.svn.wordpress.org/trunk@45388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 03:19:58 +00:00
93f3335f13
Twenty Seventeen: Correct the CSS selectors intended to fix hover colors for MediaElement controls.
...
This is a follow-up to the previous fix in [45146], which didn't work as expected.
Props ryokuhi.
Fixes #47543 . See #40843 .
Built from https://develop.svn.wordpress.org/trunk@45576
git-svn-id: http://core.svn.wordpress.org/trunk@45387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-29 00:51:58 +00:00
405efef86c
Build/Test Tools: Fix the hello e2e test assertion.
...
The previous assertion was always valid because we assumed it returned a single object,
while in reality it was returning an array.
Props hideokamoto.
Fixes #47622 .
Built from https://develop.svn.wordpress.org/trunk@45575
git-svn-id: http://core.svn.wordpress.org/trunk@45386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-28 11:34:58 +00:00
691ffce019
Formatting: Add correct `<p>` tags near `<hr>` tags.
...
It can be tricky to know when `wpautop()` should add `<p>` tags, but one thing we can be certain about is that they really shouldn't be anywhere near `<hr>` tags.
Now they aren't.
Props solarissmoke, MattyRob, pento.
Fixes #14674 .
Built from https://develop.svn.wordpress.org/trunk@45574
git-svn-id: http://core.svn.wordpress.org/trunk@45385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-28 07:16:56 +00:00
dd38e9cc0b
Formatting: Add support for seconds to `human_time_diff()`.
...
The web has gotten so much faster since `human_time_diff()` was created, we need to be able to measure time differences with much finer granularity. Now, we can.
Props johnjamesjacoby, pento.
Fixes #35655 .
Built from https://develop.svn.wordpress.org/trunk@45573
git-svn-id: http://core.svn.wordpress.org/trunk@45384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-28 06:44:57 +00:00
00704114e0
Accessibility: Make the Media modal an ARIA modal dialog.
...
For a number of years, the Media modal missed an explicit ARIA role and the required attributes for modal dialogs.
This was confusing for assistive technology users, since they may not realize they're inside a dialog, and that consequently the keyboard interactions may be different from the rest of the page. Lack of an explicit label for the dialog was confusing as well, since assistive technology users didn't have an immediate sense of what the dialog is for.
This change makes the Media modal meet the ARIA Authoring Practices recommendations, helping users better understand the purpose and interactions with the modal. Also, it makes sure to hide the rest of the page content from assistive technologies, until support for `aria-modal="true"` improves.
Additionally:
- moves the modal H1 heading to the beginning of the modal content
- changes the modal left menu position to make visual and DOM order match
- improves the `wp.media.view.FocusManager` documentation
Fixes #47145 .
Built from https://develop.svn.wordpress.org/trunk@45572
git-svn-id: http://core.svn.wordpress.org/trunk@45383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-27 12:33:56 +00:00
1714484132
Build/Test Tools: Make the local env scripts executable.
...
See #45165 .
Built from https://develop.svn.wordpress.org/trunk@45571
git-svn-id: http://core.svn.wordpress.org/trunk@45382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-27 12:06:55 +00:00
5cf8452ae9
Build/Test Tools: Add the e2e tests setup.
...
- Adds a local environment based on docker
- Adds the e2e tests setup
- Adds a "Hello World" e2e test to serve as a template
Props gziolo, herregroen, mcsf.
Fixes #45165 .
Built from https://develop.svn.wordpress.org/trunk@45570
git-svn-id: http://core.svn.wordpress.org/trunk@45381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-27 11:28:19 +00:00
d2a64fdabd
Formatting: Don't convert smilies in ignored tags that have attributes.
...
Smilies in ignored tags are not supposed to be converted to emoji, but this can malfunction if the tag has attributes. For example, the Preformatted block with add a `class` to the `<pre>` tag.
Props pento, jikamens.
Fixes #47489 .
Built from https://develop.svn.wordpress.org/trunk@45569
git-svn-id: http://core.svn.wordpress.org/trunk@45380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-27 02:05:52 +00:00
573daa129c
Users: Pass `$length`, `$special_chars`, and `$extra_special_chars` parameters to the `random_password` filter in `wp_generate_password()`.
...
Props roytanck.
Fixes #47092 .
Built from https://develop.svn.wordpress.org/trunk@45568
git-svn-id: http://core.svn.wordpress.org/trunk@45379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-27 00:48:53 +00:00
9d7bd11631
Docs: Correct `@since` for `admin/edit-comments.js`, introduced in [3736].
...
See #47581 .
Built from https://develop.svn.wordpress.org/trunk@45567
git-svn-id: http://core.svn.wordpress.org/trunk@45378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-26 18:19:52 +00:00
e23ce44744
REST API: Call `WP_REST_Server::get_compact_response_links()` and `::get_raw_data()` static methods the right way.
...
Props andizer, TimothyBlynJacobs.
Fixes #47578 .
Built from https://develop.svn.wordpress.org/trunk@45566
git-svn-id: http://core.svn.wordpress.org/trunk@45377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-26 18:07:54 +00:00
bab5ed2df5
Docs: Correct and improve the docs for a few nonce-related functions.
...
See #47110
Built from https://develop.svn.wordpress.org/trunk@45565
git-svn-id: http://core.svn.wordpress.org/trunk@45376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-25 17:07:52 +00:00
05c9032a0b
Editor: Fix undefined `$locked` var in edit-form-blocks.php when the `show_post_locked_dialog` filter is used to disable displaying of the dialog.
...
Props aprea.
Fixes #47604 .
Built from https://develop.svn.wordpress.org/trunk@45564
git-svn-id: http://core.svn.wordpress.org/trunk@45375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-25 15:03:52 +00:00
ba24a8f6d3
Plugins: Fix the plugin details modal layout after [45520].
...
Props mukesh27, marybaum, audrasjb.
Fixes #47561 .
Built from https://develop.svn.wordpress.org/trunk@45563
git-svn-id: http://core.svn.wordpress.org/trunk@45374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-25 14:11:55 +00:00
bb965baeec
Cron: Fix condition reversed in [45559].
...
In [45559] a test for not-falsey was reversed to a falsey check.
Props obenland.
Fixes #47589 .
Built from https://develop.svn.wordpress.org/trunk@45562
git-svn-id: http://core.svn.wordpress.org/trunk@45373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-22 13:43:52 +00:00
73ad55051b
Docs: Improve JSDoc for `media/views/attachment/details.js`.
...
Props maartenleenders, boblinthorst, dfangstrom.
Fixes #47588 .
Built from https://develop.svn.wordpress.org/trunk@45561
git-svn-id: http://core.svn.wordpress.org/trunk@45372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-22 13:02:52 +00:00
b0e82d2cc4
Cron API: Prevent caching of WP Cron requests.
...
Add `Cache-Control` and `Expires` HTTP headers to prevent caching of requests to WP Cron on systems supporting fastcgi_finish_request().
The fastcgi_finish_request() call prevents the setting of further HTTP headers by caching plugins subsequently loaded.
Props kingkero.
Fixes 47396.
Built from https://develop.svn.wordpress.org/trunk@45560
git-svn-id: http://core.svn.wordpress.org/trunk@45371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-22 11:13:51 +00:00
fdb8ff4980
Code is Poetry: CS Fixes required in wp-cron.php.
...
See #47396 , #41057 .
Built from https://develop.svn.wordpress.org/trunk@45559
git-svn-id: http://core.svn.wordpress.org/trunk@45370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-22 11:12:51 +00:00
225de4e6eb
Docs: Improve JSDoc for `admin/edit-comments.js`.
...
Props manuelaugustin, diedeexterkate, thulshof, Xyfi, ireneyoast.
Fixes #47581 .
Built from https://develop.svn.wordpress.org/trunk@45558
git-svn-id: http://core.svn.wordpress.org/trunk@45369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 14:45:51 +00:00
bcc4ecb1f6
Themes: improve search by trimming search string.
...
Fix an issue where searching installed themes for an empty string resulted in matching all themes.
Props afercia, desrosj, hesyifei, evalarumbe.
Fixes #39041 .
Built from https://develop.svn.wordpress.org/trunk@45557
git-svn-id: http://core.svn.wordpress.org/trunk@45368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 14:15:53 +00:00
89e7a75d96
Date/Time: Eliminate use of `date_default_timezone_set()` for determining DST status on General Options screen.
...
Time calculations should not need to rely on manipulating global PHP configuration state.
Props Rarst.
Fixes #46483 .
Built from https://develop.svn.wordpress.org/trunk@45556
git-svn-id: http://core.svn.wordpress.org/trunk@45367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 14:11:53 +00:00
a06e914bae
Date/Time: Add more supported formats to `wp_maybe_decline_date()`.
...
Props SergeyBiryukov, Rarst.
Fixes #37411 .
Built from https://develop.svn.wordpress.org/trunk@45555
git-svn-id: http://core.svn.wordpress.org/trunk@45366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 13:47:52 +00:00
bd239b4be8
XML-RPC: Merge similar translation strings.
...
Props ramiy.
Fixes #47039 .
Built from https://develop.svn.wordpress.org/trunk@45554
git-svn-id: http://core.svn.wordpress.org/trunk@45365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 12:53:52 +00:00
8756207ef2
Comments: Open comment quick edit on double click.
...
In [42767] the quick edit button changed from a link to a button. This caused the jQuery code that selects on a link to no longer work. This commit restores the previous behavior.
Fixes #47572 .
See #43382 , #38677 .
Built from https://develop.svn.wordpress.org/trunk@45553
git-svn-id: http://core.svn.wordpress.org/trunk@45364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 10:06:51 +00:00
470177a906
Help/About: Improve wording of PHP Error Protection section.
...
Props pedromendonca, garrett-eclipse.
See #47475 .
Fixes #47538 .
Built from https://develop.svn.wordpress.org/trunk@45551
git-svn-id: http://core.svn.wordpress.org/trunk@45362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 09:52:54 +00:00
f0e9ffdebb
Plugins: When validating plugin's WordPress and PHP requirements, check for `Requires at least` and `Requires PHP` headers in the plugin's main PHP file.
...
This allows for blocking plugin activation if it requires a higher version of PHP or WordPress, and does not have a `readme.txt` file.
If the headers are defined in both `readme.txt` and the main plugin file, precedence is given to the plugin file.
Props afragen, Otto42, Ipstenu.
Fixes #46938 .
Built from https://develop.svn.wordpress.org/trunk@45546
git-svn-id: http://core.svn.wordpress.org/trunk@45357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-18 03:24:52 +00:00
55d05b56c3
Bootstrap/Load: Set expiration of the recovery mode cookie to the same amount of time for which the token in it is valid: a week by default.
...
Props david.binda, TimothyBlynJacobs.
Fixes #47480 .
Built from https://develop.svn.wordpress.org/trunk@45545
git-svn-id: http://core.svn.wordpress.org/trunk@45356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-17 19:17:54 +00:00
038c980a42
Bootstrap/Load: Return a 403 error code when the recovery mode cookie is invalid or expired, or the exit recovery mode nonce check failed.
...
Props david.binda, spacedmonkey.
Fixes #47479 .
Built from https://develop.svn.wordpress.org/trunk@45544
git-svn-id: http://core.svn.wordpress.org/trunk@45355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-17 18:37:55 +00:00
88ffa41ee3
Media: Ignore errors coming from `image_resize_dimensions()` when creating sub-sizes (for now). It returns `false` when the requested size is larger than the original image and should be skipped. This triggers new `WP_Error` in `WP_Image_Editor::resize()`.
...
See #40439 .
Built from https://develop.svn.wordpress.org/trunk@45543
git-svn-id: http://core.svn.wordpress.org/trunk@45354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-16 01:33:51 +00:00
4e4ef1170b
I18N: Merge duplicate strings in notifications displayed when a new user has been created or added to the site.
...
Props ramiy.
Fixes #35746 .
Built from https://develop.svn.wordpress.org/trunk@45542
git-svn-id: http://core.svn.wordpress.org/trunk@45353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 18:57:52 +00:00
6b74e27d04
Media: fix support for arrays for the `crop` setting for registered image sub-sizes in `wp_get_registered_image_subsizes()`.
...
See #40439 .
Built from https://develop.svn.wordpress.org/trunk@45541
git-svn-id: http://core.svn.wordpress.org/trunk@45352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 17:17:52 +00:00
da7839dc45
After [45538]: fix another WPCS "strict comparison" fix.
...
Props birgire.
See #40439 .
Built from https://develop.svn.wordpress.org/trunk@45540
git-svn-id: http://core.svn.wordpress.org/trunk@45351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 16:24:52 +00:00
5987caeecc
After [45538]: fix a WPCS fix and make couple of var names consistent.
...
See #40439 .
Built from https://develop.svn.wordpress.org/trunk@45539
git-svn-id: http://core.svn.wordpress.org/trunk@45350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 01:32:53 +00:00
05302bd054
Save progress of intermediate image creation after upload. First run.
...
- Introduces `wp_get_missing_image_subsizes()` and `wp_update_image_subsizes()` to generate image sub-sizes that are missing or were not created after the upload.
- Adds a way to display errors that happened while creating sub-sizes.
- Introduces `wp_create_image_subsizes()` intended for use after an image was uploaded. It saves/updates the image metadata immediately after each sub-size is created. This fixes the (long standing) problem when some of the sub-size image files were created but there was a timeout or an error and the metadata was not saved. Until now such uploads were considered "failed" which usually resulted in the user trying to upload the same image again, creating even more "orphan" image files.
Note that the patch also includes some unrelated WPCS fixes.
Props mikeschroder, azaozz.
See #40439 .
Built from https://develop.svn.wordpress.org/trunk@45538
git-svn-id: http://core.svn.wordpress.org/trunk@45349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 01:02:52 +00:00
8a2daa7648
Menus: Set better default for `$args` parameter in `Walker_Nav_Menu` methods, to match the documented parameter type.
...
Props trasweb.
Fixes #47524 .
Built from https://develop.svn.wordpress.org/trunk@45537
git-svn-id: http://core.svn.wordpress.org/trunk@45348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-14 11:26:52 +00:00
0239fe6d10
Administration: Adjust code for "Manage widgets or menus" item on "Welcome to WordPress" panel to avoid an extra space after [42343].
...
Props Presskopp, davidbaumwald.
Fixes #47536 .
Built from https://develop.svn.wordpress.org/trunk@45536
git-svn-id: http://core.svn.wordpress.org/trunk@45347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-14 00:29:52 +00:00
3d61f81536
Docs: Fix typos in `Services_JSON` DocBlocks.
...
Props mukesh27.
Fixes #47401 .
Built from https://develop.svn.wordpress.org/trunk@45535
git-svn-id: http://core.svn.wordpress.org/trunk@45346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-13 19:19:52 +00:00
d38e15e59d
Fix displaying of the "An updated version of WordPress is available." notice when running the latest nightly build. Note that it is still displayed when running a local build or from `/src`.
...
Props afragen, audrasjb, SergeyBiryukov.
Fixes #45202 .
Built from https://develop.svn.wordpress.org/trunk@45532
git-svn-id: http://core.svn.wordpress.org/trunk@45343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-13 16:43:53 +00:00
d69a3e6f90
Accessibility: Handle one more case of focus loss when switching view in the Media Views.
...
See #43169 .
Built from https://develop.svn.wordpress.org/trunk@45531
git-svn-id: http://core.svn.wordpress.org/trunk@45342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-13 16:22:52 +00:00
727838a11b
Add a Recovery Mode Exit button to the notice. This fixes it in responsive view.
...
Props desrosj, karmatosed, chetan200891, afercia, afragen, garrett-eclipse.
Fixes #47070 .
Built from https://develop.svn.wordpress.org/trunk@45529
git-svn-id: http://core.svn.wordpress.org/trunk@45340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-13 16:00:52 +00:00
7be747f86d
Customize: Remove “Update” link for themes on multisite installs.
...
In [38887], installing themes in the Customizer was disabled for multisite installs. However, an update link continues to be displayed when a theme update is available. Clicking the link causes a JavaScript error.
This removes that update link because updates cannot actually be performed in the Customizer in this situation.
Props desrosj, earnjam, mukesh27, audrasjb, garrett-eclipse.
Fixes #46997 .
Built from https://develop.svn.wordpress.org/trunk@45527
git-svn-id: http://core.svn.wordpress.org/trunk@45338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-13 15:31:52 +00:00
c622fb4fe1
Media: Make sure the bottom media toolbar content is fully visible with Internet Explorer 11.
...
Props mspatovaliyski.
Fixes #47502 .
Built from https://develop.svn.wordpress.org/trunk@45526
git-svn-id: http://core.svn.wordpress.org/trunk@45337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-13 14:12:52 +00:00
2ca468889a
Bundled Theme: Fix malformed Google Font URL for Twenty Twelve due to double-encoding of `+`
...
Amends [45485].
Fixes #47282 .
Built from https://develop.svn.wordpress.org/trunk@45525
git-svn-id: http://core.svn.wordpress.org/trunk@45336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 23:33:50 +00:00
340fd28d82
Accessibility: Improve focus management in the Media Views.
...
- keeps focus management only where necessary to avoid focus losses
- removes focus management where a specific user workflow was assumed
- makes the "Attachment Details" navigation buttons really disabled when there are no next or previous attachments
- adds inline comments to clarify all the usages of focus()
Fixes #43169 .
Built from https://develop.svn.wordpress.org/trunk@45524
git-svn-id: http://core.svn.wordpress.org/trunk@45335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 21:03:52 +00:00
9f579ea448
Administration: Improve the horizontal centering of the Site Health tabs.
...
Props dkarfa, davidbaumwald, Clorith, tinkerbelly, afercia.
Fixes #46881 .
Built from https://develop.svn.wordpress.org/trunk@45522
git-svn-id: http://core.svn.wordpress.org/trunk@45333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 19:31:52 +00:00
9f7f9d2d89
Administration: Fix the responsive layout after changes to the Screen Options and Help buttons position.
...
Fixes #45094 .
Built from https://develop.svn.wordpress.org/trunk@45520
git-svn-id: http://core.svn.wordpress.org/trunk@45331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 19:21:54 +00:00
d0c1b77cda
Privacy tools:
...
- Move the (remaining) privacy tools related functions from `wp-admin/includes/file.php` to `wp-admin/includes/privacy-tools.php`.
- Move the `WP_User_Request` class to a separate file.
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45519
git-svn-id: http://core.svn.wordpress.org/trunk@45330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 23:54:53 +00:00
3b69e493f6
I18N: Merge duplicate "authenticity could not be verified" strings, fix comma placement on About page.
...
Props pedromendonca, garrett-eclipse.
Fixes #47475 .
Built from https://develop.svn.wordpress.org/trunk@45515
git-svn-id: http://core.svn.wordpress.org/trunk@45326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 14:14:51 +00:00
a5e57d7245
Site health: Introduce `view_site_health_checks` capability.
...
Introduces the faux primitive capability `view_site_health_checks` available to single site admins and multisite super-admin to view the site health page within the admin.
The capability is mapped to the `install_plugins` capability without being dependent on the file system being writable. This fixes a bug where the feature couldn't be used by sites unable to write to the file system or managed through version control.
The capability is granted on the `user_has_cap` filter.
Props birgire, Clorith, palmiak, peterwilsoncc, spacedmonkey.
Fixes #46957 .
Built from https://develop.svn.wordpress.org/trunk@45507
git-svn-id: http://core.svn.wordpress.org/trunk@45318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 07:42:52 +00:00
f57e10a35d
Accessibility: Fix the order of the Previous, Next, and Close buttons in the Attachment Details modal.
...
Making the visual and DOM order match benefits keyboard users who navigate documents sequentially and expect the focus order to be consistent with the sequential reading order.
Fixes #47458 .
Built from https://develop.svn.wordpress.org/trunk@45506
git-svn-id: http://core.svn.wordpress.org/trunk@45317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-09 15:48:53 +00:00
c9b51df3d0
I18N: Allow the length of automatically generated excerpts to be localized.
...
This introduces three new strings that can be used to control the maximum length of automatically generated excerpts for posts, comments, and draft post previews in the dashboard. Optionally combined with the existing word count type control this allows languages which include many multibyte characters to specify more appropriate maximum excerpt lengths.
Props miyauchi, birgire, johnbillion
Fixes #44541
Built from https://develop.svn.wordpress.org/trunk@45505
git-svn-id: http://core.svn.wordpress.org/trunk@45316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 18:42:52 +00:00
eeba1c1244
HTTP API: Ensure the `http_api_debug` hook is fired for all responses.
...
This means that logging and debugging functionality can access the error code and error message for erroneous responses under all conditions. The hook is not fired when a request is short-circuited with the `pre_http_request` filter, because this filter itself can be used in that situation.
Fixes #25747
Built from https://develop.svn.wordpress.org/trunk@45504
git-svn-id: http://core.svn.wordpress.org/trunk@45315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 17:10:52 +00:00
935c35fe34
Accessibility: Improve the Screen Options and Help buttons order.
...
- makes the buttons visual order match the DOM order
- also, restores the focus style on the "hero" primary button after [34948]
Props vrimill, mukesh27 for reporting and testing.
Fixes #45094 .
Built from https://develop.svn.wordpress.org/trunk@45503
git-svn-id: http://core.svn.wordpress.org/trunk@45314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 16:31:53 +00:00
be14c6e5c6
Administration: Improve the Screen Options and Help buttons focus style after [45501].
...
Amends [45501].
See #46749 .
Built from https://develop.svn.wordpress.org/trunk@45502
git-svn-id: http://core.svn.wordpress.org/trunk@45313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 16:07:52 +00:00
17034e2a4e
Administration: Remove extra border from the Screen Options and Help buttons.
...
The extra border was visible in the responsive view for smaller screens after [32844].
Props jitendrabanjara1991.
Fixes #46749 .
Built from https://develop.svn.wordpress.org/trunk@45501
git-svn-id: http://core.svn.wordpress.org/trunk@45312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 14:50:52 +00:00
7cee029897
Privacy tools: remove some left-over code and fix inline comment.
...
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45500
git-svn-id: http://core.svn.wordpress.org/trunk@45311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 00:30:51 +00:00
6a9bcaeaa9
Accessibility: Improve accessibility of all the media views form controls.
...
- changes the media views form controls to have explicitly associated labels with for/id attributes
- adds a few missing labels / aria-labels
- improves a few existing labels / aria-labels
- improves semantics in a few places, by adding visually hidden headings, fieldset + legend elements, aria-describedby attributes
- improves the image custom size input fields and their labelling
- adds `role="status"` to the "saved" indicator so that status messages are announced to assistive technologies
- swaps the columns source order in the image details template, to make visual and DOM order match
- swaps the "Replace" and "Back" buttons source order in the Replace Image view, to make visual and DOM order match
- gallery settings: move checkbox label to the right: checkboxes are supposed to have labels on the right
- merge similar strings, unified to "Drop files to upload" (removed "Drop files here", and "Drop files anywhere to upload")
- makes the "upload-ui" consistent across the media views
- hides the IE 11 "X" `::-ms-clear` button in the Insert from URL field, as it conflicts with the uploading spinner
- adds comments to all the media templates to clarify their usage
- slightly increases vertical spacing between form fields in the media sidebar
- removes some CSS selectors introduced as backwards compatibility for WordPress pre-4.4
- removes some CSS still targeting Internet Explorer 7 and 8
Fixes #47141 .
Fixes #47122 .
Built from https://develop.svn.wordpress.org/trunk@45499
git-svn-id: http://core.svn.wordpress.org/trunk@45310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 20:45:02 +00:00
314bfab180
Regenerate the REST API fixtures after [45443].
...
See #38517 .
Built from https://develop.svn.wordpress.org/trunk@45498
git-svn-id: http://core.svn.wordpress.org/trunk@45309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 20:24:52 +00:00
d5333b9593
Fix the media player controls bar width in the media views.
...
Props vaishalipanchal, chetan200891.
Fixes #47457 .
Built from https://develop.svn.wordpress.org/trunk@45497
git-svn-id: http://core.svn.wordpress.org/trunk@45308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 13:29:52 +00:00
056b9c47a2
Docs: Fix typo in `comment_class()` DocBlock.
...
Props mbabker.
Fixes #47499 .
Built from https://develop.svn.wordpress.org/trunk@45496
git-svn-id: http://core.svn.wordpress.org/trunk@45307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-06 23:52:51 +00:00
baa2cd69b8
Media: Restore correct arrow direction in RTL in Attachment Details modal.
...
Reverts [29264]. As we now have a build task to replace dashicons for RTL, the CSS rules no longer worked as expected and had the opposite effect.
Props ramiy, SergeyBiryukov.
Fixes #46289 .
Built from https://develop.svn.wordpress.org/trunk@45495
git-svn-id: http://core.svn.wordpress.org/trunk@45306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-06 01:25:52 +00:00
53719315b4
I18N: Merge duplicate "Original" strings used in the same context (referring to image size).
...
Props mukesh27.
Fixes #47486 .
Built from https://develop.svn.wordpress.org/trunk@45494
git-svn-id: http://core.svn.wordpress.org/trunk@45305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-05 15:23:52 +00:00
3f9bf72d69
I18N: Correct encoding for `wp-includes/widgets/class-wp-widget-calendar.php`, accidentally saved in ANSI instead of UTF-8.
...
See #47485 .
Built from https://develop.svn.wordpress.org/trunk@45493
git-svn-id: http://core.svn.wordpress.org/trunk@45304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-05 15:09:53 +00:00
16dfde180c
I18N: Merge duplicate "A calendar of your site’s posts" strings used in the Calendar widget and the Calendar block in the editor.
...
Props jorgefilipecosta, ramiy.
Fixes #47485 .
Built from https://develop.svn.wordpress.org/trunk@45492
git-svn-id: http://core.svn.wordpress.org/trunk@45303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-05 15:03:53 +00:00
8c449d3312
Posts, Post Types: Switch the order of arguments for `implode()` in `the_meta()` to match the function notation.
...
Props loyaltymanufaktur.
Fixes #47481 .
Built from https://develop.svn.wordpress.org/trunk@45491
git-svn-id: http://core.svn.wordpress.org/trunk@45302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-05 00:16:54 +00:00
4c0620bdf8
Privacy: Remove inline CSS within personal data request list tables.
...
The `.hidden` class can be used to show and hide UI elements instead.
Props birgire, pratikthink, garrett-eclipse.
Fixes #44839 .
Built from https://develop.svn.wordpress.org/trunk@45490
git-svn-id: http://core.svn.wordpress.org/trunk@45301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-04 23:40:55 +00:00
aa59cb8359
Docs: Correct parameter name for `wp_new_user_notification_email_admin` filter.
...
Props needle.
Fixes #47476 .
Built from https://develop.svn.wordpress.org/trunk@45489
git-svn-id: http://core.svn.wordpress.org/trunk@45300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-04 12:48:55 +00:00
32d761ce7d
I18N: Merge duplicate "Status" and "Info" strings on Site Health screens.
...
Props ramiy.
Fixes #47227 .
Built from https://develop.svn.wordpress.org/trunk@45488
git-svn-id: http://core.svn.wordpress.org/trunk@45299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-01 22:10:52 +00:00
13da094c39
Upgrade/Install: Correct operator precedence for an error code in `WP_Ajax_Upgrader_Skin::error()`.
...
Props jrf.
Fixes #47441 .
Built from https://develop.svn.wordpress.org/trunk@45487
git-svn-id: http://core.svn.wordpress.org/trunk@45298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-31 14:14:52 +00:00
410eb3501b
Build/Test Tools: Add `$current_screen` to the list of globals to unset in `WP_UnitTestCase_Base::go_to()`.
...
Props mauteri.
Fixes #47439 .
Built from https://develop.svn.wordpress.org/trunk@45486
git-svn-id: http://core.svn.wordpress.org/trunk@45297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-31 14:07:51 +00:00
3c40573f77
Bundled Theme: Load Google fonts with `display=fallback` parameter for better UX in case the font cannot be loaded.
...
Providing this query parameter ensures the stylesheet contains the `font-display: fallback` rule. This changeset also updates the Open Sans font used by core accordingly.
Props westonruter.
Fixes #47282 .
Built from https://develop.svn.wordpress.org/trunk@45485
git-svn-id: http://core.svn.wordpress.org/trunk@45296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-31 10:10:54 +00:00
0d40c54f9b
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/media.css`.
...
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46530 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45484
git-svn-id: http://core.svn.wordpress.org/trunk@45295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 16:45:50 +00:00
412ffd0aaf
Media: Move tag cloud styles that accidentally ended up in Media section after the reorganization in [16136] to a more appropriate place.
...
Remove styles for `wp-admin/update-core.php` accidentally duplicated in Media section as part of the same reorganization.
See #46530 .
Built from https://develop.svn.wordpress.org/trunk@45483
git-svn-id: http://core.svn.wordpress.org/trunk@45294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 16:40:52 +00:00
ebb0b92081
Block Editor: Update packages to the ones slated for WP5.2.2
...
- Fix the template validation notice
- Fix for focus jumps when typing in meta attributes
Packages updated:
- @wordpress/block-editor@2.0.3
- @wordpress/block-library@2.4.6
- @wordpress/e2e-tests@1.1.6
- @wordpress/edit-post@3.3.6
- @wordpress/editor@9.2.6
- @wordpress/format-library@1.4.6
Props aduth, desrosj.
Fixes #47429 .
Built from https://develop.svn.wordpress.org/trunk@45481
git-svn-id: http://core.svn.wordpress.org/trunk@45292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 15:41:57 +00:00
349d95f27a
Docs: Add missing function documentation for `list_plugin_updates()`.
...
Introduced in [9543].
Props priyankkpatel, mukesh27.
Fixes #47424 .
Built from https://develop.svn.wordpress.org/trunk@45480
git-svn-id: http://core.svn.wordpress.org/trunk@45291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 15:10:52 +00:00
012d05f5c0
Docs: Add missing documentation for the locale meta field.
...
The user’s locale is passed in the `$meta` parameter for `insert_user_meta`. Added in [38705].
Props tmatsuur.
Fixes #47423 .
Built from https://develop.svn.wordpress.org/trunk@45479
git-svn-id: http://core.svn.wordpress.org/trunk@45290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 14:37:53 +00:00
96a533b279
CSS Coding Standards: Use unitless values for `line-height` in `wp-includes/css/media-views.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46529 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45478
git-svn-id: http://core.svn.wordpress.org/trunk@45289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 13:18:52 +00:00
9bab7d6fd6
CSS Coding Standards: Use unitless values for `line-height` in `wp-includes/css/editor.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46528 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45477
git-svn-id: http://core.svn.wordpress.org/trunk@45288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:45:53 +00:00
5083e104d4
CSS Coding Standards: Use unitless values for `line-height` in `wp-includes/css/buttons.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46526 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45476
git-svn-id: http://core.svn.wordpress.org/trunk@45287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:42:52 +00:00
1d98a92fad
CSS Coding Standards: Use unitless values for `line-height` in `wp-includes/css/wp-pointer.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46525 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45475
git-svn-id: http://core.svn.wordpress.org/trunk@45286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:41:51 +00:00
90b2092ab6
CSS Coding Standards: Use unitless values for `line-height` in `wp-includes/css/wp-embed-template.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46524 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45474
git-svn-id: http://core.svn.wordpress.org/trunk@45285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:40:52 +00:00
05afb2271d
CSS Coding Standards: Use unitless values for `line-height` in `wp-includes/functions.php`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46523 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45473
git-svn-id: http://core.svn.wordpress.org/trunk@45284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:39:52 +00:00
820baca1bd
CSS Coding Standards: Use unitless values for `line-height` in `wp-includes/css/wp-auth-check.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46522 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45472
git-svn-id: http://core.svn.wordpress.org/trunk@45283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:37:52 +00:00
e6b98a469c
CSS Coding Standards: Use unitless values for `line-height` in `wp-includes/css/jquery-ui-dialog.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46521 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45471
git-svn-id: http://core.svn.wordpress.org/trunk@45282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:36:52 +00:00
8738c23afc
CSS Coding Standards: Use unitless values for `line-height` in `wp-includes/css/customize-preview.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46520 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45470
git-svn-id: http://core.svn.wordpress.org/trunk@45281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:34:52 +00:00
2a417c2168
CSS Coding Standards: Use unitless values for `line-height` in `wp-includes/css/admin-bar.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46519 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45469
git-svn-id: http://core.svn.wordpress.org/trunk@45280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:32:51 +00:00
fdc6b9583b
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/revisions.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46517 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45468
git-svn-id: http://core.svn.wordpress.org/trunk@45279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:16:52 +00:00
ca6aa01705
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/list-tables.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46515 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45467
git-svn-id: http://core.svn.wordpress.org/trunk@45278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:15:52 +00:00
afaeca95cf
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/login.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46514 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45466
git-svn-id: http://core.svn.wordpress.org/trunk@45277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:09:52 +00:00
1899a99c35
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/install.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46513 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45465
git-svn-id: http://core.svn.wordpress.org/trunk@45276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 11:53:53 +00:00
03814826b2
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/forms.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46512 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45464
git-svn-id: http://core.svn.wordpress.org/trunk@45275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 11:49:53 +00:00
41accccad6
Administration: Improve the Site Health tables layout for small screens.
...
Props immeet94, jankimoradiya, desrosj, shashank3105, chetan200891, Clorith, hedgefield.
Fixes #46960 .
Built from https://develop.svn.wordpress.org/trunk@45463
git-svn-id: http://core.svn.wordpress.org/trunk@45274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 18:22:51 +00:00
52d478cb0d
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/edit.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46511 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45462
git-svn-id: http://core.svn.wordpress.org/trunk@45273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:05:53 +00:00
ce25e2f34d
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/dashboard.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46510 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45461
git-svn-id: http://core.svn.wordpress.org/trunk@45272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:03:52 +00:00
9860a4366d
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/customize-widgets.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46509 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45460
git-svn-id: http://core.svn.wordpress.org/trunk@45271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:01:53 +00:00
bb3c264350
Administration: Add missing filter documentation for Site Health auto update tests.
...
Props johnbillion, mukesh27.
Fixes #47388 .
Built from https://develop.svn.wordpress.org/trunk@45459
git-svn-id: http://core.svn.wordpress.org/trunk@45270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 13:59:51 +00:00
d23160d427
Fix unit tests after [45456]. The query string is a bit different but the results are the same.
...
See #45346 .
Built from https://develop.svn.wordpress.org/trunk@45458
git-svn-id: http://core.svn.wordpress.org/trunk@45269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-28 04:19:53 +00:00
311527b41d
Fix previous WPCS errors in `script-loader.php` triggered by [45456].
...
See #45346 .
Built from https://develop.svn.wordpress.org/trunk@45457
git-svn-id: http://core.svn.wordpress.org/trunk@45268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-28 03:32:52 +00:00
6de52463a7
Script loader: prevent sorting of the `load` array in the query string when passing the script handles to load-scripts.php and load-styles.php.
...
Fixes #45346 #26886 .
Built from https://develop.svn.wordpress.org/trunk@45456
git-svn-id: http://core.svn.wordpress.org/trunk@45267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-28 02:43:55 +00:00
b8fa71964f
Build tools, WPCS: disable line ending check when running `phpcs` but fix them to `\n` whit `phpcfb`. Fixes (erroneous) reports on Windows about improper line endings in all files. They are managed directly by Git or SVN.
...
Fixes #47411 .
Built from https://develop.svn.wordpress.org/trunk@45455
git-svn-id: http://core.svn.wordpress.org/trunk@45266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-28 00:26:54 +00:00
51ee349942
Docs: Add a comment about the reinstated `wp-admin/options-privacy.php`.
...
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45454
git-svn-id: http://core.svn.wordpress.org/trunk@45265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-27 03:03:52 +00:00
96b4570781
Privacy: Remove reinstated `wp-admin/options-privacy.php` from `$_old_files`.
...
Fix WPCS violations in [45448].
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45453
git-svn-id: http://core.svn.wordpress.org/trunk@45264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-27 02:40:53 +00:00
2f7f0ad901
Fix typo in [45451] and move the redirect to the proper location.
...
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45452
git-svn-id: http://core.svn.wordpress.org/trunk@45263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 23:21:51 +00:00
cbcccbd5b6
Privacy tools: restore `privacy.php` to its "proper" use to output the Privacy tab on the About screen, see [42814]. Then add the Privacy tab updates from freedoms.php.
...
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45451
git-svn-id: http://core.svn.wordpress.org/trunk@45262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 22:57:52 +00:00
6aab3f2f05
Docs: Improve documentation for some more variadic functions.
...
Fixes #37402
Built from https://develop.svn.wordpress.org/trunk@45450
git-svn-id: http://core.svn.wordpress.org/trunk@45261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 22:48:51 +00:00
557ef04409
Docs: Improve docs for variadic functions relating to widgets and their controls.
...
See #37402
Built from https://develop.svn.wordpress.org/trunk@45449
git-svn-id: http://core.svn.wordpress.org/trunk@45260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 22:05:51 +00:00
87acdab81d
Privacy tools: Organize privacy functions into logical files and classes.
...
Props xkon, birgire, desrosj, garrett-eclipse, azaozz.
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45448
git-svn-id: http://core.svn.wordpress.org/trunk@45259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 20:50:53 +00:00
67f944caa6
I18N: Remove PHP function name from translatable string in `WP_Recovery_Mode_Email_Service`.
...
Props ramiy.
Fixes #47255 .
Built from https://develop.svn.wordpress.org/trunk@45447
git-svn-id: http://core.svn.wordpress.org/trunk@45258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 20:44:52 +00:00
ead1a54576
Build/Test Tools: Revert an accidental change to Node dependencies.
...
See #47380
Built from https://develop.svn.wordpress.org/trunk@45446
git-svn-id: http://core.svn.wordpress.org/trunk@45257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 19:37:51 +00:00
27365c4ec4
Build/Test Tools: Remove the dependency on a globally installed Grunt.
...
The existing `"grunt": "grunt"` script in `package.json` allows for the use of `npm run grunt ...` which uses the local `grunt` binary in the project's `node_modules`.
Fixes #47380
Built from https://develop.svn.wordpress.org/trunk@45445
git-svn-id: http://core.svn.wordpress.org/trunk@45256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 19:35:51 +00:00
2205bc5e92
I18N: Merge duplicate "Invalid post parent ID" strings.
...
Props ramiy.
Fixes #47270 .
Built from https://develop.svn.wordpress.org/trunk@45444
git-svn-id: http://core.svn.wordpress.org/trunk@45255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 19:05:53 +00:00
d4256378dd
Administration: Replace one more reference to "articles" with "posts" for greater consistency of terminology.
...
See #38517 .
Built from https://develop.svn.wordpress.org/trunk@45443
git-svn-id: http://core.svn.wordpress.org/trunk@45254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 18:51:52 +00:00
b8b12b4946
I18N: Merge duplicate "Status is forbidden" strings.
...
Props ramiy.
Fixes #47037 .
Built from https://develop.svn.wordpress.org/trunk@45442
git-svn-id: http://core.svn.wordpress.org/trunk@45253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 18:47:53 +00:00
cd9c6ce36e
I18N: Merge duplicate "Add Comment" strings.
...
Props ramiy.
Fixes #47246 .
Built from https://develop.svn.wordpress.org/trunk@45441
git-svn-id: http://core.svn.wordpress.org/trunk@45252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 18:43:52 +00:00
dd7956c674
I18N: Use consistent error messages when importing or exporting content.
...
Props ramiy.
Fixes #42269 .
Built from https://develop.svn.wordpress.org/trunk@45440
git-svn-id: http://core.svn.wordpress.org/trunk@45251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 18:09:52 +00:00
702f7d4e8d
I18N: Merge duplicate "not allowed to manage options" strings.
...
Props ramiy.
Fixes #42271 .
Built from https://develop.svn.wordpress.org/trunk@45439
git-svn-id: http://core.svn.wordpress.org/trunk@45250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 16:00:52 +00:00
b97a2d4366
I18N: Merge duplicate "Loading..." strings.
...
Props ramiy.
Fixes #47248 .
Built from https://develop.svn.wordpress.org/trunk@45438
git-svn-id: http://core.svn.wordpress.org/trunk@45249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 15:46:52 +00:00
21a12ce6cd
I18N: Merge similar strings in Edit Media help tabs.
...
Props ramiy.
Fixes #46919 .
Built from https://develop.svn.wordpress.org/trunk@45437
git-svn-id: http://core.svn.wordpress.org/trunk@45248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 15:38:53 +00:00
f5f7e99927
I18N: Remove unnecessary context for "WordPress.org" string in `WP_Widget_Meta`.
...
Props ramiy.
Fixes #47038 .
Built from https://develop.svn.wordpress.org/trunk@45436
git-svn-id: http://core.svn.wordpress.org/trunk@45247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 15:33:52 +00:00
bc8ddf3b38
I18N: Remove unnecessary HTML from "Previewing:" string in `WP_Customize_Theme_Control`.
...
Props ramiy.
Fixes #47271 .
Built from https://develop.svn.wordpress.org/trunk@45435
git-svn-id: http://core.svn.wordpress.org/trunk@45246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 15:30:53 +00:00
47720de1c2
Text Changes: Use consistent question wording for discarding unpublished changes in Customizer.
...
Props ramiy.
Fixes #47258 .
Built from https://develop.svn.wordpress.org/trunk@45434
git-svn-id: http://core.svn.wordpress.org/trunk@45245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 15:19:50 +00:00
9f4c2fcbae
I18N: Merge duplicate "Try Again" strings.
...
Props ramiy.
Fixes #47251 .
Built from https://develop.svn.wordpress.org/trunk@45433
git-svn-id: http://core.svn.wordpress.org/trunk@45244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 14:40:51 +00:00
6c50f22e4e
I18N: Remove unnecessary markup from plugin action messages, for consistency with the rest of the admin.
...
Props ramiy.
Fixes #47238 .
Built from https://develop.svn.wordpress.org/trunk@45432
git-svn-id: http://core.svn.wordpress.org/trunk@45243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 14:36:51 +00:00
f5db16738e
Administration: Merge similar "file does not exist" messages in plugin and theme editors.
...
Props ramiy.
Fixes #47249 .
Built from https://develop.svn.wordpress.org/trunk@45431
git-svn-id: http://core.svn.wordpress.org/trunk@45242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 12:35:51 +00:00
5ec3c66bd3
Docs: Correct `@type` annotation for `wpdb::$last_query`.
...
Props nextendweb, mukesh27.
Fixes #47095 .
Built from https://develop.svn.wordpress.org/trunk@45430
git-svn-id: http://core.svn.wordpress.org/trunk@45241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 02:30:51 +00:00
7aa0ce19cd
Docs: Correct `@type` annotation for `WP_Customize_Widgets` properties.
...
Props diddledan.
Fixes #46856 .
Built from https://develop.svn.wordpress.org/trunk@45429
git-svn-id: http://core.svn.wordpress.org/trunk@45240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 02:16:52 +00:00
b08c42eb80
Docs: Correct `@type` annotation for `WP_Customize_Selective_Refresh::$current_partial_id`.
...
Props diddledan.
Fixes #46854 .
Built from https://develop.svn.wordpress.org/trunk@45428
git-svn-id: http://core.svn.wordpress.org/trunk@45239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 02:12:52 +00:00
3e6ed38da1
Docs: Correct `@type` annotation for `WP_Customize_Nav_Menu_Item_Setting::$value`.
...
Props diddledan.
Fixes #46853 .
Built from https://develop.svn.wordpress.org/trunk@45427
git-svn-id: http://core.svn.wordpress.org/trunk@45238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 02:10:52 +00:00
19503190ba
Docs: Correct `@type` annotation for `WP_Customize_Manager::$_changeset_data`.
...
Props diddledan.
Fixes #46852 .
Built from https://develop.svn.wordpress.org/trunk@45426
git-svn-id: http://core.svn.wordpress.org/trunk@45237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 02:07:53 +00:00
f66429486a
Twenty Seventeen: Accessibility: Add missing focus state for native audio and video embeds.
...
Props kjellr, karlgroves.
Fixes #47190 .
Built from https://develop.svn.wordpress.org/trunk@45425
git-svn-id: http://core.svn.wordpress.org/trunk@45236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 02:01:52 +00:00
c77e771c84
Date/Time: Replace all instances of `date()` with `gmdate()`.
...
Use of `date()` in core depends on PHP timezone set to UTC and not changed by third party code (which cannot be guaranteed).
`gmdate()` is functionally equivalent, but is not affected by PHP timezone setting: it's always UTC, which is the exact behavior the core needs.
Props nielsdeblaauw, Rarst.
Fixes #46438 . See #44491 .
Built from https://develop.svn.wordpress.org/trunk@45424
git-svn-id: http://core.svn.wordpress.org/trunk@45235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 00:12:54 +00:00
17cc8cd0f8
Docs: Correct a theme feature name.
...
See #45134
Built from https://develop.svn.wordpress.org/trunk@45423
git-svn-id: http://core.svn.wordpress.org/trunk@45234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 23:46:52 +00:00
04bba79df9
Docs: Improve documentation for variadic functions relating to post type support and theme support.
...
See #37402
Built from https://develop.svn.wordpress.org/trunk@45422
git-svn-id: http://core.svn.wordpress.org/trunk@45233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 23:41:54 +00:00
e91bf3535c
Docs: Correct a function name in the `do_action()` documentation.
...
See #37402
Built from https://develop.svn.wordpress.org/trunk@45421
git-svn-id: http://core.svn.wordpress.org/trunk@45232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 22:53:51 +00:00
9abcf7881f
Docs: Improve and correct documentation for hook-related variadic functions.
...
See #37402
Built from https://develop.svn.wordpress.org/trunk@45420
git-svn-id: http://core.svn.wordpress.org/trunk@45231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 22:52:54 +00:00
26d5e05b75
Docs: Standardise documentation for capability-related variadic functions.
...
See #37402
Built from https://develop.svn.wordpress.org/trunk@45419
git-svn-id: http://core.svn.wordpress.org/trunk@45230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 22:27:51 +00:00
9c6393e967
Docs: Switch to the more common syntax for variadic function documentation.
...
See #37402
Built from https://develop.svn.wordpress.org/trunk@45418
git-svn-id: http://core.svn.wordpress.org/trunk@45229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 21:59:51 +00:00
fc17576fd2
Accessibility: Improve toggling the "Post locked" information visibility.
...
- effectively hides the "Post locked" information from assistive technologies
- when a post is locked, reveals the "Post locked" information without CSS animation
- the height CSS animation didn't work anyways after [24906]
See #24553 .
Fixes #44946 .
Built from https://develop.svn.wordpress.org/trunk@45417
git-svn-id: http://core.svn.wordpress.org/trunk@45228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 17:15:52 +00:00
48d9d94881
Accessibility: Improve settings tables and forms after [45403].
...
- adds `role="presentation"` to the edit comment table
- removes a few pointless `<fieldset>` elements
- adds a few missing `<label>` elements
- adds the CSS class `class="td-full"` to table rows spanning to multiple cells
- adds explicit `scope="row"` attribute to the table headers in `options-permalink.php`: this table is better communicated as data table
- uses consistent label association in the "Privacy Settings" page
- in the installation page "Set up your database connection": associates descriptions to their inout fields using `aria-describedby`
- improves the link to gravatar.com in the `user-edit.php` page
See #46899 .
Fixes #47390 .
Built from https://develop.svn.wordpress.org/trunk@45416
git-svn-id: http://core.svn.wordpress.org/trunk@45227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 15:19:53 +00:00
00c60ccd33
CSS Coding Standards: Update unitless values for `line-height` in `wp-admin/css/widgets.css` with more precise calculations.
...
Props ianbelanger.
Fixes #46531 .
Built from https://develop.svn.wordpress.org/trunk@45415
git-svn-id: http://core.svn.wordpress.org/trunk@45226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:44:52 +00:00
962da3db60
CSS Coding Standards: Update unitless values for `line-height` in `wp-admin/css/nav-menus.css` with more precise calculations.
...
Props ianbelanger.
Fixes #46516 .
Built from https://develop.svn.wordpress.org/trunk@45414
git-svn-id: http://core.svn.wordpress.org/trunk@45225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:42:52 +00:00
693e90ac81
Editor: In `edit-form-blocks.php`, check the result of `wp_set_post_lock()`, which may return `false` and cause a warning when passed to `implode()`.
...
Props kakshak, aduth.
Fixes #47013 .
Built from https://develop.svn.wordpress.org/trunk@45413
git-svn-id: http://core.svn.wordpress.org/trunk@45224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:35:52 +00:00
35a2322d32
General: Update support forum links.
...
There are a lot of places in Core that link to https://wordpress.org/support/ for the support forums, but that's now the URL for HelpHub. The new forums link is https://wordpress.org/support/forums/ .
This is a follow-up to [45140], which changed the links in help tabs.
Props dilipbheda.
Fixes #47239 . See #46790 .
Built from https://develop.svn.wordpress.org/trunk@45412
git-svn-id: http://core.svn.wordpress.org/trunk@45223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:24:50 +00:00
add6a8e13f
Accessibility: Fix the headings hierarchy in the legacy Custom Background and Custom Header pages.
...
Fixes #47386 .
Built from https://develop.svn.wordpress.org/trunk@45411
git-svn-id: http://core.svn.wordpress.org/trunk@45222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 13:32:53 +00:00
15dc9ab6ab
Build/Test Tools: Ignore generated RTL CSS files from Git version control.
...
Fixes #47078
Built from https://develop.svn.wordpress.org/trunk@45410
git-svn-id: http://core.svn.wordpress.org/trunk@45221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 12:30:52 +00:00
2a02b8fe5d
Docs: Remove full stop from ticket number.
...
See #46402 .
Built from https://develop.svn.wordpress.org/trunk@45409
git-svn-id: http://core.svn.wordpress.org/trunk@45220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 12:09:52 +00:00
a81dfbdf0e
Formatting: Don't run `wp_targeted_link_rel()` on entirely serialized content.
...
Props birgire, elliotcondon.
Fixes #46402 .
Built from https://develop.svn.wordpress.org/trunk@45408
git-svn-id: http://core.svn.wordpress.org/trunk@45219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 12:05:52 +00:00
ca028cfc4c
Users: Allow Super Admins to remove themselves from a site on a Multisite network.
...
Props Mista-Flo, birgire
Fixes #41439
Built from https://develop.svn.wordpress.org/trunk@45407
git-svn-id: http://core.svn.wordpress.org/trunk@45218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 00:13:53 +00:00
eecfa3b4ed
Docs: Correct description for `$seplocation` parameter of `wp_title()`.
...
Props mukesh27, vladlu.
Fixes #47370 .
Built from https://develop.svn.wordpress.org/trunk@45406
git-svn-id: http://core.svn.wordpress.org/trunk@45217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 22:59:52 +00:00
61ed726067
Mail: Use the standardised spelling of `email` in the password reset error message.
...
Fixes #39110
Built from https://develop.svn.wordpress.org/trunk@45405
git-svn-id: http://core.svn.wordpress.org/trunk@45216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 22:53:54 +00:00
b3e297925c
Mail: Improve the user experience when the password reset email cannot be sent.
...
This introduces a link to the support page for resetting your password, and improves the error by bringing it into the login page instead of a `wp_die()`.
Props neelpatel7295, estelaris, desrosj
Built from https://develop.svn.wordpress.org/trunk@45404
git-svn-id: http://core.svn.wordpress.org/trunk@45215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 22:14:52 +00:00
b77cf42c0b
Accessibility: Make sure layout tables across the admin are correctly linearized.
...
Adds `role="presentation"` to the `<table>` elements used for layout purposes.
Ideally, HTML tables should be used for tabular data. When tables are used for layout purposes, it's important to remove any native semantics so that assistive technologies can correctly announce the table content in a linearized fashion.
Props greatislander, afercia.
Fixes #46899 .
Built from https://develop.svn.wordpress.org/trunk@45403
git-svn-id: http://core.svn.wordpress.org/trunk@45214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 21:56:54 +00:00
01917b9f74
I18N: Add a language icon next to language selectors.
...
This change means that users who can't read the site's current language can more easily identify controls that allow them to change either the site language or their own admin area language.
Props janak007, atlasmahesh, afercia, birgire, JoshuaWold
Fixes #43144
Built from https://develop.svn.wordpress.org/trunk@45402
git-svn-id: http://core.svn.wordpress.org/trunk@45213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 20:43:52 +00:00
53794e9719
Administration: Replace references to "articles" with "posts" for greater consistency of terminology.
...
Props angelagibson
Fixes #38517
Built from https://develop.svn.wordpress.org/trunk@45401
git-svn-id: http://core.svn.wordpress.org/trunk@45212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 19:18:51 +00:00
27720e15a7
Bootstrap/Load: In `wp_get_server_protocol()`, check if `$_SERVER['SERVER_PROTOCOL']` is defined, to avoid a notice in CLI context.
...
Props thakkarhardik, malthert.
Fixes #47005 .
Built from https://develop.svn.wordpress.org/trunk@45400
git-svn-id: http://core.svn.wordpress.org/trunk@45211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:47:51 +00:00
729d4a4942
I18N: Remove PHP function name from translatable string in `WP_Debug_Data`.
...
Props ramiy.
Fixes #47254 .
Built from https://develop.svn.wordpress.org/trunk@45399
git-svn-id: http://core.svn.wordpress.org/trunk@45210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:41:52 +00:00
e3bb526606
Login and Registration: Pass the action to `site_url()` in `wp_logout_url()` and `wp_lostpassword_url()`:
...
* Make `site_url` filter in `wp_logout_url()` aware of the `logout` action.
* Make `network_site_url` filter in `wp_lostpassword_url()` aware of the `lostpassword` action.
Props jfarthing84.
Fixes #43407 .
Built from https://develop.svn.wordpress.org/trunk@45398
git-svn-id: http://core.svn.wordpress.org/trunk@45209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:33:52 +00:00
6dc1ced79c
Twenty Nineteen: Add missing icon to Edit link for pages.
...
Props mukesh27, ianbelanger, ounziw.
Fixes #47332 .
Built from https://develop.svn.wordpress.org/trunk@45397
git-svn-id: http://core.svn.wordpress.org/trunk@45208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:22:51 +00:00
e4ce9663a3
I18N: Merge two similar "you may need to press the Esc key twice" strings.
...
Props ramiy, tmatsuur, hareesh-pillai.
Fixes #47036 .
Built from https://develop.svn.wordpress.org/trunk@45396
git-svn-id: http://core.svn.wordpress.org/trunk@45207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:18:53 +00:00
44512b0753
I18N: Merge two similar "An unexpected error occurred" strings.
...
Props ramiy.
Fixes #47035 .
Built from https://develop.svn.wordpress.org/trunk@45395
git-svn-id: http://core.svn.wordpress.org/trunk@45206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:14:52 +00:00
a36f5d2295
Docs: Fix typos in DocBlocks and comments in `wp-admin/includes/file.php`.
...
Props mukesh27.
Fixes #47026 .
Built from https://develop.svn.wordpress.org/trunk@45394
git-svn-id: http://core.svn.wordpress.org/trunk@45205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:08:51 +00:00
68fd25ff1a
Docs: Remove unused `@global` reference in `do_blocks()` DocBlock.
...
Props avinapatel.
Fixes #47055 .
Built from https://develop.svn.wordpress.org/trunk@45393
git-svn-id: http://core.svn.wordpress.org/trunk@45204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:05:52 +00:00
7cadbb50bf
Docs: Fix incorrect `@see` notation in `wp_localize_script()` DocBlock.
...
Props coffee2code, shamim51.
Fixes #47104 .
Built from https://develop.svn.wordpress.org/trunk@45392
git-svn-id: http://core.svn.wordpress.org/trunk@45203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:02:51 +00:00
726e77d97e
Networks and Sites: Readjust tabs in `wp-admin/includes/network.php` for (more or less) consistent alignment.
...
See #47062 .
Built from https://develop.svn.wordpress.org/trunk@45391
git-svn-id: http://core.svn.wordpress.org/trunk@45202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 23:35:52 +00:00
139225ad7a
Networks and Sites: Remove extra whitespace in `.htaccess` rules on Network Setup page.
...
Props riddhiehta02 for initial patch, sebastienserre, masterforwordpress.
Fixes #47062 .
Built from https://develop.svn.wordpress.org/trunk@45390
git-svn-id: http://core.svn.wordpress.org/trunk@45201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 23:28:53 +00:00
239a159ad2
Administration: Don't apply italic formatting to code blocks in setting descriptions.
...
Props chetan200891
Fixes #42651
Built from https://develop.svn.wordpress.org/trunk@45389
git-svn-id: http://core.svn.wordpress.org/trunk@45200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 23:14:53 +00:00
75a8adb0eb
Docs: Remove incorrect information about usage of the "from" filters in `wp_mail()`, tidy up formatting.
...
See #47110
Built from https://develop.svn.wordpress.org/trunk@45388
git-svn-id: http://core.svn.wordpress.org/trunk@45199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 22:42:52 +00:00
f2ef36bb2d
I18N: Use a complete translatable string for the "Delete My Site" email subject.
...
Props thrijith
Fixes #46855
Built from https://develop.svn.wordpress.org/trunk@45387
git-svn-id: http://core.svn.wordpress.org/trunk@45198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 22:15:54 +00:00
9e891be893
Embeds: Remove the "Supports HTTPS" column from the whitelisted oEmbed provider list now that all supported providers use HTTPS.
...
See #28507
Built from https://develop.svn.wordpress.org/trunk@45386
git-svn-id: http://core.svn.wordpress.org/trunk@45197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 21:23:53 +00:00
5fe92586c0
Embeds: Use HTTPS for the Hulu oEmbed endpoint, as it redirects to HTTPS now.
...
Fixes #28507
Built from https://develop.svn.wordpress.org/trunk@45385
git-svn-id: http://core.svn.wordpress.org/trunk@45196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 21:20:52 +00:00
e32389fc04
I18N: Capitalize "Privacy Policy Page" heading to merge two similar strings.
...
Props ramiy, garrett-eclipse.
Fixes #47250 .
Built from https://develop.svn.wordpress.org/trunk@45384
git-svn-id: http://core.svn.wordpress.org/trunk@45195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 21:11:52 +00:00
aaa3e181a0
Twenty Nineteen: Correct function name in a `function_exists()` check for `twentynineteen_get_user_avatar_markup()`.
...
Props mukesh27, diego-la-monica.
Fixes #46410 .
Built from https://develop.svn.wordpress.org/trunk@45383
git-svn-id: http://core.svn.wordpress.org/trunk@45194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 01:31:54 +00:00
a3c363f8c2
I18N: Make punctuation in some `wp-admin` strings more consistent.
...
Props pedromendonca.
Fixes #47358 .
Built from https://develop.svn.wordpress.org/trunk@45382
git-svn-id: http://core.svn.wordpress.org/trunk@45193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 01:12:53 +00:00
b29ef22665
Media: Correct closing `</label>` tags in `#tmpl-audio-details` and `#tmpl-video-details` after [42444].
...
Props TravisSeitler.
Fixes #47355 .
Built from https://develop.svn.wordpress.org/trunk@45381
git-svn-id: http://core.svn.wordpress.org/trunk@45192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 00:49:53 +00:00
0cc6547e43
Docs: Adjust `get_post_modified_time` filter DocBlock for consistency with `get_post_time`.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@45380
git-svn-id: http://core.svn.wordpress.org/trunk@45191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 00:41:51 +00:00
3c16bdc538
Date/Time: Return early from `the_weekday()` and `the_weekday_date()` if we're not in the loop.
...
Restore `$previousweekday` global usage in `the_weekday_date()`, so it could still be used simultaneously with `the_date()`.
Partially reverts [45378].
See #47354 .
Built from https://develop.svn.wordpress.org/trunk@45379
git-svn-id: http://core.svn.wordpress.org/trunk@45190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 00:38:52 +00:00
ed08643734
Date/Time: Bring some consistency to `the_date()` and `the_weekday_date()`:
...
* Make `the_date()` always apply the the filter and return a value.
* Use `is_new_day()` in `the_weekday_date()`.
* Add a unit test for `the_weekday_date()`.
Fixes #47354 .
Built from https://develop.svn.wordpress.org/trunk@45378
git-svn-id: http://core.svn.wordpress.org/trunk@45189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-22 21:58:50 +00:00
0b66be9cd7
Docs: Improve documentation for `the_date()` and `the_weekday_date()`.
...
Correct type for `$currentday` and `$previousday` globals.
See #47354 , #47110 .
Built from https://develop.svn.wordpress.org/trunk@45377
git-svn-id: http://core.svn.wordpress.org/trunk@45188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-22 21:48:52 +00:00
74c0d658b4
Accessibility: Improve the media views upload Dismiss Errors button.
...
- makes the Dismiss Errors button visible in the media views inline uploader
- avoids a focus loss when activating the Dismiss Errors button
See the related GitHub issue from the WPCampus accessibility audit https://github.com/WordPress/gutenberg/issues/15354
Fixes #47113 .
Built from https://develop.svn.wordpress.org/trunk@45376
git-svn-id: http://core.svn.wordpress.org/trunk@45187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-22 19:33:53 +00:00
9785381a8c
Date/Time: Use strict comparison in `is_new_day()`, add a unit test.
...
Props pbearne.
Fixes #46627 .
Built from https://develop.svn.wordpress.org/trunk@45375
git-svn-id: http://core.svn.wordpress.org/trunk@45186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-22 17:53:52 +00:00
03148046b5
General: Add missing unit tests for `wp_array_slice_assoc()`.
...
Props pbearne, desrosj.
Fixes #46638 .
Built from https://develop.svn.wordpress.org/trunk@45371
git-svn-id: http://core.svn.wordpress.org/trunk@45182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-21 14:49:05 +00:00
ee92fc277c
Feeds: Ensure a feed’s `<lastBuildDate>` has the correct date.
...
The maximum modified time for a is currently being determined after an arbitrary date format is applied. Because the string sort in `max()` is being used to return the highest (most recent) modified value, the incorrect date is sometimes returned. This was introduced in [45247].
Props onlanka, Rarsr, mukesh27.
Fixes #47304 .
Built from https://develop.svn.wordpress.org/trunk@45367
git-svn-id: http://core.svn.wordpress.org/trunk@45178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-20 14:43:02 +00:00
3b926e0b47
Upgrade/Install: As a follow-up to [45357], when linking to Update PHP support page in error messages, check if `wp_get_update_php_url()` and `wp_get_update_php_annotation()` exist.
...
`wp-admin/includes/update-core.php` runs in the context of the previous WordPress version. Any calls to newly introduced functions there need to be checked via `function_exists()`.
Reviewed by desrosj, earnjam, SergeyBiryukov.
Props dd32, imath.
Fixes #47323 .
Built from https://develop.svn.wordpress.org/trunk@45365
git-svn-id: http://core.svn.wordpress.org/trunk@45176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-20 14:29:55 +00:00
460e256026
KSES: Add `flex` and related long form properties to safe CSS.
...
Allow `flex`, `flex-grow`, `flex-shrink` and `flex-basis` to be used in inline CSS. As of WordPress 5.3 the block editor is expected to use `flex-basis` inline to set the width in the column block.
Props aduth.
Fixes #47281 .
See #37248 .
Built from https://develop.svn.wordpress.org/trunk@45363
git-svn-id: http://core.svn.wordpress.org/trunk@45174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-18 04:34:52 +00:00
f29eba6662
Taxonomy: In `wp_insert_term()`, handle an error if writing to the `term_taxonomy` table fails.
...
This complements the check for successful writing to the `terms` table, added in [7430].
Props mbabker.
Fixes #47313 .
Built from https://develop.svn.wordpress.org/trunk@45362
git-svn-id: http://core.svn.wordpress.org/trunk@45173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 22:28:51 +00:00
f72cb6dc83
Upgrade/Install: Improve error messages displayed when WordPress update fails due to an incompatible PHP version by linking to the Update PHP support page.
...
Additionally, fix a regression in [44451] where the error message in `wp-admin/upgrade.php` was prepared, but never displayed.
Props afragen, netweb, hareesh-pillai, SergeyBiryukov.
Fixes #46937 .
Built from https://develop.svn.wordpress.org/trunk@45357
git-svn-id: http://core.svn.wordpress.org/trunk@45168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 18:11:51 +00:00
ea8078f73c
Media: Fix deletion of files on Windows.
...
`wp_delete_file_from_directory()` should always normalize file paths before comparing.
Props tonybogdanov, SergeyBiryukov.
Fixes #47185 .
Built from https://develop.svn.wordpress.org/trunk@45352
git-svn-id: http://core.svn.wordpress.org/trunk@45163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 13:30:02 +00:00
550bc5cad2
Build/Test Tools: Use a non-zero exit code in `wp_check_php_mysql_versions()` when minimum PHP or MySQL requirements are not met.
...
This allows automated scripts and test suites to interpret the result correctly.
Props jrf, spacedmonkey.
Fixes #47169 .
Built from https://develop.svn.wordpress.org/trunk@45350
git-svn-id: http://core.svn.wordpress.org/trunk@45161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 12:34:52 +00:00
c1f6c6877c
Formatting: Adjust `wp_targeted_link_rel()` to ensure JSON format is preserved and correct quotes are used when adding the missing `rel` attribute.
...
Props birgire, TobiasBg, fierevere, audrasjb, SergeyBiryukov.
Fixes #46316 , #47244 .
Built from https://develop.svn.wordpress.org/trunk@45348
git-svn-id: http://core.svn.wordpress.org/trunk@45159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 12:10:02 +00:00
e68fe165ae
Site Health: In PHP modules test description, move the space before the screen reader text out from the translatable string.
...
Props ocean90, tobifjellner.
Fixes #47161 .
Built from https://develop.svn.wordpress.org/trunk@45346
git-svn-id: http://core.svn.wordpress.org/trunk@45157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 11:50:58 +00:00
1d730f20e5
Upgrade/Install: Don't run signature verify on slow 32-bit systems.
...
The sodium_compat library can be very slow for certain operations on 32-bit architectures, which can lead to web server timeouts while attempting to verify an update. This adds a runtime speed check to skip signature verification on systems that would otherwise time out. Includes simple unit tests.
Props dd32, paragoninitiativeenterprises.
See #47186 .
Built from https://develop.svn.wordpress.org/trunk@45345
git-svn-id: http://core.svn.wordpress.org/trunk@45156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 11:06:53 +00:00
b9782736b6
Upgrade/Install: Update sodium_compat to v1.10.0.
...
This adds a runtime_speed_test() method for estimating if the 32-bit implementation is fast enough for expensive computations.
Props paragoninitiativeenterprises.
See #47186 .
Built from https://develop.svn.wordpress.org/trunk@45344
git-svn-id: http://core.svn.wordpress.org/trunk@45155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 10:58:51 +00:00
80aee4ae87
jQuery: bring jquery.js back into the WordPress SVN repo and backport the patch from 3.4.0.
...
Props MikeNGarrett, peterwilsoncc, azaozz.
Fixes #47020 for trunk.
Built from https://develop.svn.wordpress.org/trunk@45342
git-svn-id: http://core.svn.wordpress.org/trunk@45153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 04:25:54 +00:00
e06afa8a80
Accessibility: In back-compat code added for `get_search_form()` in [44956], when checking the (previously boolean) `$args` value, account for non-strict comparison.
...
Props dkarfa, sachyya-sachet.
Fixes #47177 . See #42057 .
Built from https://develop.svn.wordpress.org/trunk@45340
git-svn-id: http://core.svn.wordpress.org/trunk@45151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 02:22:53 +00:00
00255ae0be
Help/About: Restore placeholder for WordPress version in tagline on About, Credits, and Freedoms pages to include minor versions.
...
Props desrosj, mukesh27.
Fixes #46408 .
Built from https://develop.svn.wordpress.org/trunk@45338
git-svn-id: http://core.svn.wordpress.org/trunk@45149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 01:08:53 +00:00
cbad1109f4
Site Health: Use correct singular string for plugin and theme version tests.
...
Props edocev, Presskopp.
Fixes #47264 .
Built from https://develop.svn.wordpress.org/trunk@45336
git-svn-id: http://core.svn.wordpress.org/trunk@45147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 01:00:54 +00:00
4236a3522d
I18N: Avoid using placeholders for link start and end tags in alt text description strings added in [45158].
...
Use an established pattern of moving additional link attributes out of the translatable string.
Props dimadin.
Fixes #47159 .
Built from https://develop.svn.wordpress.org/trunk@45334
git-svn-id: http://core.svn.wordpress.org/trunk@45145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 00:53:54 +00:00
a9fc042377
Site Health: In PHP modules test, ensure the description is translated as a whole sentence, not as separate string parts.
...
Props dimadin, SergeyBiryukov.
Fixes #47161 .
Built from https://develop.svn.wordpress.org/trunk@45331
git-svn-id: http://core.svn.wordpress.org/trunk@45142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 00:07:54 +00:00
9c1a666249
Site Health: In HTTP requests test, when checking whether the `WP_HTTP_BLOCK_EXTERNAL` constant is defined, check its value as well.
...
Props chesio.
Fixes #47297 .
Built from https://develop.svn.wordpress.org/trunk@45328
git-svn-id: http://core.svn.wordpress.org/trunk@45139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 22:08:54 +00:00
c6da25fa9a
Privacy: Prevent email field for personal data requests from overflowing.
...
Props anischarolia, ianbelanger, afercia.
Fixes #46961 .
Built from https://develop.svn.wordpress.org/trunk@45326
git-svn-id: http://core.svn.wordpress.org/trunk@45137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 20:45:54 +00:00
1ef254a465
Menus: Fix alignment of menu actions on mobile.
...
In [41197], changes were made to improve the responsive view for the Menu Name field and Save buttons. This caused the Delete Menu button to be misaligned.
Props ianbelanger, audrasjb, afercia, mukesh27.
Fixes #47173 .
Built from https://develop.svn.wordpress.org/trunk@45324
git-svn-id: http://core.svn.wordpress.org/trunk@45135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 19:05:53 +00:00
ca7c9a8288
Site Health: Improve alignment and spacing for section headers.
...
This changes the CSS for Site Health headers to use flexbox, which helps ensure the text is vertically aligned center and consistently spaced in both the Status and Info tabs. It also fixes an issue where the loading spinner GIF was cut off on smaller screens (originally reported in #47203 .
Props Presskopp, odminstudios, kjellr, afercia, desrosj, hedgefield, ianbelanger, xavortm.
Fixes #47063 .
Built from https://develop.svn.wordpress.org/trunk@45322
git-svn-id: http://core.svn.wordpress.org/trunk@45133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 18:30:53 +00:00
913516fe5c
Build/Test Tools: Upgrade `node-sass` to 4.12.0.
...
`node-sass` 4.12 adds support for Node 12. This will prevent errors for anyone running Node 12 locally instead of the LTS version (currently 10.15.3).
Props desrosj, aduth, netweb.
Fixes #47257 .
Built from https://develop.svn.wordpress.org/trunk@45321
git-svn-id: http://core.svn.wordpress.org/trunk@45132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 18:15:55 +00:00
3c44f9e15a
Block Editor: Upgrade WordPress packages to the latest versions.
...
Updated packages:
- @wordpress/annotations@1.2.3
- @wordpress/block-editor@2.0.2
- @wordpress/block-library@2.4.5
- @wordpress/blocks@6.2.5
- @wordpress/components@7.3.2
- @wordpress/dom@2.2.5
- @wordpress/e2e-tests@1.1.5
- @wordpress/edit-post@3.3.5
- @wordpress/editor@9.2.5
- @wordpress/format-library@1.4.5
- @wordpress/list-reusable-blocks@1.3.5
- @wordpress/nux@3.2.5
- @wordpress/rich-text@3.2.3
Props: youknowriad, gwwar, iseulde, tfrommen, gziolo.
Fixes #47284 .
Built from https://develop.svn.wordpress.org/trunk@45319
git-svn-id: http://core.svn.wordpress.org/trunk@45130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 18:08:00 +00:00
0b4a421b50
Build tools: fix generating `*-rtl.css` files in `wp-includes/css` after `grunt --dev` was used.
...
Fixes #47078 .
Built from https://develop.svn.wordpress.org/trunk@45317
git-svn-id: http://core.svn.wordpress.org/trunk@45128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 02:25:52 +00:00
762b49653a
Update TinyMCE to 4.9.4. Changelog: https://github.com/tinymce/tinymce/blob/4.x/changelog.txt .
...
Fixes #47229 for trunk.
Built from https://develop.svn.wordpress.org/trunk@45316
git-svn-id: http://core.svn.wordpress.org/trunk@45127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 23:45:52 +00:00
ac095904da
Bootstrap/Load: Prevent PHP errors when a drop-in triggers fatal error protection.
...
When a drop-in (such as `advanced-cache.php`) contains a PHP error, additional PHP errors are caused when displaying the error protection screen because `load_default_textdomain()` and `WP_Error` are not yet available.
Though recovery mode is not supported for `mu-plugins` and drop-ins, fatal error protection is. This change ensures the error screen is displayed when a fatal error is encountered within a drop-in and not a white screen.
Props TimothyBlynJacobs, spacedmonkey, daxelrod.
Fixes #47265 .
Built from https://develop.svn.wordpress.org/trunk@45311
git-svn-id: http://core.svn.wordpress.org/trunk@45122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 18:19:51 +00:00
5173099abc
Administration: Remove duplicate `font-face` declaration in Dashicons CSS.
...
This was causing console warnings in some browsers.
Props aduth, joen, afercia, timph, ianbelanger.
Fixes #47183 .
Built from https://develop.svn.wordpress.org/trunk@45310
git-svn-id: http://core.svn.wordpress.org/trunk@45121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 16:08:57 +00:00
f48f926077
Site Health: Improve vertical alignment of icons in test result descriptions.
...
This change removes redundant CSS properties for different health check statuses in favor of utilizing the `.dashicons` class already in Core to define them more consistently. This also fixes the vertical alignment issues.
Props chetan200891, Clorith, desrosj.
Fixes #46940 .
Built from https://develop.svn.wordpress.org/trunk@45309
git-svn-id: http://core.svn.wordpress.org/trunk@45120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 14:26:07 +00:00
7d04482650
Site Health: Link to the correct plugin update screen in multisite installs.
...
Props Clorith, sebastienserre, jeremyfelt, desrosj.
Fixes #47189 .
Built from https://develop.svn.wordpress.org/trunk@45308
git-svn-id: http://core.svn.wordpress.org/trunk@45119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 14:13:05 +00:00
1a24aaa380
Docs: Add a `@see` reference to `WP_REST_Revisions_Controller` in `WP_REST_Autosaves_Controller` DocBlock.
...
Props chintan1896.
Fixes #47232 .
Built from https://develop.svn.wordpress.org/trunk@45307
git-svn-id: http://core.svn.wordpress.org/trunk@45116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-14 23:53:57 +00:00
afb68ae41d
Docs: Add `@see` references to `WP_Widget_Media` in media widget DocBlocks.
...
Props iamjaydip.
Fixes #47231 .
Built from https://develop.svn.wordpress.org/trunk@45306
git-svn-id: http://core.svn.wordpress.org/trunk@45115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-14 20:23:06 +00:00
cbd6fd7a30
Docs: Add missing `@see` tag to `WP_REST_Post_Search_Handler` DocBlock.
...
Props vishitshah.
Fixes #47230 .
Built from https://develop.svn.wordpress.org/trunk@45305
git-svn-id: http://core.svn.wordpress.org/trunk@45114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-14 15:00:07 +00:00
6860a1d759
Docs: Convert `@see` reference in `WP_REST_Request` DocBlock to `@link`, to avoid a broken link in Developer Reference.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@45304
git-svn-id: http://core.svn.wordpress.org/trunk@45113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-14 14:56:08 +00:00
b36a31ae14
Docs: Fix typo in `wp_mail()` description.
...
Props seedsca.
Fixes #47208 .
Built from https://develop.svn.wordpress.org/trunk@45302
git-svn-id: http://core.svn.wordpress.org/trunk@45111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-10 09:53:54 +00:00
1b3b04f354
Accessibility: Improve the "skip links" position for medium and small screens.
...
Fixes #47065 .
Built from https://develop.svn.wordpress.org/trunk@45301
git-svn-id: http://core.svn.wordpress.org/trunk@45110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 21:12:02 +00:00
9cc696fbce
Accessibility: Add `aria-current` to the links in the `<nav>` elements introduced in [44905].
...
Also fixes a few translators comments and coding standards.
Props audrasjb.
Fixes #47106 .
Built from https://develop.svn.wordpress.org/trunk@45300
git-svn-id: http://core.svn.wordpress.org/trunk@45109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 20:58:54 +00:00
dfd4641dc3
Twenty Nineteen: Fix Docblock spelling error.
...
Props mukesh27.
Fixes #47129 .
Built from https://develop.svn.wordpress.org/trunk@45299
git-svn-id: http://core.svn.wordpress.org/trunk@45108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 20:08:55 +00:00
d0f46bf73c
I18N: Combine similar strings with minor differences.
...
Props dimadin.
Fixes #47158 .
Built from https://develop.svn.wordpress.org/trunk@45298
git-svn-id: http://core.svn.wordpress.org/trunk@45107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 19:48:53 +00:00
770323b4de
Twenty Nineteen: Remove duplicate code block.
...
Introduced in [44305].
Props mukesh27, afercia.
Fixes #46455 .
Built from https://develop.svn.wordpress.org/trunk@45297
git-svn-id: http://core.svn.wordpress.org/trunk@45106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 18:04:55 +00:00
71f9170c08
Administration: Prevent cards on the Tools page from overflowing on small screens.
...
Props anischarolia, mukesh27.
Fixes #46972 .
Built from https://develop.svn.wordpress.org/trunk@45296
git-svn-id: http://core.svn.wordpress.org/trunk@45105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 14:56:56 +00:00
bfcd57d327
Help/About: Update the 5.2 tagline on Freedoms and Credits.
...
Props ocean90.
See #46901 .
Built from https://develop.svn.wordpress.org/trunk@45292
git-svn-id: http://core.svn.wordpress.org/trunk@45101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-07 20:00:54 +00:00
678e940ee7
Default Themes: Bump the version numbers and release dates.
...
Update the theme versions and release dates for the default themes, in time for WordPress 5.2.
The POT files for Twenty Eleven and Twenty Ten have also been updated.
Fixes #47172 .
Built from https://develop.svn.wordpress.org/trunk@45289
git-svn-id: http://core.svn.wordpress.org/trunk@45098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-07 18:49:53 +00:00
c4062c75a7
Help/About: Final 5.2 about page updates.
...
Use final image URLs and fix a bug in IE11 where images were being cut off.
Props afercia, SergeyBiryukov, ianbelanger, desrosj, audrasjb.
See #46901 .
Built from https://develop.svn.wordpress.org/trunk@45287
git-svn-id: http://core.svn.wordpress.org/trunk@45096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-07 17:19:55 +00:00
e464f03549
Fix `setup_postdata()` to set the (inside the loop) globals before `the_post` action is fired. Follow-up from #42814 and [44941].
...
Props david.binda, spacedmonkey, boonebgorges, birgire, jorbin, azaozz.
Fixes #47114 for trunk.
Built from https://develop.svn.wordpress.org/trunk@45285
git-svn-id: http://core.svn.wordpress.org/trunk@45094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-04 21:00:52 +00:00
3d84726ae8
Editor: Correct `since` annotation for the `excerpt_allowed_blocks` filter.
...
Props mukesh27, rabmalin.
Fixes #47079 .
Built from https://develop.svn.wordpress.org/trunk@45284
git-svn-id: http://core.svn.wordpress.org/trunk@45093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-03 16:54:52 +00:00
b431b2ff62
Update the `package-lock.json` file to 5.3.0.
...
Built from https://develop.svn.wordpress.org/trunk@45283
git-svn-id: http://core.svn.wordpress.org/trunk@45092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-03 16:52:52 +00:00
d0364fc65a
Trunk is now 5.3 alpha
...
Built from https://develop.svn.wordpress.org/trunk@45282
git-svn-id: http://core.svn.wordpress.org/trunk@45091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 16:28:55 +00:00
a1f4b046d7
Post WordPress 5.2 RC2 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@45280
git-svn-id: http://core.svn.wordpress.org/trunk@45089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 16:13:54 +00:00
0aa044f0e1
WordPress 5.2 RC2.
...
Built from https://develop.svn.wordpress.org/trunk@45279
git-svn-id: http://core.svn.wordpress.org/trunk@45088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 16:04:51 +00:00
3360974ad2
Help/About: Polish the About page for 5.2.
...
- The About page now uses a CSS grid to layout its design, making the page’s structure more obvious and hopefully easier for contributors in the future.
- Removes some code that is no longer used (such as videos, mejs elements, etc.).
- Update images.
- Unnecessary HTML is removed from a string on the page. This was a regression.
- Only users with the correct capability should be instructed to check their site status.
- Fixes the placement of commas.
Reviewed by melchoyce, afercia, jeremyfelt, and desrosj.
Props ryelle, melchoyce, cathibosco1, man4toman, SergeyBiryukov, afercia, ramiy, kjellr, tellyworth, earnjam, andreamiddleton, marybaum.
See #46901 .
Built from https://develop.svn.wordpress.org/trunk@45278
git-svn-id: http://core.svn.wordpress.org/trunk@45087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 15:44:53 +00:00
d48b709071
Bootstrap/Load: Ensure recovery link email and related notices are properly translated.
...
When recovery mode is triggered before the site’s locale has been initialized, the message displayed to the user and the email sent to the site administrator with the recovery mode link are always rendered in `en_US`. This change ensures the site’s locale is used even when an error happens early in the loading process.
Reviewed by swissspidy, SergeyBiryukov, and desrosj.
Props wolly, TimothyBlynJacobs, fierevere.
Fixes #47093 .
Built from https://develop.svn.wordpress.org/trunk@45277
git-svn-id: http://core.svn.wordpress.org/trunk@45086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 10:53:52 +00:00
d53659ed71
Help/About: Fix tab display issues.
...
This change restores About page tab heights and fixes bugs with the tab bottom border caused by [44905] and [45243].
Reviewed by SergeyBiryukov and desrosj.
Props ixkaito, ianbelanger, afercia, SergeyBiryukov.
See #46901 .
Fixes #47075 .
Built from https://develop.svn.wordpress.org/trunk@45276
git-svn-id: http://core.svn.wordpress.org/trunk@45085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 10:37:51 +00:00
6ac1d4ec1a
Site Health: Disable recommendations that could be problematic on multisite installs.
...
When viewing Site Health for a multisite install, there are a few recommendations that are not appropriate and could have negative implications for other sites on the install if the administrator follows the advice provided.
For example, Site Health recommends that inactive plugins and themes for a site should be removed. On a single site install, this is a great recommendation. However, on a multisite install, inactive plugins and themes for one site should not be removed because they could be active for other sites on the network.
This change also disables the `test_wp_version_check_attached()` test for multisite. This test checks for the presence of the `wp_version_check()` function on the `wp_version_check` hook, which is not present for every site on multisite.
Reviewed by jeremyfelt and desrosj.
Props iandunn, Clorith, azaozz, jeremyfelt.
Fixes #47084 .
Built from https://develop.svn.wordpress.org/trunk@45275
git-svn-id: http://core.svn.wordpress.org/trunk@45084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-01 18:08:53 +00:00
e4a0fd4c01
Admin: Add some additional clarity to some about page links
...
It's important for links to have enough information in them in order to be clearly actionable. Destination and purpose should be clear. For example, `debug` isn't nearly as useful as `learn how to debug issues`.
This was signed off on by chanthaboune and jorbin.
Props afercia.
See: #46901 .
Built from https://develop.svn.wordpress.org/trunk@45274
git-svn-id: http://core.svn.wordpress.org/trunk@45083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-30 17:31:55 +00:00
0344202063
Post WordPress 5.2 RC1 version bump
...
Built from https://develop.svn.wordpress.org/trunk@45273
git-svn-id: http://core.svn.wordpress.org/trunk@45082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-26 01:23:53 +00:00
754dca460c
WordPress 5.2 RC1
...
Built from https://develop.svn.wordpress.org/trunk@45272
git-svn-id: http://core.svn.wordpress.org/trunk@45081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-26 01:15:52 +00:00
d86524f09d
Admin: Add the text for the WordPress 5.2 About page.
...
This changes includes placeholder images for now, they'll be replaced by the final images before final release.
Props chanthaboune, melchoyce, karmatosed, pento, marybaum, birgire, earnjam, andreamiddleton.
See #46901 .
Built from https://develop.svn.wordpress.org/trunk@45271
git-svn-id: http://core.svn.wordpress.org/trunk@45080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-26 00:57:53 +00:00
0bbfe42ab1
Media: Revert [44947].
...
`get_available_post_mime_types()` uses a query that's extremely slow on sites with lots of posts. The original fix can be revisited after those performance issues are tackled.
See #43658 .
Built from https://develop.svn.wordpress.org/trunk@45270
git-svn-id: http://core.svn.wordpress.org/trunk@45079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-26 00:44:52 +00:00
700f891c36
Accessibility: Remove redundant title attribute from the "Exit Recovery Mode" link.
...
Fixes #47045 .
Built from https://develop.svn.wordpress.org/trunk@45269
git-svn-id: http://core.svn.wordpress.org/trunk@45078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-25 16:04:53 +00:00
3b5307339d
Bootstrap/Load: Tweak the recovery mode email text and behaviour.
...
- Change the recovery mode link expiry to 1 day.
- Improve the email text.
- Add a new `recovery_email_support_info` filter, for hosts to be able to customise their support contact information.
Props pento, chanthaboune, michelleweber, matt.
Fixes #46898 .
Built from https://develop.svn.wordpress.org/trunk@45268
git-svn-id: http://core.svn.wordpress.org/trunk@45077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-25 00:47:52 +00:00
0b6f00fde2
REST API: Always urlencode_deep() query args in get_items methods.
...
Passing all received query arguments through urlencode_deep ensures that the full set of query arguments are encoded in the same way.
Props dmsnell.
Fixes #46199
Built from https://develop.svn.wordpress.org/trunk@45267
git-svn-id: http://core.svn.wordpress.org/trunk@45076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-25 00:08:52 +00:00
8b333f8c20
Docs: Use 3-digit, x.x.x style semantic versioning for `@since 5.2.0` entries in `wp-admin/includes/file.php`.
...
See #46543 .
Built from https://develop.svn.wordpress.org/trunk@45266
git-svn-id: http://core.svn.wordpress.org/trunk@45075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-24 23:36:51 +00:00
655c21bbea
Fix parsing of inner blocks when auto-generating an excerpt. Helps to prevent cases where dynamic inner blocks may cause an infinite loop if trying to auto-generate an excerpt.
...
Props desrosj, pento, gziolo, azaozz.
Fixes #46133 .
Built from https://develop.svn.wordpress.org/trunk@45265
git-svn-id: http://core.svn.wordpress.org/trunk@45074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-24 21:39:53 +00:00
ac7877ce6f
Twenty Nineteen: Fix padding discrepancies in responsive styles for Column block.
...
Props kjellr, dianeco.
Fixes #46643 , #46999 .
Built from https://develop.svn.wordpress.org/trunk@45264
git-svn-id: http://core.svn.wordpress.org/trunk@45073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-24 18:37:52 +00:00
54c7c76836
Bootstrap/Load: Modify the fatal error template to indicate to the user that they can check the admin email address for further instructions.
...
Props spacedmonkey, TimothyBlynJacobs.
Fixes #46950 .
Built from https://develop.svn.wordpress.org/trunk@45263
git-svn-id: http://core.svn.wordpress.org/trunk@45072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-24 18:14:53 +00:00
ed802428e3
Upgrade/install: fix verification bugs and scale back signature checks.
...
This fixes several bugs in the signature verification code:
Disables signature checks on certain incompatible PHP versions that cause math errors when opcache is enabled;
Prevents a spurious URL and subsequent error when downloading a zip file with query arguments;
Prevents errors triggered by third-party upgrade scripts as per #46615 ;
Disables signature tests for Plugins, Themes, and Translations, leaving only core updates.
At the 5.2 release the API servers will only provide signatures for core update packages, which is why messages are suppressed for plugins and other package types. Signatures for those other items will become available later.
Props dd32.
See #39309 , #46615
Built from https://develop.svn.wordpress.org/trunk@45262
git-svn-id: http://core.svn.wordpress.org/trunk@45071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-24 07:44:51 +00:00
df438d90a0
Remove the `core/more` block delimiters when splitting post_content on the `<!--more-->` tag.
...
Fixes:
- Parsing of blocks in the second half of post_content.
- Outputting malformed HTML when `the_content( null, true )` or `<!--noteaser-->` is used.
Props lukecarbis, garrett-eclipse, birgire.
Fixes #46471 .
Built from https://develop.svn.wordpress.org/trunk@45261
git-svn-id: http://core.svn.wordpress.org/trunk@45070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-24 05:40:52 +00:00
0da8c2265f
Site Health: Fix count of inactive themes and the recommendation to remove them when the default theme is active or is a parent of the active child theme.
...
Props sudhiryadav, ianbelanger, mukesh27, azaozz.
Fixes #46900 .
Built from https://develop.svn.wordpress.org/trunk@45260
git-svn-id: http://core.svn.wordpress.org/trunk@45069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 21:37:53 +00:00
2548263bac
Site Health: Allow some HTML (inline tags only) in the section descriptions. Add some more docs about expected formatting of the gathered data.
...
Props kraftbj, jeherve, mukesh27, audrasjb, azaozz.
Fixes #46878 .
Built from https://develop.svn.wordpress.org/trunk@45259
git-svn-id: http://core.svn.wordpress.org/trunk@45068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 21:05:52 +00:00
c7f2bda6f2
Twenty Nineteen: Prevent too-long strings from causing horizontal scrolling.
...
Add hyphen and word-wrap styles to the site title, comments, and widget areas to break too-long strings and prevent horizontal scrolling.
Props ianbelanger, dswebsme, mukesh27.
Fixes #46704 .
Built from https://develop.svn.wordpress.org/trunk@45258
git-svn-id: http://core.svn.wordpress.org/trunk@45067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 19:48:53 +00:00
9950f8b71e
Twenty Seventeen: Prevent too-long strings from causing horizontal scrolling.
...
Add a `max-width` to the site title, so too-long strings will wrap instead of causing horizontal scrolling.
Props ianbelanger, dswebsme.
Fixes #46703 .
Built from https://develop.svn.wordpress.org/trunk@45257
git-svn-id: http://core.svn.wordpress.org/trunk@45066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 16:44:52 +00:00
18ccaf962e
Bundled Theme: add a `wp_body_open` shim for older WordPress versions.
...
WordPress 5.2 adds the `wp_body_open()` function, and the default themes make use of it. This patch adds a shim for `wp_body_open` to bundled themes so this function will also work in older versions of WordPress.
Props lgedeon, johnbillion, timph, ramiy, pento.
Fixes #46679 .
Built from https://develop.svn.wordpress.org/trunk@45256
git-svn-id: http://core.svn.wordpress.org/trunk@45065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 13:04:56 +00:00
0feb55f633
Editor: Update packages to apply bugfixes from Gutenberg 5.5.
...
- @wordpress/block-editor@2.0.1
- @wordpress/block-library@2.4.4
- @wordpress/blocks@6.2.4
- @wordpress/components@7.3.1
- @wordpress/dom@2.2.4
- @wordpress/e2e-tests@1.1.4
- @wordpress/edit-post@3.3.4
- @wordpress/editor@9.2.4
- @wordpress/format-library@1.4.4
- @wordpress/list-reusable-blocks@1.3.4
- @wordpress/nux@3.2.4
Props iseulde, kjellr, aduth, get_dave, talldanwp, jorgefilipecosta, afercia, nosolosw, jasmussen, netweb .
See https://github.com/WordPress/gutenberg/pull/14987 .
See https://github.com/WordPress/gutenberg/pull/15020 .
Fixes #46951 .
Built from https://develop.svn.wordpress.org/trunk@45255
git-svn-id: http://core.svn.wordpress.org/trunk@45064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-22 12:40:04 +00:00
355d5f9bb7
Docs: Correct `@param` type for `$deprecated` and `$plugin_rel_path` arguments of `load_plugin_textdomain()`.
...
Props sudar.
Fixes #43304 .
Built from https://develop.svn.wordpress.org/trunk@45254
git-svn-id: http://core.svn.wordpress.org/trunk@45063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-19 14:21:53 +00:00
d5c77c833a
Docs: Add missing `@since` tag for `WP_Recovery_Mode_Cookie_Service::parse_cookie()`.
...
Props mukesh27.
Fixes #46993 .
Built from https://develop.svn.wordpress.org/trunk@45253
git-svn-id: http://core.svn.wordpress.org/trunk@45062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-19 14:00:51 +00:00
bd9421104a
Networks and Sites: Use correct escaping function for classes added via ` ms_user_list_site_class` filter.
...
Props david.binda.
Fixes #46990 . See #41146 .
Built from https://develop.svn.wordpress.org/trunk@45252
git-svn-id: http://core.svn.wordpress.org/trunk@45061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-19 13:51:51 +00:00
c9efbc89be
Docs: Correct `@return` description for `get_privacy_policy_template()`.
...
Props tmatsuur.
Fixes #46989 . See #44005 .
Built from https://develop.svn.wordpress.org/trunk@45251
git-svn-id: http://core.svn.wordpress.org/trunk@45060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-19 13:46:51 +00:00
8fdb4c2b0c
Bundled Themes: Update `readme.txt` files to pass Theme Review guidelines.
...
Props rabmalin.
Fixes #45871 .
Built from https://develop.svn.wordpress.org/trunk@45250
git-svn-id: http://core.svn.wordpress.org/trunk@45059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-19 13:41:54 +00:00
643ec358a4
Docs: Correct `@return` description for `get_dirsize()`.
...
Props wpboss, tmatsuur.
Fixes #46987 .
Built from https://develop.svn.wordpress.org/trunk@45249
git-svn-id: http://core.svn.wordpress.org/trunk@45058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-19 13:39:52 +00:00
22d8c0af3c
Accessibility: Improve the "Alt text" description styles for small screens.
...
Amends [44900].
See #41612 .
Built from https://develop.svn.wordpress.org/trunk@45248
git-svn-id: http://core.svn.wordpress.org/trunk@45057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 21:43:52 +00:00
b287642342
Feeds: improve structure and naming of feed build date helper function.
...
Simplify overall code structure by passing the required format to the helper function.
Clarify functionality by renaming `get_last_build_date` to `get_feed_build_date`.
Props pento, spacedmonkey.
Fixes #4575 .
Built from https://develop.svn.wordpress.org/trunk@45247
git-svn-id: http://core.svn.wordpress.org/trunk@45056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 17:08:52 +00:00
2d58638ba0
Site Health: Fix debug data with nested fields for copying.
...
* Use `$debug_data` instead of `$field['value']` to retrieve the debug data.
* Rename inner variables to avoid overriding the output variable.
Props Clorith, ocean90.
See #46573 .
Built from https://develop.svn.wordpress.org/trunk@45246
git-svn-id: http://core.svn.wordpress.org/trunk@45055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 16:26:51 +00:00
3e6183c69c
Site Health: Provide context for tab headings to be able to distinguish them from existing strings.
...
See #46573 .
Built from https://develop.svn.wordpress.org/trunk@45245
git-svn-id: http://core.svn.wordpress.org/trunk@45054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 16:06:51 +00:00
bfc2be39e6
Site Health: Enable JavaScript translations for the `site-health` script.
...
See #46683 .
Built from https://develop.svn.wordpress.org/trunk@45244
git-svn-id: http://core.svn.wordpress.org/trunk@45053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 15:41:51 +00:00
6fcd281707
CSS: Remove the units from `line-height` properties in `common.css`.
...
Props ianbelanger, talldanwp.
Fixes #46493 .
Built from https://develop.svn.wordpress.org/trunk@45243
git-svn-id: http://core.svn.wordpress.org/trunk@45052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 06:02:53 +00:00
4325de4629
KSES: Add `background-position` and `grid-template-columns` as safe CSS properties.
...
Props aduth.
Fixes #46597 .
Built from https://develop.svn.wordpress.org/trunk@45242
git-svn-id: http://core.svn.wordpress.org/trunk@45051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 05:56:51 +00:00
3a0563e853
Site Health info tab: fix replacing the size strings in the copied info.
...
Props xkon.
See #46707 .
Built from https://develop.svn.wordpress.org/trunk@45241
git-svn-id: http://core.svn.wordpress.org/trunk@45050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 04:51:52 +00:00
699f028f21
Emoji: Upgrade Twemoji to 12.0.1.
...
As this point release doesn't modify any images, only adding a few missing ones, we don't need to change the CDN location.
Props earnjam.
Fixes #46805 .
Built from https://develop.svn.wordpress.org/trunk@45240
git-svn-id: http://core.svn.wordpress.org/trunk@45049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 02:11:52 +00:00
9659676fca
Site Health info tab: Remove the "Directories and Sizes" section on Multisite installations. Most of the info shown there doesn't apply for multisite.
...
Props xkon, desrosj, azaozz.
Built from https://develop.svn.wordpress.org/trunk@45239
git-svn-id: http://core.svn.wordpress.org/trunk@45048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 00:34:51 +00:00
2d81c95f73
Bootstrap/Load: Only send the recovery mode email if the error occurs on a protected endpoint.
...
This reduces the potential email noise to places where the fatal error could be interfering with the login and admin experience.
Once the user is in recovery mode, any fatal errors (even if they aren't in a protected endpoint) are handled and the plugin or theme will be paused.
Props TimothyBlynJacobs.
See #46950 .
Built from https://develop.svn.wordpress.org/trunk@45238
git-svn-id: http://core.svn.wordpress.org/trunk@45047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 23:04:53 +00:00
2a5c2a2cce
Site health info tab: replace "Not calculated" with "Loading..." in the "Directories and Sizes" section (that's an existing string and wouldn't cause problems for translators).
...
See #46707 .
Built from https://develop.svn.wordpress.org/trunk@45237
git-svn-id: http://core.svn.wordpress.org/trunk@45046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 21:26:52 +00:00
7ec74901d3
Docs: Add arguments passed by `wp_insert_site()` to `wp_initialize_site()`.
...
Props codemascot.
Fixes #45061 .
Built from https://develop.svn.wordpress.org/trunk@45236
git-svn-id: http://core.svn.wordpress.org/trunk@45045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 20:57:52 +00:00
2e0e63f923
Users: In `wp_list_authors()`, check for author's post count before getting author's metadata.
...
This significantly reduces the number of SQL queries when `wp_list_authors()` is called on a site where the majority of users don't have any posts, e.g. a membership site.
Props billerickson, ianbelanger, dswebsme.
Fixes #45105 .
Built from https://develop.svn.wordpress.org/trunk@45235
git-svn-id: http://core.svn.wordpress.org/trunk@45044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 14:50:50 +00:00
23de32062e
Site Health: Allow any callable added via `site_status_tests` filter to return test results for direct tests.
...
Async tests still need to be a string for the AJAX action.
Props kraftbj.
Fixes #46836 .
Built from https://develop.svn.wordpress.org/trunk@45234
git-svn-id: http://core.svn.wordpress.org/trunk@45043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 14:35:50 +00:00
1be34a234f
Docs: Remove `@global` tag for `$wpdb` from `wp-admin/install.php` and `wp-admin/upgrade.php`.
...
Per the documentation standards, the `@global` tag is meant to list PHP globals used within functions or methods.
The code in question uses the variable in global namespace, but does not explicitly declare it.
Props jayupadhyay01, dswebsme.
Fixes #46602 .
Built from https://develop.svn.wordpress.org/trunk@45233
git-svn-id: http://core.svn.wordpress.org/trunk@45042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 14:07:53 +00:00
d2ccaacedf
Docs: Correct spelling in various comments and DocBlocks, per the conventions in Core Contributor Handbook.
...
Props man4toman, samanehmirrajabi.
Fixes #45857 .
Built from https://develop.svn.wordpress.org/trunk@45232
git-svn-id: http://core.svn.wordpress.org/trunk@45041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 13:26:51 +00:00
e1de58320d
Themes: Standardize on passing `frontpage` and `privacypolicy` as the `$type` parameter to `get_query_template()`.
...
These keys are used in `{$type}_template_hierarchy` and `{$type}_template` filters.
Previously, `front_page` and `privacy_policy` were passed, but `get_query_template()` stripped the underscores before passing the values to the filters.
Props rinatkhaziev, tmatsuur, johnbillion.
Fixes #21213 , #46958 .
Built from https://develop.svn.wordpress.org/trunk@45231
git-svn-id: http://core.svn.wordpress.org/trunk@45040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 12:58:51 +00:00
604769cca5
Site Health: Group `WP_DEBUG`-related constants together.
...
Props tmatsuur.
Fixes #46955 .
Built from https://develop.svn.wordpress.org/trunk@45230
git-svn-id: http://core.svn.wordpress.org/trunk@45039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 12:00:54 +00:00
d89a302503
Site Health: Improve the accordions styles for small screens.
...
Also, changes the hex color values to lowercase.
Props subrataemfluence, man4toman, garrett-eclipse, chetan200891, mukesh27, melchoyce, karmatosed, Clorith.
Fixes #46949 .
Built from https://develop.svn.wordpress.org/trunk@45229
git-svn-id: http://core.svn.wordpress.org/trunk@45038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 11:00:53 +00:00
65ab4e7607
Site Health: Remove title attribute from the directory sizes spinner.
...
Amends [45176].
See #46707 .
Built from https://develop.svn.wordpress.org/trunk@45228
git-svn-id: http://core.svn.wordpress.org/trunk@45037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 10:09:52 +00:00
4ead9880b0
Accessibility: Make the Tags meta box better support Input Method Editor (IME) converters.
...
Also, restores the keyboard interaction behavior prior to [41988] by requesting one single Enter key press to add a tag.
Props ryanshoover, miyauchi.
Fixes #45371 .
Built from https://develop.svn.wordpress.org/trunk@45227
git-svn-id: http://core.svn.wordpress.org/trunk@45036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 07:18:51 +00:00
74e9c3d20d
Docs: Improve documentation for various `WP_Filesystem_Base` methods and extending classes.
...
Props jaydeep-rami, man4toman, SaeedFard, mukesh27, mohadeseghasemi, ebrahimzadeh, juiiee8487, SergeyBiryukov.
Fixes #42227 , #46806 , #46840 . See #46543 .
Built from https://develop.svn.wordpress.org/trunk@45226
git-svn-id: http://core.svn.wordpress.org/trunk@45035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 04:13:51 +00:00
13345d12e9
Administration: Add missing `:before` to two Dashicon class definitions.
...
Introduced in [45040].
Props builtbynorthby.
Fixes #41074 .
Built from https://develop.svn.wordpress.org/trunk@45225
git-svn-id: http://core.svn.wordpress.org/trunk@45034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 02:09:52 +00:00
f807a098b1
Administration: Improve the accuracy of `is_block_editor()`.
...
Currently, there are a number of scenarios where `is_block_editor()` (and `WP_Screen::is_block_editor`) would incorrectly indicate block editor support at different points of the loading process. Most notably, checking `is_block_editor` when hooking into the `current_screen` action will always result in `false`, even when the block editor is being loaded. This is because `is_block_editor` is not set to `true` until `edit-form-blocks.php` is included.
This change adds logic to `WP_Screen` to ensure the accuracy of `is_block_editor` on block editor pages earlier in the load process.
While edit screens will now be accurate 100% of the time from `current_screen` on, there are still a few edge cases where `is_block_editor` could contain an incorrect value when creating a new post.
Because a `WP_Post` object is a required parameter for the `replace_editor` filter and `use_block_editor_for_post()` function, `WP_Screen` will fall back to the value returned by `use_block_editor_for_post_type()` for the post being created. To eliminate these edge cases, the `use_block_editor_for_post_type` filter can be used to return the appropriate boolean value to indicate support.
Props Chouby, desrosj, aduth, johnbillion.
Fixes #46195 .
Built from https://develop.svn.wordpress.org/trunk@45224
git-svn-id: http://core.svn.wordpress.org/trunk@45033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 01:56:52 +00:00
893be2cf11
Site Health: Remove reference to an undefined variable in `WP_Site_Health_Auto_Updates::test_constants()`.
...
Props diddledan.
Fixes #46952 .
Built from https://develop.svn.wordpress.org/trunk@45223
git-svn-id: http://core.svn.wordpress.org/trunk@45032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 01:10:52 +00:00
01dec9af0b
Docs: Fix typo in `WP_Site_Health_Auto_Updates::test_constants()` description.
...
See #46543 .
Built from https://develop.svn.wordpress.org/trunk@45222
git-svn-id: http://core.svn.wordpress.org/trunk@45031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 01:00:51 +00:00
6ad0bf33ec
PHPCS: Fix WPCS violations in [45220].
...
See #46707 .
Built from https://develop.svn.wordpress.org/trunk@45221
git-svn-id: http://core.svn.wordpress.org/trunk@45030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 00:45:50 +00:00
9a316c6ea4
Site health, info tab:
...
- Change `recurse_dirsize()` to accept an array of excluded paths.
- Change so we don't calculate the sizes of dirs in wp-content twice.
- Add the size in bytes to the "debug" into.
- Add a custom DOM event after the dir sizes request is done. Can be used by plugins to "daisy chain" more requests.
- Move "WordPress directory location" and "WordPress directory size" to the top in the "Directories and Sizes" section.
- Move "Theme directory location" to the "Active Theme" section.
- Fix labels capitalization.
Props xkon, afercia, Clorith, azaozz.
Fixes #46707 .
Built from https://develop.svn.wordpress.org/trunk@45220
git-svn-id: http://core.svn.wordpress.org/trunk@45029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 23:02:51 +00:00
8e9315f51e
Media: move `get_available_post_mime_types` to `wp-includes/post.php` making it more generally available.
...
Address an issue since r44947 where calling `wp_enqueue_media` on the front-end would result in a PHP fatal.
Props david.binda.
Fixes #46795 .
Built from https://develop.svn.wordpress.org/trunk@45219
git-svn-id: http://core.svn.wordpress.org/trunk@45028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 20:30:51 +00:00
47ad9774e3
Bundled Themes: Reverts [45213].
...
Reverting to address backward compatibility concerns in Twenty Eleven and Twenty Ten.
See #39997 .
Built from https://develop.svn.wordpress.org/trunk@45218
git-svn-id: http://core.svn.wordpress.org/trunk@45027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 18:22:52 +00:00
fc7a8f7194
Administration: Improve the Site Health "Passed tests" button style for small screens.
...
Props chetan200891.
Fixes #46939 .
Built from https://develop.svn.wordpress.org/trunk@45217
git-svn-id: http://core.svn.wordpress.org/trunk@45026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 16:23:52 +00:00
c28e516c80
Export: Remove extra whitespace from `<title>`, `<content:encoded>`, and `<excerpt:encoded>` elements in WXR files.
...
Props sgastard, juliarrr, aristath, SergeyBiryukov.
Fixes #46575 .
Built from https://develop.svn.wordpress.org/trunk@45216
git-svn-id: http://core.svn.wordpress.org/trunk@45025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 15:57:53 +00:00
373a759c6b
Feeds: Amend [45208] to avoid `phpcs:ignore`.
...
See #46922 .
Built from https://develop.svn.wordpress.org/trunk@45215
git-svn-id: http://core.svn.wordpress.org/trunk@45024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 15:46:52 +00:00
39b82b89be
Permalinks: Avoid a PHP notice in `wp_resolve_numeric_slug_conflicts()` when visiting a day archive with the `/%postname%/` permalink structure.
...
Props thakkarhardik, thomstark.
Fixes #46828 .
Built from https://develop.svn.wordpress.org/trunk@45214
git-svn-id: http://core.svn.wordpress.org/trunk@45023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 15:34:52 +00:00
464535d0d3
Bundled Themes: Use the theme version when enqueuing theme specific stylesheets.
...
For many bundled theme related stylesheets, a version is either not specified, or specified as a hardcoded date string when enqueued. This is problematic when a stylesheet is updated and the version number is not (which has happened several times recently). This change ensures that all bundled theme related stylesheets use the theme’s version as the stylesheet version. This ensures cache busting for theme stylesheets every time a theme is updated and guarantees that users receive any new or updated styles included in the update when visiting the site for the first time after an update.
Props parsmizban, ianbelanger, dswebsme.
Fixes #39997 .
Built from https://develop.svn.wordpress.org/trunk@45213
git-svn-id: http://core.svn.wordpress.org/trunk@45022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 14:56:51 +00:00
69362abeac
Twenty Thirteen: Correct Genericons stylesheet version number.
...
In [28693], the Genericons stylesheet was updated to `3.0.3`, but the version was incorrectly indicated as `3.03`.
See #39997 .
Built from https://develop.svn.wordpress.org/trunk@45212
git-svn-id: http://core.svn.wordpress.org/trunk@45021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 14:07:51 +00:00
6067088848
Bootstrap/Load: Allow more than one recovery link to be valid at a time.
...
While currently a recovery link is only made available via the admin email address, this will be expanded in the future. In order to accomplish that, the mechanisms to store and validate recovery keys must support multiple keys to be valid at the same time.
This changeset adds that support, adding an additional token parameter which is part of a recovery link in addition to the key. A key itself is always associated with a token, so the two are only valid in combination. These associations are stored in a new `recovery_keys` option, which is regularly cleared in a new Cron hook, to prevent potential cluttering from unused recovery keys.
This changeset does not have any user-facing implications otherwise.
Props pbearne, timothyblynjacobs.
Fixes #46595 . See #46130 .
Built from https://develop.svn.wordpress.org/trunk@45211
git-svn-id: http://core.svn.wordpress.org/trunk@45020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 05:09:51 +00:00
f1352827f8
General: Display fatal error handler notice in admin backend even if headers have been sent.
...
This ensures that at least for the admin, which is more predictable than the frontend, the user-friendlier error notice from the fatal error handler still shows if a runtime fatal error happens within the page generation process.
Props axaak.
Fixes #46811 .
Built from https://develop.svn.wordpress.org/trunk@45210
git-svn-id: http://core.svn.wordpress.org/trunk@45019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 04:38:51 +00:00
37f04694d5
Bundled Themes: Use consistent HTML comments after closing HTML tags.
...
Props iamdmitrymayorov.
Fixes #46871 .
Built from https://develop.svn.wordpress.org/trunk@45209
git-svn-id: http://core.svn.wordpress.org/trunk@45018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 01:30:53 +00:00
f25f241573
Feeds: Remove whitespace from `<updated>` elements in Atom feeds.
...
Per Atom format's RFC, there must not be any whitespace in a Date construct or in any IRI.
Props josephwa.
Fixes #46922 .
Built from https://develop.svn.wordpress.org/trunk@45208
git-svn-id: http://core.svn.wordpress.org/trunk@45017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 00:46:51 +00:00
6efa2cd724
I18N: Fix typo in a translator comment.
...
See #46920 .
Built from https://develop.svn.wordpress.org/trunk@45207
git-svn-id: http://core.svn.wordpress.org/trunk@45016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-15 23:56:52 +00:00
7af011a5f0
Bootstrap/Load: After [45016], make sure `wp_die()` does not cause `_doing_it_wrong()` notices if called before `$wp_query` global is set.
...
Props tmdesigned, TimothyBlynJacobs.
Fixes #46813 .
Built from https://develop.svn.wordpress.org/trunk@45206
git-svn-id: http://core.svn.wordpress.org/trunk@45015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-15 23:49:53 +00:00
c75d21589d
Bootstrap/Load: Remove `WP_Recovery_Mode_Cookie_Service` constructor to avoid referencing cookie constants before they are defined.
...
Instantiating `WP_Recovery_Mode` should no longer have any required timing.
Props TimothyBlynJacobs, lkraav.
Fixes #46882 .
Built from https://develop.svn.wordpress.org/trunk@45205
git-svn-id: http://core.svn.wordpress.org/trunk@45014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-15 22:44:52 +00:00
d4d1267847
I18N: Improvements to and additions of translator comments for various email subject strings.
...
Props ramiy
Fixes #46920
Built from https://develop.svn.wordpress.org/trunk@45204
git-svn-id: http://core.svn.wordpress.org/trunk@45013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-15 22:39:50 +00:00
60bf5fefff
Docs: Adjust comments in `wp_initial_constants()` to conform to WPCS.
...
See #46543 .
Built from https://develop.svn.wordpress.org/trunk@45203
git-svn-id: http://core.svn.wordpress.org/trunk@45012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-15 22:10:52 +00:00
df276c333a
Administration: Update chevron color in Site Health.
...
Props afercia.
Fixes #46934 . See #46730 .
Built from https://develop.svn.wordpress.org/trunk@45202
git-svn-id: http://core.svn.wordpress.org/trunk@45011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-15 18:56:54 +00:00
10239ba45d
Administration: Add a chevron icon to the Site Health "Passed tests" button.
...
The chevron icon helps clarify what the button does.
Props garrett-eclipse, Clorith, xkon, melchoyce.
Fixes #46730 .
Built from https://develop.svn.wordpress.org/trunk@45201
git-svn-id: http://core.svn.wordpress.org/trunk@45010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-15 18:01:53 +00:00
5ac2b28396
Administration: Provide translatable strings for the Site Health comment status report.
...
Props ocean90.
Fixes #46909 .
Built from https://develop.svn.wordpress.org/trunk@45200
git-svn-id: http://core.svn.wordpress.org/trunk@45009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-15 15:08:51 +00:00
5b530e903d
Site Health: Add missing translator comments.
...
Amends [45178].
See #46683 .
Built from https://develop.svn.wordpress.org/trunk@45199
git-svn-id: http://core.svn.wordpress.org/trunk@45008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-15 14:39:55 +00:00
b0ef0ae305
Site health: Improve jQuery selectors so that they don't depend on a specific markup.
...
Amends [45178].
See #46683 .
Built from https://develop.svn.wordpress.org/trunk@45198
git-svn-id: http://core.svn.wordpress.org/trunk@45007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-14 14:30:51 +00:00
a9542cd60a
Coding standards: Site health: Avoid to use `var` in the middle of JavaScript function blocks.
...
Amends [45178].
See #46683 .
Built from https://develop.svn.wordpress.org/trunk@45197
git-svn-id: http://core.svn.wordpress.org/trunk@45006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-14 13:49:55 +00:00
394d3b2f9b
Site Health: Merge duplicate "utf8mb4 requires a newer client library" strings.
...
Props ramiy.
Fixes #46917 .
Built from https://develop.svn.wordpress.org/trunk@45196
git-svn-id: http://core.svn.wordpress.org/trunk@45005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 18:18:52 +00:00
f94f0684b1
Site Health: Merge duplicate "Error" strings.
...
Props ramiy.
Fixes #46915 .
Built from https://develop.svn.wordpress.org/trunk@45195
git-svn-id: http://core.svn.wordpress.org/trunk@45004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 18:12:52 +00:00
38f3607c53
Users: Merge duplicate "Download failed" strings.
...
Props ramiy.
Fixes #46914 .
Built from https://develop.svn.wordpress.org/trunk@45194
git-svn-id: http://core.svn.wordpress.org/trunk@45003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 18:08:52 +00:00
cbe1c88485
Site Health: Merge duplicate "Latest version" strings.
...
Props ramiy.
Fixes #46913 .
Built from https://develop.svn.wordpress.org/trunk@45193
git-svn-id: http://core.svn.wordpress.org/trunk@45002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 18:04:52 +00:00
845977ed1f
Site Health: Merge duplicate "Learn more about updating PHP" strings.
...
Props ramiy.
Fixes #46912 .
Built from https://develop.svn.wordpress.org/trunk@45192
git-svn-id: http://core.svn.wordpress.org/trunk@45001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 17:59:52 +00:00
ae779fc980
Docs: Add missing `@since` tag for [45031].
...
Props dimadin.
See #46667 .
Built from https://develop.svn.wordpress.org/trunk@45191
git-svn-id: http://core.svn.wordpress.org/trunk@45000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 14:17:55 +00:00
b6471e9be4
Bootstrap/Load: Remove duplicate leading slashes on inclusion of various files under `ABSPATH`.
...
Props dmsnell, birgire, szepe.viktor.
Fixes #46327 .
Built from https://develop.svn.wordpress.org/trunk@45190
git-svn-id: http://core.svn.wordpress.org/trunk@44999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 04:46:52 +00:00
b2a9bb4e78
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/customize-controls.css`.
...
Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46494 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45189
git-svn-id: http://core.svn.wordpress.org/trunk@44998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 04:36:51 +00:00
77ff117d7f
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/themes.css`.
...
Props ianbelanger, mukesh27, audrasjb, pbiron, afercia.
Fixes #46518 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45188
git-svn-id: http://core.svn.wordpress.org/trunk@44997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 04:32:51 +00:00
5fe5733f38
CSS Coding Standards: Use unitless values for `line-height` for count bubbles in `wp-admin/css/admin-menu.css`.
...
Missed in [45186].
Props ianbelanger.
See #46489 , #44643 .
Built from https://develop.svn.wordpress.org/trunk@45187
git-svn-id: http://core.svn.wordpress.org/trunk@44996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 04:20:50 +00:00
b76772b9a7
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/admin-menu.css`.
...
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46489 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45186
git-svn-id: http://core.svn.wordpress.org/trunk@44995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 00:17:50 +00:00
88fdfae793
Plugins: Introduce `is_wp_version_compatible()` and `is_php_version_compatible()` for checking compatibility with the current WordPress or PHP version.
...
Props afragen.
Fixes #46599 .
Built from https://develop.svn.wordpress.org/trunk@45185
git-svn-id: http://core.svn.wordpress.org/trunk@44994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 23:56:52 +00:00
a2e273944a
Plugins: In `list_plugin_updates()`, only display the annotation and the surrounding tags if it's not empty.
...
Props afragen.
Fixes #46680 .
Built from https://develop.svn.wordpress.org/trunk@45184
git-svn-id: http://core.svn.wordpress.org/trunk@44993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 21:52:52 +00:00
b9c927411a
Post WordPress 5.2 Beta 3 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@45183
git-svn-id: http://core.svn.wordpress.org/trunk@44992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 21:27:53 +00:00
1845aeb2c8
WordPress 5.2 Beta 3.
...
Built from https://develop.svn.wordpress.org/trunk@45182
git-svn-id: http://core.svn.wordpress.org/trunk@44991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 21:06:51 +00:00
65da064055
Bootstrap/Load: Finalize recovery mode email language.
...
Props TimothyBlynJacobs, miss_jwo, desrosj.
Fixes #46898 .
Built from https://develop.svn.wordpress.org/trunk@45181
git-svn-id: http://core.svn.wordpress.org/trunk@44990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 20:49:51 +00:00
41022dc6f2
Privacy: Remove unnecessary translation from help notice action label.
...
As static markup, the Privacy Policy editor help notice link no longer needs to be translateable with the revisions included in [45174].
Props garrett-eclipse.
Fixes #46098 . See [45174].
Built from https://develop.svn.wordpress.org/trunk@45180
git-svn-id: http://core.svn.wordpress.org/trunk@44989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 20:44:52 +00:00
7e4b4e1089
Site Health: Use `_n()` for `%s Items with no issues detected` string, missed in [45178].
...
See #46683 .
Built from https://develop.svn.wordpress.org/trunk@45179
git-svn-id: http://core.svn.wordpress.org/trunk@44988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 20:40:51 +00:00
1ae11820fc
Site Health: i18n audit, take 2.
...
* Use `wp.i18n` to translate JavaScript strings.
* Use `_n()` for proper plural forms support.
Props TimothyBlynJacobs, ocean90, afercia.
Fixes #46683 .
Built from https://develop.svn.wordpress.org/trunk@45178
git-svn-id: http://core.svn.wordpress.org/trunk@44987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 20:34:51 +00:00
1b35ea6978
Media: Fix deletion of files when using stream wrappers.
...
This fixes a bug introduced in [43392] which breaks file deletion on systems using stream wrappers, due to limitations of `realpath()`.
Props antonypuckey, pfiled.
Fixes #44563 .
Built from https://develop.svn.wordpress.org/trunk@45177
git-svn-id: http://core.svn.wordpress.org/trunk@44986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 20:01:52 +00:00
30ccfd540f
Site health: Load the "Info" tab immediately and notify the user while gathering site data. Changes the Info tab to work similarly to the Status tab: it does separate request to fetch the directories sizes and doesn't "block" the loading of the page.
...
Props xkon, afercia, Clorith, azaozz.
See #46707 .
Built from https://develop.svn.wordpress.org/trunk@45176
git-svn-id: http://core.svn.wordpress.org/trunk@44985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 19:24:51 +00:00
105277f93e
Administration: Move “Recovery Mode” to the beginning of the document title.
...
This improves accessibility, ensuring users utilizing screen readers are informed that the site is in recovery mode.
Props: afercia, TimothyBlynJacobs.
See #46608 .
Built from https://develop.svn.wordpress.org/trunk@45175
git-svn-id: http://core.svn.wordpress.org/trunk@44984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 19:05:51 +00:00
7f456cab7d
Privacy: Display help notice on block editor screen.
...
Use the Notices data module when viewing the block editor screen for the assigned Privacy Policy page to display a help notice.
Props garrett-eclipse, joen, xkon.
Fixes #46098 .
Built from https://develop.svn.wordpress.org/trunk@45174
git-svn-id: http://core.svn.wordpress.org/trunk@44983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 18:19:51 +00:00
79f8d9786d
Text Changes: Use simpler language for login detail email subjects.
...
Props: peterwilsoncc, desrosj.
Fixes #37940 .
Built from https://develop.svn.wordpress.org/trunk@45173
git-svn-id: http://core.svn.wordpress.org/trunk@44982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 18:16:52 +00:00
77e87830ae
TinyMCE: Fix keyboard navigation when the `dfw` button is present but hidden. Ensure that button is added last in the DOM to match where it appears visually.
...
Props afercia, azaozz.
Fixes #46640 .
Built from https://develop.svn.wordpress.org/trunk@45172
git-svn-id: http://core.svn.wordpress.org/trunk@44981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 18:08:53 +00:00
44d977b2af
Site Health: Correctly refer to an `.htaccess` file as hidden.
...
The preceding period (`.`) should always be included when referring to an `.htaccess` file.
Props: ianbelanger, garrett-eclipse, subrataemfluence, burhandodhy.
Fixes #46841 .
Built from https://develop.svn.wordpress.org/trunk@45171
git-svn-id: http://core.svn.wordpress.org/trunk@44980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 17:50:52 +00:00
6afe73667c
Site Health: Add missing actions to tests.
...
This change adds missing actions for several tests. This ensures that the user is provided with a next step, whenever possible.
Also, change the URL displayed in the WordPress.org communication test description to `api.wordpress.org` for accuracy.
Props: garrett-eclipse, Clorith, vaishalipanchal.
Fixes #46734 .
Built from https://develop.svn.wordpress.org/trunk@45170
git-svn-id: http://core.svn.wordpress.org/trunk@44979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 17:40:53 +00:00
5bafb4ea2d
Site Health: Improve the test badge implementation.
...
Label badges for each Site Health test currently display in either red, orange, or green, regardless of if the test passed or failed. This is confusing, as seeing red labels in the “Passed Test” section could alarm users (when really everything is OK and no action is required), and seeing green labels in the “Failed Tests” section would not appropriately encourage the user to take appropriate action.
This change makes several improvements to the label badges:
- Always right align the badges for consistent display.
- Remove background fill for badges. Instead, use a border.
- Use a consistent styling for all tests (passed and failed).
- The text color no longer uses true black (#000000 ).
- The `.badge.pink` CSS definition has been switched to `.badge.purple`, and the definitions for blue, gray, and green have also been updated to more closely follow the official WordPress color palette.
Props: pbiron, garrett-eclipse, hedgefield, Clorith, xkon, melchoyce, mdwolinski, alexdenning.
Fixes #46623 .
Built from https://develop.svn.wordpress.org/trunk@45169
git-svn-id: http://core.svn.wordpress.org/trunk@44978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 17:04:52 +00:00
21da589622
Site Health: Ensure Site Health pages are correctly displayed for RTL locales.
...
Props: ebrahimzadeh, afercia, mohadeseghasemi.
Fixes #46868 .
Built from https://develop.svn.wordpress.org/trunk@45168
git-svn-id: http://core.svn.wordpress.org/trunk@44977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 16:39:52 +00:00
e04ffc348b
Administration: Remove unnecessary numbered placeholders.
...
Props: tobifjellner, thrijith.
Fixes #46824 .
Built from https://develop.svn.wordpress.org/trunk@45167
git-svn-id: http://core.svn.wordpress.org/trunk@44976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 16:32:50 +00:00
501234ebe0
Site Health: Include both site and user locales in debug information.
...
Previously, only the site’s locale was displayed in the Site Health debug information. Moving forward, both the site’s default locale and the user’s locale will be specified.
This change also removes the `@param` tag for `WP_Debug_Data::debug_data()`. This parameter was previously removed in [45156].
Props: mukesh27, ianbelanger, Clorith, desrosj.
Fixes #46803 .
Built from https://develop.svn.wordpress.org/trunk@45166
git-svn-id: http://core.svn.wordpress.org/trunk@44975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 15:49:52 +00:00
8d04086af3
Upgrade/Install: Prevent plugin auto updates if PHP version requirements are not satisfied.
...
In [44937] and [44939], changes were made to prevent a user from updating any plugin that requires a higher version of PHP than the site is running. This compliments those changes to also prevent plugins from being auto updated when the same requirements are not met.
Props: TimothyBlynJacobs, davidbaumwald.
Fixes #46613 .
Built from https://develop.svn.wordpress.org/trunk@45165
git-svn-id: http://core.svn.wordpress.org/trunk@44974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 14:02:53 +00:00
8b0cc1c90f
Site Health: Clarify `WP_DEBUG` warning and translation contexts.
...
Clarifies that `WP_DEBUG` can cause `WP_DEBUG_DISPLAY` to be enabled,
and uses the constants themselves in related translation contexts.
Props mukesh27, ocean90, clorith, SergeyBiryukov, mikeschroder.
Fixes #46877 .
Built from https://develop.svn.wordpress.org/trunk@45164
git-svn-id: http://core.svn.wordpress.org/trunk@44973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 02:27:51 +00:00
3ab2803af2
Docs: Add missing `@since` tags for `wp_targeted_link_rel()` and `wp_targeted_link_rel_callback()`.
...
See #43187 , #46543 .
Built from https://develop.svn.wordpress.org/trunk@45163
git-svn-id: http://core.svn.wordpress.org/trunk@44972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-11 21:16:51 +00:00
b3057080e8
Networks and Sites: Use numbered placeholder in a `mailto:` link in `ms_site_check()`.
...
Props diddledan.
Fixes #46849 .
Built from https://develop.svn.wordpress.org/trunk@45162
git-svn-id: http://core.svn.wordpress.org/trunk@44971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-11 20:15:52 +00:00
ed4f394b67
Docs: Correct type for `WP_Object_Cache::$blog_prefix`.
...
Props diddledan.
Fixes #46851 .
Built from https://develop.svn.wordpress.org/trunk@45161
git-svn-id: http://core.svn.wordpress.org/trunk@44970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-11 20:10:53 +00:00
15684a84db
Build/Test tools: Add some docs to the test functions.
...
Props andizer
Fixes #46501
Built from https://develop.svn.wordpress.org/trunk@45160
git-svn-id: http://core.svn.wordpress.org/trunk@44969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-11 17:30:52 +00:00
17bdafca77
General: Fix a typo in the docs for `_restore_wpautop_hook()`.
...
Props manzoorwani.jk
Fixes #46864
Built from https://develop.svn.wordpress.org/trunk@45159
git-svn-id: http://core.svn.wordpress.org/trunk@44968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-11 17:27:52 +00:00
2887cea50f
Accessibility: Improve the image "Alternative Text" field in the Edit Media screen.
...
Brings parity with the changes for the Media Views introduced in [44900].
- moves the alt text field to the top as first field
- adds an explanatory text with a link pointing to the W3C "alt decision tree" tutorial
- adds `aria-describedby` to target the explanatory text
- adjusts the CSS and indentation
Props chetan200891.
Fixes #46875 .
Built from https://develop.svn.wordpress.org/trunk@45158
git-svn-id: http://core.svn.wordpress.org/trunk@44967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-10 20:00:50 +00:00
f27917373c
Login and Registration: improve the CSS padding on the login input fields.
...
The right padding added in [44895] needs to be set only on the input fields in the Reset Password screen and exclude other login screens.
Amends [44895].
Fixes #42853 .
Built from https://develop.svn.wordpress.org/trunk@45157
git-svn-id: http://core.svn.wordpress.org/trunk@44966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-10 16:12:51 +00:00
8ffebab3e6
Site health: Fix gathering the site data twice on non-English locales. Introduces two sets of data:
...
- More verbose set used to generate the admin page.
- More concise set that is copied when clicking the "Copy the site info" button intended mostly for support and developers.
Props xkon, azaozz.
Fixes #46726 .
Built from https://develop.svn.wordpress.org/trunk@45156
git-svn-id: http://core.svn.wordpress.org/trunk@44965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-10 05:07:51 +00:00
447b956bb8
Site Health: Add missing i18n for “Copied!” string.
...
Props: Soean, mukesh27, davidbaumwald.
Fixes #46847 .
Built from https://develop.svn.wordpress.org/trunk@45155
git-svn-id: http://core.svn.wordpress.org/trunk@44964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-09 15:24:53 +00:00
dd0785d3f9
Privacy: Pass admin URLs for data export and erase forms through `esc_url()`.
...
Introduced in [45149].
Props: birgire.
Fixes #44047 .
Built from https://develop.svn.wordpress.org/trunk@45154
git-svn-id: http://core.svn.wordpress.org/trunk@44963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-09 14:07:51 +00:00
33c82208a2
Media: Remove an extra verb context missed in [45147].
...
Props garrett-eclipse.
See #44675 .
Built from https://develop.svn.wordpress.org/trunk@45153
git-svn-id: http://core.svn.wordpress.org/trunk@44962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-09 03:59:51 +00:00
af86d95778
Post WordPress 5.2 Beta version bump
...
Built from https://develop.svn.wordpress.org/trunk@45152
git-svn-id: http://core.svn.wordpress.org/trunk@44961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-09 01:23:51 +00:00
02d97f51c1
WordPress 5.2 Beta 2
...
Built from https://develop.svn.wordpress.org/trunk@45151
git-svn-id: http://core.svn.wordpress.org/trunk@44960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-09 01:12:51 +00:00
ed8723fd8f
UI: Remove vertical alignment from active primary buttons.
...
This caused the post-plugin installation actions to jump around when the "Activate Plugin" primary button became active.
Props seedsca, pratikthink, ianbelanger, mukesh27.
Fixes #44836 .
Built from https://develop.svn.wordpress.org/trunk@45150
git-svn-id: http://core.svn.wordpress.org/trunk@44959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-09 00:16:53 +00:00
d6c90ca7d7
Privacy: Add a missing `<form>` action on the Export/Erasure screens.
...
This lack of action could cause an expired nonce to end up in the URL.
Props garrett-eclipse, saimonh, xkon.
Fixes #44047 .
Built from https://develop.svn.wordpress.org/trunk@45149
git-svn-id: http://core.svn.wordpress.org/trunk@44958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-09 00:08:54 +00:00
cbc0240cd6
Privacy: Only mark a personal data export as complete when the user downloads it.
...
An admin may download an export to check that it's all correct, but this action shouldn't mark the request as complete.
Props garrett-eclipse, JoshuaWold, birgire.
Fixes #44644 .
Built from https://develop.svn.wordpress.org/trunk@45148
git-svn-id: http://core.svn.wordpress.org/trunk@44957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-09 00:04:50 +00:00
4b1ff1c298
Media: Update the media bulk action labels for consistency.
...
Props ianbelanger, garrett-eclipse, afercia, Presskopp.
Fixes #44675 .
Built from https://develop.svn.wordpress.org/trunk@45147
git-svn-id: http://core.svn.wordpress.org/trunk@44956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 23:54:52 +00:00
9292802d92
Twenty Seventeeen: Fix MediaElement control hover colours in the customiser.
...
When selecting custom colour schemes in the customiser, the hover colour is incorrectly applied to MediaElement controls.
Props xkon, ianbelanger.
Fixes #40843 .
Built from https://develop.svn.wordpress.org/trunk@45146
git-svn-id: http://core.svn.wordpress.org/trunk@44955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 23:38:51 +00:00
5b8db48734
Site Health: Remove animated ellipsis from the status loading indicator.
...
This animation wasn't particularly reliable across browsers.
Props Clorith, afercia.
Fixes #46684 .
Built from https://develop.svn.wordpress.org/trunk@45145
git-svn-id: http://core.svn.wordpress.org/trunk@44954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 23:29:51 +00:00
8c8c1f8984
Widgets: Add `rel="noopener noreferrer"` to links with `target="_blank"` in the Image widget.
...
Props audrasjb, welcher, afercia.
Fixes #43280 .
Built from https://develop.svn.wordpress.org/trunk@45144
git-svn-id: http://core.svn.wordpress.org/trunk@44953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 23:23:51 +00:00
K. Adam White
Sergey Biryukov
Gary Pendergast
Peter Wilson
Adam Silverstein
Andrew Ozz
whyisjake
Aaron Jorbin
Andrea Fercia
Tammie Lister
Dominik Schilling
laurelfulford
youknowriad
John Blackbourn
atimmer
desrosj
Weston Ruter
Felix Arntz
tellyworth
aduth
Jeremy Felt
Mel Choyce
Joe McGill
Mike Schroder