honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
angular-cn/.pullapprove.yml

1296 lines
44 KiB
YAML
Raw Normal View History

ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
####################################################################################
####################################################################################
# Angular Code Ownership #
####################################################################################
####################################################################################
#
# Configuration of code ownership and review approvals for the angular/angular repo.
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
#
# More info: https://docs.pullapprove.com/
#
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# =========================================================
# General rules / philosophy
# =========================================================
#
# - We trust that people do the right thing and won't approve changes they don't feel confident reviewing
# - We enforce that only approved PRs are merged ensuring that unreviewed code isn't accidentally merged
# - We distribute approval rights as much as possible to help us scale better
# - Groups have one or two global approvers groups as fallbacks:
# - @angular/fw-global-approvers: for approving minor changes, large-scale refactorings, and emergency situations.
# - @angular/fw-global-approvers-for-docs-only-changes: for approving minor documentation-only changes that don't require engineering review
# - A small number of file groups have very limited number of reviewers because incorrect changes to the files they guard would have serious consequences (e.g. security, public api)
#
# Configuration nuances:
#
# - This configuration works in conjunction with the protected branch settings that require all changes to be made via pull requests with at least one approval.
# - This approval can come from an appropriate codeowner, or any repo collaborator (person with write access) if the PR is authored by a codeowner.
# - All groups whose pullapprove rules are matched will be required for overall approval.
#
# NOTE:
# In the case of emergency, the repo administrators which include the current angular caretaker
# can bypass this reviewer approval requirement, this is expected as a last resort and to be
# done exceedingly sparingly.
####################################################################################
# GitHub usernames
####################################################################################
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
# See reviewer list under `required-minimum-review` group. Team member names and
# usernames are managed there.
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
####################################################################################
# Approval Groups
####################################################################################
# =========================================================
# @angular/framework-global-approvers
# =========================================================
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
# Used for approving minor changes, large-scale refactorings, and in emergency situations.
#
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# IgorMinar
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 18:10:13 -04:00
# jelbourn
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# josephperrott
# mhevery
#
# =========================================================
# @angular/framework-global-approvers-for-docs-only-changes
# =========================================================
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
# Used for approving minor documentation-only changes that don't require engineering review.
#
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# aikidave
# gkalpak
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
# kapunahelewong
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# petebacondarwin
version: 3
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
# Meta field that goes unused by PullApprove to allow for defining aliases to be
# used throughout the config.
meta:
refactor(dev-infra): create anchors/aliases for excluded always active groups (#37798) global-approvers, global-docs-approvers, and required-minimum-review groups are always active. It's useful to have aliases for getting groups that are active/pending/rejected while excluding these few. PR Close #37798
2020-06-27 15:47:54 -04:00
# The following groups have no file based conditions and will be initially `active` on all PRs
# - `global-approvers`
# - `global-docs-approvers`
# - `required-minimum-review`
#
# By checking the number of active/pending/rejected groups when these are excluded, we can determine
# if any other groups are matched.
#
ci: only check active groups for the `no-groups-above-this-*` checks (#38259) Since PullApprove starts all inactive groups as a pending state, to properly assess if any groups we care about are pending we must only check the active groups. We additionally do this with rejected because the intention of the reusable checks is around checking active rules only. PR Close #38259
2020-07-27 20:10:23 -04:00
# Note: Because all inactive groups start as pending, we are only checking pending and rejected active groups.
#
refactor(dev-infra): create anchors/aliases for excluded always active groups (#37798) global-approvers, global-docs-approvers, and required-minimum-review groups are always active. It's useful to have aliases for getting groups that are active/pending/rejected while excluding these few. PR Close #37798
2020-06-27 15:47:54 -04:00
# Also note that the ordering of groups matters in this file. The only groups visible to the current
# one are those that appear above it.
no-groups-above-this-pending: &no-groups-above-this-pending
ci: only check active groups for the `no-groups-above-this-*` checks (#38259) Since PullApprove starts all inactive groups as a pending state, to properly assess if any groups we care about are pending we must only check the active groups. We additionally do this with rejected because the intention of the reusable checks is around checking active rules only. PR Close #38259
2020-07-27 20:10:23 -04:00
len(groups.active.pending.exclude("required-minimum-review").exclude("global-approvers").exclude("global-docs-approvers")) == 0
refactor(dev-infra): create anchors/aliases for excluded always active groups (#37798) global-approvers, global-docs-approvers, and required-minimum-review groups are always active. It's useful to have aliases for getting groups that are active/pending/rejected while excluding these few. PR Close #37798
2020-06-27 15:47:54 -04:00
no-groups-above-this-rejected: &no-groups-above-this-rejected
ci: only check active groups for the `no-groups-above-this-*` checks (#38259) Since PullApprove starts all inactive groups as a pending state, to properly assess if any groups we care about are pending we must only check the active groups. We additionally do this with rejected because the intention of the reusable checks is around checking active rules only. PR Close #38259
2020-07-27 20:10:23 -04:00
len(groups.active.rejected.exclude("required-minimum-review").exclude("global-approvers").exclude("global-docs-approvers")) == 0
refactor(dev-infra): create anchors/aliases for excluded always active groups (#37798) global-approvers, global-docs-approvers, and required-minimum-review groups are always active. It's useful to have aliases for getting groups that are active/pending/rejected while excluding these few. PR Close #37798
2020-06-27 15:47:54 -04:00
no-groups-above-this-active: &no-groups-above-this-active
len(groups.active.exclude("required-minimum-review").exclude("global-approvers").exclude("global-docs-approvers")) == 0
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
can-be-global-approved: &can-be-global-approved "\"global-approvers\" not in groups.approved"
can-be-global-docs-approved: &can-be-global-docs-approved "\"global-docs-approvers\" not in groups.approved"
defaults: &defaults
reviews:
# Authors provide their approval implicitly, this approval allows for a reviewer
# from a group not to need a review specifically for an area of the repository
# they own. This is coupled with the `required-minimum-review` group which requires
# that all PRs are reviewed by at least one team member who is not the author of
# the PR.
author_value: 1
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# turn on 'draft' support
# https://docs.pullapprove.com/config/github-api-version/
# https://developer.github.com/v3/previews/#draft-pull-requests
github_api_version: "shadow-cat-preview"
pullapprove_conditions:
ci: fix pullapprove_conditions (#35011) PR Close #35011
2020-01-28 12:29:36 -05:00
- condition: "'WIP' not in title"
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
unmet_status: pending
explanation: "Waiting to send reviews as PR is WIP"
ci: fix pullapprove_conditions (#35011) PR Close #35011
2020-01-28 12:29:36 -05:00
- condition: "'PR state: WIP' not in labels"
unmet_status: pending
explanation: "Waiting to send reviews as PR is WIP"
ci: reenable draft mode conditioning for pullapprove (#35396) Previously there was a regression in PullApprove which preventing draft mode from being respected correctly for PullApprove processing. This regression has been remedied and we should be able to once again respect draft mode for PRs. PR Close #35396
2020-02-12 17:30:49 -05:00
- condition: "not draft"
unmet_status: pending
explanation: "Waiting to send reviews as PR is in draft"
ci: fix pullapprove_conditions (#35011) PR Close #35011
2020-01-28 12:29:36 -05:00
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
groups:
build: update required-minimum-review group to be global approvable (#37636) Previously, the required-minimum-review group was still considered active when a global approval was provided. This would result in global approvers needing to Reviewd-For both the global approval and minimum review groups. Instead when a global approver provides their approval, the minimum review group should be considered satisified. PR Close #37636
2020-06-18 11:26:46 -04:00
# =========================================================
# Global Approvers
#
# All reviews performed for global approvals require using
# the `Reviewed-for:` specifier to set the approval
# specificity as documented at:
# https://docs.pullapprove.com/reviewed-for/
# =========================================================
global-approvers:
type: optional
reviewers:
teams:
- framework-global-approvers
reviews:
request: 0
required: 1
reviewed_for: required
# =========================================================
# Global Approvers For Docs
#
# All reviews performed for global docs approvals require
# using the `Reviewed-for:` specifier to set the approval
# specificity as documented at:
# https://docs.pullapprove.com/reviewed-for/
# =========================================================
global-docs-approvers:
type: optional
reviewers:
teams:
- framework-global-approvers-for-docs-only-changes
reviews:
request: 0
required: 1
reviewed_for: required
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
# =========================================================
# Require review on all PRs
#
# All PRs require at least one review. This rule will not
# request any reviewers, however will require that at least
# one review is provided before the group is satisfied.
# =========================================================
required-minimum-review:
build: update required-minimum-review group to be global approvable (#37636) Previously, the required-minimum-review group was still considered active when a global approval was provided. This would result in global approvers needing to Reviewd-For both the global approval and minimum review groups. Instead when a global approver provides their approval, the minimum review group should be considered satisified. PR Close #37636
2020-06-18 11:26:46 -04:00
conditions:
- *can-be-global-approved
- *can-be-global-docs-approved
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
reviews:
request: 0 # Do not request any reviews from the reviewer group
required: 1 # Require that all PRs have approval from at least one of the users in the group
author_value: 0 # The author of the PR cannot provide an approval for themself
reviewers:
users:
- aikidave # Dave Shevitz
- alan-agius4 # Alan Agius
- alxhub # Alex Rickabaugh
- AndrewKushnir # Andrew Kushnir
- andrewseguin # Andrew Seguin
- atscott # Andrew Scott
- ayazhafiz # Ayaz Hafiz
- clydin # Charles Lyding
- crisbeto # Kristiyan Kostadinov
- dennispbrown # Denny Brown
- devversion # Paul Gschwendtner
- dgp1130 # Doug Parker
- filipesilva # Filipe Silva
- gkalpak # Georgios Kalpakas
- gregmagolan # Greg Magolan
- IgorMinar # Igor Minar
- jbogarthyde # Judy Bogart
- jelbourn # Jeremy Elbourn
- JiaLiPassion # Jia Li
- JoostK # Joost Koehoorn
- josephperrott # Joey Perrott
- juleskremer # Jules Kremer
- kapunahelewong # Kapunahele Wong
- kara # Kara Erickson
- kyliau # Keen Yee Liau
- manughub # Manu Murthy
- mgechev # Minko Gechev
- mhevery # Miško Hevery
- mmalerba # Miles Malerba
- petebacondarwin # Pete Bacon Darwin
- pkozlowski-opensource # Pawel Kozlowski
build: correct listed username for @Splaktar in pullapprove config (#37636) Previously, Michael Prentice's username was erroneously listed at @michaelprentice however his Github username is actually @Splaktar. This issue is corrected by this change to properly allow him to provide reviews. PR Close #37636
2020-06-18 09:36:03 -04:00
- Splaktar # Michael Prentice
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
- StephenFluin # Stephen Fluin
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# =========================================================
# Framework: Animations
# =========================================================
fw-animations:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'packages/animations/**',
'packages/platform-browser/animations/**',
'aio/content/guide/animations.md',
'aio/content/examples/animations/**',
'aio/content/images/guide/animations/**',
'aio/content/guide/complex-animation-sequences.md',
'aio/content/guide/reusable-animations.md',
'aio/content/guide/route-animations.md',
'aio/content/guide/transition-and-triggers.md'
])
reviewers:
users:
build: update pullapprove to remove @matsko from reviewer lists (#38146) With @matsko leaving the Angular team, we need to update the pullapprove configuration to reflect his no longer being a reviewer for file groups throughout the repository. PR Close #38146
2020-07-20 14:06:05 -04:00
- crisbeto
- IgorMinar
- jelbourn
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# =========================================================
# Framework: Compiler
# =========================================================
fw-compiler:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
ci: fix pullapprove incorrectly skipping fw-compiler as owner (#36661) Currently, if changes are made to `compiler-cli/ngcc` and to other compiler-related files, then only the `fw-ngcc` group is requested for review. This is because the `not contains_any_globs` condition will be false for `fw-compiler` and the group will never become active. We fix this by removing the incorrect condition and filtering out ngcc files before checking `contains_any_globs` in the primary fw-compiler condition. PR Close #36661
2020-04-16 17:18:16 -04:00
contains_any_globs(files.exclude('packages/compiler-cli/ngcc/**'), [
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'packages/compiler/**',
'packages/examples/compiler/**',
'packages/compiler-cli/**',
'aio/content/guide/angular-compiler-options.md',
'aio/content/guide/aot-compiler.md',
'aio/content/guide/aot-metadata-errors.md',
'aio/content/guide/template-typecheck.md '
])
reviewers:
users:
- alxhub
- AndrewKushnir
- JoostK
# =========================================================
# Framework: Compiler / ngcc
# =========================================================
fw-ngcc:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: fix pullapprove incorrectly skipping fw-compiler as owner (#36661) Currently, if changes are made to `compiler-cli/ngcc` and to other compiler-related files, then only the `fw-ngcc` group is requested for review. This is because the `not contains_any_globs` condition will be false for `fw-compiler` and the group will never become active. We fix this by removing the incorrect condition and filtering out ngcc files before checking `contains_any_globs` in the primary fw-compiler condition. PR Close #36661
2020-04-16 17:18:16 -04:00
- files.include('packages/compiler-cli/ngcc/**')
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
reviewers:
users:
- alxhub
- gkalpak
- JoostK
- petebacondarwin
ci: add codeowner group for migrations (#36661) Adds a new codeowner group that is dedicated for changes to the migrations stored in `packages/core/schematics`. PR Close #36661
2020-04-16 17:27:33 -04:00
# =========================================================
# Framework: Migrations
# =========================================================
fw-migrations:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: add codeowner group for migrations (#36661) Adds a new codeowner group that is dedicated for changes to the migrations stored in `packages/core/schematics`. PR Close #36661
2020-04-16 17:27:33 -04:00
conditions:
- *can-be-global-approved
- *can-be-global-docs-approved
- files.include("packages/core/schematics/**")
reviewers:
users:
- alxhub
- crisbeto
- devversion
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# =========================================================
# Framework: Core
# =========================================================
fw-core:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
ci: add codeowner group for migrations (#36661) Adds a new codeowner group that is dedicated for changes to the migrations stored in `packages/core/schematics`. PR Close #36661
2020-04-16 17:27:33 -04:00
contains_any_globs(files.exclude("packages/core/schematics/**"), [
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'packages/core/**',
'packages/examples/core/**',
'packages/common/**',
'packages/platform-browser/**',
'packages/examples/platform-browser/**',
'packages/platform-browser-dynamic/**',
'packages/platform-webworker/**',
'packages/platform-webworker-dynamic/**',
'packages/examples/common/**',
'packages/docs/**',
'aio/content/guide/accessibility.md',
'aio/content/examples/accessibility/**',
'aio/content/guide/architecture-components.md',
'aio/content/guide/architecture-modules.md',
'aio/content/guide/architecture-next-steps.md',
'aio/content/guide/architecture-services.md',
'aio/content/guide/architecture.md',
'aio/content/examples/architecture/**',
'aio/content/images/guide/architecture/**',
'aio/content/guide/attribute-directives.md',
'aio/content/examples/attribute-directives/**',
'aio/content/images/guide/attribute-directives/**',
'aio/content/guide/bootstrapping.md',
'aio/content/examples/bootstrapping/**',
'aio/content/guide/cheatsheet.md',
'aio/content/guide/component-interaction.md',
'aio/content/examples/component-interaction/**',
'aio/content/images/guide/component-interaction/**',
'aio/content/guide/component-styles.md',
'aio/content/examples/component-styles/**',
'aio/content/guide/dependency-injection.md',
'aio/content/examples/dependency-injection/**',
'aio/content/images/guide/dependency-injection/**',
'aio/content/guide/dependency-injection-in-action.md',
'aio/content/examples/dependency-injection-in-action/**',
'aio/content/images/guide/dependency-injection-in-action/**',
'aio/content/guide/dependency-injection-navtree.md',
'aio/content/guide/dependency-injection-providers.md',
docs: add lightweight token page to library section of docs (#36144) adds new DI technique recommendation for libraries to ensure tree-shaking for unused services includes reasons for packaging schematics with libraries, clarify schematic usage recommendation PR Close #36144
2020-03-19 11:40:36 -04:00
'aio/content/guide/lightweight-injection-tokens.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/guide/displaying-data.md',
'aio/content/examples/displaying-data/**',
'aio/content/images/guide/displaying-data/**',
'aio/content/guide/dynamic-component-loader.md',
'aio/content/examples/dynamic-component-loader/**',
'aio/content/images/guide/dynamic-component-loader/**',
'aio/content/guide/entry-components.md',
'aio/content/guide/feature-modules.md',
'aio/content/examples/feature-modules/**',
'aio/content/images/guide/feature-modules/**',
'aio/content/guide/frequent-ngmodules.md',
'aio/content/images/guide/frequent-ngmodules/**',
'aio/content/guide/hierarchical-dependency-injection.md',
'aio/content/examples/hierarchical-dependency-injection/**',
'aio/content/examples/providers-viewproviders/**',
'aio/content/examples/resolution-modifiers/**',
'aio/content/guide/lazy-loading-ngmodules.md',
'aio/content/examples/lazy-loading-ngmodules/**',
'aio/content/images/guide/lazy-loading-ngmodules/**',
'aio/content/guide/lifecycle-hooks.md',
'aio/content/examples/lifecycle-hooks/**',
'aio/content/images/guide/lifecycle-hooks/**',
'aio/content/examples/ngcontainer/**',
'aio/content/guide/ngmodules.md',
'aio/content/examples/ngmodules/**',
'aio/content/guide/ngmodule-api.md',
'aio/content/guide/ngmodule-faq.md',
'aio/content/guide/ngmodule-vs-jsmodule.md',
'aio/content/guide/module-types.md',
'aio/content/guide/template-syntax.md',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/built-in-template-functions.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/examples/built-in-template-functions/**',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/event-binding.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/examples/event-binding/**',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/interpolation.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/examples/interpolation/**',
'aio/content/examples/template-syntax/**',
'aio/content/images/guide/template-syntax/**',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/binding-syntax.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/examples/binding-syntax/**',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/property-binding.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/examples/property-binding/**',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/attribute-binding.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/examples/attribute-binding/**',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/two-way-binding.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/examples/two-way-binding/**',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/built-in-directives.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/examples/built-in-directives/**',
'aio/content/images/guide/built-in-directives/**',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/template-reference-variables.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/examples/template-reference-variables/**',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/inputs-outputs.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/examples/inputs-outputs/**',
'aio/content/images/guide/inputs-outputs/**',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/template-expression-operators.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/examples/template-expression-operators/**',
'aio/content/guide/pipes.md',
'aio/content/examples/pipes/**',
'aio/content/images/guide/pipes/**',
'aio/content/guide/providers.md',
'aio/content/examples/providers/**',
docs: add explanation for providedIn any (#35283) Angular 9 introduces a new value for providedIn called `any` which lets us use unique instance for servicec in each lazy loaded module, this PR is to document the same fixes #35179 PR Close #35283
2020-07-08 14:11:20 -04:00
'aio/content/images/guide/providers/**',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/guide/singleton-services.md',
'aio/content/guide/set-document-title.md',
'aio/content/examples/set-document-title/**',
'aio/content/images/guide/set-document-title/**',
'aio/content/guide/sharing-ngmodules.md',
'aio/content/guide/structural-directives.md',
'aio/content/examples/structural-directives/**',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/svg-in-templates.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/images/guide/structural-directives/**',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/template-statements.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/guide/user-input.md',
'aio/content/examples/user-input/**',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'aio/content/images/guide/user-input/**'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
- alxhub
- AndrewKushnir
refactor(dev-infra): add atscott for fw-core approvers (#37020) Add atscott (Andrew Scott) to the list of approvers in the fw-core section of the .pullapprove.yml file. PR Close #37020
2020-05-08 14:36:24 -04:00
- atscott
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 18:10:13 -04:00
- ~kara # do not request reviews from Kara, but allow her to approve PRs
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- mhevery
- pkozlowski-opensource
# =========================================================
# Framework: Http
# =========================================================
fw-http:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'packages/common/http/**',
'packages/examples/http/**',
'aio/content/guide/http.md',
'aio/content/examples/http/**',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'aio/content/images/guide/http/**'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
- alxhub
- IgorMinar
# =========================================================
# Framework: Elements
# =========================================================
fw-elements:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'packages/elements/**',
'aio/content/examples/elements/**',
'aio/content/images/guide/elements/**',
'aio/content/guide/elements.md'
])
reviewers:
users:
- andrewseguin
- gkalpak
# =========================================================
# Framework: Forms
# =========================================================
fw-forms:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'packages/forms/**',
'packages/examples/forms/**',
'aio/content/guide/forms.md',
'aio/content/examples/forms/**',
'aio/content/images/guide/forms/**',
'aio/content/guide/forms-overview.md',
'aio/content/examples/forms-overview/**',
'aio/content/images/guide/forms-overview/**',
'aio/content/guide/form-validation.md',
'aio/content/examples/form-validation/**',
'aio/content/images/guide/form-validation/**',
'aio/content/guide/dynamic-form.md',
'aio/content/examples/dynamic-form/**',
'aio/content/images/guide/dynamic-form/**',
'aio/content/guide/reactive-forms.md',
'aio/content/examples/reactive-forms/**',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'aio/content/images/guide/reactive-forms/**'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
- AndrewKushnir
# =========================================================
# Framework: i18n
# =========================================================
fw-i18n:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'packages/core/src/i18n/**',
'packages/core/src/render3/i18n.ts',
'packages/core/src/render3/i18n.md',
'packages/core/src/render3/interfaces/i18n.ts',
'packages/common/locales/**',
'packages/common/src/i18n/**',
'packages/common/src/pipes/date_pipe.ts',
'packages/common/src/pipes/i18n_plural_pipe.ts',
'packages/common/src/pipes/i18n_select_pipe.ts',
'packages/common/src/pipes/number_pipe.ts',
'packages/compiler/src/i18n/**',
'packages/compiler/src/render3/view/i18n/**',
'packages/compiler-cli/src/extract_i18n.ts',
'packages/localize/**',
'aio/content/guide/i18n.md',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'aio/content/examples/i18n/**'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
- AndrewKushnir
- mhevery
- petebacondarwin
# =========================================================
# Framework: Platform Server
# =========================================================
fw-platform-server:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'packages/platform-server/**',
'aio/content/guide/universal.md',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'aio/content/examples/universal/**'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
- alxhub
- kyliau
# =========================================================
# Framework: Router
# =========================================================
fw-router:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'packages/router/**',
'packages/examples/router/**',
'aio/content/guide/router.md',
docs: Add new section, tutorials, to left nav, and a tutorial on routing (#36545) This PR adds a new section, tutorials, to the left navigation. It also adds a new, basic tutorial for routing. PR Close #36545
2020-04-09 13:43:26 -04:00
'aio/content/guide/router-tutorial.md',
docs: Move router tutorial (toh) from router.md to new file (#37979) In an effort to make angular documentation easier for users to read, we are moving the router tutorial currently in router.md to a new file. To support this change, we have done the following: * Update files to fix any broken links caused by moving the file * Updated the new file to follow tutorial guidelines * Add the new file to the table of contents under, Tutorials. PR Close #37979
2020-07-08 11:29:41 -04:00
'aio/content/guide/router-tutorial-toh.md',
docs: Add new section, tutorials, to left nav, and a tutorial on routing (#36545) This PR adds a new section, tutorials, to the left navigation. It also adds a new, basic tutorial for routing. PR Close #36545
2020-04-09 13:43:26 -04:00
'aio/content/examples/router-tutorial/**',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/examples/router/**',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'aio/content/images/guide/router/**'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
- atscott
# =========================================================
# Framework: Service Worker
# =========================================================
build: fix typo in PullApprove group name (server-worker --> service-worker) (#36325) PR Close #36325
2020-03-30 10:35:21 -04:00
fw-service-worker:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'packages/service-worker/**',
'packages/examples/service-worker/**',
'aio/content/guide/service-worker-getting-started.md',
'aio/content/examples/service-worker-getting-started/**',
'aio/content/guide/app-shell.md',
'aio/content/guide/service-worker-communications.md',
'aio/content/guide/service-worker-config.md',
'aio/content/guide/service-worker-devops.md',
'aio/content/guide/service-worker-intro.md',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'aio/content/images/guide/service-worker/**'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
- alxhub
- gkalpak
- IgorMinar
# =========================================================
# Framework: Upgrade
# =========================================================
fw-upgrade:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'packages/upgrade/**',
'packages/common/upgrade/**',
'packages/examples/upgrade/**',
'aio/content/guide/upgrade.md',
'aio/content/examples/upgrade-lazy-load-ajs/**',
'aio/content/examples/upgrade-module/**',
'aio/content/images/guide/upgrade/**',
'aio/content/examples/upgrade-phonecat-1-typescript/**',
'aio/content/examples/upgrade-phonecat-2-hybrid/**',
'aio/content/examples/upgrade-phonecat-3-final/**',
'aio/content/guide/upgrade-performance.md',
'aio/content/guide/upgrade-setup.md',
'aio/content/guide/ajs-quick-reference.md',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'aio/content/examples/ajs-quick-reference/**'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
- gkalpak
- petebacondarwin
# =========================================================
# Framework: Testing
# =========================================================
fw-testing:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
ci: testing folders in compiler-cli should not require `fw-testing`approval (#37220) The `fw-testing` PullApprove group is really designed to capture the top level public testing API groups in packages like `common` and `router`. The compiler-cli also has some folders that contain the path segment `testing` but these should not require `fw-testing` PullApprove approval. This commit excludes the whole of `compiler-cli` package from the `fw-testing` group. PR Close #37220
2020-05-20 09:53:13 -04:00
contains_any_globs(files.exclude('packages/compiler-cli/**'), [
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'**/testing/**',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/guide/testing.md',
docs: break testing doc into multiple docs (#37957) This commit breaks up the testing document into nine total documents, with each document focusing on an existing section of the current testing documentation. There are no content changes. PR Close #37957
2020-06-30 14:14:34 -04:00
'aio/content/guide/test-debugging.md',
'aio/content/guide/testing-attribute-directives.md',
'aio/content/guide/testing-code-coverage.md',
'aio/content/guide/testing-components-basics.md',
'aio/content/guide/testing-components-scenarios.md',
'aio/content/guide/testing-pipes.md',
'aio/content/guide/testing-services.md',
'aio/content/guide/testing-utility-apis.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/examples/testing/**',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'aio/content/images/guide/testing/**'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
build: add AndrewKushnir to the `fw-testing` group (#36744) This commit update the PullApprove config to add AndrewKushnir to the `fw-testing` group. The reason for this change is that I was involved into TestBed rewrite (for Ivy) and it belongs to the `fw-testing` group ownership. PR Close #36744
2020-04-21 14:47:52 -04:00
- AndrewKushnir
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- IgorMinar
- pkozlowski-opensource
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 19:10:50 -05:00
# =========================================================
# Framework: Benchmarks
# =========================================================
fw-benchmarks:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 19:10:50 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 19:10:50 -05:00
- >
contains_any_globs(files, [
'modules/benchmarks/**'
])
reviewers:
users:
- IgorMinar
- pkozlowski-opensource
# =========================================================
# Framework: Playground
# =========================================================
fw-playground:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 19:10:50 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 19:10:50 -05:00
- >
contains_any_globs(files, [
'modules/playground/**'
])
reviewers:
users:
- IgorMinar
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 18:10:13 -04:00
- jelbourn
- pkozlowski-opensource
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 19:10:50 -05:00
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# =========================================================
# Framework: Security
# =========================================================
fw-security:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'packages/core/src/sanitization/**',
'packages/core/test/linker/security_integration_spec.ts',
'packages/compiler/src/schema/**',
'packages/platform-browser/src/security/**',
'aio/content/guide/security.md',
'aio/content/examples/security/**',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'aio/content/images/guide/security/**'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
- IgorMinar
- mhevery
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 18:10:13 -04:00
- jelbourn
- pkozlowski-opensource
reviews:
request: -1 # request reviews from everyone
required: 2 # require at least 2 approvals
reviewed_for: required
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# =========================================================
# Bazel
# =========================================================
bazel:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'packages/bazel/**',
])
reviewers:
users:
- IgorMinar
- josephperrott
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
- kyliau
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# =========================================================
# Language Service
# =========================================================
language-service:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'packages/language-service/**',
'aio/content/guide/language-service.md',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'aio/content/images/guide/language-service/**'
])
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
reviewers:
users:
ci: add ayazhafiz to ownership of language-service code (#35651) PR Close #35651
2020-02-24 12:34:47 -05:00
- ayazhafiz
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- kyliau
# =========================================================
# zone.js
# =========================================================
zone-js:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
docs: add documentation of NgZone with zone.js (#34295) PR Close #34295
2019-12-07 09:30:53 -05:00
'packages/zone.js/**',
'aio/content/guide/zone.md'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
- JiaLiPassion
- mhevery
build: import in-memory-web-api project (#37182) Moves the `angular-in-memory-web-api` project into the main repository in order to make it easier to maintain and release. PR Close #37182
2020-06-12 12:25:08 -04:00
# =========================================================
# in-memory-web-api
# =========================================================
in-memory-web-api:
conditions:
- *can-be-global-approved
- *can-be-global-docs-approved
- >
contains_any_globs(files, [
'packages/misc/angular-in-memory-web-api/**',
])
reviewers:
users:
- IgorMinar
- crisbeto
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# =========================================================
# Benchpress
# =========================================================
benchpress:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'packages/benchpress/**'
])
reviewers:
users:
- alxhub
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 18:10:13 -04:00
- josephperrott
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# =========================================================
# Integration Tests
# =========================================================
integration-tests:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'integration/**'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
- IgorMinar
- josephperrott
- mhevery
# =========================================================
# Docs: Gettings Started & Tutorial
# =========================================================
docs-getting-started-and-tutorial:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'aio/content/guide/setup-local.md',
'aio/content/images/guide/setup-local/**',
'aio/content/tutorial/**',
'aio/content/images/guide/toh/**',
'aio/content/examples/toh-pt0/**',
'aio/content/examples/toh-pt1/**',
'aio/content/examples/toh-pt2/**',
'aio/content/examples/toh-pt3/**',
'aio/content/examples/toh-pt4/**',
'aio/content/examples/toh-pt5/**',
'aio/content/examples/toh-pt6/**',
'aio/content/examples/getting-started-v0/**',
'aio/content/examples/getting-started/**',
'aio/content/start/**',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'aio/content/images/guide/start/**'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
- aikidave
- IgorMinar
ci: fix StephenFluin's casing in entries in PullApprove (#35062) PR Close #35062
2020-01-30 13:54:05 -05:00
- StephenFluin
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# =========================================================
# Docs: Marketing
# =========================================================
docs-marketing:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'aio/content/marketing/**',
'aio/content/images/bios/**',
'aio/content/images/marketing/**',
ci: add missing codeowners for `aio/` files (#34988) PR Close #34988
2020-01-27 05:51:17 -05:00
'aio/content/file-not-found.md',
'aio/content/license.md',
'aio/content/navigation.json'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
fix: add aikidave as reviewer for DOCS: Marketing (#37014) It makes sense that the lead technical writer should be allowed to approve changes to DOCS: Marketing. The inspriration for this change came to the current lead technical writer in a vision, or perhaps it was a fugue state caused by too little caffeine. No one knows. It's still a good idea though. PR Close #37014
2020-05-08 12:25:24 -04:00
- aikidave
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- IgorMinar
ci: fix StephenFluin's casing in entries in PullApprove (#35062) PR Close #35062
2020-01-30 13:54:05 -05:00
- StephenFluin
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# =========================================================
# Docs: Observables
# =========================================================
docs-observables:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'aio/content/guide/observables.md',
'aio/content/examples/observables/**',
'aio/content/guide/comparing-observables.md',
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 19:10:50 -05:00
'aio/content/examples/comparing-observables/**',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/guide/observables-in-angular.md',
'aio/content/examples/observables-in-angular/**',
'aio/content/guide/practical-observable-usage.md',
'aio/content/examples/practical-observable-usage/**',
'aio/content/guide/rx-library.md',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'aio/content/examples/rx-library/**'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
- alxhub
# =========================================================
# Docs: Packaging, Tooling, Releasing
# =========================================================
docs-packaging-and-releasing:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 19:10:50 -05:00
'docs/PUBLIC_API.md',
'docs/RELEASE_SCHEDULE.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/guide/npm-packages.md',
'aio/content/guide/browser-support.md',
'aio/content/guide/releases.md',
'aio/content/guide/updating.md',
'aio/content/guide/deprecations.md',
'aio/content/guide/migration-renderer.md',
'aio/content/guide/migration-undecorated-classes.md',
'aio/content/guide/migration-dynamic-flag.md',
'aio/content/guide/migration-injectable.md',
'aio/content/guide/migration-localize.md',
'aio/content/guide/migration-module-with-providers.md',
'aio/content/guide/static-query-migration.md',
docs: Initial commit of update guide for v10 release. (#37152) This update includes modifications to the navigation.json file to remove unneeded migration guides. TODO: Redirects from v9 topics to v10; links to removed migration guides need to point to v9.angular.io. PR Close #37152
2020-05-15 20:58:55 -04:00
'aio/content/guide/updating-to-version-10.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/guide/ivy-compatibility.md',
'aio/content/guide/ivy-compatibility-examples.md'
])
reviewers:
users:
- IgorMinar
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 18:10:13 -04:00
- jelbourn
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
ci: special case tooling-cli-shared-api review group (#37467) The new tooling-cli-shared-api is used to guard changes to packages/compiler-cli/src/tooling.ts which is a private API sharing channel between Angular FW and CLI. Changes to this file should be rare and explicitly approved by at least two members of the CLI team. PR Close #37467
2020-06-05 19:27:53 -04:00
# =========================================================
# Tooling: Compiler API shared with Angular CLI
#
# Changing this API might break Angular CLI, so we require
# the CLI team to approve changes here.
# =========================================================
tooling-cli-shared-api:
conditions:
- *can-be-global-approved
- *can-be-global-docs-approved
- >
contains_any_globs(files, [
'packages/compiler-cli/src/tooling.ts'
])
reviewers:
users:
- alan-agius4
- clydin
- kyliau
- IgorMinar
reviews:
request: -1 # request reviews from everyone
required: 2 # require at least 2 approvals
reviewed_for: required
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# =========================================================
# Docs: CLI
# =========================================================
docs-cli:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
ci: add missing codeowners for `aio/` files (#34988) PR Close #34988
2020-01-27 05:51:17 -05:00
'aio/content/cli/**',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'aio/content/guide/typescript-configuration.md',
'aio/content/examples/setup/**',
'aio/content/guide/build.md',
'aio/content/images/guide/build/**',
'aio/content/guide/cli-builder.md',
'aio/content/examples/cli-builder/**',
'aio/content/guide/deployment.md',
'aio/content/images/guide/deployment/**',
'aio/content/guide/file-structure.md',
'aio/content/guide/ivy.md',
docs: add strict-mode.md file to pullapprove (#37679) When I created the strict-mode.md file, I didn't add it to the pullapprove list. Now it's there. The issue was introduced in #37486. PR Close #37679
2020-06-22 20:15:10 -04:00
'aio/content/guide/strict-mode.md',
feat(dev-infra): pullapprove verify should handle `files` in conditions (#36661) Currently, when verifying our pullapprove configuration, we don't respect modifications to the set of files in a condition. e.g. It's not possible to do the following: ``` contains_any_globs(files.exclude(...), [ ``` This prevents us from having codeowner groups which match a directory, but want to filter out specific sub directories. For example, `fw-core` matches all files in the core package. We want to exclude the schematics from that glob. Usually we do this by another exclude condition. This has a *significant* downside though. It means that fw-core will not be requested if a PR changes schematic code, _and_ actual fw-core code. To support these conditions, the pullapprove verification tool is refactored, so that it no longer uses Regular expressions for parsing, but rather evaluates the code through a dynamic function. This is possible since the conditions are written in simple Python that can be run in NodeJS too (with small modifications/transformations). PR Close #36661
2020-04-16 14:12:25 -04:00
'aio/content/guide/web-worker.md',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'aio/content/guide/workspace-config.md',
docs: add solution-style tsconfig migration docs (#37512) This adds documentation for the v10.0 tooling migration `solution-style-tsconfig` contained within the `@schematics/angular` package. PR Close #37512
2020-06-08 21:41:50 -04:00
'aio/content/guide/migration-solution-style-tsconfig.md',
docs: add module/target compiler option migration docs (#37429) This adds documentation for the v10.0 tooling migration `update-module-and-target-compiler-options` contained within the `@schematics/angular` package. PR Close #37429
2020-06-03 22:12:59 -04:00
'aio/content/guide/migration-update-module-and-target-compiler-options.md',
docs: add tslib update migration docs (#37402) This adds documentation for the v10.0 tooling migration `update-libraries-tslib` contained within the `@schematics/angular` package. PR Close #37402
2020-06-02 14:37:27 -04:00
'aio/content/guide/migration-update-libraries-tslib.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
- clydin
- IgorMinar
- mgechev
# =========================================================
# Docs: CLI Libraries
# =========================================================
docs-libraries:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'aio/content/guide/creating-libraries.md',
'aio/content/guide/libraries.md',
'aio/content/guide/using-libraries.md'
])
reviewers:
users:
- alan-agius4
- IgorMinar
- mgechev
# =========================================================
# Docs: Schematics
# =========================================================
docs-schematics:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'aio/content/guide/schematics.md',
'aio/content/guide/schematics-authoring.md',
'aio/content/guide/schematics-for-libraries.md',
'aio/content/images/guide/schematics/**',
'aio/content/examples/schematics-for-libraries/**'
])
reviewers:
users:
- alan-agius4
- IgorMinar
- mgechev
# =========================================================
# Docs-infra
# =========================================================
docs-infra:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
- *can-be-global-docs-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'aio/*',
'aio/aio-builds-setup/**',
ci: add missing codeowners for `aio/` files (#34988) PR Close #34988
2020-01-27 05:51:17 -05:00
'aio/content/cli-src/**',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/examples/*',
'aio/scripts/**',
'aio/src/**',
'aio/tests/**',
'aio/tools/**',
'aio/content/guide/docs-style-guide.md',
'aio/content/examples/docs-style-guide/**',
'aio/content/images/guide/docs-style-guide/**',
build(docs-infra): remove unused `ngmodule-faq` and `visual-studio-2015` examples (#36015) PR Close #36015
2020-03-17 16:28:33 -04:00
'aio/content/guide/visual-studio-2015.md'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
- gkalpak
- IgorMinar
- petebacondarwin
# =========================================================
# Dev-infra
# =========================================================
dev-infra:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
ci(compiler-cli): exempt compiler-cli .bazel files from dev-infra approval (#37558) Previously, dev-infra approval (via PullApprove) was required for all .bazel files in the monorepo, including those in packages/compiler-cli. The compiler-cli package is a little special in this sense: * it's not shipped to NPM in the APF * it uses lots of internal subpackages to organize and test its code As a result: * changes to compiler-cli BUILD.bazel files are not user visible and don't have larger implications for the packages published to NPM, unlike changes to other BUILD.bazel files in the repo * the requirement for dev-infra approval for BUILD.bazel changes is overly burdensome, because compiler-cli build files change more rapidly than those of other packages. This commit exempts the compiler-cli's build files from the requirement for dev-infra approval. It will be sufficient for such files to be approved by the normal compiler reviewers. PR Close #37558
2020-06-12 13:34:26 -04:00
contains_any_globs(files.exclude("CHANGELOG.md").exclude("packages/compiler-cli/**/BUILD.bazel"), [
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'*',
'.circleci/**',
'.devcontainer/**',
'.github/**',
build: migrate ng-dev config to .ng-dev directory (#37142) Migrate to using .ng-dev directory for ng-dev configuration to allow better management of the configuration using multiple files. The intention is to prevent the config file from becoming unruly. PR Close #37142
2020-05-15 17:19:08 -04:00
'.ng-dev/**',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'.vscode/**',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'.yarn/**',
build: create dev-infra-private npm package (#35862) Creates the scaffolding for an @angular/dev-infra-private package which will not be published to npm but will be pushed to https://github.com/angular/dev-infra-private-builds repo for each commit to master. The contents of this npm package will then be depended on via package.json dependency for angular/angular angular/angular-cli and angular/components. PR Close #35862
2020-03-04 12:42:45 -05:00
'dev-infra/**',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'docs/BAZEL.md',
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 19:10:50 -05:00
'docs/CARETAKER.md',
docs: create coding standards doc (#37700) Create initial document for Angular framework coding standards. This document will evolve over time. This version contains all non-controversial rules as discussed in a recent team meeting. Some text and examples were copied from angular/components. PR Close #37700
2020-06-24 01:32:40 -04:00
'docs/CODING_STANDARDS.md',
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 19:10:50 -05:00
'docs/COMMITTER.md',
'docs/DEBUG.md',
'docs/DEBUG_COMPONENTS_REPO_IVY.md',
'docs/DEVELOPER.md',
'docs/GITHUB_PROCESS.md',
'docs/PR_REVIEW.md',
'docs/SAVED_REPLIES.md',
'docs/TOOLS.md',
'docs/TRIAGE_AND_LABELS.md',
ci: move public-api goldens to goldens directory (#35768) Moves the public api .d.ts files from tools/public_api_guard to goldens/public-api. Additionally, provides a README in the goldens directory and a script assist in testing the current state of the repo against the goldens as well as a command for accepting all changes to the goldens in a single command. PR Close #35768
2020-02-26 12:09:35 -05:00
'goldens/*',
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 19:10:50 -05:00
'modules/*',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'packages/*',
'packages/examples/test-utils/**',
'packages/private/**',
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 19:10:50 -05:00
'packages/examples/*',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'scripts/**',
'third_party/**',
'tools/build/**',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'tools/circular_dependency_test/**',
build: creates a script to get contributor stats from across the angular org (#35834) This script gets all of the current users for the organization and retrieves information about PR/Issue contributions/authorship since a provided date. Returning this information as a CSV. PR Close #35834
2020-03-03 13:16:18 -05:00
'tools/contributing-stats/**',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'tools/gulp-tasks/**',
'tools/npm/**',
build: add npm_integration_test && angular_integration_test (#33927) * it's tricky to get out of the runfiles tree with `bazel test` as `BUILD_WORKSPACE_DIRECTORY` is not set but I employed a trick to read the `DO_NOT_BUILD_HERE` file that is one level up from `execroot` and that contains the workspace directory. This is experimental and if `bazel test //:test.debug` fails than `bazel run` is still guaranteed to work as `BUILD_WORKSPACE_DIRECTORY` will be set in that context * test //integration:bazel_test and //integration:bazel-schematics_test exclusively * run "exclusive" and "manual" bazel-in-bazel integration tests in their own CI job as they take 8m+ to execute ``` //integration:bazel-schematics_test PASSED in 317.2s //integration:bazel_test PASSED in 167.8s ``` * Skip all integration tests that are now handled by angular_integration_test except the tests that are tracked for payload size; these are: - cli-hello-world* - hello_world__closure * add & pin @babel deps as newer versions of babel break //packages/localize/src/tools/test:test @babel/core dep had to be pinned to 7.6.4 or else //packages/localize/src/tools/test:test failed. Also //packages/localize uses @babel/generator, @babel/template, @babel/traverse & @babel/types so these deps were added to package.json as they were not being hoisted anymore from @babel/core transitive. NB: integration/hello_world__systemjs_umd test must run with systemjs 0.20.0 NB: systemjs must be at 0.18.10 for legacy saucelabs job to pass NB: With Bazel 2.0, the glob for the files to test `"integration/bazel/**"` is empty if integation/bazel is in .bazelignore. This glob worked under these conditions with 1.1.0. I did not bother testing with 1.2.x as not having integration/bazel in .bazelignore is correct. PR Close #33927
2020-02-04 14:45:40 -05:00
'tools/npm_integration_test/**',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'tools/rxjs/**',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'tools/saucelabs/**',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'tools/size-tracking/**',
'tools/source-map-test/**',
'tools/symbol-extractor/**',
'tools/testing/**',
'tools/ts-api-guardian/**',
'tools/tslint/**',
ci: update pullapprove config to ensure complete coverage of files (#35060) PR Close #35060
2020-02-12 12:50:30 -05:00
'tools/utils/**',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'tools/yarn/**',
'tools/*',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
'**/*.bzl',
'**/*.bazel'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
])
reviewers:
users:
- devversion
- filipesilva
- gkalpak
- IgorMinar
- josephperrott
# =========================================================
# Public API
# =========================================================
public-api:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
ci: move public-api goldens to goldens directory (#35768) Moves the public api .d.ts files from tools/public_api_guard to goldens/public-api. Additionally, provides a README in the goldens directory and a script assist in testing the current state of the repo against the goldens as well as a command for accepting all changes to the goldens in a single command. PR Close #35768
2020-02-26 12:09:35 -05:00
'goldens/public-api/**',
build: move CHANGELOG to public-api approval group (#37143) Previously, the CHANGELOG file was caught under the general "*" glob, which meant that it fell under the dev-infra approval group. This does not really make sense since it has more to do with public-facing changes. As such, this commit moves the CHANGELOG file specifically to the public-api approval group. PR Close #37143
2020-05-15 18:00:33 -04:00
'CHANGELOG.md',
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 19:10:50 -05:00
'docs/NAMING.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
'aio/content/guide/glossary.md',
'aio/content/guide/styleguide.md',
'aio/content/examples/styleguide/**',
'aio/content/images/guide/styleguide/*'
])
reviewers:
users:
ci: add more owners for limited categories (#38170) * Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to #37994 PR Close #38170
2020-07-21 21:43:05 -04:00
- AndrewKushnir
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- IgorMinar
ci: add more owners for some categories (#37994) * Add petebacondarwin to public-api, size-tracking, and circular-dependencies * Add mhevery, josephperrott, and jelbourn to code-ownership PR Close #37994
2020-07-15 14:47:26 -04:00
- alxhub
ci: add more owners for limited categories (#38170) * Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to #37994 PR Close #38170
2020-07-21 21:43:05 -04:00
- atscott
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 18:10:13 -04:00
- jelbourn
ci: add more owners for some categories (#37994) * Add petebacondarwin to public-api, size-tracking, and circular-dependencies * Add mhevery, josephperrott, and jelbourn to code-ownership PR Close #37994
2020-07-15 14:47:26 -04:00
- petebacondarwin
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 18:10:13 -04:00
- pkozlowski-opensource
reviews:
ci: add more owners for limited categories (#38170) * Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to #37994 PR Close #38170
2020-07-21 21:43:05 -04:00
request: 4 # Request reviews from four people
required: 3 # Require that three people approve
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 18:10:13 -04:00
reviewed_for: required
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# ================================================
# Size tracking
# ================================================
size-tracking:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
ci: migrate payload size tracking goldens to the golden directory (#36455) This change is part of a larger effort to migrate all golden type tracking files to a single location. Additionally, this makes it a bit easier to manage file ownership in pullapprove. PR Close #36455
2020-04-06 12:42:02 -04:00
'goldens/size-tracking/**'
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 15:52:49 -05:00
])
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
reviewers:
users:
ci: add more owners for limited categories (#38170) * Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to #37994 PR Close #38170
2020-07-21 21:43:05 -04:00
- AndrewKushnir
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- IgorMinar
ci: add more owners for some categories (#37994) * Add petebacondarwin to public-api, size-tracking, and circular-dependencies * Add mhevery, josephperrott, and jelbourn to code-ownership PR Close #37994
2020-07-15 14:47:26 -04:00
- alxhub
ci: add more owners for limited categories (#38170) * Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to #37994 PR Close #38170
2020-07-21 21:43:05 -04:00
- atscott
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 18:10:13 -04:00
- jelbourn
ci: add more owners for some categories (#37994) * Add petebacondarwin to public-api, size-tracking, and circular-dependencies * Add mhevery, josephperrott, and jelbourn to code-ownership PR Close #37994
2020-07-15 14:47:26 -04:00
- petebacondarwin
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 18:10:13 -04:00
- pkozlowski-opensource
reviews:
ci: add more owners for limited categories (#38170) * Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to #37994 PR Close #38170
2020-07-21 21:43:05 -04:00
request: 4 # Request reviews from four people
required: 2 # Require that two people approve
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 18:10:13 -04:00
reviewed_for: required
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
ci: set up golden file for typescript circular dependencies (#35647) Sets up a golden file for the TypeScript circular dependencies for source files inside of the `packages/` folder. Also sets up the appropriate Yarn shorthand scripts, and a codeowner group that is soley responsible for verifying changes to the golden. PR Close #35647
2020-02-24 06:08:24 -05:00
# ================================================
# Circular dependencies
# ================================================
circular-dependencies:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: set up golden file for typescript circular dependencies (#35647) Sets up a golden file for the TypeScript circular dependencies for source files inside of the `packages/` folder. Also sets up the appropriate Yarn shorthand scripts, and a codeowner group that is soley responsible for verifying changes to the golden. PR Close #35647
2020-02-24 06:08:24 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
ci: set up golden file for typescript circular dependencies (#35647) Sets up a golden file for the TypeScript circular dependencies for source files inside of the `packages/` folder. Also sets up the appropriate Yarn shorthand scripts, and a codeowner group that is soley responsible for verifying changes to the golden. PR Close #35647
2020-02-24 06:08:24 -05:00
- >
contains_any_globs(files, [
build: move circular deps golden to a subfolder (#36630) Moves the circular deps golden for packages into a subfolder of goldens, `/goldens/circular-deps/` to more easily target the files for ownership. PR Close #36630
2020-04-14 16:37:54 -04:00
'goldens/circular-deps/packages.json'
ci: set up golden file for typescript circular dependencies (#35647) Sets up a golden file for the TypeScript circular dependencies for source files inside of the `packages/` folder. Also sets up the appropriate Yarn shorthand scripts, and a codeowner group that is soley responsible for verifying changes to the golden. PR Close #35647
2020-02-24 06:08:24 -05:00
])
reviewers:
users:
ci: add more owners for limited categories (#38170) * Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to #37994 PR Close #38170
2020-07-21 21:43:05 -04:00
- AndrewKushnir
ci: set up golden file for typescript circular dependencies (#35647) Sets up a golden file for the TypeScript circular dependencies for source files inside of the `packages/` folder. Also sets up the appropriate Yarn shorthand scripts, and a codeowner group that is soley responsible for verifying changes to the golden. PR Close #35647
2020-02-24 06:08:24 -05:00
- IgorMinar
ci: add more owners for limited categories (#38170) * Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to #37994 PR Close #38170
2020-07-21 21:43:05 -04:00
- alxhub
- atscott
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 18:10:13 -04:00
- jelbourn
ci: add more owners for some categories (#37994) * Add petebacondarwin to public-api, size-tracking, and circular-dependencies * Add mhevery, josephperrott, and jelbourn to code-ownership PR Close #37994
2020-07-15 14:47:26 -04:00
- petebacondarwin
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 18:10:13 -04:00
- pkozlowski-opensource
ci: set up golden file for typescript circular dependencies (#35647) Sets up a golden file for the TypeScript circular dependencies for source files inside of the `packages/` folder. Also sets up the appropriate Yarn shorthand scripts, and a codeowner group that is soley responsible for verifying changes to the golden. PR Close #35647
2020-02-24 06:08:24 -05:00
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
####################################################################################
# Special Cases
####################################################################################
# =========================================================
# Code Ownership
# =========================================================
code-ownership:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 11:25:39 -04:00
- *can-be-global-approved
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- >
contains_any_globs(files, [
'.pullapprove.yml'
])
reviewers:
users:
ci: add more owners for limited categories (#38170) * Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to #37994 PR Close #38170
2020-07-21 21:43:05 -04:00
- AndrewKushnir
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
- IgorMinar
ci: add more owners for limited categories (#38170) * Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to #37994 PR Close #38170
2020-07-21 21:43:05 -04:00
- alxhub
- atscott
ci: add more owners for some categories (#37994) * Add petebacondarwin to public-api, size-tracking, and circular-dependencies * Add mhevery, josephperrott, and jelbourn to code-ownership PR Close #37994
2020-07-15 14:47:26 -04:00
- jelbourn
- josephperrott
- mhevery
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
# ====================================================
# Catch all for if no groups match the code change
# ====================================================
fallback:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 11:20:24 -04:00
<<: *defaults
ci: remove IgorMinar from reviewers list for pullapprove fallback group (#36456) Historically we have had a pullapprove group `fallback` which acted as a catch all for files which did not match any other groups. This group assigned reviews to IgorMinar, however it was not apparent that this group was assigned. This change removes this assignment. This group as active should always coincide with failures of the pullapprove verification script. We continue to have this group as a secondary test ensuring all files in the repo are captured by the pullapprove config. PR Close #36456
2020-04-06 14:03:40 -04:00
# A group is considered to be `active` for a PR if at least one of group's
# conditions matches the PR.
#
# The PullApprove CI check should fail if a PR has no `active` groups, as
# this indicates the PR is modifying a file that has no owner.
#
# This is enforced through the pullapprove verification check done
# as part of the CircleCI lint job. Failures in this lint job should be
# fixed as part of the PR. This can be done by updating the
# `.pullapprove.yml` file cover the unmatched path.
# The pullapprove verification script is part of the ng-dev tool and can be
# run locally with the command: `yarn -s ng-dev pullapprove verify`
#
# For cases in which the verification check fails to ensure coverage, this
# group will be active. The expectation is that this should be remedied
# before merging the PR as described above. In an emergency situation
# `global-approvers` can still approve PRs that match this `fallback` rule,
# but that should be an exception and not an expectation.
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 11:39:09 -05:00
conditions:
refactor(dev-infra): create anchors/aliases for excluded always active groups (#37798) global-approvers, global-docs-approvers, and required-minimum-review groups are always active. It's useful to have aliases for getting groups that are active/pending/rejected while excluding these few. PR Close #37798
2020-06-27 15:47:54 -04:00
- *no-groups-above-this-active
build: determine pullapprove fallback with better active group counting (#37636) Previously, the fallback group simply determined its active state based on the of active groups during processing. Instead, we should consider if there are any active groups after excluding the ones we don't want to be considered, i.e. the minimum required review group and the global approval groups. This allows for an explicit test of the active groups that exist rather than a prone to get out of date number of expected active groups. With this change, we additionally need to check to ensure that global approvals have not caused other groups to no longer be active, causing a false case of no active groups, when they have simply been superceded by a global approval. PR Close #37636
2020-06-18 11:30:42 -04:00
# When any of the `global-*` groups is approved, they cause other groups to deactivate.
# In those cases, the condition above would evaluate to `true` while in reality, only a global
# approval has been provided. To ensure we don't activate the fallback group in such cases,
# ensure that no explicit global approval has been provided.
- *can-be-global-approved
- *can-be-global-docs-approved