Commit Graph

692 Commits

Author SHA1 Message Date
James Agnew 5132f1f4ed COnfirm validation support comntains codesystem 2019-05-02 07:50:59 -04:00
James Agnew 37b9e1a42c Improve validation of enableWhen questionnaires 2019-04-29 14:43:42 -04:00
Matti Uusitalo b95b4cf110 Merge with master 2019-04-25 10:44:07 +03:00
James Agnew 738c2c1797
Interceptor framework refactoring (#1287)
Interceptor framework overhaul
2019-04-24 14:32:30 -04:00
James Agnew 210d99d121 Correct validation of questionnaire enableWhen 2019-04-17 16:50:37 -04:00
patrick-werner 41a032ae9f added more missing methods 2019-03-30 15:36:06 +01:00
patrick-werner 2f3ac9d734 added missing method 2019-03-30 15:21:01 +01:00
Matti Uusitalo 5e0996d8ff Better method comment 2019-03-05 12:00:56 +02:00
Matti Uusitalo 9549a1615c Merge with origin/master 2019-03-05 11:44:30 +02:00
James Agnew 48c10bddc5
Narrative Generator refactoring (#1219)
* Starting work on this

* Working on narrative templates

* Work on new narrative system

* Account for some failing tests due to refactoring of narrative mode

* Another test fix

* More test fixes

* One more test fix

* Work on searches

* Address review comments
2019-02-27 14:59:57 -05:00
James Agnew 0f8c8d18e2 Bump version to 3.8.0-SNAPSHOT 2019-02-06 20:02:28 -05:00
jamesagnew 207015c3af Version bump to 3.7.0 2019-02-05 21:36:38 -05:00
James Agnew 9a8e3245b8 Build fixes 2019-02-05 15:00:36 -05:00
James Agnew 47123196a0 Merge branch 'master' of https://github.com/eevaturkka/hapi-fhir into eevaturkka-master 2019-02-05 14:26:41 -05:00
Eeva Turkka be746854e5 version number for release 2019-01-31 15:42:37 +02:00
Eeva Turkka 1c9f7f7ca9 Version number changed for build 2019-01-31 13:26:13 +02:00
Eeva Turkka 7e7d4d8879 Allowing items without answers even if item is disabled. 2019-01-31 13:00:41 +02:00
Eeva Turkka e6df4a21e4 Merge branch 'enablewhen_fix' of https://github.com/eevaturkka/hapi-fhir into enablewhen_fix 2019-01-28 10:31:44 +02:00
James Agnew 4f16fea580 Fix compile error 2018-12-28 12:11:19 -05:00
James Agnew 14a132a937 Squashed commit of the following:
commit 9659655830
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu Dec 27 17:54:25 2018 -0500

    Finish sync

commit 70da25b76f
Author: jamesagnew <jamesagnew@gmail.com>
Date:   Thu Dec 27 10:32:51 2018 -0500

    Work on RI4 sync
2018-12-27 17:58:47 -05:00
James Agnew a0cb7edd08 Version bump a few dependencies 2018-12-22 20:13:03 -05:00
Ken Stevens 84a34eb3c9
Subscription module support (#1147)
* Reorganizing packages and dependencies to support standalone subscription running within a CDR container where all hapi modules are on the classpath.

Moved Subscription registry out of interceptor and introduced SubscriptionLoader

* Created ActiveSubscription and moved cache bits into it

* Moved ExecutorQueue stuff out into its own class

* Add test and supporting code to validate SubscriptionConstants.EXT_SUBSCRIPTION_RESTHOOK_DELIVER_LATEST_VERSION behaviour

* Added SubscriptionCheckingSubscriber

* Moved a few beans to @ComponentScan

* Replaced use of beanFactory with concrete factory classes

* Switched test to use subscribablechannel

* Added SubscriptionLoaderFhirClientTest

* Confirm that our SubscriptionProviderFhirClient works with a live fhir client

* Register interceptors with DaoConfig instead of RestServer.
Also, Rename @VisibleForTesting methods with ForUnitTest

* Fix triggering service so it uses new subscriptionmatcherinterceptor

* Renamed "Database" classes to "Dao"

* processing -> matching naming change
2018-12-18 13:09:06 -05:00
Matti Uusitalo a3e7f5b18f Corrected group ids back to ca.uhn.hapi.fhir 2018-12-18 11:21:29 +02:00
Matti Uusitalo 01eb7faf66 Deleted unnecessary Inteface class 2018-12-18 10:15:47 +02:00
Matti Uusitalo 98f929997b Sync with upstream/master 2018-12-17 15:38:05 +02:00
Matti Uusitalo 7ad45308e0 Make this configurable 2018-12-17 14:10:15 +02:00
Matti Uusitalo 89e3cac0e2 Corrected problems caused by merge 2018-12-17 13:55:15 +02:00
Matti Uusitalo 8183c18406 Corrected project dependency version numberts 2018-12-17 13:54:43 +02:00
Matti Uusitalo 58959eec48 Do not force enableWhen to have system 2018-12-17 13:31:07 +02:00
Matti Uusitalo dd8e027ff4 Don't evaluate Extensions when determining type of answer 2018-12-17 13:31:07 +02:00
Matti Uusitalo a1f79a2063 Filter Extensions from enablewhen evaluation 2018-12-17 13:31:07 +02:00
Matti Uusitalo 755eaa5f25 bumped version n. for release 2018-12-17 13:31:07 +02:00
Matti Uusitalo c2b3d48afe Support required questionnaireitem groups 2018-12-17 13:31:07 +02:00
Matti Uusitalo a0db7e20b6 temporarily set hard coded error when no profile found 2018-12-17 13:30:36 +02:00
Matti Uusitalo cefacdc18c Returned to original state as the experiment failed 2018-12-17 13:30:36 +02:00
Matti Uusitalo 24ebe6cf03 Temporarily set isNoTerminologyServer() return true to avoid errors about loinc codes 2018-12-17 13:30:36 +02:00
Matti Uusitalo 311d92f276 Added more information to the error message about misplaced QuestionnaireResponseItem 2018-12-17 13:30:36 +02:00
Eeva Turkka 076d18977d Added support for Quantity in the default enable when evaluator 2018-12-17 13:30:36 +02:00
Matti Uusitalo b29e8d987c Avoid infinite loop when validating misaligned questionnaireresponseitems 2018-12-17 13:27:27 +02:00
Matti Uusitalo a9c625365d Added missing propagation of QuestionnaireResponse root element 2018-12-17 13:27:27 +02:00
Matti Uusitalo ab484c9819 Thread questionnaireResponse root element through questionnaire validation so implementations of enablewhen may validate against the complete resource 2018-12-17 13:27:27 +02:00
Matti Uusitalo 10fe878540 Changed versions to use fi.kela.kanta.phr parent 2018-12-17 13:27:27 +02:00
Matti Uusitalo e84689b167 Way to inject custom enablewhen evaluator added 2018-12-17 13:27:27 +02:00
Matti Uusitalo 507c78320c Added check for answering questions which are not enabled 2018-12-17 13:27:27 +02:00
Matti Uusitalo d2c6a98c24 Removed unused HapiWorkerContext 2018-12-17 13:27:27 +02:00
Okko Kauhanen a12f5892e2 Added operator evaluation for R4 enableWhen 2018-12-17 13:26:31 +02:00
Eeva Turkka 69d9e5d2b2 Unit tests up to date and maybe we need to use r4 path 2018-12-17 13:15:43 +02:00
Eeva Turkka 84c02d2e79 Cherry picked changes from master to 3.5.0 branch 2018-12-17 13:13:38 +02:00
Matti Uusitalo 3c56640d57 Do not force enableWhen to have system 2018-12-17 12:48:53 +02:00
Matti Uusitalo 73e85ce668 Don't evaluate Extensions when determining type of answer 2018-12-17 12:48:53 +02:00
Matti Uusitalo 14b5d88530 Filter Extensions from enablewhen evaluation 2018-12-17 12:48:53 +02:00
Matti Uusitalo 4956c9c7e0 bumped version n. for release 2018-12-17 12:48:53 +02:00
Matti Uusitalo c04a172fcd Support required questionnaireitem groups 2018-12-17 12:48:53 +02:00
Matti Uusitalo e13bc28b42 temporarily set hard coded error when no profile found 2018-12-17 12:45:51 +02:00
Matti Uusitalo 3f21bfb560 Returned to original state as the experiment failed 2018-12-17 12:45:51 +02:00
Matti Uusitalo 154a1d92e0 Temporarily set isNoTerminologyServer() return true to avoid errors about loinc codes 2018-12-17 12:45:51 +02:00
Matti Uusitalo c86ae90c4d Added more information to the error message about misplaced QuestionnaireResponseItem 2018-12-17 12:45:51 +02:00
Eeva Turkka 074e812162 Added support for Quantity in the default enable when evaluator 2018-12-17 12:45:51 +02:00
Matti Uusitalo 94f0520982 Avoid infinite loop when validating misaligned questionnaireresponseitems 2018-12-17 12:43:43 +02:00
Matti Uusitalo a6b0cb2a6e Added missing propagation of QuestionnaireResponse root element 2018-12-17 12:43:43 +02:00
Matti Uusitalo fa0b61d9b8 Thread questionnaireResponse root element through questionnaire validation so implementations of enablewhen may validate against the complete resource 2018-12-17 12:43:43 +02:00
Matti Uusitalo a981452957 Reverted to original version 2018-12-17 12:43:43 +02:00
Matti Uusitalo b7843498dc Changed versions to use fi.kela.kanta.phr parent 2018-12-17 12:43:43 +02:00
Matti Uusitalo 76eb85308c Way to inject custom enablewhen evaluator added 2018-12-17 12:43:43 +02:00
Matti Uusitalo 78ab112204 Added check for answering questions which are not enabled 2018-12-17 12:43:43 +02:00
Matti Uusitalo 16a4004f02 Removed unused HapiWorkerContext 2018-12-17 12:43:43 +02:00
Matti Uusitalo e7e039a851 Added default enablewhen behaviour to STU3 resources converted to R4 2018-12-17 12:43:43 +02:00
Okko Kauhanen 8f338c1b63 Remove unnecessary throw 2018-12-17 12:43:43 +02:00
Okko Kauhanen 4fff5ee27a Fixed bug in finding QuestionnaireResponse child items 2018-12-17 12:43:43 +02:00
Okko Kauhanen cddb6b993c Added operator evaluation for R4 enableWhen 2018-12-17 12:43:43 +02:00
Okko Kauhanen 6a83a3fb59 fix enablewhen result 2018-12-17 12:42:29 +02:00
Okko Kauhanen 275cc9556f Missing file 2018-12-17 12:42:29 +02:00
Okko Kauhanen 48db1d8770 First implementation of enableWhen evaluator 2018-12-17 12:42:29 +02:00
Eeva Turkka ad11409705 Unit tests up to date and maybe we need to use r4 path 2018-12-17 12:42:29 +02:00
Eeva Turkka 7097526f81 Cherry picked changes from master to 3.5.0 branch 2018-12-17 12:41:05 +02:00
James Agnew 46f5c18adc Prepare for 3.6.0 release 2018-12-17 12:32:33 +02:00
Matti Uusitalo b262985e21 Do not force enableWhen to have system 2018-12-13 13:29:17 +02:00
hdconradi 89ede0e524 Extension domains configuration for the fhr instance validator (#917)
* Fix the url of the StructureDefinition extensions

http://hl7.org/fhir/tools/StructureDefinition/ -> http://hl7.org/fhir/StructureDefinition/
That makes the entry for the structuredefinition-expression superfluous.

The url behind IG_DEPENDSON_PACKAGE_EXTENSION does not point is not (yet?) valid too.

* Add ability to configure custom extension domains.

* Testing the extension domains configuration

* Fix obvious bug when determining resource name

The for loop was completely superfluous beforehand.
Either fix it as e.g. in this patch or remove it.

* small improvements and TODO's for possible NPE's

- javadoc see
- use diamond operator for generics
- remove throws clause when exception is not thrown
- add TODO's for some cases a NPE might occur.
  My knowledge of the context is not sufficient to suggest the proper
  way to solve this.
2018-12-13 05:32:47 -05:00
Matti Uusitalo c85f4b8362 Don't evaluate Extensions when determining type of answer 2018-12-13 12:12:56 +02:00
Matti Uusitalo 82387e6902 Filter Extensions from enablewhen evaluation 2018-12-12 14:22:38 +02:00
Matti Uusitalo 3df4004539 bumped version n. for release 2018-12-11 11:17:40 +02:00
Matti Uusitalo 64f378ae78 Support required questionnaireitem groups 2018-12-10 13:58:14 +02:00
Matti Uusitalo b2e20b5c31 temporarily set hard coded error when no profile found 2018-12-10 13:57:04 +02:00
Matti Uusitalo 5a508f45b9 Returned to original state as the experiment failed 2018-12-10 13:52:38 +02:00
Matti Uusitalo f72fbbe402 Temporarily set isNoTerminologyServer() return true to avoid errors about loinc codes 2018-12-10 13:52:38 +02:00
Matti Uusitalo b922670d97 Added more information to the error message about misplaced QuestionnaireResponseItem 2018-12-10 13:52:38 +02:00
Eeva Turkka efbff93247 Added support for Quantity in the default enable when evaluator 2018-12-10 13:52:38 +02:00
Matti Uusitalo d2a1be82f8 Avoid infinite loop when validating misaligned questionnaireresponseitems 2018-12-10 13:51:12 +02:00
Matti Uusitalo 55287f126c Added missing propagation of QuestionnaireResponse root element 2018-12-10 13:51:12 +02:00
Matti Uusitalo 2941e7067a Thread questionnaireResponse root element through questionnaire validation so implementations of enablewhen may validate against the complete resource 2018-12-10 13:51:12 +02:00
Matti Uusitalo 606d901523 Reverted to original version 2018-12-10 13:48:23 +02:00
Matti Uusitalo addc44b5f4 Changed versions to use fi.kela.kanta.phr parent 2018-12-10 13:48:23 +02:00
Matti Uusitalo 11b1114fe8 Way to inject custom enablewhen evaluator added 2018-12-10 13:48:23 +02:00
Matti Uusitalo deb8de8705 Added check for answering questions which are not enabled 2018-12-10 13:48:23 +02:00
Matti Uusitalo e2cdb7bbe6 Removed unused HapiWorkerContext 2018-12-10 13:48:23 +02:00
Matti Uusitalo 98cf1becb1 Added default enablewhen behaviour to STU3 resources converted to R4 2018-12-10 13:46:45 +02:00
Okko Kauhanen 360e8d2d8f Remove unnecessary throw 2018-12-10 13:45:12 +02:00
Okko Kauhanen 430e8c89e8 Fixed bug in finding QuestionnaireResponse child items 2018-12-10 13:45:12 +02:00
Okko Kauhanen 0540efa49b Added operator evaluation for R4 enableWhen 2018-12-10 13:45:12 +02:00
Okko Kauhanen f56ad302dd fix enablewhen result 2018-12-10 13:45:12 +02:00
Okko Kauhanen 44b24a65cb Missing file 2018-12-10 13:45:12 +02:00
Okko Kauhanen e4db83ce41 First implementation of enableWhen evaluator 2018-12-10 13:45:12 +02:00
Eeva Turkka c67554e5aa Unit tests up to date and maybe we need to use r4 path 2018-12-10 13:45:12 +02:00
Eeva Turkka b0635a91cd Fixed unit test asserts 2018-12-10 13:33:55 +02:00
Eeva Turkka 4dbef9a799 Cherry picked changes from master to 3.5.0 branch 2018-12-10 13:33:55 +02:00
Matti Uusitalo b76fe1e6be Sync our fork with Hapi master. Merge remote-tracking branch 'upstream/master' 2018-12-10 13:20:27 +02:00
jamesagnew cc57bacab8 Version bump to 3.7.0-SNAPSHOT 2018-11-12 10:07:28 -05:00
James Agnew 63af04a7b4 Prepare for 3.6.0 release 2018-11-12 05:40:55 -05:00
Matti Uusitalo 130fc3a90e Removed unused HapiWorkerContext 2018-11-07 11:46:24 +02:00
Matti Uusitalo b140351650 Added default enablewhen behaviour to STU3 resources converted to R4 2018-11-06 13:11:12 +02:00
Okko Kauhanen 139ec6503f Remove unnecessary throw 2018-11-05 18:39:13 +02:00
Okko Kauhanen c099fcda0a Fixed bug in finding QuestionnaireResponse child items 2018-11-05 17:49:12 +02:00
Okko Kauhanen 4c4c8ba87a Added operator evaluation for R4 enableWhen 2018-11-05 17:03:50 +02:00
Okko Kauhanen 38a2b17a5e fix enablewhen result 2018-11-05 13:00:32 +02:00
Okko Kauhanen 91bf3b61f6 Missing file 2018-11-05 12:55:02 +02:00
Okko Kauhanen 0dcc4fa189 First implementation of enableWhen evaluator 2018-11-05 12:01:25 +02:00
Eeva Turkka 92936d6889 Unit tests up to date and maybe we need to use r4 path 2018-11-02 15:54:34 +02:00
Eeva Turkka 15610c9498 Fixed unit test asserts 2018-11-02 12:03:48 +02:00
Eeva Turkka a832b58691 Fixed test cases to make EnableWhen disable questions 2018-11-02 09:17:35 +02:00
Eeva Turkka 0c0f887ddf Added unit tests - Case when hasAnswer is false doesn't work with
InstanceValidator yet.
2018-11-01 15:58:05 +02:00
James Agnew 34bb70af65 Add validator test and allow migrator to be used for 3_3_0 2018-10-08 21:04:17 -04:00
James Agnew 1cfaeadcb8 Don't use a null version advisor in the DSTU2 version converter 2018-10-01 16:48:56 -04:00
James Agnew 3fd86efa73 One more useless class deleted 2018-09-30 13:41:58 -04:00
James Agnew d7abeb513b Remove class that is failing the build and not used 2018-09-30 13:31:06 -04:00
James Agnew 3e445faf47 Squashed commit of the following:
commit df641506885e09e63f80efc6c658d01a1a3a8142
Author: James Agnew <jamesagnew@gmail.com>
Date:   Sat Sep 29 13:47:22 2018 -0400

    Shrink validation resources

commit 4c1550eafa26f4235b4b8804741aecc03276b5c6
Author: James Agnew <jamesagnew@gmail.com>
Date:   Fri Sep 28 22:45:28 2018 -0400

    Updates to get R4 working

commit 8332f15291006691ed9b07ead3e3524b0fc85510
Author: jamesagnew <jamesagnew@gmail.com>
Date:   Fri Sep 28 09:02:13 2018 -0400

    Ongoing work on gettign R4 working

commit f7146cab7aed937bb625a8aec95744d76db00041
Author: James Agnew <jamesagnew@gmail.com>
Date:   Fri Sep 28 05:21:01 2018 -0400

    More work on sync

commit f48de4a10b1bab2584fee813017d9b27b237bfa9
Merge: 9e4f3cc722 aacb78b779
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu Sep 27 20:11:29 2018 -0400

    Merge branch 'sync_r4' of github.com:jamesagnew/hapi-fhir into sync_r4

commit 9e4f3cc722668aae31a77b19bf9b032af3ae01b0
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu Sep 27 20:11:19 2018 -0400

    Fix compile error

commit 7ec29e0ceda8f9013cbabb95767cbe15b4b81303
Merge: 23f7517325 002c4b3ff7
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu Sep 27 20:04:23 2018 -0400

    Merge branch 'master' into sync_r4

commit aacb78b7793ab2c71e0a2a774240ee2b5d3f9e7f
Author: jamesagnew <jamesagnew@gmail.com>
Date:   Thu Sep 27 20:01:42 2018 -0400

    Keep working on getting R4 building

commit 4950de46d99897e74d41dfdb10d3d8a3435cb0c9
Author: jamesagnew <jamesagnew@gmail.com>
Date:   Tue Sep 25 13:11:27 2018 -0400

    Ongoing work to get R4 working

commit 819d69c20e112dd3c72569ec50114ddb8263c300
Author: jamesagnew <jamesagnew@gmail.com>
Date:   Thu Sep 20 08:15:36 2018 -0400

    Work on getting build working

commit 2c61b6cd1205ced5d7b822cf10942c69272ea078
Merge: 16b5bb06c8 dfb4de86f1
Author: jamesagnew <jamesagnew@gmail.com>
Date:   Thu Sep 20 05:16:53 2018 -0400

    Merge branch 'master' into sync_r4

commit 16b5bb06c8cdaf8d67c3b80f5aa9be9fccd99aef
Author: jamesagnew <jamesagnew@gmail.com>
Date:   Mon Sep 17 05:30:39 2018 -0400

    Work on R4 sync

commit 23f7517325a14dd2ca1eb5641296ead2776634ae
Author: James Agnew <jamesagnew@gmail.com>
Date:   Sun Sep 16 10:19:00 2018 -0400

    Work on sync

commit 6cc413c1f1dea538295aa4c16c21a5677494ac4c
Author: James Agnew <jamesagnew@gmail.com>
Date:   Fri Sep 14 17:28:28 2018 -0400

    Work on R$ sync

commit df6f6ad2ce783b07ccc383134705d874bc5d2cf1
Author: jamesagnew <jamesagnew@gmail.com>
Date:   Fri Sep 14 08:33:07 2018 -0400

    Work on R4
2018-09-29 13:48:35 -04:00
James Agnew 706e004b9d Bump to 3.6.0-SNAPSHOT 2018-09-19 10:24:48 -04:00
James Agnew 261f2c73ab Merge branch 'jpa_migration' 2018-09-11 08:09:15 -04:00
jamesagnew 0e75c8ed39 A few test fixes 2018-09-10 08:50:12 -04:00
James Agnew 29f324f8de
Merge branch 'master' into master 2018-09-07 23:25:49 -04:00
James Agnew daef975734 Version bump to 3.5.0 2018-09-08 07:22:21 +08:00
James Agnew f4a21eadda Fix this issue 2018-09-01 14:38:52 +08:00
Anthony Sute 5ef647840b Follow-up fixes for unit tests for issue #1048. 2018-08-10 11:47:53 -04:00
Anthony Sute 0fdcad0985 Second pull request for fixes for issue #1048. 2018-08-06 13:17:51 -04:00
Anthony Sute 3cf3f7d5d6 Fixes for issue #1048. FhirInstanceValidator::validate() now looking in meta/profile section of request prior to calling InstanceValidator::validate(). 2018-08-06 12:50:50 -04:00
jamesagnew e5cb609f4d Performance improvements 2018-06-24 20:02:27 -04:00
James Agnew e9fffd3cdc Allow indexing in custom search params to descend into contained
resources
2018-06-22 11:22:07 -04:00
James Agnew 218937e425 Several fixes 2018-06-20 05:53:32 -04:00
James Agnew cc0e836680
Auth interceptor early checks (#995)
* Validator fix

* Enhance AuthorizationInterceptor so that it tries to deny access earlier
for compartment searches that are outside the allowable compartment.

* FIx DSTU2 test that wasn't updated

* More test fixes
2018-06-10 17:48:20 -04:00
James Agnew 91d4ab8496 Merge branch 'java9' of github.com:jamesagnew/hapi-fhir into java9 2018-05-30 15:03:29 -04:00
James Agnew 1fcb374d40 Test fixes 2018-05-30 15:03:11 -04:00
jamesagnew d127a89047 Some test fixes 2018-05-30 11:01:43 -04:00
James Agnew d819d685ee Test fix 2018-05-30 09:57:41 -04:00
jamesagnew 5a96482860 More work o JDK9 tests 2018-05-30 08:04:01 -04:00
James Agnew a52805e504 Work on JDK9 support 2018-05-30 05:45:08 -04:00
Diederik Muylwyk 0e2c57fa60 Bumping version. 2018-05-28 17:44:38 -04:00
Diederik Muylwyk 2871920734 Preparing release. 2018-05-28 10:45:47 -04:00
jamesagnew 09eb52ed27 Fix failing tests 2018-05-24 06:33:13 -04:00
James Agnew 1ead3f715e
Merge pull request #892 from hdconradi/validate-questionnaire-response-item-type-for-text
Allow text items in questionnaire
2018-05-24 06:03:18 -04:00
James Agnew 934369a1d9
Merge branch 'master' into instance-validator-npe-on-itemtype 2018-05-24 05:55:22 -04:00
James Agnew 179e88eb86
Merge pull request #881 from hdconradi/two-typos
Two typos in the InstanceValidator
2018-05-24 05:52:39 -04:00
James Agnew 74e7152ce6
Merge pull request #880 from hdconradi/required-answer-can-be-missing-when-in-progress
Activate the QuestionnaireResponseValidatorDstu3Test again and add tests for missing required items
2018-05-24 05:46:41 -04:00
James Agnew eb77b8a225
Merge pull request #874 from hdconradi/validation-server-exception-when-local-reference-absent
Validation server exception when local reference absent
2018-05-23 06:29:25 -04:00
jamesagnew c82c57eb37 Sync validator 2018-05-23 06:28:58 -04:00
jamesagnew 7e83fc78cf Disable user resource and weaken validation on the public server 2018-05-21 19:04:37 -04:00
jamesagnew e8139192e0 FIx test issues 2018-05-21 13:07:11 -04:00
James Agnew a7cd37e2a0
Merge branch 'master' into fix936 2018-05-17 07:30:31 -04:00
patrick-werner 4d8608e721 temp. fixed: "Attempt to read a single element when there is more than one present" #949
Will be overwritten by next RI import!
2018-05-17 10:15:29 +02:00
patrick-werner 07d0cc7876 Merge branch 'master' into bpCheckValFix 2018-05-17 09:53:41 +02:00
patrick-werner 78f9d6333a temp. fixed: "Attempt to read a single element when there is more than one present" #949
Will be overwritten by next RI import!
2018-05-17 09:43:35 +02:00
James Agnew 4fd868afae Credit for #946 and add extensions to the CLI uploader 2018-05-16 19:32:12 -04:00
patrick-werner b4d2fcfc68 added core-extension validation support 2018-05-16 18:51:55 -04:00
James Agnew 0b6a146945 Don't do karaf verifier by default 2018-05-16 14:24:55 -04:00
patrick-werner 412994bfc7 Merge branch 'core-extensions' 2018-05-15 12:16:35 +02:00
James Agnew a3ff08d9ec
Replace phloc with ph for #775 (#930)
* Replace phloc with ph

* Enable schematron tests

* Make HAPI-FHIR ph-schematron on OSGI

* Work on getting tests passing

* Another test fix

* Fix up transaction handling for DSTU2

* Add changelog

* Avoid double transaction

* Dont use readonly

* One more test fix

* Update to snapshow build

* Resolve a circular dependency

* Try to fix tests

* Solve recurring NPE in DSTU2 tests

* Fix one more test

* Test fix

* More test threading fixes

* One more attempt to get tests passing

* Refactoring for tests

* Refactoring for tests
2018-05-14 17:38:40 -04:00
James Agnew 3a03d4ff63 Add test for #942 2018-05-13 10:31:54 -04:00
patrick-werner 305cc9c9c4 added core-extension validation support 2018-05-13 16:22:57 +02:00
James Agnew 8c47d966e9 Add test for #938 2018-05-13 09:03:12 -04:00
jamesagnew 3d762b984b Sync to R4 definitions 2018-05-12 19:35:42 -04:00
patrick-werner 405bb50036 Modified Information warning about non must-support content 2018-05-12 14:12:01 +02:00
James Agnew b17eebd8d2 Squashed commit of the following:
commit 2be11651c2
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu May 10 11:50:53 2018 -0400

    Update changelog

commit b3bb5f9052
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu May 10 11:19:28 2018 -0400

    Parameter updates

commit f6b1082ba4
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu May 10 07:24:30 2018 -0400

    More test fixes

commit 81a69c265f
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu May 10 06:26:48 2018 -0400

    Fix compile error

commit 935938e92c
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu May 10 06:25:18 2018 -0400

    Another test fix

commit 43568a1f8d
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu May 10 06:18:06 2018 -0400

    Fix compile error

commit e95894e643
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu May 10 06:13:50 2018 -0400

    More work on tests

commit 9393fb8f4f
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu May 10 05:36:27 2018 -0400

    One more fix

commit 437f5051e4
Author: James Agnew <jamesagnew@gmail.com>
Date:   Wed May 9 21:32:10 2018 -0400

    Work on validator

commit 20c51add4f
Author: James Agnew <jamesagnew@gmail.com>
Date:   Wed May 9 19:34:10 2018 -0400

    Validator fix

commit 7bf2b0a0e9
Author: James Agnew <jamesagnew@gmail.com>
Date:   Wed May 9 18:44:04 2018 -0400

    Fix test

commit adc73e75c9
Author: James Agnew <jamesagnew@gmail.com>
Date:   Wed May 9 17:22:34 2018 -0400

    Merge validator
2018-05-10 11:53:32 -04:00
James Agnew f092caf386
Merge pull request #903 from dgileadi/902-fix-bounds-exception
Fix #902, IndexOutOfBoundsException for DSTU2 QuestionnaireResponses with groups
2018-05-04 08:49:17 -04:00
jamesagnew 83a5eedb29 Fix performance regression in DSTU3 validation 2018-04-28 11:42:59 -04:00
Heinz-Dieter Conradi 01b84cdd96 Fix the InstanceValidator so that the test passes for text items too. 2018-04-03 23:40:36 +02:00
Heinz-Dieter Conradi 04ae5a30d1 R4: add a questionnaire test which checks all possible item types 2018-04-03 23:39:58 +02:00
Heinz-Dieter Conradi fafbabb34a DSTU3: add a questionnaire test which checks all possible item types 2018-04-03 23:37:37 +02:00
Heinz-Dieter Conradi baf53efd32 Fixing the NPE in the InstanceValidator 2018-04-03 23:35:00 +02:00
Heinz-Dieter Conradi 1aff132691 Test questionnaire with embedded items for R4.
The test for an item embedded in a text item works as expected.
    However, the embedded item in a choice or openchoice case
    triggers an NPE.
2018-04-03 23:34:53 +02:00
Heinz-Dieter Conradi eeb4fe62b7 Test questionnaire with embedded items for DSTU3.
The test for an item embedded in a text item works as expected.
However, the embedded item in a choice or openchoice case
triggers an NPE.
2018-04-03 23:33:12 +02:00
Heinz-Dieter Conradi 913283559f Wrong javadoc parameter name
This is an error in some ide's and of course in javadoc.
2018-04-03 23:28:23 +02:00
Heinz-Dieter Conradi 41207e5555 Testing missing required items in QuestionnaireResponses 2018-04-03 23:20:31 +02:00
Heinz-Dieter Conradi 2d55b1f886 Remove the Ignore from the QuestionnaireResponseValidatorDstu3Test 2018-04-03 23:20:31 +02:00
Heinz-Dieter Conradi b2107baae4 Fix the server exception when validating an invalid local reference
'fetcher == null' is ok for a local reference.

Unfortunately, there are now two messages with the same meaning:
- one from the ProfileValidation
- one from the code in this location
2018-04-03 23:11:53 +02:00
Heinz-Dieter Conradi f2cd05fe3b Add test for invalid local reference (R4)
Currently an invalid local reference causes an InternalErrorException
caused by: FHIRException: Resource resolution services not provided.
The validation should instead return normally and contain an error
message.
2018-04-03 23:11:40 +02:00
Heinz-Dieter Conradi 229e0977d2 Add test for invalid local reference (DSTU3)
Currently an invalid local reference causes an InternalErrorException
caused by: FHIRException: Resource resolution services not provided.
The validation should instead return normally and contain an error
message.
2018-04-03 23:09:39 +02:00
jamesagnew c5b286921e Tests all passing 2018-03-30 15:18:57 -04:00
jamesagnew 180336e076 Sync to master 2018-03-29 06:54:24 -04:00
jamesagnew 53c2d8a38d Merge branch 'master' into loinc_loader_update 2018-03-29 06:21:55 -04:00
jamesagnew 418e82032f Prep for 3.3.0 2018-03-29 05:48:13 -04:00
James Agnew d9c167455e Make sure we correctly clean up resources 2018-03-27 15:20:22 -04:00
James Agnew b56d65ef5b
Merge pull request #871 from johnpoth/hapi-fhir-osgi
Implement #826 - add OSGI support and Apache Karaf features with inte…
2018-03-27 06:06:34 -04:00
David Gileadi 3b724107ff Fix the IndexOutOfBoundsException, #902
Add a test that demonstrates it
2018-03-26 11:10:55 -07:00
James Agnew 29c09e40f0
Merge pull request #858 from patrick-werner/master
added Test for #11 to Dstu3 and R4, fixed #853
2018-03-24 06:31:24 -04:00
James Agnew 308ac63a77 Merge branch 'master' into loinc_loader_update 2018-03-20 07:53:41 -04:00
James Agnew 6359f7f8a1 More work on loinc 2018-03-19 08:51:02 -04:00
patrick-werner ff04ab3358 ${argLine} -> [at]{argLine}
see:
http://maven.apache.org/surefire/maven-surefire-plugin/faq.html#late-property-evaluation
2018-03-19 10:45:33 +01:00
patrick-werner 0cee57392a Merge remote-tracking branch 'upstream/master'
# Conflicts:
#	hapi-fhir-validation/src/test/java/org/hl7/fhir/r4/validation/FhirInstanceValidatorR4Test.java
2018-03-07 11:45:31 -03:00
James Agnew 1a331838d0 Add comment for #870 2018-03-05 08:36:42 -05:00
James Agnew 1fcfc13dca Merge branch 'schematron-questionnaire-que-7' of https://github.com/hdconradi/hapi-fhir into hdconradi-schematron-questionnaire-que-7 2018-03-05 08:29:57 -05:00
jamesagnew 07290ae8a0 Sync to latest R4 code 2018-03-04 11:02:47 -05:00
jamesagnew b2ceb87a70 Work on #873 2018-03-03 17:50:29 -05:00
James Agnew 790aaeb4ea Tests for #872 2018-02-28 21:34:32 -05:00
Heinz-Dieter Conradi f4fa233ad7 remove superfluous import 2018-02-28 13:34:14 +01:00
jpoth 66ebfa0ed3 Implement #826 - add OSGI support and Apache Karaf features with integration tests 2018-02-28 11:32:53 +01:00
Heinz-Dieter Conradi 8e000749ba Fix questionnaire schematron with enableWhen and hasAnswer
Without this fix, the 'hasAnswer' element of a questionnaire item is ignored.
This in turn allowes it that one can have both an 'answer' and a 'hasAnswer' item.

A fix is applied for both DSTU3 and R4 and tests are provided.

The tests for R4 are currently ignored, since they require a valid schematron,
e.g. by merging #869
2018-02-27 16:31:19 +01:00
patrick-werner 0af95842a9 fixes #853
performer validation implementation is now list based
added Test
2018-02-22 12:23:42 +01:00
jamesagnew c8e61cd9a3 Fix test for #851 2018-02-15 07:15:25 -05:00
jamesagnew 8458544fc9 Add test for #851 2018-02-15 07:12:56 -05:00
James Agnew b61887e841 Improve performance of base64 validation 2018-01-30 17:37:12 -06:00
James Agnew 41583606a6 Reduce burden of base64 validation 2018-01-30 14:08:34 -06:00
James Agnew 2810fff39f Sync validator with RI 2018-01-30 13:58:35 -06:00
James Agnew e4c58af006 Fix broken test in validator 2018-01-30 13:55:20 -06:00
James Agnew ebcdd0d917 Add test for #824 2018-01-30 12:41:34 -06:00
James Agnew 8d468de551 Use R4 validator for DSTU3 validation 2018-01-30 11:16:04 -06:00
James Agnew 16038ece26 Version bump to 3.3.0-SNAPSHOT 2018-01-23 10:31:01 -05:00
James Agnew 4fd3e20d06 Remove duplicate resource body creation (Merge branch 'optimize_jpa') 2018-01-21 18:16:11 +08:00
James Agnew 6468ca474a Verion bump to 3.2.0 2018-01-13 02:14:33 -05:00
James Agnew 01186ec8cb Squashed commit of the following:
commit ab876ef864005b6758d3e00a1bb1ef2dad5d2161
Author: James Agnew <jamesagnew@gmail.com>
Date:   Fri Jan 12 18:59:15 2018 -0500

    Tests all passing

commit 4f8a5d98307da1bb5ca7602e34b1d3b791f73d25
Author: jamesagnew <jamesagnew@gmail.com>
Date:   Fri Jan 12 08:21:58 2018 -0500

    Almost compiling
2018-01-12 18:59:43 -05:00
jamesagnew 6fc88caa51 More work on optimizing JPA 2018-01-08 07:15:58 -05:00
James Agnew 8c10d96416 Add tests 2017-12-22 13:33:35 -05:00
James Agnew 3e296f9d1b Merge branch 'master' of github.com:jamesagnew/hapi-fhir 2017-11-25 17:53:01 -05:00
James Agnew 6afe6804db Fix #796 - Correctly escape spaces in generated URLs 2017-11-25 17:52:12 -05:00
jamesagnew 5b909b4746 Version bump to 3.2.0-SNAPSHOT 2017-11-24 13:32:47 -05:00
jamesagnew 42dd34252d Version bump to 3.1.0 2017-11-23 13:27:21 -05:00
James Agnew 1d06c9165b Remove more windows line ending dependencies 2017-10-31 17:55:16 -04:00
James 15ba0dff03 Clean up email subscription type 2017-10-26 06:02:12 -04:00
James Agnew 16e19a9fed Fix #720 - Failure to parse custom type 2017-10-21 13:47:03 -04:00
James Agnew a265de8649 Validation fixes for QuestionnaireResponse validation 2017-10-18 11:59:22 -04:00
James Agnew 9ca85b4cf3 Re-enable errorprone on standard hapi fhir build. woohoo! 2017-10-15 11:27:30 -04:00
James Agnew 4b8a8e8af1 Fix #758 - Invalid char 2017-10-12 21:48:31 -04:00
James Agnew 9d6bfdc25a Remove useless log line 2017-10-11 21:16:56 -04:00
James Agnew 0ac53e55d4 Accidentally reverted a fix in InstanceValidator 2017-10-11 13:38:05 -04:00
James Agnew 78b7188fbc Fix validation error when Bundle has no type 2017-10-11 10:20:12 -04:00
James Agnew 328080e87b Add test for #739 2017-09-27 21:36:40 -04:00
James Agnew 87383ad802 Version bump to 3.1.0-SNAPSHOT 2017-09-27 21:23:34 -04:00
James e19c13fa6f Prepare 3.0.0 release 2017-09-24 17:55:16 -04:00
James 49bdaa1a45 Version bump to 3.0.0 2017-09-23 17:31:39 -04:00
James Agnew 85aef0a853 Refactor tests 2017-09-10 07:23:57 -07:00
James Agnew 805fbad6ce All recreating code systems with previously used URL 2017-09-09 21:49:26 -07:00
James Agnew 2bb01451ea Cleanup of validator 2017-09-09 20:55:00 -07:00
James e3a28e2ff5 Split out delivery and processing channel for subscriptions 2017-08-19 12:15:19 -04:00
James 4bd1c1d0de Updates to validation for DSTU2 2017-08-18 08:22:37 -04:00
James be5c5ebecd Merge in HAPI 3.0.0 working branch!
Squashed commit of the following:

commit 12f89a423a
Author: James <jamesagnew@gmail.com>
Date:   Sun Aug 13 14:38:51 2017 -0400

    Minimize validation resources

commit f6868cce5c
Merge: 3b80779fd3 1e158311d8
Author: James <jamesagnew@gmail.com>
Date:   Sun Aug 13 14:05:34 2017 -0400

    Forward port fix for #710

    Merge branch 'master' into hapi3_refactor

commit 3b80779fd3
Merge: 1f534985e8 356d9acaf7
Author: James <jamesagnew@gmail.com>
Date:   Sun Aug 13 12:31:09 2017 -0400

    Forward port #705, #708, and #710

    Merge branch 'master' into hapi3_refactor

commit 1f534985e8
Merge: 7c39a47852 dedd3d635b
Author: James <jamesagnew@gmail.com>
Date:   Sun Aug 13 10:52:59 2017 -0400

    Forward port #695

    Merge branch 'master' into hapi3_refactor

commit 7c39a47852
Merge: e0ffb84d21 6efafe62f1
Author: James <jamesagnew@gmail.com>
Date:   Sun Aug 13 09:53:17 2017 -0400

    Forward port #688

    Merge branch 'master' into hapi3_refactor

commit e0ffb84d21
Merge: 52388c11c1 d19b00ff09
Author: James <jamesagnew@gmail.com>
Date:   Sat Aug 12 14:59:46 2017 -0400

    Merge branch 'master' into hapi3_refactor

commit 52388c11c1
Author: James <jamesagnew@gmail.com>
Date:   Sat Aug 12 06:21:46 2017 -0400

    Cleanup

commit 209752cd63
Author: James <jamesagnew@gmail.com>
Date:   Thu Aug 10 11:18:19 2017 -0400

    Fix tests

commit 4543408dc8
Author: James <jamesagnew@gmail.com>
Date:   Sat Aug 5 06:55:50 2017 -0400

    Fix a potential deadlock

commit ee360f5376
Author: James <jamesagnew@gmail.com>
Date:   Sat Aug 5 06:22:06 2017 -0400

    Add R4 code to CLI

commit 1a95ba3b65
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu Aug 3 06:14:01 2017 -0400

    More cleanup

commit f0d8802681
Author: James <jamesagnew@gmail.com>
Date:   Wed Aug 2 11:27:43 2017 -0400

    Tests are working!

commit a4cbda357e
Author: James Agnew <jamesagnew@gmail.com>
Date:   Wed Aug 2 10:42:04 2017 -0400

    Connection handling cleanup for new tests

commit 0e2cecfbd0
Author: James Agnew <jamesagnew@gmail.com>
Date:   Wed Aug 2 10:16:28 2017 -0400

    Clean up R4 JPA tests

commit 40317a650d
Author: James <jamesagnew@gmail.com>
Date:   Wed Aug 2 09:12:38 2017 -0400

    Work on R4 for JPA server

commit e7f8f8c30d
Author: James <jamesagnew@gmail.com>
Date:   Tue Aug 1 20:43:47 2017 -0400

    More work on porting tests

commit 43c9003258
Author: James <jamesagnew@gmail.com>
Date:   Tue Aug 1 07:09:29 2017 -0400

    Work on porting DSTU1 tests

commit 602857f1e2
Author: James Agnew <jamesagnew@gmail.com>
Date:   Mon Jul 31 22:34:08 2017 -0400

    More work on bring unit tests up to date

commit e326a7b0cd
Author: James Agnew <jamesagnew@gmail.com>
Date:   Mon Jul 31 17:36:38 2017 -0400

    Credit for #686 and forward port the fix to R4 validator

commit 96543c3992
Merge: 3fb75aa61a 9901b802c4
Author: James Agnew <jamesagnew@gmail.com>
Date:   Mon Jul 31 17:12:33 2017 -0400

    Merge branch 'master' into hapi3_refactor

commit 3fb75aa61a
Author: James <jamesagnew@gmail.com>
Date:   Mon Jul 31 15:21:30 2017 -0400

    More work on cleanup

commit b02fbb6804
Author: James Agnew <jamesagnew@gmail.com>
Date:   Sun Jul 30 22:11:07 2017 -0400

    Work on porting STU1 tests

commit 1ae37b0db3
Author: James Agnew <jamesagnew@gmail.com>
Date:   Sun Jul 30 20:56:10 2017 -0400

    Try to get coverage report working

commit 72b88849b3
Author: James Agnew <jamesagnew@gmail.com>
Date:   Sun Jul 30 20:27:02 2017 -0400

    Fix android tests

commit e5f6c35aea
Author: James <jamesagnew@gmail.com>
Date:   Sun Jul 30 19:31:18 2017 -0400

    More work on getting legacy code cleaned up

commit 0b513b0845
Author: James <jamesagnew@gmail.com>
Date:   Sun Jul 30 18:41:13 2017 -0400

    Continue work on removing deprecated API

commit defea69aa3
Author: James Agnew <jamesagnew@gmail.com>
Date:   Sun Jul 30 17:10:01 2017 -0400

    More cleanup of legacy code

commit 9ae7295705
Author: James <jamesagnew@gmail.com>
Date:   Sun Jul 30 07:11:45 2017 -0400

    More cleanup of legacy code

commit ebd3eeb5ee
Author: James Agnew <jamesagnew@gmail.com>
Date:   Sun Jul 30 06:43:25 2017 -0400

    More work on removing legacy code

commit 92224c2532
Author: James <jamesagnew@gmail.com>
Date:   Sat Jul 29 18:44:06 2017 -0400

    Remove DSTU1 Bundle

commit c52cacf71b
Author: James <jamesagnew@gmail.com>
Date:   Sat Jul 29 14:27:42 2017 -0400

    Now compiling

commit b405e51773
Merge: c3ddf04e25 cb2cea54d7
Author: James Agnew <jamesagnew@gmail.com>
Date:   Fri Jul 28 06:21:02 2017 -0400

    Merge branch 'master' into hapi3_refactor

commit c3ddf04e25
Author: James <jamesagnew@gmail.com>
Date:   Thu Jul 27 11:06:06 2017 -0400

    Sync R4 releases in

commit b13333c3c0
Author: James <jamesagnew@gmail.com>
Date:   Fri Jul 14 05:52:33 2017 -0400

    JPA server is now able to handle placeholder IDs (e.g. urn:uuid:00....000) being used in Bundle.entry.request.url as a part of the conditional URL within transactions.

commit 2e60ff7521
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu Jul 13 20:02:46 2017 -0400

    Fix imports

commit a92ace2e0d
Merge: 3196db96d1 1a6b3ea867
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu Jul 13 12:02:27 2017 -0400

    Merge branch 'master' into hapi3_refactor

commit 3196db96d1
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu Jul 13 11:48:10 2017 -0400

    Don't add false paging link to request

commit bd4e1d3388
Author: James <jamesagnew@gmail.com>
Date:   Sun Jul 9 21:32:16 2017 -0400

    Finally building correctly!

commit 6464ce9304
Author: James <jamesagnew@gmail.com>
Date:   Sun Jul 9 16:38:28 2017 -0400

    Work on refactor

commit 0059f2e48e
Author: James <jamesagnew@gmail.com>
Date:   Sat Jul 8 07:16:20 2017 -0400

    Keep working on refactor

commit 6c2e87e8cc
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu Jul 6 22:35:13 2017 -0400

    Lots of work on refactor

commit 11cab97504
Merge: 34ec6b8807 6c47bd4c51
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu Jul 6 21:43:57 2017 -0400

    Merge branch 'master' into hapi3_refactor

commit 34ec6b8807
Merge: f8e647511b c520e60ac1
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu Jul 6 21:43:49 2017 -0400

    Merge branch 'hapi3_refactor' of github.com:jamesagnew/hapi-fhir into hapi3_refactor

commit f8e647511b
Author: James Agnew <jamesagnew@gmail.com>
Date:   Thu Jul 6 18:46:55 2017 -0400

    Work on hapi3 changes

commit c520e60ac1
Author: James <jamesagnew@gmail.com>
Date:   Wed Jul 5 08:08:40 2017 -0400

    Keep working on refactor

commit f1d2ee9092
Author: James Agnew <jamesagnew@gmail.com>
Date:   Mon Jul 3 22:10:59 2017 -0400

    Continue refactor for HAPI 3

commit 9281ccafc3
Merge: ea1264cd8e 294d080bd3
Author: James Agnew <jamesagnew@gmail.com>
Date:   Mon Jul 3 20:34:16 2017 -0400

    Merge branch 'master' into hapi3_refactor

commit ea1264cd8e
Author: James <jamesagnew@gmail.com>
Date:   Wed Jun 28 10:26:01 2017 -0400

    Continue work on refactor

commit fbe2f98a02
Merge: b2bef47100 0a4dcc32ec
Author: James <jamesagnew@gmail.com>
Date:   Wed Jun 28 06:21:22 2017 -0400

    Merge branch 'master' into hapi3_refactor

commit b2bef47100
Author: James <jamesagnew@gmail.com>
Date:   Tue Jun 27 21:13:23 2017 -0400

    Work on refactor

commit 8f76e4e463
Author: James Agnew <jamesagnew@gmail.com>
Date:   Sun Jun 25 21:55:35 2017 -0400

    Lots of work on refactoring
2017-08-13 14:39:47 -04:00