Commit Graph

371 Commits

Author SHA1 Message Date
Jaison B c7d60fc3e6 merge 'validate_contains_change' into issue-3144-multi-threaded-bundle-validation 2021-12-03 10:06:59 -07:00
Jaison B fefbac8df7 Merge branch 'master' into issue-3144-multi-threaded-bundle-validation 2021-12-03 09:05:06 -07:00
James Agnew 84a9609236
Avoid long pauses in CapabilityStatement generation (#3212)
* Avoid long pauses in CapabilityStatement generation

* Add changelog

* Test fix
2021-12-03 05:28:04 -05:00
Jaison B 72515c2094 Merge branch 'master' into issue-3144-multi-threaded-bundle-validation 2021-12-02 14:53:05 -07:00
Kevin Dougan SmileCDR 3c2b4bb397
3136 - Provide RemoteTerminologyServiceValidationSupport Implementation For Operation $validate-code (#3142)
* 3136 - Send validate-code requests to an Instance of IValidationSupport instead of directly to the DAO.

* 3136 - Added support for R4 validate-code calls to a Remote Terminology Server.

* Added more Unit Tests.

* Added NULL checks based on code analysis.

* Adding some cleanup code to the Unit Tests since some other unrelated Unit Tests were failing when running in an Azure Pipeline.

* Adding @Ignore to both of my Unit Test classes to try and see if this is the cause of other unrelated Unit Test failures in the Azure Pipeline.

* Commented out ALL CODE in my Unit Tests to see if this fixes the other Unit Tests.

* Added 1 Unit Tester called RemoteTerminologyServiceResourceProviderR4Test to see if it causes other Unit Test failures.

* Added a Unit Tester called ResourceProviderR4RemoteTerminologyTest with the code that creates a RemoteTerminologyServiceValidationSupport instance commented out for now, just to see if this allows all other Unit Tests to pass.

* Added a Unit test back in to verify how the RemoteTerminologyServiceValidationSupport works when inserted into the front of the IValidation chain. Lets see if this will mess up any other Unit Tests in the Azure Pipeline...

* Added an @AfterEach method to remove the RemoteTerminologyServiceValidationSupport instance from the ValidationSupportChain to see if it allows all the other Unit Tests to work as before.

* Added more Unit tests.

* Added more Unit Tests to increase code coverage.

* Added some NULL checks.

* Added a changelog for this feature add.

* Removed the decision logic in the REST APIs and also the isRemoteTerminologyServiceConfigured() method, and letting the ValidationSupportChain figure out how to perform the validate-code Operation.

* Removed a NULL check that was not needed.

* Reverting the previous change where I tried using the IValidationSupportChain for each and every incoming Operation request. Splitting the implementation between local and remote seems to be required at this time.
2021-11-23 10:39:56 -05:00
Ken Stevens 94f4009d73 merge master 2021-11-19 16:15:21 -05:00
Tadgh 0a64294467
Release 5.6.0 (#3174)
* 3138 externalized binary packages (#3139)

* Add test and impl

* Add changelog

* Fix test

* Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/5_6_0/3138-support-externalized-binaries.yaml

* add beans to test configs

* Typo

* Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/binstore/IBinaryStorageSvc.java

Co-authored-by: michaelabuckley <michaelabuckley@gmail.com>

* Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/binstore/NullBinaryStorageSvcImpl.java

Co-authored-by: michaelabuckley <michaelabuckley@gmail.com>

Co-authored-by: Kevin Dougan SmileCDR <72025369+KevinDougan-SmileCDR@users.noreply.github.com>
Co-authored-by: michaelabuckley <michaelabuckley@gmail.com>

* 3131 - Added support for the lookup operation in the Remote Terminology code (#3134)

* Remove leading underscores from identifiers (#3146)

* Version bump

* License files

* version.yaml

Co-authored-by: Kevin Dougan SmileCDR <72025369+KevinDougan-SmileCDR@users.noreply.github.com>
Co-authored-by: michaelabuckley <michaelabuckley@gmail.com>
2021-11-19 15:24:44 +00:00
TipzCM 0c3fb775df
3170 language portion of language code is case insensitive (#3171)
* 3170 language portion of language code is case insensitive

* 3170 adding changelog

* 3170 house keeping

Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local>
2021-11-16 15:58:58 +00:00
TipzCM 1478abac3a
3164 updating code review points (#3165)
* 3164 updating code review points

* 3164 updating code review points

Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local>
2021-11-12 20:13:42 +00:00
TipzCM 25c025cdee
3153 update unknowncodesystemwarningvallidationsupport to have configurable severities (#3155)
* 3153 updating the unknowncodesystemwarningvalidationsupport class

* 3153 updating version for smile

* 3153 update broken tests

* 3153 adding log

* 3153 cleanup

* 3153 cleanup

Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local>
2021-11-10 16:06:09 -05:00
Jaison B 1ee641ba16 FHIR validator refactored to maintain correct bundle path and async validation task 2021-11-09 08:33:37 -07:00
James Agnew 106eb75dc6
Allow GraphQL to work with RequestValidatingInterceptor (#3145)
* Allow GraphQL to work with RequestValidatingInterceptor

* Add test

* Add changelog
2021-11-08 17:47:56 -05:00
Jaison B 4cab7f8b80 Add test to check bundle entry path being added to validation messages 2021-11-08 11:26:13 -07:00
Ken Stevens 882eb99f29 validate threadpool prefixes 2021-11-07 17:15:38 -05:00
Ken Stevens 238027d303 Remove bundleValidationThreadCount (it's set by creating an appropriate executor) 2021-11-07 15:19:10 -05:00
Ken Stevens 47454554e3 Moved concurrent details from ValidationOptions to FhirValidator 2021-11-07 15:04:33 -05:00
Ken Stevens 9eb20cb668 move bundle concurrency config from validationsupport to request validator 2021-11-07 13:26:59 -05:00
Ken Stevens ed9dac5b1a add daoconfig 2021-11-07 12:19:25 -05:00
Ken Stevens 8e27b85094 change test to a red-green test 2021-11-07 09:08:52 -05:00
Ken Stevens 3481069a13 First cut at multithreading bundle validation 2021-11-06 15:52:08 -04:00
jmarchionatto 92e9859272
Issue 3072 using an external terminology server in the fhir server for codes in fhir resources (#3081)
* Let RemoteTerminologyServiceValidationSupport.validateCodeInValueSet work when code system is present, even when theOptions.isInferSystem() is true

* Add test for specific use case added

* Consider ValueSets with multiple component includes

* Fix typo

Co-authored-by: juan.marchionatto <juan.marchionatto@smilecdr.com>
2021-10-18 15:40:17 -04:00
Tadgh 120443e561
Bump core version (#3067)
* Bump core version

* Changes for version bump

* Resolve NPE:

* Test fix

Co-authored-by: jamesagnew <jamesagnew@gmail.com>
2021-10-16 14:13:13 -04:00
jmarchionatto 05aa4447f8
Let RemoteTerminologyServiceValidationSupport.validateCodeInValueSet … (#3073)
* Let RemoteTerminologyServiceValidationSupport.validateCodeInValueSet work when code system is present, even when theOptions.isInferSystem() is true

* Add test for specific use case added

Co-authored-by: juan.marchionatto <juan.marchionatto@smilecdr.com>
2021-10-14 15:40:27 -04:00
jmarchionatto 71e2b82128
Issue 2851 upload terminology valueset parallel versioning (#3051)
* Fix operations for 'loinc-all' ValueSet

* Fix tests

Co-authored-by: juan.marchionatto <juan.marchionatto@smilecdr.com>
2021-10-06 20:56:30 +00:00
James Agnew eca725afa4
Improve versioned URL support for ValueSet expansion (#2994)
* Add test

* Test fixes

* Work on expansion errors

* Fixes

* Test fixes

* Test fixes

* Test fixes

* Test fixes

* Test fixes

* Test fixes

* Test fixes

* Work on fix

* Test fixes

* Test fixes

* Test fix

* Cleanup

* Test fixes

* Remove accidental commit

* Test fixes

* Version bump

* Add changelog

* Fixes

* Test fix

* Fix conflicts
2021-10-03 19:47:23 -04:00
Ken Stevens b1dd40fdba
Try commenting out clearAllStaticFieldsForUnitTest to see what happens (#3034)
* Try commenting out clearAllStaticFieldsForUnitTest to see what happens

* Rename clearAllStaticFieldsForUnitTest to randomizeLocaleAndTimezone and only do that
2021-09-24 16:01:28 -04:00
juan.marchionatto 751c5d0d05 Implement revision suggestions. Add changelog. 2021-09-23 11:55:50 -04:00
Ken Stevens eee7d7e455
code cleanup (#2986)
* failed attempt to get it to work

* Use simplified FhirContext.forCached methods

* Update hapi-fhir-base/src/main/java/ca/uhn/fhir/context/FhirContext.java

Co-authored-by: James Agnew <jamesagnew@gmail.com>

Co-authored-by: James Agnew <jamesagnew@gmail.com>
2021-09-13 03:09:18 +00:00
Frank Tao 44b0d3e9e7
Fixed $lookup with displayLanguage caching issue (#2932)
* Fixed $lookup with displayLanguage caching issue

* Added changelog and optimized the test cases
2021-08-31 22:18:40 +00:00
Tadgh 0304ea2d62 Add requested test 2021-08-26 12:03:00 -04:00
Tadgh fd6dcf6363 Fix bug in code. Add test. Add changelog 2021-08-25 18:16:47 -04:00
Frank Tao 090a8b0821
Impl displayLanguage for $lookup (#2908)
* Impl displayLanguage for $lookup - first cut

* Added original lookupCode method

* Added original lookupCode method to IFhirResourceDaoCodeSystem

* Added more test cases and changelog
2021-08-25 14:47:10 -04:00
markiantorno 3cfc41f840 updating all convertor calls to not failfast 2021-08-20 14:11:20 -04:00
Tadgh b352bc5c96 Fix all tests in validation package 2021-08-19 15:25:19 -04:00
Tadgh 101e0d7288 Fix tests in class 2021-08-19 15:19:31 -04:00
Tadgh 77c99e47c1 TIL that anyString() wont match nulls in Mockito, but any() will 2021-08-19 15:15:51 -04:00
markiantorno 3fdb7c8408 conversion issues fixed, validation issues next 2021-08-19 13:48:59 -04:00
markiantorno 367b338d85 Updating HAPI to use latest core lib changes. 2021-08-18 11:06:14 -04:00
James Agnew 95306c3d64
Add NPM validation support module (#2782)
* Add NPM validation support module

* Add changelog
2021-07-07 16:28:41 -04:00
ianmarshall a878ef2496 Add null check on code lookup result. 2021-05-25 09:09:41 -04:00
ianmarshall 8e552916ee Add null check on code lookup result. 2021-05-25 09:07:28 -04:00
ianmarshall f2627959c2 Add null check on code lookup result. 2021-05-24 22:09:44 -04:00
jamesagnew ff2698d4d1 Merge branch 'rel_5_4' 2021-05-19 09:22:11 -04:00
jamesagnew 8d0d75356e Test fixes 2021-05-19 05:34:24 -04:00
jamesagnew b463b072c8 Test fixes 2021-05-18 21:32:13 -04:00
jamesagnew de56f440cb Version bump 2021-05-18 17:14:14 -04:00
James Agnew 26d030f93e
Add language validation (#2644)
* Add language validation

* Add tests

* Test fix
2021-05-10 20:09:45 -04:00
Kevin Dougan SmileCDR 646faa10e1
2540 - Upgraded the fhir_core_version from 5.3.0 to 5.3.10 (#2545)
* 2540 - Upgraded the fhir_core_version from 5.3.0 to 5.3.9.

* 2540 - Updated the Unit Test messages due to the upgraded dependencies.

* 2540 - Fixed some additional Unit Test message checks.

* 2540 - Updated the POM to refer to fhir_core_version 5.3.10-SNAPSHOT so a FULL Pipeline Build can run to verify that everything is fixed now.

* 2540 - Added some DEBUG Sysout logging to try and determine why the Pipeline Builds fail for a specific Unit Test when it passes locally...

* 2540 - Added some more logging to try and determine why the Pipeline Builds fail for a specific Unit Test when it passes locally...

* 2540 - Updated a Unit Test to account for a newly returned search param.

* 2540 - Updated a Unit Test to account for a newly returned search param and removed some debug output.
2021-04-29 15:00:37 -04:00
Kevin Hartmann 4a5b62616c Improved assertions for testBulkDataExport() 2021-04-27 15:01:03 -04:00
Kevin Hartmann 3a901a6671 Cleaned up extra logging. 2021-04-26 16:57:13 -04:00