Commit Graph

4280 Commits

Author SHA1 Message Date
Amrita Dutta b8def0b3fb Added test to check for missing OS disk snapshot name and data disk snapshot prefix 2018-11-15 22:01:16 +00:00
Amrita Dutta 67342750a3 Addressed PR comments 2018-11-14 01:47:48 +00:00
Megan Marsh dca02c7b07
Merge pull request #6962 from hashicorp/fix_6940
escape vSphere username when putting it into the query
2018-11-13 10:15:25 -08:00
Megan Marsh 3b413d2e5e fix rebase conflicts 2018-11-12 13:24:03 -08:00
Megan Marsh 89184ae384 rework if/else to simplify main code body. 2018-11-12 13:21:25 -08:00
Megan Marsh 536e0501ac Validate username/password for ovftool during prepare.
Add template option skip_validate_credentials allowing users to skip this validation if they don't want it.
Refactor vmware-iso builder to separate out config so that it matches the vmware-vmx builder and simplifies the builder.go file
2018-11-12 13:21:25 -08:00
Megan Marsh 7643ccc67d
Merge pull request #6982 from hashicorp/fix_6161
azure builder: allow to auth with managed identities ( MSI )
2018-11-12 09:03:41 -08:00
Megan Marsh 49b40e0789
Merge pull request #6984 from hashicorp/add_display_name_vmware
add new display_name template option
2018-11-12 08:49:38 -08:00
Adrien Delorme f1fa28847f
remove debug line.
Co-Authored-By: SwampDragons <megan@hashicorp.com>
2018-11-12 08:07:08 -08:00
Adrien Delorme 78ac943679
Merge pull request #6987 from hashicorp/6624
6624
2018-11-12 15:31:36 +01:00
Adrien Delorme 175b6a7971 add test for MSI configuration 2018-11-12 12:04:57 +01:00
Adrien Delorme 1958ef6e81 remove unecessary check 2018-11-12 11:32:49 +01:00
Adrien Delorme 08e8b1850e
remove unnecessary parenthesis 2018-11-12 10:49:39 +01:00
Amrita Dutta 2d6b18e63e Fix tests after bug fix 2018-11-10 00:05:25 +00:00
Megan Marsh 2e2b2cea82 add a warning that checks for collisions between packer-generated values in the default vmx file and the vmx_data 2018-11-09 15:46:52 -08:00
Amrita Dutta 213fbbae00 Updated go version and reformatted 2018-11-09 22:41:48 +00:00
Megan Marsh 3cf4c63a87 Change antiquated Master/Slave terminology for disk drives to more appropriate Primary/Secondary. 2018-11-09 14:00:07 -08:00
Megan Marsh e5c4a4a6fb create export directories for vmx and ovf file types, too. 2018-11-09 11:45:36 -08:00
Amrita Dutta a297d73b98 correcting wrong log message 2018-11-09 19:29:57 +00:00
Amrita Dutta 06525dd885 adding logs in the steps 2018-11-09 19:28:37 +00:00
Megan Marsh 68c9e34bfe add new display_name template option 2018-11-09 10:54:31 -08:00
Megan Marsh be0959004a
Revert "Revert "Rename attribute api_access_key to organization_id"" 2018-11-09 08:47:22 -08:00
Adrien Delorme 1ab0173e69 azure builder: allow to auth with managed identities ( MSI ) 2018-11-09 17:39:03 +01:00
Amrita Dutta 8881bc2d64 Fix bug in snapshot client creation 2018-11-09 03:30:57 +00:00
Megan Marsh c1c929164f
Revert "Rename attribute api_access_key to organization_id" 2018-11-08 16:34:23 -08:00
Megan Marsh 210d62de2c
Merge pull request #6925 from sieben/organization_renaming
Rename attribute api_access_key to organization_id
2018-11-08 16:33:15 -08:00
Rémy Léone e54d2e3591 Rename attribute api_access_key to organization 2018-11-08 13:45:32 +01:00
Mikhail Ushanov 536252683e builders: reuse private key file reading function
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-11-08 14:25:50 +03:00
Amrita Dutta 8d8c86366b Config tests + typo fix 2018-11-07 22:23:22 +00:00
Amrita Dutta 1fa9f1ef11 formatting changes in stateBag.go 2018-11-07 18:11:48 +00:00
Amrita Dutta 8c326dbab7 Formatting changes 2018-11-07 18:08:15 +00:00
Amrita Dutta b2d1675d39 Added tests 2018-11-07 03:23:17 +00:00
Amrita Dutta 369b2dae5e Inlining suggested functions 2018-11-06 21:50:53 +00:00
Megan Marsh 790d5661c5 escape username 2018-11-06 11:30:45 -08:00
Amrita Dutta 593363c5be fix typo in last commit 2018-11-06 19:23:15 +00:00
Amrita Dutta 1266d5146d addressed PR comments + add file for data disk snapshots 2018-11-06 19:17:03 +00:00
Megan Marsh 8567be43d9
Merge pull request #6927 from hashicorp/rebased_4591
Extend vmware-vmx builder to allow esxi builds. (Rebase of PR #4591)
2018-11-06 09:59:26 -08:00
Megan Marsh 96d628eef1 fix silliness with pointers 2018-11-06 09:50:28 -08:00
Amrita Dutta d12d23d34b OS disk snapshot 2018-11-05 23:48:22 +00:00
Megan Marsh 79862f1bbb
Merge pull request #6931 from hashicorp/fix_6919
aws: better error handling of region/credential guessing from metadata
2018-11-05 11:24:09 -08:00
Megan Marsh 5c2ca450bd fix tests 2018-11-02 15:44:27 -07:00
Megan Marsh 5815b376b4 remove unnecessary checks; we always default format to ovf if it is unset.
fix exportoutputdir
2018-11-02 14:22:01 -07:00
Megan Marsh c3144c2d0a add some missing template validation (copied from iso builder) and revert to current use of displayName for parsing vm ssh IP; using VMName was breaking chained builds that hadn't updated the display name from the previous build. 2018-11-02 14:22:01 -07:00
Megan Marsh c3d6d45696 modify test so that it accesses CommConfig the same way we really do within the driver 2018-11-02 14:22:01 -07:00
Megan Marsh f18bb19f96 remove redundant config; CommConfig was already a part of the SSSHConfig struct 2018-11-02 14:22:01 -07:00
Megan Marsh fa12113eaf remove unused NewLocalArtifact
consolidate artifacts
entirely remove local artifact object and get artifacts in the vmx builder the same way we do in the vmware iso builder
2018-11-02 14:22:01 -07:00
Adrien Delorme 3f288fc6ca aws client: config.WithMaxRetries(8) 2018-11-01 15:09:07 +01:00
Megan Marsh daf1f39930
Merge pull request #6918 from hashicorp/oracle_classic_volumes
Parameterized volume size support for Oracle classic builder
2018-10-31 16:03:40 -07:00
Matthew Hooker 3ff038d4d1
remove todo 2018-10-31 12:00:33 -07:00
bozhi.ch c3a60ad0ce add options for system disk properties 2018-10-30 21:09:59 +08:00
Matthew Hooker 42cd3e4bf7
Warn if not a pv build but builder image entry is set. cleanup 2018-10-29 15:23:58 -07:00
chbell43 653fa2298f use guard clauses
* just return early if no FloatingIP is required

* move the instanceIP declaration up and store in the state bag to avoid
errors in ssh.go
2018-10-29 18:36:08 +00:00
Mikhail Ushanov 4608b5d39d amazon: add option for skipping TLS verification
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-29 21:35:29 +03:00
chbell43 ea78cb62fd Make the config.networkV2Client conditional
In cases where the OpenStack environment does not contain a v2 network, the
builder will error out.  We only need the networkV2Client when using floating
IPs.  This will allow packer to work in environments where a v2 network is not
available.
2018-10-29 18:32:09 +00:00
Matthew Hooker eb976894fc
cleanup 2018-10-27 02:04:36 -07:00
Matthew Hooker c697c9d3de
cleanup 2018-10-26 21:59:26 -07:00
Matthew Hooker f322397413
add config tests 2018-10-26 21:56:39 -07:00
Matthew Hooker 6d6d262308
some final fixes and documentation work 2018-10-26 21:56:00 -07:00
Matthew Hooker 4eba1ee724
remove unused config key 2018-10-26 20:02:51 -07:00
Matthew Hooker 03932f1157
Clean up volumes 2018-10-26 20:02:13 -07:00
Matthew Hooker e2a0cbf7df
move upload script to const 2018-10-26 16:59:23 -07:00
Matthew Hooker 7331d6fc7f
some final clean up 2018-10-26 16:59:23 -07:00
Matthew Hooker ab4f205bf6
correctly building linux/windows now 2018-10-26 16:59:23 -07:00
Matthew Hooker 09de194d8e
trying to wrap the base communicator config but it needs to be prepared 2018-10-26 16:59:22 -07:00
Matthew Hooker ab5e964ca6
Connecting to master instance but not builder 2018-10-26 16:59:22 -07:00
Matthew Hooker ade396e140
don't echo image creation commands 2018-10-26 16:59:22 -07:00
Matthew Hooker 3e966ae38d
make fmt 2018-10-26 16:59:22 -07:00
Matthew Hooker 86f6cf478a
cleanup 2018-10-26 16:59:22 -07:00
Matthew Hooker 6f729d0265
Adding some missing configuration 2018-10-26 16:59:22 -07:00
Matthew Hooker c42be62d90
fix identifier changes from oracle sdk 2018-10-26 16:59:22 -07:00
Matthew Hooker bbb0d450f1
todo 2018-10-26 16:59:22 -07:00
Matthew Hooker be91c99d29
warn about dangling segments.
The client offers no way to bulk delete keys, so for now let's just warn users.
The issue is tracked upstream here: https://github.com/hashicorp/go-oracle-terraform/issues/172
2018-10-26 16:59:22 -07:00
Matthew Hooker ce30e1053e
wip 2018-10-26 16:59:22 -07:00
Matthew Hooker 9f310045fc
split image upload/creation. clean up 2018-10-26 16:59:22 -07:00
Matthew Hooker 420d0ebe3e
fix artifact generation 2018-10-26 16:59:21 -07:00
Matthew Hooker 84bb5d2f6f
create image list 2018-10-26 16:59:21 -07:00
Matthew Hooker fa54a64d28
WIP 2018-10-26 16:59:21 -07:00
Matthew Hooker b84c7df9da
Segments going into per-run subfolder 2018-10-26 16:59:21 -07:00
Matthew Hooker b5c6beb8a3
don't delete segments. registering works now. 2018-10-26 16:59:21 -07:00
Matthew Hooker 705fa976a8
more debugging 2018-10-26 16:59:21 -07:00
Matthew Hooker 2536790e0a
todo 2018-10-26 16:59:21 -07:00
Matthew Hooker 7a35e2408f
fix pty, some todo and refactor of bash scri[t 2018-10-26 16:59:21 -07:00
Matthew Hooker fc301601e1
actually delete temp container 2018-10-26 16:59:21 -07:00
Matthew Hooker cd77d00fd8
delete temporary image container 2018-10-26 16:59:21 -07:00
Matthew Hooker 21f786d686
todo and some clean up. correct values for machine image 2018-10-26 16:59:21 -07:00
Matthew Hooker b222d36669
use 2x volume size 2018-10-26 16:59:21 -07:00
Matthew Hooker 7c577abbcb
WIP: register machine image.
remove passwords
2018-10-26 16:59:21 -07:00
Matthew Hooker 8207ba4fa4
Use jq to create manifest. Upload to compute_images 2018-10-26 16:59:20 -07:00
Matthew Hooker 96e62236ec
upload volume WIP
check upload for error
increase builder volume size to account for chunking
2018-10-26 16:59:20 -07:00
Matthew Hooker 8598e2d0a3
WIP 2018-10-26 16:59:20 -07:00
Matthew Hooker bf7c4a7ad6
wip 2018-10-26 16:59:20 -07:00
Matthew Hooker 445c3fb5bb
cleanup temp keys 2018-10-26 16:59:20 -07:00
Matthew Hooker 098764d8ac
WIP 2018-10-26 16:59:20 -07:00
Matthew Hooker 2db0a03142
image upload WIP 2018-10-26 16:59:20 -07:00
Matthew Hooker 265ee0b0b8
add whitespace 2018-10-26 16:59:20 -07:00
Matthew Hooker 7c26ffef9c
builder instance now runs and is connected to 2018-10-26 16:59:20 -07:00
Matthew Hooker b3ffa975c3
Revert "add boot volume to builder instance"
This reverts commit cbce7b42079d2087bc622fd8c6f65d1339b735d1.
2018-10-26 16:59:20 -07:00
Matthew Hooker 2febfa2c7d
attach volume after instance booted 2018-10-26 16:59:20 -07:00
Matthew Hooker b68f214ca4
add boot volume to builder instance 2018-10-26 16:59:20 -07:00
Matthew Hooker ca3bffcb0d
bugfix and some debug logging 2018-10-26 16:59:19 -07:00
Matthew Hooker 00ff187d77
master instance working 2018-10-26 16:59:19 -07:00
Matthew Hooker e271e88b49
oracle-classic variable volume size WIP 2018-10-26 16:59:19 -07:00
Adrien Delorme f4fbf45349 remove duplicate region check error 2018-10-26 17:44:56 +02:00
Adrien Delorme 16aa21dffe aws: better error handling of region guessing from metadata
* this will fix #6919
2018-10-26 12:24:10 +02:00
Megan Marsh 2ae235a28a fix tests 2018-10-25 14:41:01 -07:00
Megan Marsh 290f4a7c4c cleanup to make it actually build after that monstrous rebase 2018-10-25 14:17:35 -07:00
Alexander Laamanen 3193f50f17 Support export with the vmx builder. 2018-10-25 13:02:37 -07:00
Alexander Laamanen a68a639a1a Move step_export to common. 2018-10-25 12:55:10 -07:00
Alexander Laamanen 63054fb808 Fix the test. 2018-10-25 12:45:44 -07:00
Stuart Miller da5f322484 Add quotes around all filenames to prevent issues with spaces 2018-10-25 12:45:44 -07:00
Alexander Laamanen f42f5a8ad3 Remove some extra logging. 2018-10-25 12:44:29 -07:00
Alexander Laamanen e7e6a80587 No need to make upload public. 2018-10-25 12:39:51 -07:00
Alexander Laamanen c294e65c36 A separate driver file is not really needed anymore 2018-10-25 12:39:51 -07:00
Alexander Laamanen 2ed6c3ef5e Set output dir always according to the config. 2018-10-25 12:37:47 -07:00
Alexander Laamanen c940f7e754 Conditional reload. 2018-10-25 12:37:47 -07:00
Alexander Laamanen 17845beadc Fix the CommHost tests 2018-10-25 12:37:47 -07:00
Alexander Laamanen 5e74bcfb88 Fix tests, move remote_ default values to driver_config. 2018-10-25 12:30:57 -07:00
Alexander Laamanen 4d9cb19012 Refactor artifacts and output_dir implementations. 2018-10-25 12:21:24 -07:00
Alexander Laamanen 2d00dc6756 Add VMName to the vmx mods. 2018-10-25 11:17:09 -07:00
Alexander Laamanen 7b5943160b Re-enable the CommHost() call. Use common's driver factory. 2018-10-25 11:17:09 -07:00
Alexander Laamanen ba22090bc9 Move step_register and step_uload_vmx from iso to common. 2018-10-25 11:07:02 -07:00
Alexander Laamanen b5298464c5 Move the remote_driver from iso to common. 2018-10-25 11:01:22 -07:00
Alexander Laamanen 91c7089455 Implement the first version of the remote Clone(). 2018-10-25 10:37:45 -07:00
Alexander Laamanen 46cfb5a30c Move driver_esx5 to commons and allow it to be instantiated wtih NewDriver() 2018-10-25 10:33:37 -07:00
Megan Marsh c7b938c9d4
Merge pull request #6904 from hashicorp/fix_6890
Fix 6890
2018-10-24 10:43:34 -07:00
Adrien Delorme 8908a72fa9 builder/hyperv/vmcx: allow to set generation from buildfile
this commit fixes #6908
2018-10-24 12:20:52 +02:00
Adrien Delorme ed793a8fb8 make ValidateRegion a member of *AccessConfig and make it variadic 2018-10-24 11:26:53 +02:00
Megan Marsh fe044d8ff7 fix tests 2018-10-23 13:31:56 -07:00
Megan Marsh 340009009d Revert "Revert "Merge pull request #6892 from hashicorp/fix_6890""
This reverts commit 0cd3f36d50.
2018-10-23 09:58:27 -07:00
Megan Marsh 0cd3f36d50 Revert "Merge pull request #6892 from hashicorp/fix_6890"
This reverts commit 1c4062c316, reversing
changes made to 9bc41a23b9.
2018-10-23 09:34:05 -07:00
Megan Marsh 1c4062c316
Merge pull request #6892 from hashicorp/fix_6890
fix template-set credentials
2018-10-22 13:55:48 -07:00
Megan Marsh 0924a316b7 fix template-set credentials
update tests with mocked session
2018-10-22 13:53:40 -07:00
Megan Marsh cdd99564fd
Merge pull request #6891 from hashicorp/fix_6794
Fix 6794
2018-10-22 11:10:05 -07:00
Megan Marsh 091efae8bb
Merge branch 'master' into misc 2018-10-22 11:07:30 -07:00
Megan Marsh fd8a85042d use strconv.Quote instead of fmt.Sprint 2018-10-22 10:59:47 -07:00
Megan Marsh 18c5e8deb8 fix 2018-10-19 13:46:55 -07:00
Megan Marsh 1e4133cbf9 quote upload path 2018-10-19 13:43:13 -07:00
Megan Marsh 3f591d78f3 quote vmx path in register function 2018-10-19 13:42:40 -07:00
Megan Marsh 8cba32d526 escape all the d.sh calls that contain paths 2018-10-19 13:42:40 -07:00
Megan Marsh 5b9adc0c48 single quotes 2018-10-19 13:42:40 -07:00
Megan Marsh 9573013d3a
Merge pull request #6872 from aspectcapital/disable-ena-support
Add support to explicitly disable ENA support
2018-10-19 10:54:38 -07:00
Megan Marsh 9fe27c225b
Merge pull request #6703 from shield-9/wait_volume
OpenStack: wait for volume availability when cleaning up
2018-10-19 10:25:51 -07:00
Matt Dainty feb8067c7d Convert `ena_support` to a pointer
This means it now has three states, `true`, `false`, & `nil`. The
default state is now `nil` which does nothing instead of `false` which
now will explicitly disable ENA support instead of just not enabling it.
2018-10-19 12:40:43 +01:00
Josh Soref b68168807a Miscellaneous doc improvements
backticks, spaces, commas

In general, a list of items should have a space after each comma.
While there are editorial styles that suggest commas inside quotations,
they're horrible advice when the backticks are describing specific
character for a user to enter.

one off indent filters section

singular

backticks...

word wrap long lines...

spelling: macOS

contributing: clarify closing case
contributing: link to changelog
contributing: point to git remote...
contributing: split commands from descriptions
contributing: grammar
spelling: github
grammar: comma after etc.
spelling: macOS
grammar: i.e.
alicloud: use relative link
alicloud: use backticks
alicloud: bits
alicloud: such as
grammar: comma after etc.
avoid linking periods
grammar: period
amazon-chroot: IOPS
amazon-chroot: use backticks
amazon-chroot: link to section
amazon-chroot: whether-or-not; period
amazon-ebs: period
amazon-ebs: use relative link
amazon-ebs: use backticks
amazon-ebs: comma
amazon-ebs: bold
amazon-ebssurrogate: comma after etc.
amazon-ebssurrogate: this builder
amazon-instance: this builder
amazon-ebssurrogate: set this
amazon-ebssurrogate: whether-or-not
amazon-ebssurrogate: period
amazon-ebssurrogate: bold section reference
amazon-ebssurrogate: backticks...
amazon-ebssurrogate: commas around e.g.
spelling: precedence
spelling: i.e.
amazon-ebssurrogate: backticks...
2018-10-18 19:09:49 -04:00
Megan Marsh 57f87f58b9
Merge pull request #6374 from rickard-von-essen/aws-filters
builder/amazon: Add suppport for vpc_filter, subnet_filter, and security_group_filter
2018-10-18 14:34:02 -07:00
Megan Marsh 3175dcdf81
Merge pull request #6807 from dev-rowbot/qemu-net-device-6804
Fix for #6804 - KVM/QEMU Network "has no peer"
2018-10-18 14:09:22 -07:00
Megan Marsh c5b6eff691
Merge pull request #6871 from LKaemmerling/master
Add hcloud builder
2018-10-18 11:13:16 -07:00
Lukas Kämmerling e4a670d2a2 Remove Debug Message 2018-10-18 10:29:06 +02:00
Adrien Delorme 29d041ea8a
Merge pull request #6858 from hashicorp/tests_race_detector
test with race detection enabled + fix race on progressbar
2018-10-18 09:48:03 +02:00
Lukas Kämmerling bad1b95a49 Unify steps, fix some typos 2018-10-18 08:03:04 +02:00
Megan Marsh fd89d4f020
Merge pull request #6827 from skish/qemuDiskZero
builder/qemu add drive detect-zeroes option
2018-10-17 19:12:38 -07:00
Megan Marsh 2266514408
Merge pull request #6843 from gmmephisto/pr-master-aws-security-group
aws: wait for temporary security group before authorize rules
2018-10-17 14:08:49 -07:00
Megan Marsh e7d3a30c0e
Merge pull request #6865 from hashicorp/fix_6862
Fix 6862
2018-10-17 13:07:29 -07:00
Mikhail Ushanov 00c96fc400 aws: use IpPermissions for authorizing temporary security group
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-17 22:00:25 +03:00
Mikhail Ushanov b316be51cd aws: wait for temporary security group before authorizing
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-17 22:00:24 +03:00
Megan Marsh b0cfecf314 remove unnecessary valid flag 2018-10-17 11:03:31 -07:00
Matt Dainty 9e0fae9db3 Add support to explicitly disable ENA support
If `ena_support` is set to false then it previously didn't do anything
whereas now it will explicitly disable ENA support.

Fixes #6852
2018-10-17 14:58:07 +01:00
Adrien Delorme 410bee0666 make TestStepShutdown_shutdownDelay less strict on schedule 2018-10-17 12:49:38 +02:00
Lukas Kämmerling 270110767c
Add hcloud Builder 2018-10-17 12:15:47 +02:00
Adrien Delorme af3b818de0 TestBuilderPrepare_ISOChecksumType: set config["switch_name"] = "switch" to avoid using builder.detectSwitchName which can lock down in CI mode 2018-10-17 12:09:24 +02:00
Adrien Delorme 0237956e66 builder/virtualbox/common/step_shutdown_test.go: compare durations instead of floats & ouput duration 2018-10-17 11:19:57 +02:00
Adrien Delorme 1ca21499c6 Revert "make builder/hyperv/vmcx/builder_test.go invisible to windows"
This reverts commit e692dee2d8.
2018-10-17 10:21:53 +02:00
Adrien Delorme b80a0fed42 make builder/parallels/common/output_config_test.go invisible to windows 2018-10-17 09:59:13 +02:00
Adrien Delorme e692dee2d8 make builder/hyperv/vmcx/builder_test.go invisible to windows 2018-10-17 09:57:42 +02:00
Megan Marsh d4767845f0 fix tests 2018-10-16 15:01:13 -07:00
Megan Marsh 7c3f0aa3b2 make sure region validation catches authentication errors 2018-10-16 14:17:30 -07:00
Mikhail Ushanov ee133482b4 aws: add validation for device_name parameter
cause it's required in block-device-mapping.

Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-16 21:37:48 +03:00
Adrien Delorme 8a6c55dd69 make builder/hyperv/iso/builder_test.go invisible to windows 2018-10-16 19:09:35 +02:00
Matthew Aynalem 28eff7303e builder/googlecompute: validate startup_script_file exists 2018-10-15 16:09:33 -07:00
Megan Marsh cdc6c57b31
Merge pull request #6822 from hashicorp/fix_6774
Fix 6774
2018-10-10 13:25:58 -07:00
Megan Marsh f5af2afc06
Merge pull request #6818 from hashicorp/fix_6732
default wait time for amazon import to one hour.
2018-10-10 11:27:34 -07:00
Megan Marsh f331327f24
Merge pull request #6823 from hashicorp/fix_6794
fix datastore path that contains spaces
2018-10-10 10:06:15 -07:00
Megan Marsh 53bce398bb add Managed Image test to azure artifact 2018-10-10 10:04:19 -07:00
Megan Marsh 5dc4ff95da fix azure artifact so it works with managed images as well as VHDs 2018-10-10 10:04:11 -07:00
Christopher Boumenot 520dea23fd
Merge pull request #6798 from mbearup/mb-sharedgallery
Consume images from Azure Shared Image Gallery
2018-10-10 09:53:18 -07:00
mbearup de8d30d77c Update tests for Azure Shared Image Gallery 2018-10-10 09:20:34 -07:00
Konstantin Shloma fe341e2bd0 fix go source formatting
add description to documentation page
2018-10-10 16:16:23 +03:00
Konstantin Shloma 1155347b55 add qemu disk detect-zeroes= option 2018-10-10 14:38:59 +03:00
mbearup c7180413b0 Fix tests for Shared Image Gallery 2018-10-09 16:38:50 -07:00
Megan Marsh e5e75df033 fix datastore path that contains spaces 2018-10-09 16:36:55 -07:00
mbearup a3a2a9e970 Fix issue with composite literal in test 2018-10-09 15:35:09 -07:00
mbearup 335feaf89c Convert shared_image_gallery options to a struct
Updates tests and documentation for shared_image_gallery
2018-10-09 13:56:49 -07:00
Megan Marsh 895e7fe111
Merge pull request #6812 from hashicorp/remove_unused_processPrivateKeyFile
removed unused processPrivateKeyFile func & tests
2018-10-09 13:14:11 -07:00
Megan Marsh 02bfac118f default wait time for amazon import to one hour. 2018-10-09 13:08:42 -07:00
Megan Marsh f494d87dc5
Merge pull request #6747 from hashicorp/fix_6743
abort if image import fails
2018-10-09 12:56:28 -07:00
Adrien Delorme b2e2d3b008 removed unused processPrivateKeyFile func & tests 2018-10-09 11:56:43 +02:00
Rowan Potgieter 65db6be6b9 Fix for #6804
The user QEMU args may overwrite the default -device.
This results in no network
2018-10-06 14:40:43 +02:00
mbearup 5373b8586d Update tests for Azure Shared Image Gallery 2018-10-05 16:04:07 -07:00
mbearup b6bb5d4b4d Fix format/spacing for config.go 2018-10-05 10:52:02 -07:00
mbearup c1e0146d33 Dynamically set apiVersion for Shared Image Gallery scenario. 2018-10-03 16:33:28 -07:00
mbearup d21b13cb85 Modify variable names for Shared Image Gallery.
Add checks for Shared Image Gallery options.
2018-10-03 16:10:46 -07:00
Adrien Delorme f44dfcc62f
Merge pull request #6727 from hashicorp/fix_6723
reset poll delay seconds default to 2 because it can actuall be used …
2018-10-03 11:15:42 +02:00
Adrien Delorme 146db5667a fix intermitent TestProcessPrivateKeyFile_encrypted failure
Because of deficiencies in the encrypted-PEM format, it's not always possible to detect an incorrect
password. In these cases no error will be returned but the decrypted DER bytes will be random noise.

this closes #3337
2018-10-01 10:29:30 +02:00
mbearup 55be0da5da Initial changes to support Shared Image Gallery 2018-09-30 13:56:44 -07:00
Adrien Delorme b7b1720a91
Merge pull request #6772 from fflorens/scaleway-add-boottype
scaleway: add boottype parameter in config
2018-09-27 16:51:01 +02:00
Florian Florensa 9ea5104b74 scaleway: add boottype parameter in config 2018-09-27 16:37:07 +02:00
Adrien Delorme 37c6f08abe Revert "Fix bugs"
This reverts commit 02139dcb69 that constitutes pr #6701
2018-09-27 16:27:34 +02:00
Adrien Delorme 016b0985a6 builder/openstack: use config as a pointer so values could be set
this commit will close #6712
2018-09-27 16:27:34 +02:00
Adrien Delorme b328d3569d builer/triton: pass config as a pointer so values could be set 2018-09-27 16:27:34 +02:00
Adrien Delorme 22d3e9b5c4 builder/amazon/ebs: pass config as a pointer so values could be populated by a run 2018-09-27 16:27:34 +02:00
mvaude 7f78eef08d scaleway: fix builder problems with ssh keys
The builder is currently failing with the last packer version.

This commit is fixing:
- the ssh keys and configuration management (the config is passed through a pointer and the ssh keys through the config instead of the runner states)
- the key size for generated ssh key
- the public key added as a tag to the instance<Paste>

fix #6757
2018-09-27 15:40:18 +02:00
Matthew Hooker 9181570bc3
remove stray struct dumps in logs 2018-09-27 00:14:05 -07:00
zhuzhih2017 676b28ecc5
Merge pull request #6764 from chhaj5236/feature/support_disable_stop_instance
support disable_stop_instance option for some specific scenarios
2018-09-27 14:52:07 +08:00
zhuzhih2017 f59cde03c4
Merge pull request #6763 from chhaj5236/fix/invalid_type_convert
fix type error in step_create_tags
2018-09-27 14:49:52 +08:00
bozhi.ch bb19cdeb55 support disable_stop_instance option for some specific scenarios 2018-09-25 22:02:05 +08:00
bozhi.ch 1f3a517a19 fix type error in step_create_tags 2018-09-25 20:20:10 +08:00
Rickard von Essen 838d5021f5 openstack: use source_image_name to find UUID 2018-09-21 10:35:15 +02:00
Daisuke Takahashi 3b8aba2d24 OpenStack: wait for volume availability when cleaning up 2018-09-21 10:13:45 +09:00
Megan Marsh d616f0ba71 abort if image import fails 2018-09-20 13:18:59 -07:00
Daisuke Takahashi c848f59a55 Check condition for image_disk_format option 2018-09-20 11:02:30 +09:00
Daisuke Takahashi b7bd3d4b34 OpenStack: Change option name to `image_disk_format` 2018-09-20 10:44:28 +09:00
Daisuke Takahashi 904dd1df63 Add disk_format option for OpenStack builder 2018-09-20 10:44:28 +09:00
Megan Marsh b0774d155a
Merge pull request #6512 from sharmaanshul2102/5786-use-describe-regions-for-validation-aws
Use DescribeRegions for aws region validation
2018-09-19 10:37:42 -07:00
Megan Marsh 79093da6ad skip region validation in tests that don't care; refactor Prepare func so we can test region validation logic with a mock 2018-09-19 10:30:08 -07:00
Adrien Delorme 9ba959598b
Merge pull request #6729 from hashicorp/fix_ssh_digitalocean
builder/digitalocean: pass config as a pointer so that ssh configuration is correctly set
2018-09-19 18:26:36 +02:00
zhuzhih2017 9e3e2e83ae
Merge pull request #6720 from chhaj5236/fix/attach_keypair
fix attaching keypair error due to missing keypair name
2018-09-19 14:14:55 +08:00
Megan Marsh 93f1155a14 remove test-related special casing 2018-09-18 08:08:36 -07:00
bozhi.ch 3c312eb2a0 change b.config to pointer 2018-09-18 21:40:57 +08:00
Adrien Delorme 5389ab1694 pass config as a pointer so that ssh configuration is correctly set 2018-09-18 11:36:21 +02:00
Anshul Sharma ef3c10c403 Modify Validate Region for test cases 2018-09-17 14:45:55 -07:00
Anshul Sharma 98f13eaf29 Use DescribeRegions for aws region validation 2018-09-17 14:45:55 -07:00
Megan Marsh f4e6d06e68 reset poll delay seconds default to 2 because it can actuall be used in one part of the conditional tree for applyEnvOverrides 2018-09-17 11:10:50 -07:00
chhaj5236 43e091de15
Merge branch 'master' into feature/support_tags 2018-09-17 16:50:44 +08:00
zhuzhih2017 31bbe2983b
Merge pull request #6688 from chhaj5236/feature/support_ssh_private_ip
support ssh with private ip address
2018-09-17 16:46:38 +08:00
bozhi.ch b3aae89a53 fix attaching keypair error due to missing keypair name 2018-09-16 18:19:00 +08:00
bozhi.ch b8a3e3b8f4 support adding tags to image 2018-09-16 18:16:13 +08:00
Adrien Delorme fc75449e06
Merge pull request #6713 from hashicorp/cleanup_keys
new option allowing user to clean up the ephemeral ssh key from the a…
2018-09-14 11:12:33 -07:00
Megan Marsh 38cc525ec7 new option allowing user to clean up the ephemeral ssh key from the authorized_keys file 2018-09-14 11:06:38 -07:00
Daisuke Takahashi 02139dcb69 Fix bugs 2018-09-13 14:39:38 +09:00
Adrien Delorme 770f61e682 spot instance creation, only set blockDurationMinutes when > 0 2018-09-12 10:21:39 -07:00
Adrien Delorme 2e73ed8d46 pass Comm instance to fix Spot instance creation 2018-09-11 18:20:14 -07:00
Matt DeBoer 09797df958 use a UI wrapper to auto-decode error messages
update docs to reflect optional config
2018-09-11 16:05:43 -07:00
bozhi.ch 743be8a808 support ssh with private ip address 2018-09-11 16:56:57 +08:00
Megan Marsh a0edaf6c46 Going to revert this change for now, becuase of potential issues that arise from calling Prepare() twice
Revert "use statebag instead of SetSharedState for winRM password"

This reverts commit b35acbd879.
2018-09-10 16:48:42 -07:00
Adrien Delorme e02d0dacc4
Merge branch 'master' into aws-filters 2018-09-07 16:14:00 +02:00
Sargun Dhillon 63d784023f Add support to support non-gp2 volume types for building from_scratch 2018-09-06 13:22:09 -07:00
Sargun Dhillon 07ce820c70 Enable setting the volume type when building with the Amazon Chroot builder 2018-09-06 13:22:09 -07:00
Megan Marsh b94e6e913e
Merge pull request #6670 from sargun/fix-ena-on-pv
Allow users to build hvm images from pv images to have ena_support
2018-09-06 12:50:46 -07:00
Adrien Delorme 4682b3a9d2 refactor possible random strings into common/random 2018-09-05 10:26:52 +02:00
Adrien Delorme b80e1d51c6 aws: when building an AMI with 'encrypt_boot: true', randomize the name of the temporary AMI 2018-09-05 10:24:28 +02:00
Adrien Delorme 170b2f3383 builder/azure/common.RandomString-> common/random.String
* to share them
* also removed unused PassworString func & arm.TempPasswordAlphabet package const
2018-09-05 10:24:28 +02:00
Sargun Dhillon 902497d6ce Allow users to build hvm images from pv images to have ena_support 2018-09-04 18:16:52 -07:00
Megan Marsh cb35829f80
Merge pull request #6411 from jmartin-r7/esxi_compact
add support for disk compaction to esx5 builder
2018-09-04 12:44:32 -07:00
Christopher Boumenot 2e294da82a
Merge pull request #6644 from riezebosch/master
[azure-arm] retry cleanup individual resources on error
2018-09-04 11:40:27 -07:00
Megan Marsh 349f9ae62b
Merge pull request #6641 from hashicorp/increase_retries
Increase retries
2018-09-04 11:39:28 -07:00
Adrien Delorme 819bda50d5
Merge pull request #6648 from hashicorp/fix_6642
Update public google cloud image projects
2018-09-03 09:29:31 +02:00
Adrien Delorme 2a2734505b
Merge pull request #6649 from hashicorp/fix_6569
Fix 6569
2018-09-03 08:44:07 +02:00
RenaudS 26aab49aaf aws spot instances: add block_duration_minutes option (#6638)
* Add block_duration_minutes option

* int64 cannot be nil

* Update doc

* Fix formating
2018-09-03 08:33:58 +02:00
Megan Marsh 4472ecccb0 fix waiters that weren't applying env defaults 2018-08-31 13:30:41 -07:00
Megan Marsh d00b815c06 Update public google cloud image projects 2018-08-31 13:13:19 -07:00
Manuel Riezebosch fcfa54fb1d [azure-arm] retry cleanup individual resources on error 2018-08-31 13:43:38 +02:00
Adrien Delorme 61480f41dc fix some go vet issues in tests ( composite literal uses unkeyed fields ) 2018-08-31 11:54:12 +02:00
Jeffrey Martin 1833b4edaf
validate compaction is skipped when not 'thin' 2018-08-30 16:44:00 -05:00
Jeffrey Martin b51cd22b21
document ESXi disk compaction & use verbose option 2018-08-30 16:44:00 -05:00
Jeffrey Martin 09c71f3810
add support for disk compaction to esx5 builder 2018-08-30 16:43:53 -05:00
Megan Marsh 9926988ab7
Merge pull request #6621 from hashicorp/ssh_keys_centralised
Merge ssh fields usage
2018-08-30 14:13:21 -07:00
Megan Marsh d606339edc
Merge pull request #6635 from hashicorp/fix_6493
fix chroot communicator to properly escape quotes
2018-08-30 09:40:03 -07:00
Megan Marsh 2b9f937c23 increase max retries from 3 to 20 2018-08-30 09:35:06 -07:00
Adrien Delorme cbbfc6630d scaleway: stop using config from statebag 2018-08-30 17:58:09 +02:00
Adrien Delorme d159c0900b openstack: use config only where needed 2018-08-30 17:52:11 +02:00
Adrien Delorme df9e756865 pass the Comm instance to the amazon ebs builders steps 2018-08-30 12:50:29 +02:00
Adrien Delorme 157691c710 remove unecessary get/pug config in tests; those are being referenced 2018-08-30 12:07:37 +02:00
Adrien Delorme 94d5bb7a3b revert test changes of builder/googlecompute/step_create_ssh_key_test.go 2018-08-30 12:04:21 +02:00
Harvey Lowndes 344e7e8b92 Validation for tag configuration 2018-08-29 15:31:05 -07:00
Harvey Lowndes cc7d4e4a95 Add support for freeform tagging of images 2018-08-29 15:31:05 -07:00
Adrien Delorme 050a98e8bb googlecompute builder: use config from statebag 2018-08-29 18:15:09 +02:00
Adrien Delorme b0c09087a2 move SSHInterface/SSHIPVersion fields to communitator.Config struct 2018-08-29 14:51:28 +02:00
Adrien Delorme cd851f8ac2 use public ssh key & key name from config instead of the statebag 2018-08-29 14:40:33 +02:00
Adrien Delorme 0938b640cc use key pair name from config 2018-08-29 14:40:33 +02:00
Adrien Delorme 1e71712cc9 builder.alicloud: stop using config from statebag 2018-08-29 14:40:33 +02:00
Adrien Delorme 4fdf5714a6 builder.scaleway: use c.Comm for ssh 2018-08-29 14:40:33 +02:00
Adrien Delorme 0f9eddda3a builder.oracle: use c.Comm for ssh 2018-08-29 14:40:33 +02:00
Adrien Delorme 92570a2725 builder.openstack: use c.Comm for ssh 2018-08-29 14:40:33 +02:00
Adrien Delorme 4982627dd2 builder.gcp: use c.Comm for ssh 2018-08-29 14:40:33 +02:00
Adrien Delorme e0e6b0b8f7 builder.cloudstack: use c.Comm for ssh 2018-08-29 14:40:33 +02:00
Adrien Delorme ef4ca9c48e builder.amazon: use c.Comm for ssh 2018-08-29 14:40:33 +02:00
Adrien Delorme dffcbb7a35 builder.alicloud: use c.Comm for ssh 2018-08-29 14:40:33 +02:00
Adrien Delorme 9a9b82715b config.Comm.SSHKeyPair => SSHKeyPairName 2018-08-29 14:40:33 +02:00
Adrien Delorme 3a4bb26150 builder.aws: use key pair from comm struct 2018-08-29 14:40:33 +02:00
Adrien Delorme 293c485372 builder.aws: use SSHAgentAuth from Comm 2018-08-29 14:40:33 +02:00
Adrien Delorme ef08c441c9 builder.aws: use Comm field for StepKeyPair & StepGetPassword 2018-08-29 14:40:33 +02:00
Adrien Delorme 7c358eed2f removed unused builder/azure/common/lin.StepGeneralizeOS struct 2018-08-29 14:40:33 +02:00
Adrien Delorme 3d46fbd4f2 removed unused builder/azure/common/lin.StepCreateCert struct 2018-08-29 14:40:33 +02:00
Adrien Delorme 25de7ad1f2 PrivateKey => PrivateKeyFile 2018-08-29 14:40:33 +02:00
Adrien Delorme 324c46279b up test 2018-08-29 14:40:33 +02:00
Adrien Delorme 5369c15459 helper: communicator.SSHFileSigner => ssh.FileSigner
* had to to avoid circular dependency
* this commit fixes #6631 ( esxi cannot be reached by ssh )
2018-08-29 14:40:33 +02:00
Adrien Delorme b83c72fd54 more private keys in config 2018-08-29 14:40:32 +02:00
Adrien Delorme 336cac29d4 also use config.SSHPrivateKey for azure-arm builds 2018-08-29 14:40:32 +02:00
Adrien Delorme d49ad12895 update gcp ssh tests 2018-08-29 14:40:32 +02:00
Adrien Delorme 663c8134ef GCP: put ssh public/private key in config 2018-08-29 14:40:32 +02:00
Adrien Delorme 51d2aac9f6 SSHPrivateKey => SSHPrivateKeyFile 2018-08-29 14:40:32 +02:00
Megan Marsh e4f6b6f720 fix chroot communicator to properly escape quotes 2018-08-28 09:16:43 -07:00
Matthew Hooker 7519037562
Merge pull request #6629 from hashicorp/travisbuild
travis builds go 1.11. remove 1.9
2018-08-24 20:51:31 -07:00
Matthew Hooker 3f1a9766f4
formatting verb fixes for go 1.11 2018-08-24 16:18:21 -07:00
Matthew Hooker e41e99954d
go 1.11 format rules 2018-08-24 15:56:44 -07:00
Megan Marsh c5b346b07b
Merge pull request #6393 from DanHam/fix-hyperv-export
Various improvements to Hyper-V ISO and VMCX builders
2018-08-24 15:52:49 -07:00
Megan Marsh bf191d1ef6
Merge pull request #6204 from arizvisa/GH-6197
Specify "bios.hddOrder" during the CreateVMX step for the vmware-iso builder.
2018-08-24 15:46:31 -07:00
Megan Marsh b35acbd879 use statebag instead of SetSharedState for winRM password 2018-08-24 13:51:16 -07:00
Rickard von Essen 23f62f221e Only filter SG's on VPC if it's set. Only use VPC's and Subnets that are available 2018-08-24 20:24:48 +02:00
Megan Marsh fa99f931b7
Merge pull request #6601 from hashicorp/fix_6536
Increase waiter timeout for AWS WaitUntilImageAvailable command
2018-08-24 09:35:58 -07:00
Adrien Delorme 6bbcd3e914
Remove remaining unused ssh config funcs and add missing calls (#6622)
* Remove duplicate unused SSHConfig funcs

* call to SSHConfigFunc() for azure/arm builder

* ncloud too

* remove empty ncloud file
2018-08-24 16:00:40 +02:00
Rickard von Essen 533967cb66 builder/amazon: Add suppport for security_group_filter
Allow selecting SG's using a filter. Also some cleanup of vpc_filter and
subnet_filter.
2018-08-24 12:42:38 +02:00
Megan Marsh 340363a649
Merge pull request #6613 from hashicorp/merge_ssh_config_funcs
Merge ssh config funcs from builders
2018-08-23 16:03:36 -07:00
Megan Marsh 1f79b430ee
Merge pull request #6610 from hashicorp/filter_logs
Filter logs
2018-08-23 13:30:21 -07:00
Megan Marsh 7f518cc2d0
Merge pull request #6616 from hashicorp/fix_6496
added new template variables to replace PACKER_KEY_INTERVAL with tuna…
2018-08-23 13:21:31 -07:00
Megan Marsh 31d4f8af45 use a time.Duration instead of a hardcoded ms 2018-08-23 13:16:01 -07:00
Rickard von Essen 9840862757 builder/amazon: Add suppport for vpc_filter and subnet_filter
First step of adding support for discovering VPC's and Subnets using
filters.
2018-08-23 12:52:03 +02:00
Rickard von Essen 70cfafb75c
Merge pull request #6490 from tcarrio/most-recent-image-openstack
OpenStack source image search filter
2018-08-23 12:41:06 +02:00
Tom Carrio e2fe5cd775 Updated test cases to cover bad filters and empty() 2018-08-22 18:23:12 -04:00
Megan Marsh bb319fb1e8
Merge pull request #6607 from hashicorp/gcp_min_cpu_platform
GCP: min cpu platform
2018-08-22 12:58:34 -07:00
Megan Marsh 918db58604 added new template variables to replace PACKER_KEY_INTERVAL with tunable key and keygroup intervals depending on driver used 2018-08-22 11:37:56 -07:00
Adrien Delorme e5ffa9e5b3 use SSHConfigFunc on right member in builder/parallels/pvm/builder.go 2018-08-22 18:23:23 +02:00
Adrien Delorme fa44a4546f use ssh.ParsePrivateKey where we can 2018-08-22 18:23:09 +02:00
Adrien Delorme 41f6e0334d refactor all copy pasted sshConfig with into communicator.Config.SSHConfigFunc
* still need to append the auth methods into an array for gracefullness
2018-08-22 17:02:23 +02:00
Rickard von Essen 057a635cab
Merge pull request #6532 from sermilrod/Allowing-fixed-port-in-forwarding-rules
Cloudstack builder: adding public_ssh_port flag to use a fixed port in the forwarding rules
2018-08-22 14:27:38 +02:00
Rickard von Essen 3b49caaf40 OpenStack: refactored how source_image_filter is handled to remove reflection 2018-08-22 13:37:43 +02:00
Sergio Millan Rodriguez befdb59da6 renaming public_ssh_port to public_port 2018-08-22 10:17:46 +01:00
Rickard von Essen bd1961b927 Correctly fail if no Image matches filter 2018-08-21 12:46:42 +02:00
Adrien Delorme b038cd10f5 GCP: Allow to set MinCpuPlatform 2018-08-21 10:09:30 +02:00
Adrien Delorme e37f126cf1 update gcp google.golang.org/api/compute/v1/ 2018-08-21 10:09:01 +02:00
Megan Marsh ff6a039d5b replace scrubconfig with packer.LogSecretFilter.Set
filter winrm password from logs
Add new root-level packer template option, sensitive-variables, to tell us what user variables to mark sensitive.
2018-08-20 15:35:55 -07:00
Matthew Hooker 31fcfe4bc2 PoC for filtering logs 2018-08-20 15:20:21 -07:00
Adrien Delorme 6b3844a64f
Revert "allow to use ISO images in-place v.s. copying them" 2018-08-20 10:48:06 +02:00
Tom Carrio c5fe1e9e34 Updated to @rickard-von-essen's code review suggestions, including:
- filter build and error checking in Prepare stage (multiErr created in the original function will be returned to Prepare and appended, so all errors show).
- source_image overrides source_image_filter.
- Doc edit
2018-08-19 18:47:07 -04:00
Tom Carrio 5ca5c037eb Updated filter parser to log all invalid values/fields provided by user 2018-08-19 18:45:22 -04:00
Tom Carrio fc19cd8d28 Updated limit logic, removed limiter, updated test cases and sort field used 2018-08-19 18:45:22 -04:00
Tom Carrio 4147062802 Internally handling most_recent logic. 2018-08-19 18:45:22 -04:00
Tom Carrio 2d5d1890d4 Switching sort method 2018-08-19 18:45:22 -04:00
Tom Carrio 8d98237a15 I should have a git-status alias to make fmt 2018-08-19 18:45:22 -04:00
Tom Carrio 036918b81b Updated to comments in PR#6490 - Thanks @haxorof 2018-08-19 18:45:22 -04:00
Tom Carrio db3d2682b5 Updated allowed filters to tags, visibility, owner, and name. Test cases updated and passed 2018-08-19 18:45:22 -04:00
tcarrio e9e58e6b2b Tags field parsed from "tags" and updated test case 2018-08-19 18:45:22 -04:00
Tom Carrio c8fd53d60b make fmt 2018-08-19 18:45:22 -04:00
Tom Carrio de9999ecb9 Updated tag to slice, docs, comments, only active images, source_image_name supercedes filter name 2018-08-19 18:45:22 -04:00
tcarrio e776ad51a9 Removing statement from old image erroring logic 2018-08-19 18:45:22 -04:00
tcarrio 3a6ab0fc0e Updated test logic and Error->Errof for formatted output. 2018-08-19 18:45:22 -04:00
tcarrio 6dc71590eb Updated OpenStack Builder docs and tests 2018-08-19 18:45:22 -04:00
tcarrio 94018c691c Fixed step interface, added step to builder, passing all tests for new image_query.go 2018-08-19 18:45:22 -04:00
Tom Carrio a87c8fec38 Fixing up reflection issues on ListOpts builder 2018-08-19 18:39:42 -04:00
Tom Carrio 810a602a1b Added testing on query helper functions 2018-08-19 18:39:42 -04:00
Tom Carrio 33caed3531 Completed filters and most_recent processing using OpenStack imageservice API 2018-08-19 18:39:42 -04:00
Megan Marsh 00c6ec979f do 30 minutes not 25 2018-08-17 13:30:02 -07:00
Megan Marsh 00de0f4996 increase the timeout for waiting for an ami to become available 2018-08-17 13:27:19 -07:00
Megan Marsh 5dbd71b857
Merge pull request #6593 from hashicorp/iso_inplace
allow to use ISO images in-place v.s. copying them
2018-08-17 10:27:50 -07:00
Andrei Ozerov 6bf442f039 OpenStack builder: fix floating IP docs
Update website documentation about "floating_ip_network" parameter.
Add new inline comment about alghoritm that is used for checking
floatingIP-related configuration parameters.
2018-08-17 07:55:31 +03:00
Andrei Ozerov 103403db48 OpenStack builder: do not always use floating IPs
Only associate floating IPs if user provided "floating_ip_network" or
"floating_ip".
Remove FindExternalNetwork helper method because it won't be used.
2018-08-17 00:49:06 +03:00
Andrei Ozerov 5d6ba4301d OpenStack builder: fix floating_ip_pool validation
Only use "floating_ip_pool" if "floating_ip_network" wasn't set.
Update unit test for the OpenStack builder parameters.
2018-08-17 00:15:18 +03:00
Andrei Ozerov 1af899248b OpenStack builder: allow floating IP network name
Add support for the external network reference by it's name apart from
ID.
Include external network id in a log message of
the openstack/step_allocate_ip.
2018-08-16 23:38:41 +03:00
Andrei Ozerov c9047cbfbe OpenStack builder: update floating IP params
Rename "floating_network" to the "floating_ip_network".
Return old "floating_ip_pool" parameter for backward compatibility with
old configuration files. It's value will be passed to the
"floating_ip_network" parameter.
2018-08-16 22:18:48 +03:00
Andrei Ozerov 0eef9b4292 OpenStack builder: floating IP refactoring
Remove usage of the deprecated OpenStack Compute service floating IP
management and add methods to work with the OpenStack Networking
service floating IPs API.

Remove usage of the deprecated OpenStack Compute service floating IP
pools and add methods to work with the OpenStack Networking service
external networks API.

Move reusable logic of working with the OpenStack Networking service API
to a separate methods in the networking.go file.

Pass error messages from the API services to the ui messages in the
allocate IP step.
2018-08-16 22:15:26 +03:00
zhuzhih2017 2eafdb33a2
Merge pull request #6588 from xiaozhu36/master
Support describing and checking source image coming from marketplace
2018-08-16 20:58:52 +08:00
Andrei Ozerov 3316d40527 OpenStack builder: make volume type optional
Volume type parameter should be optional as described in API reference:
https://developer.openstack.org/api-ref/block-storage/v3/#create-a-volume

It should be enforced by the OpenStack cluster if not specified.
2018-08-16 12:40:11 +02:00
Andrei Ozerov 572cdeecd1 OpenStack builder: create image from blockstorage
Allow to create final image from the Block Storage service volume.
2018-08-16 12:40:11 +02:00
Andrei Ozerov c0ffe7eb89 OpenStack builder: add StepDetachVolume
Add a step of detaching Compute instance volume if it's created using
the Block Storage service.
It is needed to create a final image.

This commit also moves common volume functions to a different file and
fixes some messages in the StepCreateVolume.
2018-08-16 12:40:11 +02:00
Andrei Ozerov 005f7e56a7 OpenStack builder: cleanup blockDeviceMappingV2
There is no need to indicate type of the list elements, remove it.
2018-08-16 12:40:11 +02:00
Andrei Ozerov d51e683bf7 OpenStack builder: add Block Storage volumes
This commit allows user to use the Block Storage v3 volume as the
Compute instance root volume.
Also it adds new volume-related parameters to the builder.
2018-08-16 12:40:11 +02:00
Megan Marsh ac3554a37f
Merge pull request #6594 from rickard-von-essen/mode-check
Check that only certain files are executable
2018-08-15 13:07:00 -07:00
Megan Marsh 3362897c44
Merge pull request #6585 from hashicorp/do_6584
fix security hole with ami filter
2018-08-15 10:26:40 -07:00
Rickard von Essen 074b170ed4 Fixed exec bit 2018-08-15 16:13:34 +02:00
Rickard von Essen 25452945d7
Merge pull request #6546 from mzupan/do-add-tags
Add tags to DigitalOcean Droplets
2018-08-15 15:52:32 +02:00
Adrien Delorme 17f2949e36 remove stuttering; ISOConfig.InplaceISO -> Inplace 2018-08-15 15:51:25 +02:00
Rickard von Essen 889c89ec79 Validate tags 2018-08-15 15:27:00 +02:00
Adrien Delorme 82e480a285 allow to use ISO images inplace v.s. copying them 2018-08-15 14:37:38 +02:00
Rickard von Essen 9e9f0d2ab9
Merge pull request #6570 from cb-oath/openstack-builder-ports
add support for ports to the OpenStack builder
2018-08-15 13:35:48 +02:00
Rickard von Essen c962e7b856 Simplified loop code 2018-08-15 13:12:47 +02:00
Megan Marsh 71cad4f2a9 fix tests 2018-08-14 12:30:05 -07:00
He Guimin 1a17b799f1 Support describing and checking source image coming from marketplace 2018-08-15 00:14:02 +08:00
Megan Marsh 250da0ab49 fix security hole with ami filter 2018-08-13 17:01:13 -07:00
Christopher Boumenot 39fc8593de
Merge pull request #6576 from double16/vagrant-azure
Add to vagrant post-processor support for Azure
2018-08-09 12:36:22 -07:00
Patrick Double 2868971a9b Fixes per code review 2018-08-09 07:14:14 -05:00
Patrick Double d796edc783 Add to vagrant post-processor support for Azure 2018-08-08 10:04:28 -05:00
Megan Marsh 5585855265
Merge pull request #5165 from bennu/esxi-remote-cache
vmware-iso:esxi5 using ISO files uploaded by packer to datastore
2018-08-06 14:31:19 -07:00
Megan Marsh 99d1a1a297
Merge pull request #6541 from rsclarke/qemu-ssh-agent
add ssh agent support for qemu builder
2018-08-06 13:43:26 -07:00
Megan Marsh 57dd1c3ca2
Merge pull request #6543 from thedrow/lxc-root-path
Determine lxc root according to the running user
2018-08-06 11:34:01 -07:00
chbell43 aaa42543e6 fix formatting 2018-08-03 21:32:34 +00:00
chbell43 5f9d4b729f add support for ports to the OpenStack builder
For networks that have multiple subnets, we may want to target a single
subnet.  OpenStack doesn't let you target a single subnet in a network
and so you need to make a port.
2018-08-03 20:46:36 +00:00
Nye Liu 6d6212b75e Fix issue #6561 - Pass "--config" option correctly to "lxc launch" 2018-08-02 19:37:53 +00:00
Christopher Boumenot a3e6153068 azure: implement clean_image_name 2018-08-01 10:54:45 -07:00
Felix Yan f69ab4ed77
Fix a typo in config_test.go 2018-07-31 15:19:45 +08:00
Mike Zupan 11271ead59 Change name to tags 2018-07-30 07:55:06 -06:00
Mike Zupan 7081fe990b Adding in droplet tags on creation 2018-07-30 07:52:40 -06:00
Omer Katz 26dd6441e0
Locate lxc root directory when exporting as well. 2018-07-29 16:14:17 +03:00
Omer Katz 808df82eea
Remove privilege escalation with sudo when copying files. Preserve file permission mapping when copying files. 2018-07-29 16:03:01 +03:00
Omer Katz e5b740e223
Determine lxc root according to the running user. 2018-07-29 13:16:41 +03:00
rsclarke 887e694534 add ssh agent support for qemu builder 2018-07-27 20:24:06 +08:00
Anshul Sharma c1edcd3774
amazon-ebssurrogate clean up volumes 2018-07-26 09:38:59 +03:00
bugbuilder 2c4f703ff8 Merge 2018-07-24 20:54:08 -04:00
Sergio Millan Rodriguez d90dfc096a adding public_ssh_port flag to use a fixed port in the forwarding rules 2018-07-24 18:39:02 +01:00
Christopher Boumenot 9c6b4287e5
Merge pull request #6480 from hashicorp/pr-azure-password-requirements
azure: satisfy Azure password requirements
2018-07-24 09:58:54 -07:00
Megan Marsh 5bbb6633cf
Merge pull request #6279 from ChrisLundquist/clundquist/lxc-perms
[WIP] Unpriviliged LXC containers
2018-07-24 09:34:21 -07:00
Megan Marsh 07b6bc0c4f
Merge pull request #6504 from sharmaansh/6309-amazon-chroot-create-volume-tags
amazon-chroot: Add tags on CreateVolume
2018-07-23 14:58:17 -07:00
Megan Marsh d2823622e5
Merge pull request #6249 from iammattcoleman/add-use_backing_file
qemu builder: add the 'use_backing_file' setting for QCOW2 images
2018-07-23 13:40:04 -07:00
DanHam da21c25791
Convert incorrect 'vmxc' -> 'vmcx' in codebase, docs and template opts
grep -rli --exclude-dir={vendor,bin\*,\*vmware\*,\*pkg\*} vmxc . | \
xargs sed -i 's/\(vm\)\(x\)\(c\)/\1\3\2/ig'
2018-07-20 02:12:47 +01:00
DanHam 674bad0ab4
Break very long lines for readability 2018-07-20 02:12:47 +01:00
DanHam 2bb5a92755
Fix error in comment due to copy/paste from VMware step 2018-07-20 02:12:47 +01:00
DanHam 36bd2f5691
Fix an error with an error. Add some comments. 2018-07-20 02:12:46 +01:00
DanHam ee0a2469eb
Add ability to specify 'temp_path' for the build directory to VMCX builder 2018-07-20 02:12:46 +01:00
DanHam 8032c8151a
Tests for step to create output directory 2018-07-20 02:12:46 +01:00
DanHam f027585a93
Tests for step to create build directory 2018-07-20 02:12:45 +01:00
DanHam ed5bebfa8c
Change variable/statebag key name to better convey purpose 2018-07-20 02:12:45 +01:00
DanHam 00276f2f64
Change step name to better illustrate purpose of step 2018-07-20 02:12:45 +01:00
DanHam b386e567db
Change filename to better illustrate purpose of step 2018-07-20 02:12:45 +01:00
DanHam d2390f464d
Actually implement the function for the driver 2018-07-20 02:12:45 +01:00
DanHam 181bb0ba23
Add calling code and skeleton driver to make tests pass 2018-07-20 02:12:45 +01:00
DanHam 0a4ec13323
Tests for func to move VHDs to output dir when skip_export: true 2018-07-20 02:12:44 +01:00
DanHam 32148168bd
Introduce a new step to collate build artifact at the end of the build
The new step collects together all the required build artifacts and
places them in the output directory.

* Reintroduce/add the code removed from step export to preserve the
  legacy export directory structure when skip_export is unset/false
* Add a place holder for a future function that will move just the VHD
  files from the build directory to the output directory when
  skip_export is true
* Add tests for current functionality and placeholder tests for future
  functions
2018-07-20 02:12:44 +01:00
DanHam ee7fa27ada
Fix up tests. Ensure export step stores the export path in state 2018-07-20 02:12:44 +01:00
DanHam 232dd8f0a6
Remove code to preserve legacy export dir structure from the export step
Store the export path in the state bag in preparation for use in a later
step
2018-07-20 02:12:44 +01:00
DanHam c2437ba592
Remove the option to place the VHD files in a separate directory
The export process now exports the VM directly from the build directory
into the output directory. There are no intermediate steps or copying of
files involved. This means that there is no longer any benefit in having
a separate directory to house the VHD files - see #5206 for the
reasoning behind the introduction of this feature.

If a user wishes to house the build files on a separate disk from the
output directory (perhaps for performance reasons or due to disk space
limitations) they can still do so through the use of `temp_path`.
2018-07-20 02:12:43 +01:00
DanHam d5d82c32b2
Changes to the export process have made 'inline' build of disks redundant
PR #5631 introduced code to build/create disks directly in the output
directory if `skip_export` was set in an attempt to optimise the build
process. These are no longer required.
2018-07-20 02:12:43 +01:00
DanHam 35b4e87c42
Add tests for export VM step 2018-07-20 02:12:43 +01:00
DanHam 30a71da8e7
Add tests for disk compaction step 2018-07-20 02:12:43 +01:00
DanHam 09028c14a3
Reintroduce the disk compaction process as a unique step 2018-07-20 02:12:43 +01:00
DanHam da2df69301
Remove disk compaction from the export step 2018-07-20 02:12:42 +01:00
DanHam c6b9d9ce90
Add checks/error reporting to compaction process
* Report compaction results
* Failure to find any disks under the supplied path is treated as a
  'soft' error and a warning message will be printed in place of the
  compaction result. Any other failure will cause the build to fail.
2018-07-20 02:12:42 +01:00
DanHam 534fc4a473
Ensure the export directory structure matches that of previous versions
Commit 3fc2defb6 altered the directory structure associated with an
exported VM. The changes mean that the export process now stores the
exported machine files and folders under a folder with name 'vm_name' in
the output directory.
This commit restores the previous behaviour whereby the exported machine
files and folders were stored directly in the output directory. This
allows us to keep the efficiency improvements introduced with 3fc2defb6
while maintaining backward compatibility.

By default the Export-VM command creates three folders in the specified
export directory - 'Virtual Hard Disks', 'Virtual Machines' and
'Snapshots'. When a machine with no associated snapshots is exported the
'Snapshots' directory is empty.
Prior to 3fc2defb6 the Snapshots folder was not copied/incorporated into
the output directory at all. This was a bug.
This commit preserves the legacy behaviour by not including an empty
Snapshots directory in the export. However, if there *are* Snapshots
associated with the VM, they are now moved into the output directory
along with the usual directories containing disks and VM metadata. This
prevents warnings/errors on import due to missing snapshots.
2018-07-20 02:09:57 +01:00
DanHam dc46848f89
Remove now redundant function to copy exported VM files 2018-07-20 02:09:57 +01:00
DanHam 3fc2defb6d
Refactor the export step for Hyper-V ISO and VMCX builders
* Fixes a bug that caused the build to error if users did not
  explicitly set `skip_compaction:true` when setting `skip_export:
  true`. See #6392.
* Improves the efficiency of the compaction and export process by
  reordering the compaction and export steps.
* Further improves the efficiency of the compacting step through
  compacting the vmd* file directly rather than creating and then
  operating on a copy.
* The changes mean the export process now stores the exported machine
  files and folders under a folder with name 'vm_name' in the output
  directory. Previously the exported machine files and folders were
  stored directly in the output directory.
2018-07-20 02:09:54 +01:00
Matthew Hooker 814c1cf2b2
spellfix 2018-07-18 13:00:45 -07:00
Andrew Pryde 67f039509a
Merge pull request #6498 from neumayer/ocimetadata
Allow instance metadata to be specified in config
2018-07-18 18:27:27 +01:00
Anshul Sharma 885ecb0790
Issue-6309 Amazon Chroot Provider
-  Add tags on CreateVolume
2018-07-18 13:01:15 +03:00
xxx 7630268e1d Incorporate review comments 2018-07-17 17:41:19 +02:00
James Nugent 9fffe4056e
Merge pull request #5452 from smaato/tag-spot-requests
Enable tagging of spot requests
2018-07-16 13:00:07 -05:00
Sander van Harmelen 451cbd8aa9
Merge pull request #6487 from sermilrod/Honour-cloudstack-projectid
Honour cloudstack projectid
2018-07-16 13:53:06 +02:00
Sergio Millan Rodriguez f4020835d6 flag to setup networking without firewall rules 2018-07-16 13:06:51 +02:00
Sergio Millan Rodriguez 472a7820eb Using UI keypair meaningful message 2018-07-16 11:39:15 +02:00
Sergio Millan Rodriguez e729b21212 passing projectid to getRootVolumeID rather than the whole config struct 2018-07-16 11:38:14 +02:00
Mark Meyer 2fec76ea87 Check if spot price is empty, when spot_tags is set 2018-07-13 22:42:42 +02:00
Megan Marsh b6b907f523 read in the environment variables that government wait time and polling time for the AWS wait in step_stop_ebs_volume 2018-07-13 09:43:28 -07:00
Sergio Millan Rodriguez a41a4658ee make packer builder honour projectid setting if provided 2018-07-13 17:58:46 +02:00
Sergio Millan Rodriguez eae0556dc5 Add option to enable/disable create firewall/acl rules 2018-07-13 17:58:39 +02:00
Megan Marsh 1d15f09e36
Merge pull request #6440 from DanHam/simplify-vmx-find-disks
Further simplify enumeration of attached disks for VMware VMX builder
2018-07-12 11:05:35 -07:00
Christopher Boumenot fa7f54cb55 azure: satisfy Azure password requirements 2018-07-11 15:32:45 -07:00
Megan Marsh 8e22803099 fix loading of environment variables for managing aws waiters 2018-07-11 13:10:38 -07:00
Megan Marsh 12f1b2421d
Merge pull request #6332 from hashicorp/do_6177
Replace home-grown waiters with aws sdk's built in waiters
2018-07-11 11:17:02 -07:00
Megan Marsh f657ca39c9 refactored env var code and tests so that I don't have to set env vars during tests to check logic 2018-07-11 10:36:21 -07:00
Megan Marsh 14166fdd99 update amazon import docs to include the env vars for setting aws waiter delays and timeouts 2018-07-11 10:36:21 -07:00
Megan Marsh bfbe318727 fix the homegrown waiters
fix image import; issue was with wait options not being evaluated
2018-07-11 10:36:21 -07:00
Megan Marsh f49a2d8aed move UI call to before the wait; add context to these steps 2018-07-11 10:36:21 -07:00
Megan Marsh cf63dd10bf replace AMIStateRefreshFunc, InstanceStateRefreshFunc, our spot instance waiter, our chroot volume waiter, and our snapshot waiters with waiters form AWS's SDK. 2018-07-11 10:34:20 -07:00
M. Marsh 62d9dcb822
Merge pull request #6477 from jabbera/fixMaxResourceGroupLength
managed_image_resource_group_name max length change
2018-07-11 10:23:30 -07:00
Mike 5ea6429cd6
managed_image_resource_group_name max length change 2018-07-11 11:31:51 -04:00
M. Marsh 8e852af1eb
Merge pull request #6448 from DanHam/fix-esxi-displayName
ESXi: Fix failure to discover IP or export VM when 'displayName' differs from 'vm_name'
2018-07-10 16:57:16 -07:00
Michael Gibson 7e4fb9adb5
vnc_bind_address not getting passed through to qemu
This was mostly addressed in commit
hashicorp/packer@fa273f3

Just missing vncIP from step_type_boot_command.go
2018-07-09 14:05:39 -06:00
M. Marsh adfee4933a
Merge pull request #6437 from hashicorp/retry_convert
make the convert retryable in case it takes a bit to release a lock
2018-07-09 11:09:57 -07:00
Mark Meyer 3dbf1cb371 Enable tagging of spot requests
This adds a new parameter to the EBS builders named `spot_tags'. This
parameter accepts a map of tags, much like `tags'. These tags will be
applied to a spot request that is created.

Improve visibility.
2018-07-07 16:06:51 +02:00
DanHam a39c5887fb
Test we halt if a bad path is set in vmx_path 2018-07-06 10:58:25 +01:00
DanHam 21117e5d38
Test we fail if displayName is not stored in the statebag as 'display_name' 2018-07-06 10:58:25 +01:00
DanHam 88c43ec98d
Test we fail if the displayName key is not found in the VMX 2018-07-06 10:58:24 +01:00
DanHam d68d26a6e5
Fix tests: We now need to set `displayName` key/val pair in the test VMX 2018-07-06 10:58:24 +01:00
DanHam 902cea0f30
ESXi: Fix failure to export VM when `displayName` differs from `vm_name`
ovftool requires we pass in `displayName` as part of the source locator
string so that it can successfully determine the VM intended for export.
2018-07-06 10:58:17 +01:00
DanHam cd7d3812ea
ESXi: Fix failure to get VM IP when `displayName` differs from `vm_name`
The value in the Name field returned by 'esxcli network vm list'
actually returns the VMs `displayName`. As such, we need to match
against `displayName` to discover the VMs 'WorldID'.
'WorldId' is ultimately used/needed as an argument in the command that
returns the VMs IP.
2018-07-06 10:58:09 +01:00
DanHam 3eab3cc99b
ESXi builds require we store the value of displayName in the statebag
The value of displayName is needed by later steps:
* When determining the IP address of the build VM
* When exporting the VM using ovftool

By default Packer will configure the VMX so `displayName` is equal to
the value defined for `vm_name` in the build template. However, it is
possible (and sometimes desirable) to set a custom value for
`displayName`.
Users can set a custom `displayName` through use of the `vmx_data`
option in their template.
2018-07-06 01:58:09 +01:00
Edouard Bonlieu 4b1f96b527
Merge pull request #6439 from jbonachera/scaleway-config-bootscript
scaleway: add 'bootscript' configuration parameter
2018-07-04 10:10:19 +02:00
M. Marsh 8658eaf1ac
Merge pull request #6424 from DanHam/fix-esxi-export-hang
Prevent hang on export when using VMware ISO builder on remote ESXi host
2018-07-02 16:42:08 -07:00
DanHam 939aa7e289
Add test: We shouldn't error when main remote options are unset 2018-07-02 18:13:19 +01:00
DanHam efcdf60d96
Add tests to ensure remote_password is set when exporting with ovftool 2018-07-02 18:13:19 +01:00
DanHam 0d9134bdbc
Fix existing tests as they were not doing what they should have been
* Fix test to check for remote_host when remote_type is set
* Fix tests by including remote_password where required
2018-07-02 18:12:41 +01:00
DanHam eee16262b6
Remove duplicate/redundant test 2018-07-02 18:10:50 +01:00
DanHam c8199458a7
Prevent hang on export for remote ESXi build due to empty remote_password 2018-07-02 18:10:50 +01:00
M. Marsh 406f4eeb93
Merge pull request #6394 from conradjones/master
Add support to vmware-vmx for linked clones
2018-07-02 09:50:24 -07:00
Robert Neumayer 22e5523faa Allow instance metadata to be specified in config 2018-07-02 10:48:08 +02:00
DanHam fff72780e1
Further simplify enumeration of attached disks for VMware VMX builder
* Collate separate regexp's into one for greater efficiency
* Inline function and remove unnecessary struct and variables
2018-07-01 16:18:33 +01:00
Conrad Jones d9b6924986 Add cloneType to fusion driver 2018-06-30 16:31:42 +01:00
Julien BONACHERA eda85a4daf
scaleway: add 'bootscript' configuration parameter 2018-06-29 19:44:56 +02:00
Megan Marsh 2b2c860df8 make the convert retryable in case it takes a bit to release a lock 2018-06-28 14:21:28 -07:00
M. Marsh c67d59515c
Merge pull request #6370 from arizvisa/patch-1
Allow StepAttachIso in the VirtualBox builder to resolve symbolic links when processing the IsoPath.
2018-06-27 10:30:30 -07:00
Owain Lewis b600be009d Pass context into OCI client 2018-06-26 10:17:02 +01:00
M. Marsh 5a6a389e66
Merge pull request #6415 from brumfb/skip_invalid_lease_files
Fixes VMWare Builder issue regarding DHCP-less NAT networks.
2018-06-25 16:47:04 -07:00
M. Marsh 78c0b7bd9c
Merge pull request #6408 from harveylowndes/oci-support-custom-instance-display-name
Support instance display name configuration for OCI
2018-06-25 13:17:12 -07:00
Bob Brumfield 04ff0761e6 Notify that we are skipping file, but retain error message 2018-06-25 08:28:32 -07:00
Harvey Lowndes a69e2ac78e Support instance display name configuration 2018-06-25 11:45:59 +01:00
willmao 7bab499b73 fix vpc clean up issue 2018-06-25 09:16:06 +08:00
willmao f511c706c9 fix alicloud builder eip allocating issue 2018-06-23 16:34:45 +08:00
Bob Brumfield 591bfe3dfa Continue searching for leases even if one of the files cannot be read. 2018-06-22 18:09:27 -07:00
Alexander Georgievskiy ec8747a042 They finally added https on download.virtualbox.org
Because downloading SHA256SUMS via http is a fun joke
2018-06-22 00:45:20 +03:00
Conrad Jones abfb9f24d6 revert accidental debugging change 2018-06-17 01:45:26 +01:00
Conrad Jones d05a601d00 Add support to vmware-vmx builder for linked clones. 2018-06-17 01:38:42 +01:00
M. Marsh 58e4176a73
Merge pull request #6385 from enricou/wip/add-northeast-3
Add ap-northeast-3 region
2018-06-15 10:46:36 -07:00
EC2 Default User 58f73aabbf Add ap-northeast-3 region 2018-06-15 07:15:41 +00:00
Pavel Vasilevich 4e2b1756f9 Fix misprints in steps names 2018-06-15 12:12:40 +07:00
Ali Rizvi-Santiago 47a3315fde
Added a missing reference to the "path/filepath" module.
Lol. Dammit.
2018-06-11 18:07:43 -05:00
Ali Rizvi-Santiago 963932699e
Remove a stray tab that resulted from poor usage of Github's file editor.
That's what I get for not making a proper branch...
2018-06-11 18:02:52 -05:00
Ali Rizvi-Santiago 9b30c9aed0
Allow StepAttachIso in the VirtualBox builder to resolve symbolic links when processing the IsoPath.
This just closes out a really old issue (#3437) by using `filepath.EvalSymLinks` to resolve the symbolic link that the user specifies for the IsoPath.
2018-06-11 17:53:54 -05:00
M. Marsh 2b60934420
Merge pull request #6363 from hashicorp/fix_6358
sh -c to execute command to accomodate communicator change
2018-06-11 10:25:25 -07:00
M. Marsh 5d35c71358
Merge pull request #6362 from rickard-von-essen/os-token
openstack: Add support for token authorization and cloud.yaml
2018-06-08 16:26:34 -07:00
Megan Marsh 87a93e84ac sh -c to execute command to accomodate communicator change 2018-06-08 13:14:55 -07:00
Matthew Hooker 3bdf1f1849 openstack: Add support for token authorization and cloud.yaml
via config options `cloud` and `token` and environment variables
OS_CLOUD and OS_TOKEN.
2018-06-08 21:38:26 +02:00
M. Marsh 10549d34b6
Merge pull request #6322 from sieben/remove_vc
Remove the VC product line
2018-06-08 09:55:24 -07:00
M. Marsh c586312bf7
Merge pull request #4538 from hashicorp/defaultovf
builder/vmware: correctly default export format to ovf
2018-06-07 11:36:48 -07:00
Hariharan Jayaraman b23d6c9589 fixing infinite loop issue deleting existing resources if we have a empty target resource 2018-06-06 15:25:19 -07:00
Rickard von Essen c0ae1b7790
digitalocean: artifact should include build region and fixed docs
- Add the build region to the list of regions for the artefact
- Corrected docs: `snapshot_name` doesn't have to be unique.
- Updated example to use Ubuntu 16.04
2018-06-03 16:37:38 +02:00
deepuashokan85 10f118b14c
Update driver_gce.go
Added "rhel-sap-cloud" Projects_ID.
2018-05-31 11:29:57 +05:30
M. Marsh 31c7374869
Merge pull request #6303 from hashicorp/do_5871
add get windows default credentials to oci builder
2018-05-29 16:12:15 -07:00
Rémy Léone dba9f1b015 Remove the VC product line 2018-05-28 16:19:51 +02:00
James Nugent b97475b647
Merge pull request #6265 from DanHam/enable-t2-unlimited
Add support for T2 Unlimited for Amazon builders
2018-05-25 00:26:17 +04:00
DanHam af7f7f2ce9
Fix redundant Sprintf 2018-05-24 21:05:03 +01:00
Megan Marsh 08218222dc add get windows default credentials to oci builder 2018-05-24 10:47:37 -07:00
M. Marsh 62e1323577
Merge pull request #5956 from hashicorp/dedupe_shell_local
Deduplicate the code for the shell-local post-processor and shell-local provisioner
2018-05-23 15:54:27 -07:00
Megan Marsh e670eed315 Add new option, nvme_device_path, so that we can properly mount nvme block devices. 2018-05-23 09:16:40 -07:00
Paul Meyer 3dd6bf5781
Merge pull request #6285 from harijayms/devicelogin
Devicelogin Support for Windows and not requiring object ID
2018-05-22 11:26:47 -07:00
Hariharan Jayaraman a13a2511f9 Added additional error message if we failed to parse token 2018-05-21 22:20:36 -07:00
Hariharan Jayaraman 1bd7aa534e Addressed PR feedback 2018-05-21 21:38:41 -07:00
M. Marsh a8b6a04dda
Merge pull request #6194 from hashicorp/fix_6176
allow user to mount entire block device in chroot builder
2018-05-21 15:28:18 -07:00
Hariharan Jayaraman 8a3e599cad Added text to point out two device auth 2018-05-21 11:05:59 -07:00
Hariharan Jayaraman da67df6d03 space fix 2018-05-18 21:17:19 -07:00
Hariharan Jayaraman 4992429e8c Minor comment fixes 2018-05-18 17:34:01 -07:00
Hariharan Jayaraman 00e809cb7e Refactored the change into a new function 2018-05-18 15:21:49 -07:00
Hariharan Jayaraman ea9b2a8b5f review feedback 2018-05-18 12:09:42 -07:00
M. Marsh edb5c1f50d
Merge pull request #6243 from camjjack/hyper-v-gui
Using vmconnect to display gui for hyper-v
2018-05-18 11:24:24 -07:00
M. Marsh cbbbf551e3
Merge pull request #6274 from DanHam/fix-compaction-esx
Revert commits that enabled reporting of disk compaction results for VMware builders
2018-05-18 09:20:21 -07:00
Hariharan Jayaraman 667113338a missed formating 2018-05-18 01:41:00 -07:00
Hariharan Jayaraman 7f2277676a Ensure that Device Login tests dont block general acceptance tests 2018-05-18 01:34:12 -07:00
Hariharan Jayaraman 77fe1bffe4 Ensure that Device Login tests dont block general acceptance tests 2018-05-18 01:25:19 -07:00
Hariharan Jayaraman de1783240f Updates to remove space changes 2018-05-18 00:53:44 -07:00
Hariharan Jayaraman 91eed4da52 trim right of the keyvault url 2018-05-18 00:44:25 -07:00
Hariharan Jayaraman df5cc234fc updates 2018-05-18 00:39:57 -07:00
Hariharan Jayaraman 1f46271a6b Ensuring device login works for Windows build 2018-05-18 00:32:01 -07:00
Christopher Boumenot a5530d4546
Merge pull request #6269 from harijayms/asyncrgdelete
Async delete Resource Group
2018-05-16 15:13:09 -07:00
Chris Lundquist c925a02f82 don't chown to close the security issue 2018-05-16 21:40:22 +00:00
Matt Coleman 3192f5e0da qemu builder: add the 'use_backing_file' setting for QCOW2 images 2018-05-16 10:22:50 -04:00
DanHam 73eb9a629e
Revert "Fix test - reporting compaction results requires a tmp file"
This reverts commit f342975ff3.
2018-05-16 13:52:00 +01:00
DanHam 2939cd75ae
Revert "Report the result of the disk compaction step"
Unfortunately this broke the ability to build on remote (ESXi) hosts.

This reverts commit 08f9d619a9.
2018-05-16 12:55:59 +01:00
Hariharan Jayaraman e1b18d594a Updates based on PR feedback 2018-05-15 11:41:26 -07:00
DanHam ec8b70721c
Use an explicit error message when an error is expected and we don't get one
Previously, if the validation check generating the error in the main code
is removed, the 'should error' tests would just return an empty message
2018-05-15 12:25:06 +01:00
DanHam 82c8710af5
Use fmt.Errorf over errors.New as we only require basic error reporting 2018-05-15 12:25:06 +01:00
DanHam 99e3487795
Add missing validation and tests for Spot Instance requests 2018-05-15 12:25:06 +01:00
DanHam d5304a25e9
Pass T2 Unlimited settings to run instance step for appropriate EC2 builders 2018-05-15 12:25:06 +01:00
DanHam 6fc68754d7
Allow use of T2 unlimited by adding appropriate request for the instance 2018-05-15 12:25:06 +01:00
DanHam df7fb86984
Add tests for T2 Unlimited configuration 2018-05-15 12:25:06 +01:00
DanHam be02b3f613
Validate template settings when T2 Unlimited has been enabled
* T2 Unlimited cannot be used with anything other than T2 instance types
* T2 Unlimited cannot be used with Spot Instances
2018-05-15 12:25:06 +01:00
DanHam 482629ae90
Add config option to enable/disable T2 Unlimited for the launched instance 2018-05-15 12:25:06 +01:00
DanHam 2c339b99d2
Sort run config options alphabetically 2018-05-15 12:25:06 +01:00
Hariharan Jayaraman c8c9bbb22a Async delete Resource Group 2018-05-14 20:06:23 -07:00
Unknown 5710c0aca1 Making log output clearer for hyper-v gui connection 2018-05-14 20:53:51 +10:00
Unknown 29c4b4436d Changes requested in PR #6243
- Logging error if vmconnect.exe fails.
- Using StepRun struct rather than StateBag for command Cancel function
- Better handling in Disconnect when headless is true or vmconnect failed in Start
2018-05-14 20:52:10 +10:00
Unknown fc734b6bd9 Using vmconnect to display gui for hyper-v
vmconnect.exe comes as part of Hyper-V and is the tool used by Hyper-V Manager to connect with a virtual machine. This commits sets behaviour the same as virtualbox and vmware to display the virtual machine connection unless headless is set in the template.
2018-05-14 20:52:10 +10:00
Christopher Boumenot 132dfa7c86
Merge pull request #6262 from harijayms/warningforVHDcreation
Added warning for VHD creation and updated samples
2018-05-11 11:40:42 -07:00
M. Marsh 5871b8242b
Merge pull request #6101 from adarobin/azurecompatible
Add use_fixed_vhd_format Hyper-V ISO option
2018-05-10 17:02:44 -07:00
Hariharan Jayaraman 13c0b0b370 Added warning for VHD creation and updated samples 2018-05-10 13:15:35 -07:00
Stefan Henseler 6f00596053 Adds config option to specify hyper-v secure boot template 2018-05-10 19:00:35 +02:00
M. Marsh 84a7d2436f
Merge pull request #6229 from DanHam/use-re-for-vmxadapter
Use regex based approach to detect attached disks
2018-05-08 15:12:25 -07:00
DanHam a866232ac9
Use regex based approach to detect attached disks 2018-05-08 12:52:39 +01:00
Megan Marsh 6dc4b1cbdc move all of the run commands for shell-local provisioner and postprocessor into common library too 2018-05-07 15:10:09 -07:00
Megan Marsh 616b41e58f deduplicate the nearly identical communicators for the shell-local provisioner and post-processor, moving single communicator into a new common/shell-local module 2018-05-07 15:10:09 -07:00
Christopher Boumenot 80a096cadd azure: device login for US Gov 2018-05-06 20:59:38 -07:00
Paul Meyer 8aee53ebe9
Merge pull request #6224 from paulmey/update-azure-sdk
Update Azure SDK
2018-05-04 09:47:28 -07:00
Rickard von Essen 4be5f072c7
Merge pull request #6238 from DanHam/fix-scaleway-auto-ssh-key
Fix use of automatically generated ssh key for Scaleway
2018-05-04 13:35:03 +02:00
Paul Meyer 169f9d22e6 Update 'the other place' too 2018-05-04 00:32:15 +00:00
Paul Meyer 80f57308d7 Process review feedback 2018-05-04 00:28:34 +00:00