a545caa24a
use openstack volume_size option on creation
...
if present. Otherwise fallback to to source image min disk value (if
set) or calculated from the source image bytes size.
Note that in some cases this needs to be specified, if
`use_blockstorage_volume` is true. See #6957 for the discussion.
2018-12-18 23:59:54 +01:00
336c11c54a
add openstack volume_size option
...
Adds an option to OpenStack, `volume_size` (int), which is the size of
the Block Storage service volume in GB.
2018-12-18 23:58:27 +01:00
acacf6e59c
Merge pull request #7111 from hashicorp/pr-7077-azure-regression
...
azure: fix snapshot regression
2018-12-18 09:53:52 -08:00
bdcbf61ade
Fixed replace variable name.
2018-12-18 06:18:51 -06:00
fa154f5298
Fixed driver mock up formatting.
2018-12-18 06:14:38 -06:00
31d03fb48e
Added legacy network adapter driver mock up.
2018-12-18 06:12:05 -06:00
da8b140bca
Fix Hyper-V builder formatting.
2018-12-18 05:50:16 -06:00
348c267054
Updated support for legacy network adapters on Hyper-V.
2018-12-18 04:59:00 -06:00
6ac5971288
Fixed cmd order for docker driver. Added config to post proc.
2018-12-17 22:59:41 -06:00
10095678c8
Adding driver changes.
2018-12-17 22:37:32 -06:00
21fdbadf04
Adding changes to import prototype.
2018-12-17 22:35:59 -06:00
050f809a1c
Add changes var to docker driver import func.
2018-12-17 22:04:43 -06:00
19144111dd
fix packer crash that occurs when image is nil
2018-12-17 14:54:27 -08:00
8184fcb99a
Make sure sshkey is not nil
2018-12-14 22:30:26 +01:00
0821653256
Fix 'nil' dir in VMware artifact when building locally
2018-12-14 13:21:41 +00:00
2045390e74
Merge pull request #7108 from hashicorp/revert_hddorder_setting
...
Revert hddorder setting
2018-12-13 16:27:31 -08:00
f9230aeb95
azure: fix snapshot regression
2018-12-13 13:58:18 -08:00
7d5ea43f41
revert the hddorder being added to the vmx template, since it's breaking things for some of our users.
2018-12-13 09:58:24 -08:00
b95123f457
add new copy_in_compare flag so users can set the copy var to whatever they need in order to get the compatibility report to work.
2018-12-13 09:12:23 -08:00
2718a5ed62
Revert "revert changes to docker entrypoint; since this is a backwards-breaking change it needs to wait for a minor release"
...
This reverts commit 2a79d64ae0
2018-12-13 10:23:46 +01:00
47257c0d07
Merge pull request #7104 from hashicorp/revert_docker_changes
...
revert changes to docker entrypoint; since this is a backwards-breaki…
2018-12-13 10:23:18 +01:00
ee2e5cc874
Merge pull request #7080 from hashicorp/do_6508
...
Move logging about aws waiters to the access config prepare() so that…
2018-12-12 15:42:37 -08:00
2a79d64ae0
revert changes to docker entrypoint; since this is a backwards-breaking change it needs to wait for a minor release
2018-12-12 15:30:24 -08:00
279949ddcc
Merge pull request #7090 from tomelliff/validate-kms-key-id
...
Check that the KMS key ID is valid
2018-12-12 10:04:22 -08:00
b7222d1f56
Add tmp package that offers Dir & File funcs
...
this regroups the calls of tmp func calls into one package.
the tmp pkg allows to store tmp files under a common directory for easier managment
Squashed commit of the following:
commit 74b674c01560c6b547e9cab5e8afb486f0fe7d6c
Merge: fc94b5714 66001525d
Author: Matthew Patton <mpatton@enquizit.com>
Date: Fri Nov 2 02:02:38 2018 -0400
Merge branch 'remove_TMPDIR_docs' of github.com:tb3088/packer into remove_TMPDIR_docs
commit fc94b571428447aaf2e5171967c95cdf9e5c73ff
Author: Matthew Patton <mpatton@enquizit.com>
Date: Fri Nov 2 01:42:38 2018 -0400
update tests to honor configured temporary directory
commit 5a562359f4937af506607dd96ed1c46426093f52
Author: Matthew Patton <mpatton@enquizit.com>
Date: Thu Nov 1 18:52:38 2018 -0400
sync straggler to refactor. implement tests at packer/configfile instead of buried in docker.
commit 9d5a4a0935bfd049e2f8f50ad73e4455b42c9410
Author: Matthew Patton <mpatton@enquizit.com>
Date: Thu Nov 1 15:39:46 2018 -0400
insert URL to GoLang API for os.TempDir()
commit fbae4c2e051898aecd8705e9d8a20353430ede23
Author: Matthew Patton <mpatton@enquizit.com>
Date: Thu Nov 1 07:41:29 2018 -0400
revise documentation to match code
commit 3590fae8bd0afa92a161a49ed794ee32e357d583
Author: Matthew Patton <mpatton@enquizit.com>
Date: Thu Nov 1 07:21:59 2018 -0400
refacter config_file. replace all hard-coded os.TempDir with wrapper
commit d5c5306a97b648ded06a8eb76ce728f07c9924f0
Author: Matthew Patton <mpatton@enquizit.com>
Date: Wed Oct 31 20:11:36 2018 -0400
close massive file overwrite hole with TempDir
commit 0a72297da86089fbd07e4f7d9472a92fa4d1c733
Author: Matthew Patton <mpatton@enquizit.com>
Date: Wed Oct 31 01:06:00 2018 -0400
adjust var declaration scope
commit 20f68228b6c372d984ea5b055cfc8bda9b110ac5
Author: Matthew Patton <mpatton@enquizit.com>
Date: Wed Oct 31 00:54:35 2018 -0400
use mktemp() equivalent to create temporary directory
commit c73ebe3d8321664a2685a0baa8e441dd895b0db4
Author: Matthew Patton <mpatton@enquizit.com>
Date: Tue Oct 30 20:40:58 2018 -0400
remove extraneous variable declaration, fix FOR loop
commit 63549b8bd745a0090b15ed0b0ebf644162db27db
Author: Matthew Patton <mpatton@enquizit.com>
Date: Tue Oct 30 19:30:44 2018 -0400
match styistic convension with rest of docs
commit 976101074942db36f10d3a686d6d29ddb7c01926
Author: Matthew Patton <mpatton@enquizit.com>
Date: Tue Oct 30 19:08:39 2018 -0400
revert dangling config file change
commit 95159afbc05eac96ed11c3183af5fb0abe2f2d5c
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date: Fri Dec 29 23:53:43 2017 -0500
replace invalid TMPDIR variable wth PACKER_TMP_DIR.
update ConfigTmpDir() to try common temporary paths first and
only write to configDir() as a last resort.
commit 66001525d72de56a4cf9339b900c46f59bc6e91a
Author: Matthew Patton <mpatton@enquizit.com>
Date: Fri Nov 2 01:42:38 2018 -0400
update tests to honor configured temporary directory
commit e9b6adefeae8c65eb8aa47fef38cbf0aa424338c
Author: Matthew Patton <mpatton@enquizit.com>
Date: Thu Nov 1 18:52:38 2018 -0400
sync straggler to refactor. implement tests at packer/configfile instead of buried in docker.
commit 852113ed076e2d14e5dca6815ea680da1e2896bb
Author: Matthew Patton <mpatton@enquizit.com>
Date: Thu Nov 1 15:39:46 2018 -0400
insert URL to GoLang API for os.TempDir()
commit 54add38d1d1c6e283cd444b367ed8bd49a5f3699
Author: Matthew Patton <mpatton@enquizit.com>
Date: Thu Nov 1 07:41:29 2018 -0400
revise documentation to match code
commit 6b5b8f6d4edad0e187ca13d64ac4118f34eee643
Author: Matthew Patton <mpatton@enquizit.com>
Date: Thu Nov 1 07:21:59 2018 -0400
refacter config_file. replace all hard-coded os.TempDir with wrapper
commit c22092c601c33484327674f322c7379fa41506d7
Author: Matthew Patton <mpatton@enquizit.com>
Date: Wed Oct 31 20:11:36 2018 -0400
close massive file overwrite hole with TempDir
commit 7a730450916bf8e5dbc2a741ec233a49466ab7cc
Author: Matthew Patton <mpatton@enquizit.com>
Date: Wed Oct 31 01:06:00 2018 -0400
adjust var declaration scope
commit 0f2933adb6f6922dfeab78a95371a444ec8918ab
Author: Matthew Patton <mpatton@enquizit.com>
Date: Wed Oct 31 00:54:35 2018 -0400
use mktemp() equivalent to create temporary directory
commit d74839ede05dacf712b55a7bb48aec19fe6b007f
Author: Matthew Patton <mpatton@enquizit.com>
Date: Tue Oct 30 20:40:58 2018 -0400
remove extraneous variable declaration, fix FOR loop
commit eb65416619437e4a3dec90277770803dd5b2281c
Author: Matthew Patton <mpatton@enquizit.com>
Date: Tue Oct 30 19:30:44 2018 -0400
match styistic convension with rest of docs
commit acaa2b31ed463219c4ef099f351eec72406e2989
Author: Matthew Patton <mpatton@enquizit.com>
Date: Tue Oct 30 19:08:39 2018 -0400
revert dangling config file change
commit e573fde668dcb418561e61535c1d68b2888f5b0f
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date: Fri Dec 29 23:53:43 2017 -0500
replace invalid TMPDIR variable wth PACKER_TMP_DIR.
update ConfigTmpDir() to try common temporary paths first and
only write to configDir() as a last resort.
commit 39a9874afc9dea71b36753375fb7feb61ffecf69
Merge: 8a413cfe8 3315812c2https://github.com/hashicorp/packer into prestine
commit 8a413cfe83b0a70dbd99c32d936334ca5788ca9b
Merge: e07491de5 4e14710a6a1fa35dff0d63cf7bc9d97365526189d66e74be5f072cfefaf0fa6554b2b4a5
2018-12-12 16:35:57 +01:00
12bf7fc4d6
Check that the KMS key ID is valid
...
KMS key IDs can be given as either a raw key ID, an alias (always prefixed with 'alias/'), the full ARN to the KMS key ID or the full ARN to the KMS key alias.
Should help with https://github.com/hashicorp/packer/issues/6599 but probably isn't enough to fully close it.
2018-12-12 11:41:58 +00:00
dfa284c02b
Merge pull request #7094 from hashicorp/fix_7087
...
fix virtualbox 6.0 beta command options
2018-12-11 11:54:56 +01:00
5e5ed9793f
Merge pull request #7092 from arizvisa/vmware-builders.halt-duplicate-code
...
Tiny fix to replace some duplicate code with usage of the already defined `halt` closure in the StepCloneVMX step for the vmware-vmx builder.
2018-12-11 11:53:26 +01:00
a819217c93
fix virtualbox 6.0 beta command options
2018-12-10 15:18:21 -08:00
1a36458e9e
Tiny fix to replace some duplicate code with usage of the `halt` closure in the StepCloneVMX step for the vmware-vmx builder.
2018-12-10 16:24:27 -06:00
d367c1ba8b
Merge pull request #7091 from arizvisa/GH-6920
...
Proper fix to #6920 which ensures that entrypoint and arguments get passed to docker, not the image.
2018-12-10 13:25:34 -08:00
a6af04417e
Moved the entrypoint argument for the docker builder in front of the image so it's passed correctly as an argument.
2018-12-10 15:09:56 -06:00
32f226eda0
Merge pull request #7069 from arizvisa/GH-6920
...
Updated docker's default config to use regular bourne shell instead of bourne again.
2018-12-10 11:29:27 -08:00
c4782807de
Merge pull request #7050 from chhaj5236/feature/force_delete_copied
...
alicloud: delete copied image and snapshots if corresponding options are specified
2018-12-09 19:39:14 +08:00
c42b3a41a9
Merge pull request #7059 from hashicorp/fix_6965
...
Fix 6965
2018-12-07 13:35:00 +01:00
ce71932f95
Merge pull request #7061 from boumenot/pr-6773-caching-type
...
azure: configuration for disk caching
2018-12-06 15:06:21 -08:00
042e9ad14b
Move logging about aws waiters to the access config prepare() so that it's only spit out once per builder.
2018-12-06 14:37:31 -08:00
dbfc1b5aff
fix tests
2018-12-06 09:36:16 -08:00
0058422a5c
also for vmx
2018-12-05 15:58:44 -08:00
0fe4d79bbf
add validation to prevent users from being confused about format functionality
2018-12-05 15:57:45 -08:00
2e977019e4
Modified the docker builder's default run_command to specify the shell via the entrypoint command line argument as suggested by @vrubiolo in #6920 .
2018-12-04 23:52:17 -06:00
0174a502eb
support -force option and update docs
2018-12-05 11:50:35 +08:00
310ea6c006
Updated docker's default config to use regular bourne shell instead of bourne again. Closes #6920 .
2018-12-04 18:28:48 -06:00
040a33567e
Trying again one more time to prevent import cycles.. Moved common.ExpandUser into packer.ExpandUser..
2018-12-04 16:54:47 -06:00
79b68fb89c
Replaced the previous incorrect logic with an re-implementation of common.ExpandUser.
2018-12-04 16:53:33 -06:00
e04986659a
Changed the logic for when to actually prefix a path with a u.HomeDir so that it's only done when a non-absolute path is specified.
2018-12-04 16:53:33 -06:00
1a3c3f2ffc
Replaced all instances of mitchellh/go-homedir with an implementation based on os/user.
2018-12-04 16:53:33 -06:00
152f6fed8f
Merge pull request #7066 from arizvisa/vmware-temporary-devices
...
Add a "temporaryDevices" key to the statebag for the VMware builder
2018-12-04 10:34:37 -08:00
96bdf17d2e
Added knowledge of the "temporaryDevices" statebag to the StepCleanVMX tests for the VMware builders.
2018-12-03 18:03:02 -06:00
65124985d1
don't set DetectZeroes if it's off, because some versions of QEMU don't support this option
2018-12-03 15:52:13 -08:00
fa4998e1ec
Modified StepCleanVMX to walk through the "temporaryDevices" statebag so that we can disable or remove its devices cleanly. This gets rid of the regex hack that was previously used to identify a cdrom-image.
2018-12-03 17:50:40 -06:00
e0d3861e81
Updated StepCreateVMX to add the CDROM device that packer uses to the "temporaryDevices" statebag so that StepCleanVMX can unmount its ISO later.
2018-12-03 17:48:05 -06:00
3512c3c5ea
Updated StepConfigureVMX to add the floppy disk device to the "temporaryDevices" statebag so that StepCleanVMX can remove it later.
2018-12-03 17:48:05 -06:00
27b16cee0a
Added a new "temporaryDevices" key to the VMware builders' statebag in order to keep track of devices that were temporarily added during build and need to be removed later by StepCleanVMX.
2018-12-03 17:47:45 -06:00
c7d8f4e150
azure: configuration for disk caching
...
Export a configuration knob to change the disk caching setting. The
default value remains ReadWrite. This seems the most appropriate value
given Packer. Certain disk sizes require that disk caching be disable,
and this knob allows the user to do just that.
2018-11-30 14:14:43 -08:00
c0c5c6afac
Add DigitalOcean post-processor.
2018-11-29 21:00:57 -05:00
c03894c05d
fix bad interpolation exemption for volume_size
2018-11-29 16:39:43 -08:00
c29268a5d2
Merge pull request #7046 from nferch/hcloud_snapshot_labels
...
add snapshot_labels to hcloud builder
2018-11-29 13:48:57 +01:00
a2c3b35bff
Merge pull request #7032 from hashicorp/fix_region_validation
...
move region validation to run so that we don't break validation when no creds are set
2018-11-28 15:02:18 -08:00
11ef407b4d
Merge pull request #7016 from rickard-von-essen/vmware-tech-prev
...
vmware: Correctly parse version for VMware Fusion Tech Preview
2018-11-28 14:59:53 -08:00
bf97557abf
Backport VNC log from vmware to qemu
2018-11-28 19:13:29 +01:00
a485bcfdf3
delete copied image and snapshots if corresponding options are specified
2018-11-28 21:34:21 +08:00
ec75913412
fix crash that occurs when dir is nil
2018-11-27 16:34:26 -08:00
89fb8f0d3e
fix defaulting/lack thereof for cpu count and memory in vmware template
2018-11-27 15:43:48 -08:00
fccd7d0692
add snapshot_labels to hcloud builder
2018-11-27 14:41:32 -05:00
6728244480
simplify for loop logic
2018-11-27 09:33:29 -08:00
c05ac784d3
fix tests
2018-11-27 09:31:01 -08:00
5ada3376b8
fix test
2018-11-27 09:31:01 -08:00
2c989157e4
gofmt
2018-11-27 09:31:01 -08:00
5b6cbeed1d
expose `--iso` option down in `VBoxManage export --iso` up to virtualbox-iso configuration as "bundle_iso"; ensure ISOs are not removed when this is enabled.
2018-11-27 09:31:01 -08:00
8cc3320977
Merge pull request #7034 from zenjoy/hcloud/rescue_mode
...
[Hetzner Cloud] Support for builds using rescue mode
2018-11-26 11:39:34 -08:00
7704ff2f24
apply tags to relevant snapshots
2018-11-26 16:58:32 +08:00
1aaa998b02
Revert back to reset server
2018-11-26 09:49:45 +01:00
6589bfaaab
Small code improvements and fixes
2018-11-26 09:10:17 +01:00
53bfe7179f
Merge pull request #7022 from chhaj5236/feature/image_without_datadisks
...
alicloud: support creating image without data disks
2018-11-26 13:13:51 +08:00
76d1bf567e
Replaced compute/v2/images with imageservice/v2/images.
...
Removed usage of a deprecated API.
Standardized clientService naming.
2018-11-25 14:30:31 -05:00
3c1395eb04
support wait_snapshot_ready_timeout for much bigger disk
2018-11-25 16:05:26 +08:00
0f3bfbf8e6
Fix timing issues by updating to hcloud-go v1.11.0
2018-11-24 17:56:09 +01:00
802e7d467d
openstack: Add support for tagging new images.
2018-11-23 20:22:10 -05:00
064e6c7e08
Add support for builds using rescue mode
2018-11-23 20:35:32 +01:00
e539133d8c
Merge pull request #7019 from arizvisa/vmware.cpu-memory
...
Add configuration options to vmware builder to specify cpu count and memory size
2018-11-23 10:53:46 +01:00
24510907be
Merge pull request #7018 from arizvisa/parallels.cpu-memory
...
Add configuration options to parallels builder to specify cpu count and memory size
2018-11-23 10:50:01 +01:00
174c811c1e
Merge pull request #7017 from arizvisa/virtualbox.cpu-memory
...
Add configuration options to virtualbox builder to specify cpu count and memory size
2018-11-23 10:27:14 +01:00
f8c23c1808
Updated things related to the vmware-iso builder to include @azr's suggestions.
2018-11-22 21:03:06 -06:00
0f019407d6
Updated things related to the general hw config in the virtualbox builders to correspond to @azr's suggestions.
2018-11-22 20:48:00 -06:00
784535a4e3
Updated things related to the parallels-iso builder to correspond to @azr's suggestions.
2018-11-22 20:19:00 -06:00
61ee3a44f5
Modified the cpus and memory options for the vmware builders to only apply them if they were specified.
2018-11-21 00:43:14 -06:00
da6e350949
fix tests
2018-11-20 15:20:01 -08:00
fbb3d526e3
move region validation to run so that we don't break validation when we don't have aws creds set
2018-11-20 15:01:28 -08:00
849a6ed353
add ssh_keys config to hcloud builder
2018-11-20 13:58:17 -05:00
3c2c13a021
support creating image without data disks
2018-11-19 15:25:12 +08:00
fb7ce9f2b5
Renamed both `cpu_count` and `memory_size` to `cpus` and `memory` (respective).
2018-11-17 06:36:02 -06:00
eca26f43f2
Renamed both `cpu_count` and `memory_size` to `cpus` and `memory` (respective).
2018-11-17 06:34:22 -06:00
24140131c7
Renamed both `cpu_count` and `memory_size` to `cpus` and `memory` (respective).
2018-11-17 06:32:11 -06:00
51948daf92
Added options for the cpu count, memory, audio, and usb to the virtualbox builder.
2018-11-17 06:19:54 -06:00
71d15d05c0
Added support for the cpu_count, memory_size, sound, and usb options to the parallels builder.
2018-11-17 06:13:59 -06:00
cd45248eaa
Moved common hardware config options used by the vmware-iso builder into common/hw_config and added options for the CpuCount and MemorySize.
2018-11-17 06:08:08 -06:00
4ea3d1567a
vmware: Correctly parse version for VMware Fusion Tech Preview
...
Closes #5317
2018-11-17 09:32:15 +01:00
4e73c85e22
Re-sorted, grouped, and commented the options in the template VMX for the VMWare builder to keep things organized.
2018-11-16 22:20:00 -06:00
06c2c35e4c
Merge pull request #6980 from amydutta/amdut/snapshot
...
Adding options for Managed Image OS Disk and Data Disk(s) snapshot(s)
2018-11-16 15:51:52 -08:00
b8def0b3fb
Added test to check for missing OS disk snapshot name and data disk snapshot prefix
2018-11-15 22:01:16 +00:00
67342750a3
Addressed PR comments
2018-11-14 01:47:48 +00:00
dca02c7b07
Merge pull request #6962 from hashicorp/fix_6940
...
escape vSphere username when putting it into the query
2018-11-13 10:15:25 -08:00
3b413d2e5e
fix rebase conflicts
2018-11-12 13:24:03 -08:00
89184ae384
rework if/else to simplify main code body.
2018-11-12 13:21:25 -08:00
536e0501ac
Validate username/password for ovftool during prepare.
...
Add template option skip_validate_credentials allowing users to skip this validation if they don't want it.
Refactor vmware-iso builder to separate out config so that it matches the vmware-vmx builder and simplifies the builder.go file
2018-11-12 13:21:25 -08:00
7643ccc67d
Merge pull request #6982 from hashicorp/fix_6161
...
azure builder: allow to auth with managed identities ( MSI )
2018-11-12 09:03:41 -08:00
49b40e0789
Merge pull request #6984 from hashicorp/add_display_name_vmware
...
add new display_name template option
2018-11-12 08:49:38 -08:00
f1fa28847f
remove debug line.
...
Co-Authored-By: SwampDragons <megan@hashicorp.com>
2018-11-12 08:07:08 -08:00
78ac943679
Merge pull request #6987 from hashicorp/6624
...
6624
2018-11-12 15:31:36 +01:00
175b6a7971
add test for MSI configuration
2018-11-12 12:04:57 +01:00
1958ef6e81
remove unecessary check
2018-11-12 11:32:49 +01:00
08e8b1850e
remove unnecessary parenthesis
2018-11-12 10:49:39 +01:00
2d6b18e63e
Fix tests after bug fix
2018-11-10 00:05:25 +00:00
2e2b2cea82
add a warning that checks for collisions between packer-generated values in the default vmx file and the vmx_data
2018-11-09 15:46:52 -08:00
213fbbae00
Updated go version and reformatted
2018-11-09 22:41:48 +00:00
3cf4c63a87
Change antiquated Master/Slave terminology for disk drives to more appropriate Primary/Secondary.
2018-11-09 14:00:07 -08:00
e5c4a4a6fb
create export directories for vmx and ovf file types, too.
2018-11-09 11:45:36 -08:00
a297d73b98
correcting wrong log message
2018-11-09 19:29:57 +00:00
06525dd885
adding logs in the steps
2018-11-09 19:28:37 +00:00
68c9e34bfe
add new display_name template option
2018-11-09 10:54:31 -08:00
be0959004a
Revert "Revert "Rename attribute api_access_key to organization_id""
2018-11-09 08:47:22 -08:00
1ab0173e69
azure builder: allow to auth with managed identities ( MSI )
2018-11-09 17:39:03 +01:00
8881bc2d64
Fix bug in snapshot client creation
2018-11-09 03:30:57 +00:00
c1c929164f
Revert "Rename attribute api_access_key to organization_id"
2018-11-08 16:34:23 -08:00
210d62de2c
Merge pull request #6925 from sieben/organization_renaming
...
Rename attribute api_access_key to organization_id
2018-11-08 16:33:15 -08:00
e54d2e3591
Rename attribute api_access_key to organization
2018-11-08 13:45:32 +01:00
536252683e
builders: reuse private key file reading function
...
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-11-08 14:25:50 +03:00
8d8c86366b
Config tests + typo fix
2018-11-07 22:23:22 +00:00
1fa9f1ef11
formatting changes in stateBag.go
2018-11-07 18:11:48 +00:00
8c326dbab7
Formatting changes
2018-11-07 18:08:15 +00:00
b2d1675d39
Added tests
2018-11-07 03:23:17 +00:00
369b2dae5e
Inlining suggested functions
2018-11-06 21:50:53 +00:00
790d5661c5
escape username
2018-11-06 11:30:45 -08:00
593363c5be
fix typo in last commit
2018-11-06 19:23:15 +00:00
1266d5146d
addressed PR comments + add file for data disk snapshots
2018-11-06 19:17:03 +00:00
8567be43d9
Merge pull request #6927 from hashicorp/rebased_4591
...
Extend vmware-vmx builder to allow esxi builds. (Rebase of PR #4591 )
2018-11-06 09:59:26 -08:00
96d628eef1
fix silliness with pointers
2018-11-06 09:50:28 -08:00
d12d23d34b
OS disk snapshot
2018-11-05 23:48:22 +00:00
79862f1bbb
Merge pull request #6931 from hashicorp/fix_6919
...
aws: better error handling of region/credential guessing from metadata
2018-11-05 11:24:09 -08:00
5c2ca450bd
fix tests
2018-11-02 15:44:27 -07:00
5815b376b4
remove unnecessary checks; we always default format to ovf if it is unset.
...
fix exportoutputdir
2018-11-02 14:22:01 -07:00
c3144c2d0a
add some missing template validation (copied from iso builder) and revert to current use of displayName for parsing vm ssh IP; using VMName was breaking chained builds that hadn't updated the display name from the previous build.
2018-11-02 14:22:01 -07:00
c3d6d45696
modify test so that it accesses CommConfig the same way we really do within the driver
2018-11-02 14:22:01 -07:00
f18bb19f96
remove redundant config; CommConfig was already a part of the SSSHConfig struct
2018-11-02 14:22:01 -07:00
fa12113eaf
remove unused NewLocalArtifact
...
consolidate artifacts
entirely remove local artifact object and get artifacts in the vmx builder the same way we do in the vmware iso builder
2018-11-02 14:22:01 -07:00
3f288fc6ca
aws client: config.WithMaxRetries(8)
2018-11-01 15:09:07 +01:00
daf1f39930
Merge pull request #6918 from hashicorp/oracle_classic_volumes
...
Parameterized volume size support for Oracle classic builder
2018-10-31 16:03:40 -07:00
3ff038d4d1
remove todo
2018-10-31 12:00:33 -07:00
c3a60ad0ce
add options for system disk properties
2018-10-30 21:09:59 +08:00
42cd3e4bf7
Warn if not a pv build but builder image entry is set. cleanup
2018-10-29 15:23:58 -07:00
653fa2298f
use guard clauses
...
* just return early if no FloatingIP is required
* move the instanceIP declaration up and store in the state bag to avoid
errors in ssh.go
2018-10-29 18:36:08 +00:00
4608b5d39d
amazon: add option for skipping TLS verification
...
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-29 21:35:29 +03:00
ea78cb62fd
Make the config.networkV2Client conditional
...
In cases where the OpenStack environment does not contain a v2 network, the
builder will error out. We only need the networkV2Client when using floating
IPs. This will allow packer to work in environments where a v2 network is not
available.
2018-10-29 18:32:09 +00:00
eb976894fc
cleanup
2018-10-27 02:04:36 -07:00
c697c9d3de
cleanup
2018-10-26 21:59:26 -07:00
f322397413
add config tests
2018-10-26 21:56:39 -07:00
6d6d262308
some final fixes and documentation work
2018-10-26 21:56:00 -07:00
4eba1ee724
remove unused config key
2018-10-26 20:02:51 -07:00
03932f1157
Clean up volumes
2018-10-26 20:02:13 -07:00
e2a0cbf7df
move upload script to const
2018-10-26 16:59:23 -07:00
7331d6fc7f
some final clean up
2018-10-26 16:59:23 -07:00
ab4f205bf6
correctly building linux/windows now
2018-10-26 16:59:23 -07:00
09de194d8e
trying to wrap the base communicator config but it needs to be prepared
2018-10-26 16:59:22 -07:00
ab5e964ca6
Connecting to master instance but not builder
2018-10-26 16:59:22 -07:00
ade396e140
don't echo image creation commands
2018-10-26 16:59:22 -07:00
3e966ae38d
make fmt
2018-10-26 16:59:22 -07:00
86f6cf478a
cleanup
2018-10-26 16:59:22 -07:00
6f729d0265
Adding some missing configuration
2018-10-26 16:59:22 -07:00
c42be62d90
fix identifier changes from oracle sdk
2018-10-26 16:59:22 -07:00
bbb0d450f1
todo
2018-10-26 16:59:22 -07:00
be91c99d29
warn about dangling segments.
...
The client offers no way to bulk delete keys, so for now let's just warn users.
The issue is tracked upstream here: https://github.com/hashicorp/go-oracle-terraform/issues/172
2018-10-26 16:59:22 -07:00
ce30e1053e
wip
2018-10-26 16:59:22 -07:00
9f310045fc
split image upload/creation. clean up
2018-10-26 16:59:22 -07:00
420d0ebe3e
fix artifact generation
2018-10-26 16:59:21 -07:00
84bb5d2f6f
create image list
2018-10-26 16:59:21 -07:00
fa54a64d28
WIP
2018-10-26 16:59:21 -07:00
b84c7df9da
Segments going into per-run subfolder
2018-10-26 16:59:21 -07:00
b5c6beb8a3
don't delete segments. registering works now.
2018-10-26 16:59:21 -07:00
705fa976a8
more debugging
2018-10-26 16:59:21 -07:00
2536790e0a
todo
2018-10-26 16:59:21 -07:00
7a35e2408f
fix pty, some todo and refactor of bash scri[t
2018-10-26 16:59:21 -07:00
fc301601e1
actually delete temp container
2018-10-26 16:59:21 -07:00
cd77d00fd8
delete temporary image container
2018-10-26 16:59:21 -07:00
21f786d686
todo and some clean up. correct values for machine image
2018-10-26 16:59:21 -07:00
b222d36669
use 2x volume size
2018-10-26 16:59:21 -07:00
7c577abbcb
WIP: register machine image.
...
remove passwords
2018-10-26 16:59:21 -07:00
8207ba4fa4
Use jq to create manifest. Upload to compute_images
2018-10-26 16:59:20 -07:00
96e62236ec
upload volume WIP
...
check upload for error
increase builder volume size to account for chunking
2018-10-26 16:59:20 -07:00
8598e2d0a3
WIP
2018-10-26 16:59:20 -07:00
bf7c4a7ad6
wip
2018-10-26 16:59:20 -07:00
445c3fb5bb
cleanup temp keys
2018-10-26 16:59:20 -07:00
098764d8ac
WIP
2018-10-26 16:59:20 -07:00
2db0a03142
image upload WIP
2018-10-26 16:59:20 -07:00
265ee0b0b8
add whitespace
2018-10-26 16:59:20 -07:00
7c26ffef9c
builder instance now runs and is connected to
2018-10-26 16:59:20 -07:00
b3ffa975c3
Revert "add boot volume to builder instance"
...
This reverts commit cbce7b42079d2087bc622fd8c6f65d1339b735d1.
2018-10-26 16:59:20 -07:00
2febfa2c7d
attach volume after instance booted
2018-10-26 16:59:20 -07:00
b68f214ca4
add boot volume to builder instance
2018-10-26 16:59:20 -07:00
ca3bffcb0d
bugfix and some debug logging
2018-10-26 16:59:19 -07:00
00ff187d77
master instance working
2018-10-26 16:59:19 -07:00
e271e88b49
oracle-classic variable volume size WIP
2018-10-26 16:59:19 -07:00
f4fbf45349
remove duplicate region check error
2018-10-26 17:44:56 +02:00
16aa21dffe
aws: better error handling of region guessing from metadata
...
* this will fix #6919
2018-10-26 12:24:10 +02:00
2ae235a28a
fix tests
2018-10-25 14:41:01 -07:00
290f4a7c4c
cleanup to make it actually build after that monstrous rebase
2018-10-25 14:17:35 -07:00
3193f50f17
Support export with the vmx builder.
2018-10-25 13:02:37 -07:00
a68a639a1a
Move step_export to common.
2018-10-25 12:55:10 -07:00
63054fb808
Fix the test.
2018-10-25 12:45:44 -07:00
da5f322484
Add quotes around all filenames to prevent issues with spaces
2018-10-25 12:45:44 -07:00
f42f5a8ad3
Remove some extra logging.
2018-10-25 12:44:29 -07:00
e7e6a80587
No need to make upload public.
2018-10-25 12:39:51 -07:00
c294e65c36
A separate driver file is not really needed anymore
2018-10-25 12:39:51 -07:00
2ed6c3ef5e
Set output dir always according to the config.
2018-10-25 12:37:47 -07:00
c940f7e754
Conditional reload.
2018-10-25 12:37:47 -07:00
17845beadc
Fix the CommHost tests
2018-10-25 12:37:47 -07:00
5e74bcfb88
Fix tests, move remote_ default values to driver_config.
2018-10-25 12:30:57 -07:00
4d9cb19012
Refactor artifacts and output_dir implementations.
2018-10-25 12:21:24 -07:00
2d00dc6756
Add VMName to the vmx mods.
2018-10-25 11:17:09 -07:00
7b5943160b
Re-enable the CommHost() call. Use common's driver factory.
2018-10-25 11:17:09 -07:00
ba22090bc9
Move step_register and step_uload_vmx from iso to common.
2018-10-25 11:07:02 -07:00
b5298464c5
Move the remote_driver from iso to common.
2018-10-25 11:01:22 -07:00
91c7089455
Implement the first version of the remote Clone().
2018-10-25 10:37:45 -07:00
46cfb5a30c
Move driver_esx5 to commons and allow it to be instantiated wtih NewDriver()
2018-10-25 10:33:37 -07:00
c7b938c9d4
Merge pull request #6904 from hashicorp/fix_6890
...
Fix 6890
2018-10-24 10:43:34 -07:00
8908a72fa9
builder/hyperv/vmcx: allow to set generation from buildfile
...
this commit fixes #6908
2018-10-24 12:20:52 +02:00
ed793a8fb8
make ValidateRegion a member of *AccessConfig and make it variadic
2018-10-24 11:26:53 +02:00
fe044d8ff7
fix tests
2018-10-23 13:31:56 -07:00
340009009d
Revert "Revert "Merge pull request #6892 from hashicorp/fix_6890""
...
This reverts commit 0cd3f36d50
2018-10-23 09:58:27 -07:00
0cd3f36d50
Revert "Merge pull request #6892 from hashicorp/fix_6890"
...
This reverts commit 1c4062c3169bc41a23b9
2018-10-23 09:34:05 -07:00
1c4062c316
Merge pull request #6892 from hashicorp/fix_6890
...
fix template-set credentials
2018-10-22 13:55:48 -07:00
0924a316b7
fix template-set credentials
...
update tests with mocked session
2018-10-22 13:53:40 -07:00
cdd99564fd
Merge pull request #6891 from hashicorp/fix_6794
...
Fix 6794
2018-10-22 11:10:05 -07:00
091efae8bb
Merge branch 'master' into misc
2018-10-22 11:07:30 -07:00
fd8a85042d
use strconv.Quote instead of fmt.Sprint
2018-10-22 10:59:47 -07:00
18c5e8deb8
fix
2018-10-19 13:46:55 -07:00
1e4133cbf9
quote upload path
2018-10-19 13:43:13 -07:00
3f591d78f3
quote vmx path in register function
2018-10-19 13:42:40 -07:00
8cba32d526
escape all the d.sh calls that contain paths
2018-10-19 13:42:40 -07:00
5b9adc0c48
single quotes
2018-10-19 13:42:40 -07:00
9573013d3a
Merge pull request #6872 from aspectcapital/disable-ena-support
...
Add support to explicitly disable ENA support
2018-10-19 10:54:38 -07:00
9fe27c225b
Merge pull request #6703 from shield-9/wait_volume
...
OpenStack: wait for volume availability when cleaning up
2018-10-19 10:25:51 -07:00
feb8067c7d
Convert `ena_support` to a pointer
...
This means it now has three states, `true`, `false`, & `nil`. The
default state is now `nil` which does nothing instead of `false` which
now will explicitly disable ENA support instead of just not enabling it.
2018-10-19 12:40:43 +01:00
b68168807a
Miscellaneous doc improvements
...
backticks, spaces, commas
In general, a list of items should have a space after each comma.
While there are editorial styles that suggest commas inside quotations,
they're horrible advice when the backticks are describing specific
character for a user to enter.
one off indent filters section
singular
backticks...
word wrap long lines...
spelling: macOS
contributing: clarify closing case
contributing: link to changelog
contributing: point to git remote...
contributing: split commands from descriptions
contributing: grammar
spelling: github
grammar: comma after etc.
spelling: macOS
grammar: i.e.
alicloud: use relative link
alicloud: use backticks
alicloud: bits
alicloud: such as
grammar: comma after etc.
avoid linking periods
grammar: period
amazon-chroot: IOPS
amazon-chroot: use backticks
amazon-chroot: link to section
amazon-chroot: whether-or-not; period
amazon-ebs: period
amazon-ebs: use relative link
amazon-ebs: use backticks
amazon-ebs: comma
amazon-ebs: bold
amazon-ebssurrogate: comma after etc.
amazon-ebssurrogate: this builder
amazon-instance: this builder
amazon-ebssurrogate: set this
amazon-ebssurrogate: whether-or-not
amazon-ebssurrogate: period
amazon-ebssurrogate: bold section reference
amazon-ebssurrogate: backticks...
amazon-ebssurrogate: commas around e.g.
spelling: precedence
spelling: i.e.
amazon-ebssurrogate: backticks...
2018-10-18 19:09:49 -04:00
57f87f58b9
Merge pull request #6374 from rickard-von-essen/aws-filters
...
builder/amazon: Add suppport for vpc_filter, subnet_filter, and security_group_filter
2018-10-18 14:34:02 -07:00
3175dcdf81
Merge pull request #6807 from dev-rowbot/qemu-net-device-6804
...
Fix for #6804 - KVM/QEMU Network "has no peer"
2018-10-18 14:09:22 -07:00
c5b6eff691
Merge pull request #6871 from LKaemmerling/master
...
Add hcloud builder
2018-10-18 11:13:16 -07:00
e4a670d2a2
Remove Debug Message
2018-10-18 10:29:06 +02:00
29d041ea8a
Merge pull request #6858 from hashicorp/tests_race_detector
...
test with race detection enabled + fix race on progressbar
2018-10-18 09:48:03 +02:00
bad1b95a49
Unify steps, fix some typos
2018-10-18 08:03:04 +02:00
fd89d4f020
Merge pull request #6827 from skish/qemuDiskZero
...
builder/qemu add drive detect-zeroes option
2018-10-17 19:12:38 -07:00
2266514408
Merge pull request #6843 from gmmephisto/pr-master-aws-security-group
...
aws: wait for temporary security group before authorize rules
2018-10-17 14:08:49 -07:00
e7d3a30c0e
Merge pull request #6865 from hashicorp/fix_6862
...
Fix 6862
2018-10-17 13:07:29 -07:00
00c96fc400
aws: use IpPermissions for authorizing temporary security group
...
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-17 22:00:25 +03:00
b316be51cd
aws: wait for temporary security group before authorizing
...
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-17 22:00:24 +03:00
b0cfecf314
remove unnecessary valid flag
2018-10-17 11:03:31 -07:00
9e0fae9db3
Add support to explicitly disable ENA support
...
If `ena_support` is set to false then it previously didn't do anything
whereas now it will explicitly disable ENA support.
Fixes #6852
2018-10-17 14:58:07 +01:00
410bee0666
make TestStepShutdown_shutdownDelay less strict on schedule
2018-10-17 12:49:38 +02:00
270110767c
Add hcloud Builder
2018-10-17 12:15:47 +02:00
af3b818de0
TestBuilderPrepare_ISOChecksumType: set config["switch_name"] = "switch" to avoid using builder.detectSwitchName which can lock down in CI mode
2018-10-17 12:09:24 +02:00
0237956e66
builder/virtualbox/common/step_shutdown_test.go: compare durations instead of floats & ouput duration
2018-10-17 11:19:57 +02:00
1ca21499c6
Revert "make builder/hyperv/vmcx/builder_test.go invisible to windows"
...
This reverts commit e692dee2d8
2018-10-17 10:21:53 +02:00
b80a0fed42
make builder/parallels/common/output_config_test.go invisible to windows
2018-10-17 09:59:13 +02:00
e692dee2d8
make builder/hyperv/vmcx/builder_test.go invisible to windows
2018-10-17 09:57:42 +02:00
d4767845f0
fix tests
2018-10-16 15:01:13 -07:00
7c3f0aa3b2
make sure region validation catches authentication errors
2018-10-16 14:17:30 -07:00
ee133482b4
aws: add validation for device_name parameter
...
cause it's required in block-device-mapping.
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-16 21:37:48 +03:00
8a6c55dd69
make builder/hyperv/iso/builder_test.go invisible to windows
2018-10-16 19:09:35 +02:00
28eff7303e
builder/googlecompute: validate startup_script_file exists
2018-10-15 16:09:33 -07:00
cdc6c57b31
Merge pull request #6822 from hashicorp/fix_6774
...
Fix 6774
2018-10-10 13:25:58 -07:00
f5af2afc06
Merge pull request #6818 from hashicorp/fix_6732
...
default wait time for amazon import to one hour.
2018-10-10 11:27:34 -07:00
f331327f24
Merge pull request #6823 from hashicorp/fix_6794
...
fix datastore path that contains spaces
2018-10-10 10:06:15 -07:00
53bce398bb
add Managed Image test to azure artifact
2018-10-10 10:04:19 -07:00
5dc4ff95da
fix azure artifact so it works with managed images as well as VHDs
2018-10-10 10:04:11 -07:00
520dea23fd
Merge pull request #6798 from mbearup/mb-sharedgallery
...
Consume images from Azure Shared Image Gallery
2018-10-10 09:53:18 -07:00
de8d30d77c
Update tests for Azure Shared Image Gallery
2018-10-10 09:20:34 -07:00
fe341e2bd0
fix go source formatting
...
add description to documentation page
2018-10-10 16:16:23 +03:00
1155347b55
add qemu disk detect-zeroes= option
2018-10-10 14:38:59 +03:00
c7180413b0
Fix tests for Shared Image Gallery
2018-10-09 16:38:50 -07:00
e5e75df033
fix datastore path that contains spaces
2018-10-09 16:36:55 -07:00
a3a2a9e970
Fix issue with composite literal in test
2018-10-09 15:35:09 -07:00
335feaf89c
Convert shared_image_gallery options to a struct
...
Updates tests and documentation for shared_image_gallery
2018-10-09 13:56:49 -07:00
895e7fe111
Merge pull request #6812 from hashicorp/remove_unused_processPrivateKeyFile
...
removed unused processPrivateKeyFile func & tests
2018-10-09 13:14:11 -07:00
02bfac118f
default wait time for amazon import to one hour.
2018-10-09 13:08:42 -07:00
f494d87dc5
Merge pull request #6747 from hashicorp/fix_6743
...
abort if image import fails
2018-10-09 12:56:28 -07:00
b2e2d3b008
removed unused processPrivateKeyFile func & tests
2018-10-09 11:56:43 +02:00
65db6be6b9
Fix for #6804
...
The user QEMU args may overwrite the default -device.
This results in no network
2018-10-06 14:40:43 +02:00
5373b8586d
Update tests for Azure Shared Image Gallery
2018-10-05 16:04:07 -07:00
b6bb5d4b4d
Fix format/spacing for config.go
2018-10-05 10:52:02 -07:00
c1e0146d33
Dynamically set apiVersion for Shared Image Gallery scenario.
2018-10-03 16:33:28 -07:00
d21b13cb85
Modify variable names for Shared Image Gallery.
...
Add checks for Shared Image Gallery options.
2018-10-03 16:10:46 -07:00
f44dfcc62f
Merge pull request #6727 from hashicorp/fix_6723
...
reset poll delay seconds default to 2 because it can actuall be used …
2018-10-03 11:15:42 +02:00
146db5667a
fix intermitent TestProcessPrivateKeyFile_encrypted failure
...
Because of deficiencies in the encrypted-PEM format, it's not always possible to detect an incorrect
password. In these cases no error will be returned but the decrypted DER bytes will be random noise.
this closes #3337
2018-10-01 10:29:30 +02:00
55be0da5da
Initial changes to support Shared Image Gallery
2018-09-30 13:56:44 -07:00
b7b1720a91
Merge pull request #6772 from fflorens/scaleway-add-boottype
...
scaleway: add boottype parameter in config
2018-09-27 16:51:01 +02:00
9ea5104b74
scaleway: add boottype parameter in config
2018-09-27 16:37:07 +02:00
37c6f08abe
Revert "Fix bugs"
...
This reverts commit 02139dcb69#6701
2018-09-27 16:27:34 +02:00
016b0985a6
builder/openstack: use config as a pointer so values could be set
...
this commit will close #6712
2018-09-27 16:27:34 +02:00
b328d3569d
builer/triton: pass config as a pointer so values could be set
2018-09-27 16:27:34 +02:00
22d3e9b5c4
builder/amazon/ebs: pass config as a pointer so values could be populated by a run
2018-09-27 16:27:34 +02:00
7f78eef08d
scaleway: fix builder problems with ssh keys
...
The builder is currently failing with the last packer version.
This commit is fixing:
- the ssh keys and configuration management (the config is passed through a pointer and the ssh keys through the config instead of the runner states)
- the key size for generated ssh key
- the public key added as a tag to the instance<Paste>
fix #6757
2018-09-27 15:40:18 +02:00
9181570bc3
remove stray struct dumps in logs
2018-09-27 00:14:05 -07:00
676b28ecc5
Merge pull request #6764 from chhaj5236/feature/support_disable_stop_instance
...
support disable_stop_instance option for some specific scenarios
2018-09-27 14:52:07 +08:00
f59cde03c4
Merge pull request #6763 from chhaj5236/fix/invalid_type_convert
...
fix type error in step_create_tags
2018-09-27 14:49:52 +08:00
bb19cdeb55
support disable_stop_instance option for some specific scenarios
2018-09-25 22:02:05 +08:00
1f3a517a19
fix type error in step_create_tags
2018-09-25 20:20:10 +08:00
838d5021f5
openstack: use source_image_name to find UUID
2018-09-21 10:35:15 +02:00
3b8aba2d24
OpenStack: wait for volume availability when cleaning up
2018-09-21 10:13:45 +09:00
d616f0ba71
abort if image import fails
2018-09-20 13:18:59 -07:00
c848f59a55
Check condition for image_disk_format option
2018-09-20 11:02:30 +09:00
b7bd3d4b34
OpenStack: Change option name to `image_disk_format`
2018-09-20 10:44:28 +09:00
904dd1df63
Add disk_format option for OpenStack builder
2018-09-20 10:44:28 +09:00
b0774d155a
Merge pull request #6512 from sharmaanshul2102/5786-use-describe-regions-for-validation-aws
...
Use DescribeRegions for aws region validation
2018-09-19 10:37:42 -07:00
79093da6ad
skip region validation in tests that don't care; refactor Prepare func so we can test region validation logic with a mock
2018-09-19 10:30:08 -07:00
9ba959598b
Merge pull request #6729 from hashicorp/fix_ssh_digitalocean
...
builder/digitalocean: pass config as a pointer so that ssh configuration is correctly set
2018-09-19 18:26:36 +02:00
9e3e2e83ae
Merge pull request #6720 from chhaj5236/fix/attach_keypair
...
fix attaching keypair error due to missing keypair name
2018-09-19 14:14:55 +08:00
93f1155a14
remove test-related special casing
2018-09-18 08:08:36 -07:00
3c312eb2a0
change b.config to pointer
2018-09-18 21:40:57 +08:00
5389ab1694
pass config as a pointer so that ssh configuration is correctly set
2018-09-18 11:36:21 +02:00
ef3c10c403
Modify Validate Region for test cases
2018-09-17 14:45:55 -07:00
98f13eaf29
Use DescribeRegions for aws region validation
2018-09-17 14:45:55 -07:00
f4e6d06e68
reset poll delay seconds default to 2 because it can actuall be used in one part of the conditional tree for applyEnvOverrides
2018-09-17 11:10:50 -07:00
43e091de15
Merge branch 'master' into feature/support_tags
2018-09-17 16:50:44 +08:00
31bbe2983b
Merge pull request #6688 from chhaj5236/feature/support_ssh_private_ip
...
support ssh with private ip address
2018-09-17 16:46:38 +08:00
b3aae89a53
fix attaching keypair error due to missing keypair name
2018-09-16 18:19:00 +08:00
b8a3e3b8f4
support adding tags to image
2018-09-16 18:16:13 +08:00
fc75449e06
Merge pull request #6713 from hashicorp/cleanup_keys
...
new option allowing user to clean up the ephemeral ssh key from the a…
2018-09-14 11:12:33 -07:00
38cc525ec7
new option allowing user to clean up the ephemeral ssh key from the authorized_keys file
2018-09-14 11:06:38 -07:00
02139dcb69
Fix bugs
2018-09-13 14:39:38 +09:00
770f61e682
spot instance creation, only set blockDurationMinutes when > 0
2018-09-12 10:21:39 -07:00
2e73ed8d46
pass Comm instance to fix Spot instance creation
2018-09-11 18:20:14 -07:00
09797df958
use a UI wrapper to auto-decode error messages
...
update docs to reflect optional config
2018-09-11 16:05:43 -07:00
743be8a808
support ssh with private ip address
2018-09-11 16:56:57 +08:00
a0edaf6c46
Going to revert this change for now, becuase of potential issues that arise from calling Prepare() twice
...
Revert "use statebag instead of SetSharedState for winRM password"
This reverts commit b35acbd879
2018-09-10 16:48:42 -07:00
e02d0dacc4
Merge branch 'master' into aws-filters
2018-09-07 16:14:00 +02:00
63d784023f
Add support to support non-gp2 volume types for building from_scratch
2018-09-06 13:22:09 -07:00
07ce820c70
Enable setting the volume type when building with the Amazon Chroot builder
2018-09-06 13:22:09 -07:00
b94e6e913e
Merge pull request #6670 from sargun/fix-ena-on-pv
...
Allow users to build hvm images from pv images to have ena_support
2018-09-06 12:50:46 -07:00
4682b3a9d2
refactor possible random strings into common/random
2018-09-05 10:26:52 +02:00
b80e1d51c6
aws: when building an AMI with 'encrypt_boot: true', randomize the name of the temporary AMI
2018-09-05 10:24:28 +02:00
170b2f3383
builder/azure/common.RandomString-> common/random.String
...
* to share them
* also removed unused PassworString func & arm.TempPasswordAlphabet package const
2018-09-05 10:24:28 +02:00
902497d6ce
Allow users to build hvm images from pv images to have ena_support
2018-09-04 18:16:52 -07:00
cb35829f80
Merge pull request #6411 from jmartin-r7/esxi_compact
...
add support for disk compaction to esx5 builder
2018-09-04 12:44:32 -07:00
2e294da82a
Merge pull request #6644 from riezebosch/master
...
[azure-arm] retry cleanup individual resources on error
2018-09-04 11:40:27 -07:00
349f9ae62b
Merge pull request #6641 from hashicorp/increase_retries
...
Increase retries
2018-09-04 11:39:28 -07:00
819bda50d5
Merge pull request #6648 from hashicorp/fix_6642
...
Update public google cloud image projects
2018-09-03 09:29:31 +02:00
2a2734505b
Merge pull request #6649 from hashicorp/fix_6569
...
Fix 6569
2018-09-03 08:44:07 +02:00
26aab49aaf
aws spot instances: add block_duration_minutes option ( #6638 )
...
* Add block_duration_minutes option
* int64 cannot be nil
* Update doc
* Fix formating
2018-09-03 08:33:58 +02:00
4472ecccb0
fix waiters that weren't applying env defaults
2018-08-31 13:30:41 -07:00
d00b815c06
Update public google cloud image projects
2018-08-31 13:13:19 -07:00
fcfa54fb1d
[azure-arm] retry cleanup individual resources on error
2018-08-31 13:43:38 +02:00
61480f41dc
fix some go vet issues in tests ( composite literal uses unkeyed fields )
2018-08-31 11:54:12 +02:00
1833b4edaf
validate compaction is skipped when not 'thin'
2018-08-30 16:44:00 -05:00
b51cd22b21
document ESXi disk compaction & use verbose option
2018-08-30 16:44:00 -05:00
09c71f3810
add support for disk compaction to esx5 builder
2018-08-30 16:43:53 -05:00
9926988ab7
Merge pull request #6621 from hashicorp/ssh_keys_centralised
...
Merge ssh fields usage
2018-08-30 14:13:21 -07:00
d606339edc
Merge pull request #6635 from hashicorp/fix_6493
...
fix chroot communicator to properly escape quotes
2018-08-30 09:40:03 -07:00
2b9f937c23
increase max retries from 3 to 20
2018-08-30 09:35:06 -07:00
cbbfc6630d
scaleway: stop using config from statebag
2018-08-30 17:58:09 +02:00
d159c0900b
openstack: use config only where needed
2018-08-30 17:52:11 +02:00
df9e756865
pass the Comm instance to the amazon ebs builders steps
2018-08-30 12:50:29 +02:00
157691c710
remove unecessary get/pug config in tests; those are being referenced
2018-08-30 12:07:37 +02:00
94d5bb7a3b
revert test changes of builder/googlecompute/step_create_ssh_key_test.go
2018-08-30 12:04:21 +02:00
344e7e8b92
Validation for tag configuration
2018-08-29 15:31:05 -07:00
cc7d4e4a95
Add support for freeform tagging of images
2018-08-29 15:31:05 -07:00
050a98e8bb
googlecompute builder: use config from statebag
2018-08-29 18:15:09 +02:00
b0c09087a2
move SSHInterface/SSHIPVersion fields to communitator.Config struct
2018-08-29 14:51:28 +02:00
cd851f8ac2
use public ssh key & key name from config instead of the statebag
2018-08-29 14:40:33 +02:00
0938b640cc
use key pair name from config
2018-08-29 14:40:33 +02:00
1e71712cc9
builder.alicloud: stop using config from statebag
2018-08-29 14:40:33 +02:00
4fdf5714a6
builder.scaleway: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
0f9eddda3a
builder.oracle: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
92570a2725
builder.openstack: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
4982627dd2
builder.gcp: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
e0e6b0b8f7
builder.cloudstack: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
ef4ca9c48e
builder.amazon: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
dffcbb7a35
builder.alicloud: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
9a9b82715b
config.Comm.SSHKeyPair => SSHKeyPairName
2018-08-29 14:40:33 +02:00
3a4bb26150
builder.aws: use key pair from comm struct
2018-08-29 14:40:33 +02:00
293c485372
builder.aws: use SSHAgentAuth from Comm
2018-08-29 14:40:33 +02:00
ef08c441c9
builder.aws: use Comm field for StepKeyPair & StepGetPassword
2018-08-29 14:40:33 +02:00
7c358eed2f
removed unused builder/azure/common/lin.StepGeneralizeOS struct
2018-08-29 14:40:33 +02:00
3d46fbd4f2
removed unused builder/azure/common/lin.StepCreateCert struct
2018-08-29 14:40:33 +02:00
25de7ad1f2
PrivateKey => PrivateKeyFile
2018-08-29 14:40:33 +02:00
324c46279b
up test
2018-08-29 14:40:33 +02:00
5369c15459
helper: communicator.SSHFileSigner => ssh.FileSigner
...
* had to to avoid circular dependency
* this commit fixes #6631 ( esxi cannot be reached by ssh )
2018-08-29 14:40:33 +02:00
b83c72fd54
more private keys in config
2018-08-29 14:40:32 +02:00
336cac29d4
also use config.SSHPrivateKey for azure-arm builds
2018-08-29 14:40:32 +02:00
d49ad12895
update gcp ssh tests
2018-08-29 14:40:32 +02:00
663c8134ef
GCP: put ssh public/private key in config
2018-08-29 14:40:32 +02:00
51d2aac9f6
SSHPrivateKey => SSHPrivateKeyFile
2018-08-29 14:40:32 +02:00
e4f6b6f720
fix chroot communicator to properly escape quotes
2018-08-28 09:16:43 -07:00
7519037562
Merge pull request #6629 from hashicorp/travisbuild
...
travis builds go 1.11. remove 1.9
2018-08-24 20:51:31 -07:00
3f1a9766f4
formatting verb fixes for go 1.11
2018-08-24 16:18:21 -07:00
e41e99954d
go 1.11 format rules
2018-08-24 15:56:44 -07:00
c5b346b07b
Merge pull request #6393 from DanHam/fix-hyperv-export
...
Various improvements to Hyper-V ISO and VMCX builders
2018-08-24 15:52:49 -07:00
bf191d1ef6
Merge pull request #6204 from arizvisa/GH-6197
...
Specify "bios.hddOrder" during the CreateVMX step for the vmware-iso builder.
2018-08-24 15:46:31 -07:00
b35acbd879
use statebag instead of SetSharedState for winRM password
2018-08-24 13:51:16 -07:00
23f62f221e
Only filter SG's on VPC if it's set. Only use VPC's and Subnets that are available
2018-08-24 20:24:48 +02:00
fa99f931b7
Merge pull request #6601 from hashicorp/fix_6536
...
Increase waiter timeout for AWS WaitUntilImageAvailable command
2018-08-24 09:35:58 -07:00
6bbcd3e914
Remove remaining unused ssh config funcs and add missing calls ( #6622 )
...
* Remove duplicate unused SSHConfig funcs
* call to SSHConfigFunc() for azure/arm builder
* ncloud too
* remove empty ncloud file
2018-08-24 16:00:40 +02:00
533967cb66
builder/amazon: Add suppport for security_group_filter
...
Allow selecting SG's using a filter. Also some cleanup of vpc_filter and
subnet_filter.
2018-08-24 12:42:38 +02:00
340363a649
Merge pull request #6613 from hashicorp/merge_ssh_config_funcs
...
Merge ssh config funcs from builders
2018-08-23 16:03:36 -07:00
1f79b430ee
Merge pull request #6610 from hashicorp/filter_logs
...
Filter logs
2018-08-23 13:30:21 -07:00
7f518cc2d0
Merge pull request #6616 from hashicorp/fix_6496
...
added new template variables to replace PACKER_KEY_INTERVAL with tuna…
2018-08-23 13:21:31 -07:00
31d4f8af45
use a time.Duration instead of a hardcoded ms
2018-08-23 13:16:01 -07:00
9840862757
builder/amazon: Add suppport for vpc_filter and subnet_filter
...
First step of adding support for discovering VPC's and Subnets using
filters.
2018-08-23 12:52:03 +02:00
70cfafb75c
Merge pull request #6490 from tcarrio/most-recent-image-openstack
...
OpenStack source image search filter
2018-08-23 12:41:06 +02:00
e2fe5cd775
Updated test cases to cover bad filters and empty()
2018-08-22 18:23:12 -04:00
bb319fb1e8
Merge pull request #6607 from hashicorp/gcp_min_cpu_platform
...
GCP: min cpu platform
2018-08-22 12:58:34 -07:00
918db58604
added new template variables to replace PACKER_KEY_INTERVAL with tunable key and keygroup intervals depending on driver used
2018-08-22 11:37:56 -07:00
e5ffa9e5b3
use SSHConfigFunc on right member in builder/parallels/pvm/builder.go
2018-08-22 18:23:23 +02:00
fa44a4546f
use ssh.ParsePrivateKey where we can
2018-08-22 18:23:09 +02:00
41f6e0334d
refactor all copy pasted sshConfig with into communicator.Config.SSHConfigFunc
...
* still need to append the auth methods into an array for gracefullness
2018-08-22 17:02:23 +02:00
057a635cab
Merge pull request #6532 from sermilrod/Allowing-fixed-port-in-forwarding-rules
...
Cloudstack builder: adding public_ssh_port flag to use a fixed port in the forwarding rules
2018-08-22 14:27:38 +02:00
3b49caaf40
OpenStack: refactored how source_image_filter is handled to remove reflection
2018-08-22 13:37:43 +02:00
befdb59da6
renaming public_ssh_port to public_port
2018-08-22 10:17:46 +01:00
bd1961b927
Correctly fail if no Image matches filter
2018-08-21 12:46:42 +02:00
b038cd10f5
GCP: Allow to set MinCpuPlatform
2018-08-21 10:09:30 +02:00
e37f126cf1
update gcp google.golang.org/api/compute/v1/
2018-08-21 10:09:01 +02:00
ff6a039d5b
replace scrubconfig with packer.LogSecretFilter.Set
...
filter winrm password from logs
Add new root-level packer template option, sensitive-variables, to tell us what user variables to mark sensitive.
2018-08-20 15:35:55 -07:00
31fcfe4bc2
PoC for filtering logs
2018-08-20 15:20:21 -07:00
6b3844a64f
Revert "allow to use ISO images in-place v.s. copying them"
2018-08-20 10:48:06 +02:00
c5fe1e9e34
Updated to @rickard-von-essen's code review suggestions, including:
...
- filter build and error checking in Prepare stage (multiErr created in the original function will be returned to Prepare and appended, so all errors show).
- source_image overrides source_image_filter.
- Doc edit
2018-08-19 18:47:07 -04:00
5ca5c037eb
Updated filter parser to log all invalid values/fields provided by user
2018-08-19 18:45:22 -04:00
fc19cd8d28
Updated limit logic, removed limiter, updated test cases and sort field used
2018-08-19 18:45:22 -04:00
4147062802
Internally handling most_recent logic.
2018-08-19 18:45:22 -04:00
2d5d1890d4
Switching sort method
2018-08-19 18:45:22 -04:00
8d98237a15
I should have a git-status alias to make fmt
2018-08-19 18:45:22 -04:00
036918b81b
Updated to comments in PR#6490 - Thanks @haxorof
2018-08-19 18:45:22 -04:00
db3d2682b5
Updated allowed filters to tags, visibility, owner, and name. Test cases updated and passed
2018-08-19 18:45:22 -04:00
e9e58e6b2b
Tags field parsed from "tags" and updated test case
2018-08-19 18:45:22 -04:00
c8fd53d60b
make fmt
2018-08-19 18:45:22 -04:00
de9999ecb9
Updated tag to slice, docs, comments, only active images, source_image_name supercedes filter name
2018-08-19 18:45:22 -04:00
e776ad51a9
Removing statement from old image erroring logic
2018-08-19 18:45:22 -04:00
3a6ab0fc0e
Updated test logic and Error->Errof for formatted output.
2018-08-19 18:45:22 -04:00
6dc71590eb
Updated OpenStack Builder docs and tests
2018-08-19 18:45:22 -04:00
94018c691c
Fixed step interface, added step to builder, passing all tests for new image_query.go
2018-08-19 18:45:22 -04:00
a87c8fec38
Fixing up reflection issues on ListOpts builder
2018-08-19 18:39:42 -04:00
810a602a1b
Added testing on query helper functions
2018-08-19 18:39:42 -04:00
33caed3531
Completed filters and most_recent processing using OpenStack imageservice API
2018-08-19 18:39:42 -04:00
00c6ec979f
do 30 minutes not 25
2018-08-17 13:30:02 -07:00
00de0f4996
increase the timeout for waiting for an ami to become available
2018-08-17 13:27:19 -07:00
5dbd71b857
Merge pull request #6593 from hashicorp/iso_inplace
...
allow to use ISO images in-place v.s. copying them
2018-08-17 10:27:50 -07:00
6bf442f039
OpenStack builder: fix floating IP docs
...
Update website documentation about "floating_ip_network" parameter.
Add new inline comment about alghoritm that is used for checking
floatingIP-related configuration parameters.
2018-08-17 07:55:31 +03:00
103403db48
OpenStack builder: do not always use floating IPs
...
Only associate floating IPs if user provided "floating_ip_network" or
"floating_ip".
Remove FindExternalNetwork helper method because it won't be used.
2018-08-17 00:49:06 +03:00
5d6ba4301d
OpenStack builder: fix floating_ip_pool validation
...
Only use "floating_ip_pool" if "floating_ip_network" wasn't set.
Update unit test for the OpenStack builder parameters.
2018-08-17 00:15:18 +03:00
1af899248b
OpenStack builder: allow floating IP network name
...
Add support for the external network reference by it's name apart from
ID.
Include external network id in a log message of
the openstack/step_allocate_ip.
2018-08-16 23:38:41 +03:00
c9047cbfbe
OpenStack builder: update floating IP params
...
Rename "floating_network" to the "floating_ip_network".
Return old "floating_ip_pool" parameter for backward compatibility with
old configuration files. It's value will be passed to the
"floating_ip_network" parameter.
2018-08-16 22:18:48 +03:00
0eef9b4292
OpenStack builder: floating IP refactoring
...
Remove usage of the deprecated OpenStack Compute service floating IP
management and add methods to work with the OpenStack Networking
service floating IPs API.
Remove usage of the deprecated OpenStack Compute service floating IP
pools and add methods to work with the OpenStack Networking service
external networks API.
Move reusable logic of working with the OpenStack Networking service API
to a separate methods in the networking.go file.
Pass error messages from the API services to the ui messages in the
allocate IP step.
2018-08-16 22:15:26 +03:00
Johannes J. Schmidt
Christopher Boumenot
Ladar Levison
Megan Marsh
wizurijyq
DanHam
Christopher Boumenot
Adrien Delorme
Adrien Delorme
Tom Elliff
Ali Rizvi-Santiago
chhaj5236
bozhi.ch
Andrew Starr-Bochicchio
PORTE Loïc
Nathan A. Ferch
Andrew Pennebaker
dedene
zhuzhih2017
Kevin Bulebush
Rickard von Essen
Amrita Dutta
Rémy Léone
Mikhail Ushanov
Matthew Hooker
chbell43
Alexander Laamanen
Stuart Miller
Matt Dainty
Josh Soref
Lukas Kämmerling
Lukas Kämmerling
Matthew Aynalem
mbearup
Konstantin Shloma
Rowan Potgieter
Florian Florensa
mvaude
Daisuke Takahashi
Anshul Sharma
Matt DeBoer
Sargun Dhillon
RenaudS
Manuel Riezebosch
Jeffrey Martin
Harvey Lowndes
Tom Carrio
Sergio Millan Rodriguez
Andrei Ozerov