Commit Graph

8569 Commits

Author SHA1 Message Date
Andrew Gaul 8f8b6dd7ce Further FindBugs fixes 2014-09-02 15:24:33 -07:00
Andrew Gaul 34cfdbe266 Enforce Override annotation via Checkstyle
Also remove bogus inheritDoc on base and static methods.
2014-08-31 19:37:50 -07:00
Andrew Gaul fdef97d527 Add suppressions to FindBugs 2014-08-30 14:34:59 -07:00
Andrew Gaul 195998b3b6 Miscellaneous FindBugs fixes 2014-08-30 14:33:10 -07:00
Andrew Gaul 5399cb6877 Avoid unnecessary boxing
Found with FindBugs.
2014-08-30 14:30:47 -07:00
Andrew Gaul 63d43f236e Correct unusual equals implementations
Found with FindBugs.
2014-08-30 14:30:44 -07:00
Andrew Gaul df996f3231 Set Content-MD5 only if ETag has correct format
Previously this check was more lenient than it should have been.
2014-08-28 21:50:57 -07:00
Everett Toews 268fb242d5 jclouds Development Tools 2014-08-28 10:19:57 -05:00
Andrew Gaul 550018a68d Use randomByteSource to generate test data
This avoids buffering the entire bolus of data in-memory.
2014-08-27 15:59:36 -07:00
Andrew Gaul ba9c4b972a Upgrade to maven-findbugs-plugin 3.0.0
Notably this release include support for Java 8.  Changelog:

http://findbugs.sourceforge.net/Changes.html
2014-08-26 18:16:18 -07:00
Andrew Gaul df94527056 Ensure no calls to primitive wrapper constructors 2014-08-26 17:51:29 -07:00
Andrew Gaul 37d65d3d81 Avoid primitive wrapper constructors 2014-08-26 17:51:11 -07:00
Andrew Gaul 92d5091845 Enforce no redundant modifiers via Checkstyle
This check also helps find utility classes which should not allow
instantiation.
2014-08-26 17:38:21 -07:00
Andrew Gaul 1b824afbfc Remove redundant modifiers from interfaces 2014-08-26 17:34:13 -07:00
Ignasi Barrera b2cb898123 Ignore jEnv files 2014-08-26 23:54:44 +02:00
Andrew Gaul 480f0e883d Prevent instantiation of utility classes
Also prevent extension.
2014-08-26 12:23:36 -07:00
Andrew Gaul 967f55c2e4 Enforce type naming via Checkstyle 2014-08-26 11:29:25 -07:00
Andrew Gaul bf678edb97 Enforce no leading or trailing spurious whitespace 2014-08-26 11:16:24 -07:00
Andrew Gaul 9c2c2e0c44 Remove spurious whitespace
Also remove spurious unary operator plus.
2014-08-26 11:15:55 -07:00
Andrew Gaul 8b16bf0e47 Enforce whitespace after semicolon 2014-08-26 11:06:16 -07:00
Andrew Gaul 74fb8f0183 Add whitespace after semicolons
Also correct some bad line-wrapping.
2014-08-26 11:06:00 -07:00
Andrew Gaul 614f5194ef JCLOUDS-653: Upgrade to Guava 18.0
Release notes:

https://code.google.com/p/guava-libraries/wiki/Release18
2014-08-25 17:47:23 -07:00
Jeremy Daggett ddd00a20de Added assertion for versioned OpenStack extension APIs. Required for the Neutron v2 API. 2014-08-22 20:30:46 -07:00
Andrew Gaul 60e3763999 Throw ContainerNotFoundException from removeBlob
This makes removeBlob consistent with all other user-facing methods.
2014-08-21 16:18:12 -07:00
Andrew Gaul 80a4430035 JCLOUDS-679: Use HEAD for S3 bucketExists
This method costs 0.4 cents per 10,000 requests instead of 0.5 cents
per 1,000 requests:

http://aws.amazon.com/s3/pricing/

API reference:

http://docs.aws.amazon.com/AmazonS3/latest/API/RESTBucketHEAD.html
2014-08-20 12:44:20 -07:00
Jeremy Daggett e711275fb1 Prefer isEmpty() for collections rather than size() 2014-08-20 11:07:48 -07:00
Chris Custine 192785dbae Move checkstyle copyright header into checkstyle.xml 2014-08-18 18:55:52 -06:00
John Walker e5283df995 JCLOUDS-676: Fix reflection warnings / Clojure
JCLOUDS-676: Fix reflection warnings / Clojure

Also fixed a typo in a doc string
2014-08-17 12:03:30 -07:00
Jeremy Daggett 82fbdf9695 Updated OSGi fragment bundle-version upper constraint from version 2 to 3 2014-08-17 07:59:44 -07:00
Stuart Hendren f3778b6cbd JCLOUDS-661: Adding a test for single-port firewall rules 2014-08-14 12:49:06 -04:00
Jeremy Daggett 7d70362590 Removed @Nullable annotations on region parameters 2014-08-13 15:37:54 -07:00
Jeremy Daggett 744cd5d7eb Prefer Regions to Zones in OpenStack APIs 2014-08-13 09:58:53 -07:00
Andrew Gaul 9009bb5268 JCLOUDS-658: use xattr only on supported systems
Mac OS X HFS+ does not support UserDefinedFileAttributeView:

https://bugs.openjdk.java.net/browse/JDK-8030048
2014-08-12 12:30:06 -07:00
Ignasi Barrera 95b6064c3d JCLOUDS-496: Use the security groups options in the portable TemplateOptions 2014-08-12 13:34:29 -04:00
Andrea Turli 8743e947be JCLOUDS-662: Support multiple disks with the same size using SoftLayerTemplateOptions 2014-08-12 11:22:10 -04:00
Andrew Gaul 204a6c7f3b JCLOUDS-658: xattr for filesystem blob metadata
This allows the filesystem blobstore to mimic real blobstores more
accurately.  This also doubles the speed of getBlob by storing the
Content-MD5 header instead of recalculating it.
2014-08-11 12:56:14 -07:00
Andrew Gaul f236e046e3 Merge identical tests 2014-08-11 12:45:28 -07:00
Andrew Gaul a10bf3e9c5 Remove Java 6 litter 2014-08-11 12:45:27 -07:00
Andrea Turli fecedfdb3f fix ASF copyright headers on SoftLayer 2014-08-11 12:43:57 -07:00
Andrew Gaul aa41d489f4 Remove maven-license-plugin
This never seemed to work and we will enforce license text via
Checkstyle instead.
2014-08-11 10:34:30 -07:00
Andrew Gaul 4e166e3a20 Enforce ASF copyright header via Checkstyle 2014-08-11 10:26:43 -07:00
Andrew Gaul d9650ccdc8 Remove maven.compile.optimize
This setting has no effect.  Reference:

http://stackoverflow.com/questions/4218721/optimizing-java-compiler-during-a-maven-build
2014-08-09 07:09:33 -07:00
Andrew Phillips a6412ad66b Addressing Checkstyle violation
Introduced in 7e4cacf
2014-08-09 09:12:43 -04:00
Andrew Gaul 7e4cacf9ea JCLOUDS-264: Allow payloads greater than 2 GB
Enabled by JDK 7.
2014-08-09 00:28:49 -07:00
Andrew Gaul 5e8bd02c93 JCLOUDS-652: Require JDK 7
Moving to Java 7 allows jclouds to use more language and library
features such as try-with-resources and HTTP client improvements.
2014-08-09 00:28:47 -07:00
Andrew Gaul 20bc145284 JCLOUDS-650: ContainerNotFoundException on putBlob
Found with Ceph s3-tests and s3proxy.
2014-08-09 00:25:10 -07:00
Fabian Lange aa174a5d73 JCLOUDS-656: Parse Swift authentication headers case-insensitively
Also ensure they are added to the result object with the normalized
capitalization expected by downstream code.

Follow-up to 375cb207.
2014-08-08 19:10:00 -04:00
Andrew Phillips 5d3b293b69 Revert "Parse Swift authentication headers case-insensitively"
Missing JIRA issue number.

This reverts commit e532e6f260.
2014-08-08 19:09:36 -04:00
Fabian Lange e532e6f260 Parse Swift authentication headers case-insensitively
Also ensure they are added to the result object with the normalized
capitalization expected by downstream code.

Follow-up to 375cb207.
2014-08-08 19:07:41 -04:00
Andrew Gaul 80a0256cc7 JCLOUDS-622: Remove last vestiges of InputSupplier
Guava 16 deprecated InputSupplier and a future release will remove it.
2014-08-08 15:40:33 -07:00