Gary Pendergast
501b5f545b
Code Modernisation: Remove the `array_replace_recursive()` polyfill.
...
This function was added in PHP 5.3.0, so we no longer need the polyfill.
Props jrf.
See #47698 .
Built from https://develop.svn.wordpress.org/trunk@45636
git-svn-id: http://core.svn.wordpress.org/trunk@45447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-15 05:08:56 +00:00
Gary Pendergast
fbdb267634
WPDB: Allow custom data to be added to logged queries.
...
This adds a new method, `wpdb::log_query()`, and a new filter, `log_query_custom_data`. The custom data is stored as a new element in each entry of the `wpdb::$queries` array.
Props CrazyJaco, johnbillion, pento.
Fixes 42151.
Built from https://develop.svn.wordpress.org/trunk@45635
git-svn-id: http://core.svn.wordpress.org/trunk@45446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-15 04:07:57 +00:00
Sergey Biryukov
83d175cdd0
I18N: Add context for theme filter strings in `WP_MS_Themes_List_Table::get_views()`.
...
Props audrasjb.
Fixes #47695 .
Built from https://develop.svn.wordpress.org/trunk@45634
git-svn-id: http://core.svn.wordpress.org/trunk@45445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-14 14:47:56 +00:00
Sergey Biryukov
436a9512e2
Upgrade/Install: Remove debugging artifacts from `wp-admin/upgrade.php` added in [1229].
...
Props rahulvaza.
Fixes #47074 .
Built from https://develop.svn.wordpress.org/trunk@45633
git-svn-id: http://core.svn.wordpress.org/trunk@45444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-14 14:39:57 +00:00
Sergey Biryukov
e85a5c64a3
REST API: Allow `rest_get_avatar_urls()` to accept full user, post, or comment objects, rather than just an email address, to provide better flexibility for alternative avatar data.
...
Since the function uses `get_avatar_url()` internally, which already supports it, this should not have any backward compatibility concerns.
Props donmhico, dshanske, pputzer, joehoyle, TimothyBlynJacobs.
Fixes #40030 .
Built from https://develop.svn.wordpress.org/trunk@45632
git-svn-id: http://core.svn.wordpress.org/trunk@45443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-14 14:35:56 +00:00
Andrew Ozz
ee8813606d
TinyMCE: fix adding of too many undo levels for wpviews. The HTML changes several times when a wpview is added. We only want one undo level. Also fixes cases when the cursor is next to an embeddable URL in the Text tab and the user switches to the Visual tab.
...
See #45307 .
Built from https://develop.svn.wordpress.org/trunk@45631
git-svn-id: http://core.svn.wordpress.org/trunk@45442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 03:25:55 +00:00
Gary Pendergast
4d3a84aa9f
Code Modernisation: Introduce the spread operator in `wpdb::prepare()`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45630
git-svn-id: http://core.svn.wordpress.org/trunk@45441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:17:57 +00:00
Gary Pendergast
2fe355cdd0
Code Modernisation: Introduce the spread operator in `widgets.php`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45629
git-svn-id: http://core.svn.wordpress.org/trunk@45440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:14:58 +00:00
Gary Pendergast
afdbf749d7
Code Modernisation: Introduce the spread operator in `theme.php`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf, pento.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45628
git-svn-id: http://core.svn.wordpress.org/trunk@45439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:10:56 +00:00
Gary Pendergast
1af80c2106
Code Modernisation: Introduce the spread operator in `walk_page_dropdown_tree()`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45627
git-svn-id: http://core.svn.wordpress.org/trunk@45438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:06:55 +00:00
Sergey Biryukov
02c07f23d5
Customize: Fix text direction for color picker in RTL.
...
Props vjik for the report.
Fixes #47688 . See #23740 .
Built from https://develop.svn.wordpress.org/trunk@45626
git-svn-id: http://core.svn.wordpress.org/trunk@45437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:05:57 +00:00
Gary Pendergast
5fb46ff14b
Code Modernisation: Introduce the spread operator in `add_post_type_support()`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf, pento.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45625
git-svn-id: http://core.svn.wordpress.org/trunk@45436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:02:56 +00:00
Gary Pendergast
41ea1f106d
Code Modernisation: Introduce the spread operator in `Walker`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45624
git-svn-id: http://core.svn.wordpress.org/trunk@45435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 23:51:56 +00:00
Gary Pendergast
4de2f2f49b
Code Modernisation: Introduce the spread operator in `WP_User`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45623
git-svn-id: http://core.svn.wordpress.org/trunk@45434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 23:48:56 +00:00
Gary Pendergast
5d658427a8
Code Modernisation: Introduce the spread operator in `capabilities.php`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@45622
git-svn-id: http://core.svn.wordpress.org/trunk@45433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 23:46:56 +00:00
Andrew Ozz
ff723a2fba
Editor: Make registered editor stylesheets (editor-style.css) available to the front-end.
...
Props webmandesign, azaozz.
Fixes #34882 .
Built from https://develop.svn.wordpress.org/trunk@45621
git-svn-id: http://core.svn.wordpress.org/trunk@45432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 18:30:57 +00:00
Andrew Ozz
969699260d
TinyMCE: fix flickering inline toolbar when showing a tooltip. Take two.
...
Fixes #44911 .
Built from https://develop.svn.wordpress.org/trunk@45620
git-svn-id: http://core.svn.wordpress.org/trunk@45431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 18:18:58 +00:00
Gary Pendergast
bb8afb46b9
Block Editor: Avoid a PHP warning when a theme adds an editor style with an empty filename.
...
Fixes #45739 .
Built from https://develop.svn.wordpress.org/trunk@45619
git-svn-id: http://core.svn.wordpress.org/trunk@45430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 07:21:55 +00:00
Gary Pendergast
4c3d541e23
Block Editor: Fix the link to the classic editor when incompatible meta boxen are detected.
...
Props tmatsuur, mukesh27.
Fixes #45935 .
Built from https://develop.svn.wordpress.org/trunk@45618
git-svn-id: http://core.svn.wordpress.org/trunk@45429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 06:01:58 +00:00
Sergey Biryukov
7369ff02f5
Coding Standards: Remove extra whitespace in list tables' `column_cb()` methods.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45617
git-svn-id: http://core.svn.wordpress.org/trunk@45428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 21:11:58 +00:00
Sergey Biryukov
9a5f538153
Coding Standards: Remove extra whitespace in `wp-admin/includes/image-edit.php`.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45616
git-svn-id: http://core.svn.wordpress.org/trunk@45427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 21:05:57 +00:00
Sergey Biryukov
6a696f6051
I18N: Move code out of translatable string in a `_deprecated_argument()` message in `wp_stream_image()`, `wp_save_image_file()`, and `image_edit_apply_changes()`.
...
Props ramiy.
Fixes #47406 .
Built from https://develop.svn.wordpress.org/trunk@45615
git-svn-id: http://core.svn.wordpress.org/trunk@45426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 20:57:56 +00:00
Sergey Biryukov
bb365054b8
Menus: Remove extra whitespace from URLs in `Walker_Nav_Menu_Edit::start_el()`.
...
Props alexeyskr, SergeyBiryukov.
Fixes #47666 .
Built from https://develop.svn.wordpress.org/trunk@45614
git-svn-id: http://core.svn.wordpress.org/trunk@45425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 20:45:56 +00:00
Sergey Biryukov
29e5155969
Filesystem API: Check correct variable in `WP_Filesystem_Direct::dirlist()` after [45611].
...
Props zinigor.
Fixes #47668 . See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45613
git-svn-id: http://core.svn.wordpress.org/trunk@45424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 15:58:57 +00:00
Gary Pendergast
4be25f3d06
Coding Standards: Fix instances of `WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase`.
...
See #46732 .
Built from https://develop.svn.wordpress.org/trunk@45612
git-svn-id: http://core.svn.wordpress.org/trunk@45423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 06:29:57 +00:00
Gary Pendergast
abcbee954f
Coding Standards: Fix instances of `WordPress.PHP.NoSilencedErrors.Discouraged`.
...
Noteable changes:
- The `magic_quotes_runtime` and `magic_quotes_sybase` settings were removed in PHP 5.4, so no longer need to be set.
- Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
- Quite a few functions would cause errors if `safe_mode` was set. This setting was removed in PHP 5.4.
- Only a handful of `header()` calls needed corresponding `headers_sent()` checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.
See #46732 .
Built from https://develop.svn.wordpress.org/trunk@45611
git-svn-id: http://core.svn.wordpress.org/trunk@45422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 05:45:58 +00:00
Andrew Ozz
4a273484f3
TinyMCE: fix flickering inline toolbar when hovering over the buttons there and the vertical scrollbar is not shown (the page height is less than the window height). Improves/removes the previous fix for similar flickering but only in RTL, see #42018 .
...
Props joakimsilfverberg, mukesh27, kokers, Howdy_McGee, noisysocks, azaozz.
Fixes #44911 .
Built from https://develop.svn.wordpress.org/trunk@45610
git-svn-id: http://core.svn.wordpress.org/trunk@45421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 01:11:55 +00:00
Gary Pendergast
c71bc1513e
Coding Standards: Add missing translator comments to the default themes.
...
All default themes now have translator comments for all strings with placeholders!
See #46732 .
Built from https://develop.svn.wordpress.org/trunk@45609
git-svn-id: http://core.svn.wordpress.org/trunk@45420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 01:10:00 +00:00
Gary Pendergast
82935b0343
Theme Editor: Hide the recommendation to create a child theme when editing a child theme.
...
Props mukesh27, davidbaumwald.
Fixes #44889 .
Built from https://develop.svn.wordpress.org/trunk@45608
git-svn-id: http://core.svn.wordpress.org/trunk@45419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-08 03:15:56 +00:00
Gary Pendergast
ec07a7e565
Coding Standards: Fix the remaining issues in `/tests`.
...
All PHP files in `/tests` now conform to the PHP coding standards, or have exceptions appropriately marked.
Travis now also runs `phpcs` on the `/tests` directory, any future changes to these files must conform entirely to the WordPress PHP coding standards. 🎉
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45607
git-svn-id: http://core.svn.wordpress.org/trunk@45418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-08 00:56:56 +00:00
laurelfulford
83e19085a3
Twenty Thirteen: Add styles for the new Group block.
...
Add styles for the new Group block to the theme, to make sure nested blocks display correctly when using the wide and full alignments.
Props @kjellr.
Fixes #46778 .
Built from https://develop.svn.wordpress.org/trunk@45606
git-svn-id: http://core.svn.wordpress.org/trunk@45417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-07 20:49:55 +00:00
laurelfulford
5b4b6d98ce
Twenty Nineteen: Add styles for the new Group block.
...
Add styles for the new Group block to the theme, to make sure nested blocks display correctly when using the wide and full alignments.
Props @kjellr, @dianeco.
Fixes #46750 .
Built from https://develop.svn.wordpress.org/trunk@45605
git-svn-id: http://core.svn.wordpress.org/trunk@45416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-07 20:11:57 +00:00
Gary Pendergast
28a8f31ffa
Coding Standards: Add missing translator comments.
...
Twentys Eleven, Sixteen, and Seventeen now have translator comments for all their strings.
Also, WPCS now doesn't show missing translator comment warnings for test files.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45604
git-svn-id: http://core.svn.wordpress.org/trunk@45415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 08:04:57 +00:00
Gary Pendergast
14c7533162
Coding Standards: Fix all `WordPress.DB.PreparedSQLPlaceholders` issues.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45603
git-svn-id: http://core.svn.wordpress.org/trunk@45414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 05:43:55 +00:00
Gary Pendergast
87675d288b
Coding Standards: Fix all `WordPress.WhiteSpace.PrecisionAlignment` issues.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45602
git-svn-id: http://core.svn.wordpress.org/trunk@45413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 05:21:56 +00:00
Gary Pendergast
f69c20859e
Coding Standards: Fix all `WordPress.CodeAnalysis.AssignmentInCondition` issues.
...
`WordPress.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition` can be ignored, as this is allowed in Core.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45601
git-svn-id: http://core.svn.wordpress.org/trunk@45412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 03:14:56 +00:00
Gary Pendergast
d378f0a8f4
Coding Standards: Upgrade WPCS to 2.1.1.
...
Noteable changes:
- WPCS now throws warnings when non-strict comparisons are used. There are quite a few of them in Core. 🙃
- WPCS now detects and warns for assignments in loop conditions.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45600
git-svn-id: http://core.svn.wordpress.org/trunk@45411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 02:50:56 +00:00
Gary Pendergast
a02b5cc2a8
Coding Standards: Mark the handful of hook names with uppercase characters or hyphens as ignored.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45599
git-svn-id: http://core.svn.wordpress.org/trunk@45410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 01:45:56 +00:00
Sergey Biryukov
b8be081e7e
Text Changes: Use consistent question wording in database connection error messages.
...
Props Presskopp.
See #44878 .
Built from https://develop.svn.wordpress.org/trunk@45598
git-svn-id: http://core.svn.wordpress.org/trunk@45409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 10:58:56 +00:00
Sergey Biryukov
4af4c78a27
Text Changes: Use consistent question wording for plugin and theme deletion confirmations.
...
Props johnjamesjacoby, Presskopp.
Fixes #44878 .
Built from https://develop.svn.wordpress.org/trunk@45597
git-svn-id: http://core.svn.wordpress.org/trunk@45408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 09:56:57 +00:00
Sergey Biryukov
abe3ec288b
Twenty Nineteen: Fix markup errors in `twentynineteen_add_ellipses_to_nav()`:
...
* Add missing i18n for `aria-label` attribute.
* Remove redundant screen reader text superseded by `aria-label`.
* Remove unnecessary `id` and `class` attributes.
Props afercia, chetan200891, ianbelanger.
Fixes #47067 .
Built from https://develop.svn.wordpress.org/trunk@45596
git-svn-id: http://core.svn.wordpress.org/trunk@45407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 09:23:55 +00:00
Sergey Biryukov
d1815a5c91
Twenty Nineteen: Adjust markup in `twentynineteen_add_ellipses_to_nav()` for better readability.
...
See #47067 .
Built from https://develop.svn.wordpress.org/trunk@45595
git-svn-id: http://core.svn.wordpress.org/trunk@45406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 09:15:58 +00:00
Sergey Biryukov
f84ab5e19f
Twenty Nineteen: Update `package.json` with the latest package versions to pass `npm audit`.
...
Props netweb.
Fixes #47631 .
Built from https://develop.svn.wordpress.org/trunk@45594
git-svn-id: http://core.svn.wordpress.org/trunk@45405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 00:38:58 +00:00
Sergey Biryukov
3a57fee891
Script Loader: Remove unnecessary `jquery` dependency for `wp-sanitize.js`.
...
The file is written in plain JavaScript.
Props sstoqnov.
Fixes #47324 .
Built from https://develop.svn.wordpress.org/trunk@45593
git-svn-id: http://core.svn.wordpress.org/trunk@45404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 00:33:57 +00:00
Sergey Biryukov
f154cd0780
Bundled Themes: Remove extra semicolons from CSS files.
...
Props shashank3105, ianbelanger.
Fixes #47178 .
Built from https://develop.svn.wordpress.org/trunk@45592
git-svn-id: http://core.svn.wordpress.org/trunk@45403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 00:27:58 +00:00
Sergey Biryukov
268c64913e
Query: Make sure `$climits` variable in `WP_Query::get_posts()` is always defined to avoid a PHP notice.
...
Props juiiee8487, agengineering.
Fixes #47638 .
Built from https://develop.svn.wordpress.org/trunk@45591
git-svn-id: http://core.svn.wordpress.org/trunk@45402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-03 01:14:57 +00:00
Gary Pendergast
4803fc405e
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in `wp-includes`.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45590
git-svn-id: http://core.svn.wordpress.org/trunk@45401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 23:42:58 +00:00
Gary Pendergast
55b2d94cca
Formatting: Revert the changes to `wpautop()` in [45585,45587].
...
See #27350 .
Built from https://develop.svn.wordpress.org/trunk@45589
git-svn-id: http://core.svn.wordpress.org/trunk@45400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 11:22:56 +00:00
Gary Pendergast
073f379fd3
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in `tests`.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45588
git-svn-id: http://core.svn.wordpress.org/trunk@45399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 04:43:57 +00:00
Gary Pendergast
b57d185bb1
Formatting: Improve performance of `wpautop()` on large paragraphs.
...
Following [45585], older versions of PHP could segfault when attempting to autop paragraphs with 10,000+ characters.
Rather than having to negative lookahead for every character in the paragraph (which could run into recursion limits), we can quickly jump ahead to the next tag and start checking from there.
See #27350 .
Built from https://develop.svn.wordpress.org/trunk@45587
git-svn-id: http://core.svn.wordpress.org/trunk@45398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 03:29:55 +00:00