14012 Commits

Author SHA1 Message Date
George Kalpakas
582ef2e7b4 ci(docs-infra): split the aio_monitoring CircleCI job into two jobs ()
Previously, the `aio_monitoring` job was testing both the stable
(https://angular.io/) and the @next (https://next.angular.io/) versions.

This commit splits the tests into two separate jobs (still run as part
of the same workflow). This speeds up the tests (since the two jobs can
now run in parallel) and makes it easier to isolate failures (e.g.
identify which branch is failing, disable one of the two, etc.).
(Credits to @petebacondarwin 😉)

PR Close 
2019-04-26 16:33:45 -07:00
George Kalpakas
214fef2ee4 ci(docs-infra): re-use setup CircleCI job in aio_monitoring ()
PR Close 
2019-04-26 16:33:45 -07:00
George Kalpakas
531fcaa99a ci(docs-infra): re-enable aio_monitoring CircleCI job ()
The job started failing for https://angular.io/, due to changes in tests
that only affected https://next.angular.io/, and was disabled in .

This commit re-enables the job (since it does not block anything and it
will be fixed in a subsequent commit).

PR Close 
2019-04-26 16:33:45 -07:00
Suraj Poddar
8a60239ae7 docs(docs-infra): fix typo in workspace-config.md file ()
Fixed typo in 'Project asset configuration' section inside workdspace-config.md

PR Close 
2019-04-26 16:33:03 -07:00
Alan Agius
10705684c8 test: fix api guardian tests on windows when node_modules are not installed ()
When the workspace node_modules are not installed outside of bazel context the api guardian tests fails because the tree artifacts files are not symlinked in windows.

We need to pass the node module location in the node_path

PR Close 
2019-04-26 16:32:23 -07:00
Alan Agius
bdc6818716 ci: add public_api_guard tests to codefresh config ()
PR Close 
2019-04-26 16:32:22 -07:00
Alan Agius
5f95796b61 test: fix ts api guardian and public guard tests on windows ()
This change addresses several issues with ts-api-guardian and public api guards related tests in Windows

The fixes contain 3 main changes:
1) In `stripExportPattern` - replace `^` with `^^^^`  in RegExp due to a double escaping requirment under Windows. Note that under Linux this the extra character has no effect because it's still a valid RegExp in Js.

2. Force `*.patch` files to always be with a LF line sequence instead of CRLF in windows

3. When adding JSDoc comments consider the presence of a carriage return in a line new feed

Partially addresses 

PR Close 
2019-04-26 16:32:22 -07:00
Kristiyan Kostadinov
f2709ac3f9 fix(ivy): correctly reflect undefined values ()
Fixes Ivy reflecting properties with `undefined` values, rather than omitting them. Also fixes that Ivy doesn't clear the reflected values when property value changes from something that is defined to undefined.

This PR resolves FW-1277.

PR Close 
2019-04-26 16:31:49 -07:00
Vani
cce9b9912f docs: update redirect links and fix typo ()
PR Close 
2019-04-26 16:31:04 -07:00
MaksPob
2ae26ce20b build: upgrade yargs package to 13.1.0 ()
Update yargs, because the old version was transitively (via os-local) depending on a vulnerable version of the mem package: https://app.snyk.io/vuln/npm:mem:20180117

PR Close 
2019-04-26 16:29:29 -07:00
Marc Laval
d47de60944 fix(ivy): @Component should support entry components from another module ()
PR Close 
2019-04-26 16:27:19 -07:00
Adam Plumer
acfcf90528 refactor: use new Http library in playground ()
PR Close 
2019-04-26 16:26:30 -07:00
cexbrayat
c99d379cc8 refactor(ivy): move di tests for inject to acceptance ()
PR Close 
2019-04-26 16:23:43 -07:00
cexbrayat
0151ad432b refactor(ivy): move di tests for flags to acceptance ()
Including tests for `@Optional`, `@Self`, `@SkipSelf` and `@Host`.

PR Close 
2019-04-26 16:23:43 -07:00
cexbrayat
1b0be8d656 refactor(ivy): move di tests for directive injection to acceptance ()
PR Close 
2019-04-26 16:23:43 -07:00
cexbrayat
47244ba2b8 refactor(ivy): move di tests for DI tokens to acceptance ()
Move tests for special tokens like `Injector`, `ElementRef`, `TemplateRef`, `ViewContainerRef`, `ChangeDectetorRef` and custom string tokens.

PR Close 
2019-04-26 16:23:43 -07:00
cexbrayat
0d66844ad6 refactor(ivy): move di tests for Attribute to acceptance ()
PR Close 
2019-04-26 16:23:42 -07:00
Kara Erickson
b945bc3a9e test(ivy): pin deps on hello world size tests ()
We recently had an unexpected size regression in the hello world
tests because the CLI devkit released an RC that regressed us and
the dependencies were not pinned. This change ensures that we only
update dependencies like devkit deliberately, so we do not have
mysterious breakages caused by other packages.

PR Close 
2019-04-26 12:34:10 -07:00
Alex Eagle
4ae0ee86cb fix(bazel): update peerDep ranges ()
PR Close 
2019-04-26 12:32:35 -07:00
Marc Laval
6c86ae710a fix(ivy): output should not be subscribe twice when 2 listeners ()
PR Close 
2019-04-26 11:11:09 -07:00
Ben Lesh
f3ce8eeb83 fix(ivy): property bindings use correct indices ()
- Extracts and documents code that will be common to interpolation instructions
- Ensures that binding indices are updated at the proper time during compilation
- Adds additional tests

Related 

PR Close 
2019-04-26 11:09:51 -07:00
Filipe Silva
876ceb3688 docs: remove note about ivy being coupled to dynamic import ()
PR Close 
2019-04-26 11:08:51 -07:00
Alan Agius
ee12c45473 build: bazel ts-api-guardian usage fails on workspaces which don't depend on chalk ()
When using the npm package in a workspace which doesn't depend on chalk, ts-api-guardian fails with an error `Error: Cannot find module 'chalk'`

PR Close 
2019-04-26 11:08:05 -07:00
Keen Yee Liau
1f4c380f58 fix(bazel): Exclude common/upgrade* in metadata.tsconfig.json ()
It has a dependency on @angular/upgrade which is not part of the
dependencies in package.json, so postinstall would fail.

PR Close 
2019-04-26 11:07:34 -07:00
Ben Lesh
b9f0720c95 refactor(ivy): undeprecate inject ()
PR Close 
2019-04-26 11:06:42 -07:00
Kara Erickson
71b8b355a6 fix(ivy): remove debug utilities from ivy production builds ()
Prior to this commit, we were pulling DebugNode and DebugElement
into production builds because BrowserModule automatically pulled
in NgProbe and thus getDebugNode. In Ivy, this is not necessary
because Ivy has its own set of debug utilities. We should use these
existing tools instead of NgProbe.

This commit adds an Ivy switch so we do not pull in NgProbe utilities
when running with Ivy. This saves us ~8KB in prod builds.

PR Close 
2019-04-26 11:04:47 -07:00
Joey Perrott
f45684ff95 ci: enable github bot CI rerun feature ()
PR Close 
2019-04-26 10:45:12 -07:00
Igor Minar
5b134caf2d ci: don't sync most of /modules/** except for benchmarks ()
we don't need these files in g3 and they just create sync noise.

CL to remove this from g3 is: cl/245342562

PR Close 
2019-04-25 18:24:43 -07:00
Andrew Kushnir
fcacb2a4a2 test: update payload size limit for cli-hello-world app ()
Master is red due to a size regression that was not caught before. We are making this change to bring master back to green state and will perform further investigation.

PR Close 
2019-04-25 18:03:48 -07:00
Max Kramer
933772ed69 docs(aio): clarify "next to" as "same directory" ()
closes 
PR Close 
2019-04-25 17:20:29 -07:00
Andrew Kushnir
a03a9236f2 release: cut the v8.0.0-rc.0 release 2019-04-25 16:05:26 -07:00
Brandon Roberts
6de4cbdd41 fix(common): add upgrade sub-package to ng_package rule for @angular/common ()
Follow-up to  to include @angular/common/upgrade in the npm package

Closes 

PR Close 
2019-04-25 15:01:17 -07:00
Greg Magolan
61365a94ed fix(bazel): transitive npm deps in ng_module ()
BREAKING CHANGE:

ng_module now depends on a minimum of build_bazel_rules_nodejs 0.27.12

PR Close 
2019-04-25 14:42:02 -07:00
Adam Plumer
3a9d2473ca feat: remove deprecated DOCUMENT token from platform-browser ()
PR Close 
2019-04-25 14:40:16 -07:00
Peter Johan Salomonsen
6200732e23 feat(service-worker): support bypassing SW with specific header/query param ()
Add support for bypassing the ServiceWorker for a request by using the
ngsw-bypass header or query parameter.

Fixes 

PR Close 
2019-04-25 13:09:44 -07:00
Pete Bacon Darwin
304a12f027 feat(compiler): support skipping leading trivia in template source-maps ()
Leading trivia, such as whitespace or comments, is
confusing for developers looking at source-mapped
templates, since they expect the source-map segment
to start after the trivia.

This commit adds skipping trivial characters to the lexer;
and then implements that in the template parser.

PR Close 
2019-04-25 12:36:54 -07:00
George Kalpakas
acaf1aa530 build(docs-infra): switch from no-op no-jasmine-focus tslint rule to ban ()
The `no-jasmine-focus` rule has been removed from
`vrsource-tslint-rules` [since version 5.8.0][1] (theoretically;
practically it remained [until version 5.8.2][2]).

This commit removes the non-existent rule (and the obsolete dependency)
and uses tslint's `ban` rule instead (as recommended).

[1]: 477f622cb2 (diff-04c6e90faac2675aa89e2176d2eec7d8R162)
[2]: https://github.com/vrsource/vrsource-tslint-rules/pull/13#issuecomment-442053340

PR Close 
2019-04-25 12:32:49 -07:00
George Kalpakas
282167a37f build(docs-infra): upgrade tslint to 5.15.0 and codelyzer to 5.0.0 ()
This commit also changes the `tslint.json` config file to (reasonably
closely) match what the cli would generate for a new app.

PR Close 
2019-04-25 12:32:49 -07:00
George Kalpakas
eb85c8a742 build(docs-infra): make type-checking stricter by enabling noImplicitAny ()
PR Close 
2019-04-25 12:32:49 -07:00
George Kalpakas
2002db28ff build(docs-infra): remove obsolete ie-polyfills.js ()
Now that defferential loading it supported by the cli, remove the
obsolete `ie-polyfills.js` (and associated dependencies).

All polyfills in `ie-polyfills.js` are now included in the
[polyfills-es5][1] bundle, except for `classlist.js`, that is only
needed in order to support `NgClass` on SVG elements, which we don't
use.

[1]: https://github.com/angular/angular-cli/blob/b95933a57/packages/angular_devkit/build_angular/src/angular-cli-files/models/es5-polyfills.js

PR Close 
2019-04-25 12:32:49 -07:00
George Kalpakas
6c1ae294dc build(docs-infra): upgrade @angular/cli to 8.0.0-beta.18 ()
This commit also changes the config files and their layout to
(reasonably closely) match what the cli would generate for a new app.

Related Jira issue: [TOOL-815](https://angular-team.atlassian.net/browse/TOOL-815)

PR Close 
2019-04-25 12:32:49 -07:00
George Kalpakas
b8298f1b2d build(docs-infra): upgrade @angular/material to 8.0.0-beta.2 ()
PR Close 
2019-04-25 12:32:48 -07:00
George Kalpakas
3def652e18 build(docs-infra): upgrade @angular/* to 8.0.0-beta.14 ()
PR Close 
2019-04-25 12:32:48 -07:00
Martin Mädler
909557d5f8 feat(core): add missing ARIA attributes to html sanitizer ()
Allow ARIA attributes from the WAI-ARIA 1.1 spec which were stripped by the htmlSanitizer.

Closes 

PR Close 
2019-04-25 12:30:55 -07:00
George Kalpakas
957f594d7c test(service-worker): add tests for RegistrationOptions#registrationStrategy ()
PR Close 
2019-04-25 12:29:59 -07:00
George Kalpakas
8f120aff33 refactor(service-worker): DRY up SW registration logic ()
PR Close 
2019-04-25 12:29:58 -07:00
JiaLi.Passion
4cfba58072 feat(service-worker): allow configuring when the SW is registered ()
Fixes 

PR Close 
2019-04-25 12:29:58 -07:00
George Kalpakas
aa53d6cc6d docs(service-worker): improve SwRegistrationOptions docs and add example ()
PR Close 
2019-04-25 12:29:58 -07:00
George Kalpakas
be28a6ad8e test(service-worker): expand SwRegistrationOptions tests and move to separate file ()
PR Close 
2019-04-25 12:29:58 -07:00
deebloo
39c0152b76 feat(service-worker): expose SwRegistrationOptions token to allow runtime config ()
Previously, the ServiceWorker registration options should be defined as
an object literal (in order for them to be compatible with Ahead-of-Time
compilation), thus making it impossible to base the ServiceWorker
behavior on runtime conditions.
This commit allows specifying the registration options using a regular
provider, which means that it can take advantage of the `useFactory`
option to determine the config at runtime, while still remaining
compatible with AoT compilation.

PR Close 
2019-04-25 12:29:58 -07:00