9db05a895a
DEV: Add job_id to sidkiq log
...
This makes it easier to correlate 'pending' logs from the same job
2019-03-08 09:16:13 +00:00
2312caccdc
FEATURE: Skip small actions when counting replies in PMs. ( #7108 )
2019-03-08 10:49:34 +02:00
35942f7c7c
FEATURE: Special call-out for new / returning posters. ( #7115 )
2019-03-08 10:48:35 +02:00
65464969cd
Change searchTearm to searchTerm ( #7130 )
2019-03-08 09:24:14 +01:00
3acf8a95f3
UX: various tweaks to search-menu ( #7114 )
2019-03-08 09:23:44 +01:00
c90267db52
FIX: do not display add/remove participants if you can’t actually do it ( #7125 )
2019-03-08 09:23:26 +01:00
cd94ac9453
FIX: remove padding from onebox site icon in composer preview
2019-03-07 22:32:27 -05:00
6e26358380
REFACTOR: streamline like button styles, clarify for themeing, enable tab focus
2019-03-07 21:09:57 -05:00
f6ef4f8c3f
FEATURE: Add missing S3 regions
2019-03-07 22:42:20 +01:00
ccff1d2dbb
prettier
2019-03-07 13:30:39 -05:00
837452794b
Target active nav pill with single style
2019-03-07 13:21:42 -05:00
a2fdd4089c
FIX: nav-pills not highlighted on user preferences page ( #7126 )
2019-03-07 13:40:12 +01:00
fc7938f7e0
REFACTOR: Migrate GoogleOAuth2Authenticator to use ManagedAuthenticator ( #7120 )
...
https://meta.discourse.org/t/future-social-authentication-improvements/94691/3
2019-03-07 11:31:04 +00:00
2c8e1d3578
FEATURE: remove all expired invitations by default
2019-03-07 15:28:39 +05:30
caef0a56d1
FEATURE: create a new message via URL without specifying user or group
2019-03-07 11:30:24 +05:30
9d3c7d7b25
prettier
2019-03-06 19:52:34 -05:00
e233a69db0
Customize nav pill fix
2019-03-06 19:42:44 -05:00
7d2cc33013
prettier
2019-03-06 17:37:59 -05:00
a917a93990
fix active class, remove style
2019-03-06 17:29:19 -05:00
536952f194
adding back active nav pill
2019-03-06 17:14:02 -05:00
733deba585
FIX: Loading draft also replaces the recipients ( #7122 )
2019-03-07 08:14:55 +11:00
078c02cd24
UX: More consistent structure for active nav-pill
2019-03-06 16:10:22 -05:00
1121514799
UX: Localize date format in "new user of the month" message
2019-03-06 21:58:25 +01:00
5ba2ef4274
UX: Display error message if no time frame selected in topic status update
2019-03-07 02:17:29 +05:30
167d85c21f
FIX: post & topic destroyed hooks not triggering with tag filter
2019-03-06 22:52:54 +05:30
2db3652338
UX: Fix redeemed invite table layout
2019-03-06 11:05:45 -05:00
4000978452
FIX: Failed to save email template with pluralized subject
2019-03-06 16:51:04 +01:00
5cf63e43c6
FEATURE: Add about-after-description plugin outlet
2019-03-06 10:26:34 -05:00
df474bceee
DEV: Further sidekiq logging stability improvements
...
- Open the log file in "append" mode. This avoids issues if the file does not exist (and matches standard rails log behavior)
- Correctly parse the interval logging environment variable
2019-03-06 12:50:15 +00:00
0a9a11094d
FEATURE: Save ignored usernames in user preferences ( #7117 )
...
* FEATURE: Save ignored usernames in user preferences
2019-03-06 11:21:58 +00:00
974e756369
FIX: bugs in safari where select-kit is not expanding on iOS ( #7118 )
2019-03-06 11:29:45 +01:00
fe62de68dd
DEV: Correct sidekiq logging to avoid thread leak
2019-03-06 10:11:31 +00:00
b58eea1fcb
FEATURE: Hide ignored user's Original Post content ( #7113 )
...
* FEATURE: Hide ignored user's Original Post content
2019-03-06 09:20:45 +00:00
05ebb52ec4
FEATURE: defer flags when deleting child replies ( #7111 )
2019-03-06 14:32:25 +05:30
8d7c10f7f2
FIX: allow moderators to create categories setting broken
...
Mods require visibility to everyone group cause category dialogs need to
know about this.
If the site setting `allow moderators to create categories` will not function
without this
Note there is no security expansion of rights here, the group is technically
empty anyway and it always looks exactly the same on all discourse instances
2019-03-06 17:44:18 +11:00
86f9ace0ea
UX: Previous positioning was better for the image resizer
2019-03-05 22:10:12 -05:00
b5804c410e
UX: Add slash to mobile category page totals
2019-03-05 20:16:12 -05:00
2ea77073ae
prettier
2019-03-05 15:12:10 -05:00
84892429ed
UX: Improve layout of invite table
2019-03-05 14:50:27 -05:00
b0d93a38e8
FEATURE: Add plugin html hook to insert html before any other scripts
2019-03-05 10:41:16 -08:00
8b30ed5b7a
DEV: Serialize the job parameters in sidekiq logs
...
Otherwise this can lead to some very large data structures when processing the logs later
2019-03-05 17:44:49 +00:00
671cec4bd2
DEV: Use Discourse.getURL for creating URL
...
follow-up to ccb48bef75
2019-03-05 17:52:18 +01:00
190b19f3c2
FEATURE: Add ignored user list to the User's preference page ( #7107 )
...
* FEATURE: Add ignored user list to the User's preference page
## Why?
Part of: https://meta.discourse.org/t/ability-to-ignore-a-user/110254
We want to add list of Ignored users under or along with the muted users preferences section.
This way Users can find and update their list of ignored users.
## UI
## Open questions
Two of many options to represent a list of ignored users is that we can:
1. We can represent the ignored user list as a table with the ability to `un-ignore` but NOT to add new ignored users.
2. We can keep it functioning as the `muted user list` where you can `un-ignore` or `ignore` users.
2019-03-05 14:47:51 +00:00
f19d36cbba
REFACTOR: Change `watch` wording to `unignore` ( #7112 )
...
* REFACTOR: Change `watch` wording to `unignore`
2019-03-05 14:40:31 +00:00
ccb48bef75
UX: Make Uncategorized category less confusing
...
* Adds warnings to the "Edit Category" dialog
* Doesn't hide the "Security" tab on the "Edit Category" dialog anymore. Instead, it shows an explanation why permissions can't be changed.
* Makes the category name translatable
* Hides the category name from the edit dialog (it can be customized by overriding the translation)
* Creates a translation override if the category has been renamed in the past
2019-03-05 14:42:41 +01:00
68e4aba369
UX: Don't concatenate title on "Edit Category" dialog
2019-03-05 14:42:41 +01:00
35275c137b
PERF: Remove final N+1 from theme admin page
...
The rails bug previously mentioned only causes an issue when using `pluck`, so this controller is not affected.
Followup to a8ffc02d06
2019-03-05 12:10:53 +00:00
8963f1af30
FEATURE: Optional detailed performance logging for Sidekiq jobs ( #7091 )
...
By default, this does nothing. Two environment variables are available:
- `DISCOURSE_LOG_SIDEKIQ`
Set to `"1"` to enable logging. This will log all completed jobs to `log/rails/sidekiq.log`, along with various db/redis/network statistics. This is useful to track down poorly performing jobs.
- `DISCOURSE_LOG_SIDEKIQ_INTERVAL`
(seconds) Check running jobs periodically, and log their current duration. They will appear in the logs with `status:pending`. This is useful to track down jobs which take a long time, then crash sidekiq before completing.
2019-03-05 11:19:11 +00:00
73e4204d20
UX: Image preview resizer style
2019-03-04 21:59:58 -05:00
079b0f4bff
FIX: Remove ignore user feature from `user-card-contents` component ( #7104 )
...
Based on our discussions, we want to have the `Ignore button will ONLY be on the User’s profile page`.
2019-03-04 15:21:45 +00:00
ad5f5b931d
DEV: deprecate blank files for static modal pages
2019-03-04 15:05:33 +05:30
2e881adb6e
FIX: select-kit perf and positioning improvements ( #7093 )
2019-03-04 10:30:22 +01:00
dc4001370c
FEATURE: displays groups in menu search ( #7090 )
2019-03-04 10:30:09 +01:00
075b264338
DEV: replaces DOMNodeInserted by the better MutationObserver ( #6884 )
2019-03-04 10:28:59 +01:00
824d9402a4
FIX: pending counts were not shown on invites tab
2019-03-04 14:14:13 +05:30
fea5d4f3ec
FIX: any subcategory permissions are valid if everyone has access to parent category ( #7097 )
2019-03-04 14:49:26 +11:00
bb39a6f7d7
REFACTOR: topic-list-header-column ( #7099 )
2019-03-04 14:45:52 +11:00
01e2180548
FIX: /signup and /password-reset direct links were broken
2019-03-04 09:02:22 +05:30
9585e2dff2
change separator from | to • for editor image sizing
2019-03-03 17:55:21 -08:00
14f9e55977
FIX: Error when filtering site settings
...
Happened only when none of the logo settings had an image assigned.
2019-03-03 20:43:22 +01:00
fd9671f7fe
DEV: Minor code improvements.
2019-03-02 19:07:54 +02:00
03a70ef69c
FIX: allow underscore and dash in username search
...
_ and - are technically punctuations, but we allow them in usernames so
accept them in search
2019-03-01 15:23:45 +11:00
cdf34657f6
FEATURE: focus on composer TEXTAREA when iPad has a physical keyboard
...
This disables a bunch of hacks that bypassed "focus" on iOS (cause focus
events that involve a virtual keyboard on iOS cause browser havoc unless
a physical keyboard is attached)
Also will focus on title on new topic
2019-03-01 11:31:52 +11:00
6bc8382555
FEATURE: Use smooth scrolling for J/K keyboard shortcuts. ( #7084 )
2019-03-01 09:31:40 +11:00
be436066ff
FIX: Prevent default event and stop bubbling up when card popup is closed in mobile
2019-03-01 01:42:17 +05:30
64a3d63ddc
DEV: Rename some icons with deprecated names
2019-02-28 13:03:14 -05:00
612a0be085
FIX: don't add bottom padding for avatars in composer preview
2019-02-28 18:03:38 +01:00
e67474daf4
UX: Don't link to theme source unless it's http(s)
2019-02-28 17:01:59 +00:00
1cd64f68f1
FIX: staff/admin shouldn’t be able to create uncategorized topics ( #7077 )
2019-02-28 15:51:13 +01:00
3517103398
UX: Correct locale key for theme compatibility error
2019-02-28 14:40:33 +00:00
c02956e29c
FIX: when posts are moved to a message then small action post should not be publicly visible ( #7085 )
...
This fix is inspired from what we do in discourse-assigned plugin.
https://github.com/discourse/discourse-assign/blob/master/lib/topic_assigner.rb#L184
https://github.com/discourse/discourse-assign/blob/master/assets/javascripts/discourse-assign/initializers/extend-for-assigns.js.es6#L125-L133
2019-02-28 19:49:26 +05:30
bb5119b88f
FIX: only profile owner can see links to watched/tracked/muted topics ( #7083 )
2019-02-28 14:58:49 +01:00
883a18547e
FIX: shows invite panel on mobile from topic footer buttons ( #7080 )
2019-02-28 14:56:22 +01:00
6296554ed1
DEV: Add additional hook for theme-creator
2019-02-28 10:48:30 +00:00
0cc636f648
UX: Don't add padding bottom for emojis in composer preview
2019-02-28 15:53:21 +05:30
97c0fd0909
FIX: styling for resizable image wrapper in editor preview
2019-02-28 10:24:43 +01:00
06abecdb41
FEATURE: on iPad bluetooth keyboard use ALT-ENTER for post submit
...
Command and Control can not be properly detected via JavaScript so lean on
Alt that can be detected.
2019-02-28 16:41:31 +11:00
0b86a99c39
FEATURE: allow iPad users to specify they have a physical keyboard
...
Sadly there is no clean way of detecting a keyboard is connected to an iPad
If the keyboard is connected we want to disable all the touch related hacks
on iOS
This allows iPad users to specify they have a keyboard connected. Setting
is per device.
2019-02-28 15:59:44 +11:00
cafbb3aea7
UX: Use official Facebook logo
2019-02-27 09:52:06 -05:00
986cc8a0fb
FEATURE: Introduce Ignore user ( #7072 )
2019-02-27 14:49:07 +01:00
5c476f639c
REFACTOR: user-invited-show ( #7078 )
2019-02-27 12:59:57 +01:00
8ff3fc20a6
REFACTOR: tags-show ( #7079 )
2019-02-27 12:59:39 +01:00
7d2ea2d4dd
FEATURE: image resizing discoverability ( #6804 )
2019-02-27 11:46:16 +01:00
f68a7a16a4
FIX: Use field name to name files in theme export. ( #7009 )
2019-02-27 10:45:22 +01:00
6f427589b2
FIX: make it possible to use backup code everywhere where 2FA required ( #7010 )
2019-02-27 10:37:33 +01:00
e1d1073273
FIX: use * when apply italics in the editor instead of _ ( #7063 )
2019-02-27 10:36:14 +01:00
326d892f5e
Aadd 'secondary_emails' field in users export
...
FIX: escape_comma wasn't working in CSV exports
FIX: group_names field wasn't properly serialized
2019-02-27 10:12:20 +01:00
ef9b249cd2
UX: More consistent table header styles, removing duplicate styles
2019-02-26 21:40:17 -05:00
1d4e9b08ad
UX: Don't override unset flair color
2019-02-26 12:49:54 -05:00
59c66fd226
REFACTOR: Improve the readability of code ( #7076 )
2019-02-26 23:03:49 +05:30
fbedaea5ed
FIX: prevents double network calls and other quirks on admin emails ( #7074 )
2019-02-26 17:53:52 +01:00
75aaae5d5c
FEATURE: Allow wildcard in allowed_user_api_auth_redirects setting ( #6779 )
2019-02-26 17:03:20 +01:00
8c706b0ff7
fix tests ( #7073 )
2019-02-26 16:49:29 +01:00
2a8da03951
FIX: prevents autocomplete from going over search input ( #7075 )
2019-02-26 15:48:02 +01:00
a8ffc02d06
PERF: Reduce N+1s on theme admin page
2019-02-26 14:22:02 +00:00
d04c4bf8e7
UX: puts back share-panel as floating pane on post actions ( #7066 )
2019-02-26 14:15:25 +01:00
6ea9f5c9c5
FIX: do not update tag name on /tags/intersection
2019-02-26 16:43:39 +05:30
1cee8a86f6
fix prettier ( #7071 )
2019-02-26 11:24:02 +01:00
7ccb0b882f
FIX: ensures topic’s category allows topics tags ( #7060 )
2019-02-26 11:21:55 +01:00
a206c7f5d5
FIX: attempts to fix an error with EXTEND_PROTOTYPES ( #7067 )
2019-02-26 11:04:05 +01:00
71360436ff
FIX: users list show was loading multiple times with different params ( #7058 )
...
A first load was happening in route, which was setting properties on controller. These properties were observed on the controller and were triggering a reload of the AdminUser model.
Not only was it doing loading two times it was also sometimes resulting on the controller model refresh end to happen after route has been changed, resulting in a wrong model.
2019-02-26 10:43:24 +01:00
ed0120171c
FIX: Hide 'show associated accounts' button if moderators can't see emails
...
And minor prettier code alignments
2019-02-26 13:49:27 +05:30
c742d42031
FIX: rtl topic progress wrapper position ( #7070 )
...
* Set left/right topic-progress-wrapper CSS from text-direction
* Remove unnecessary CSS rule
2019-02-25 20:56:52 -05:00
d6875a77fb
UX: Apply new-user color to full name and username
2019-02-25 17:09:41 -05:00
34d0cc6ad5
UX: Better alignment of similar topics in composer
2019-02-25 17:04:11 -05:00
d5efe2d7ee
UX: make composer resize work on touch devices ( #7068 )
...
* UX: make composer resize work on touch devices
This also replaces a vendor dependency with a small built-in resize mechanism.
* Make blue bar's larger padding specific to touch devices
2019-02-26 08:04:14 +11:00
90c09d17b6
FIX: Heisentest - don't memoize on a class variable
...
Repeated usage of the same class will have the same memoized results
even if the data has changed.
2019-02-25 14:49:01 -05:00
dc961fecb9
FIX: Outgoing emails were not disabled after restoring backup
2019-02-25 16:07:24 +01:00
5952a6c0ad
DEV: uses find() helper instead of this.$() in js tests ( #7062 )
2019-02-25 16:04:55 +01:00
c0dd171cf1
REFACTOR: bread-crumbs ( #7064 )
2019-02-25 14:51:14 +01:00
6930706830
REFACTOR: new message route ( #7061 )
2019-02-25 14:01:00 +01:00
91e771ece6
FIX: send test email doesn't show a status
2019-02-25 17:42:58 +05:30
900e187627
DEV: removing blank files ( #7057 )
2019-02-25 09:52:44 +01:00
919839fd97
FIX: allows {{d-button}} to set a form attribute ( #7056 )
...
This attribute is used when a submit button is out of a form. It makes it explicit which form this button is submitting.
It's currently used in our login modal form.
2019-02-25 09:49:49 +01:00
2d031a1beb
UX: Improve moderator icon alignment
2019-02-22 21:29:39 -05:00
87f4ee13ef
UX: puts more emphasis on the shared url on share panel ( #7055 )
2019-02-22 23:22:11 +01:00
260398d706
FIX: Live refresh parent themes when editing child themes
2019-02-22 21:13:07 +00:00
8be7878656
FEATURE: add ability to clear previously set mobile_view with mobile_view=auto
2019-02-22 10:44:49 -08:00
8aca26cce3
FIX: allows right-click on post-date sharing link ( #7054 )
2019-02-22 15:18:05 +01:00
d1bad881ea
FEATURE: Allow moderators to change topic timestamps ( #7053 )
2019-02-22 14:33:52 +05:30
87b5003453
UX: Increase width of hamburger menu to 320px
2019-02-21 21:52:21 -05:00
f44ef82b53
UX: Better wrapping of group header elements
2019-02-21 21:42:39 -05:00
667d3a3fd6
PERF: include content-length header for CDN
...
Attempt to force NGINX to include content length when doing X-SendFile
This does not seem to be required when bypassing NGINX.
Without this header some CDNs may have issues caching
2019-02-22 11:21:07 +11:00
31d41f532e
PERF: do not include suggested topics when loading new posts
...
When a new post is triggered via message bus post stream will attempt to load
it, previously the `/topic/TOPIC_ID/posts.json` would unconditionally include
suggested topics, this caused excessive load on the server.
New pattern defaults to exclude suggested and related topics from this API
unless people explicitly ask for suggested.
2019-02-22 10:37:18 +11:00
74ed72e825
DEV: Remove `d-checkbox` component
...
Replaces the last occurrence of `d-checkbox` with a regular input element.
Includes a minor refactor of admin site text search.
2019-02-21 09:54:54 -05:00
1dee71d760
UX: Disabled lightbox expand button when loading image meta.
2019-02-21 22:30:57 +08:00
f8e498f6ad
DEV: Fix random build error
2019-02-21 14:53:29 +01:00
090acb5b11
FIX: s/isMessage/isPM ( #7048 )
...
Regression due to refactoring
2019-02-21 13:53:50 +01:00
8d779db270
FIX: allows invite modal from topic-map post-actions ( #7047 )
2019-02-21 13:48:03 +01:00
46e62c0d22
UX: Default user facing routes to `/g` instead of `/groups`. ( #7042 )
2019-02-21 13:44:25 +08:00
07b856700d
REFACTOR: remove disallowEmails option from user-selector
...
Negative option was leading to a fair amount of confusion, going forward
if we want to allow selection of emails from user selector it must be
supplied with `allowEmails=true`
This corrects a regression in 1f4ace4f
2019-02-21 16:37:26 +11:00
79841cf7dd
FEATURE: add missing autocomplete suppressions
...
Following 1f4ace4f
2019-02-21 16:37:26 +11:00
d3cd314a98
Make eslint happy.
2019-02-21 10:26:56 +08:00
58b0e945bd
UX: Lightbox support for image uploader. ( #7034 )
2019-02-21 10:13:37 +08:00
e3a23116d2
FIX: don't update gravatar if the user has no email
2019-02-20 22:34:43 +01:00
cc1f9e7be6
Fix share button in post menu
2019-02-20 16:27:59 -05:00
353eeef72a
fix prettier offense ( #7041 )
2019-02-20 22:22:38 +01:00
cafe637407
UX: List popular themes and components in admin panel ( #6997 )
...
Reorganizes theme create/upload flows into one install flow
Adds quick list of popular themes/components with one-click installation
2019-02-20 14:58:31 -05:00
4955ab1689
DEV: add replaceTagRenderer to pluginApi
2019-02-20 14:52:56 -05:00
18296b4211
FIX: more reliable native sharing ( #7039 )
2019-02-20 20:43:48 +01:00
9618300d69
s/share/nativeShare ( #7038 )
2019-02-20 20:03:30 +01:00
994a09e5e8
FIX: stricter window.navigator.share check ( #7037 )
2019-02-20 19:40:51 +01:00
2e0342dba7
UX: more spacing between social links ( #7036 )
2019-02-20 19:37:08 +01:00
28c24631b8
FIX: ensures panel's shareUrl is not erased by topic's shareUrl ( #7035 )
2019-02-20 19:33:54 +01:00
66901f67f6
UX: Moderator post wasn't completely translatable
2019-02-20 16:37:47 +01:00
04a63cfaaa
[WIP] FEATURE: merge share and invite actions together ( #7021 )
...
This commit also:
- removes [+ New Topic] behaviour from share, this feature has been duplicated in composer actions, months ago
- introduces our new experimental spacing standard for css: eg: `s(2)`
- introduces a new panel UI for modals
2019-02-20 15:42:44 +01:00
6a8007e5fb
FEATURE: Improve handling of backup storage errors
2019-02-20 15:16:49 +01:00
33269c4172
FEATURE: do no search for groups unless a term is specified
...
Do not allow `/u/search/users.json` to list any group matches unless a
specific `term` is specified in the API call.
Adding groups should always be done when an actual search term exists,
blank search is only supported for users within a topic
2019-02-20 17:28:22 +11:00
31ffa5f64e
UX: Allow users to see filename in image-uploader component. ( #7022 )
...
https://meta.discourse.org/t/downsides-of-the-new-logo-ui-in-site-settings/102247/23?u=tgxworld
2019-02-20 13:55:55 +08:00
1f4ace4f56
FEATURE: autocomplete usernames early in topic based on participation
...
Following this change when a user hits `@` and is replying to a topic they
will see usernames of people who were last seen and participated in the topic
This is somewhat experimental, we may tweak this, or make it optional.
Also, a regression in a423a938
2019-02-20 13:34:43 +11:00
918a0ea3a4
FIX: use autocomplete="discourse" to disable Chrome address autofill
...
https://stackoverflow.com/a/47822599/17174
Chrome 63 and up start ignoring `autofill="off"`
Per: https://bugs.chromium.org/p/chromium/issues/detail?id=468153#c164
> The tricky part here is that somewhere along the journey of the web autocomplete=off become a default for many form fields, without any real thought being given as to whether or not that was good for users. This doesn't mean there aren't very valid cases where you don't want the browser autofilling data (e.g. on CRM systems), but by and large, we see those as the minority cases. And as a result, we started ignoring autocomplete=off for Chrome Autofill data
So to work around this decision we now explicitly say: autocomplete="discourse"
when we don't want Chrome to randomly fill in addressed (aka. always)
2019-02-20 10:15:59 +11:00
246997dbd9
FIX: an `<a>` with a target of _blank wants a new window
2019-02-19 14:44:30 -08:00
49e7073438
FIX: Hide advanced theme fields behind a flag, pending UI improvement
2019-02-19 22:25:00 +00:00
d08939ab05
FIX: Should be possible to save an empty theme_field in the editor
...
Removing the theme_field JS object when the value was empty caused the server to maintain the previous value, making it impossible to delete the content of a field.
2019-02-19 21:49:31 +00:00
5d75bd4831
FIX: Don't try to rename group when username is taken
...
FIX: Always rename groups with the default locale instead of using the user's locale
2019-02-19 22:31:03 +01:00
dbcf05d62c
DEV: Code style improvements following review
...
Followup to 05ee1d1aba
2019-02-19 20:02:29 +00:00
7878e5007a
FIX: Refactor to prevent themes affecting core stylesheets ( #7029 )
...
If a theme setting contained invalid SCSS, it would cause an error 500 on the site, with no way to recover. This commit stops loading theme settings in the core stylesheets, and instead only loads the color scheme variables. This change also makes `common/foundation/variables.scss` available to themes without an explicit import.
2019-02-19 15:55:59 +00:00
9ade04b709
FIX: removes legacy browsers-refresh button ( #7028 )
2019-02-19 16:38:21 +01:00
84c56e16f9
REFACTOR: Use keyword argument for fallback_to_english flag
2019-02-19 15:28:47 +01:00
05ee1d1aba
FEATURE: Added settings/translations support to theme editor UI ( #7026 )
...
- These advanced fields are hidden behind an 'advanced' button, so will not affect normal use
- The editor has been refactored into a component, and styling cleaned up so menu items do not overlap on small screens
- Styling has been added to indicate which fields are in use for a theme
- Icons have been added to identify which fields have errors
2019-02-19 12:56:01 +00:00
0616837a5d
UX: moves wizard's "Finish" button to the left of back and next ( #7027 )
...
This was done to avoid clicking finish when clicking fast on next.
2019-02-19 13:32:01 +01:00
8a4cd15e46
REFACTOR: topic model ( #7020 )
2019-02-19 10:13:46 +01:00
15fd875855
REFACTOR: color-scheme-color model ( #7019 )
2019-02-19 09:31:26 +01:00
cba0dd33ee
REFACTOR: admin-customize-color ( #7018 )
2019-02-19 09:31:11 +01:00
2c6bf184bc
REFACTOR: admin-badge-preview ( #7017 )
2019-02-19 09:30:52 +01:00
3bf61fca66
REFACTOR: admin-user-field-item ( #7016 )
2019-02-19 09:30:38 +01:00
ee692414ce
REFACTORING: admin-edit-badge-groupings ( #7015 )
2019-02-19 09:30:24 +01:00
27e7f2bee0
DEV: call 'enqueue_hooks' method only if active webhooks exist
2019-02-19 12:43:08 +05:30
f2c3415548
FIX: Should not generate payload until active webhooks are exist
2019-02-19 12:23:42 +05:30
4f5aebc338
UX: reduce subcategory badge spacing
2019-02-18 19:04:36 -05:00
50f833def0
fix the build
...
JsPrettier on Sublime was failing because: https://github.com/jonlabelle/SublimeJsPrettier/issues/157#issuecomment-458175837
2019-02-18 11:52:11 +05:30
dc2776bcdd
FIX: do not show "move to new PM" option to moderators
2019-02-18 11:35:00 +05:30
052eaed16a
lighten embed blockquote style for consistency
2019-02-17 21:00:46 -08:00
dfba36fdca
remove bgcolor from embed quotes for consistency
2019-02-17 20:57:27 -08:00
7da7a30e02
PERF: Restore `exists?` in favor of `blank?`.
...
Regression from dcd7b92532
2019-02-18 10:04:21 +08:00
f04471e422
REFACTOR: Proxy letter avatars in rails instead of nginx
...
Co-authored-by: Sam Saffron <sam.saffron@gmail.com>
Co-authored-by: David Taylor <david@taylorhq.com>
This gives more control over the request. In particular we can easily
lookup DNS dynamically, instead of only upon NGINX startup.
Previously, NGINX was looking up IP for the letter avatar service and
caching the CDN IP address, this caused issues if CDN changed IP, in
which letter avatars would be broken till a container restarted.
NGINX config has been updated to add caching. This change will require
a container rebuild.
The proxy will now function in development environments, so the patch
for `letter_avatar_proxy` has been removed.
2019-02-18 08:46:56 +11:00
b0862bd15d
FIX: Push notifications could fail with UnauthorizedRegistration
...
The webpush gem by default sets the expiration date of the JWT token to exactly 24 hours in the future. That's not really needed because the token isn't reused. And it might cause UnauthorizedRegistration if the server's clock isn't 100% correct, because the maximum allowed value is 24 hours.
2019-02-15 21:12:09 +01:00
17f1a76570
FIX: Delete push subscription on MismatchSenderId error
...
This should prevent repeated MismatchSenderId warnings when the VAPID keys have changed.
2019-02-15 21:12:09 +01:00
159dd69fcb
UX: make adding permissions more visible and intuitive to click. ( #6999 )
2019-02-15 12:01:10 -05:00
99c6db21e6
FEATURE: allow blocking emojis ( #7011 )
...
https://meta.discourse.org/t/blocking-emojis-wont-work/105853
2019-02-15 20:55:48 +05:30
a423a9383f
FIX: Stop autocomplete for invalid usernames. ( #7005 )
2019-02-15 11:29:26 +11:00
f8b70f4ca3
FIX: unable to create new categories
...
Previous attempt at 70adb940
2019-02-15 10:24:29 +11:00
3d11064a33
UX: Reduce font size on about pages
2019-02-14 11:01:17 -05:00
70adb94008
SECURITY: Do not leak private group names. ( #7008 )
2019-02-14 15:35:58 +01:00
fc14847c14
PERF: only require aws-sdk-sns gem when it's being used
2019-02-14 11:08:21 +01:00
ebd4140492
FIX: logspam due to 404s on CSS files
...
We had a missing formats: string on our render partial that caused logs to
spam when CSS files got 404s.
Due to magic discourse_public_exceptions.rb was actually returning the
correct 404 cause it switched format when rendering the error.
2019-02-14 17:58:16 +11:00
39522659a6
FIX: validate parent category/subcategories permissions
...
See: https://meta.discourse.org/t/subcategories-do-not-inherit-permissions-from-parent-category/17174/23 for more details
This ensures users with access to child category can always at least see parent
2019-02-14 16:38:52 +11:00
090e9c8432
FIX: make composer full screen shortcut work when inputs have focus ( #6907 )
...
- Uses a Mousetrap plugin for global shortcuts
- Implemented for search `ctrl+alt+f` and composer fullscreen `shift+f11` shortcuts
2019-02-14 00:19:27 -05:00
ed6f4dfc40
FEATURE: trigger user profile create and update event ( #6958 )
...
Adds `user_profile_created` DiscourseEvent on profile creation and `user_profile_updated` on profile update
2019-02-14 15:45:12 +11:00
b651605d6e
FIX: tags added while editing a pending approval topic do not show up ( #6959 )
2019-02-14 15:42:40 +11:00
37666c3d18
UX: Signup form labels were too constrained, minor cleanup
2019-02-13 21:07:34 -05:00
484bd82278
FIX: Add onceoff job to remove double quotes from s3 etags
2019-02-14 05:19:41 +05:30
0476169692
make prettier happy
2019-02-13 22:16:38 +01:00
94fe0af900
FIX: upload emojis sequentially to prevent rate limit
2019-02-13 22:07:37 +01:00
4d674acc25
FEATURE: AWS SNS bounce notifications webhooks
2019-02-13 21:26:40 +01:00
560cc4e73e
FIX: sets categoryId but do not scope when replying as new topic ( #7002 )
2019-02-13 15:19:58 +01:00
fe4254b8f3
FIX: reverse consolidated pageviews stacked chart order ( #7001 )
2019-02-13 12:24:18 +01:00
641b079c78
FIX: add support for missing verbs in user api key
...
Previously "write" scope was missing put and delete verbs which should be
allowed.
Also closes : #6982
2019-02-13 15:49:43 +11:00
1328a127ee
FIX: translate bootbox confirmation dialog ( #6981 )
2019-02-13 14:04:56 +11:00
467cfc9e08
FIX: remove extra periods ( #6998 )
...
Periods are belong in the translation files not in our templates, if we have them in the templates sentences can not be localized properly.
2019-02-13 12:54:34 +11:00
47fe34d794
FEATURE: makes create-account userfields using dropdowns accessible ( #6991 )
2019-02-13 12:52:55 +11:00
3da35081e5
UX: Embedded post collapse button hover color fix
2019-02-12 17:21:33 -05:00
c23411cc69
FIX: Heisentest - suspicious logins report was not ordered by date
...
The specs needed an order even though none was supplied.
2019-02-12 13:17:29 -05:00
86fe423f5e
FIX: Clear the cache after destroying theme_fields
2019-02-12 16:39:40 +00:00
91f0468f4e
FIX: Allow unbaked theme fields to be destroyed
...
The after_commit hook was attempting to re-bake theme_fields after they were destroyed, which caused an exception to be thrown
2019-02-12 16:14:43 +00:00
59640ef373
DEV: Add additional hooks for theme-creator plugin
2019-02-12 14:17:34 +00:00
b8b1759de9
UX: show envelope when tag is only used in PM
...
UX: use regular envelope instead of solid envelope
REFACTOR: %s/enveloppe/envelope/g
2019-02-12 11:34:25 +01:00
90ce448675
PERF: Cache build_not_found_page
2019-02-12 21:20:33 +11:00
d997b01a24
FIX: Scale down swipe in detection to 20px from edge of the screen
...
...and slightly increase velocity required for menu actions
2019-02-11 21:22:50 -08:00
c3cbff55be
FIX: only respond to menu open swipes on Andorid
2019-02-11 20:56:25 -08:00
e0c16d3a8a
minor refactoring to improve code readability
2019-02-11 17:24:02 +05:30
dcd7b92532
FIX: some posters were not getting added to topic_allowed_users when moving posts to a new PM
...
If a user posted twice in a topic then subsequent posters were not getting added as topic_allowed_users.
2019-02-11 17:05:21 +05:30
2c12336c6b
FIX: Display post updated date in non-JS view for crawler
2019-02-11 16:48:22 +05:30
c50db76f5d
FIX: do not treat TIFF, BMP, WEBP as images
...
Treating TIFF and BMP as images cause us to add them to IMG tags, this is very inconsistent across browsers.
You can still upload these files they will simply not be displayed in IMG tags.
2019-02-11 16:28:43 +11:00
c719658f9f
`human?` helper method on a user
...
This is cleaner than hard coding `id > 0` in ruby code.
2019-02-08 13:34:54 -05:00
60fa4fe692
DEV: Make interface route/controller more resilient to missing values
2019-02-08 16:54:15 +00:00
0d1fa54957
compensate for border overhang in category list alignment
2019-02-08 11:49:06 -05:00
72b5ab0454
Don't wrap exceptions in test mode unless specifically requested.
...
This helps debugging reports with invalid SQL, which would otherwise
return no results instead of a useful error message while running
tests.
2019-02-08 11:26:26 -05:00
7c55de6e6f
UX: Alignment fix for names with emoji
2019-02-08 11:07:04 -05:00
747fea8458
DEV: Remove unused import
2019-02-08 16:05:39 +00:00
95eb4c67f2
FIX: Allow reverting theme/text settings from cookie back to default
2019-02-08 15:39:44 +00:00
62043e6904
UX: Hide branch/private repo options in admin theme import modal
2019-02-08 10:17:29 -05:00
7aecd3c2f5
Update app/services/user_silencer.rb
...
Co-Authored-By: eviltrout <robin.ward@gmail.com>
2019-02-08 08:50:50 -05:00
bc3efab816
FIX: When disagreeing with a flag that silenced a user, unsilence them
...
Previously it would unhide their post but leave them silenced.
This fix also cleans up some of the helper classes to make it easier
to pass extra data to the silencing code (for example, a link to the
post that caused the user to be silenced.)
This patch also refactors the auto_silence specs to avoid using
stubs.
2019-02-08 08:50:50 -05:00
44d9bc12c9
FEATURE: color-palettes component ( #6992 )
2019-02-08 14:01:14 +01:00
babd80dfd1
FIX: Allow subexpressions in raw handlebars helpers
...
Helpers registered via `registerUnbound` did not receive parameters if they were subexpressions.
For example: `{{helper1 key=(helper2 value)}}`
2019-02-08 12:58:10 +00:00
95b5c5898e
FIX: Prevent duplicate params for raw template theme handlebars helpers
2019-02-08 12:54:00 +00:00
e3324737ee
FIX: position invite footer button before archive ( #6990 )
2019-02-08 12:21:51 +01:00
e9ec5238fc
DEV: Remove ignored columns
2019-02-08 12:12:38 +01:00
8a152566e3
FIX: improves positioning of footer buttons on mobile ( #6989 )
2019-02-08 12:09:56 +01:00
e54612c914
fix tests ( #6987 )
2019-02-08 11:38:15 +01:00
f849169619
UX: Modifications to admin/customize layout
2019-02-07 22:27:35 -05:00
cbedb6a1ac
FEATURE: Hidden site setting to always include topic excerpt
2019-02-07 22:45:21 +01:00
2a007bafa2
FEAT: Allow image resize by width or height
...
`|150x` resizes to 150px wide + auto-height. `x150` resizes to 150px tall and auto-width.
Resize value can be from 1 to 999 (incl. for percentages).
2019-02-07 15:04:39 -05:00
c0ccf21970
FIX: hides topic-footer-mobile-dropdown when no content ( #6985 )
2019-02-07 18:37:20 +01:00
6c195640b9
FEATURE: adds an API to register topic footer buttons
2019-02-07 14:43:33 +01:00
92c52c0724
FEATURE: displays report description when hovering activity metrics ( #6983 )
2019-02-07 13:33:05 +01:00
1cacfddda4
Prevent usercard badge section from overflowing
2019-02-06 22:39:10 -05:00
984f1d96b0
Add max-width so long badges don't force short badges to truncate
2019-02-06 20:51:54 -05:00
94f8c4ecac
UX: Truncate (don't wrap) badges in user cards if the text is long
2019-02-06 20:18:12 -05:00
fc4c015bee
FEATURE: Shortcut 'g s' goes to first suggested topic
2019-02-07 08:43:07 +11:00
56a9f777cb
UX: Turn off autocomplete on composer title
2019-02-06 14:37:29 -05:00
ab2c2ea605
FIX: validate Invite email against `EmailValidator.email_regex` ( #6975 )
2019-02-06 22:38:06 +05:30
ca03b2ff30
Move SCSS variables for topic post width
...
This allows them to be re-used by other components, for example the
upcoming review queue.
2019-02-06 11:37:59 -05:00
057d1dc077
UX: disable browser's autocomplete in search menu
2019-02-06 17:06:23 +01:00
f3cfce4a93
FEATURE: Calculate sprite-sheet based on currently active themes ( #6973 )
...
Previously there was only one sprite sheet, which always included icons from all themes even if they were disabled
2019-02-06 15:51:23 +00:00
381793243e
FIX: include error message if the "accept invite" process fails
2019-02-06 19:20:25 +05:30
1a72242746
line-height adjustment
2019-02-05 21:44:06 -05:00
a52b2c9625
UX: Moving the create theme buttons, adding buttons to theme index
2019-02-05 21:40:17 -05:00
e7821a63e7
FIX: Users should able check the emails for self
2019-02-05 23:31:19 +05:30
ba724d7f25
FIX: S3 endpoint broke bucket creation in non-default region
2019-02-05 18:17:02 +01:00
a3b47c1dd1
FEATURE: Allow string theme settings to display with multiple lines
...
To use, add `textarea: true` to the theme settings.yml. For example:
```
my_setting:
default: "some string"
textarea: true
```
2019-02-05 14:14:53 +00:00
7b7bc3db39
FIX: Rescue and display import errors when updating theme via git
2019-02-05 13:49:16 +00:00
31ffcf989c
UX: Use translatedLabel for aria-label in buttons.
2019-02-05 13:11:07 +02:00
2c222e16fe
FEATURE: Returning falsy value from upload handler stops upload. ( #6969 )
2019-02-05 10:54:11 +01:00
b6e3ef4a90
Minor icon color fix
2019-02-04 22:14:18 -05:00
58d5fc3632
UX: Minor button icon color fixes
2019-02-04 12:46:12 -05:00
9de906ddab
FIX: Register pan events for touch only
...
* touch events - only register touch, not pointer events
* immediately request redraw frame, do not wait for after render to fire.
2019-02-04 08:27:40 -08:00
e0e91fad87
FIX: Fix delete button for Tag Groups. ( #6965 )
2019-02-04 12:46:39 +01:00
2a2be093ca
UX: checkboxes were too close to other inputs
2019-02-01 21:07:57 -05:00
e75b240390
FIX: Some brittle tests with hardcoded ids
...
If we're going to use hardcoded ids, we should make sure the records are
not saved, or that the ID will not come up during normal use.
2019-02-01 11:44:37 -05:00
37c28cf0b7
UX: Header icon color fix
2019-02-01 09:51:12 -05:00
eb617dea4b
DEV: Run prettier on `report.js.es6`
...
The prettier version I was running was different to the CI pipeline
2019-02-01 13:22:31 +00:00
5c9426be48
SECURITY: Escape HTML in dashboard report tables
2019-02-01 13:10:59 +00:00
925606f8b1
FIX: Login button icons should be white
2019-02-01 11:01:59 +00:00
b4f713ca52
FEATURE: Use amazon s3 inventory to manage upload stats ( #6867 )
2019-02-01 10:10:48 +05:30
bbaa3e9166
Header icon focus color fix
2019-01-31 19:31:09 -05:00
95e16ab0a6
UX: Badge checkmarks should be round
2019-01-31 15:27:46 -05:00
6141290399
FIX: Mobile button colors
2019-01-31 15:13:54 -05:00
ec7f418a22
REFACTOR: Simplify finding the opengraph image
...
* removes deprecation warnings for "logo url"
* adds the "large icon" as fallback before the "apple touch icon"
2019-01-31 20:46:15 +01:00
3500acf2f6
FIX: refresh admin/customize/themes route after import
...
Fixes an issue where the imported color schemes of a theme were not available immediately in the UI.
2019-01-31 14:29:09 -05:00
0dfcbdeb54
ok/cancel button fix
2019-01-31 14:20:27 -05:00
3d394a6144
prettier
2019-01-31 14:06:32 -05:00
3eb000a968
UX: Overflow hidden was causing some icons to be cropped
2019-01-31 14:03:11 -05:00
94f16ba931
UX: Make button icons use lighter color instead of opacity
2019-01-31 13:59:49 -05:00
43f3bf71ba
FIX: Imported themes should set their color scheme automatically
2019-01-31 17:45:11 +00:00
1021a42b22
FIX: new mailgun webhooks
2019-01-31 17:52:33 +01:00
4786b7ff81
FEATURE: when only option is "existing topic", autofocus input field
2019-01-31 11:23:04 +05:30
f83533e1cb
FIX: use absolute url for `/images/example.png` links
...
FEATURE: fallback to logo_url as last resort for opengraph image url
2019-01-31 10:20:15 +05:30
4763d6c9d7
FEATURE: add the show user action to the user-card-after-username plugin outlet
2019-01-30 14:56:14 -08:00
bb8808985a
REFACTOR: Remove a couple more `self` uses
2019-01-30 14:41:49 -05:00
dca5486b78
REFACTOR: Prefer `this` over `self`
2019-01-30 14:29:45 -05:00
c02e81fe01
FIX: regression with composer warnings
...
Fixes composer warnings when: a) mentioning groups ("By mentioning @group, you are about to notify x people...") and b) mentioning users in a PM ("You mentioned @user but they won`t be notified...")
2019-01-30 11:37:16 -05:00
d8bd3c32ca
DEV: Allow theme CLI to specify which theme to synchronize ( #6963 )
...
Currently the theme is matched by name, which can be fragile when there are many themes with the same name. This functionality will be used by the next version of theme CLI.
2019-01-30 14:17:04 +00:00
1e98929501
FIX: Email domain whitelist prevented user anonymizing
...
FIX: Secondary email addresses were not deleted during anonymizing
2019-01-30 15:14:36 +01:00
096974d178
FIX: user_id attribute not found in posters array
2019-01-30 15:28:03 +05:30
60c1cd9f81
FIX: Return 400 when username params is invalid.
2019-01-30 16:06:55 +08:00
0e5c7f5da7
DEV: Update annotations.
2019-01-30 09:34:51 +08:00
ac004297fa
PERF: Add index on `user_id` to `single_sign_on_records`.
2019-01-30 09:34:19 +08:00
fc5b2de85d
FEATURE: add topic list before status plugin outlet for mobile
2019-01-29 17:15:31 -08:00
6f656f6e7d
FIX: Better error handling if a file cannot be sent
...
If for some reason `Discourse.store.path_for` returns `nil`, the
forum would throw an error rather than returning 404.
Why would it be `nil`? One cause could be changing the type of
file store and having the `url` field no longer be relative.
2019-01-29 16:47:25 -05:00
0d0303e7ea
FIX: more resilient lookup in plugin-api ( #6961 )
...
Ember3 is more picky about having a container being destroyed and it's easier to cause exceptions, especially in tests.
This fix has been initially created for an exception occuring in tests when running discourse-code-review and discourse-polls tests at the same time. `getCurrentUser` method body was failing as the container was destroyed.
Original stacktrace:
```
"Error: Assertion Failed: expected container not to be destroyed
at new EmberError (ember:2929:31)
at assert (ember:1793:23)
at Container.lookup (ember:17736:64)
at PluginApi.getCurrentUser (discourse/lib/plugin-api:56:31)
at allowUser (javascripts/discourse/initializers/init-code-review:38:29)
at eval (javascripts/discourse/initializers/init-code-review:78:11)
at eval (select-kit/mixins/plugin-api:86:19)
at Array.forEach (<anonymous>)
at eval (select-kit/mixins/plugin-api:85:44)
at Array.forEach (<anonymous>)"
```
2019-01-29 16:54:04 +01:00
32f9fd1e51
FIX: add autocomplete=off to composer textarea
...
Somehow a plugin or some new Chrome bug is causing its heuristic to detect
our textarea for the composer as a target for address autocomplete
This is likely a chrome bug but this change is very safe regardless.
2019-01-29 15:05:29 +02:00
f7deb52c90
FIX: Class name for external-link on customize page
2019-01-28 17:15:36 -05:00
62a0f88e97
FIX: More link in topic page search shouldn't navigate to full page result
2019-01-29 02:26:55 +05:30
3d52f690b3
UX: Add post action text in non-JS topic view
2019-01-28 22:51:06 +05:30
fb5c94246c
DEV: Remove underscore from `learn_more` key in theme export
...
Follow up from 033cd4f3
2019-01-28 16:00:33 +00:00
0d0ca4f070
DEV: Automatically remove placeholder 'URL' metadata values from themes
2019-01-28 11:55:58 +00:00
77d26b9df6
FIX: Support application/gzip theme imports, and improve error message
2019-01-28 11:51:14 +00:00
033cd4f31d
DEV: Include "_learn_more" key in theme `about.json`
...
This does not serve any technical purpose. It is there to provide a signpost for any user/developer that wants to know what to do with a theme archive.
2019-01-28 11:34:11 +00:00
aca0b32fda
FEATURE: Allow overriding text size from a different device ( #6955 )
...
This brings the feature in line with the theme selection system
2019-01-28 11:19:50 +00:00
7e4edcfae8
FIX: Convert lightbox html into proper image markdown
2019-01-27 01:21:56 +05:30
cd3a167c63
FIX: javascript error when opening rename tag modal
2019-01-25 17:34:05 -05:00
94e2b77c5f
Fix theme component name's color when theme is selected
2019-01-25 17:25:12 -05:00
84a3da4b18
FIX: match drafts using key when deleting
...
Using "sequence" when removing drafts was buggy, it would remove more than one draft from the stream sometimes.
2019-01-25 13:55:40 -05:00
0e1862013a
FIX: prevents race condition where the same report is loaded multiple times ( #6953 )
2019-01-25 19:29:45 +01:00
2e48c43546
FIX: Fix safe mode regression
...
Follow up from a48731e
2019-01-25 17:00:30 +00:00
78ddc82952
FIX: Respect min_flags_staff_visibility for new flags too
...
There was a situation where if:
* There were new flags to review that met the visibility threshold
AND
* There were old flags that *didn't* meet the threshold
THEN
a pending flags notification would be sent out. This fixes that case.
Staff should not be notified of flags if they do not meet the threshold
and are old.
2019-01-25 11:27:43 -05:00
7caa28cf45
FIX: ensures ordering set in tags-show queryString works at first load ( #6951 )
2019-01-25 16:48:20 +01:00
d338e54f59
FEATURE: Allow setting font size per-device using a cookie ( #6947 )
2019-01-25 15:06:06 +00:00
65caf04ddc
clean up unused code
...
Unused PM topic list column 'Users' is removed
2019-01-25 20:13:54 +05:30
a48731e359
FEATURE: Support additional metadata in theme about.json ( #6944 )
...
New `about.json` fields (all optional):
- `authors`: An arbitrary string describing the theme authors
- `theme_version`: An arbitrary string describing the theme version
- `minimum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.
- `maximum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.
A localized description for a theme can be provided in the language files under the `theme_metadata.description` key
The admin UI has been re-arranged to display this new information, and give more prominence to the remote theme options.
2019-01-25 14:19:01 +00:00
2d6aa2aea2
FEATURE: Add recipient avatars in PM topic list even if they not yet replied
2019-01-25 19:41:49 +05:30
f461a9971f
FIX: makes staff_logins show only admins ( #6948 )
2019-01-25 11:28:52 +01:00
de47b35b2d
FIX: user_id handling on remove user from group
...
Under some conditions it was possible to pass in a user_id as an
integer, but we would try and parse it as a comma delimited string
resulting in an error. This has been fixed so that we are no longer
mapping the user_id param to user_ids.
2019-01-24 17:40:48 -07:00
868528f862
Slight shadow adjustment to hide overflow
2019-01-24 14:49:39 -05:00
96b2585a91
REFACTOR: Remove unncessary stubs from pending flags reminder
...
They seem to be calculated fine by the application, and stubbing
makes the tests more brittle and prone to regression.
2019-01-24 13:45:58 -05:00
a518950e52
FIX: Use context sensitive "create topic" via keyboard if possible
2019-01-24 13:20:33 -05:00
8e795d82f9
UX: Bump up notification panel width to accommodate larger text
2019-01-24 12:48:48 -05:00
755b47b4bc
UX: change topic reminder notification icon
2019-01-24 10:07:24 -05:00
e5765fe1f5
FIX: ensures correct scroll position of textarea after autocomplete ( #6942 )
2019-01-24 15:19:19 +01:00
49193ca3bf
FIX: includes staff in staff_logins report ( #6945 )
2019-01-24 14:46:56 +01:00
c88fd49591
DEV: refactor user preferences path method
2019-01-24 18:39:13 +05:30
b9bf751b88
FIX: link to the user preferences page is incorrect in user admin page
2019-01-24 18:31:00 +05:30
dda918f862
UX: removes width constraint in user-card badge section
2019-01-24 20:53:14 +08:00
b1297a5f5a
FIX: replaces inline button message with d-button
2019-01-24 13:19:52 +01:00
1f8ff85ff9
FIX: displays user-card when clicking on avatar of post small action ( #6941 )
2019-01-24 10:46:06 +01:00
22f43abb0e
UX: protection for very wide category-logo images on narrow screens
2019-01-24 17:16:18 +08:00
12df8c5c82
General style cleanup, removing unused styles
2019-01-23 21:37:39 -05:00
7d92fa3a5e
Mobile SCSS cleanup and removing unused styles
2019-01-23 14:36:53 -05:00
48c9234545
FIX: Lazy Loading: copy only present srcset
...
When showing a lazy-loaded image, copy the `srcset` property only when
it is actually set. `copyImg.srcset = copyImg.srcset` is not actually a
noop but creates an empty `srcset`, changing content security rules on
the image.
2019-01-23 14:04:43 -05:00
a9734eef81
UX: removes margins from categories in suggested topics message
2019-01-24 02:12:16 +08:00
bd31423137
DEV: refactoring admin-logs-screened-ip-addresses ( #6932 )
2019-01-23 17:40:37 +01:00
0aa049791e
DEV: refactoring admin-backups-index ( #6933 )
2019-01-23 17:40:24 +01:00
60974932c4
DEV: refactoring api-keys ( #6931 )
2019-01-23 17:40:05 +01:00
9a594fed01
Removing unused bootstrap.scss file
2019-01-23 11:22:23 -05:00
5feeac221e
Groups on user profile missing margin
2019-01-23 10:10:17 -05:00
096a81158a
FIX: siteNavigationElement was reversed ( #6934 )
2019-01-23 15:47:39 +01:00
afd449089f
FEATURE: Import and export themes in a .tar.gz format ( #6916 )
2019-01-23 14:40:21 +00:00
d0129b85f4
FIX: stop propagating keyboard event when replying to topic/post ( #6930 )
2019-01-23 14:38:20 +01:00
d720215183
UX: admin badge page improvements
2019-01-23 11:29:51 +01:00
2e59a37687
FEATURE: List unused theme components ( #6924 )
2019-01-23 09:20:13 +00:00
b21266ed6f
FIX: corrects selector for move-to modal styles
2019-01-23 16:18:38 +08:00
70b56c8332
FIX: 'anon' css class is missing for anonymous users
2019-01-23 10:13:36 +05:30
9886934ef5
DEV: fix some deprecated SVG icon refs
2019-01-22 14:42:00 -05:00
62adc2eb98
User admin page button height fix
2019-01-22 14:00:38 -05:00
66f6382090
FIX: Icon missing due to typo
2019-01-22 13:01:21 -05:00
f0fd875918
UX: Improving aligment within topic timer modal
2019-01-22 12:33:46 -05:00
a834245683
FIX: Keep tags when switching to shared draft
2019-01-22 11:26:52 -05:00
f32de88dfc
FIX: Don't notify of pending flags if min_flags_staff_visibility not met
2019-01-22 11:01:18 -05:00
fc710de3ab
DEV: refactoring admin user index ( #6927 )
2019-01-22 16:44:55 +01:00
31a700daf8
DEV: refactoring emoji-uploader ( #6926 )
2019-01-22 16:44:40 +01:00
bce9c37f15
DEV: refactoring permalink-form ( #6925 )
2019-01-22 15:09:21 +01:00
ea8373351b
DEV: refactoring ip-lookup ( #6923 )
2019-01-22 15:09:04 +01:00
80d42b4ea2
icons deprecations fixes ( #6920 )
2019-01-22 12:02:02 +01:00
ea0e188c8f
FIX: improves stacked-chart layout on ie11 ( #6922 )
2019-01-22 11:47:54 +01:00
9148f7675b
FIX: better handling of resizing in stacked charts ( #6921 )
2019-01-22 11:20:50 +01:00
7161304842
minor cosmetic improvements to charts ( #6919 )
2019-01-22 10:22:41 +01:00
b1b27d9f7b
FEATURE: add total on stacked-chart tooltip ( #6917 )
2019-01-22 09:57:34 +01:00
3359b3baca
FEATURE: Do not autoclose topics due to user flagging that are authored by staff
2019-01-21 15:50:53 -08:00
fe6d571021
FIX: Alignment for small-actions, gap, removing unneeded clearfix
2019-01-21 17:57:47 -05:00
4ddc28f194
FIX: Whitespace breaks activity column in Firefox
2019-01-21 16:26:34 -05:00
d82628987a
FIX: Badges appeared in wrong badge group
...
Some badges always appeared in the "Other" group (the default group) and some badges were always moved back into the original group during seeding.
Now badges are either in the correct, seeded group or stay in a custom group if the admin moved the badge into a custom group.
2019-01-21 21:09:33 +01:00
8546f0020e
UX: Invert pikaday png for dark themes
2019-01-21 13:47:46 -05:00
ba5e17a7a9
FIX: IE11 layout glitches
...
IE11 requires a unit on the third parameter (flex-basis) of the flex property
2019-01-21 13:40:55 -05:00
ec71091216
FIX: Don't override user flair styles in topic map
2019-01-21 12:37:49 -05:00
916219f48e
Remove "Users" heading in wizard homepage preview
2019-01-21 11:31:00 -05:00
3e1e9fce7e
FIX: better legend labels for stacked-charts ( #6914 )
2019-01-21 17:10:10 +01:00
a9edcb2e10
fixes few icons deprecations warnings ( #6915 )
2019-01-21 16:56:05 +01:00
b95165b838
FEATURE: adds a new chart report to track pageviews ( #6913 )
2019-01-21 15:17:04 +01:00
52f2e0d6b9
SECURITY: fix possible XSS with badges ( #6912 )
2019-01-21 13:08:26 +01:00
2d354ec9b0
FIX: `ForumsController` doesn't need to inherit from `ApplicationController`.
...
Application controller has a whole bunch of before/after actions which
we have no need for.
2019-01-21 14:37:04 +08:00
502b1316d0
DEV: s/this._super()/this._super(...arguments) ( #6908 )
2019-01-19 10:05:51 +01:00
61fff098ed
minor email/whisper icon alignment fix
2019-01-18 20:59:52 -05:00
3b7ac3f6eb
UX: We don't have bulk select on mobile, so we should hide the button
2019-01-18 20:26:58 -05:00
df0303c912
UX: Improve button alignment, fix invite header
2019-01-18 20:08:52 -05:00
e6e4a073a5
alignment fix due to font-size bump
2019-01-18 16:24:27 -05:00
4f897dde50
UX: Improve alignment of new post badge on mobile
2019-01-18 16:17:24 -05:00
247ab4a830
Align notification in unread education message
2019-01-18 15:40:07 -05:00
59028035df
FIX: Update about/license URLs when updating theme from remote source
2019-01-18 17:46:57 +00:00
95f9a369a5
FIX: ensures visits reports are correcttly differencing mobile/all ( #6905 )
2019-01-18 17:24:18 +01:00
7908a522a0
FIX: postLabel was not working for totals ( #6904 )
2019-01-18 17:06:43 +01:00
b1b8c37e62
FIX: Correctly import theme assets with spaces in filename
...
This issue is caused by the filename restrictions in `OptimizedImage#ensure_safe_paths!`. Difficult to add a test for this because image optimization is bypassed in test mode.
2019-01-18 15:20:11 +00:00
45f66826ee
PERF: delete potentially large associated tables before user_destroyer.destroy transaction
2019-01-18 16:10:03 +01:00
f8f281cdad
UI: update "latest" canvas layout in wizard
2019-01-18 09:56:39 -05:00
457e6c7b37
FIX: Mods weren't able to see emails in admin user list
2019-01-18 15:37:30 +01:00
f40c97c367
Remove support for `theme_var` and `theme_color_var` fields
...
These are remnants of the old 'customization' system, and have been superseded by theme settings
2019-01-18 12:04:23 +00:00
197e3fd722
FIX: Keep original subject in emails to staged users
...
Renaming a topic shouldn't be visibile to staged users when the topic was created via email.
2019-01-18 11:07:54 +01:00
b20ad9d684
FIX: since Ember 3 interceptClick was not working on buffered links ( #6898 )
2019-01-18 11:01:19 +01:00
95e3841974
FIX: Remove old reference and use `MiniScheduler::Stat`.
2019-01-18 16:36:11 +08:00
f89a32e759
FIX: Text logo does not show up on non ember pages.
2019-01-18 15:11:42 +08:00
cf6223226d
DEV: Do the draft conflict check async. ( #6895 )
2019-01-18 15:51:56 +11:00
2274d6d7ac
FIX: refresh "/categories" on logo click ( #6891 )
...
* FIX: refresh discovery categories on logo click
* Fix prettier offence
2019-01-18 12:08:42 +08:00
9f52306861
Keep avatar image at native size for normal font-size, remove unneeded clearfix
2019-01-17 21:54:22 -05:00
8c5c4200ec
prettier
2019-01-17 21:13:52 -05:00
5307e9337f
HACK: Reduce icon jitter while scrolling with composer open in iOS
2019-01-17 21:04:05 -05:00
d5d994e24a
UX: Improving user stream alignment and spacing
2019-01-17 17:29:27 -05:00
43bb16de27
Prevent header icons from overflowing with long title present
2019-01-17 16:11:40 -05:00
7401901939
UX: Badge alignment adjustments
2019-01-17 15:46:55 -05:00
2818afb267
FIX: Do not hide posts automatically when flagged by staff user
2019-01-18 01:33:55 +05:30
3c987132cb
Prevent placeholder text from being cut-off
2019-01-17 14:39:28 -05:00
3501533a2b
DEV: unpin Prettier version, apply to YAML files
...
We had Prettier pinned because of https://github.com/prettier/prettier/issues/5529 . Since that bug is fixed, unpinning.
Prettier now supports YAML, so this applies Prettier to all .yml except for translations, which should not be edited directly anyway.
2019-01-17 13:05:39 -05:00
b664674d2b
make smaller text size bigger
2019-01-17 12:11:31 -05:00
b9215ddaea
FIX: Navigate to full page search when enter key used in topic
2019-01-17 22:34:23 +05:30
b9355f316a
Minor size/alignment fixes for font size increase
2019-01-17 11:42:03 -05:00
675bf94133
UX: Bump up base font size 1px, add smaller text size option
2019-01-17 10:30:34 -05:00
24b59afe2a
FIX: Wrap theme javascript inside IIFE to prevent using global namespace
2019-01-17 14:44:10 +00:00
5bfa661a87
FIX: Theme settings are referenced in JS by `settings`, not `themeSetting`
2019-01-17 12:24:21 +00:00
880311dd4d
FEATURE: Support for localized themes ( #6848 )
...
- Themes can supply translation files in a format like `/locales/{locale}.yml`. These files should be valid YAML, with a single top level key equal to the locale being defined. For now these can only be defined using the `discourse_theme` CLI, importing a `.tar.gz`, or from a GIT repository.
- Fallback is handled on a global level (if the locale is not defined in the theme), as well as on individual keys (if some keys are missing from the selected interface language).
- Administrators can override individual keys on a per-theme basis in the /admin/customize/themes user interface.
- Theme developers should access defined translations using the new theme prefix variables:
JavaScript: `I18n.t(themePrefix("my_translation_key"))`
Handlebars: `{{theme-i18n "my_translation_key"}}` or `{{i18n (theme-prefix "my_translation_key")}}`
- To design for backwards compatibility, theme developers can check for the presence of the `themePrefix` variable in JavaScript
- As part of this, the old `{{themeSetting.setting_name}}` syntax is deprecated in favour of `{{theme-setting "setting_name"}}`
2019-01-17 11:46:11 +00:00
740d047365
FIX: regression lead to a 404 when trying to filter user posts ( #6893 )
2019-01-17 11:31:23 +01:00
aa2cc4ab31
FIX: Liked notification consolidation has to account for user like frequency setting.
2019-01-17 14:33:23 +08:00
384135845b
FEATURE: introduce ultra_low priority queue
...
This commit introduces an ultra low priority queue for post rebakes. This
way rebakes can never interfere with regular sidekiq processing for cases
where we perform a large scale rebake.
Additionally it allows Post.rebake_old to be run with rate_limiter: false
to avoid triggering the limiter when rebaking. This is handy for cases
where you want to just force the full rebake and not wait for it to trickle
2019-01-17 14:53:19 +11:00
7d84648d11
FEATURE: Remove full quotes only from new posts. ( #6862 )
2019-01-17 13:24:32 +11:00
e7d2a0d42f
UX: Larger/Largest font-sizes should be 1px larger on mobile
2019-01-16 20:59:31 -05:00
d5ecf8e8c2
FIX: properly clean out post and user actions on destroy user
...
This corrects 2 issues:
First is a regression with d7c08e21
2019-01-17 12:40:30 +11:00
d7c08e217a
PERF: delete user and post actions vs destroy on user destroy
...
Users can have 100s of thousands of post and user actions, we do not want
to destroy each individually cause the tracking is enormous and the amount
of queries we would need is enormous.
This gives up on the `after_commit` hook on `post_actions` which ships a message
to clients to synchronize a post, so some phantom post_actions may remain
in the UX in the rare occasion we delete a user. The phantoms will be gone
on reload.
2019-01-17 11:19:37 +11:00
1d4d4b81e6
remove stray chars
2019-01-16 15:05:43 -08:00
58008dd2fe
FIX: sort topics/posts/links in descending order in user summaries
...
This should only change the order on freshly imported instances with no likes.
This makes the user summary show the latest topics/posts/links instead of the firsts until the users get some likes.
2019-01-16 23:58:46 +01:00
f0999f27a7
UX: soften the "problems" alert on dashboard
2019-01-16 14:58:19 -08:00
6079a3e4d0
FEATURE: allow calling user destroyer without a transaction
...
This additional option allows us to destroy a user in "pieces" in cases
where database is very big and stuff tends to time out
2019-01-17 07:56:17 +11:00
16a7102dad
FIX: `Ember.warn` needs an `id`
...
This way errors can be customized/silenced in the console.
2019-01-16 14:53:13 -05:00
98f26bcaf5
Revert "FIX: makes click-interceptor working with touchstart ( #6890 )"
...
This reverts commit fd2dd8d67d
2019-01-16 17:47:40 +00:00
fd2dd8d67d
FIX: makes click-interceptor working with touchstart ( #6890 )
...
Probable regression due to the removal of Modernizr.
2019-01-16 17:56:43 +01:00
18055f5e37
DEV: show remote theme repository URL
2019-01-16 11:09:16 -05:00
1ac4dc5b73
FIX: makes whisper state more resilient ( #6889 )
...
This commit also moves some logic from model to controller.
2019-01-16 15:23:06 +01:00
b46b6e72d1
FIX: Only add the trust level name for numeric trust levels
...
Previously the TrustLevelAndStaffSetting would display 'new user' for staff/admin
2019-01-16 12:04:12 +00:00
79eb1b8e16
FIX: Add watching_first_post to NOTIFIABLE_TYPES ( #6887 )
2019-01-16 11:49:15 +00:00
54f95bb335
rm period ( #6886 )
2019-01-16 10:58:43 +01:00
486df57a23
FIX: tweaking topic footer dropdowns ( #6882 )
...
- no description on mobile for notifications
- better reason text positioning
2019-01-16 10:27:27 +01:00
f06b773d25
FIX: Don't show liked consolidated notification when frequency is never.
2019-01-16 17:08:59 +08:00
e7b49c42c4
FIX: Allow liked notifications consolidation to be disabled.
2019-01-16 16:17:04 +08:00
f8db93df5f
FIX: Consolidated like notifications links to wrong user on user page.
2019-01-16 15:55:18 +08:00
27e2b6575b
FIX: Liked notifications should not be consolidated across multiple users.
2019-01-16 15:01:13 +08:00
71a69c1976
Revert "FIX: refresh topic list on logo click"
...
This reverts commit 037776881b
2019-01-15 22:54:53 -05:00
1591c42a06
FIX: profile picture not showing up on user admin page
2019-01-16 09:21:11 +05:30
40533bc570
REFACTOR: `filterBy` in `UserStream`.
...
Follow up to ebe65577ed
2019-01-16 10:53:44 +08:00
ebe65577ed
FEATURE: Consolidate likes notifications. ( #6879 )
2019-01-16 10:40:16 +08:00
037776881b
FIX: refresh topic list on logo click
...
Fixes a regression where, when homepage is set to "categories", clicking on logo would no longer reload topic list.
2019-01-15 17:01:09 -05:00
b69e57e2f3
FIX: Prevent layout changes while images are lazy-loading
...
This commit moves the temporary image to be adjacent to the original image in the DOM. Previously the temporary image was appended to the parent element. Normally this makes no difference because the temporary element has position:absolute. However, if the `:last-child` selector is being used on the parent, it can cause layout changes during loading.
2019-01-15 17:35:55 +00:00
70cdb42173
FIX: Tooltip for unlisted topics wasn't shown in topic list
...
The locale key had to be renamed, because this key is also used as CSS class.
The "invisible" CSS class makes the icon invisible. "unlisted" doesn't have that effect.
2019-01-15 16:13:06 +01:00
c4422fdc13
UX: sort admins and moderators by last seen date on /about page
...
UX: only show active admins and moderators on /about page
2019-01-15 17:26:11 +05:30
59e5af466b
FIX: call method only if it exists
...
discourse-objects creating empty Discourse object in window. It fails the _registerPluginCode method call since it is not exist.
2019-01-15 15:55:32 +05:30
f75915efa4
FIX: `expandAllPinned` was not resetting after visiting a category
...
This resulted in a bug where if you saw a pinned topic in a category,
then went back to latest, the same topic would show an excerpt even
though it shouldn't on the latest view.
See:
https://meta.discourse.org/t/pinned-post-excerpt-no-longer-appears-after-refreshing-the-page/106222
2019-01-14 13:02:25 -05:00
0cb2b7d603
FIX: add meta details for user summary page
2019-01-14 19:49:14 +05:30
1ebd3dbbd0
FEATURE: Allow the base font size to be changed on a per-user basis ( #6859 )
2019-01-14 13:21:46 +00:00
59e3eecfa6
FEATURE: allow staff to select existing message via ID or URL
2019-01-14 15:29:05 +05:30
a121d40771
FIX: do not show PM topics when moving posts to an existing public topic ( #6876 )
2019-01-14 15:00:45 +05:30
08d21cc758
FIX: do not show full name on summary page unless the setting is enabled
2019-01-14 07:00:44 +05:30
93eb0a0690
UX: better help text for private invite-only instance
2019-01-12 18:40:00 +05:30
49593d1a00
FIX: Fix registration dialog popup for 'full screen' social logins
...
Regression following the ember3 upgrade. In addition to fixing, this commit consolidates our social registration logic into one place, and adds tests for the behaviour.
2019-01-12 12:08:13 +00:00
dcdcaebd0f
FIX: checkEmail was calling itself ( #6878 )
2019-01-12 11:12:17 +01:00
8176d26dbd
UX: Reducing usage of btn-small, simplifying styles
2019-01-11 19:41:09 -05:00
e4c593f1e7
removing some dupe styles, adding button class
2019-01-11 15:41:51 -05:00
95f263995d
FIX: Previous annotations were broken
2019-01-11 14:30:19 -05:00
5e0f9eadb8
FIX: show user avatar on User summary page ( #6872 )
2019-01-11 23:39:06 +05:30
83f0afbec9
Usercards sometimes not wrapping correctly in Safari
2019-01-11 12:50:16 -05:00
a3839495e0
Update annotations
2019-01-11 12:19:43 -05:00
1a3655b787
DEV: s/Em/Ember ( #6874 )
2019-01-11 17:54:23 +01:00
dbe42068a2
REFACTOR: Move option to return emails into the serializer
...
This makes more sense than having the guardian take an accessor.
The logic belongs in the Serializer, where the JSON is calculated.
Also removed some of the DRYness in the spec. It's fewer lines
and made it easier to test the option on the serializer.
2019-01-11 11:17:23 -05:00
0fa92699e2
UX: Don't save automatically when resetting site settings in admin page.
2019-01-11 16:39:21 +08:00
2956c52e57
FIX: Show title as home logo if title has been set and logo is blank.
...
https://meta.discourse.org/t/default-text-logo-not-working/103936
2019-01-11 15:46:58 +08:00
99856478d6
FIX: use discourse route_for function to check url route
...
it takes care if there is a relative url root
2019-01-11 14:58:45 +08:00
29ff184508
d60b9df fix, was too broad
2019-01-10 21:50:00 -05:00
d60b9dfba4
UX: Close button shouldn't get :visited color
2019-01-10 21:47:38 -05:00
9f39ac8366
FIX: ember3 regression, uses model as bufferedProperty for badges ( #6875 )
2019-01-11 00:46:03 +01:00
49e3a83062
FIX: minor regression when acting on queued post
2019-01-10 15:32:33 -05:00
0744e84604
UX: always scope the composer categories dropdown to current category
2019-01-11 01:07:23 +05:30
a8ff4a8a78
UX: search all categories even if category-chooser is scoped to particular category
2019-01-10 21:19:53 +05:30
978cc0cfca
FIX: Remove expired subscription for push notifications
...
All other errors get logged, but do not stop the system from sending further push notifications.
2019-01-10 15:41:04 +01:00
1fdbf0fc9b
FIX: uses compiler version to force rebaking of themes ( #6870 )
...
Co-Authored-By: David Taylor <david@taylorhq.com>
2019-01-10 12:36:13 +01:00
f9648de897
DEV: upgrades from Ember 2.13 to Ember 3.5.1 ( #6808 )
...
Co-Authored-By: Bianca Nenciu <nbianca@users.noreply.github.com>
Co-Authored-By: David Taylor <david@taylorhq.com>
2019-01-10 11:06:01 +01:00
c2bca9cabe
Make rubocop happy.
2019-01-10 10:52:15 +08:00
d10694150e
Revert "FIX: Partial reply key search in email sent logs."
...
This reverts commit e9b2018bc8
2019-01-10 10:05:56 +08:00
798e98a7cc
remove safari check from isAppleDevice ( #6869 )
2019-01-10 13:02:55 +11:00
51b13ec86f
FIX: show lock glyph to a user without permissions to see quote ( #6854 )
2019-01-10 09:48:05 +08:00
cb0f6d653b
DEV: Minor fixes to b63b399799.
2019-01-10 09:38:22 +08:00
b63b399799
DEV: remove uploaded_meta_id column from category ( #6725 )
...
* DEV: remove uploaded_meta_id column from category
* remove uploaded_meta part
2019-01-10 09:37:21 +08:00
a52baf4b28
FEAT: use category logo image as meta image ( #6865 )
2019-01-10 09:33:13 +08:00
e9b2018bc8
FIX: Partial reply key search in email sent logs.
...
Follow up to c85b9c6ed3
2019-01-10 09:25:14 +08:00
c85b9c6ed3
FIX: searching email logs by reply key ( #6868 )
...
* you can't use LIKE or ILIKE on a UUID
2019-01-10 07:51:58 +08:00
312e282b6a
FIX: Apply classes when lazily loading images
...
If an image had extra classes (for example oneboxes), then while loading
the copy of the image would lose those classes and look differently
until the image had loaded fully.
This fix copies the classes while loading.
2019-01-09 12:56:25 -05:00
439eff4709
revert null checking around interceptClick
2019-01-09 09:44:30 -08:00
2d3e50ae7c
FIX: Match default `<code>` padding to highlightjs padding
...
Without this, the height of posts changes once highlightjs is lazy-loaded, potentially causing scrolling issues
2019-01-09 17:36:51 +00:00
8b3ddcf646
FIX: Add topic status to flagged topics list
...
Previously at a glance it was impossible to tell if a topic was closed
before digging deeper.
2019-01-09 10:59:35 -05:00
1f12a377fa
minor refactoring of card-contents-base mixin
2019-01-09 19:32:30 +05:30
b7c501bf52
FIX: full page search results are unclickable
...
data-ember-action can have empty value in favor of data-ember-action-ID attribute
2019-01-09 10:59:37 +05:30
2748822576
FEATURE: Remove option for Google Plus sharing ( #6864 )
...
* Remove option for Google Plus sharing
* remove google+ share translations
2019-01-09 10:17:50 +08:00
25269a37aa
FIX: do not show #uncategorized in category drop if setting is disabled ( #6856 )
2019-01-09 09:44:24 +08:00
f73fe36772
FEATURE: PWA compatibility checks in the Dashboard ( #6850 )
2019-01-09 08:46:11 +08:00
09cbd08c64
FIX: ensure ember transitions do not get hijacked by discourse intercept-click
...
explicit null checks as a blank string evaluates to false
2019-01-08 15:38:13 -08:00
d75262046d
Revert "FIX: ensure ember transitions do not get hijacked by discourse intercept-click"
...
This reverts commit a2cb2f2366
2019-01-08 15:37:10 -08:00
a2cb2f2366
FIX: ensure ember transitions do not get hijacked by discourse intercept-click
...
explicit null checks as a blank string evaluates to false
2019-01-08 15:09:50 -08:00
7e4a43afc6
PERF: run ImageMagick conversions with nice 10
...
This lowers the priority of all image resizes so they do not clog CPU on
machines running low on resources
2019-01-09 09:21:58 +11:00
e08a3f719c
FEATURE: push post rebake regular task to low priority queue
...
This allows us to run regular rebakes without starving the normal queue.
It additionally adds the ability to specify queue with `Jobs.enqueue` so
we can specifically queue a job with lower priority using the `queue` arg.
2019-01-09 08:57:20 +11:00
cfb8e157a2
Fixing tag alignment
2019-01-08 16:25:11 -05:00
4a01fee41b
UX: use default H2 and H3 sizes on user profiles for better hierarchy
2019-01-08 13:07:29 -05:00
fe20cb4b56
FIX: Enforce a fixed height on generic oneboxed videos
...
This prevents 'jumping' as the video loads. This change will require posts to be rebaked before it takes effect.
2019-01-08 16:22:03 +00:00
a2d1babac6
UX: tag container should wrap if there's a large number of tags
2019-01-08 23:33:47 +08:00
8f602be2fe
FEATURE: keep the topic in closed status until the community flags are handled
2019-01-08 16:13:10 +05:30
f947e3c6cc
FIX: always serve new avatar for previous version
...
Previously we killed caching on old avatars cause we kept serving blank
this meant we would front many more avatar requests after a version change
This change ensures all old avatars do not cause a flood of requests on the
server
2019-01-08 19:51:33 +11:00
3457395f75
UX: moves topic-list excerpts out of category / tag div
2019-01-08 14:55:15 +08:00
4ebf170fe4
DEV: no need for conditional redirect in invites
2019-01-08 11:34:26 +05:30
9919f16041
FIX: use absolute URL for twitter:image tag
2019-01-08 11:19:04 +05:30
ef72a9a1fe
UX: Default search log index to yearly.
2019-01-08 13:40:38 +08:00
6c8069c65a
FIX: properly escape embed url
2019-01-07 18:11:43 +01:00
e0bc82657b
FIX: better accept invite flow when user is invited via a link
2019-01-07 14:22:08 +05:30
effb3262a1
UX: no need for margin if participants is first-child
2019-01-06 00:11:53 +08:00
3a9fea4409
align and truncate header tags and participants
2019-01-05 23:09:44 +08:00
046e4ab413
FIX: Improve topic small header alignment in mobile
...
Force topic-header-extra height to 20px
2019-01-05 14:06:06 +05:30
3589f3e023
UX: Display user and group cards over the small PM header
2019-01-05 04:58:56 +05:30
aba18a42a7
UX: Improve PM small header alignment with recipient avatars
2019-01-05 03:51:15 +05:30
5eaf3cb104
Adjusts the `minimum_flag_threshold` for TL3/TL4 actions
...
Before this patch, a high trust level user could flag something
and have an action be taken, as well as skipping the flag queue.
Now, if a TL3/TL4 cause an action, the flag will skip the minimum
visibility check and allow staff to review it.
2019-01-04 13:16:44 -05:00
5ac1e3d4cd
FIX: emojis are hard 🤷
2019-01-04 17:21:16 +01:00
f400830575
DEV: Remove old _firefoxPastingHack
2019-01-04 11:14:35 -05:00
858a456aaf
FEATURE: Use email_site_title in From of digest emails
2019-01-04 17:06:19 +01:00
c0a8bb9a91
FEATURE: Include "via <site_name>" in email From header
2019-01-04 17:06:19 +01:00
95e5f8380d
FEATURE: Allow plugins to add custom emoji translations
...
FIX: buildTranslationTree was erroring when translations overlapped (ie. ":-)" and ":-))")
FIX: emoji translations wasn't working properly when translations overlapped
2019-01-04 15:27:46 +01:00
88e861e895
FIX: prevent error when badge has already been awarded
2019-01-04 15:17:54 +01:00
5bf16d7d10
FEATURE: Topic timer for bumping a topic in the future
2019-01-04 13:08:04 +00:00
9c91e68351
PERF: remove image optimization throttling from Sidekiq
...
Previously we only allowed one image optimization per machine, this meant there
was cross talk between avatar resizing and Sidekiq. This could lead to large
amounts of starvation when optimized image version changed which in turn could
block the Sidekiq queue.
This increases amount of allowed load on machines but this is preferable to
having crosstalk between avatar resizing and Sidekiq.
2019-01-04 18:44:44 +11:00
75dbb98cca
FEATURE: Add S3 etag value to uploads table ( #6795 )
2019-01-04 14:16:22 +08:00
3a04e04ccb
UX: excerpts don't wrap on IE11 ( #6847 )
2019-01-04 15:11:42 +11:00
8b7a2d1cb7
FEATURE: add setting to bypass sending redis CLIENT commands
...
Some cloud providers (Google Memorystore) do not support any CLIENT commands
By setting :id to nil in the redis config hash we can avoid these commands.
This adds a special global setting GCE users can enable:
`DISCOURSE_REDIS_SKIP_CLIENT_COMMANDS = true`
2019-01-04 15:08:33 +11:00
a2f1d47506
Slightly better alignment of PM participants in header
2019-01-03 22:47:56 -05:00
19d7545318
FEATURE: Make auth_redirect param options on user_api_keys
...
This is a possible solution for https://meta.discourse.org/t/user-api-keys-specification/48536/19
This allows for user-api-key requests to not require a redirect url.
Instead, the encypted payload will just be displayed after creation ( which can be copied
pasted into an env for a CLI, for example )
Also: Show instructions when creating user-api-key w/out redirect
This adds a view to show instructions when requesting a user-api-key
without a redirect. It adds a erb template and json format.
Also adds a i18n user_api_key.instructions for server.en.yml
2019-01-04 14:46:18 +11:00
d0f38dbb07
FIX: image rendered temporarily in wrong position while loading
...
Previously non lightboxed images would render in the wrong spot while loading.
We assumed the image we were rendering while loading was at 0,0 position.
This is not the case on non-lightboxed images cause they have no surrounding
DIV.
2019-01-04 11:50:44 +11:00
70269c7c97
FEATURE: tighter limits on per cluster post rebakes
...
We have the periodical job that regularly will rebake old posts. This is
used to trickle in update to cooked markdown. The problem is that each rebake
can issue multiple background jobs (post process and pull hotlinked images)
Previously we had no per-cluster limit so cluster running 100s of sites could
flood the sidekiq queue with rebake related jobs.
New system introduces a hard limit of 300 rebakes per 15 minutes across a
cluster to ensure the sidekiq job is not dominated by this.
We also reduced `rebake_old_posts_count` to 80, which is a safer default.
2019-01-04 09:24:46 +11:00
385829d7be
FEATURE: Display error message when category restriction is applied for tags
2019-01-04 00:29:13 +05:30
d1597683f3
Revert "FIX: trim trailing slash from topic links"
...
This reverts commit 993f847a2c
2019-01-03 17:29:22 +05:30
993f847a2c
FIX: trim trailing slash from topic links
2019-01-03 12:38:36 +05:30
570877da3c
FEATURE: store thumbnail algorithm version in optimized image table
...
Previously we had no idea what algorithm generated thumbnails, this starts tracking the version.
We also bumped up the version to force all optimized images to be generated. This is important cause we recently introduced pngquant which results in much smaller images.
2019-01-03 17:07:30 +11:00
bea7a8a4d1
FIX: show accurate error message based on invite token validity
2019-01-03 07:46:05 +05:30
a953b71797
FEATURE: allow custom HighlightJS languages
...
Adds pluginApi function that allows themes and plugins to register languages for HighlightJS.
2019-01-02 19:07:36 -05:00
4af7471ead
Better contrast ratio match between dark and light themes
2019-01-02 17:54:22 -05:00
49fbedc445
FIX: make full height menu and cloak respect custom headers ( #6845 )
2019-01-02 14:18:14 -08:00
0c11caf796
UX: remove gray background from lighbox
...
This avoids a 3 way transition when loading images
- grey
- ultra low res
- full image
Instead we go
- ultra low res
- full image
2019-01-03 08:16:33 +11:00
e8a75628fd
Revert "FIX: make full height menu and cloak respect custom headers"
...
This reverts commit a61d9deba1
2019-01-02 11:51:03 -08:00
dc477d1228
FIX: "Toggle topic bump" wasn't visible for TL4 users
2019-01-02 20:16:55 +01:00
a61d9deba1
FIX: make full height menu and cloak respect custom headers
2019-01-02 11:05:44 -08:00
c30996129f
FEATURE: Allow TL4 users to reset bump date
2019-01-02 16:57:05 +01:00
e8053d6e7d
FIX: Polls didn't work in imported posts
...
Imports skip validation of posts, but polls are only created during the validation phase.
2019-01-02 15:26:57 +01:00
0884cd218d
UX: Add group name next to PM recipient avatar
...
Also changed group icon color and did minor refactoring
2019-01-02 15:26:42 +05:30
766e67ce57
FEATURE: introduce lossy color optimization on resized pngs
...
This feature ensures optimized images run via pngquant, this results extreme amounts of savings for resized images. Effectively the only impact is that the color palette on small resized images is reduced to 256.
To ensure safety we only apply this optimisation to images smaller than 500k.
This commit also makes a bunch of image specs less fragile.
2019-01-02 17:20:02 +11:00
14911d50a1
DEV: improve comment explaining need for favicon proxy
2019-01-02 13:15:20 +11:00
27ed60bad0
FIX: Quote selection in IE11
2018-12-31 13:54:05 +00:00
70fdc10365
FEATURE: move posts to new/existing PM ( #6802 )
2018-12-31 17:17:22 +05:30
0fca3205b5
FIX: show error msg on grant badge if message available from backend ( #6801 )
2018-12-31 10:46:39 +01:00
1381dc603d
UX: show generic message when reloading 'activation email resent' page
2018-12-31 13:12:37 +05:30
6fb421312e
UX: aligns categories and tags in topic lists
...
History:
https://meta.discourse.org/t/minor-visual-weirdness-on-topic-listing-category-and-tags/105268
2018-12-31 14:38:33 +08:00
55d745f03b
UX: header needs a bit of padding on narrow screens
...
A bit of history
https://meta.discourse.org/t/header-on-responsive-window/105204
2018-12-31 14:33:02 +08:00
021f11b68e
FEATURE: Display avatars of PM recepients in small topic header when scrolling down
2018-12-30 20:10:40 +05:30
e7cf642b1f
FIX: reports issues with ie11 ( #6828 )
2018-12-28 21:32:07 +01:00
9a8db2748a
FIX: composer css fixes for ie11 ( #6827 )
2018-12-28 20:52:21 +01:00
f1269fa807
FEATURE: Add `Top Uploads` report ( #6825 )
...
Co-Authored-By: I am very Pro-Grammer. <khalilovcmded@users.noreply.github.com>
2018-12-28 20:48:54 +01:00
608abd4c08
FIX: uses `flex: 1 0 0;` instead of `flex: 1;` for better browser compat ( #6826 )
2018-12-28 20:21:32 +01:00
7b15b87cf5
FIX: better left/right positioning in select-kit components ( #6824 )
2018-12-28 19:46:31 +01:00
0f09cb50e9
FIX: less fancy pages computation for browser compatibility ( #6823 )
2018-12-28 19:07:29 +01:00
4f6ca66df5
FIX: routeToTag mini-fix for IE11
...
skip "a.host" for IE11 since IE11 does not support URL interface
2018-12-28 11:49:51 -05:00
fdfb7ed764
FIX: Limit previous IE SVG click event fix
...
Fixes issues with clicking SVG icons in Safari, IE11, Edge
2018-12-28 10:18:53 -05:00
74f0bd08c0
UX: removes unnecessary margin in header tag wrapper
...
This margin is not needed and doesn't exist in the mobile view.
It causes a bit of a problem in desktop topics with no categories and more prominently in PMs in the desktop view.
There's a small TODO here where the rest of the extra-info-wrapper styles should all be moved to header sylesheets.
2018-12-28 21:31:41 +08:00
942114b34c
FIX: optimize collapse/expand select-kit codepath ( #6818 )
2018-12-27 23:38:01 +01:00
1d62d3df6f
FIX: remove storage_stats from the list of reports, too specific ( #6817 )
2018-12-27 22:21:08 +01:00
695894d458
FIX: delete dataset doesn’t work on safari
2018-12-27 06:49:49 +02:00
2b006c0429
FEATURE: Invalidate broken images cache on Rebuild HTML action
2018-12-26 23:22:07 +05:30
2076f371b3
FIX: Hashtags should work for non-english characters
2018-12-26 22:12:40 +05:30
5381096bfd
PERF: new 'migrate_to_s3' rake task
2018-12-26 17:34:49 +01:00
303a535dba
PERF: automatic upload size calculation not persisted
...
Previously if upload had missing width and height we would calculate
on first use BUT we (me) forgot to save this to the database
This was particularly bad on home page cause category images (when old)
miss dimensions.
2018-12-26 17:19:29 +02:00
f637286db5
UX: improves flags-status report ( #6773 )
...
- link to post
- cover more post action types
2018-12-26 10:29:33 +01:00
0402f0f357
UX: new site setting to define activity metrics displayed on dashboard
2018-12-26 10:29:07 +01:00
69aa8f18c2
FEATURE: allow for custom excerpt BBCODE
...
This allows fidelity in controlling excerpt (text that shows up when you pin a topic or link to it externally):
```
I am some text
[excerpt]
This is some **custom** markdown that should be the excerpt
[/excerpt]
More text
```
Previous solution relied on DIVs, unfortunately DIVs do not play well,
by design with mixing markdown unless you have a preceding newline eg:
```
<div class='hello'>
this will be treated properly as markdown
</div>
```
This extra newline is not desirable.
I am also considering adding
```
[div class=excerpt]
[/div]
```
This would offer lots of flexibility to themes and plugins that do not want the extra annoying newline.
2018-12-25 17:02:28 +02:00
61dcd7c52c
FIX: validate YAML before save to avoid race condition
2018-12-25 15:08:17 +02:00
1e2b81991f
fix the build
2018-12-25 10:27:51 +05:30
a74e49c87c
use proper typographical × instead of x
2018-12-24 20:33:17 -08:00
a16bb32865
FIX: Do not raise error if most liked user is deleted
2018-12-25 01:04:55 +05:30
2988d281fc
DEV: group all collapsed notifications
2018-12-24 12:44:50 +01:00
b3df4bee9c
FIX: Hide group membership request button for existing members
2018-12-24 13:49:05 +05:30
f4d8a330c3
Merge pull request #6761 from mrfinch/saurabh/show-popup
...
FIX:show popup before bulk invite
2018-12-21 21:36:17 +01:00
126be6c478
FIX: Resetting bump date shouldn't fail when first post is hidden
2018-12-21 17:43:52 +01:00
0e710dc573
Improvements to Lazy Loading
...
- Now applied to all images over 150x150px
- Stores the width and height in the WeakMap rather than using
percentages for accuracy
- When oneboxed images are hidden, they are given a subtle border for better
visibility.
- Don't apply when in the composer. Causes flickering.
2018-12-21 11:31:27 -05:00
7feabd9e49
PERF: Eradicate N+1 queries from the theme admin page
2018-12-21 11:03:58 +02:00
2909e7fbdf
FIX: Subfolder path is missing in category permalinks after slug update
2018-12-21 09:29:54 +05:30
a2ae67509d
Don't use `getAttribute` if we don't need to
2018-12-20 16:41:04 -05:00
816acc6984
Improving color contrast of $danger-low for dark themes
2018-12-20 14:46:13 -05:00
f4d37d05c3
Merge branch 'master' of github.com:discourse/discourse
2018-12-20 11:15:26 -05:00
28283c2396
FIX: Workaround for Edge issue with clicks on SVGs
...
- Related Edge issue at https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10583086/
2018-12-20 11:13:55 -05:00
e7e4074856
FIX: raises an error if q param is empty in search page
2018-12-20 21:43:14 +05:30
400eea4d13
UX: show lazy loaded images while they are downloading
...
Also shows fuzzy image right away prior to it being downloaded
2018-12-20 22:04:30 +08:00
d7466156ae
UX: adds missing wizard icons
...
With our recent move to SVG icons, the font file does not work in the wizard. I've opted for path2D, which accepts an SVG path
Path2D is not supported by IE11 but the chances of admins running the wizard on IE11 are practically none.
https://caniuse.com/#feat=path2d
2018-12-20 14:55:40 +02:00
3d2c72dd33
UX: Switch placeholder to an SSH url if importing a private theme
2018-12-20 17:01:50 +05:30
a06d310855
DEV: Refactor location string builders. ( #6794 )
2018-12-20 10:23:05 +01:00
dc292d4598
FIX: Use one-way binding to prevent unnecessary updates in site.periods
2018-12-20 03:39:05 +05:30
bb67ca9d21
FIX: use correct post object when logging exception
2018-12-19 22:17:37 +05:30
1ea0cbece8
FIX: skip adding sso diagnostics if sso object is nil
2018-12-19 20:55:35 +05:30
e655e1863f
UX: Adding reports dashboard tab, new layout, report descriptions ( #6790 )
...
Co-Authored-By: Kris <shout@k-ris.com>
2018-12-19 14:44:43 +01:00
f5c4ab0573
Add category link renderer to plugin API ( #6787 )
...
* Add category link renderer to plugin API
- lets themes/plugins override the category link display
- planning to use this in a "category icons" theme component
* small code review fix
* Code review refactor
2018-12-19 10:26:09 +01:00
7050ce4638
FIX: Bypass draft check when switching to shared draft. ( #6782 )
2018-12-19 10:25:33 +01:00
0ce5f05b2a
FIX: hide emails on admin user list for moderators ( #6781 )
2018-12-19 10:24:57 +01:00
2fcbbead45
FIX: move sso provider into its own class so it doesn't interfere with sso client ( #6767 )
2018-12-19 10:22:10 +01:00
2eefe6d5d6
FIX: Use CDN for logos and icons. ( #6698 )
2018-12-19 10:20:48 +01:00
41e06efb94
Adding padding to mobile that was removed in 3710b016
2018-12-18 22:20:02 -05:00
David Taylor
Dan Ungureanu
Simon Cossar
Joffrey JAFFEUX
Kris
Gerhard Schlager
Arpit Jalan
Bianca Nenciu
Vinoth Kannan
Tarek Khalil
Sam
Jeff Wong
Maja Komel
Jeff Atwood
Penar Musaraj
Erick Guan
Régis Hanol
Vinoth Kannan
Davide Porrovecchio
Osama Sayegh
Robin Ward
Guo Xiang Tan
Guo Xiang Tan
peterlamber
Saurabh Patel
Neil Lalonde
Blake Erickson
Joe
Angus McLeod
Daniel
Michael Brown
Zach Whitehead
Rafael dos Santos Silva
cfitz
Kyle Zhao
Joe
Rishabh
