3c81683955
DEV: Rename `UriHelper.escape_uri` to `.normalized_encode`
...
This is a much better description of its function. It performs idempotent normalization of a URL. If consumers truly need to `encode` a URL (including double-encoding of existing encoded entities), they can use the existing `.encode` method.
2022-08-09 11:55:25 +01:00
3eaac56797
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
9534f13256
DEV: Replace `site-settings:main` with `service:site-settings` ( #17734 )
...
This will allow consumers to inject it using `siteSettings: service()` in preparation for the removal of implicit injections in Ember 4.0. `site-settings:main` is still available and will print a deprecation notice.
2022-08-01 09:43:33 +01:00
493d437e79
Add RSpec 4 compatibility ( #17652 )
...
* Remove outdated option
04078317bahttps://github.com/rspec/rspec-core/pull/2803
* Use the non-globally exposed RSpec syntax, cont
https://github.com/rspec/rspec-core/pull/2803
* Comply to strict predicate matchers
See:
- https://github.com/rspec/rspec-expectations/pull/1195
- https://github.com/rspec/rspec-expectations/pull/1196
- https://github.com/rspec/rspec-expectations/pull/1277
2022-07-28 10:27:38 +08:00
b179fb98b1
DEV: Consistently use `response` helper ( #17627 )
2022-07-25 02:31:52 +02:00
6cae26c499
DEV: Always `await` for `publishToMessageBus` ( #17626 )
...
(+ typos)
2022-07-24 19:55:58 +02:00
c700cf3213
DEV: Fix pretender in poll tests ( #17587 )
2022-07-21 10:53:21 +02:00
3ada82f713
DEV: Use native `element.closest()` ( #17482 )
2022-07-14 08:57:24 +08:00
7b6cd44c32
DEV: Remove most of jQuery usage from tests ( #17474 )
2022-07-13 19:29:19 +02:00
189bebb2e4
DEV: Modernize component tests ( #17368 )
...
* Use QUnit `module` instead of `discourseModule`
* Use QUnit `test` instead of `componentTest`
* Use angle-bracket syntax
* Remove jQuery usage
* Improve assertions (and actually fix some of them)
2022-07-11 12:29:44 +02:00
c3fd91670e
DEV: Update linting setup and fix issues ( #17345 )
...
Re-lands #16119 and #17298
* Update eslint-config-discourse
* Update linting workflow
* Prettier-ignore stuff
* Update template-lint config
* Auto-fix template issues
* Fix various template issues
Mostly incorrect attributes and unused templates
* Prettier js files
* Fix template auto-fix regressions
* Small css tweak
Co-authored-by: Peter Wagenet <peter.wagenet@gmail.com>
2022-07-06 10:37:54 +02:00
371bbadb92
No implicit this codemod ( #17235 )
...
* Run no-implicit-this codemod for app templates
* Run tagless-ember-components-codemod for plugins
* Turn on no-implicit-this lint
2022-07-05 19:41:31 +02:00
c011dd7b43
DEV: Remove last few curly-component invocations
2022-07-04 17:25:42 +01:00
624c684d51
DEV: Transpile all plugin js by default ( #17175 )
...
Goodbye `# transpile_js: true`? 🙂
2022-06-21 22:07:10 +02:00
7ac485fb9f
FEATURE: Add Croatian language ( #17130 )
...
Co-authored-by: Gerhard Schlager <gerhard.schlager@discourse.org>
2022-06-18 00:18:22 +02:00
e0364cf228
Update translations ( #17087 )
2022-06-14 16:57:33 +02:00
41fa278c00
Update translations ( #16958 )
2022-05-31 16:14:37 +02:00
d303466c30
Update translations ( #16902 )
2022-05-24 16:03:04 +02:00
660227434e
Update translations ( #16701 )
2022-05-10 21:42:02 +02:00
62cbb766cd
FIX: Validate post's polls as acting user ( #16638 )
...
It used to validate the post from the perspective of the user who
created the post. That did not work well when an admin attempted to
add a poll to a post created by a user who cannot create posts because
it said the user cannot create polls.
The problem was that it used post.user for the validation process
instead of post.acting_user.
2022-05-05 09:54:10 +03:00
51e29d3ca8
Update translations ( #16608 )
2022-05-03 15:30:59 +02:00
ac68cb20c3
UX: Show all pie legend options for long polls ( #16510 )
...
Results pie chart of polls with very many options were wider than the
post and most of their content was hidden.
2022-04-20 10:43:10 +03:00
4ec6af064a
Update translations ( #16505 )
2022-04-19 15:45:09 +02:00
461936f211
FIX: don't validate and render the polls inside a quoted post. ( #15019 )
...
Previously, we had issues while approving posts since we validated the polls inside quotes.
2022-04-15 16:33:07 +05:30
a1d7e77967
Update translations ( #16456 )
2022-04-12 21:04:30 +02:00
fe689115d4
Update translations ( #16378 )
2022-04-05 15:28:19 +02:00
943083f4df
DEV: Include helper in core for `applyLocalDates` ( #16325 )
2022-03-30 20:58:38 -04:00
216dfbb895
Update translations ( #16314 )
2022-03-30 14:52:59 +02:00
93407005b5
Update translations ( #16132 )
2022-03-10 16:51:47 +01:00
c9dab6fd08
DEV: Automatically require 'rails_helper' in all specs ( #16077 )
...
It's very easy to forget to add `require 'rails_helper'` at the top of every core/plugin spec file, and omissions can cause some very confusing/sporadic errors.
By setting this flag in `.rspec`, we can remove the need for `require 'rails_helper'` entirely.
2022-03-01 17:50:50 +00:00
2fc70c5572
DEV: Correctly tag heredocs ( #16061 )
...
This allows text editors to use correct syntax coloring for the heredoc sections.
Heredoc tag names we use:
languages: SQL, JS, RUBY, LUA, HTML, CSS, SCSS, SH, HBS, XML, YAML/YML, MF, ICS
other: MD, TEXT/TXT, RAW, EMAIL
2022-02-28 20:50:55 +01:00
5ff3a9c4bb
DEV: add native lazy loading for emojis ( #15830 )
2022-02-09 12:18:59 +01:00
022480b461
Update translations ( #15763 )
2022-02-01 16:15:18 +01:00
332266cbee
Update translations ( #15731 )
2022-01-27 15:18:29 +01:00
f0435ca1a7
Update translations ( #15673 )
2022-01-23 11:14:20 +01:00
2976b63094
Update translations ( #15540 )
2022-01-11 14:21:34 +01:00
cd13524e26
FIX: Disable cast votes button for multiple polls with no min.
...
Multiple polls can be created without the min attribute but that means
the attribute defaults to 1. A default of 0 does not make any sense
because it is equivalent to saying that a user is not casting any votes.
2022-01-10 10:03:17 +08:00
21822cf0b7
FIX: Error when voting on a multiple poll without the min/max attrs.
2022-01-05 11:31:18 +08:00
a82e0db5ba
Update translations ( #15446 )
2022-01-04 17:39:32 +01:00
c665003203
Update translations ( #15416 )
2021-12-28 14:13:58 +01:00
8a67be0339
Update translations ( #15353 )
2021-12-22 18:30:09 +01:00
9fd92f329e
DEV: remove `showHtml` jQuery plugin ( #15316 )
2021-12-15 13:13:06 -05:00
27fda37a8f
DEV: removes jQuery usage from extend-for-poll ( #15289 )
2021-12-14 16:52:18 +01:00
4afd6f0189
Update translations ( #15292 )
2021-12-14 14:53:35 +01:00
3fec579ede
Update translations ( #15210 )
2021-12-07 16:19:44 +01:00
b12f89e351
Update translations ( #15140 )
2021-11-30 21:06:39 +01:00
2971d03307
DEV: Don't create unnecessary scope methods ( #15104 )
...
Skipping methods we don't use gives us mem/perf gains (minuscule but still), but more importantly fixes warnings about `Poll#open` (created by `enum :status`) conflicting with some internal AR method. 😃
2021-11-26 16:34:07 +01:00
563b27b763
Update translations ( #15065 )
2021-11-23 17:29:39 +01:00
5a8e6de42c
FIX: Don't publish polls on message bus when there are no polls ( #15041 )
...
`poll` plugin was publishing on `/polls/[topic_id]` every time a non-first post was created. I can't imagine this being needed. It regressed 3 years ago in https://github.com/discourse/discourse/pull/6359
2021-11-22 12:31:53 +01:00
a9d5921901
FIX: Allow poll feature to be disabled in discourse-markdown ( #15025 )
2021-11-19 15:10:47 -06:00
David Taylor
Loïc Guitaut
Phil Pirozhkov
Jarek Radosz
Peter Wagenet
Discourse Translator Bot
Bianca Nenciu
Vinoth Kannan
Penar Musaraj
Ayke Halder
Alan Guo Xiang Tan
Joffrey JAFFEUX
Mark VanLandingham