Commit Graph

59 Commits

Author SHA1 Message Date
Guo Xiang Tan 3f24ed2b3e Can't revert due to incompatibility of new site setting types.
Revert "Revert "FEATURE: Site settings defaults per locale""

This reverts commit 439fe8ba24.
2017-08-07 10:43:09 +09:00
Guo Xiang Tan 439fe8ba24 Revert "FEATURE: Site settings defaults per locale"
This reverts commit 468a8fcd20.
2017-08-07 10:31:50 +09:00
Erick Guan 468a8fcd20 FEATURE: Site settings defaults per locale
This change-set allows setting different defaults for different locales. 

It also:

- Adds extensive testing around site setting validation

- raises deprecation error if site setting has the default property based on env

- relocated site settings for dev and tests in the initializer

- deprecated client_setting in the site setting's loading process

- ensure it raises when a enum site setting being set

- default_locale is promoted to `required` category.

- fixes incorrect default setting and validation

- fixes ensure type check for site settings

- creates a benchmark for site setting

- sets reasonable defaults for Chinese
2017-08-02 12:24:19 -04:00
Neil Lalonde 2feec43bd7 Update translations 2017-08-01 13:11:52 -04:00
Guo Xiang Tan 0eb7159e51 UX: Discobot advanced tutorial certificate does not work with dark theme.
https://meta.discourse.org/t/discobot-assets-certificate-svg/65523/11?u=tgxworld
2017-07-31 15:27:47 +09:00
Guo Xiang Tan 5012d46cbd Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
Arpit Jalan d666b73893 Update translations. 2017-07-20 14:57:02 +05:30
Leo McArdle d0b027d88d FEATURE: phase 1 of supporting multiple email addresses 2017-07-20 11:22:27 +09:00
Sam 14c2439473 correct specs so they run on latest 2017-07-18 15:45:23 -04:00
Guo Xiang Tan 78bb367b0a FIX: Discobot's certificate shouldn't blow up on non 200 response.
https://meta.discourse.org/t/discobot-assets-certificate-svg/65523/6
2017-07-14 15:16:29 +09:00
Guo Xiang Tan f1141ee4f6 Revert "Convert emoji keywords in bot narrative to use native characters."
This reverts commit bfc4f15b93.

* Transifex doesn't like those unicode strings.
2017-07-14 11:27:15 +09:00
Guo Xiang Tan bfc4f15b93 Convert emoji keywords in bot narrative to use native characters.
* Makes the narrative work even when emoji is disabled.
2017-07-13 16:04:35 +09:00
Guo Xiang Tan c049e18203 FEATURE: Allow tutorials to declare prerequisite before it starts. 2017-07-13 15:12:45 +09:00
Neil Lalonde d1d43ff5d9 FIX: report discobot messages as system messages instead of user-to-user 2017-07-12 16:00:18 -04:00
Robin Ward f1a6449e4b SECURITY: Remove disposable invite feature 2017-07-07 20:24:39 -04:00
Arpit Jalan 25d70ec900 Update Translations 2017-07-05 11:35:35 +05:30
Neil Lalonde febfe27669 Update translations 2017-06-26 14:56:22 -04:00
Guo Xiang Tan a23ce56682 Update translations. 2017-06-19 12:39:30 +09:00
Guo Xiang Tan e7571d1c5d Merge pull request #4933 from tgxworld/use_username_in_cert
FIX: Use username in bot's certificate.
2017-06-19 07:24:55 +09:00
Guo Xiang Tan f8a46c510f FIX: Recover post tutorial does not work when `SiteSetting.delete_removed_posts_after` is 0. 2017-06-16 13:03:34 +09:00
Guo Xiang Tan 716b0235f9 FIX: Use username in bot's certificate.
* The default name generated can be weird sometimes.
2017-06-16 10:32:43 +09:00
Robin Ward 8ae445766f Upgrade Ember to 2.13 2017-06-15 10:12:07 -04:00
Arpit Jalan 4112c2b883 Update translations 2017-06-12 21:24:40 +05:30
Guo Xiang Tan e888369f51 UX: Don't send emails for discobot notifications. 2017-06-12 17:00:27 +09:00
Guo Xiang Tan a7ed6bd9e1 Use `User#username_lower` instead. 2017-06-12 10:58:31 +09:00
Robin Ward d8ba1c66d5 FIX: Don't fail seed if avatar can't be downloaded 2017-06-09 11:01:48 -04:00
Régis Hanol 6997925a52 Merge pull request #4910 from jomaxro/patch-2
Add missing URL
2017-06-08 14:00:37 +02:00
Guo Xiang Tan 977bbb1f45 FIX: Bot mentioned check should be case insensitive. 2017-06-08 19:00:07 +09:00
jomaxro dbaf7ad052 Add missing URL 2017-06-08 00:14:20 -04:00
Guo Xiang Tan 677fbc783d Fix randomly failing spec. 2017-06-08 05:47:44 +09:00
Arpit Jalan d326784ecf Update translations 2017-06-07 20:13:54 +05:30
Guo Xiang Tan 17c29c972b Move the constant as well. 2017-06-06 15:38:26 +09:00
Guo Xiang Tan c1dc6f6cd7 FIX: Track should only continue if user is alone with bot in a PM. 2017-06-06 09:47:00 +09:00
Guo Xiang Tan 30f2758404 FIX: Ensure that we cancel any timeout jobs when terminating a track. 2017-06-05 16:23:25 +09:00
Guo Xiang Tan 3621647fb5 FIX: Bot should only respond to regular posts. 2017-06-05 15:21:19 +09:00
Guo Xiang Tan cd2869c767 Revert "Skip validations when Discobot creates new posts."
This reverts commit ca7e906774.

Post validations are already skipped for admin users. Skipping
validations cause polls to not work.
2017-06-03 07:18:23 +09:00
Guo Xiang Tan 418cb09713 Ensure that we skip validations when creating a post on behalf of a user. 2017-06-03 07:15:08 +09:00
Neil Lalonde ceedec894d fix narrative bot for subfolder in translation files 2017-06-02 10:07:16 -04:00
Neil Lalonde 23dfddbfb4 FIX: narrative bot on subfolder installs 2017-06-01 15:15:34 -04:00
Guo Xiang Tan edbb876d1b FIX: Discobot welcome post delay should start counting when a user logs in. 2017-06-01 21:02:29 +09:00
Guo Xiang Tan ae5cc217cd Avoid monkey patching which causes weird reloading error in dev. 2017-06-01 12:06:25 +09:00
Neil Lalonde e22d88c91d Add Franch and Slovak translations for narrative bot 2017-05-31 13:56:41 -04:00
Arpit Jalan 304090f759 Update translations 2017-05-31 22:36:20 +05:30
Guo Xiang Tan ca7e906774 Skip validations when Discobot creates new posts. 2017-05-31 17:51:05 +09:00
Guo Xiang Tan 4144ea34a2 Rename a test file. 2017-05-31 06:38:38 +09:00
Arpit Jalan da23c446c0 fix the build 2017-05-29 13:22:04 +05:30
Arpit Jalan 266acbcc6c Update Translations 2017-05-29 12:23:49 +05:30
Guo Xiang Tan 7ffdb6be75 Switch to a unicorn image that we know is free for commercial use.
* Source: https://pixabay.com/en/unicorn-galaxy-unicorn-galaxy-star-2007257/
2017-05-29 10:24:25 +08:00
Guo Xiang Tan 56f98de7b2 Use webmock to stub external web requests. 2017-05-26 15:19:09 +08:00
Guo Xiang Tan 144b810d0e Missed a spot when redefining a method. 2017-05-26 13:02:41 +08:00