8d34f4bbd9
Revert "Revert Ember.run refactors"
...
This reverts commit fcb1ca52f9
2019-10-30 09:48:24 -04:00
fcb1ca52f9
Revert Ember.run refactors
...
This reverts commit 5ca60fcb6b
2019-10-29 17:10:47 -04:00
5ca60fcb6b
REFACTOR: Use imports for `Ember.run`
2019-10-29 15:31:56 -04:00
7744b636e9
FIX: Handle nil case for avatar, just in case
2019-10-24 14:02:51 -04:00
8b4e71cb21
FIX: Allow avatar downloads to follow redirects
2019-10-24 14:01:54 -04:00
2c0efac25e
FIX: Broken certificates
2019-10-24 12:39:58 -04:00
690db4fd36
FIX: Show poll voters in Oneboxed posts. ( #7768 )
2019-10-24 14:00:25 +03:00
6287eccb35
REFACTOR: Remove `Ember.Controller` in favor of import
2019-10-23 13:06:54 -04:00
a8a76198b1
REFACTOR: Remove `Ember.Component` global variable
...
Use imports instead.
2019-10-23 12:30:52 -04:00
835d2be4da
FIX: Rate limit and hijack certificate generation. ( #8215 )
...
To eliminate a DDOS attack vector, we're taking the following measures:
The endpoint will be rate-limited to 3 requests every 60 seconds (per user).
A 24 hours max-age cache header is sent with the response.
The route will be hijacked to generate the certificate in the background.
2019-10-21 13:14:15 -03:00
54bc2bdba7
UX: emphasizes on local-dates being UTC in excerpts ( #8208 )
2019-10-17 10:18:06 -04:00
4338515a85
fix poll test
2019-10-16 21:53:37 -04:00
b005377d0a
UX: add newline after closing poll tag for poll builder
2019-10-16 21:40:42 -04:00
74207ef03a
Refactor `search_answer` to be dynamically inserted so it can be changed
2019-10-16 14:37:17 -04:00
a37dafdd4d
FIX: Use the quote generator in the example text
...
This way if a plugin customizes the quotes the example will match.
2019-10-16 13:40:44 -04:00
e2f9b7dd6f
FIX: Narrative Bot certificates are ERB templates ( #8174 )
...
There are at least two ways of rendering templates outside of the controller. The first one is Rails way enabled with Rails 5 https://evilmartians.com/chronicles/new-feature-in-rails-5-render-views-outside-of-actions
The downside of this method is that all variables need to be passed as params (I could find a way to pass the whole context)
Another way is to use instance_eval described in Erubi documentation
https://github.com/jeremyevans/erubi#usage - it works perfectly fine, however, I didn't feel very confident about using eval unless necessary.
An additional benefit of using `ApplicationController.render` is that if Rails would change the ERB engine in the future, this code should still work.
If you want to test it on your local, you need to be signed in and then that two URLs are generating certificates:
http://localhost:3000/discobot/certificate.svg?date=Oct+07+2019&type=standard&user_id=1
http://localhost:3000/discobot/certificate.svg?date=Oct+07+2019&type=advanced&user_id=1
Dev: https://dev.discourse.org/t/discourse-narrative-bot-should-not-be-storing-giant-strings/17130
2019-10-09 17:45:01 +11:00
3dfe9f3b8d
Update translations
2019-10-08 12:25:24 +02:00
f5d391a48a
REFACTOR: Move `app-events:main` to `service:app-events` ( #8152 )
...
AppEvents was always a service object in disguise, so we should move it
to the correct place in the application. Doing this allows other service
objects to inject it easily without container access.
In the future we should also deprecate `this.appEvents` without an
explicit injection too.
2019-10-04 10:06:08 -04:00
5a919c2211
DEV: use 'user_created' discourse event instead of 'after_commit' model callback.
2019-10-04 10:48:49 +05:30
427d54b2b0
DEV: Upgrading Discourse to Zeitwerk ( #8098 )
...
Zeitwerk simplifies working with dependencies in dev and makes it easier reloading class chains.
We no longer need to use Rails "require_dependency" anywhere and instead can just use standard
Ruby patterns to require files.
This is a far reaching change and we expect some followups here.
2019-10-02 14:01:53 +10:00
45ff119f27
FIX: Try to match advanced tutorial reset first ( #8048 )
...
Advanced trigger is currently broken on:
ca
es
et
fr
he
it
pt_BR
And that is because the translation levels for the plugin are kinda low, so I would guess it's broken for half the languages.
Since we have only two tracks for a while now, a quick fix to me is inverting the selectors.
This patch works because the advanced key is "larger" than the new user one.
2019-10-02 11:55:47 +10:00
8adec48b33
Update translations
2019-09-26 04:29:44 +02:00
0d22beb81d
FIX: Improve Onebox detection ( #8019 )
...
Follow-up to 7c83d2eeb2
2019-09-10 13:59:48 +03:00
27f7bd4273
UX: adjusts RTL composer presence avatar alignment
...
context: https://meta.discourse.org/t/user-is-typing-misaligned-and-mixed-with-reply-choices-with-rtl/127963
This commit adds a temporary fix for presence avatar overlap in the composer for RTL.
More context on TMP here: https://meta.discourse.org/t/moving-the-voting-box-to-the-right-side-of-the-screen/126752
2019-09-09 20:47:29 +08:00
930e70aba9
Update translations
2019-09-04 10:24:43 -04:00
1e89939383
DEV: Added wrapper to signal that NewPostManager#add_plugin_payload_attribute is part of the public API
2019-08-29 11:58:19 -03:00
8841563f8a
Update translations
2019-08-26 14:36:46 +02:00
bf05a8da96
FEATURE: adds countdown attribute to [date] ( #8037 )
...
When used, dates will be displayed as a countdown in a human friendly way.
2019-08-24 11:39:20 -05:00
6b621ceb06
DEV: consistent plugin nomenclature.
2019-08-22 11:08:06 +05:30
75f37ac16a
Rename `lazyYT` plugin directory name to `lazy-yt`
2019-08-21 14:35:14 +05:30
096f932ef2
Lint files
...
Both needed some prettier tlc
2019-08-16 13:06:51 +10:00
69498a58e9
FEATURE: Staff only poll results ( #7984 )
...
* FEATURE: Staff only poll results
These changes allow only staff to see the results of a poll.
Non-staff users will be shown a screen like this:
1b8bd76013
2019-08-15 12:27:18 -06:00
79957706b1
FIX: Store custom attributes that are needed by plugins in queuedpost payload ( #8009 )
2019-08-14 15:02:59 -03:00
c628166bb4
FIX: replace model usage with SQL query
...
Follow-up to b500ef77
2019-08-13 18:32:24 +02:00
6a65e5312b
FEATURE: Add a preview to the poll builder ( #7988 )
...
* FEATURE: Add a preview to the poll builder
* Use selectKit helper in the poll preview test
* Extract the mobile-specific poll builder form CSS
2019-08-13 09:49:40 -04:00
b500ef77d7
Poll migration is not idempotent ( #7964 )
...
The migration script is not idempotent due to database constrains on the
poll related objects, namely:
polls: index_polls_on_post_id_and_name (post_id,name) UNIQUE
poll_options: index_poll_options_on_poll_id_and_digest (poll_id,digest) UNIQUE
poll_votes: index_poll_votes_on_poll_id_and_poll_option_id_and_user_id (poll_id,poll_option_id,user_id) UNIQUE
This change skips a particular poll migration if it's already found on
the db.
2019-08-08 18:48:53 +02:00
636b6c3a5a
FIX: Wrong discobot tutorial started for certain locales.
...
If a locale has triggers that start with the same word, our regexp will
always end up matching the first trigger. For example,
`start tutorial` and `start tutorial advanced`
To support the change, we have to make the match on triggers more
restrictive. `@discobot quote here` will no longer work like `@discobot
quote`.
2019-08-08 10:53:58 +08:00
b574276e6e
DEV: Correct hardcoded value in discobot tests.
2019-08-08 10:53:58 +08:00
78500fb770
UX: Improve layout of poll builder modal
2019-08-07 15:00:03 -04:00
f4543ff02a
FIX: ensures pikaday picker is showing in UTC ( #7968 )
2019-08-06 08:41:38 +02:00
a68d8de72f
UX:UX: Use shorter weekday labels in local-dates plugin
2019-08-05 14:21:59 +02:00
1267185a07
DEV: Remove unused option.
...
Follow up to 18ed03e044
2019-07-30 21:12:13 +08:00
18ed03e044
Clarify how to start a tutorial
...
https://meta.discourse.org/t/does-the-advanced-user-tutorial-still-exist/123661/14
2019-07-30 21:10:22 +08:00
a0df4c3757
UX: prevents cooked dates from wrapping ( #7954 )
2019-07-30 14:04:30 +08:00
c1d2fb115c
DEV: prevents staff computed property to be overridden ( #7931 )
2019-07-24 22:01:08 +02:00
97e9599ecc
Update translations
2019-07-15 09:43:22 -04:00
bfbd97d3b5
Remove extra whitespaces from locale files
...
Co-authored-by: Gerhard Schlager <mail@gerhard-schlager.at>
2019-07-04 13:48:17 +02:00
a5e80079d6
FEATURE: Add Belarusian language
2019-07-04 11:37:37 +02:00
463db22928
DEV: Add test.
...
Follow-up to bccd090ced
2019-06-26 16:37:01 +03:00
bccd090ced
SECURITY: Escape email text for posts containing [details].
2019-06-26 16:28:31 +03:00
7e884cce6b
Update translations
2019-06-25 10:57:18 -04:00
dbc59cfe61
Update translations
2019-06-17 13:25:37 -04:00
32cd9ba59b
FIX: ensures local-dates modal is not taking full height on mobile ( #7772 )
2019-06-16 08:48:07 +02:00
a8793d0d9a
REFACTOR: Test Memory Usage Fixes ( #7769 )
...
* Calling `Discourse.reset()` creates a new container
We should run our de-initializers only after acceptance tests,
since initializers are not run outside of acceptance tests anyway,
and the container at this point can be passed properly to the
`teardown()` method.
* Remove `Discourse.reset` from tests
This would cause a new container to be created which leaks many objects.
* `updateCurrentUser` is more accurate than `replaceCurrentUser`
2019-06-14 14:54:20 +02:00
c322cccd53
FIX: Memory Leaks when decorating posts ( #7749 )
...
* Remove long-deprecated method
* FIX: Memory Leaks when decorating posts
Previously we'd keep creating mixins dynamically when decorating the
same class.
This code changes the API to recommend an `id` parameter for each
decorator which will avoid leaks. All plugins should be updated to
include this parameter, although if they don't in the meantime it'll
just mean a warning in the console (and a continued leak.)
2019-06-11 17:21:23 +02:00
5d7e34e0ad
Update translations
2019-06-10 10:36:08 -04:00
84e5d58a0d
DEV: make prettier 💅 happy
2019-06-06 12:28:41 +02:00
c131903e56
FIX: clone dateTime before changing timezone
2019-06-06 11:16:58 +02:00
b339d67401
DEV: refactors select-kit helper to prevent it to leak into global state ( #7708 )
2019-06-06 10:47:10 +02:00
70b73c2159
DEV: Use proper heredoc name.
2019-06-04 16:31:18 +08:00
63e3d49508
DEV: Add test for poll plugin reduce_excerpt.
2019-06-04 16:30:15 +08:00
dbfdce95c9
Update translations
2019-05-30 10:40:16 -04:00
dc43828905
add trust level blog link to discobot PM welcome
2019-05-29 18:19:35 -07:00
0df5349dbf
FIX: ensure the post url is present
...
Also don't interpolate a string
2019-05-30 00:05:53 +02:00
a188d15b08
FIX: reduce poll when post is nil
2019-05-30 00:02:33 +02:00
227c45107d
FEATURE: Implement Onebox for posts including polls. ( #7539 )
2019-05-29 17:05:52 +02:00
1efed6e527
DEV: amend test for anonymous handling to use real data
...
Previously we relied on fabrication on anonymous, we can not get the
transaction commit pipeline to work as it does in production, cleanly
This amends it so our anonymous user is created using the core APIs
Signed-off-by: Sam Saffron <sam.saffron@gmail.com>
2019-05-29 15:05:37 +10:00
3a1d99577e
FIX: Replace details content with instruction.
2019-05-29 08:36:04 +08:00
b98b994fe7
apply prettier on plugins ( #7605 )
2019-05-27 11:06:11 +02:00
bfea922167
DEV: global s/this.get\("(\w+)"\)/this.$1 ( #7592 )
2019-05-27 10:15:39 +02:00
edc6ac0c66
Update translations
2019-05-21 00:04:37 +02:00
0afcad148a
DEV: Always use %{count} in pluralized strings
2019-05-20 23:26:22 +02:00
b788948985
FEATURE: English locale with international date formats
...
Makes en_US the new default locale
2019-05-20 13:47:20 +02:00
a58aa9b4bf
Update translations
2019-05-20 13:42:05 +02:00
3c1fa3910f
DEV: track the correct channel in specs
...
These tests are erratically failing due to distributed cache messages that
can land between tests
Ensure we are only looking for the correct messages
2019-05-20 18:27:09 +10:00
aeb7143aff
DEV: correct flaky poll specs
...
They were relying on a pristine message bus, however current implementation
still uses redis, stuff can get held up and we can end up publishing
distributed cache messages in the middle invalidating the tests
2019-05-17 16:16:02 +10:00
5605dba85c
DEV: Automatically annotate plugin models alongside core models
2019-05-13 16:37:47 +01:00
c00dab89e4
Fix the build take 2.
2019-05-13 11:22:48 +08:00
9059a8ca90
Fix the build.
2019-05-13 10:16:26 +08:00
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
41f4f9302d
UX: Rename discobot tutorial triggers.
...
We found the previous triggers less straight forward than just calling
it tutorial.
`start new user` -> `start tutorial`
`start new advanced user` -> `start advanced tutorial`
2019-05-10 09:08:16 +08:00
f3a346464e
FIX: allTimezonesd was mistakenly removed ( #7513 )
2019-05-09 10:22:54 +02:00
c72f16d927
Follow up to 329969ea20.
2019-05-08 15:36:12 +08:00
329969ea20
FIX: Discobot mention tutorial should be case insensitive.
2019-05-07 10:54:22 +08:00
61cc0f8c5f
Follow up to 152238b4cf.
2019-05-07 09:57:27 +08:00
152238b4cf
DEV: Prefer `public_send` over `send`.
2019-05-07 09:33:21 +08:00
1d784c7a18
FEATURE: adds support for dates in polls ( #7450 )
2019-04-29 10:01:19 +02:00
d5d784b9f2
FIX: Narration Bot now gets site setting for automatic post deletion ( #7432 )
2019-04-25 07:29:20 +08:00
0284910125
Update translations
2019-04-24 15:02:04 +02:00
21b975e71a
FIX: Broken plugin spec
2019-04-23 15:29:26 -04:00
99efd12376
FIX: Url in Russian translation
2019-04-18 17:10:58 -04:00
5c8213ffd3
removes debugging statement ( #7362 )
2019-04-11 15:02:38 +02:00
7dd684744c
UX: sets min date on calendar when initial date is set ( #7361 )
2019-04-11 14:37:39 +02:00
46dc38e5a5
UX: minor local-dates form improvements ( #7360 )
2019-04-11 14:03:53 +02:00
7226240df3
UX: full revamp of local-dates form ( #7357 )
2019-04-11 11:14:34 +02:00
ad5edc8bb1
UX: copy and formating improvements to local-dates form ( #7343 )
2019-04-09 10:33:01 +02:00
e50e4b6cc6
Make Prettier happy
2019-04-08 12:03:41 -04:00
5957991340
FIX: Remove quoted post text and block realtime replies from ignored users ( #7336 )
2019-04-08 17:44:42 +02:00
5e68c5f851
UX: moves local-dates from popupMenu to toolbar ( #7335 )
2019-04-08 15:52:09 +02:00
e7a6f0698d
Update translations
2019-04-05 10:02:54 -04:00
3cf922a58a
FIX: URL to user profile in poll results. ( #7315 )
2019-04-03 22:17:05 +02:00
b360d4289e
UX: get rid of preview_for ( #7314 )
2019-04-03 10:09:25 +02:00
02d8931425
UX: more compact local-dates preview ( #7305 )
2019-04-02 14:39:20 +02:00
d81f3ee2c2
FIX: improves DST support of dates when recurrence is used ( #7297 )
2019-04-01 12:19:09 +02:00
fd6513b516
FIX: Incorrect API in narrative bot
2019-03-28 14:29:33 -04:00
c44371b4ac
FIX: Broken spec
2019-03-28 13:55:04 -04:00
b58867b6e9
FEATURE: New 'Reviewable' model to make reviewable items generic
...
Includes support for flags, reviewable users and queued posts, with REST API
backwards compatibility.
Co-Authored-By: romanrizzi <romanalejandro@gmail.com>
Co-Authored-By: jjaffeux <j.jaffeux@gmail.com>
2019-03-28 12:45:10 -04:00
9a56b398a1
UX: improves local-dates form ( #7268 )
2019-03-28 16:34:56 +01:00
4a7e83d880
Update translations
2019-03-28 10:07:51 -04:00
d43f4206c7
FEATURE: Add Armenian language
2019-03-28 14:24:14 +01:00
b5e32cfe2a
DEV: correct spec to test for correct fidelity
...
This is due to 9ebabc1d
2019-03-28 17:45:36 +11:00
4874cf742b
FIX: better styling with popover ( #7259 )
2019-03-26 16:34:27 +01:00
52332ccd72
FIX: uses aria-label instead of title as it's useless with popover ( #7258 )
2019-03-26 16:31:48 +01:00
8fb63b2706
FEATURE: unified popover implementation ( #7244 )
2019-03-26 15:43:27 +01:00
34b871a86c
Missing translation key
2019-03-19 12:51:10 -04:00
9334d2f4f7
FEATURE: add more granular user option levels for email notifications ( #7143 )
...
Migrates email user options to a new data structure, where `email_always`, `email_direct` and `email_private_messages` are replace by
* `email_messages_level`, with options: `always`, `only_when_away` and `never` (defaults to `always`)
* `email_level`, with options: `always`, `only_when_away` and `never` (defaults to `only_when_away`)
2019-03-15 10:55:11 -04:00
fa5a158683
REFACTOR: Move `queue_jobs` out of `SiteSetting`
...
It is not a setting, and only relevant in specs. The new API is:
```
Jobs.run_later! # jobs will be thrown on the queue
Jobs.run_immediately! # jobs will run right away, avoid the queue
```
2019-03-14 10:47:38 -04:00
b0c8fdd7da
FIX: Properly support defaults for upload site settings.
2019-03-13 16:36:57 +08:00
d1d9a4f128
Add new `run_jobs_synchronously!` helper for tests
...
Previously if you wanted to have jobs execute in test mode, you'd have
to do `SiteSetting.queue_jobs = false`, because the opposite of queue
is to execute.
I found this very confusing, so I created a test helper called
`run_jobs_synchronously!` which is much more clear about what it does.
2019-03-11 16:58:35 -04:00
9c54447ca7
Update translations
2019-03-11 13:55:45 -04:00
44a43878a5
FIX: lightbox wrapper within open details should show.
2019-03-08 15:07:22 -08:00
6420b73c33
FIX: Changed poll age message to upcase ( #7124 )
2019-03-07 11:04:17 +01:00
be5e889b1b
UX: Poll style fix, button classes
2019-03-06 20:27:40 -05:00
aabc3375c6
Update translations
2019-03-01 11:28:07 -05:00
6b006c383b
FIX: polls acceptance tests
2019-02-27 19:16:24 +01:00
0a708ba064
FIX: preload poll voters
2019-02-27 17:00:21 +01:00
9bf11a7c02
FEATURE: Add localized timezone names ( #7004 )
...
Uses github.com/discourse/moment-timezone-names-translations to translate timezone names.
Plugins can also provide their own timezone name translations.
2019-02-25 14:40:02 -05:00
5952a6c0ad
DEV: uses find() helper instead of this.$() in js tests ( #7062 )
2019-02-25 16:04:55 +01:00
79841cf7dd
FEATURE: add missing autocomplete suppressions
...
Following 1f4ace4f
2019-02-21 16:37:26 +11:00
c08b2ddecf
FIX: stricter matching on local-dates ( #7023 )
2019-02-18 22:39:45 +01:00
c719658f9f
`human?` helper method on a user
...
This is cleaner than hard coding `id > 0` in ruby code.
2019-02-08 13:34:54 -05:00
55cc5ab4b8
Update translations
2019-02-07 09:49:57 -05:00
a342d2f150
UX: reduces white-space in polls ( #6956 )
...
* reduces white-space in polls and uses font-size variables
2019-02-05 10:47:22 +01:00
6bfd2b6eaf
Update translations
2019-01-31 16:27:07 -05:00
3c5fbd3ce1
FIX: do not send welcome message to staged users
2019-01-30 18:03:16 -05:00
f7b7bc8abe
DEV: move 'default_scope' to default sort on 'has_many' relation
2019-01-30 17:45:50 +01:00
024ba28525
Update translations
2019-01-28 10:27:20 -05:00
671ff4243f
FIX: discourse-poll-option test wasn't working
2019-01-24 14:55:36 +01:00
cba6bdaf52
UX: use solid circle to indicate selected option in polls
2019-01-24 12:25:37 +01:00
d589c66f3e
FIX: Fix URL to user profile. ( #6881 )
2019-01-23 18:27:21 +01:00
80d42b4ea2
icons deprecations fixes ( #6920 )
2019-01-22 12:02:02 +01:00
ba5e17a7a9
FIX: IE11 layout glitches
...
IE11 requires a unit on the third parameter (flex-basis) of the flex property
2019-01-21 13:40:55 -05:00
444bc466b0
for docs, normalize on space after code fence when specifying lang
2019-01-21 01:19:28 -08:00
90823eaca6
Update translations
2019-01-19 23:41:52 +01:00
502b1316d0
DEV: s/this._super()/this._super(...arguments) ( #6908 )
2019-01-19 10:05:51 +01:00
78730062de
Fix prettier offence in local-dates plugin
2019-01-17 14:22:35 -05:00
9703fa2abc
UX: improves dates display in emails ( #6805 )
2019-01-16 12:53:41 +01:00
81953339f2
Update translations
2019-01-14 12:23:49 -05:00
098b6d9364
remove bullets on discobot oneboxing step
2019-01-13 04:33:32 -08:00
1a3655b787
DEV: s/Em/Ember ( #6874 )
2019-01-11 17:54:23 +01:00
Robin Ward
Bianca Nenciu
Roman Rizzi
Joffrey JAFFEUX
Kris
Krzysztof Kotlarek
Gerhard Schlager
Vinoth Kannan
Rafael dos Santos Silva
Joe
Neil Lalonde
Arpit Jalan
Sam Saffron
Blake Erickson
Régis Hanol
Jarek Radosz
Eduardo Poleo
Guo Xiang Tan
Penar Musaraj
Ned Batchelder
AhmadF.Cheema
Bianca Nenciu
Jeff Atwood
David Taylor
Tim Lange
Tarek Khalil
Jeff Wong
Joe
