Commit Graph

362 Commits

Author SHA1 Message Date
Guo Xiang Tan 2f14a81fa4
FIX: `min` setting should be greater than 0 for multiple type polls. 2016-06-07 10:48:06 +08:00
Guo Xiang Tan a849fae5ee Add specs for polls (#4246)
* Extract validation logic into a service object.

* Extract logic for updating polls custom fields into a service object.

* Use `strip_heredoc` instead.

* FIX: Polls do not update when configuration has been changed.
2016-06-06 17:04:56 +02:00
Arpit Jalan 4f4c1b54ba Update Translations 2016-06-04 00:15:03 +05:30
Arpit Jalan e489af0b50 add Estonian language files 2016-06-01 15:25:21 +05:30
Neil Lalonde 7050042088 Update translations 2016-05-26 11:50:15 -04:00
Robin Ward 7c0fb41ec0
Deprecation: Use `Ember.Helper` for later versions of Ember 2016-05-11 14:26:09 -04:00
Arpit Jalan e8623ccd92 Update Translations 2016-05-09 23:39:52 +05:30
Robin Ward 9ea32bf7d8
Deprecation: Change `{{#each x in y}}` to `{{#each y as |x|}}` 2016-05-04 16:18:09 -04:00
Neil Lalonde b1f798f119 Update translations 2016-05-04 14:22:15 -04:00
Gerhard Schlager f1bc7de541
Adds support for anonymous votes to the poll plugin 2016-04-23 22:44:09 +02:00
Neil Lalonde e63e296761 Update translations 2016-04-20 19:18:07 -04:00
Robin Ward e91379916b
FIX: Provide the ability to `reduce` cooked content
This allows us to strip polls from the group posts page.
2016-04-13 13:25:18 -04:00
Neil Lalonde a2501bfee5 Update Translations 2016-04-07 12:11:30 -04:00
Robin Ward ef4877e009 FIX: Stability issues with multiple polls 2016-03-28 12:17:37 -04:00
Arpit Jalan ddebd76c44 Update Translations 2016-03-23 22:25:29 +05:30
Manel Villar 6a2fe44e51 Support for Galician language added 2016-03-22 16:42:54 +01:00
Régis Hanol 6c579ba932 FIX: close existing polls in closed topics to keep old behaviour 2016-03-21 23:09:36 +01:00
Régis Hanol b575f97ece FIX: allows polls on closed topics 2016-03-21 12:12:25 +01:00
Neil Lalonde 9f30a28a8e Update translations 2016-03-17 11:01:02 -04:00
Arpit Jalan bdb290ccdb Update Translations 2016-03-07 19:44:32 +05:30
Robin Ward 026bba1876 Merge branch 'master' into vdom 2016-02-22 15:28:07 -05:00
Neil Lalonde 7e39619bc9 Update translations 2016-02-22 11:10:12 -05:00
Sam c404da248a Merge branch 'master' into vdom 2016-02-22 12:20:59 +11:00
Sam 5a47199528 Merge pull request #3947 from khoa-le/update-locale-vietnamese
Add locale for Vietnamese
2016-02-22 11:41:37 +11:00
Robin Ward 6935925f10 Update Polls plugin to work with new Plugin API 2016-02-18 15:23:43 -05:00
Neil Lalonde 71a87bea0c Update translations 2016-02-04 13:35:14 -05:00
Arpit Jalan bcc0ed7c9c Update Translations 2016-02-02 15:24:01 +05:30
Arpit Jalan 915afa703d Update Translations 2016-01-26 23:41:00 +05:30
Khoa, Le Ngoc 06e637fc4a Merge remote-tracking branch 'upstream/master' into update-locale-vietnamese
* upstream/master: (185 commits)
  SECURITY: Upgrade rails.
  FIX: new user summary page was broken
  Version bump to v1.5.0.beta9
  Remove addressable from Discourse.
  UX: change glyph when inviting existing user to a topic
  FIX: Allow for large free disk space
  Revert "FIX: disk_space should be a BigDecimal to handle large disk (closes #3923)"
  UX: improve styling of messages and mobile view of messages
  FIX: correct counts on user summary
  FIX: link to filtered down list of badges from summary FEATURE: pick featured badges in summary page
  FIX: do not allow new email to be duplicate FIX: return proper error message when email already exists
  retain unactivated accounts a bit longer default
  FEATURE: blocked users can send and reply to private messages from staff
  Remove Arel patch that has been merged upstream.
  correct path
  little typo
  FIX: Missing tag in CSS.
  PERF: remove 10-20ms of work from every page view
  FIX: remove green background for wiki (this can be re-added via a customization if needed)
  Hotfix for unsubscribe via email
  ...

# Conflicts:
#	.tx/config
2016-01-26 12:44:29 +07:00
Khoa, Le Ngoc 003399bf96 Update translation code 2016-01-22 14:54:48 +07:00
Régis Hanol fc3bedaaed Merge pull request #3921 from gschlager/locale-sk
Add Slovak locale
2016-01-20 15:38:48 +01:00
Arpit Jalan bfa4e6b69c Update Translations 2016-01-19 01:29:19 +05:30
Régis Hanol fc92166d5f FIX: when rouding numbers in poll resuls, *don't* select a never-been-voted-for option to round up from zero 2016-01-14 01:59:46 +01:00
Neil Lalonde d732c0876a Update translations 2016-01-08 15:50:00 -05:00
Sam Saffron 57944a0694 PERF: only subscribe to a topic once for polls
in the past as views were created and destroyed poll subscriptions would change

this caused a lot of load on messaging bus and uneeded traffic
2016-01-06 20:36:09 +11:00
Arpit Jalan 593c22eda1 Update Translations 2016-01-04 21:01:49 +05:30
root e0ffce1cad Add locale for Vietnamese 2016-01-03 10:05:28 +00:00
Arpit Jalan 90d15ba588 Update Translations 2015-12-29 23:16:17 +05:30
Arpit Jalan 47410f1b99 Update Translations 2015-12-23 17:01:43 +05:30
Neil Lalonde fe10f3e0a3 Update translations 2015-12-18 10:48:02 -05:00
Gerhard Schlager e56f8fa471 Add Slovak locale 2015-12-14 21:55:36 +01:00
Arpit Jalan b227897c44 Update Translations 2015-12-07 23:29:32 +05:30
Régis Hanol 72e7271687 FIX: '.intersect?' isn't available in older version of ruby 2015-12-02 17:25:01 +01:00
Régis Hanol f4184aea33 FIX: properly re-compute # of voters in multiple-choice polls 2015-12-02 12:33:34 +01:00
Andy Waite 3e50313fdc Prepare for separation of RSpec helper files
Since rspec-rails 3, the default installation creates two helper files:
* `spec_helper.rb`
* `rails_helper.rb`

`spec_helper.rb` is intended as a way of running specs that do not
require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's
current `spec_helper.rb` does).

For more information:

https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files

In this commit, I've simply replaced all instances of `spec_helper` with
`rails_helper`, and renamed the original `spec_helper.rb`.

This brings the Discourse project closer to the standard usage of RSpec
in a Rails app.

At present, every spec relies on loading Rails, but there are likely
many that don't need to. In a future pull request, I hope to introduce a
separate, minimal `spec_helper.rb` which can be used in tests which
don't rely on Rails.
2015-12-01 20:39:42 +00:00
Arpit Jalan 04593b8fef Update Translations 2015-12-01 01:09:45 +05:30
Régis Hanol 08ae5f89bd FIX: rounding issue might appear when summing up all the decimals 2015-11-30 11:24:25 +01:00
Régis Hanol 96cd36e86d FIX: properly compute the number of voters using only valid options 2015-11-30 11:23:38 +01:00
Régis Hanol 68a44a1d59 FIX: use an algorithm that doesn't re-order percentages when rounding them up to 100% in single choice polls 2015-11-25 00:14:24 +01:00
Régis Hanol 4f25278b39 FIX: round down percentages when using multiple choices polls 2015-11-23 15:28:24 +01:00
Arpit Jalan bde05fd334 Update Translations 2015-11-23 19:25:06 +05:30
Régis Hanol 9d2128dad3 FIX: don't round up to 100% when using multiple choices poll 2015-11-23 11:34:24 +01:00
Arpit Jalan 6ec336e56f Update Translations 2015-11-20 23:26:48 +05:30
Régis Hanol 32b6ccd622 FIX: properly round % so they add up to 100 in polls 2015-11-19 18:23:38 +01:00
Arpit Jalan 951bfb6186 Update Translations 2015-11-09 21:14:02 +05:30
Arpit Jalan a44c2f6ea3 Update Translations 2015-11-02 17:49:57 +05:30
Arpit Jalan 574805b682 Update Translations 2015-10-30 18:16:52 +05:30
Arpit Jalan c3cadbb4d8 Update Translations 2015-10-26 22:38:34 +05:30
Régis Hanol 515fc49727 FIX: replace polls with a link in emails 2015-10-22 19:10:07 +02:00
Arpit Jalan 717be06f17 Update Translations 2015-10-20 23:11:42 +05:30
Neil Lalonde 131e7ed445 fix MergePollsVotes migration 2015-10-16 13:54:41 -04:00
Régis Hanol 8f2b002203 FIX: a poll option cannot be voted more than 100% of the time 2015-10-16 17:18:22 +02:00
Arpit Jalan 06f616792d Update Translations 2015-10-15 18:19:04 +05:30
Arpit Jalan 43cd0912e6 Update Translations 2015-10-11 02:11:28 +11:00
Neil Lalonde 1e5ad6f219 Update translations 2015-10-02 10:40:28 -04:00
Arpit Jalan a2e8e5f90b Update Translations 2015-09-29 12:30:01 +05:30
Gerhard Schlager bb52042b46 FIX: Add missing pluralization keys to poll plugin locale 2015-09-27 21:36:57 +02:00
Régis Hanol 2e76c9165a FIX: polls are always editable until the first vote 2015-09-25 18:54:15 +02:00
Régis Hanol cc75890cd4 UX: disable 'Hide results' button when poll is closed 2015-09-16 13:01:08 +02:00
Régis Hanol 26c743a962 FIX: disable poll dialect when poll plugin is disabled 2015-09-14 20:11:03 +02:00
Régis Hanol 60bbd81607 FIX: polls with votes were preventing users from updating the post 2015-09-14 19:27:54 +02:00
Arpit Jalan b8c3187a94 Update Translations 2015-08-31 22:19:30 +05:30
Arpit Jalan e1575746f2 Update Translations 2015-08-20 17:33:13 +05:30
Arpit Jalan 73f547b019 Update Translations 2015-08-10 23:41:05 +05:30
Sam d16de4a0a1 correct polls spec 2015-08-05 12:39:38 +10:00
Arpit Jalan e53bf294ef Update Translations 2015-08-04 13:17:39 +05:30
Régis Hanol 969f6ad1d0 Revert "make polls unselectable"
This reverts commit 9b819d9245.
2015-07-31 12:46:30 +02:00
Jeff Atwood 9b819d9245 make polls unselectable
https://meta.discourse.org/t/disabling-text-selection-in-polls/31586
2015-07-31 03:43:07 -07:00
Régis Hanol 233cdc011d FIX: disable text selection in polls 2015-07-31 12:42:53 +02:00
Arpit Jalan 62a59ef7c0 Update Translations 2015-07-30 22:41:12 +05:30
Arpit Jalan e01d196bda Update Translations 2015-07-22 22:57:18 +05:30
Luke GB 9f31c3d235 Expose poll_maximum_options to client
At present this doesn't actually seem to be exposed to the client.

I discovered this by accident whilst trying to write my own plugin:

7b6d6b76eb/app/models/site_setting.rb (L17-L18)
2015-07-19 21:41:14 +01:00
Arpit Jalan fc977771a3 Update Translations 2015-07-16 19:18:02 +05:30
Sam 00aaa692ac Merge pull request #3574 from gschlager/patch-2
FIX: Remove invalid translation keys from polls plugin
2015-07-15 16:53:37 +10:00
Arpit Jalan 63b5a6c4e0 Update Translations 2015-07-09 18:57:52 +05:30
Robin Ward 8be37193ee Trivial changes to poll plugin, including a small typo fix. 2015-07-07 10:51:51 -04:00
Kane York af042ffe5e FEATURE: Per-plugin settings buttons, "Enabled" column
Also, added enabled_site_setting to the Poll plugin so it shows up properly.
2015-07-02 10:59:06 -07:00
Neil Lalonde 9a0e4bb96e Update translations 2015-07-01 17:09:37 -04:00
Gerhard Schlager 5eaf95b328 FIX: Remove invalid translation keys from polls plugin
And it changes the file header since it was wrong.
2015-06-28 01:31:03 +02:00
Arpit Jalan db02dbb0da Update Translations 2015-06-26 20:30:13 +05:30
Régis Hanol b25a16ee3e FEATURE: 2 new reports: time to first response, topics with no response
FIX: relativeAgeMediumSpan was off by 1
REFACTOR: extracted decimalAdjust & round functions from the poll plugin
2015-06-22 19:46:51 +02:00
Neil Lalonde 4b6cf528ce update translations 2015-06-19 11:29:13 -04:00
Arpit Jalan 6148ae8775 Update Translations 2015-06-17 22:05:22 +05:30
Arpit Jalan 436e84c6c1 Update Translations 2015-06-15 20:25:53 +05:30
Neil Lalonde d9efb37ec7 Update translations 2015-06-11 15:35:01 -04:00
Arpit Jalan 45a7c314c2 Update Translations 2015-06-03 20:39:08 +05:30
Régis Hanol 7afe78eec0 FIX: don't use a table for poll results 2015-06-03 16:49:20 +02:00
Régis Hanol 50a39f7e98 use bigger bottom padding instead of line-height to vertical center 2015-06-03 12:35:49 +02:00
Régis Hanol 0013a94692 FIX: use pastel color for background of the selected poll options 2015-06-03 12:28:03 +02:00
Jeff Atwood 1a9da9133e switch back to line-height based centering on polls 2015-06-03 02:58:52 -07:00
Régis Hanol c240a8bd80 FIX: make sure we can't vote on deleted polls 2015-06-01 22:31:47 +02:00
Arpit Jalan 1ac4e60c90 Update Translations 2015-06-01 23:33:27 +05:30
Régis Hanol f736b6face FIX: validate poll parameters when type=multiple 2015-06-01 19:28:05 +02:00
Jeff Atwood 9ce6603864 better poll option alignment for multi-line 2015-05-29 16:32:44 -07:00
Arpit Jalan 5880313e84 Update Translations 2015-05-26 20:08:20 +05:30
Robin Ward 78abf85087 FIX: IE9 issues with latest discourse 2015-05-25 12:32:42 -04:00
Arpit Jalan 56544f2048 Update Translations 2015-05-21 00:24:12 +05:30
Régis Hanol 3859273ff7 FIX: prevent span abuse in polls 2015-05-20 15:55:27 +02:00
Régis Hanol d889f05480 changed default 'poll maximum options' to 20 2015-05-19 14:33:27 +02:00
Régis Hanol 764f9b42fe Merge pull request #3458 from Qasem-h/Bosnian
Add Bosnian langage for discourse
2015-05-15 14:34:16 +02:00
Régis Hanol 42be2b431f ooops, we actually need that :fired: 2015-05-15 11:51:10 +02:00
Régis Hanol a3fb2c002c FIX: remove dangerous support for style/background attributes in polls 2015-05-15 11:08:51 +02:00
riking 9d232dac9a FIX: Properly whitelist li styles 2015-05-14 16:43:01 -07:00
Régis Hanol 635b31af7b FIX: editing a post with a poll breaks sometimes 2015-05-14 17:18:45 +02:00
Régis Hanol 7c545537a6 FIX: prevent pollception 2015-05-13 23:12:53 +02:00
Régis Hanol 43755a6fab keep closed status when migrating poll to new style 2015-05-13 22:30:27 +02:00
Régis Hanol 06643fb625 add support for all types of unordered lists in migrate_old_polls 2015-05-13 22:10:02 +02:00
Régis Hanol 4df868a420 FIX: update 'migrate_old_polls' rake task to support more cases
FIX: support list that uses double newlines
FIX: support list that uses spaces before the '-'
FIX: don't break lamentably when a poll wasn't created
2015-05-13 19:56:09 +02:00
Régis Hanol b8005f0b1b FIX: link starting with '[poll' should not break polls 2015-05-13 17:50:25 +02:00
Neil Lalonde 1c5ea5d8ef Update translations 2015-05-12 17:38:49 -04:00
Qasem Hajizadeh a4c69d450e Create server.bs_BA.yml 2015-05-12 16:22:06 +04:30
Qasem Hajizadeh 2ad958b796 Create client.bs_BA.yml 2015-05-12 16:21:49 +04:30
Régis Hanol 3a9907f392 FIX: prevent self-xss in poll attributes 2015-05-11 20:09:17 +02:00
Robin Ward 585583d38c Upgrade polls to Ember 1.11 2015-05-11 11:20:45 -04:00
Robin Ward aee12fd6ef Ember Deprecations for Topics 2015-05-11 11:18:37 -04:00
riking 7238c43018 SECURITY: XSS in poll errors dialog 2015-05-08 19:28:04 -07:00
Régis Hanol 0ded6434df FIX: migrate_old_polls should properly identify olds polls at the end of the post 2015-05-08 19:17:09 +02:00
Régis Hanol c2ffe255c3 FIX: add borders on polls on mobile 2015-05-08 11:13:32 +02:00
Régis Hanol 875a013ec7 FIX: poll design on mobile 2015-05-07 19:49:06 +02:00
Régis Hanol c1bb7bc7cc clarify copy when editing a poll after the first 5 minutes 2015-05-07 17:24:35 +02:00
Régis Hanol 9b0ca60f52 FIX: support quotes for poll parameters 2015-05-07 16:40:14 +02:00
Régis Hanol 78cff468bc FIX: poll options display issues 2015-05-07 15:19:23 +02:00
Régis Hanol 033761d2f6 FIX: reset all votes when the # of options changes 2015-05-06 18:52:09 +02:00
Arpit Jalan ee960899df Update Translations 2015-05-06 21:32:11 +05:30
Régis Hanol 2d3a090060 FIX: poll design on mobile 2015-05-05 20:14:38 +02:00
Régis Hanol 73703dd557 FIX: poll fake 3D button effect with custom background color 2015-05-05 20:00:42 +02:00
Sam b4f666630e make jshint happy 2015-05-05 10:10:50 +10:00
Régis Hanol 90c05ff045 FIX: two-column poll 2015-05-04 22:29:45 +02:00
Gerhard Schlager 409a367ab7 Replace all occurrences of totalVotes 2015-05-04 16:20:13 +02:00
Régis Hanol 86d7412f30 REFACTOR: rename "total_votes" poll field to the more accurate "voters"
FEATURE: automagically load plugin's migrations
2015-05-04 16:01:57 +02:00
Sam c3e3afcb2c PERF: eliminate N+1 query due to polls 2015-05-04 16:12:03 +10:00
Sam 803feefd54 MessageBus handles readonly redis now, no need to wrap it 2015-05-04 12:21:00 +10:00
Régis Hanol 44bf8fc7f7 Merge pull request #3423 from gschlager/polls-refactor
Extract the parsing of polls
2015-05-03 19:50:58 +02:00
Gerhard Schlager 9bc750e43d Extract the parsing of polls 2015-05-02 23:44:45 +02:00
Gerhard Schlager c9e4fd578d FIX: closed polls with no votes showed NaN as percentage and average 2015-05-02 01:58:23 +02:00
Régis Hanol 2954c99a1e FEATURE: new 'poll_maximum_options' site setting to limit the number of options in a poll 2015-05-01 16:44:51 +02:00
Régis Hanol f83638c154 FIX: check the selected options when casting a vote 2015-05-01 16:33:24 +02:00
Régis Hanol 9106331d4f FIX: 'migrate_old_poll' rake task to support options with HTML 2015-05-01 15:53:02 +02:00
Régis Hanol e9b70ac9cb FIX: migrate old polls rake task 2015-04-30 17:08:44 +02:00
Régis Hanol 202b442b86 FEATURE: new 'poll:migrate_old_polls' rake task 2015-04-29 23:34:40 +02:00