c9dab6fd08
DEV: Automatically require 'rails_helper' in all specs ( #16077 )
...
It's very easy to forget to add `require 'rails_helper'` at the top of every core/plugin spec file, and omissions can cause some very confusing/sporadic errors.
By setting this flag in `.rspec`, we can remove the need for `require 'rails_helper'` entirely.
2022-03-01 17:50:50 +00:00
6f6406ea03
DEV: Fix random typos ( #16066 )
2022-02-28 10:20:58 +08:00
0b34d5ac6c
UX: Maximize the preview space in composer ( #15188 )
...
A follow-up to #15117 and #15141 . Applies the previous changes to PM-specific fields, makes the preview area take the all the available height of the composer, and unifies more spacing between composer elements.
2021-12-24 12:38:33 +01:00
a6230b8138
UX: Improve composer presence-display positioning ( #15235 )
...
Previously the discourse-presence plugin was using a `position: absolute` hack to display the 'replying...' users in the top right of the composer. This commit adds a more suitable plugin outlet, and updates the discourse-presence styling so it slots into the flex-box layout at the top of the composer
2021-12-08 16:18:49 +00:00
2eb162e25b
FEATURE: Show user cards for 'replying...' users ( #15142 )
...
Also removes some unneeded parameters from the `avatar` helper.
2021-11-30 18:57:57 +00:00
906a71a607
DEV: Fix linting issues in core plugins ( #14916 )
2021-11-13 15:31:42 +01:00
4ad77f3382
DEV: Remove `.es6` extensions from core ( #14912 )
...
Still supported in plugins though.
2021-11-13 12:51:53 +01:00
8063489dc9
FIX: Include admins in presence reply channel permissions ( #14839 )
...
Admins can see all regular topics, regardless of category permissions
2021-11-08 13:54:02 +00:00
d162229758
DEV: Replace `equal()` with `strictEqual()` ( #14827 )
2021-11-08 10:26:28 +01:00
6894b3f3af
Update translations ( #14792 )
2021-11-02 18:49:00 +01:00
79ad0860a2
FIX: Cleanup PresenceChannel instances when composer closed ( #14741 )
...
I was previously relying on `this.isDestroying` returning `true` during `willDestroyElement`. This was an incorrect assumption.
This commit refactors the logic into an explicit `cleanup` function, and also adds some cleanup for empty keys in the `subscribedProxy` array
2021-10-27 15:17:10 +01:00
b57b079ff2
DEV: Update discourse-presence plugin to use new PresenceChannel system ( #14519 )
...
This removes all custom controllers and redis/messagebus logic from discourse-presence, and replaces it with core's new PresenceChannel system.
All functionality should be retained. This implementation should scale much better to large numbers of users, reduce the number of HTTP requests made by clients, and reduce the volume of messages on the MessageBus.
For more information on PresenceChannel, see 31db8352
2021-10-21 12:42:46 +01:00
0f5d737a61
Update translations ( #14513 )
2021-10-05 15:59:26 +02:00
c995b20ca4
Update translations ( #14063 )
2021-08-24 15:25:44 +02:00
5eb4e642a6
DEV: Rename discourse-presence endpoints and messagebus channels ( #14089 )
...
We are working to introduce a general core API for presence, which will clash with this plugin's `/presence` namespace
This commit introduces no functional change. There may be a slight interruption in discourse-presence functionality during a deploy of this commit.
2021-08-19 13:04:31 +01:00
0e53769f71
Update translations ( #13994 )
2021-08-14 10:18:05 +02:00
28b5e6e47d
Update translations ( #13796 )
2021-07-21 10:30:34 +02:00
5f7e60d9dc
discourse/discourse change from 'master' to 'main'
2021-07-19 11:46:15 -04:00
53fe8b2e77
Update translations ( #13647 )
2021-07-13 20:30:09 +02:00
252dd169a4
Update translations ( #13476 )
2021-06-22 15:21:20 +02:00
59097b207f
DEV: Correct typos and spelling mistakes ( #12812 )
...
Over the years we accrued many spelling mistakes in the code base.
This PR attempts to fix spelling mistakes and typos in all areas of the code that are extremely safe to change
- comments
- test descriptions
- other low risk areas
2021-05-21 11:43:47 +10:00
55611a5b80
Update translations ( #13089 )
2021-05-18 16:49:18 +02:00
8ac184c636
Update translations ( #13088 )
2021-05-18 15:11:41 +02:00
f9bb6399e0
DEV: Remove SCSS color vars fallbacks ( #13035 )
...
They are no longer needed.
2021-05-12 08:56:15 -04:00
21c301aa72
Update translations ( #13030 )
2021-05-11 19:01:59 +02:00
d45c7973f9
Update translations ( #12940 )
2021-05-04 16:34:37 +02:00
3b2f2b533f
Update translations ( #12851 )
2021-04-27 16:01:06 +02:00
984d87f30c
UX: stop presence indicator hop, space consistency ( #12797 )
2021-04-22 16:11:47 -04:00
93f74add7d
Update translations ( #12614 )
2021-04-07 11:58:41 +02:00
bc88ea5976
Update translations ( #12412 )
2021-03-16 15:49:29 +01:00
bd709c89a7
FIX: Unsubscribe from topic presence when navigating between topics ( #12198 )
...
This PR fixes a bug where if you navigate from topic to another one (via suggested topics, notifications etc.), the previous topic is not unsubscribed from presence manager, which means if you visit lots of topics all the subscriptions will accumulate and can cause rate limit errors.
This bug is exposed by the loading slider we're currently experimenting with on Meta because we no longer have an intermediate state when navigating between topics which means the `willDestroyElement` hook that's responsible for unsubscribing is not called.
2021-02-24 23:14:38 +03:00
2757003ef1
Update translations ( #12186 )
2021-02-23 15:10:04 +01:00
f283bde25a
Update translations ( #12097 )
2021-02-16 15:24:37 +01:00
b3fa521bf4
Update translations ( #12019 )
2021-02-09 14:56:15 +01:00
3c028cb67f
Update translations ( #11848 )
2021-01-26 14:52:35 +01:00
0e8c155b70
Update translations ( #11779 )
2021-01-20 22:58:26 +01:00
0e8e3f4813
Update translations ( #11689 )
2021-01-12 14:29:05 +01:00
09f9d4b281
Update translations ( #11601 )
2020-12-29 19:44:53 +01:00
e113ddc73c
Update translations ( #11557 )
2020-12-22 14:49:40 +01:00
47fa3cf864
Update translations ( #11492 )
2020-12-15 15:25:10 +01:00
bbe5d8d5cf
DEV: Sort imports alphabetically ( #11382 )
2020-12-01 15:31:26 -03:00
d7bd9aa3d0
Update translations ( #11385 )
2020-12-01 14:34:25 +01:00
7fecad41db
Update translations ( #11264 )
2020-11-17 14:49:58 +01:00
9904a007c5
Update translations ( #11182 )
2020-11-10 15:23:06 +01:00
886d619d3f
Update translations ( #11108 )
2020-11-03 18:08:07 +01:00
9648122b51
Update translations ( #11042 )
2020-10-27 15:36:21 +01:00
b5933e2b49
Update translations ( #10970 )
2020-10-20 15:34:57 +02:00
7eef10c6d7
Update translations ( #10944 )
2020-10-17 00:07:21 +02:00
7adf71a203
Fix i18n issues reported on Crowdin ( #10925 )
...
* Pluralize `discourse_narrative_bot.dice.not_enough_dice`
The number of dice requires a pluralized string.
Fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/278/en-ar#51346
* Always use "two-factor" instead of "second factor" or "two factor"
Using different terms for the same thing is quite confusing.
Fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-nl#40096
* Remove whitespace before ellipsis for consistency
Fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-nl#53978
* Remove unused strings from locale file
* Correct grammar in `site_settings.review_media_unless_trust_level`
Fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/248/en-nl#54018
* Correct grammar in `reviewables.reasons.contains_media`
Fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/248/en-nl#54020
* Correct grammar in user notifications
It also adds a link to the /about page in order to give the user a clue who the site admins are.
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/248/en-nl#54084
* Use "log in" instead of "login" when it's a verb
This fixes multiple issues:
* https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-nl#40940
* https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/248/en-nl#47858
* https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/248/en-nl#49458
* Replace "Github" with "GitHub"
* Remove "discourse.org" from title of 503 error page
* Replace weirdly formatted multi line string
* Pluralize `js.composer.group_mentioned_limit`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#41158
* Remove unused string and pluralize `js.topic.feature_topic.confirm_pin_globally`
This kinda fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#42114 as `js.topic.feature_topic.confirm_pin` wasn't used anymore.
* Pluralize `js.user.second_factor_backup.remaining_codes`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#40054
* Pluralize `js.composer.error.tags_missing`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#41184
* Pluralize `js.post.errors.too_many_dragged_and_dropped_files`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#42408
* Remove unused `js.posts_long` and `js.likes_long`
This fixes the following issues in an unexpected way:
* https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#42974
* https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#42994
* Pluralize `js.bootstrap_mode_enabled`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#38726
* Remove unused `long_form` from `post_action_types`
This more or less fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/248/en-ar#47158
* Pluralize `js.presence.replying` and `js.presence.replying`
This fixes the following issues:
* https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/282/en-ar#51588
* https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/282/en-ar#51590
* Pluralize `js.user.second_factor_backup.manage`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#40044
* Stop using concatenated strings for "Recently Used Devices"
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#40308
* Pluralize `js.category_row.topic_count`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#41056
* Pluralize `js.select_kit.invalid_selection_length`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#41072
* Pluralize `js.notifications.membership_request_consolidated`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#41416
2020-10-16 15:24:58 +02:00
85894537b1
Update translations
2020-10-13 15:40:37 +02:00
David Taylor
Jarek Radosz
Discourse Translator Bot
Michael Brown
Josh Soref
Penar Musaraj
Kris
Osama Sayegh
Roman Rizzi
Gerhard Schlager